mptcp: refactor token container
Subsystems (3)
Paolo Abeni
maintainerv2 cover mptcp: refactor token container
Currently the msk sockets are stored in a single radix tree, protected by a global spin_lock. This series moves to an hash table, allocated at boot time, with per bucker spin_lock - alike inet_hashtables, but using a different key:
the token itself.
The above improves scalability, as write operations will have a far later chance to compete for lock acquisition, allows lockless lookup, and will allow easier msk traversing - e.g. for diag interface implementation's sake.
This also introduces trivial, related, kunit tests and move the existing in kernel's one to kunit.
v1 -> v2:
- fixed a few extra and sparse warns
Paolo Abeni (4):
mptcp: add __init annotation on setup functions
mptcp: refactor token container
mptcp: move crypto test to KUNIT
mptcp: introduce token KUNIT self-tests
net/mptcp/Kconfig | 20 ++- net/mptcp/Makefile | 4 + net/mptcp/crypto.c | 63 +-------- net/mptcp/crypto_test.c | 72 +++++++++++ net/mptcp/pm.c | 2 +- net/mptcp/pm_netlink.c | 2 +- net/mptcp/protocol.c | 49 ++++--- net/mptcp/protocol.h | 24 ++-- net/mptcp/subflow.c | 21 ++- net/mptcp/token.c | 280 ++++++++++++++++++++++++++++------------ net/mptcp/token_test.c | 140 ++++++++++++++++++++ 11 files changed, 487 insertions(+), 190 deletions(-) create mode 100644 net/mptcp/crypto_test.c create mode 100644 net/mptcp/token_test.c
Signature · 1 line
2.26.2
Paolo Abeni
maintainerPATCH v2 1/4 mptcp: add __init annotation on setup functions
Add the missing annotation in some setup-only
functions.
--- net/mptcp/pm.c | 2 +- net/mptcp/pm_netlink.c | 2 +- net/mptcp/protocol.c | 4 ++-- net/mptcp/protocol.h | 10 +++++----- net/mptcp/subflow.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)
net/mptcp/pm.c +1 -1
@@ -234,7 +234,7 @@ void mptcp_pm_close(struct mptcp_sock *msk)sock_put ((struct sock *)msk); } -void mptcp_pm_init (void ) +void __init mptcp_pm_init (void ) { pm_wq =alloc_workqueue ("pm_wq" ,WQ_UNBOUND |WQ_MEM_RECLAIM ,8 );if (!pm_wq)
net/mptcp/pm_netlink.c +1 -1
@@ -851,7 +851,7 @@ static struct pernet_operations mptcp_pm_pernet_ops = { .size = sizeof(struct pm_nl_pernet), }; -void mptcp_pm_nl_init (void ) +void __init mptcp_pm_nl_init (void ) {if (register_pernet_subsys (&mptcp_pm_pernet_ops) <0 )panic ("Failed to register MPTCP PM pernet subsystem.\n" );
net/mptcp/protocol.c +2 -2
@@ -2077,7 +2077,7 @@ static struct inet_protosw mptcp_protosw = { .flags = INET_PROTOSW_ICSK, }; -void mptcp_proto_init (void ) +void __init mptcp_proto_init (void ) { mptcp_prot.h.hashinfo = tcp_prot.h.hashinfo;
@@ -2139,7 +2139,7 @@ static struct inet_protosw mptcp_v6_protosw = { .flags = INET_PROTOSW_ICSK, }; -int mptcp_proto_v6_init (void ) +int __init mptcp_proto_v6_init (void ) {int err;
net/mptcp/protocol.h +5 -5
@@ -337,7 +337,7 @@ mptcp_subflow_get_mapped_dsn(const struct mptcp_subflow_context *subflow)int mptcp_is_enabled (struct net *net);bool mptcp_subflow_data_available (struct sock *sk); -void mptcp_subflow_init (void ); +void __init mptcp_subflow_init (void );/* called with sk socket lock held */ int __mptcp_subflow_connect(struct sock *sk, int ifindex,
@@ -355,9 +355,9 @@ static inline void mptcp_subflow_tcp_fallback(struct sock *sk,inet_csk (sk)->icsk_af_ops = ctx->icsk_af_ops; } -void mptcp_proto_init (void ); +void __init mptcp_proto_init (void );#if IS_ENABLED (CONFIG_MPTCP_IPV6 ) -int mptcp_proto_v6_init (void ); +int __init mptcp_proto_v6_init (void );#endif struct sock *mptcp_sk_clone(const struct sock *sk,
@@ -394,7 +394,7 @@ static inline void mptcp_crypto_key_gen_sha(u64 *key, u32 *token, u64 *idsn)void mptcp_crypto_hmac_sha (u64 key1,u64 key2,u8 *msg,int len,void *hmac); -void mptcp_pm_init (void ); +void __init mptcp_pm_init (void );void mptcp_pm_data_init (struct mptcp_sock *msk);void mptcp_pm_close (struct mptcp_sock *msk);void mptcp_pm_new_connection (struct mptcp_sock *msk,int server_side);
@@ -428,7 +428,7 @@ bool mptcp_pm_addr_signal(struct mptcp_sock *msk, unsigned int remaining, struct mptcp_addr_info *saddr);int mptcp_pm_get_local_id (struct mptcp_sock *msk,struct sock_common *skc); -void mptcp_pm_nl_init (void ); +void __init mptcp_pm_nl_init (void );void mptcp_pm_nl_data_init (struct mptcp_sock *msk);void mptcp_pm_nl_fully_established (struct mptcp_sock *msk);void mptcp_pm_nl_subflow_established (struct mptcp_sock *msk);
net/mptcp/subflow.c +1 -1
@@ -1255,7 +1255,7 @@ static int subflow_ops_init(struct request_sock_ops *subflow_ops)return 0 ; } -void mptcp_subflow_init (void ) +void __init mptcp_subflow_init (void ) { subflow_request_sock_ops = tcp_request_sock_ops;if (subflow_ops_init (&subflow_request_sock_ops) !=0 )
Signature · 1 line
2.26.2
Paolo Abeni
maintainerPATCH v2 2/4 mptcp: refactor token container
In reply to Paolo AbeniReplace the radix tree with a hash table allocated at boot time. The radix tree has some shortcoming:
a single lock is contented by all the mptcp operation, the lookup currently use such lock, and traversing all the items would require a lock, too.
With hash table instead we trade a little memory to address all the above - a per bucket lock is used.
To hash the MPTCP sockets, we re-use the msk' sk_node
entry: the MPTCP sockets are never hashed by the stack. Replace the existing hash proto callbacks with a dummy implementation, annotating the above constraint.
Additionally refactor the token creation to code to:
- limit the number of consecutive attempts to a fixed maximum. Hitting a hash bucket with a long chain is considered a failed attempt
- accept() no longer can fail to token management.
- if token creation fails at connect() time, we do fallback to TCP (before the connection was closed)
v1 -> v2:
- fix "no newline at end of file" - Jakub
--- net/mptcp/protocol.c | 45 ++++--- net/mptcp/protocol.h | 14 ++- net/mptcp/subflow.c | 19 ++- net/mptcp/token.c | 271 ++++++++++++++++++++++++++++++------------- 4 files changed, 236 insertions(+), 113 deletions(-)
net/mptcp/protocol.c +26 -19
@@ -1448,20 +1448,6 @@ struct sock *mptcp_sk_clone(const struct sock *sk, msk->token = subflow_req->token; msk->subflow =NULL ; -if (unlikely (mptcp_token_new_accept (subflow_req->token, nsk))) { - nsk->sk_state =TCP_CLOSE ; -bh_unlock_sock (nsk); - -/* we can't call into mptcp_close() here - possible BH context -* free the sock directly. -* sk_clone_lock() sets nsk refcnt to two, hence call sk_free() -* too. -*/ -sk_common_release (nsk); -sk_free (nsk); -return NULL ; - } - msk->write_seq = subflow_req->idsn +1 ;atomic64_set (&msk->snd_una, msk->write_seq);if (mp_opt->mp_capable) {
@@ -1547,7 +1533,7 @@ static void mptcp_destroy(struct sock *sk) {struct mptcp_sock *msk =mptcp_sk (sk); -mptcp_token_destroy (msk->token); +mptcp_token_destroy (msk);if (msk->cached_ext)__skb_ext_put (msk->cached_ext);
@@ -1636,6 +1622,20 @@ static void mptcp_release_cb(struct sock *sk) } } +static int mptcp_hash (struct sock *sk) +{ +/* should never be called, +* we hash the TCP subflows not the master socket +*/ +WARN_ON_ONCE (1 ); +return 0 ; +} + +static void mptcp_unhash (struct sock *sk) +{ +/* called from sk_common_release(), but nothing to do here */ +} +static int mptcp_get_port (struct sock *sk,unsigned short snum) {struct mptcp_sock *msk =mptcp_sk (sk);
@@ -1679,7 +1679,6 @@ void mptcp_finish_connect(struct sock *ssk)*/ WRITE_ONCE (msk->remote_key, subflow->remote_key);WRITE_ONCE (msk->local_key, subflow->local_key); -WRITE_ONCE (msk->token, subflow->token);WRITE_ONCE (msk->write_seq, subflow->idsn +1 );WRITE_ONCE (msk->ack_seq, ack_seq);WRITE_ONCE (msk->can_ack,1 );
@@ -1761,8 +1760,8 @@ static struct proto mptcp_prot = { .sendmsg = mptcp_sendmsg, .recvmsg = mptcp_recvmsg, .release_cb = mptcp_release_cb, - .hash = inet_hash, - .unhash = inet_unhash, + .hash = mptcp_hash, + .unhash = mptcp_unhash, .get_port = mptcp_get_port, .sockets_allocated = &mptcp_sockets_allocated, .memory_allocated = &tcp_memory_allocated,
@@ -1771,6 +1770,7 @@ static struct proto mptcp_prot = { .sysctl_wmem_offset = offsetof(struct net, ipv4.sysctl_tcp_wmem), .sysctl_mem = sysctl_tcp_mem, .obj_size = sizeof(struct mptcp_sock), + .slab_flags = SLAB_TYPESAFE_BY_RCU, .no_autobind = true, };
@@ -1800,6 +1800,7 @@ static int mptcp_stream_connect(struct socket *sock, struct sockaddr *uaddr, int addr_len, int flags) {struct mptcp_sock *msk =mptcp_sk (sock->sk); +struct mptcp_subflow_context *subflow;struct socket *ssock;int err;
@@ -1812,19 +1813,23 @@ static int mptcp_stream_connect(struct socket *sock, struct sockaddr *uaddr, goto do_connect; } +mptcp_token_destroy (msk); ssock =__mptcp_socket_create (msk,TCP_SYN_SENT );if (IS_ERR (ssock)) { err =PTR_ERR (ssock); goto unlock; } + subflow =mptcp_subflow_ctx (ssock->sk);#ifdef CONFIG_TCP_MD5SIG /* no MPTCP if MD5SIG is enabled on this socket or we may run out of * TCP option space. */ if (rcu_access_pointer (tcp_sk (ssock->sk)->md5sig_info)) -mptcp_subflow_ctx (ssock->sk)->request_mptcp =0 ; + subflow->request_mptcp =0 ;#endif +if (subflow->request_mptcp &&mptcp_token_new_connect (ssock->sk)) + subflow->request_mptcp =0 ; do_connect: err = ssock->ops->connect (ssock, uaddr, addr_len, flags);
@@ -1888,6 +1893,7 @@ static int mptcp_listen(struct socket *sock, int backlog)pr_debug ("msk=%p" , msk);lock_sock (sock->sk); +mptcp_token_destroy (msk); ssock =__mptcp_socket_create (msk,TCP_LISTEN );if (IS_ERR (ssock)) { err =PTR_ERR (ssock);
@@ -2086,6 +2092,7 @@ void __init mptcp_proto_init(void)mptcp_subflow_init ();mptcp_pm_init (); +mptcp_token_init ();if (proto_register (&mptcp_prot,1 ) !=0 )panic ("Failed to register MPTCP proto.\n" );
net/mptcp/protocol.h +11 -3
@@ -250,6 +250,7 @@ struct mptcp_subflow_request_sock {u32 local_nonce;u32 remote_nonce;struct mptcp_sock *msk; +struct hlist_nulls_node token_node; }; static inline struct mptcp_subflow_request_sock *
@@ -372,12 +373,19 @@ bool mptcp_finish_join(struct sock *sk);void mptcp_data_acked (struct sock *sk);void mptcp_subflow_eof (struct sock *sk); +void __init mptcp_token_init (void ); +static inline void mptcp_token_init_request (struct request_sock *req) +{ +mptcp_subflow_rsk (req)->token_node.pprev =NULL ; +} +int mptcp_token_new_request (struct request_sock *req); -void mptcp_token_destroy_request (u32 token); +void mptcp_token_destroy_request (struct request_sock *req);int mptcp_token_new_connect (struct sock *sk); -int mptcp_token_new_accept (u32 token,struct sock *conn); +void mptcp_token_accept (struct mptcp_subflow_request_sock *r, +struct mptcp_sock *msk);struct mptcp_sock *mptcp_token_get_sock (u32 token); -void mptcp_token_destroy (u32 token); +void mptcp_token_destroy (struct mptcp_sock *msk);void mptcp_crypto_key_sha (u64 key,u32 *token,u64 *idsn);static inline void mptcp_crypto_key_gen_sha (u64 *key,u32 *token,u64 *idsn)
net/mptcp/subflow.c +7 -12
@@ -32,12 +32,9 @@ static void SUBFLOW_REQ_INC_STATS(struct request_sock *req,static int subflow_rebuild_header (struct sock *sk) {struct mptcp_subflow_context *subflow =mptcp_subflow_ctx (sk); -int local_id, err =0 ; +int local_id; -if (subflow->request_mptcp && !subflow->token) { -pr_debug ("subflow=%p" , sk); - err =mptcp_token_new_connect (sk); - }else if (subflow->request_join && !subflow->local_nonce) { +if (subflow->request_join && !subflow->local_nonce) {struct mptcp_sock *msk = (struct mptcp_sock *)subflow->conn;pr_debug ("subflow=%p" , sk);
@@ -57,9 +54,6 @@ static int subflow_rebuild_header(struct sock *sk) } out: -if (err) -return err; -return subflow->icsk_af_ops->rebuild_header (sk); }
@@ -72,8 +66,7 @@ static void subflow_req_destructor(struct request_sock *req)if (subflow_req->msk)sock_put ((struct sock *)subflow_req->msk); -if (subflow_req->mp_capable) -mptcp_token_destroy_request (subflow_req->token); +mptcp_token_destroy_request (req); tcp_request_sock_ops.destructor (req); }
@@ -135,6 +128,7 @@ static void subflow_init_req(struct request_sock *req, subflow_req->mp_capable =0 ; subflow_req->mp_join =0 ; subflow_req->msk =NULL ; +mptcp_token_init_request (req);#ifdef CONFIG_TCP_MD5SIG /* no MPTCP if MD5SIG is enabled on this socket or we may run out of
@@ -250,7 +244,7 @@ static void subflow_finish_connect(struct sock *sk, const struct sk_buff *skb) subflow->remote_nonce = mp_opt.nonce;pr_debug ("subflow=%p, thmac=%llu, remote_nonce=%u" , subflow, subflow->thmac, subflow->remote_nonce); - }else if (subflow->request_mptcp) { + }else { tp->is_mptcp =0 ; }
@@ -386,7 +380,7 @@ static void mptcp_sock_destruct(struct sock *sk)sock_orphan (sk); } -mptcp_token_destroy (mptcp_sk (sk)->token); +mptcp_token_destroy (mptcp_sk (sk));inet_sock_destruct (sk); }
@@ -505,6 +499,7 @@ static struct sock *subflow_syn_recv_sock(const struct sock *sk,*/ new_msk->sk_destruct = mptcp_sock_destruct;mptcp_pm_new_connection (mptcp_sk (new_msk),1 ); +mptcp_token_accept (subflow_req,mptcp_sk (new_msk)); ctx->conn = new_msk; new_msk =NULL ;
net/mptcp/token.c +192 -79
332 lines not on this page · raw message
Signature · 1 line
2.26.2
Paolo Abeni
maintainerPATCH v2 3/4 mptcp: move crypto test to KUNIT
In reply to Paolo Abenicurrently MPTCP uses a custom hook to executed unit tests at boot time. Let's use the KUNIT framework instead. Additionally move the relevant code to a separate file and export the function needed by the test when self-tests are build as a module.
--- net/mptcp/Kconfig | 20 ++++++++---- net/mptcp/Makefile | 3 ++ net/mptcp/crypto.c | 63 ++---------------------------------- net/mptcp/crypto_test.c | 72 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 67 deletions(-) create mode 100644 net/mptcp/crypto_test.c
net/mptcp/Kconfig +14 -6
@@ -18,12 +18,20 @@ config MPTCP_IPV6 select IPV6 default y -config MPTCP_HMAC_TEST - bool "Tests for MPTCP HMAC implementation" +endif + +config MPTCP_KUNIT_TESTS + tristate "This builds the MPTCP KUnit tests" if !KUNIT_ALL_TESTS + select MPTCP + depends on KUNIT + default KUNIT_ALL_TESTS help - This option enable boot time self-test for the HMAC implementation - used by the MPTCP code + Currently covers the MPTCP crypto helpers. + Only useful for kernel devs running KUnit test harness and are not + for inclusion into a production build. - Say N if you are unsure. + For more information on KUnit and unit tests in general please refer + to the KUnit documentation in Documentation/dev-tools/kunit/. + + If unsure, say N. -endif
net/mptcp/Makefile +3 -0
@@ -3,3 +3,6 @@ obj-$(CONFIG_MPTCP) += mptcp.o mptcp-y := protocol.o subflow.o options.o token.o crypto.o ctrl.o pm.o diag.o \ mib.o pm_netlink.o + +mptcp_crypto_test-objs := crypto_test.o +obj-$(CONFIG_MPTCP_KUNIT_TESTS) += mptcp_crypto_test.o
net/mptcp/crypto.c +2 -61
67 lines not on this page · raw message
net/mptcp/crypto_test.c new file +72 -0
72 lines not on this page · raw message
Signature · 1 line
2.26.2
Paolo Abeni
maintainerPATCH v2 4/4 mptcp: introduce token KUNIT self-tests
In reply to Paolo AbeniUnit tests for the internal MPTCP token APIs, using KUNIT
v1 -> v2:
- use the correct RCU annotation when initializing icsk ulp
- fix a few checkpatch issues
--- net/mptcp/Kconfig | 2 +- net/mptcp/Makefile | 3 +- net/mptcp/token.c | 9 +++ net/mptcp/token_test.c | 140 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 152 insertions(+), 2 deletions(-) create mode 100644 net/mptcp/token_test.c
net/mptcp/Kconfig +1 -1
@@ -26,7 +26,7 @@ config MPTCP_KUNIT_TESTS depends on KUNIT default KUNIT_ALL_TESTS help - Currently covers the MPTCP crypto helpers. + Currently covers the MPTCP crypto and token helpers. Only useful for kernel devs running KUnit test harness and are not for inclusion into a production build.
net/mptcp/Makefile +2 -1
@@ -5,4 +5,5 @@ mptcp-y := protocol.o subflow.o options.o token.o crypto.o ctrl.o pm.o diag.o \ mib.o pm_netlink.o mptcp_crypto_test-objs := crypto_test.o -obj-$(CONFIG_MPTCP_KUNIT_TESTS) += mptcp_crypto_test.o +mptcp_token_test-objs := token_test.o +obj-$(CONFIG_MPTCP_KUNIT_TESTS) += mptcp_crypto_test.o mptcp_token_test.o
net/mptcp/token.c +9 -0
@@ -307,3 +307,12 @@ void __init mptcp_token_init(void)spin_lock_init (&token_hash[i].lock); } } + +#if IS_MODULE (CONFIG_MPTCP_KUNIT_TESTS ) +EXPORT_SYMBOL_GPL (mptcp_token_new_request); +EXPORT_SYMBOL_GPL (mptcp_token_new_connect); +EXPORT_SYMBOL_GPL (mptcp_token_accept); +EXPORT_SYMBOL_GPL (mptcp_token_get_sock); +EXPORT_SYMBOL_GPL (mptcp_token_destroy_request); +EXPORT_SYMBOL_GPL (mptcp_token_destroy); +#endif
net/mptcp/token_test.c new file +140 -0
140 lines not on this page · raw message
Signature · 1 line
2.26.2
Re: [MPTCP] [PATCH net-next v2 1/4] mptcp: add __init annotation on setup functions
In reply to Paolo AbeniQuoted 11 lines · Paolo Abeni
Add the missing annotation in some setup-only
functions.Signed-off-by Paolo Abeni <pabeni(a)redhat.com>---
net/mptcp/pm.c | 2 +- net/mptcp/pm_netlink.c | 2 +- net/mptcp/protocol.c | 4 ++-- net/mptcp/protocol.h | 10 +++++----- net/mptcp/subflow.c | 2 +- 5 files changed, 10 insertions(+), 10 deletions(-)
--
Mat Martineau
Intel
Quoted 28 lines · Paolo Abeni
Replace the radix tree with a hash table allocated at boot time. The radix tree has some shortcoming:
a single lock is contented by all the mptcp operation, the lookup currently use such lock, and traversing all the items would require a lock, too.With hash table instead we trade a little memory to address all the above - a per bucket lock is used.
To hash the MPTCP sockets, we re-use the msk'
sk_node
entry: the MPTCP sockets are never hashed by the stack. Replace the existing hash proto callbacks with a dummy implementation, annotating the above constraint.Additionally refactor the token creation to code to:
- limit the number of consecutive attempts to a fixed maximum. Hitting a hash bucket with a long chain is considered a failed attempt
-
accept()no longer can fail to token management.- if token creation fails at
connect()time, we do fallback to TCP (before the connection was closed)v1 -> v2:
- fix "no newline at end of file" - Jakub
Quoted 7 lines
Signed-off-by Paolo Abeni <pabeni(a)redhat.com>---
net/mptcp/protocol.c | 45 ++++--- net/mptcp/protocol.h | 14 ++- net/mptcp/subflow.c | 19 ++- net/mptcp/token.c | 271 ++++++++++++++++++++++++++++++------------- 4 files changed, 236 insertions(+), 113 deletions(-)
--
Mat Martineau
Intel
Re: [MPTCP] [PATCH net-next v2 3/4] mptcp: move crypto test to KUNIT
In reply to Paolo AbeniQuoted 9 lines · Paolo Abeni
currently MPTCP uses a custom hook to executed unit tests at boot time. Let's use the KUNIT framework instead. Additionally move the relevant code to a separate file and export the function needed by the test when self-tests are build as a module.
Co-developed-by Matthieu Baerts <matthieu.baerts(a)tessares.net>Signed-off-by Matthieu Baerts <matthieu.baerts(a)tessares.net>Signed-off-by Paolo Abeni <pabeni(a)redhat.com>
Quoted 7 lines
---
net/mptcp/Kconfig | 20 ++++++++---- net/mptcp/Makefile | 3 ++ net/mptcp/crypto.c | 63 ++---------------------------------- net/mptcp/crypto_test.c | 72 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 91 insertions(+), 67 deletions(-)create mode 100644
net/mptcp/crypto_test.c
--
Mat Martineau
Intel
Re: [MPTCP] [PATCH net-next v2 4/4] mptcp: introduce token KUNIT self-tests
In reply to Paolo AbeniQuoted 6 lines · Paolo Abeni
Unit tests for the internal MPTCP token APIs, using KUNIT
v1 -> v2:
- use the correct RCU annotation when initializing icsk ulp
- fix a few checkpatch issues
Quoted 8 lines
Signed-off-by Paolo Abeni <pabeni(a)redhat.com>---
net/mptcp/Kconfig | 2 +- net/mptcp/Makefile | 3 +- net/mptcp/token.c | 9 +++ net/mptcp/token_test.c | 140 +++++++++++++++++++++++++++++++++++++++++ 4 files changed, 152 insertions(+), 2 deletions(-)create mode 100644
net/mptcp/token_test.c
--
Mat Martineau
Intel
David Miller
maintainerFrom: Paolo Abeni <pabeni(a)redhat.com>
Date: Fri, 26 Jun 2020 19:29:58 +0200
Quoted 9 lines
Currently the msk sockets are stored in a single radix tree, protected by a global
spin_lock. This series moves to an hash table, allocated at boot time, with per buckerspin_lock- alikeinet_hashtables, but using a different key:
the token itself.The above improves scalability, as write operations will have a far later chance to compete for lock acquisition, allows lockless lookup, and will allow easier msk traversing - e.g. for diag interface implementation's sake.
Quoted 5 lines
This also introduces trivial, related, kunit tests and move the existing in kernel's one to kunit.
v1 -> v2:
- fixed a few extra and sparse warns
Series applied, thanks Paolo.