Skip to contentSkip to conversation

Enable 1165522 Errata for Neovers

PATCH In review Bertrand Marquis 2 participants 8 messages Aug 18, 2020 – Aug 20, 2020

lore
Share & tools
lore
#0 lore raw

cover Enable 1165522 Errata for Neovers

This patch serie is adding Neoverse N1 processor identification and enabling the processor errata 1165522 for Neoverse N1 processors.

Bertrand Marquis (2):
arm: Add Neoverse N1 processor identifation
xen/arm: Enable CPU Errata 1165522 for Neoverse

 xen/arch/arm/cpuerrata.c        | 8 +++++++-
 xen/include/asm-arm/processor.h | 2 ++
 2 files changed, 9 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/2 arm: Add Neoverse N1 processor identifation

Add MIDR and CPU part numbers for Neoverse N1

---
 xen/include/asm-arm/processor.h | 2 ++
 1 file changed, 2 insertions(+)
xen/include/asm-arm/processor.h +2 -0
index aa642e3ab2..3ca67f8157 100644
@@ -58,6 +58,7 @@
 #define ARM_CPU_PART_CORTEX_A73     0xD09
 #define ARM_CPU_PART_CORTEX_A75     0xD0A
 #define ARM_CPU_PART_CORTEX_A76     0xD0B
+#define ARM_CPU_PART_NEOVERSE_N1    0xD0C
 
 #define MIDR_CORTEX_A12 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A12)
 #define MIDR_CORTEX_A17 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A17)
@@ -68,6 +69,7 @@
 #define MIDR_CORTEX_A73 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A73)
 #define MIDR_CORTEX_A75 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A75)
 #define MIDR_CORTEX_A76 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_CORTEX_A76)
+#define MIDR_NEOVERSE_N1 MIDR_CPU_MODEL(ARM_CPU_IMP_ARM, ARM_CPU_PART_NEOVERSE_N1)
 
 /* MPIDR Multiprocessor Affinity Register */
 #define _MPIDR_UP           (30)
Signature · 1 line
2.17.1
#3 lore raw

Re: [PATCH 1/2] arm: Add Neoverse N1 processor identifation

Quoted 7 lines · Julien Grall

Hi Bertrand,

Title: s/identifation/identification/

oh yes sorry :-)

Quoted 9 lines · Bertrand Marquis
Quoted 2 lines

Add MIDR and CPU part numbers for Neoverse N1

I can fix the typo on commit:

Thanks
Bertrand

Quoted 4 lines

Cheers,

Signature · 1 line
Julien Grall
#4 lore raw

PATCH 2/2 xen/arm: Enable CPU Errata 1165522 for Neoverse

In reply to Bertrand Marquis

Enable CPU errata of Speculative AT on the Neoverse N1 processor versions r0p0 to r2p0.
Also Fix Cortex A76 Errata string which had a wrong errata number.

---
 xen/arch/arm/cpuerrata.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
xen/arch/arm/cpuerrata.c +7 -1
index 0248893de0..6c09017515 100644
@@ -476,9 +476,15 @@ static const struct arm_cpu_capabilities arm_errata[] = {
         .matches = has_ssbd_mitigation,
     },
 #endif
+    {
+        /* Neoverse r0p0 - r2p0 */
+        .desc = "ARM erratum 1165522",
+        .capability = ARM64_WORKAROUND_AT_SPECULATE,
+        MIDR_RANGE(MIDR_NEOVERSE_N1, 0, 2 << MIDR_VARIANT_SHIFT),
+    },
     {
         /* Cortex-A76 r0p0 - r2p0 */
-        .desc = "ARM erratum 116522",
+        .desc = "ARM erratum 1165522",
         .capability = ARM64_WORKAROUND_AT_SPECULATE,
         MIDR_RANGE(MIDR_CORTEX_A76, 0, 2 << MIDR_VARIANT_SHIFT),
     },
Signature · 1 line
2.17.1
Acked-by on v1 2/2
#5 lore raw

Re: [PATCH 2/2] xen/arm: Enable CPU Errata 1165522 for Neoverse

Hi Bertrand,

There is only one. So it should be erratum :).

Quoted 1 line · Bertrand Marquis

Enable CPU errata of Speculative AT on the Neoverse N1 processor

Ditto.

Quoted 2 lines

versions r0p0 to r2p0.
Also Fix Cortex A76 Errata string which had a wrong errata number.

Ditto.

And good catch for the typo :).

Quoted 2 lines

All the NITs can be fixed during commit:

Cheers,

Quoted 26 lines
---
  xen/arch/arm/cpuerrata.c | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)
xen/arch/arm/cpuerrata.c +7 -1
index 0248893de0..6c09017515 100644
@@ -476,9 +476,15 @@ static const struct arm_cpu_capabilities arm_errata[] = {
          .matches = has_ssbd_mitigation,
      },
  #endif
+    {
+        /* Neoverse r0p0 - r2p0 */
+        .desc = "ARM erratum 1165522",
+        .capability = ARM64_WORKAROUND_AT_SPECULATE,
+        MIDR_RANGE(MIDR_NEOVERSE_N1, 0, 2 << MIDR_VARIANT_SHIFT),
+    },
      {
          /* Cortex-A76 r0p0 - r2p0 */
-        .desc = "ARM erratum 116522",
+        .desc = "ARM erratum 1165522",
          .capability = ARM64_WORKAROUND_AT_SPECULATE,
          MIDR_RANGE(MIDR_CORTEX_A76, 0, 2 << MIDR_VARIANT_SHIFT),
      },
Signature · 1 line
Julien Grall
#6 lore raw

Re: [PATCH 2/2] xen/arm: Enable CPU Errata 1165522 for Neoverse

Quoted 7 lines · Julien Grall

Hi Bertrand,

There is only one. So it should be erratum :).

True my years of latin are quite far ;-)
Anyway grep for errata in commit logs would be defeated if we put erratum instead of errata.

Quoted 11 lines · Bertrand Marquis
Quoted 1 line

Enable CPU errata of Speculative AT on the Neoverse N1 processor

Ditto.

Quoted 2 lines

versions r0p0 to r2p0.
Also Fix Cortex A76 Errata string which had a wrong errata number.

Ditto.

Quoted 7 lines

And good catch for the typo :).

Quoted 1 line

All the NITs can be fixed during commit:

Thanks
Bertrand

Quoted 30 lines

Cheers,

Quoted 24 lines
---
 xen/arch/arm/cpuerrata.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
xen/arch/arm/cpuerrata.c +7 -1
index 0248893de0..6c09017515 100644
@@ -476,9 +476,15 @@ static const struct arm_cpu_capabilities arm_errata[] = {
         .matches = has_ssbd_mitigation,
     },
 #endif
+    {
+        /* Neoverse r0p0 - r2p0 */
+        .desc = "ARM erratum 1165522",
+        .capability = ARM64_WORKAROUND_AT_SPECULATE,
+        MIDR_RANGE(MIDR_NEOVERSE_N1, 0, 2 << MIDR_VARIANT_SHIFT),
+    },
     {
         /* Cortex-A76 r0p0 - r2p0 */
-        .desc = "ARM erratum 116522",
+        .desc = "ARM erratum 1165522",
         .capability = ARM64_WORKAROUND_AT_SPECULATE,
         MIDR_RANGE(MIDR_CORTEX_A76, 0, 2 << MIDR_VARIANT_SHIFT),
     },
Signature · 1 line
Julien Grall
#7 lore raw
In reply to Bertrand Marquis

Hi,

Quoted 6 lines · Bertrand Marquis

This patch serie is adding Neoverse N1 processor identification and enabling the processor errata 1165522 for Neoverse N1 processors.

Bertrand Marquis (2):
arm: Add Neoverse N1 processor identifation xen/arm: Enable CPU Errata 1165522 for Neoverse

Committed, thank you!

Cheers,

Signature · 1 line
Julien Grall