Skip to contentSkip to conversation

fixes for bnxt driver

PATCH Superseded wangyunjian 2 participants 4 messages Sep 5, 2020 – Sep 11, 2020 Network drivers

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

wangyunjian

author
#0 lore raw

cover fixes for bnxt driver

From: Yunjian Wang <[email protected]>

This series include two fixes patches for bnxt driver.

Yunjian Wang (2):
net/bnxt: remove logically dead code
net/bnxt: fix a wrong use of rte_free when freeing mbuf

 drivers/net/bnxt/bnxt_reps.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
Signature · 1 line
2.18.1
author
#1 lore raw

PATCH 1/2 net/bnxt: remove logically dead code

From: Yunjian Wang <[email protected]>

This patch removes logically dead code reported by coverity.

Coverity issue: 360824

Fixes 6dc83230b43b ("net/bnxt: support port representor data path")
Cc [email protected]
Signed-off-by Yunjian Wang <[email protected]>
---
 drivers/net/bnxt/bnxt_reps.c | 2 --
 1 file changed, 2 deletions(-)
drivers/net/bnxt/bnxt_reps.c +0 -2
index 6fa9a30d2..e924025cf 100644
@@ -44,8 +44,6 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf)
 	uint8_t que;
 
 	vfr_eth_dev = &rte_eth_devices[port_id];
-	if (!vfr_eth_dev)
-		return 1;
 	vfr_bp = vfr_eth_dev->data->dev_private;
 	/* If rxq_id happens to be > max rep_queue, use rxq0 */
 	que = queue_id < BNXT_MAX_VF_REP_RINGS ? queue_id : 0;
Signature · 1 line
2.18.1
author
#2 lore raw

PATCH 2/2 net/bnxt: fix a wrong use of rte_free when freeing mbuf

In reply to wangyunjian

From: Yunjian Wang <[email protected]>

We should use rte_pktmbuf_free() instead of rte_free() to free the mbuf.

Fixes 6dc83230b43b ("net/bnxt: support port representor data path")
Cc [email protected]
Signed-off-by Yunjian Wang <[email protected]>
---
 drivers/net/bnxt/bnxt_reps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/bnxt_reps.c +1 -1
index e924025cf..26bd0f626 100644
@@ -61,7 +61,7 @@ bnxt_vfr_recv(uint16_t port_id, uint16_t queue_id, struct rte_mbuf *mbuf)
 	} else {
 		vfr_bp->rx_drop_bytes[que] += mbuf->pkt_len;
 		vfr_bp->rx_drop_pkts[que]++;
-		rte_free(mbuf); /* Representor Rx ring full, drop pkt */
+		rte_pktmbuf_free(mbuf); /* Representor Rx ring full, drop pkt */
 	}
 
 	return 0;
Signature · 1 line
2.18.1
#3 lore raw
In reply to wangyunjian
Quoted 4 lines · wangyunjian

From: Yunjian Wang <[email protected]>

This series include two fixes patches for bnxt driver.

Patchset applied to dpdk-next-net-brcm. Thanks

Quoted 13 lines

Yunjian Wang (2):
net/bnxt: remove logically dead code
net/bnxt: fix a wrong use of rte_free when freeing mbuf

 drivers/net/bnxt/bnxt_reps.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--
2.18.1