Simplify PCIe native ownership detection logic
Subsystems (3)
PATCH v9 1/5 PCI: Conditionally initialize host bridge native_* members
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
If CONFIG_PCIEPORTBUS is not enabled in kernel then initialing struct pci_host_bridge PCIe specific native_* members to "1" is incorrect. So protect the PCIe specific member initialization with CONFIG_PCIEPORTBUS.
--- drivers/pci/probe.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/pci/probe.c +4 -2
@@ -588,12 +588,14 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge)* may implement its own AER handling and use _OSC to prevent the * OS from interfering. */ +#ifdef CONFIG_PCIEPORTBUS bridge->native_aer =1 ; bridge->native_pcie_hotplug =1 ; - bridge->native_shpc_hotplug =1 ; bridge->native_pme =1 ; - bridge->native_ltr =1 ; bridge->native_dpc =1 ; +#endif + bridge->native_ltr =1 ; + bridge->native_shpc_hotplug =1 ;device_initialize (&bridge->dev); }
Signature · 1 line
2.17.1
PATCH v9 3/5 ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set.
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
pcie_ports_dpc_native is set only if user requests native handling of PCIe DPC capability via pcie_port_setup command line option. User input takes precedence over _OSC based control negotiation result. So consider the _OSC negotiated result for DPC ownership only if pcie_ports_dpc_native is unset.
--- drivers/acpi/pci_root.c | 8 ++++++-- drivers/pci/pcie/dpc.c | 3 ++- drivers/pci/pcie/portdrv.h | 2 -- drivers/pci/pcie/portdrv_core.c | 2 +- include/linux/pci.h | 2 ++ 5 files changed, 11 insertions(+), 6 deletions(-)
drivers/acpi/pci_root.c +6 -2
@@ -935,8 +935,12 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root, host_bridge->native_ltr);OSC_OWNER (ctrl,OSC_PCI_EXPRESS_DPC_CONTROL , host_bridge->native_dpc); - } - +if (pcie_ports_dpc_native) +dev_warn (&bus->dev,"OS forcibly taking over DPC\n" ); +else +OSC_OWNER (ctrl,OSC_PCI_EXPRESS_DPC_CONTROL , + host_bridge->native_dpc); + }if (!(root->osc_control_set &OSC_PCI_SHPC_NATIVE_HP_CONTROL )) host_bridge->native_shpc_hotplug =0 ;
drivers/pci/pcie/dpc.c +2 -1
@@ -280,11 +280,12 @@ void pci_dpc_init(struct pci_dev *pdev)static int dpc_probe (struct pcie_device *dev) {struct pci_dev *pdev = dev->port; +struct pci_host_bridge *host =pci_find_host_bridge (pdev->bus);struct device *device = &dev->device;int status;u16 ctl, cap; -if (!pcie_aer_is_native (pdev) && !pcie_ports_dpc_native) +if (!pcie_aer_is_native (pdev) && !host->native_dpc)return -ENOTSUPP ; status = devm_request_threaded_irq(device, dev->irq, dpc_irq,
drivers/pci/pcie/portdrv.h +0 -2
@@ -25,8 +25,6 @@#define PCIE_PORT_DEVICE_MAXSERVICES 5 -extern bool pcie_ports_dpc_native; -#ifdef CONFIG_PCIEAER int pcie_aer_init (void );int pcie_aer_is_native (struct pci_dev *dev);
drivers/pci/pcie/portdrv_core.c +1 -1
@@ -253,7 +253,7 @@ static int get_port_device_capability(struct pci_dev *dev)*/ if (pci_find_ext_capability (dev,PCI_EXT_CAP_ID_DPC ) &&pci_aer_available () && - (pcie_ports_dpc_native || (services &PCIE_PORT_SERVICE_AER ))) + (host->native_dpc || (services &PCIE_PORT_SERVICE_AER ))) services |=PCIE_PORT_SERVICE_DPC ; if (pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM ||
include/linux/pci.h +2 -0
@@ -1556,9 +1556,11 @@ static inline int pci_irqd_intx_xlate(struct irq_domain *d,#ifdef CONFIG_PCIEPORTBUS extern bool pcie_ports_disabled;extern bool pcie_ports_native; +extern bool pcie_ports_dpc_native;#else #define pcie_ports_disabled true#define pcie_ports_native false +#define pcie_ports_dpc_native false#endif #define PCIE_LINK_STATE_L0S BIT(0)
Signature · 1 line
2.17.1
PATCH v9 5/5 PCI/DPC: Move AER/DPC dependency checks out of DPC driver
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
Currently, AER and DPC Capabilities dependency checks is distributed between DPC and portdrv service drivers. So move them out of DPC driver.
Also, since services & PCIE_PORT_SERVICE_AER check already ensures AER native ownership, no need to add additional pcie_aer_is_native() check.
--- drivers/pci/pcie/dpc.c | 4 ---- drivers/pci/pcie/portdrv_core.c | 1 + 2 files changed, 1 insertion(+), 4 deletions(-)
drivers/pci/pcie/dpc.c +0 -4
@@ -280,14 +280,10 @@ void pci_dpc_init(struct pci_dev *pdev)static int dpc_probe (struct pcie_device *dev) {struct pci_dev *pdev = dev->port; -struct pci_host_bridge *host =pci_find_host_bridge (pdev->bus);struct device *device = &dev->device;int status;u16 ctl, cap; -if (!pcie_aer_is_native (pdev) && !host->native_dpc) -return -ENOTSUPP ; - status =devm_request_threaded_irq (device, dev->irq, dpc_irq, dpc_handler,IRQF_SHARED ,"pcie-dpc" , pdev);
drivers/pci/pcie/portdrv_core.c +1 -0
@@ -252,6 +252,7 @@ static int get_port_device_capability(struct pci_dev *dev)* permission to use AER. */ if (pci_find_ext_capability (dev,PCI_EXT_CAP_ID_DPC ) && + host->native_dpc && (host->native_dpc || (services &PCIE_PORT_SERVICE_AER ))) services |=PCIE_PORT_SERVICE_DPC ;
Signature · 1 line
2.17.1
Re: [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members
In reply to [email protected]I got 1/5, 3/5, and 5/5 (and no cover letter). Is there a 2/5 and a 4/5? Not sure if I should wait for more, or review these three as-is?
Quoted 36 lines · On Fri, Sep 18, 2020 at 12:58:30PM -0700…
From: Kuppuswamy Sathyanarayanan <[email protected]>
If
CONFIG_PCIEPORTBUSis not enabled in kernel then initialing structpci_host_bridgePCIe specific native_* members to "1" is incorrect. So protect the PCIe specific member initialization withCONFIG_PCIEPORTBUS.Signed-off-by Kuppuswamy Sathyanarayanan <[email protected]>--- drivers/pci/probe.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/pci/probe.c +4
-2@@ -588,12 +588,14 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge)* may implement its own AER handling and use _OSC to prevent the * OS from interfering. */ +#ifdef CONFIG_PCIEPORTBUS bridge->native_aer =1 ; bridge->native_pcie_hotplug =1 ; - bridge->native_shpc_hotplug =1 ; bridge->native_pme =1 ; - bridge->native_ltr =1 ; bridge->native_dpc =1 ; +#endif + bridge->native_ltr =1 ; + bridge->native_shpc_hotplug =1 ;device_initialize (&bridge->dev); }Signature · 1 line
2.17.1
Re: [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members
Quoted 2 lines · Bjorn Helgaas
I got 1/5, 3/5, and 5/5 (and no cover letter). Is there a 2/5 and a 4/5? Not sure if I should wait for more, or review these three as-is?
I sent all 5 together with cover letter. Do you want me to send it again ?
Quoted 38 lines · On Fri, Sep 18, 2020 at 12:58:30PM -0700…
Quoted 36 lines
From: Kuppuswamy Sathyanarayanan <[email protected]>
If
CONFIG_PCIEPORTBUSis not enabled in kernel then initialing structpci_host_bridgePCIe specific native_* members to "1" is incorrect. So protect the PCIe specific member initialization withCONFIG_PCIEPORTBUS.Signed-off-by Kuppuswamy Sathyanarayanan <[email protected]>--- drivers/pci/probe.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)drivers/pci/probe.c +4
-2@@ -588,12 +588,14 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge)* may implement its own AER handling and use _OSC to prevent the * OS from interfering. */ +#ifdef CONFIG_PCIEPORTBUS bridge->native_aer =1 ; bridge->native_pcie_hotplug =1 ; - bridge->native_shpc_hotplug =1 ; bridge->native_pme =1 ; - bridge->native_ltr =1 ; bridge->native_dpc =1 ; +#endif + bridge->native_ltr =1 ; + bridge->native_shpc_hotplug =1 ;device_initialize (&bridge->dev); }Signature · 1 line
2.17.1
Signature · 2 lines
Sathyanarayanan Kuppuswamy Linux Kernel Developer
v9 cover Simplify PCIe native ownership detection logic
From: Kuppuswamy Sathyanarayanan <[email protected]>
Currently, PCIe capabilities ownership status is detected by verifying the status of pcie_ports_native, pcie_ports_dpc_native and _OSC negotiated results (cached in struct pci_host_bridge ->native_* members). But this logic can be simplified, and we can use only struct pci_host_bridge ->native_* members to detect it.
This patchset removes the distributed checks for pcie_ports_native, pcie_ports_dpc_native parameters.
Changes since v8:
* Simplified setting _OSC ownwership logic
* Moved bridge->native_ltr out of #ifdef CONFIG_PCIEPORTBUS.
Changes since v7:
* Fixed "fix array_size.cocci warnings".
Changes since v6:
* Created new patch for CONFIG_PCIEPORTBUS check in pci_init_host_bridge().
* Added warning message for a case when pcie_ports_native overrides _OSC negotiation result.
Changes since v5:
* Rebased on top of v5.8-rc1
Changes since v4:
* Changed the patch set title (Original link: https://lkml.org/lkml/2020/5/26/1710)
* Added AER/DPC dependency logic cleanup fixes.
Kuppuswamy Sathyanarayanan (5):
PCI: Conditionally initialize host bridge native_* members ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set. ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native
is set.
PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable
logic
PCI/DPC: Move AER/DPC dependency checks out of DPC driver
drivers/acpi/pci_root.c | 37 ++++++++++++++++++++++--------- drivers/pci/hotplug/pciehp_core.c | 2 +- drivers/pci/pci-acpi.c | 3 --- drivers/pci/pcie/aer.c | 2 +- drivers/pci/pcie/dpc.c | 3 --- drivers/pci/pcie/portdrv.h | 2 -- drivers/pci/pcie/portdrv_core.c | 13 +++++------ drivers/pci/probe.c | 6 +++-- include/linux/acpi.h | 2 ++ include/linux/pci.h | 2 ++ 10 files changed, 42 insertions(+), 30 deletions(-)
Signature · 1 line
2.17.1
Re: [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members
In reply to Kuppuswamy, Sathyanarayanan[+cc Sean]
Quoted 4 lines · Sathyanarayanan
Quoted 2 lines · Bjorn Helgaas
I got 1/5, 3/5, and 5/5 (and no cover letter). Is there a 2/5 and a 4/5? Not sure if I should wait for more, or review these three as-is?
I sent all 5 together with cover letter. Do you want me to send it again ?
I guess so. I'm starting to suspect something wrong with Intel's email path.
Sean had a similar problem a few days ago, and he re-sent the series, and the resend also has the same problem.
PATCH v9 4/5 PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic
In reply to [email protected]From: Kuppuswamy Sathyanarayanan <[email protected]>
In DPC service enable logic, check for
services & PCIE_PORT_SERVICE_AER implies pci_aer_available() is true. So there is no need to explicitly check it again.
Also, passing pcie_ports=dpc-native in kernel command line implies DPC needs to be enabled in native mode irrespective of AER ownership status. So checking for pci_aer_available() without checking for pcie_ports status is incorrect.
--- drivers/pci/pcie/portdrv_core.c | 1 - 1 file changed, 1 deletion(-)
drivers/pci/pcie/portdrv_core.c +0 -1
@@ -252,7 +252,6 @@ static int get_port_device_capability(struct pci_dev *dev)* permission to use AER. */ if (pci_find_ext_capability (dev,PCI_EXT_CAP_ID_DPC ) && -pci_aer_available () && (host->native_dpc || (services &PCIE_PORT_SERVICE_AER ))) services |=PCIE_PORT_SERVICE_DPC ;
Signature · 1 line
2.17.1
PATCH v9 2/5 ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set.
In reply to [email protected]pcie_ports_native is set only if user requests native handling of PCIe capabilities via pcie_port_setup command line option. User input takes precedence over _OSC based control negotiation result. So consider the _OSC negotiated result only if pcie_ports_native is unset.
Also, since struct pci_host_bridge ->native_* members caches the ownership status of various PCIe capabilities, use them instead of distributed checks for pcie_ports_native.
--- drivers/acpi/pci_root.c | 33 +++++++++++++++++++++---------- drivers/pci/hotplug/pciehp_core.c | 2 +- drivers/pci/pci-acpi.c | 3 --- drivers/pci/pcie/aer.c | 2 +- drivers/pci/pcie/portdrv_core.c | 9 +++------ include/linux/acpi.h | 2 ++ 6 files changed, 30 insertions(+), 21 deletions(-)
drivers/acpi/pci_root.c +23 -10
@@ -43,6 +43,10 @@ static int acpi_pci_root_scan_dependent(struct acpi_device *adev) | OSC_PCI_CLOCK_PM_SUPPORT \ | OSC_PCI_MSI_SUPPORT) +#define OSC_OWNER (ctrl, bit, flag) \ + if (!(ctrl & bit)) \ + flag = 0; +static const struct acpi_device_id root_device_ids[] = { {"PNP0A03" ,0 }, {"" ,0 },
@@ -889,6 +893,7 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,struct pci_bus *bus;struct pci_host_bridge *host_bridge;union acpi_object *obj; +u32 ctrl; info->root = root; info->bridge = device;
@@ -914,18 +919,26 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root, goto out_release_info; host_bridge =to_pci_host_bridge (bus->bridge); -if (!(root->osc_control_set &OSC_PCI_EXPRESS_NATIVE_HP_CONTROL )) - host_bridge->native_pcie_hotplug =0 ; + +if (pcie_ports_native) { +decode_osc_control (root,"OS forcibly taking over" , +OSC_PCI_EXPRESS_CONTROL_MASKS ); + }else { + ctrl = root->osc_control_set; +OSC_OWNER (ctrl,OSC_PCI_EXPRESS_NATIVE_HP_CONTROL , + host_bridge->native_pcie_hotplug); +OSC_OWNER (ctrl,OSC_PCI_EXPRESS_AER_CONTROL , + host_bridge->native_aer); +OSC_OWNER (ctrl,OSC_PCI_EXPRESS_PME_CONTROL , + host_bridge->native_pme); +OSC_OWNER (ctrl,OSC_PCI_EXPRESS_LTR_CONTROL , + host_bridge->native_ltr); +OSC_OWNER (ctrl,OSC_PCI_EXPRESS_DPC_CONTROL , + host_bridge->native_dpc); + } +if (!(root->osc_control_set &OSC_PCI_SHPC_NATIVE_HP_CONTROL )) host_bridge->native_shpc_hotplug =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_AER_CONTROL )) - host_bridge->native_aer =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_PME_CONTROL )) - host_bridge->native_pme =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_LTR_CONTROL )) - host_bridge->native_ltr =0 ; -if (!(root->osc_control_set &OSC_PCI_EXPRESS_DPC_CONTROL )) - host_bridge->native_dpc =0 ;/* * Evaluate the "PCI Boot Configuration" _DSM Function. If it
drivers/pci/hotplug/pciehp_core.c +1 -1
@@ -256,7 +256,7 @@ static bool pme_is_native(struct pcie_device *dev)const struct pci_host_bridge *host; host =pci_find_host_bridge (dev->port->bus); -return pcie_ports_native || host->native_pme; +return host->native_pme; }static void pciehp_disable_interrupt (struct pcie_device *dev)
drivers/pci/pci-acpi.c +0 -3
@@ -800,9 +800,6 @@ bool pciehp_is_native(struct pci_dev *bridge)if (!(slot_cap &PCI_EXP_SLTCAP_HPC ))return false; -if (pcie_ports_native) -return true; - host =pci_find_host_bridge (bridge->bus);return host->native_pcie_hotplug; }
drivers/pci/pcie/aer.c +1 -1
@@ -219,7 +219,7 @@ int pcie_aer_is_native(struct pci_dev *dev)if (!dev->aer_cap)return 0 ; -return pcie_ports_native || host->native_aer; +return host->native_aer; }int pci_enable_pcie_error_reporting (struct pci_dev *dev)
drivers/pci/pcie/portdrv_core.c +3 -6
@@ -208,8 +208,7 @@ static int get_port_device_capability(struct pci_dev *dev)struct pci_host_bridge *host =pci_find_host_bridge (dev->bus);int services =0 ; -if (dev->is_hotplug_bridge && - (pcie_ports_native || host->native_pcie_hotplug)) { +if (dev->is_hotplug_bridge && host->native_pcie_hotplug) { services |=PCIE_PORT_SERVICE_HP ;/*
@@ -221,8 +220,7 @@ static int get_port_device_capability(struct pci_dev *dev) }#ifdef CONFIG_PCIEAER -if (dev->aer_cap &&pci_aer_available () && - (pcie_ports_native || host->native_aer)) { +if (dev->aer_cap &&pci_aer_available () && host->native_aer) { services |=PCIE_PORT_SERVICE_AER ;/*
@@ -238,8 +236,7 @@ static int get_port_device_capability(struct pci_dev *dev)* Event Collectors can also generate PMEs, but we don't handle * those yet. */ -if (pci_pcie_type (dev) ==PCI_EXP_TYPE_ROOT_PORT && - (pcie_ports_native || host->native_pme)) { +if (pci_pcie_type (dev) ==PCI_EXP_TYPE_ROOT_PORT && host->native_pme) { services |=PCIE_PORT_SERVICE_PME ;/*
include/linux/acpi.h +2 -0
@@ -569,6 +569,8 @@ extern bool osc_pc_lpi_support_confirmed;#define OSC_PCI_EXPRESS_LTR_CONTROL 0x00000020#define OSC_PCI_EXPRESS_DPC_CONTROL 0x00000080#define OSC_PCI_CONTROL_MASKS 0x000000bf +/* Masks specific to PCIe Capabilities */ +#define OSC_PCI_EXPRESS_CONTROL_MASKS 0x000000bd#define ACPI_GSB_ACCESS_ATTRIB_QUICK 0x00000002#define ACPI_GSB_ACCESS_ATTRIB_SEND_RCV 0x00000004
Signature · 1 line
2.17.1
Hi Bjorn,
Quoted 6 lines · Kuppuswamy Sathyanarayanan
Currently, PCIe capabilities ownership status is detected by verifying the status of
pcie_ports_native,pcie_ports_dpc_nativeand_OSCnegotiated results (cached in structpci_host_bridge->native_* members). But this logic can be simplified, and we can use only structpci_host_bridge->native_* members to detect it.
Did you get this patch set or do I need to send it again?
Quoted 45 lines
This patchset removes the distributed checks for
pcie_ports_native,pcie_ports_dpc_nativeparameters.Changes since v8:
* Simplified setting_OSCownwership logic
* Movedbridge->native_ltrout of #ifdefCONFIG_PCIEPORTBUS.Changes since v7:
* Fixed "fixarray_size.cocciwarnings".Changes since v6:
* Created new patch forCONFIG_PCIEPORTBUScheck inpci_init_host_bridge().* Added warning message for a case when
pcie_ports_nativeoverrides_OSCnegotiation result.Changes since v5:
* Rebased on top of v5.8-rc1Changes since v4:
* Changed the patch set title (Original link: https://lkml.org/lkml/2020/5/26/1710)
* Added AER/DPC dependency logic cleanup fixes.Kuppuswamy Sathyanarayanan (5):
PCI: Conditionally initialize host bridge native_* members ACPI/PCI: Ignore_OSCnegotiation result ifpcie_ports_nativeis set. ACPI/PCI: Ignore_OSCDPC negotiation result ifpcie_ports_dpc_native
is set.
PCI/portdrv: Remove redundantpci_aer_available()check in DPC enable
logic
PCI/DPC: Move AER/DPC dependency checks out of DPC driverdrivers/acpi/pci_root.c | 37 ++++++++++++++++++++++--------- drivers/pci/hotplug/pciehp_core.c | 2 +- drivers/pci/pci-acpi.c | 3 --- drivers/pci/pcie/aer.c | 2 +- drivers/pci/pcie/dpc.c | 3 --- drivers/pci/pcie/portdrv.h | 2 -- drivers/pci/pcie/portdrv_core.c | 13 +++++------ drivers/pci/probe.c | 6 +++-- include/linux/acpi.h | 2 ++ include/linux/pci.h | 2 ++ 10 files changed, 42 insertions(+), 30 deletions(-)
Signature · 2 lines
Sathyanarayanan Kuppuswamy Linux Kernel Developer
Quoted 11 lines · Sathyanarayanan
Hi Bjorn,
Quoted 6 lines · Kuppuswamy Sathyanarayanan
Currently, PCIe capabilities ownership status is detected by verifying the status of
pcie_ports_native,pcie_ports_dpc_nativeand_OSCnegotiated results (cached in structpci_host_bridge->native_* members). But this logic can be simplified, and we can use only structpci_host_bridge->native_* members to detect it.Did you get this patch set or do I need to send it again?
I got it, thanks. More importantly, it looks like linux-pci got it, too :)
$ b4 am -om/ https://lore.kernel.org/r/a640e9043db50f5adee8e38f5c60ff8423f3f598.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com Looking up https://lore.kernel.org/r/a640e9043db50f5adee8e38f5c60ff8423f3f598.1600457297.git.sathyanarayanan.kuppuswamy%40linux.intel.com Grabbing thread from lore.kernel.org/linux-pci Reduced thread to strict matches only (18->10) Analyzing 10 messages in the thread --- Writing m/v9_20200922_sathyanarayanan_kuppuswamy_simplify_pcie_native_ownership_detection_logic.mbx [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members [PATCH v9 2/5] ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set. [PATCH v9 3/5] ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set. [PATCH v9 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic [PATCH v9 5/5] PCI/DPC: Move AER/DPC dependency checks out of DPC driver --- Total patches: 5 --- Cover: m/v9_20200922_sathyanarayanan_kuppuswamy_simplify_pcie_native_ownership_detection_logic.cover Link: https://lore.kernel.org/r/[email protected] Base: not found (applies clean to current tree) git am m/v9_20200922_sathyanarayanan_kuppuswamy_simplify_pcie_native_ownership_detection_logic.mbx
Hi,
Quoted 12 lines · Bjorn Helgaas
Quoted 10 lines · Sathyanarayanan
Hi Bjorn,
Quoted 6 lines · Kuppuswamy Sathyanarayanan
Currently, PCIe capabilities ownership status is detected by verifying the status of
pcie_ports_native,pcie_ports_dpc_nativeand_OSCnegotiated results (cached in structpci_host_bridge->native_* members). But this logic can be simplified, and we can use only structpci_host_bridge->native_* members to detect it.
Quoted 3 lines
Quoted 1 line
Did you get this patch set or do I need to send it again?
I got it, thanks. More importantly, it looks like linux-pci got it, too :)
Thanks for the confirmation.
Quoted 24 lines
$ b4 am -om/ https://lore.kernel.org/r/a640e9043db50f5adee8e38f5c60ff8423f3f598.1600457297.git.sathyanarayanan.kuppuswamy@linux.intel.com Looking up https://lore.kernel.org/r/a640e9043db50f5adee8e38f5c60ff8423f3f598.1600457297.git.sathyanarayanan.kuppuswamy%40linux.intel.com Grabbing thread from lore.kernel.org/linux-pci Reduced thread to strict matches only (18->10) Analyzing 10 messages in the thread --- Writing m/v9_20200922_sathyanarayanan_kuppuswamy_simplify_pcie_native_ownership_detection_logic.mbx [PATCH v9 1/5] PCI: Conditionally initialize host bridge native_* members [PATCH v9 2/5] ACPI/PCI: Ignore _OSC negotiation result if pcie_ports_native is set. [PATCH v9 3/5] ACPI/PCI: Ignore _OSC DPC negotiation result if pcie_ports_dpc_native is set. [PATCH v9 4/5] PCI/portdrv: Remove redundant pci_aer_available() check in DPC enable logic [PATCH v9 5/5] PCI/DPC: Move AER/DPC dependency checks out of DPC driver --- Total patches: 5 --- Cover: m/v9_20200922_sathyanarayanan_kuppuswamy_simplify_pcie_native_ownership_detection_logic.cover Link: https://lore.kernel.org/r/[email protected] Base: not found (applies clean to current tree) git am m/v9_20200922_sathyanarayanan_kuppuswamy_simplify_pcie_native_ownership_detection_logic.mbx
Signature · 2 lines
Sathyanarayanan Kuppuswamy Linux Kernel Developer