Skip to contentSkip to conversation

fix incorrect comment in kernel/sched/rt.c

PATCH New Sidney Cammeresi 1 participant 2 messages Nov 10, 2020 Scheduler

lore
Share & tools
lore
#0 lore raw

cover fix incorrect comment in kernel/sched/rt.c

I was reading rt.c and was looking at the code pertaining to allowing a non-migratable task to preempt a migratable task of the same priority. It appears to me that one of the comments describing when this will happen is wrong.

It appears that preemption will only happen when the task is *not* about to be otherwise preempted. The comment appears to describe an older version of the code, in which preemption would happen when the task *was* about to be preempted, the opposite condition.

Sidney Cammeresi (1):
sched/rt: fix incorrect comment about non-migratable tasks' priority

 kernel/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 6 lines
2.7.4


-- 
Sidney Cammeresi
Staff Software Engineer, MariaDB Corporation Ab
#1 lore raw

PATCH 1/1 sched/rt: fix incorrect comment about non-migratable tasks' priority

---
 kernel/sched/rt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/sched/rt.c +1 -1
index 49ec096..6197c9e 100644
@@ -1560,7 +1560,7 @@ static void check_preempt_curr_rt(struct rq *rq, struct task_struct *p, int flag
 	 *
 	 * - the newly woken task is of equal priority to the current task
 	 * - the newly woken task is non-migratable while current is migratable
-	 * - current will be preempted on the next reschedule
+	 * - current will not be preempted on the next reschedule
 	 *
 	 * we should check to see if current can readily move to a different
 	 * cpu.  If so, we will reschedule to allow the push logic to try
Signature · 6 lines
2.7.4


-- 
Sidney Cammeresi
Staff Software Engineer, MariaDB Corporation Ab