gatesgarth review request
cover gatesgarth review request
Next set of changes for gatesgarth. Please review.
Passed a-full on autobuilder except for one failure. Ping test failed while executing do_testimage for sato image.
https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1602
I think this failure is not related to the changes here as the test passed in other configurations. Probably similar to:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14029
Thanks,
Anuj
The following changes since commit a1db1e71129c3e67ddd9dbef21e1c5eb31552e00:
grub: clean up CVE patches (2020-11-12 11:54:28 +0800)
are available in the Git repository at:
git://push.openembedded.org/openembedded-core-contrib anujm/gatesgarth
Alexander Kanavin (2):
clutter-gst-3.0: do not call out to host gstreamer plugin scanner conf-notes.txt: mention more important images than just sato
Bruce Ashfield (1):
kernel: provide module.lds for out of tree builds in v5.10+
Denys Zagorui (1):
binutils: reproducibility: reuse debug-prefix-map for stabs
Diego Santa Cruz (1):
freetype: fix CVE-2020-15999, backport from 2.10.4
Gratian Crisan (1):
kernel-module-split.bbclass: identify kernel modconf files as
configuration files
Jose Quaresma (1):
gstreamer1.0: warn the user when something is wrong with GstBufferPool
Khem Raj (2):
lrzsz: Use Cross AR during compile
gawk: Avoid using host ar during cross compile
Konrad Weihmann (3):
oeqa/core/context: expose results as variable
oeqa/core/context: initialize _run_end_time
testimage: print results for interrupted runs
Mark Jonas (1):
libbsd: Remove BSD-4-Clause from main package
Matt Madison (1):
layer.conf: fix syntax error in PATH setting
Nathan Rossi (1):
diffstat: add nativesdk to BBCLASSEXTEND
Richard Purdie (3):
ptest-runner: Fix license as it contains 'or later' clause
libdnf: Fix license as it contains 'or later' clause
alsa-utils: Fix license to GPLv2 only
Steve Sakoman (1):
openssh: whitelist CVE-2014-9278
meta/classes/kernel-module-split.bbclass | 1 + meta/classes/kernel.bbclass | 1 + meta/classes/testimage.bbclass | 19 ++++--- meta/conf/conf-notes.txt | 2 + meta/conf/layer.conf | 2 +- meta/lib/oeqa/core/context.py | 4 ++ ...mpilation-using-autoconf-detected-AR.patch | 36 +++++++++++++ meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + .../openssh/openssh_8.3p1.bb | 4 ++ .../binutils/binutils-2.35.inc | 1 + ...oducibility-for-stabs-debugging-data.patch | 35 +++++++++++++ .../diffstat/diffstat_1.63.bb | 2 + meta/recipes-devtools/libdnf/libdnf_0.48.0.bb | 2 +- .../0001-Use-cross-AR-during-compile.patch | 35 +++++++++++++ meta/recipes-extended/gawk/gawk_5.1.0.bb | 1 + .../clutter/clutter-gst-3.0.inc | 2 + ...-sfnt-Fix-heap-buffer-overflow-59308.patch | 51 +++++++++++++++++++ .../freetype/freetype_2.10.2.bb | 1 + meta/recipes-kernel/linux/kernel-devsrc.bb | 6 +++ meta/recipes-multimedia/alsa/alsa-utils.inc | 3 +- ...size-in-reset-when-maxsize-is-larger.patch | 49 ++++++++++++++++++ .../gstreamer/gstreamer1.0_1.16.3.bb | 1 + meta/recipes-support/libbsd/libbsd_0.10.0.bb | 3 +- .../ptest-runner/ptest-runner_2.4.0.bb | 2 +- 24 files changed, 251 insertions(+), 13 deletions(-) create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/0001-Fix-cross-compilation-using-autoconf-detected-AR.patch create mode 100644 meta/recipes-devtools/binutils/binutils/0017-gas-improve-reproducibility-for-stabs-debugging-data.patch create mode 100644 meta/recipes-extended/gawk/gawk/0001-Use-cross-AR-during-compile.patch create mode 100644 meta/recipes-graphics/freetype/freetype/0001-sfnt-Fix-heap-buffer-overflow-59308.patch create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0/0005-bufferpool-only-resize-in-reset-when-maxsize-is-larger.patch
Signature · 1 line
2.28.0
PATCH 1/19 freetype: fix CVE-2020-15999, backport from 2.10.4
From: Diego Santa Cruz <[email protected]>
--- ...-sfnt-Fix-heap-buffer-overflow-59308.patch | 51 +++++++++++++++++++ .../freetype/freetype_2.10.2.bb | 1 + 2 files changed, 52 insertions(+) create mode 100644 meta/recipes-graphics/freetype/freetype/0001-sfnt-Fix-heap-buffer-overflow-59308.patch
meta/recipes-graphics/freetype/freetype/0001-sfnt-Fix-heap-buffer-overflow-59308.patch new file +51 -0
@@ -0,0 +1,51 @@ +From a3bab162b2ae616074c8877a04556932998aeacd Mon Sep 17 00:00:00 2001 +From: Werner Lemberg <[email protected]> +Date: Mon, 19 Oct 2020 23:45:28 +0200 +Subject: [PATCH] [sfnt] Fix heap buffer overflow (#59308). + +This is CVE-2020-15999. + +* src/sfnt/pngshim.c (Load_SBit_Png): Test bitmap size earlier. + +Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=a3bab162b2ae616074c8877a04556932998aeacd] + +Signed-off-by: Diego Santa Cruz <[email protected]> +--- + src/sfnt/pngshim.c | 14 +++++++------- + 1 file changed, 7 insertions(+), 7 deletions(-) + +diff --git a/src/sfnt/pngshim.c b/src/sfnt/pngshim.c +index 2e64e5846..f55016122 100644 +--- a/src/sfnt/pngshim.c ++++ b/src/sfnt/pngshim.c +@@ -332,6 +332,13 @@ + + if ( populate_map_and_metrics ) + { ++ /* reject too large bitmaps similarly to the rasterizer */ ++ if ( imgHeight > 0x7FFF || imgWidth > 0x7FFF ) ++ { ++ error = FT_THROW( Array_Too_Large ); ++ goto DestroyExit; ++ } ++ + metrics->width = (FT_UShort)imgWidth; + metrics->height = (FT_UShort)imgHeight; + +@@ -340,13 +347,6 @@ + map->pixel_mode = FT_PIXEL_MODE_BGRA; + map->pitch = (int)( map->width * 4 ); + map->num_grays = 256; +- +- /* reject too large bitmaps similarly to the rasterizer */ +- if ( map->rows > 0x7FFF || map->width > 0x7FFF ) +- { +- error = FT_THROW( Array_Too_Large ); +- goto DestroyExit; +- } + } + + /* convert palette/gray image to rgb */ +-- +2.18.4 +
meta/recipes-graphics/freetype/freetype_2.10.2.bb +1 -0
@@ -14,6 +14,7 @@ LIC_FILES_CHKSUM = "file://docs/LICENSE.TXT;md5=4af6221506f202774ef74f64932878a1 SRC_URI = "${SAVANNAH_NONGNU_MIRROR}/${BPN}/${BP}.tar.xz \ file://use-right-libtool.patch \ + file://0001-sfnt-Fix-heap-buffer-overflow-59308.patch \ " SRC_URI[md5sum] = "7c0d5a39f232d7eb9f9d7da76bf08074" SRC_URI[sha256sum] = "1543d61025d2e6312e0a1c563652555f17378a204a61e99928c9fcef030a2d8b"
Signature · 1 line
2.28.0
PATCH 2/19 ptest-runner: Fix license as it contains 'or later' clause
In reply to Anuj MittalFrom: Richard Purdie <[email protected]>
The license headers are clear that the code is "or later", fix LICENSE to match.
--- meta/recipes-support/ptest-runner/ptest-runner_2.4.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-support/ptest-runner/ptest-runner_2.4.0.bb +1 -1
@@ -4,7 +4,7 @@ program which loops through all installed ptest test suites and \ runs them in sequence." HOMEPAGE = "http://git.yoctoproject.org/cgit/cgit.cgi/ptest-runner2/about/" -LICENSE = "GPLv2" +LICENSE = "GPLv2+" LIC_FILES_CHKSUM = "file://LICENSE;md5=751419260aa954499f7abaabaa882bbe" SRCREV = "834670317bd3f6e427e1ac461c07ada6b8936dfd"
Signature · 1 line
2.28.0
PATCH 3/19 libdnf: Fix license as it contains 'or later' clause
In reply to Anuj MittalFrom: Richard Purdie <[email protected]>
The license headers are clear that the code is "or later", fix LICENSE to match.
--- meta/recipes-devtools/libdnf/libdnf_0.48.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-devtools/libdnf/libdnf_0.48.0.bb +1 -1
@@ -1,5 +1,5 @@ SUMMARY = "Library providing simplified C and Python API to libsolv" -LICENSE = "LGPLv2.1" +LICENSE = "LGPLv2.1+" LIC_FILES_CHKSUM = "file://COPYING;md5=4fbd65380cdd255951079008b364516c" SRC_URI = "git://github.com/rpm-software-management/libdnf;branch=dnf-4-master \
Signature · 1 line
2.28.0
PATCH 4/19 alsa-utils: Fix license to GPLv2 only
In reply to Anuj MittalFrom: Richard Purdie <[email protected]>
Parts of alsa-utils are v2 only, parts are v2 or later. The effect is the end result is GPLv2 and there seems little value in marking everything as being a mixture of both. Fix LICENSE to match reality.
--- meta/recipes-multimedia/alsa/alsa-utils.inc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-multimedia/alsa/alsa-utils.inc +2 -1
@@ -2,7 +2,8 @@ SUMMARY = "ALSA sound utilities" HOMEPAGE = "http://www.alsa-project.org" BUGTRACKER = "http://alsa-project.org/main/index.php/Bug_Tracking" SECTION = "console/utils" -LICENSE = "GPLv2+" +# Some parts are GPLv2+, some are only GPLv2 (e.g. axfer, alsactl) so result is GPLv2 +LICENSE = "GPLv2" LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \ file://alsactl/utils.c;beginline=3;endline=18;md5=96cc06a4cebe5eb7975688ffb0e65642" DEPENDS = "alsa-lib ncurses libsamplerate0"
Signature · 1 line
2.28.0
PATCH 5/19 kernel-module-split.bbclass: identify kernel modconf files as configuration files
In reply to Anuj MittalFrom: Gratian Crisan <[email protected]>
Currently the modconf fragments representing the configuration for kernel modules are written out to appropriate .conf files and added to the FILES variable. However they are not identified as 'configuration files' and installing a new version of a kernel module results in a conflict and a failed installed because the respective .conf file is already in place from a previous install.
Add the generated .conf files to the CONFFILES variable denoting their true nature.
--- meta/classes/kernel-module-split.bbclass | 1 + 1 file changed, 1 insertion(+)
meta/classes/kernel-module-split.bbclass +1 -0
@@ -120,6 +120,7 @@ python split_kernel_module_packages () { files = d.getVar('FILES_%s' % pkg) files = "%s /etc/modules-load.d/%s.conf /etc/modprobe.d/%s.conf" % (files, basename, basename) d.setVar('FILES_%s' % pkg, files) + d.setVar('CONFFILES_%s' % pkg, files) if "description" in vals: old_desc = d.getVar('DESCRIPTION_' + pkg) or ""
Signature · 1 line
2.28.0
PATCH 6/19 clutter-gst-3.0: do not call out to host gstreamer plugin scanner
In reply to Anuj MittalFrom: Alexander Kanavin <[email protected]>
This is host contamination and can also fail for all kinds of reasons when running under usermode qemu.
--- meta/recipes-graphics/clutter/clutter-gst-3.0.inc | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-graphics/clutter/clutter-gst-3.0.inc +2 -0
@@ -6,6 +6,8 @@ inherit clutter features_check upstream-version-is-even gobject-introspection # depends on clutter-1.0 which depends on cogl-1.0 REQUIRED_DISTRO_FEATURES ?= "opengl" +export GST_PLUGIN_SCANNER_1_0="${S}/gst-plugin-scanner-dummy" + SRC_URI += "file://0001-Install-example-binary-needed-for-core-image-clutter.patch" DEPENDS = "gstreamer1.0-plugins-base gstreamer1.0-plugins-bad clutter-1.0 libgudev"
Signature · 1 line
2.28.0
PATCH 7/19 conf-notes.txt: mention more important images than just sato
In reply to Anuj MittalFrom: Alexander Kanavin <[email protected]>
--- meta/conf/conf-notes.txt | 2 ++ 1 file changed, 2 insertions(+)
meta/conf/conf-notes.txt +2 -0
@@ -5,7 +5,9 @@ You can now run 'bitbake <target>' Common targets are: core-image-minimal + core-image-full-cmdline core-image-sato + core-image-weston meta-toolchain meta-ide-support
Signature · 1 line
2.28.0
PATCH 8/19 openssh: whitelist CVE-2014-9278
In reply to Anuj MittalFrom: Steve Sakoman <[email protected]>
The OpenSSH server, as used in Fedora and Red Hat Enterprise Linux 7 and when running in a Kerberos environment, allows remote authenticated users to log in as another user when they are listed in the .k5users file of that user, which might bypass intended authentication requirements that would force a local login.
Whitelist the CVE since this issue is Redhat specific.
--- meta/recipes-connectivity/openssh/openssh_8.3p1.bb | 4 ++++ 1 file changed, 4 insertions(+)
meta/recipes-connectivity/openssh/openssh_8.3p1.bb +4 -0
@@ -27,6 +27,10 @@ SRC_URI = "http://ftp.openbsd.org/pub/OpenBSD/OpenSSH/portable/openssh-${PV}.tar " SRC_URI[sha256sum] = "f2befbe0472fe7eb75d23340eb17531cb6b3aac24075e2066b41f814e12387b2" +# This CVE is specific to OpenSSH server, as used in Fedora and Red Hat Enterprise Linux 7 +# and when running in a Kerberos environment. As such it is not relevant to OpenEmbedded +CVE_CHECK_WHITELIST += "CVE-2014-9278" + PAM_SRC_URI = "file://sshd" inherit manpages useradd update-rc.d update-alternatives systemd
Signature · 1 line
2.28.0
PATCH 9/19 oeqa/core/context: expose results as variable
In reply to Anuj MittalFrom: Konrad Weihmann <[email protected]>
register an unittest handler for testresults and expose it as variable result.
With this even partial results from an interrupted test suite run can be made available
--- meta/lib/oeqa/core/context.py | 3 +++ 1 file changed, 3 insertions(+)
meta/lib/oeqa/core/context.py +3 -0
@@ -31,6 +31,9 @@ class OETestContext(object): self._registry = {} self._registry['cases'] = collections.OrderedDict() + self.results = unittest.TestResult() + unittest.registerResult(self.results) + def _read_modules_from_manifest(self, manifest): if not os.path.exists(manifest): raise OEQAMissingManifest("Manifest does not exist on %s" % manifest)
Signature · 1 line
2.28.0
PATCH 10/19 oeqa/core/context: initialize _run_end_time
In reply to Anuj MittalFrom: Konrad Weihmann <[email protected]>
with _run_start_time as value. For partial results of interrupted runs, this info might be otherwise missing for at least one testcase
--- meta/lib/oeqa/core/context.py | 1 + 1 file changed, 1 insertion(+)
meta/lib/oeqa/core/context.py +1 -0
@@ -85,6 +85,7 @@ class OETestContext(object): self.skipTests(skips) self._run_start_time = time.time() + self._run_end_time = self._run_start_time if not processes: self.runner.buffer = True result = self.runner.run(self.prepareSuite(self.suites, processes))
Signature · 1 line
2.28.0
PATCH 11/19 testimage: print results for interrupted runs
In reply to Anuj MittalFrom: Konrad Weihmann <[email protected]>
When a run is ended by overall timeout, print the already executed testcases, to provide some hints which testcase might made the test suite reach global timeout.
Nonetheless make the testrun exit with an error
--- meta/classes/testimage.bbclass | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-)
meta/classes/testimage.bbclass +11 -8
@@ -367,6 +367,7 @@ def testimage_main(d): package_extraction(d, tc.suites) results = None + complete = False orig_sigterm_handler = signal.signal(signal.SIGTERM, sigterm_exception) try: # We need to check if runqemu ends unexpectedly
@@ -378,6 +379,7 @@ def testimage_main(d): except ValueError: pass results = tc.runTests() + complete = True except (KeyboardInterrupt, BlockingIOError) as err: if isinstance(err, KeyboardInterrupt): bb.error('testimage interrupted, shutting down...')
@@ -385,20 +387,21 @@ def testimage_main(d): bb.error('runqemu failed, shutting down...') if results: results.stop() - results = None + results = tc.results finally: signal.signal(signal.SIGTERM, orig_sigterm_handler) tc.target.stop() # Show results (if we have them) - if not results: + if results: + configuration = get_testimage_configuration(d, 'runtime', machine) + results.logDetails(get_testimage_json_result_dir(d), + configuration, + get_testimage_result_id(configuration), + dump_streams=d.getVar('TESTREPORT_FULLLOGS')) + results.logSummary(pn) + if not results or not complete: bb.fatal('%s - FAILED - tests were interrupted during execution' % pn, forcelog=True) - configuration = get_testimage_configuration(d, 'runtime', machine) - results.logDetails(get_testimage_json_result_dir(d), - configuration, - get_testimage_result_id(configuration), - dump_streams=d.getVar('TESTREPORT_FULLLOGS')) - results.logSummary(pn) if not results.wasSuccessful(): bb.fatal('%s - FAILED - check the task log and the ssh log' % pn, forcelog=True)
Signature · 1 line
2.28.0
PATCH 12/19 binutils: reproducibility: reuse debug-prefix-map for stabs
In reply to Anuj MittalFrom: Denys Zagorui <[email protected]>
powerpc 32bit Linux Kernel widely uses .stabs pseudo-op to produce debugging information in stabs format. Faced an issue that during Linux Kernel build with Yocto build system for 32bit powerpc platform resulting vmlinux contains absolute path in .stabstr section that cannot be remapped with -fdebug-prefix-map option.
Yocto uses scripts/mkmakefile Linux Kernel build approach that allows to store all generated files outside of kernel source tree. With this approach each compilier invocation is performed with an absolute path to a file that will be compiled and this absolute path is recorded in init stab. There is no way to remap this path.
Reuse remap_debug_filename api to make -fdebug-prefix-map flag aplicable for init stab.
--- .../binutils/binutils-2.35.inc | 1 + ...oducibility-for-stabs-debugging-data.patch | 35 +++++++++++++++++++ 2 files changed, 36 insertions(+) create mode 100644 meta/recipes-devtools/binutils/binutils/0017-gas-improve-reproducibility-for-stabs-debugging-data.patch
meta/recipes-devtools/binutils/binutils-2.35.inc +1 -0
@@ -41,5 +41,6 @@ SRC_URI = "\ file://0014-Fix-rpath-in-libtool-when-sysroot-is-enabled.patch \ file://0015-sync-with-OE-libtool-changes.patch \ file://0016-Check-for-clang-before-checking-gcc-version.patch \ + file://0017-gas-improve-reproducibility-for-stabs-debugging-data.patch \ " S = "${WORKDIR}/git"
meta/recipes-devtools/binutils/binutils/0017-gas-improve-reproducibility-for-stabs-debugging-data.patch new file +35 -0
@@ -0,0 +1,35 @@ +From aa6586e80fc6fcd739aa959a71e4cf064cdef072 Mon Sep 17 00:00:00 2001 +From: Denys Zagorui <[email protected]> +Date: Mon, 9 Nov 2020 15:39:10 +0000 +Subject: [PATCH] gas: improve reproducibility for stabs debugging data format + + * config/obj-elf (obj_elf_init_stab_section): Improve + reproducibility for stabs debugging data format + +Upstream-Status: Backport [https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=0541201782c006c09d029d18a45c6e743cfea906] +--- + gas/config/obj-elf.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/gas/config/obj-elf.c b/gas/config/obj-elf.c +index de22b5a1da..2025df8542 100644 +--- a/gas/config/obj-elf.c ++++ b/gas/config/obj-elf.c +@@ -2374,12 +2374,13 @@ obj_elf_init_stab_section (segT seg) + p = frag_more (12); + /* Zero it out. */ + memset (p, 0, 12); +- file = as_where (NULL); ++ file = remap_debug_filename (as_where (NULL)); + stabstr_name = concat (segment_name (seg), "str", (char *) NULL); + stroff = get_stab_string_offset (file, stabstr_name, TRUE); + know (stroff == 1 || (stroff == 0 && file[0] == '\0')); + md_number_to_chars (p, stroff, 4); + seg_info (seg)->stabu.p = p; ++ xfree ((char *) file); + } + + #endif +-- +2.20.1 +
Signature · 1 line
2.28.0
PATCH 13/19 lrzsz: Use Cross AR during compile
In reply to Anuj MittalFrom: Khem Raj <[email protected]>
Current code hardcodes archiver to be 'ar' from build host
--- ...mpilation-using-autoconf-detected-AR.patch | 36 +++++++++++++++++++ meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + 2 files changed, 37 insertions(+) create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/0001-Fix-cross-compilation-using-autoconf-detected-AR.patch
meta/recipes-bsp/lrzsz/lrzsz-0.12.20/0001-Fix-cross-compilation-using-autoconf-detected-AR.patch new file +36 -0
@@ -0,0 +1,36 @@ +From ecdcf0df6c28c65ca6d1e5638726e13e373c76c5 Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Wed, 11 Nov 2020 22:58:55 -0800 +Subject: [PATCH] Fix cross compilation using autoconf detected AR + +currently its using 'ar' program from build host, which is not expected, +we need to respect AR passed in environment + +Upstream-Status: Pending + +Signed-off-by: Khem Raj <[email protected]> +--- + configure.in | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/configure.in b/configure.in +index 4ddbe8b..b7c3c31 100644 +--- a/configure.in ++++ b/configure.in +@@ -84,6 +84,13 @@ AC_ARG_ENABLE(syslog, + ]) + + dnl Checks for programs. ++m4_ifndef([AC_PROG_AR],[dnl ++ AN_MAKEVAR([AR], [AC_PROG_AR]) ++ AN_PROGRAM([ar], [AC_PROG_AR]) ++ AC_DEFUN([AC_PROG_AR], ++ [AC_CHECK_TOOL(AR, ar, :)]) ++]) ++AC_PROG_AR + AC_PROG_CC + AC_PROG_GCC_TRADITIONAL + dnl AC_PROG_INSTALL included in AM_INIT_AUTOMAKE +-- +2.29.2 +
meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb +1 -0
@@ -19,6 +19,7 @@ SRC_URI = "http://www.ohse.de/uwe/releases/lrzsz-${PV}.tar.gz \ file://lrzsz-check-locale.h.patch \ file://cve-2018-10195.patch \ file://include.patch \ + file://0001-Fix-cross-compilation-using-autoconf-detected-AR.patch \ " SRC_URI[md5sum] = "b5ce6a74abc9b9eb2af94dffdfd372a4"
Signature · 1 line
2.28.0
PATCH 14/19 gawk: Avoid using host ar during cross compile
In reply to Anuj MittalFrom: Khem Raj <[email protected]>
--- .../0001-Use-cross-AR-during-compile.patch | 35 +++++++++++++++++++ meta/recipes-extended/gawk/gawk_5.1.0.bb | 1 + 2 files changed, 36 insertions(+) create mode 100644 meta/recipes-extended/gawk/gawk/0001-Use-cross-AR-during-compile.patch
meta/recipes-extended/gawk/gawk/0001-Use-cross-AR-during-compile.patch new file +35 -0
@@ -0,0 +1,35 @@ +From 207b94e37c84007b294e57878c913271aad544ef Mon Sep 17 00:00:00 2001 +From: Khem Raj <[email protected]> +Date: Wed, 11 Nov 2020 23:13:23 -0800 +Subject: [PATCH] Use cross AR during compile + +If AR is specifcied then it should be used instead of defaulting to 'ar' +from host + +Upstream-Status: Pending +Signed-off-by: Khem Raj <[email protected]> +--- + configure.ac | 7 +++++++ + 1 file changed, 7 insertions(+) + +diff --git a/configure.ac b/configure.ac +index 31364ab..4804f7b 100644 +--- a/configure.ac ++++ b/configure.ac +@@ -92,6 +92,13 @@ GAWK_CANONICAL_HOST + AC_USE_SYSTEM_EXTENSIONS + + dnl checks for programs ++m4_ifndef([AC_PROG_AR],[dnl ++ AN_MAKEVAR([AR], [AC_PROG_AR]) ++ AN_PROGRAM([ar], [AC_PROG_AR]) ++ AC_DEFUN([AC_PROG_AR], ++ [AC_CHECK_TOOL(AR, ar, :)]) ++]) ++AC_PROG_AR + AC_PROG_EGREP + AC_PROG_YACC + AC_PROG_LN_S +-- +2.29.2 +
meta/recipes-extended/gawk/gawk_5.1.0.bb +1 -0
@@ -17,6 +17,7 @@ PACKAGECONFIG[mpfr] = "--with-mpfr,--without-mpfr, mpfr" SRC_URI = "${GNU_MIRROR}/gawk/gawk-${PV}.tar.gz \ file://run-ptest \ + file://0001-Use-cross-AR-during-compile.patch \ " SRC_URI[md5sum] = "f719bc9966df28e67fc6ebc405e7ea03"
Signature · 1 line
2.28.0
PATCH 15/19 layer.conf: fix syntax error in PATH setting
In reply to Anuj MittalFrom: Matt Madison <[email protected]>
Commit 05a87be51b44608ce4f77ac332df90a3cd2445ef introduced a Python conditional expression when updating PATH that generates syntax warnings in bitbake-cookerdaemon.log:
Var <PATH[:=]>:1: SyntaxWarning: "is not" with a literal. Did you mean "!="?
Fix this by using the more appropriate '!=' comparison operator.
--- meta/conf/layer.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/layer.conf +1 -1
@@ -104,4 +104,4 @@ SSTATE_EXCLUDEDEPS_SYSROOT += ".*->autoconf-archive-native" # We need to keep bitbake tools in PATH # Avoid empty path entries BITBAKEPATH := "${@os.path.dirname(bb.utils.which(d.getVar('PATH'),'bitbake'))}" -PATH := "${@'${BITBAKEPATH}:' if '${BITBAKEPATH}' is not '' else ''}${HOSTTOOLS_DIR}" +PATH := "${@'${BITBAKEPATH}:' if '${BITBAKEPATH}' != '' else ''}${HOSTTOOLS_DIR}"
Signature · 1 line
2.28.0
PATCH 16/19 libbsd: Remove BSD-4-Clause from main package
In reply to Anuj MittalFrom: Mark Jonas <[email protected]>
libbsd contains a multitude of licenses. For (commercial) projects the 3rd clause of the BSD-4-Clause license can be problematic. But only a few man pages use this license. This means that the main package containing the binary library itself is not under BSD-4-Clause ruling.
--- meta/recipes-support/libbsd/libbsd_0.10.0.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta/recipes-support/libbsd/libbsd_0.10.0.bb +2 -1
@@ -27,7 +27,8 @@ HOMEPAGE = "https://libbsd.freedesktop.org/wiki/" # License: ISC-Original # License: public-domain # License: public-domain-Colin-Plumb -LICENSE = "BSD-4-Clause & ISC & PD" +LICENSE = "BSD-3-Clause & BSD-4-Clause & ISC & PD" +LICENSE_${PN} = "BSD-3-Clause & ISC & PD" LIC_FILES_CHKSUM = "file://COPYING;md5=2120be0173469a06ed185b688e0e1ae0" SECTION = "libs"
Signature · 1 line
2.28.0
PATCH 17/19 kernel: provide module.lds for out of tree builds in v5.10+
In reply to Anuj MittalFrom: Bruce Ashfield <[email protected]>
The upstream commit 596b0474d3d [kbuild: preprocess module linker script], adds a dependency on module.lds for external module building.
Since module.lds is generated as part of 'modules_prepare', we must make it available with the other kernel artifacts in the kernel shared workdir, otherwise out of tree builds fail.
This fixes errors like:
| make[4]: *** No rule to make target 'scripts/module.lds', needed by
'build/tmp/work/qemuarm64-poky-linux/cryptodev-module/1.11-r0/git/cryptodev.ko'.
Stop.
| make[4]: *** Waiting for unfinished jobs....We also ensure that kernel-devsrc has a copy to support on target module builds that are often prepared with 'make scripts prepare'. Those targets won't regenerate it, so the build fails. If 'make modules_prepare' is used, the file will be regenerated and overwrite our copy (as expected).
--- meta/classes/kernel.bbclass | 1 + meta/recipes-kernel/linux/kernel-devsrc.bb | 6 ++++++ 2 files changed, 7 insertions(+)
meta/classes/kernel.bbclass +1 -0
@@ -486,6 +486,7 @@ do_shared_workdir () { # Copy files required for module builds cp System.map $kerneldir/System.map-${KERNEL_VERSION} [ -e Module.symvers ] && cp Module.symvers $kerneldir/ + [ -e scripts/module.lds ] && install -Dm 0644 scripts/module.lds $kerneldir/scripts/module.lds cp .config $kerneldir/ mkdir -p $kerneldir/include/config cp include/config/kernel.release $kerneldir/include/config/kernel.release
meta/recipes-kernel/linux/kernel-devsrc.bb +6 -0
@@ -86,6 +86,12 @@ do_install() { # be dealt with. # cp -a scripts $kerneldir/build + # although module.lds can be regenerated on target via 'make modules_prepare' + # there are several places where 'makes scripts prepare' is done, and that won't + # regenerate the file. So we copy it onto the target as a migration to using + # modules_prepare + cp -a --parents scripts/module.lds $kerneldir/build/ 2>/dev/null || : + if [ -d arch/${ARCH}/scripts ]; then cp -a arch/${ARCH}/scripts $kerneldir/build/arch/${ARCH} fi
Signature · 1 line
2.28.0
PATCH 18/19 gstreamer1.0: warn the user when something is wrong with GstBufferPool
In reply to Anuj MittalFrom: Jose Quaresma <[email protected]>
This is not a critical bug fix but it can be usefull in some BSP with exotic drivers like on nvidia tegra bsp.
--- ...size-in-reset-when-maxsize-is-larger.patch | 49 +++++++++++++++++++ .../gstreamer/gstreamer1.0_1.16.3.bb | 1 + 2 files changed, 50 insertions(+) create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0/0005-bufferpool-only-resize-in-reset-when-maxsize-is-larger.patch
meta/recipes-multimedia/gstreamer/gstreamer1.0/0005-bufferpool-only-resize-in-reset-when-maxsize-is-larger.patch new file +49 -0
@@ -0,0 +1,49 @@ +From a1b41b2b2493069365a8274c6a544e6799a5a8df Mon Sep 17 00:00:00 2001 +From: Matthew Waters <[email protected]> +Date: Mon, 20 Jul 2020 17:08:32 +1000 +Subject: [PATCH] gst/bufferpool: only resize in reset when maxsize is larger + +Only resize the buffer if the maxsize is larger then the configued pool +size. + +Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/570> + +Upstream-Status: Backport [https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/a1b41b2b2493069365a8274c6a544e6799a5a8df] + +Signed-off-by: Jose Quaresma <[email protected]> +--- + gst/gstbufferpool.c | 18 +++++++++++++++--- + 1 file changed, 15 insertions(+), 3 deletions(-) + +diff --git a/gst/gstbufferpool.c b/gst/gstbufferpool.c +index 8ae868cf2c7..a8167d017d6 100644 +--- a/gst/gstbufferpool.c ++++ b/gst/gstbufferpool.c +@@ -1223,9 +1223,21 @@ default_reset_buffer (GstBufferPool * pool, GstBuffer * buffer) + + /* if the memory is intact reset the size to the full size */ + if (!GST_BUFFER_FLAG_IS_SET (buffer, GST_BUFFER_FLAG_TAG_MEMORY)) { +- gsize offset; +- gst_buffer_get_sizes (buffer, &offset, NULL); +- gst_buffer_resize (buffer, -offset, pool->priv->size); ++ gsize offset, maxsize; ++ gst_buffer_get_sizes (buffer, &offset, &maxsize); ++ /* check if we can resize to at least the pool configured size. If not, ++ * then this will fail internally in gst_buffer_resize(). ++ * default_release_buffer() will drop the buffer from the pool if the ++ * sizes don't match */ ++ if (maxsize >= pool->priv->size) { ++ gst_buffer_resize (buffer, -offset, pool->priv->size); ++ } else { ++ GST_WARNING_OBJECT (pool, "Buffer %p without the memory tag has " ++ "maxsize (%" G_GSIZE_FORMAT ") that is smaller than the " ++ "configured buffer pool size (%u). The buffer will be not be " ++ "reused. This is most likely a bug in this GstBufferPool subclass", ++ buffer, maxsize, pool->priv->size); ++ } + } + + /* remove all metadata without the POOLED flag */ +-- +GitLab +
meta/recipes-multimedia/gstreamer/gstreamer1.0_1.16.3.bb +1 -0
@@ -21,6 +21,7 @@ SRC_URI = " \ file://0002-meson-build-gir-even-when-cross-compiling-if-introsp.patch \ file://0003-meson-Add-valgrind-feature.patch \ file://0004-meson-Add-option-for-installed-tests.patch \ + file://0005-bufferpool-only-resize-in-reset-when-maxsize-is-larger.patch \ " SRC_URI[md5sum] = "beecf6965a17fb17fa3b262fd36df70a" SRC_URI[sha256sum] = "692f037968e454e508b0f71d9674e2e26c78475021407fcf8193b1c7e59543c7"
Signature · 1 line
2.28.0
PATCH 19/19 diffstat: add nativesdk to BBCLASSEXTEND
In reply to Anuj MittalFrom: Nathan Rossi <[email protected]>
The diffstat tool is part of HOSTTOOLS. To support hosts that do not have it installed with buildtools-tarball it must be enabled for nativesdk.
--- meta/recipes-devtools/diffstat/diffstat_1.63.bb | 2 ++ 1 file changed, 2 insertions(+)
meta/recipes-devtools/diffstat/diffstat_1.63.bb +2 -0
@@ -27,3 +27,5 @@ LDFLAGS += "${TOOLCHAIN_OPTIONS}" do_install_ptest() { cp -r ${S}/testing ${D}${PTEST_PATH} } + +BBCLASSEXTEND = "nativesdk"
Signature · 1 line
2.28.0
Hi,
Do you still plan to upgrade bluez5 in gatesgarth to 5.55 like dunfell was recently updated?
You mentioned it in:
https://lists.openembedded.org/g/openembedded-core/message/144467
but I don't see it in this PR.
Quoted 113 lines · Anuj Mittal
Next set of changes for gatesgarth. Please review.
Passed a-full on autobuilder except for one failure. Ping test failed while executing
do_testimagefor sato image.https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1602
I think this failure is not related to the changes here as the test passed in other configurations. Probably similar to:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14029Thanks,
Anuj
The following changes since commit
a1db1e71129c3e67ddd9dbef21e1c5eb31552e00:grub: clean up CVE patches (2020-11-12 11:54:28 +0800)
are available in the Git repository at:
git://push.openembedded.org/openembedded-core-contribanujm/gatesgarthAlexander Kanavin (2):
clutter-gst-3.0: do not call out to host gstreamer plugin scanner conf-notes.txt: mention more important images than just satoBruce Ashfield (1):
kernel: providemodule.ldsfor out of tree builds in v5.10+Denys Zagorui (1):
binutils: reproducibility: reuse debug-prefix-map for stabsDiego Santa Cruz (1):
freetype: fix CVE-2020-15999, backport from 2.10.4Gratian Crisan (1):
kernel-module-split.bbclass: identify kernel modconf files as
configuration filesJose Quaresma (1):
gstreamer1.0: warn the user when something is wrong with GstBufferPoolKhem Raj (2):
lrzsz: Use Cross AR during compile
gawk: Avoid using host ar during cross compileKonrad Weihmann (3):
oeqa/core/context: expose results as variable
oeqa/core/context: initialize_run_end_time
testimage: print results for interrupted runsMark Jonas (1):
libbsd: Remove BSD-4-Clause from main packageMatt Madison (1):
layer.conf: fix syntax error in PATH settingNathan Rossi (1):
diffstat: add nativesdk to BBCLASSEXTENDRichard Purdie (3):
ptest-runner: Fix license as it contains 'or later' clause
libdnf: Fix license as it contains 'or later' clause
alsa-utils: Fix license to GPLv2 onlySteve Sakoman (1):
openssh: whitelist CVE-2014-9278meta/classes/kernel-module-split.bbclass | 1 + meta/classes/kernel.bbclass | 1 + meta/classes/testimage.bbclass | 19 ++++--- meta/conf/conf-notes.txt | 2 + meta/conf/layer.conf | 2 +- meta/lib/oeqa/core/context.py | 4 ++ ...mpilation-using-autoconf-detected-AR.patch | 36 +++++++++++++ meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + .../openssh/openssh_8.3p1.bb | 4 ++ .../binutils/binutils-2.35.inc | 1 + ...oducibility-for-stabs-debugging-data.patch | 35 +++++++++++++ .../diffstat/diffstat_1.63.bb | 2 + meta/recipes-devtools/libdnf/libdnf_0.48.0.bb | 2 +- .../0001-Use-cross-AR-during-compile.patch | 35 +++++++++++++ meta/recipes-extended/gawk/gawk_5.1.0.bb | 1 + .../clutter/clutter-gst-3.0.inc | 2 + ...-sfnt-Fix-heap-buffer-overflow-59308.patch | 51 +++++++++++++++++++ .../freetype/freetype_2.10.2.bb | 1 + meta/recipes-kernel/linux/kernel-devsrc.bb | 6 +++ meta/recipes-multimedia/alsa/alsa-utils.inc | 3 +- ...size-in-reset-when-maxsize-is-larger.patch | 49 ++++++++++++++++++ .../gstreamer/gstreamer1.0_1.16.3.bb | 1 + meta/recipes-support/libbsd/libbsd_0.10.0.bb | 3 +- .../ptest-runner/ptest-runner_2.4.0.bb | 2 +- 24 files changed, 251 insertions(+), 13 deletions(-) create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/0001-Fix-cross-compilation-using-autoconf-detected-AR.patch create mode 100644 meta/recipes-devtools/binutils/binutils/0017-gas-improve-reproducibility-for-stabs-debugging-data.patch create mode 100644 meta/recipes-extended/gawk/gawk/0001-Use-cross-AR-during-compile.patch create mode 100644 meta/recipes-graphics/freetype/freetype/0001-sfnt-Fix-heap-buffer-overflow-59308.patch create mode 100644
meta/recipes-multimedia/gstreamer/gstreamer1.0/0005-bufferpool-only-resize-in-reset-when-maxsize-is-larger.patch--
2.28.0
Re: [OE-core] [gatesgarth][PATCH 17/19] kernel: provide module.lds for out of tree builds in v5.10+
In reply to Anuj MittalThe wrong version of this patch merged to oe-core, so you don't want this one as-is.
You also need the follow up that I posted today, and that hopefully will be in oe-core soon.
Bruce
Quoted 78 lines · Anuj Mittal
From: Bruce Ashfield <[email protected]>
The upstream commit
596b0474d3d[kbuild: preprocess module linker script], adds a dependency onmodule.ldsfor external module building.Since
module.ldsis generated as part of 'modules_prepare', we must make it available with the other kernel artifacts in the kernel shared workdir, otherwise out of tree builds fail.This fixes errors like:
| make[4]: *** No rule to make target '
scripts/module.lds', needed by'
build/tmp/work/qemuarm64-poky-linux/cryptodev-module/1.11-r0/git/cryptodev.ko'.Stop. | make[4]: *** Waiting for unfinished jobs....We also ensure that kernel-devsrc has a copy to support on target module builds that are often prepared with 'make scripts prepare'. Those targets won't regenerate it, so the build fails. If 'make
modules_prepare' is used, the file will be regenerated and overwrite our copy (as expected).Signed-off-by Pan, Kris <[email protected]>Signed-off-by Lili Li <[email protected]>Signed-off-by Bruce Ashfield <[email protected]>Signed-off-by Richard Purdie <[email protected]>(cherry picked from commit 0fc66a0b64953aae38d0124b57615fffaec8de52)Signed-off-by Anuj Mittal <[email protected]>--- meta/classes/kernel.bbclass | 1 + meta/recipes-kernel/linux/kernel-devsrc.bb | 6 ++++++ 2 files changed, 7 insertions(+)meta/classes/kernel.bbclass +1
-0@@ -486,6 +486,7 @@ do_shared_workdir () { # Copy files required for module builds cp System.map $kerneldir/System.map-${KERNEL_VERSION} [ -e Module.symvers ] && cp Module.symvers $kerneldir/ + [ -e scripts/module.lds ] && install -Dm 0644 scripts/module.lds
$kerneldir/scripts/module.lds
cp .config $kerneldir/
mkdir -p $kerneldir/include/config
cpinclude/config/kernel.release
$kerneldir/include/config/kernel.releasemeta/recipes-kernel/linux/kernel-devsrc.bb +1
-0@@ -86,6 +86,12 @@ do_install() { # be dealt with. # cp -a scripts $kerneldir/build + # although module.lds can be regenerated on target via 'make
modules_prepare'
+ # there are several places where 'makes scripts prepare' is done,
and that won't
+ # regenerate the file. So we copy it onto the target as a
migration to usingmeta/recipes-kernel/linux/kernel-devsrc.bb +2
-0+ # modules_prepare + cp -a --parents scripts/module.lds $kerneldir/build/ 2>/dev/null|| :
+if [ -d arch/${ARCH}/scripts ]; then cp -a arch/${ARCH}/scripts $kerneldir/build/arch/${ARCH} fi--
2.28.0
Signature · 3 lines
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
Hi Martin,
Quoted 7 lines · Martin Jansa
Hi,
Do you still plan to upgrade bluez5 in gatesgarth to 5.55 like dunfell was recently updated?You mentioned it in:
https://lists.openembedded.org/g/openembedded-core/message/144467
but I don't see it in this PR.
Yes, I missed it this time and will include it in the next set.
Thanks,
Anuj
Quoted 116 lines
Quoted 113 lines · Anuj Mittal
Next set of changes for gatesgarth. Please review.
Passed a-full on autobuilder except for one failure. Ping test failed
while executingdo_testimagefor sato image.https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/1602
I think this failure is not related to the changes here as the test passed
in other configurations. Probably similar to:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14029Thanks,
Anuj
The following changes since commit
a1db1e71129c3e67ddd9dbef21e1c5eb31552e00:grub: clean up CVE patches (2020-11-12 11:54:28 +0800)
are available in the Git repository at:
git://push.openembedded.org/openembedded-core-contrib
anujm/gatesgarthAlexander Kanavin (2):
clutter-gst-3.0: do not call out to host gstreamer plugin scanner conf-notes.txt: mention more important images than just satoBruce Ashfield (1):
kernel: providemodule.ldsfor out of tree builds in v5.10+Denys Zagorui (1):
binutils: reproducibility: reuse debug-prefix-map for stabsDiego Santa Cruz (1):
freetype: fix CVE-2020-15999, backport from 2.10.4Gratian Crisan (1):
kernel-module-split.bbclass: identify kernel modconf files as configuration filesJose Quaresma (1):
gstreamer1.0: warn the user when something is wrong with GstBufferPoolKhem Raj (2):
lrzsz: Use Cross AR during compile
gawk: Avoid using host ar during cross compileKonrad Weihmann (3):
oeqa/core/context: expose results as variable
oeqa/core/context: initialize_run_end_time
testimage: print results for interrupted runsMark Jonas (1):
libbsd: Remove BSD-4-Clause from main packageMatt Madison (1):
layer.conf: fix syntax error in PATH settingNathan Rossi (1):
diffstat: add nativesdk to BBCLASSEXTENDRichard Purdie (3):
ptest-runner: Fix license as it contains 'or later' clause
libdnf: Fix license as it contains 'or later' clause
alsa-utils: Fix license to GPLv2 onlySteve Sakoman (1):
openssh: whitelist CVE-2014-9278meta/classes/kernel-module-split.bbclass | 1 + meta/classes/kernel.bbclass | 1 + meta/classes/testimage.bbclass | 19 ++++--- meta/conf/conf-notes.txt | 2 + meta/conf/layer.conf | 2 +- meta/lib/oeqa/core/context.py | 4 ++ ...mpilation-using-autoconf-detected-AR.patch | 36 +++++++++++++ meta/recipes-bsp/lrzsz/lrzsz_0.12.20.bb | 1 + .../openssh/openssh_8.3p1.bb | 4 ++ .../binutils/binutils-2.35.inc | 1 + ...oducibility-for-stabs-debugging-data.patch | 35 +++++++++++++ .../diffstat/diffstat_1.63.bb | 2 + meta/recipes-devtools/libdnf/libdnf_0.48.0.bb | 2 +- .../0001-Use-cross-AR-during-compile.patch | 35 +++++++++++++ meta/recipes-extended/gawk/gawk_5.1.0.bb | 1 + .../clutter/clutter-gst-3.0.inc | 2 + ...-sfnt-Fix-heap-buffer-overflow-59308.patch | 51
+++++++++++++++++++
.../freetype/freetype_2.10.2.bb | 1 + meta/recipes-kernel/linux/kernel-devsrc.bb | 6 +++ meta/recipes-multimedia/alsa/alsa-utils.inc | 3 +- ...size-in-reset-when-maxsize-is-larger.patch | 49
++++++++++++++++++
.../gstreamer/gstreamer1.0_1.16.3.bb | 1 + meta/recipes-support/libbsd/libbsd_0.10.0.bb | 3 +- .../ptest-runner/ptest-runner_2.4.0.bb | 2 +-24 files changed, 251 insertions(+), 13 deletions(-)create mode 100644 meta/recipes-bsp/lrzsz/lrzsz-0.12.20/0001-Fix- cross-compilation-using-autoconf-detected-AR.patch create mode 100644 meta/recipes-devtools/binutils/binutils/0017- gas-improve-reproducibility-for-stabs-debugging-data.patch create mode 100644 meta/recipes-extended/gawk/gawk/0001-Use-cross- AR-during-compile.patch
create mode 100644 meta/recipes-graphics/freetype/freetype/0001- sfnt-Fix-heap-buffer-overflow-59308.patch
create mode 100644 meta/recipes- multimedia/gstreamer/gstreamer1.0/0005-bufferpool-only-resize-in- reset-when-maxsize-is-larger.patch