Skip to contentSkip to conversation

Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs

PATCH Applied Cristian Ciocaltea 6 participants 64 messages Nov 19, 2020 – Dec 28, 2020

Subsystems (5)

v2 of 3 Applied Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover Add CMU/RMU/DMA/MMC/I2C support for Actions Semi S500 SoCs

Hi,

This patchset brings a series of improvements for the Actions Semi S500 SoCs family, by adding support for Clock & Reset Management Units, DMA, MMC, I2C & SIRQ controllers.

Please note the patches consist mostly of DTS and bindings/compatibles changes, since all the work they depend on has been already merged, i.e. clock fixes/additions, pinctrl driver, sirq driver.

For the moment, I have only enabled the features I could test on RoseapplePi SBC.

Thanks,
Cristi

Changes in v2:
- Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
- Added support for the SIRQ controller
- Added new entries in MAINTAINERS
- Updated naming of some patches in v1

Cristian Ciocaltea (18):
arm: dts: owl-s500: Add Clock Management Unit
arm: dts: owl-s500: Set CMU clocks for UARTs
arm: dts: owl-s500: Add Reset controller
dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
dmaengine: owl: Add compatible for the Actions Semi S500 DMA
controller
arm: dts: owl-s500: Add DMA controller
arm: dts: owl-s500: Add pinctrl & GPIO support
dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
arm: dts: owl-s500: Add MMC support
dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
MAINTAINERS: Update entry for Actions Semi Owl I2C binding
i2c: owl: Add compatible for the Actions Semi S500 I2C controller
arm: dts: owl-s500: Add I2C support
arm: dts: owl-s500: Add SIRQ controller
arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
arm: dts: owl-s500-roseapplepi: Add uSD support
arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
MAINTAINERS: Add linux-actions ML for Actions Semi Arch

 .../devicetree/bindings/dma/owl-dma.yaml      |   5 +-
 .../devicetree/bindings/i2c/i2c-owl.txt       |  29 ----
 .../devicetree/bindings/i2c/i2c-owl.yaml      |  62 ++++++++
 .../devicetree/bindings/mmc/owl-mmc.yaml      |   4 +-
 MAINTAINERS                                   |   3 +-
 arch/arm/boot/dts/owl-s500-roseapplepi.dts    |  97 +++++++++++-
 arch/arm/boot/dts/owl-s500.dtsi               | 140 ++++++++++++++++++
 drivers/dma/owl-dma.c                         |   1 +
 drivers/i2c/busses/i2c-owl.c                  |   1 +
 9 files changed, 304 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
Signature · 1 line
2.29.2
#1 lore raw

PATCH v2 1/18 arm: dts: owl-s500: Add Clock Management Unit

Add Clock Management Unit for Actions Semi S500 SoC.

---
 arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +14 -0
index 1dbe4e8b38ac..5d5ad9db549b 100644
@@ -5,6 +5,7 @@
  * Copyright (c) 2016-2017 Andreas Färber
  */
 
+#include <dt-bindings/clock/actions,s500-cmu.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/owl-s500-powergate.h>
 
@@ -70,6 +71,12 @@ hosc: hosc {
 		#clock-cells = <0>;
 	};
 
+	losc: losc {
+		compatible = "fixed-clock";
+		clock-frequency = <32768>;
+		#clock-cells = <0>;
+	};
+
 	soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -169,6 +176,13 @@ uart6: serial@b012c000 {
 			status = "disabled";
 		};
 
+		cmu: clock-controller@b0160000 {
+			compatible = "actions,s500-cmu";
+			reg = <0xb0160000 0x8000>;
+			clocks = <&hosc>, <&losc>;
+			#clock-cells = <1>;
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
Signature · 1 line
2.29.2
#4 lore raw

PATCH v2 2/18 arm: dts: owl-s500: Set CMU clocks for UARTs

In reply to Cristian Ciocaltea

Set Clock Management Unit clocks for the UART nodes of Actions Semi S500 SoCs.

---
 arch/arm/boot/dts/owl-s500.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +7 -0
index 5d5ad9db549b..ac3d04c75dd5 100644
@@ -131,6 +131,7 @@ uart0: serial@b0120000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0120000 0x2000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART0>;
 			status = "disabled";
 		};
 
@@ -138,6 +139,7 @@ uart1: serial@b0122000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0122000 0x2000>;
 			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART1>;
 			status = "disabled";
 		};
 
@@ -145,6 +147,7 @@ uart2: serial@b0124000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0124000 0x2000>;
 			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART2>;
 			status = "disabled";
 		};
 
@@ -152,6 +155,7 @@ uart3: serial@b0126000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0126000 0x2000>;
 			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART3>;
 			status = "disabled";
 		};
 
@@ -159,6 +163,7 @@ uart4: serial@b0128000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0128000 0x2000>;
 			interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART4>;
 			status = "disabled";
 		};
 
@@ -166,6 +171,7 @@ uart5: serial@b012a000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb012a000 0x2000>;
 			interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART5>;
 			status = "disabled";
 		};
 
@@ -173,6 +179,7 @@ uart6: serial@b012c000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb012c000 0x2000>;
 			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART6>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.29.2
#9 lore raw

PATCH v2 4/18 dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC

In reply to Cristian Ciocaltea

Add a new compatible string corresponding to the DMA controller found in the S500 variant of the Actions Semi Owl SoCs family.

---
 Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/dma/owl-dma.yaml +3 -2
index 256d62af2c64..f085f0e42d2c 100644
@@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
 
 description: |
   The OWL DMA is a general-purpose direct memory access controller capable of
-  supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
-  respectively.
+  supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
+  independent DMA channels for the S500 and S900 SoC variants.
 
 maintainers:
   - Manivannan Sadhasivam <[email protected]>
@@ -22,6 +22,7 @@ properties:
     enum:
       - actions,s900-dma
       - actions,s700-dma
+      - actions,s500-dma
 
   reg:
     maxItems: 1
Signature · 1 line
2.29.2
#15 lore raw

PATCH v2 5/18 dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller

In reply to Cristian Ciocaltea

The DMA controller present on the Actions Semi S500 SoC is compatible with the S900 variant, so add it to the list of devices supported by the Actions Semi Owl DMA driver.

---
 drivers/dma/owl-dma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/owl-dma.c +1 -0
index 9fede32641e9..54e509de66e2 100644
@@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
 static const struct of_device_id owl_dma_match[] = {
 	{ .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
 	{ .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
+	{ .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, owl_dma_match);
Signature · 1 line
2.29.2
#19 lore raw

PATCH v2 6/18 arm: dts: owl-s500: Add DMA controller

In reply to Cristian Ciocaltea

Add DMA controller node for Actions Semi S500 SoC.

---
 arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +14 -0
index a57ce7d6d745..449e9807c4ec 100644
@@ -207,5 +207,19 @@ sps: power-controller@b01b0100 {
 			reg = <0xb01b0100 0x100>;
 			#power-domain-cells = <1>;
 		};
+
+		dma: dma-controller@b0260000 {
+			compatible = "actions,s500-dma";
+			reg = <0xb0260000 0xd00>;
+			interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			dma-channels = <12>;
+			dma-requests = <46>;
+			clocks = <&cmu CLK_DMAC>;
+			power-domains = <&sps S500_PD_DMA>;
+		};
 	};
 };
Signature · 1 line
2.29.2
#25 lore raw

PATCH v2 9/18 arm: dts: owl-s500: Add MMC support

In reply to Cristian Ciocaltea

Add MMC controller nodes for Actions Semi S500 SoC, in order to facilitate access to SD/EMMC/SDIO cards.

---
 arch/arm/boot/dts/owl-s500.dtsi | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +33 -0
index b16172615db0..7af7c9e1119d 100644
@@ -241,5 +241,38 @@ dma: dma-controller@b0260000 {
 			clocks = <&cmu CLK_DMAC>;
 			power-domains = <&sps S500_PD_DMA>;
 		};
+
+		mmc0: mmc@b0230000 {
+			compatible = "actions,s500-mmc", "actions,owl-mmc";
+			reg = <0xb0230000 0x38>;
+			interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_SD0>;
+			resets = <&cmu RESET_SD0>;
+			dmas = <&dma 2>;
+			dma-names = "mmc";
+			status = "disabled";
+		};
+
+		mmc1: mmc@b0234000 {
+			compatible = "actions,s500-mmc", "actions,owl-mmc";
+			reg = <0xb0234000 0x38>;
+			interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_SD1>;
+			resets = <&cmu RESET_SD1>;
+			dmas = <&dma 3>;
+			dma-names = "mmc";
+			status = "disabled";
+		};
+
+		mmc2: mmc@b0238000 {
+			compatible = "actions,s500-mmc", "actions,owl-mmc";
+			reg = <0xb0238000 0x38>;
+			interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_SD2>;
+			resets = <&cmu RESET_SD2>;
+			dmas = <&dma 4>;
+			dma-names = "mmc";
+			status = "disabled";
+		};
 	};
 };
Signature · 1 line
2.29.2
#29 lore raw

PATCH v2 10/18 dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema

In reply to Cristian Ciocaltea

Convert the Actions Semi Owl I2C DT binding to a YAML schema for enabling DT validation.

Additionally, add a new compatible string corresponding to the I2C controller found in the S500 variant of the Actions Semi Owl SoCs family.

---
 .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
 .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
Documentation/devicetree/bindings/i2c/i2c-owl.txt deleted +0 -29
deleted file mode 100644
index 54c05dbdb2e4..000000000000
@@ -1,29 +0,0 @@
-Actions Semiconductor Owl I2C controller
-
-Required properties:
-
-- compatible        : Should be one of the following:
-		      - "actions,s700-i2c" for S700 SoC
-		      - "actions,s900-i2c" for S900 SoC
-- reg               : Offset and length of the register set for the device.
-- #address-cells    : Should be 1.
-- #size-cells       : Should be 0.
-- interrupts        : A single interrupt specifier.
-- clocks            : Phandle of the clock feeding the I2C controller.
-
-Optional properties:
-
-- clock-frequency   : Desired I2C bus clock frequency in Hz. As only Normal and
-                      Fast modes are supported, possible values are 100000 and
-                      400000.
-Examples:
-
-        i2c0: i2c@e0170000 {
-                compatible = "actions,s900-i2c";
-                reg = <0 0xe0170000 0 0x1000>;
-                #address-cells = <1>;
-                #size-cells = <0>;
-                interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
-                clocks = <&clock CLK_I2C0>;
-                clock-frequency = <100000>;
-        };
Documentation/devicetree/bindings/i2c/i2c-owl.yaml new file +62 -0

62 lines not on this page · raw message

Signature · 1 line
2.29.2
#33 lore raw

PATCH v2 11/18 MAINTAINERS: Update entry for Actions Semi Owl I2C binding

In reply to Cristian Ciocaltea

The Actions Semi Owl I2C DT binding has been converted to YAML schema, therefore update accordingly the entry in MAINTAINERS.

---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
MAINTAINERS +1 -1
index e451dcce054f..a85c1881cf07 100644
@@ -1501,7 +1501,7 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
 F:	Documentation/devicetree/bindings/dma/owl-dma.yaml
-F:	Documentation/devicetree/bindings/i2c/i2c-owl.txt
+F:	Documentation/devicetree/bindings/i2c/i2c-owl.yaml
 F:	Documentation/devicetree/bindings/interrupt-controller/actions,owl-sirq.yaml
 F:	Documentation/devicetree/bindings/mmc/owl-mmc.yaml
 F:	Documentation/devicetree/bindings/pinctrl/actions,*
Signature · 1 line
2.29.2
#39 lore raw

PATCH v2 13/18 arm: dts: owl-s500: Add I2C support

In reply to Cristian Ciocaltea

Add I2C controller nodes for Actions Semi S500 SoC.

---
 arch/arm/boot/dts/owl-s500.dtsi | 40 +++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +40 -0
index 7af7c9e1119d..55f8b8c2e149 100644
@@ -193,6 +193,46 @@ cmu: clock-controller@b0160000 {
 			#reset-cells = <1>;
 		};
 
+		i2c0: i2c@b0170000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0170000 0x4000>;
+			clocks = <&cmu CLK_I2C0>;
+			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c1: i2c@b0174000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0174000 0x4000>;
+			clocks = <&cmu CLK_I2C1>;
+			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c2: i2c@b0178000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0178000 0x4000>;
+			clocks = <&cmu CLK_I2C2>;
+			interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c3: i2c@b017c000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb017c000 0x4000>;
+			clocks = <&cmu CLK_I2C3>;
+			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
Signature · 1 line
2.29.2
#43 lore raw

PATCH v2 14/18 arm: dts: owl-s500: Add SIRQ controller

In reply to Cristian Ciocaltea

Add SIRQ controller node for Actions Semi S500 SoC.

---
 arch/arm/boot/dts/owl-s500.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +10 -0
index 55f8b8c2e149..cd635f222d26 100644
@@ -233,6 +233,16 @@ i2c3: i2c@b017c000 {
 			status = "disabled";
 		};
 
+		sirq: interrupt-controller@b01b0200 {
+			compatible = "actions,s500-sirq";
+			reg = <0xb01b0200 0x4>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>, /* SIRQ0 */
+				     <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>, /* SIRQ1 */
+				     <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; /* SIRQ2 */
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
Signature · 1 line
2.29.2
#45 lore raw

PATCH v2 15/18 arm: dts: owl-s500-roseapplepi: Use UART clock from CMU

In reply to Cristian Ciocaltea

Remove the UART fixed clock for RoseapplePi SBC and switch to using the clock provided by CMU.

---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 7 -------
 1 file changed, 7 deletions(-)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +0 -7
index a2087e617cb2..800edf5d2d12 100644
@@ -25,12 +25,6 @@ memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x80000000>; /* 2GB */
 	};
-
-	uart2_clk: uart2-clk {
-		compatible = "fixed-clock";
-		clock-frequency = <921600>;
-		#clock-cells = <0>;
-	};
 };
 
 &twd_timer {
@@ -43,5 +37,4 @@ &timer {
 
 &uart2 {
 	status = "okay";
-	clocks = <&uart2_clk>;
 };
Signature · 1 line
2.29.2
#48 lore raw

PATCH v2 16/18 arm: dts: owl-s500-roseapplepi: Add uSD support

In reply to Cristian Ciocaltea

Add uSD support for RoseapplePi SBC using a fixed regulator as a temporary solution until PMIC support becomes available.

---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +50 -0
index 800edf5d2d12..fe9ae3619422 100644
@@ -14,6 +14,7 @@ / {
 	model = "Roseapple Pi";
 
 	aliases {
+		mmc0 = &mmc0;
 		serial2 = &uart2;
 	};
 
@@ -25,6 +26,55 @@ memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x80000000>; /* 2GB */
 	};
+
+	/* Fixed regulator used in the absence of PMIC */
+	sd_vcc: sd-vcc {
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.1V";
+		regulator-min-microvolt = <3100000>;
+		regulator-max-microvolt = <3100000>;
+		regulator-always-on;
+	};
+};
+
+&pinctrl {
+	mmc0_pins: mmc0-pins {
+		pinmux {
+			groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
+				 "sd0_cmd_mfp", "sd0_clk_mfp";
+			function = "sd0";
+		};
+
+		drv-pinconf {
+			groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv";
+			drive-strength = <8>;
+		};
+
+		bias0-pinconf {
+			pins = "sd0_d0", "sd0_d1", "sd0_d2",
+			       "sd0_d3", "sd0_cmd";
+			bias-pull-up;
+		};
+
+		bias1-pinconf {
+			pins = "sd0_clk";
+			bias-pull-down;
+		};
+	};
+};
+
+/* uSD */
+&mmc0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc0_pins>;
+	no-sdio;
+	no-mmc;
+	no-1-8-v;
+	cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	vmmc-supply = <&sd_vcc>;
+	vqmmc-supply = <&sd_vcc>;
 };
 
 &twd_timer {
Signature · 1 line
2.29.2
#55 lore raw

PATCH v2 18/18 MAINTAINERS: Add linux-actions ML for Actions Semi Arch

In reply to Cristian Ciocaltea

Add the linux-actions mailing list for the Actions Semi architecture.

---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +1 -0
index a85c1881cf07..8428aba52581 100644
@@ -1497,6 +1497,7 @@ ARM/ACTIONS SEMI ARCHITECTURE
 M:	Andreas Färber <[email protected]>
 M:	Manivannan Sadhasivam <[email protected]>
 L:	[email protected] (moderated for non-subscribers)
+L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
Signature · 1 line
2.29.2
#52 lore raw

PATCH v2 17/18 arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration

In reply to Cristian Ciocaltea

Add pinctrl definitions for the I2C controllers used in RoseapplePi SBC. For the moment enable only I2C0, which is used by the ATC2603C PMIC.

---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +44 -0
index fe9ae3619422..ff91561ca99c 100644
@@ -37,7 +37,51 @@ sd_vcc: sd-vcc {
 	};
 };
 
+&i2c0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0_pins>;
+};
+
+&i2c1 {
+	status = "disabled";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c1_pins>;
+};
+
+&i2c2 {
+	status = "disabled";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c2_pins>;
+};
+
 &pinctrl {
+	i2c0_pins: i2c0-pins {
+		pinmux {
+			groups = "i2c0_mfp";
+			function = "i2c0";
+		};
+
+		pinconf {
+			pins = "i2c0_sclk", "i2c0_sdata";
+			bias-pull-up;
+		};
+	};
+
+	i2c1_pins: i2c1-pins {
+		pinconf {
+			pins = "i2c1_sclk", "i2c1_sdata";
+			bias-pull-up;
+		};
+	};
+
+	i2c2_pins: i2c2-pins {
+		pinconf {
+			pins = "i2c2_sclk", "i2c2_sdata";
+			bias-pull-up;
+		};
+	};
+
 	mmc0_pins: mmc0-pins {
 		pinmux {
 			groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
Signature · 1 line
2.29.2
#21 lore raw

PATCH v2 7/18 arm: dts: owl-s500: Add pinctrl & GPIO support

In reply to Cristian Ciocaltea

Add pinctrl node for Actions Semi S500 SoC.

---
 arch/arm/boot/dts/owl-s500.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +20 -0
index 449e9807c4ec..b16172615db0 100644
@@ -6,6 +6,7 @@
  */
 
 #include <dt-bindings/clock/actions,s500-cmu.h>
+#include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/owl-s500-powergate.h>
 #include <dt-bindings/reset/actions,s500-reset.h>
@@ -208,6 +209,25 @@ sps: power-controller@b01b0100 {
 			#power-domain-cells = <1>;
 		};
 
+		pinctrl: pinctrl@b01b0000 {
+			compatible = "actions,s500-pinctrl";
+			reg = <0xb01b0000 0x40>, /* GPIO */
+			      <0xb01b0040 0x10>, /* Multiplexing Control */
+			      <0xb01b0060 0x18>, /* PAD Control */
+			      <0xb01b0080 0xc>;  /* PAD Drive Capacity */
+			clocks = <&cmu CLK_GPIO>;
+			gpio-controller;
+			gpio-ranges = <&pinctrl 0 0 132>;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, /* GPIOA */
+				     <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, /* GPIOB */
+				     <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>, /* GPIOC */
+				     <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>, /* GPIOD */
+				     <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; /* GPIOE */
+		};
+
 		dma: dma-controller@b0260000 {
 			compatible = "actions,s500-dma";
 			reg = <0xb0260000 0xd00>;
Signature · 1 line
2.29.2
#35 lore raw

PATCH v2 12/18 i2c: owl: Add compatible for the Actions Semi S500 I2C controller

In reply to Cristian Ciocaltea

Add S500 variant to the list of devices supported by the Actions Semi Owl I2C driver.

---
 drivers/i2c/busses/i2c-owl.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-owl.c +1 -0
index 5cf5a119a6ad..98882fe4e965 100644
@@ -508,6 +508,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id owl_i2c_of_match[] = {
+	{ .compatible = "actions,s500-i2c" },
 	{ .compatible = "actions,s700-i2c" },
 	{ .compatible = "actions,s900-i2c" },
 	{ /* sentinel */ }
Signature · 1 line
2.29.2
#23 lore raw

PATCH v2 8/18 dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC

In reply to Cristian Ciocaltea

Add a new compatible string corresponding to the MMC controller found in the S500 variant of the Actions Semi Owl SoCs family.

---
 Documentation/devicetree/bindings/mmc/owl-mmc.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mmc/owl-mmc.yaml +3 -1
index b6ab527087d5..b0d81ebe0f6e 100644
@@ -17,7 +17,9 @@ properties:
     oneOf:
       - const: actions,owl-mmc
       - items:
-          - const: actions,s700-mmc
+          - enum:
+              - actions,s500-mmc
+              - actions,s700-mmc
           - const: actions,owl-mmc
 
   reg:
Signature · 1 line
2.29.2
#7 lore raw

PATCH v2 3/18 arm: dts: owl-s500: Add Reset controller

In reply to Cristian Ciocaltea

Add reset controller property and bindings header for the Actions Semi S500 SoC DTS.

---
 arch/arm/boot/dts/owl-s500.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +2 -0
index ac3d04c75dd5..a57ce7d6d745 100644
@@ -8,6 +8,7 @@
 #include <dt-bindings/clock/actions,s500-cmu.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/owl-s500-powergate.h>
+#include <dt-bindings/reset/actions,s500-reset.h>
 
 / {
 	compatible = "actions,s500";
@@ -188,6 +189,7 @@ cmu: clock-controller@b0160000 {
 			reg = <0xb0160000 0x8000>;
 			clocks = <&hosc>, <&losc>;
 			#clock-cells = <1>;
+			#reset-cells = <1>;
 		};
 
 		timer: timer@b0168000 {
Signature · 1 line
2.29.2
#24 lore raw

Re: [PATCH v2 08/18] dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC

In reply to Cristian Ciocaltea
Quoted 5 lines · Cristian Ciocaltea

Add a new compatible string corresponding to the MMC controller found in the S500 variant of the Actions Semi Owl SoCs family.

Applied for next, thanks!

Kind regards
Uffe

Quoted 22 lines
---
 Documentation/devicetree/bindings/mmc/owl-mmc.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Documentation/devicetree/bindings/mmc/owl-mmc.yaml +3 -2
index b6ab527087d5..b0d81ebe0f6e 100644
@@ -17,7 +17,9 @@ properties:
     oneOf:
       - const: actions,owl-mmc
       - items:
-          - const: actions,s700-mmc
+          - enum:
+              - actions,s500-mmc
+              - actions,s700-mmc
           - const: actions,owl-mmc
 
   reg:
--

2.29.2

Reviewed-by on v2 9/18
#26 lore raw

Re: [PATCH v2 09/18] arm: dts: owl-s500: Add MMC support

In reply to Cristian Ciocaltea
Quoted 5 lines · Cristian Ciocaltea

Add MMC controller nodes for Actions Semi S500 SoC, in order to facilitate access to SD/EMMC/SDIO cards.

Kind regards
Uffe

Quoted 50 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +33 -1
index b16172615db0..7af7c9e1119d 100644
@@ -241,5 +241,38 @@ dma: dma-controller@b0260000 {
                        clocks = <&cmu CLK_DMAC>;
                        power-domains = <&sps S500_PD_DMA>;
                };
+
+               mmc0: mmc@b0230000 {
+                       compatible = "actions,s500-mmc", "actions,owl-mmc";
+                       reg = <0xb0230000 0x38>;
+                       interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&cmu CLK_SD0>;
+                       resets = <&cmu RESET_SD0>;
+                       dmas = <&dma 2>;
+                       dma-names = "mmc";
+                       status = "disabled";
+               };
+
+               mmc1: mmc@b0234000 {
+                       compatible = "actions,s500-mmc", "actions,owl-mmc";
+                       reg = <0xb0234000 0x38>;
+                       interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&cmu CLK_SD1>;
+                       resets = <&cmu RESET_SD1>;
+                       dmas = <&dma 3>;
+                       dma-names = "mmc";
+                       status = "disabled";
+               };
+
+               mmc2: mmc@b0238000 {
+                       compatible = "actions,s500-mmc", "actions,owl-mmc";
+                       reg = <0xb0238000 0x38>;
+                       interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&cmu CLK_SD2>;
+                       resets = <&cmu RESET_SD2>;
+                       dmas = <&dma 4>;
+                       dma-names = "mmc";
+                       status = "disabled";
+               };
        };
 };
--

2.29.2

#27 lore raw

Re: [PATCH v2 09/18] arm: dts: owl-s500: Add MMC support

Quoted 6 lines · Ulf Hansson
Quoted 4 lines · Cristian Ciocaltea

Add MMC controller nodes for Actions Semi S500 SoC, in order to facilitate access to SD/EMMC/SDIO cards.

Quoted 7 lines
Quoted 1 line

Kind regards
Uffe

Thanks for the review!

Regards,
Cristi

Quoted 51 lines
Quoted 51 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +33 -1
index b16172615db0..7af7c9e1119d 100644
@@ -241,5 +241,38 @@ dma: dma-controller@b0260000 {
                        clocks = <&cmu CLK_DMAC>;
                        power-domains = <&sps S500_PD_DMA>;
                };
+
+               mmc0: mmc@b0230000 {
+                       compatible = "actions,s500-mmc", "actions,owl-mmc";
+                       reg = <0xb0230000 0x38>;
+                       interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&cmu CLK_SD0>;
+                       resets = <&cmu RESET_SD0>;
+                       dmas = <&dma 2>;
+                       dma-names = "mmc";
+                       status = "disabled";
+               };
+
+               mmc1: mmc@b0234000 {
+                       compatible = "actions,s500-mmc", "actions,owl-mmc";
+                       reg = <0xb0234000 0x38>;
+                       interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&cmu CLK_SD1>;
+                       resets = <&cmu RESET_SD1>;
+                       dmas = <&dma 3>;
+                       dma-names = "mmc";
+                       status = "disabled";
+               };
+
+               mmc2: mmc@b0238000 {
+                       compatible = "actions,s500-mmc", "actions,owl-mmc";
+                       reg = <0xb0238000 0x38>;
+                       interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+                       clocks = <&cmu CLK_SD2>;
+                       resets = <&cmu RESET_SD2>;
+                       dmas = <&dma 4>;
+                       dma-names = "mmc";
+                       status = "disabled";
+               };
        };
 };
--

2.29.2

Reviewed-by on v2 12/18
#36 lore raw

Re: [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Add S500 variant to the list of devices supported by the Actions Semi Owl I2C driver.

Ah, I thought S500 support needs some change...

Thanks,
Mani

Quoted 19 lines
---
 drivers/i2c/busses/i2c-owl.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-owl.c +1 -0
index 5cf5a119a6ad..98882fe4e965 100644
@@ -508,6 +508,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id owl_i2c_of_match[] = {
+	{ .compatible = "actions,s500-i2c" },
 	{ .compatible = "actions,s700-i2c" },
 	{ .compatible = "actions,s900-i2c" },
 	{ /* sentinel */ }
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 1/18
#2 lore raw

Re: [PATCH v2 01/18] arm: dts: owl-s500: Add Clock Management Unit

In reply to Cristian Ciocaltea
Quoted 3 lines · Cristian Ciocaltea

Add Clock Management Unit for Actions Semi S500 SoC.

Thanks,
Mani

Quoted 46 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +14 -0
index 1dbe4e8b38ac..5d5ad9db549b 100644
@@ -5,6 +5,7 @@
  * Copyright (c) 2016-2017 Andreas Färber
  */
 
+#include <dt-bindings/clock/actions,s500-cmu.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/owl-s500-powergate.h>
 
@@ -70,6 +71,12 @@ hosc: hosc {
 		#clock-cells = <0>;
 	};
 
+	losc: losc {
+		compatible = "fixed-clock";
+		clock-frequency = <32768>;
+		#clock-cells = <0>;
+	};
+
 	soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -169,6 +176,13 @@ uart6: serial@b012c000 {
 			status = "disabled";
 		};
 
+		cmu: clock-controller@b0160000 {
+			compatible = "actions,s500-cmu";
+			reg = <0xb0160000 0x8000>;
+			clocks = <&hosc>, <&losc>;
+			#clock-cells = <1>;
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 2/18
#5 lore raw

Re: [PATCH v2 02/18] arm: dts: owl-s500: Set CMU clocks for UARTs

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Set Clock Management Unit clocks for the UART nodes of Actions Semi S500 SoCs.

Also in this patch itself, you need to remove the dummy "uart3_clk" from S500 dts. With that,

Thanks,
Mani

Quoted 67 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +7 -0
index 5d5ad9db549b..ac3d04c75dd5 100644
@@ -131,6 +131,7 @@ uart0: serial@b0120000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0120000 0x2000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART0>;
 			status = "disabled";
 		};
 
@@ -138,6 +139,7 @@ uart1: serial@b0122000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0122000 0x2000>;
 			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART1>;
 			status = "disabled";
 		};
 
@@ -145,6 +147,7 @@ uart2: serial@b0124000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0124000 0x2000>;
 			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART2>;
 			status = "disabled";
 		};
 
@@ -152,6 +155,7 @@ uart3: serial@b0126000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0126000 0x2000>;
 			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART3>;
 			status = "disabled";
 		};
 
@@ -159,6 +163,7 @@ uart4: serial@b0128000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0128000 0x2000>;
 			interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART4>;
 			status = "disabled";
 		};
 
@@ -166,6 +171,7 @@ uart5: serial@b012a000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb012a000 0x2000>;
 			interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART5>;
 			status = "disabled";
 		};
 
@@ -173,6 +179,7 @@ uart6: serial@b012c000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb012c000 0x2000>;
 			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART6>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 3/18
#8 lore raw

Re: [PATCH v2 03/18] arm: dts: owl-s500: Add Reset controller

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Add reset controller property and bindings header for the Actions Semi S500 SoC DTS.

Thanks,
Mani

Quoted 27 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +2 -0
index ac3d04c75dd5..a57ce7d6d745 100644
@@ -8,6 +8,7 @@
 #include <dt-bindings/clock/actions,s500-cmu.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/owl-s500-powergate.h>
+#include <dt-bindings/reset/actions,s500-reset.h>
 
 / {
 	compatible = "actions,s500";
@@ -188,6 +189,7 @@ cmu: clock-controller@b0160000 {
 			reg = <0xb0160000 0x8000>;
 			clocks = <&hosc>, <&losc>;
 			#clock-cells = <1>;
+			#reset-cells = <1>;
 		};
 
 		timer: timer@b0168000 {
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 4/18
#10 lore raw

Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Add a new compatible string corresponding to the DMA controller found in the S500 variant of the Actions Semi Owl SoCs family.

Thanks,
Mani

Quoted 30 lines
---
 Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/dma/owl-dma.yaml +3 -2
index 256d62af2c64..f085f0e42d2c 100644
@@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
 
 description: |
   The OWL DMA is a general-purpose direct memory access controller capable of
-  supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
-  respectively.
+  supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
+  independent DMA channels for the S500 and S900 SoC variants.
 
 maintainers:
   - Manivannan Sadhasivam <[email protected]>
@@ -22,6 +22,7 @@ properties:
     enum:
       - actions,s900-dma
       - actions,s700-dma
+      - actions,s500-dma
 
   reg:
     maxItems: 1
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#11 lore raw

Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC

In reply to Cristian Ciocaltea
Quoted 24 lines · Cristian Ciocaltea

Add a new compatible string corresponding to the DMA controller found in the S500 variant of the Actions Semi Owl SoCs family.

---
 Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/dma/owl-dma.yaml +2 -2
index 256d62af2c64..f085f0e42d2c 100644
@@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
 
 description: |
   The OWL DMA is a general-purpose direct memory access controller capable of
-  supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
-  respectively.
+  supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
+  independent DMA channels for the S500 and S900 SoC variants.
 
 maintainers:
   - Manivannan Sadhasivam <[email protected]>

Documentation/devicetree/bindings/dma/owl-dma.yaml properties: · line 25

Quoted 4 lines
Documentation/devicetree/bindings/dma/owl-dma.yaml +1 -0
@@ -22,6 +22,7 @@ properties:
     enum:
       - actions,s900-dma
       - actions,s700-dma
+      - actions,s500-dma

I think we should order the entries now...

Quoted 6 lines
Documentation/devicetree/bindings/dma/owl-dma.yaml +0 -0
   reg:
     maxItems: 1
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 5/18
#16 lore raw

Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller

In reply to Cristian Ciocaltea
Quoted 5 lines · Cristian Ciocaltea

The DMA controller present on the Actions Semi S500 SoC is compatible with the S900 variant, so add it to the list of devices supported by the Actions Semi Owl DMA driver.

I hope that you have verified both Memcpy and Slave transfers...

Thanks,
Mani

Quoted 19 lines
---
 drivers/dma/owl-dma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/owl-dma.c +1 -0
index 9fede32641e9..54e509de66e2 100644
@@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
 static const struct of_device_id owl_dma_match[] = {
 	{ .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
 	{ .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
+	{ .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, owl_dma_match);
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 6/18
#20 lore raw

Re: [PATCH v2 06/18] arm: dts: owl-s500: Add DMA controller

In reply to Cristian Ciocaltea
Quoted 3 lines · Cristian Ciocaltea

Add DMA controller node for Actions Semi S500 SoC.

Thanks,
Mani

Quoted 31 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +14 -0
index a57ce7d6d745..449e9807c4ec 100644
@@ -207,5 +207,19 @@ sps: power-controller@b01b0100 {
 			reg = <0xb01b0100 0x100>;
 			#power-domain-cells = <1>;
 		};
+
+		dma: dma-controller@b0260000 {
+			compatible = "actions,s500-dma";
+			reg = <0xb0260000 0xd00>;
+			interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
+			#dma-cells = <1>;
+			dma-channels = <12>;
+			dma-requests = <46>;
+			clocks = <&cmu CLK_DMAC>;
+			power-domains = <&sps S500_PD_DMA>;
+		};
 	};
 };
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 7/18
#22 lore raw

Re: [PATCH v2 07/18] arm: dts: owl-s500: Add pinctrl & GPIO support

In reply to Cristian Ciocaltea
Quoted 3 lines · Cristian Ciocaltea

Add pinctrl node for Actions Semi S500 SoC.

Thanks,
Mani

Quoted 45 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +20 -0
index 449e9807c4ec..b16172615db0 100644
@@ -6,6 +6,7 @@
  */
 
 #include <dt-bindings/clock/actions,s500-cmu.h>
+#include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/owl-s500-powergate.h>
 #include <dt-bindings/reset/actions,s500-reset.h>
@@ -208,6 +209,25 @@ sps: power-controller@b01b0100 {
 			#power-domain-cells = <1>;
 		};
 
+		pinctrl: pinctrl@b01b0000 {
+			compatible = "actions,s500-pinctrl";
+			reg = <0xb01b0000 0x40>, /* GPIO */
+			      <0xb01b0040 0x10>, /* Multiplexing Control */
+			      <0xb01b0060 0x18>, /* PAD Control */
+			      <0xb01b0080 0xc>;  /* PAD Drive Capacity */
+			clocks = <&cmu CLK_GPIO>;
+			gpio-controller;
+			gpio-ranges = <&pinctrl 0 0 132>;
+			#gpio-cells = <2>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>, /* GPIOA */
+				     <GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>, /* GPIOB */
+				     <GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>, /* GPIOC */
+				     <GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>, /* GPIOD */
+				     <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>; /* GPIOE */
+		};
+
 		dma: dma-controller@b0260000 {
 			compatible = "actions,s500-dma";
 			reg = <0xb0260000 0xd00>;
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 9/18
#28 lore raw

Re: [PATCH v2 09/18] arm: dts: owl-s500: Add MMC support

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Add MMC controller nodes for Actions Semi S500 SoC, in order to facilitate access to SD/EMMC/SDIO cards.

Thanks,
Mani

Quoted 50 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +33 -0
index b16172615db0..7af7c9e1119d 100644
@@ -241,5 +241,38 @@ dma: dma-controller@b0260000 {
 			clocks = <&cmu CLK_DMAC>;
 			power-domains = <&sps S500_PD_DMA>;
 		};
+
+		mmc0: mmc@b0230000 {
+			compatible = "actions,s500-mmc", "actions,owl-mmc";
+			reg = <0xb0230000 0x38>;
+			interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_SD0>;
+			resets = <&cmu RESET_SD0>;
+			dmas = <&dma 2>;
+			dma-names = "mmc";
+			status = "disabled";
+		};
+
+		mmc1: mmc@b0234000 {
+			compatible = "actions,s500-mmc", "actions,owl-mmc";
+			reg = <0xb0234000 0x38>;
+			interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_SD1>;
+			resets = <&cmu RESET_SD1>;
+			dmas = <&dma 3>;
+			dma-names = "mmc";
+			status = "disabled";
+		};
+
+		mmc2: mmc@b0238000 {
+			compatible = "actions,s500-mmc", "actions,owl-mmc";
+			reg = <0xb0238000 0x38>;
+			interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_SD2>;
+			resets = <&cmu RESET_SD2>;
+			dmas = <&dma 4>;
+			dma-names = "mmc";
+			status = "disabled";
+		};
 	};
 };
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 12/18
#37 lore raw

Re: [PATCH v2 12/18] i2c: owl: Add compatible for the Actions Semi S500 I2C controller

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Add S500 variant to the list of devices supported by the Actions Semi Owl I2C driver.

Thanks,
Mani

Quoted 19 lines
---
 drivers/i2c/busses/i2c-owl.c | 1 +
 1 file changed, 1 insertion(+)
drivers/i2c/busses/i2c-owl.c +1 -0
index 5cf5a119a6ad..98882fe4e965 100644
@@ -508,6 +508,7 @@ static int owl_i2c_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id owl_i2c_of_match[] = {
+	{ .compatible = "actions,s500-i2c" },
 	{ .compatible = "actions,s700-i2c" },
 	{ .compatible = "actions,s900-i2c" },
 	{ /* sentinel */ }
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 13/18
#40 lore raw

Re: [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support

In reply to Cristian Ciocaltea
Quoted 3 lines · Cristian Ciocaltea

Add I2C controller nodes for Actions Semi S500 SoC.

Thanks,
Mani

Quoted 58 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 40 +++++++++++++++++++++++++++++++++
 1 file changed, 40 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +40 -0
index 7af7c9e1119d..55f8b8c2e149 100644
@@ -193,6 +193,46 @@ cmu: clock-controller@b0160000 {
 			#reset-cells = <1>;
 		};
 
+		i2c0: i2c@b0170000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0170000 0x4000>;
+			clocks = <&cmu CLK_I2C0>;
+			interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c1: i2c@b0174000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0174000 0x4000>;
+			clocks = <&cmu CLK_I2C1>;
+			interrupts = <GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c2: i2c@b0178000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb0178000 0x4000>;
+			clocks = <&cmu CLK_I2C2>;
+			interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
+		i2c3: i2c@b017c000 {
+			compatible = "actions,s500-i2c";
+			reg = <0xb017c000 0x4000>;
+			clocks = <&cmu CLK_I2C3>;
+			interrupts = <GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>;
+			#address-cells = <1>;
+			#size-cells = <0>;
+			status = "disabled";
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 14/18
#44 lore raw

Re: [PATCH v2 14/18] arm: dts: owl-s500: Add SIRQ controller

In reply to Cristian Ciocaltea
Quoted 3 lines · Cristian Ciocaltea

Add SIRQ controller node for Actions Semi S500 SoC.

Thanks,
Mani

Quoted 28 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 10 ++++++++++
 1 file changed, 10 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +10 -0
index 55f8b8c2e149..cd635f222d26 100644
@@ -233,6 +233,16 @@ i2c3: i2c@b017c000 {
 			status = "disabled";
 		};
 
+		sirq: interrupt-controller@b01b0200 {
+			compatible = "actions,s500-sirq";
+			reg = <0xb01b0200 0x4>;
+			interrupt-controller;
+			#interrupt-cells = <2>;
+			interrupts = <GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>, /* SIRQ0 */
+				     <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>, /* SIRQ1 */
+				     <GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>; /* SIRQ2 */
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#46 lore raw

Re: [PATCH v2 15/18] arm: dts: owl-s500-roseapplepi: Use UART clock from CMU

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Remove the UART fixed clock for RoseapplePi SBC and switch to using the clock provided by CMU.

Please club this patch with the one adding CMU clock.

Thanks,
Mani

Quoted 30 lines
---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 7 -------
 1 file changed, 7 deletions(-)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +0 -7
index a2087e617cb2..800edf5d2d12 100644
@@ -25,12 +25,6 @@ memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x80000000>; /* 2GB */
 	};
-
-	uart2_clk: uart2-clk {
-		compatible = "fixed-clock";
-		clock-frequency = <921600>;
-		#clock-cells = <0>;
-	};
 };
 
 &twd_timer {
@@ -43,5 +37,4 @@ &timer {
 
 &uart2 {
 	status = "okay";
-	clocks = <&uart2_clk>;
 };
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

#49 lore raw

Re: [PATCH v2 16/18] arm: dts: owl-s500-roseapplepi: Add uSD support

In reply to Cristian Ciocaltea
Quoted 21 lines · Cristian Ciocaltea

Add uSD support for RoseapplePi SBC using a fixed regulator as a temporary solution until PMIC support becomes available.

---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +1 -0
index 800edf5d2d12..fe9ae3619422 100644
@@ -14,6 +14,7 @@ / {
 	model = "Roseapple Pi";
 
 	aliases {
+		mmc0 = &mmc0;
 		serial2 = &uart2;
 	};
 

arch/arm/boot/dts/owl-s500-roseapplepi.dts memory@0 { · line 31

Quoted 6 lines
arch/arm/boot/dts/owl-s500-roseapplepi.dts +3 -0
@@ -25,6 +26,55 @@ memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x80000000>; /* 2GB */
 	};
+
+	/* Fixed regulator used in the absence of PMIC */
+	sd_vcc: sd-vcc {

Is this the exact name in the schematics?

Thanks,
Mani

Quoted 52 lines
arch/arm/boot/dts/owl-s500-roseapplepi.dts +46 -0
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.1V";
+		regulator-min-microvolt = <3100000>;
+		regulator-max-microvolt = <3100000>;
+		regulator-always-on;
+	};
+};
+
+&pinctrl {
+	mmc0_pins: mmc0-pins {
+		pinmux {
+			groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
+				 "sd0_cmd_mfp", "sd0_clk_mfp";
+			function = "sd0";
+		};
+
+		drv-pinconf {
+			groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv";
+			drive-strength = <8>;
+		};
+
+		bias0-pinconf {
+			pins = "sd0_d0", "sd0_d1", "sd0_d2",
+			       "sd0_d3", "sd0_cmd";
+			bias-pull-up;
+		};
+
+		bias1-pinconf {
+			pins = "sd0_clk";
+			bias-pull-down;
+		};
+	};
+};
+
+/* uSD */
+&mmc0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc0_pins>;
+	no-sdio;
+	no-mmc;
+	no-1-8-v;
+	cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	vmmc-supply = <&sd_vcc>;
+	vqmmc-supply = <&sd_vcc>;
 };
 
 &twd_timer {
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 17/18
#53 lore raw

Re: [PATCH v2 17/18] arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration

In reply to Cristian Ciocaltea
Quoted 4 lines · Cristian Ciocaltea

Add pinctrl definitions for the I2C controllers used in RoseapplePi SBC. For the moment enable only I2C0, which is used by the ATC2603C PMIC.

Earlier we used to add "_default" suffix for the pin groups to differentiate between active and sleep states. But I guess we can just keep the suffix away until we hit usecase.

Thanks,
Mani

Quoted 63 lines
---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +44 -0
index fe9ae3619422..ff91561ca99c 100644
@@ -37,7 +37,51 @@ sd_vcc: sd-vcc {
 	};
 };
 
+&i2c0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0_pins>;
+};
+
+&i2c1 {
+	status = "disabled";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c1_pins>;
+};
+
+&i2c2 {
+	status = "disabled";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c2_pins>;
+};
+
 &pinctrl {
+	i2c0_pins: i2c0-pins {
+		pinmux {
+			groups = "i2c0_mfp";
+			function = "i2c0";
+		};
+
+		pinconf {
+			pins = "i2c0_sclk", "i2c0_sdata";
+			bias-pull-up;
+		};
+	};
+
+	i2c1_pins: i2c1-pins {
+		pinconf {
+			pins = "i2c1_sclk", "i2c1_sdata";
+			bias-pull-up;
+		};
+	};
+
+	i2c2_pins: i2c2-pins {
+		pinconf {
+			pins = "i2c2_sclk", "i2c2_sdata";
+			bias-pull-up;
+		};
+	};
+
 	mmc0_pins: mmc0-pins {
 		pinmux {
 			groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Reviewed-by on v2 18/18
#56 lore raw

Re: [PATCH v2 18/18] MAINTAINERS: Add linux-actions ML for Actions Semi Arch

In reply to Cristian Ciocaltea
Quoted 3 lines · Cristian Ciocaltea

Add the linux-actions mailing list for the Actions Semi architecture.

There was a patch from me for this change but I don't mind taking yours as long as we keep the list updated :)

I have just one comment below, with that fixed:

MAINTAINERS ARM/ACTIONS SEMI ARCHITECTURE · line 1499

Quoted 12 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index a85c1881cf07..8428aba52581 100644
@@ -1497,6 +1497,7 @@ ARM/ACTIONS SEMI ARCHITECTURE
 M:	Andreas Färber <[email protected]>
 M:	Manivannan Sadhasivam <[email protected]>
 L:	[email protected] (moderated for non-subscribers)

No need to keep the generic list, please remove.

Thanks,
Mani

Quoted 7 lines
MAINTAINERS +1 -0
+L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
Signature · 1 line
2.29.2
#3 lore raw

Re: [PATCH v2 01/18] arm: dts: owl-s500: Add Clock Management Unit

In reply to Manivannan Sadhasivam
Quoted 6 lines · Manivannan Sadhasivam
Quoted 3 lines · Cristian Ciocaltea

Add Clock Management Unit for Actions Semi S500 SoC.

Thanks for taking the time to review this patch series!

Kind regards,
Cristi

Quoted 49 lines

Thanks,
Mani

Quoted 46 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +14 -0
index 1dbe4e8b38ac..5d5ad9db549b 100644
@@ -5,6 +5,7 @@
  * Copyright (c) 2016-2017 Andreas Färber
  */
 
+#include <dt-bindings/clock/actions,s500-cmu.h>
 #include <dt-bindings/interrupt-controller/arm-gic.h>
 #include <dt-bindings/power/owl-s500-powergate.h>
 
@@ -70,6 +71,12 @@ hosc: hosc {
 		#clock-cells = <0>;
 	};
 
+	losc: losc {
+		compatible = "fixed-clock";
+		clock-frequency = <32768>;
+		#clock-cells = <0>;
+	};
+
 	soc {
 		compatible = "simple-bus";
 		#address-cells = <1>;
@@ -169,6 +176,13 @@ uart6: serial@b012c000 {
 			status = "disabled";
 		};
 
+		cmu: clock-controller@b0160000 {
+			compatible = "actions,s500-cmu";
+			reg = <0xb0160000 0x8000>;
+			clocks = <&hosc>, <&losc>;
+			#clock-cells = <1>;
+		};
+
 		timer: timer@b0168000 {
 			compatible = "actions,s500-timer";
 			reg = <0xb0168000 0x8000>;
Signature · 1 line
2.29.2
#6 lore raw

Re: [PATCH v2 02/18] arm: dts: owl-s500: Set CMU clocks for UARTs

In reply to Manivannan Sadhasivam
Quoted 8 lines · Manivannan Sadhasivam
Quoted 4 lines · Cristian Ciocaltea

Set Clock Management Unit clocks for the UART nodes of Actions Semi S500 SoCs.

Also in this patch itself, you need to remove the dummy "uart3_clk" from S500 dts. With that,

I have prepared the updated patch with the requested changes, including also the merge of the RoseapplePi related patch (no. 15 in this series).

Thanks,
Cristi

Quoted 72 lines

Thanks,
Mani

Quoted 67 lines
---
 arch/arm/boot/dts/owl-s500.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/boot/dts/owl-s500.dtsi +7 -0
index 5d5ad9db549b..ac3d04c75dd5 100644
@@ -131,6 +131,7 @@ uart0: serial@b0120000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0120000 0x2000>;
 			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART0>;
 			status = "disabled";
 		};
 
@@ -138,6 +139,7 @@ uart1: serial@b0122000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0122000 0x2000>;
 			interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART1>;
 			status = "disabled";
 		};
 
@@ -145,6 +147,7 @@ uart2: serial@b0124000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0124000 0x2000>;
 			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART2>;
 			status = "disabled";
 		};
 
@@ -152,6 +155,7 @@ uart3: serial@b0126000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0126000 0x2000>;
 			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART3>;
 			status = "disabled";
 		};
 
@@ -159,6 +163,7 @@ uart4: serial@b0128000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb0128000 0x2000>;
 			interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART4>;
 			status = "disabled";
 		};
 
@@ -166,6 +171,7 @@ uart5: serial@b012a000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb012a000 0x2000>;
 			interrupts = <GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART5>;
 			status = "disabled";
 		};
 
@@ -173,6 +179,7 @@ uart6: serial@b012c000 {
 			compatible = "actions,s500-uart", "actions,owl-uart";
 			reg = <0xb012c000 0x2000>;
 			interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cmu CLK_UART6>;
 			status = "disabled";
 		};
 
Signature · 1 line
2.29.2
#12 lore raw

Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC

In reply to Manivannan Sadhasivam
Quoted 22 lines · Manivannan Sadhasivam
Quoted 21 lines · Cristian Ciocaltea

Add a new compatible string corresponding to the DMA controller found in the S500 variant of the Actions Semi Owl SoCs family.

---
 Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/dma/owl-dma.yaml +2 -2
index 256d62af2c64..f085f0e42d2c 100644
@@ -8,8 +8,8 @@ title: Actions Semi Owl SoCs DMA controller
 
 description: |
   The OWL DMA is a general-purpose direct memory access controller capable of
-  supporting 10 and 12 independent DMA channels for S700 and S900 SoCs
-  respectively.
+  supporting 10 independent DMA channels for the Actions Semi S700 SoC and 12
+  independent DMA channels for the S500 and S900 SoC variants.
 
Quoted 9 lines

Documentation/devicetree/bindings/dma/owl-dma.yaml properties: · line 25

Quoted 7 lines
Documentation/devicetree/bindings/dma/owl-dma.yaml +1 -0
 maintainers:
   - Manivannan Sadhasivam <[email protected]>
@@ -22,6 +22,7 @@ properties:
     enum:
       - actions,s900-dma
       - actions,s700-dma
+      - actions,s500-dma

I think we should order the entries now...

Right, I will provide the reordered list in the upcoming revision.

Quoted 6 lines
Quoted 6 lines
Documentation/devicetree/bindings/dma/owl-dma.yaml +0 -0
   reg:
     maxItems: 1
Signature · 1 line
2.29.2
#17 lore raw

Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller

In reply to Manivannan Sadhasivam
Quoted 8 lines · Manivannan Sadhasivam
Quoted 5 lines · Cristian Ciocaltea

The DMA controller present on the Actions Semi S500 SoC is compatible with the S900 variant, so add it to the list of devices supported by the Actions Semi Owl DMA driver.

I hope that you have verified both Memcpy and Slave transfers...

I have been using 'dmatest' module as documented in:
https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html

I tested all the available channels and could not find any signs of possible issues. Bellow is an excerpt from the kernel ring buffer:

[ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0)
[ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0)
[ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0)

Should I perform some additional tests?

Thanks,
Cristi

Quoted 24 lines

Thanks,
Mani

Quoted 19 lines
---
 drivers/dma/owl-dma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/owl-dma.c +1 -0
index 9fede32641e9..54e509de66e2 100644
@@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
 static const struct of_device_id owl_dma_match[] = {
 	{ .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
 	{ .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
+	{ .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, owl_dma_match);
Signature · 1 line
2.29.2
#47 lore raw

Re: [PATCH v2 15/18] arm: dts: owl-s500-roseapplepi: Use UART clock from CMU

In reply to Manivannan Sadhasivam
Quoted 7 lines · Manivannan Sadhasivam
Quoted 4 lines · Cristian Ciocaltea

Remove the UART fixed clock for RoseapplePi SBC and switch to using the clock provided by CMU.

Please club this patch with the one adding CMU clock.

Done.

Thanks,
Cristi

Quoted 33 lines

Thanks,
Mani

Quoted 30 lines
---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 7 -------
 1 file changed, 7 deletions(-)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +0 -7
index a2087e617cb2..800edf5d2d12 100644
@@ -25,12 +25,6 @@ memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x80000000>; /* 2GB */
 	};
-
-	uart2_clk: uart2-clk {
-		compatible = "fixed-clock";
-		clock-frequency = <921600>;
-		#clock-cells = <0>;
-	};
 };
 
 &twd_timer {
@@ -43,5 +37,4 @@ &timer {
 
 &uart2 {
 	status = "okay";
-	clocks = <&uart2_clk>;
 };
Signature · 1 line
2.29.2
#50 lore raw

Re: [PATCH v2 16/18] arm: dts: owl-s500-roseapplepi: Add uSD support

In reply to Manivannan Sadhasivam
Quoted 21 lines · Manivannan Sadhasivam
Quoted 20 lines · Cristian Ciocaltea

Add uSD support for RoseapplePi SBC using a fixed regulator as a temporary solution until PMIC support becomes available.

---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +1 -0
index 800edf5d2d12..fe9ae3619422 100644
@@ -14,6 +14,7 @@ / {
 	model = "Roseapple Pi";
 
 	aliases {
+		mmc0 = &mmc0;
 		serial2 = &uart2;
 	};
 
Quoted 9 lines

arch/arm/boot/dts/owl-s500-roseapplepi.dts memory@0 { · line 31

Quoted 7 lines
arch/arm/boot/dts/owl-s500-roseapplepi.dts +3 -0
@@ -25,6 +26,55 @@ memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x80000000>; /* 2GB */
 	};
+
+	/* Fixed regulator used in the absence of PMIC */
+	sd_vcc: sd-vcc {

Is this the exact name in the schematics?

Yes, it is referred as "SD_VCC". Once the support for the ATC260x PMIC will be available, the following item will be present in the regulators list:

  sd_vcc: switchldo1 {
	regulator-name = "SD_VCC";
	regulator-min-microvolt = <3000000>;
	regulator-max-microvolt = <3300000>;
	regulator-always-on;
	regulator-boot-on;

};

Thanks,
Cristi

Quoted 55 lines

Thanks,
Mani

Quoted 52 lines
arch/arm/boot/dts/owl-s500-roseapplepi.dts +46 -0
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.1V";
+		regulator-min-microvolt = <3100000>;
+		regulator-max-microvolt = <3100000>;
+		regulator-always-on;
+	};
+};
+
+&pinctrl {
+	mmc0_pins: mmc0-pins {
+		pinmux {
+			groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
+				 "sd0_cmd_mfp", "sd0_clk_mfp";
+			function = "sd0";
+		};
+
+		drv-pinconf {
+			groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv";
+			drive-strength = <8>;
+		};
+
+		bias0-pinconf {
+			pins = "sd0_d0", "sd0_d1", "sd0_d2",
+			       "sd0_d3", "sd0_cmd";
+			bias-pull-up;
+		};
+
+		bias1-pinconf {
+			pins = "sd0_clk";
+			bias-pull-down;
+		};
+	};
+};
+
+/* uSD */
+&mmc0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc0_pins>;
+	no-sdio;
+	no-mmc;
+	no-1-8-v;
+	cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	vmmc-supply = <&sd_vcc>;
+	vqmmc-supply = <&sd_vcc>;
 };
 
 &twd_timer {
Signature · 1 line
2.29.2
#54 lore raw

Re: [PATCH v2 17/18] arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration

In reply to Manivannan Sadhasivam
Quoted 9 lines · Manivannan Sadhasivam
Quoted 4 lines · Cristian Ciocaltea

Add pinctrl definitions for the I2C controllers used in RoseapplePi SBC. For the moment enable only I2C0, which is used by the ATC2603C PMIC.

Earlier we used to add "_default" suffix for the pin groups to differentiate between active and sleep states. But I guess we can just keep the suffix away until we hit usecase.

I had actually used this suffix when I submitted the first revision of the S500 pinctrl driver, but I dropped it later in the review process since it was considered an uncommon approach:
https://lore.kernel.org/lkml/CAL_Jsq+8bX5duv=116e=hve1L-h8a=5quqCHVtSAs4PjK6xc1w@mail.gmail.com/

Thanks,
Cristi

Quoted 68 lines

Thanks,
Mani

Quoted 63 lines
---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 44 ++++++++++++++++++++++
 1 file changed, 44 insertions(+)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +44 -0
index fe9ae3619422..ff91561ca99c 100644
@@ -37,7 +37,51 @@ sd_vcc: sd-vcc {
 	};
 };
 
+&i2c0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c0_pins>;
+};
+
+&i2c1 {
+	status = "disabled";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c1_pins>;
+};
+
+&i2c2 {
+	status = "disabled";
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2c2_pins>;
+};
+
 &pinctrl {
+	i2c0_pins: i2c0-pins {
+		pinmux {
+			groups = "i2c0_mfp";
+			function = "i2c0";
+		};
+
+		pinconf {
+			pins = "i2c0_sclk", "i2c0_sdata";
+			bias-pull-up;
+		};
+	};
+
+	i2c1_pins: i2c1-pins {
+		pinconf {
+			pins = "i2c1_sclk", "i2c1_sdata";
+			bias-pull-up;
+		};
+	};
+
+	i2c2_pins: i2c2-pins {
+		pinconf {
+			pins = "i2c2_sclk", "i2c2_sdata";
+			bias-pull-up;
+		};
+	};
+
 	mmc0_pins: mmc0-pins {
 		pinmux {
 			groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
Signature · 1 line
2.29.2
#57 lore raw

Re: [PATCH v2 18/18] MAINTAINERS: Add linux-actions ML for Actions Semi Arch

In reply to Manivannan Sadhasivam
Quoted 7 lines · Manivannan Sadhasivam
Quoted 3 lines · Cristian Ciocaltea

Add the linux-actions mailing list for the Actions Semi architecture.

There was a patch from me for this change but I don't mind taking yours as long as we keep the list updated :)

Sorry about that, I often forget to manually append this mailing list before submitting related patches and therefore I considered this is a good opportunity to have this issue fixed once and for all.. :)

Quoted 8 lines

I have just one comment below, with that fixed:

Quoted 4 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
Quoted 10 lines

MAINTAINERS ARM/ACTIONS SEMI ARCHITECTURE · line 1499

Quoted 8 lines
MAINTAINERS +0 -0
index a85c1881cf07..8428aba52581 100644
@@ -1497,6 +1497,7 @@ ARM/ACTIONS SEMI ARCHITECTURE
 M:	Andreas Färber <[email protected]>
 M:	Manivannan Sadhasivam <[email protected]>
 L:	[email protected] (moderated for non-subscribers)

No need to keep the generic list, please remove.

Done, thanks!

Quoted 10 lines

Thanks,
Mani

Quoted 7 lines
MAINTAINERS +1 -0
+L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
Signature · 1 line
2.29.2
maintainer
#58 lore raw

Re: [PATCH v2 18/18] MAINTAINERS: Add linux-actions ML for Actions Semi Arch

Quoted 4 lines · Cristian Ciocaltea
Quoted 3 lines · Manivannan Sadhasivam
Quoted 2 lines · Cristian Ciocaltea

Add the linux-actions mailing list for the Actions Semi architecture.

Quoted 27 lines
Quoted 4 lines
Quoted 1 line

There was a patch from me for this change but I don't mind taking yours as long as we keep the list updated :)

Sorry about that, I often forget to manually append this mailing list before submitting related patches and therefore I considered this is a good opportunity to have this issue fixed once and for all.. :)

Quoted 18 lines

I have just one comment below, with that fixed:

MAINTAINERS ARM/ACTIONS SEMI ARCHITECTURE · line 1499

Quoted 12 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index a85c1881cf07..8428aba52581 100644
@@ -1497,6 +1497,7 @@ ARM/ACTIONS SEMI ARCHITECTURE
 M:	Andreas Färber <[email protected]>
 M:	Manivannan Sadhasivam <[email protected]>
 L:	[email protected] (moderated for non-subscribers)

No need to keep the generic list, please remove.

Why? They're not mutually exclusive.

Regards,
Andreas

Quoted 13 lines

Done, thanks!

Quoted 10 lines

Thanks,
Mani

Quoted 7 lines
MAINTAINERS +1 -0
+L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
Signature · 1 line
2.29.2
Signature · 4 lines
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
#59 lore raw

Re: [PATCH v2 18/18] MAINTAINERS: Add linux-actions ML for Actions Semi Arch

Quoted 33 lines · Andreas Färber
Quoted 4 lines · Cristian Ciocaltea
Quoted 3 lines · Manivannan Sadhasivam
Quoted 2 lines · Cristian Ciocaltea

Add the linux-actions mailing list for the Actions Semi architecture.

Quoted 27 lines
Quoted 4 lines
Quoted 1 line

There was a patch from me for this change but I don't mind taking yours as long as we keep the list updated :)

Sorry about that, I often forget to manually append this mailing list before submitting related patches and therefore I considered this is a good opportunity to have this issue fixed once and for all.. :)

Quoted 18 lines

I have just one comment below, with that fixed:

MAINTAINERS ARM/ACTIONS SEMI ARCHITECTURE · line 1499

Quoted 12 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index a85c1881cf07..8428aba52581 100644
@@ -1497,6 +1497,7 @@ ARM/ACTIONS SEMI ARCHITECTURE
 M:	Andreas Färber <[email protected]>
 M:	Manivannan Sadhasivam <[email protected]>
 L:	[email protected] (moderated for non-subscribers)

No need to keep the generic list, please remove.

Quoted 2 lines

Why? They're not mutually exclusive.

Yes but why do we want to spam it? Currently we don't archive actions tree in lore but I can do that.

Thanks,
Mani

Quoted 23 lines

Regards,
Andreas

Quoted 13 lines

Done, thanks!

Quoted 10 lines

Thanks,
Mani

Quoted 7 lines
MAINTAINERS +1 -0
+L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
Signature · 1 line
2.29.2
Signature · 4 lines
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
#51 lore raw

Re: [PATCH v2 16/18] arm: dts: owl-s500-roseapplepi: Add uSD support

In reply to Cristian Ciocaltea
Quoted 36 lines · Cristian Ciocaltea
Quoted 21 lines · Manivannan Sadhasivam
Quoted 20 lines · Cristian Ciocaltea

Add uSD support for RoseapplePi SBC using a fixed regulator as a temporary solution until PMIC support becomes available.

---
 arch/arm/boot/dts/owl-s500-roseapplepi.dts | 50 ++++++++++++++++++++++
 1 file changed, 50 insertions(+)
arch/arm/boot/dts/owl-s500-roseapplepi.dts +1 -0
index 800edf5d2d12..fe9ae3619422 100644
@@ -14,6 +14,7 @@ / {
 	model = "Roseapple Pi";
 
 	aliases {
+		mmc0 = &mmc0;
 		serial2 = &uart2;
 	};
 
Quoted 9 lines

arch/arm/boot/dts/owl-s500-roseapplepi.dts memory@0 { · line 31

Quoted 7 lines
arch/arm/boot/dts/owl-s500-roseapplepi.dts +3 -0
@@ -25,6 +26,55 @@ memory@0 {
 		device_type = "memory";
 		reg = <0x0 0x80000000>; /* 2GB */
 	};
+
+	/* Fixed regulator used in the absence of PMIC */
+	sd_vcc: sd-vcc {

Is this the exact name in the schematics?

Yes, it is referred as "SD_VCC". Once the support for the ATC260x PMIC will be available, the following item will be present in the regulators list:

Quoted 7 lines
  sd_vcc: switchldo1 {
	regulator-name = "SD_VCC";
	regulator-min-microvolt = <3000000>;
	regulator-max-microvolt = <3300000>;
	regulator-always-on;
	regulator-boot-on;

};

okay, looks fine to me.

Thanks,
Mani

Quoted 59 lines

Thanks,
Cristi

Quoted 55 lines

Thanks,
Mani

Quoted 52 lines
arch/arm/boot/dts/owl-s500-roseapplepi.dts +46 -0
+		compatible = "regulator-fixed";
+		regulator-name = "fixed-3.1V";
+		regulator-min-microvolt = <3100000>;
+		regulator-max-microvolt = <3100000>;
+		regulator-always-on;
+	};
+};
+
+&pinctrl {
+	mmc0_pins: mmc0-pins {
+		pinmux {
+			groups = "sd0_d0_mfp", "sd0_d1_mfp", "sd0_d2_d3_mfp",
+				 "sd0_cmd_mfp", "sd0_clk_mfp";
+			function = "sd0";
+		};
+
+		drv-pinconf {
+			groups = "sd0_d0_d3_drv", "sd0_cmd_drv", "sd0_clk_drv";
+			drive-strength = <8>;
+		};
+
+		bias0-pinconf {
+			pins = "sd0_d0", "sd0_d1", "sd0_d2",
+			       "sd0_d3", "sd0_cmd";
+			bias-pull-up;
+		};
+
+		bias1-pinconf {
+			pins = "sd0_clk";
+			bias-pull-down;
+		};
+	};
+};
+
+/* uSD */
+&mmc0 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&mmc0_pins>;
+	no-sdio;
+	no-mmc;
+	no-1-8-v;
+	cd-gpios = <&pinctrl 117 GPIO_ACTIVE_LOW>;
+	bus-width = <4>;
+	vmmc-supply = <&sd_vcc>;
+	vqmmc-supply = <&sd_vcc>;
 };
 
 &twd_timer {
Signature · 1 line
2.29.2
#18 lore raw

Re: [PATCH v2 05/18] dmaengine: owl: Add compatible for the Actions Semi S500 DMA controller

In reply to Cristian Ciocaltea
Quoted 13 lines · Cristian Ciocaltea
Quoted 8 lines · Manivannan Sadhasivam
Quoted 5 lines · Cristian Ciocaltea

The DMA controller present on the Actions Semi S500 SoC is compatible with the S900 variant, so add it to the list of devices supported by the Actions Semi Owl DMA driver.

I hope that you have verified both Memcpy and Slave transfers...

I have been using 'dmatest' module as documented in:
https://www.kernel.org/doc/html/latest/driver-api/dmaengine/dmatest.html

Quoted 9 lines

I tested all the available channels and could not find any signs of possible issues. Bellow is an excerpt from the kernel ring buffer:

[ 2661.884680] dmatest: dma0chan1-copy0: summary 300 tests, 0 failures 1653.48 iops 13249 KB/s (0)
[ 2661.886567] dmatest: dma0chan2-copy0: summary 300 tests, 0 failures 1684.40 iops 12846 KB/s (0)
[ 2661.888448] dmatest: dma0chan3-copy0: summary 300 tests, 0 failures 1730.62 iops 13648 KB/s (0)

Should I perform some additional tests?

Nope, this is sufficient. Since you have tested slave transfer with MMC driver, running dmatest for memcpy is fine.

Thanks,
Mani

Quoted 27 lines

Thanks,
Cristi

Quoted 24 lines

Thanks,
Mani

Quoted 19 lines
---
 drivers/dma/owl-dma.c | 1 +
 1 file changed, 1 insertion(+)
drivers/dma/owl-dma.c +1 -0
index 9fede32641e9..54e509de66e2 100644
@@ -1082,6 +1082,7 @@ static struct dma_chan *owl_dma_of_xlate(struct of_phandle_args *dma_spec,
 static const struct of_device_id owl_dma_match[] = {
 	{ .compatible = "actions,s900-dma", .data = (void *)S900_DMA,},
 	{ .compatible = "actions,s700-dma", .data = (void *)S700_DMA,},
+	{ .compatible = "actions,s500-dma", .data = (void *)S900_DMA,},
 	{ /* sentinel */ },
 };
 MODULE_DEVICE_TABLE(of, owl_dma_match);
Signature · 1 line
2.29.2
#62 lore raw
In reply to Cristian Ciocaltea

Hi Cristi,

Quoted 6 lines · Cristian Ciocaltea

Hi,

This patchset brings a series of improvements for the Actions Semi S500 SoCs family, by adding support for Clock & Reset Management Units, DMA, MMC, I2C & SIRQ controllers.

Quoted 7 lines

Please note the patches consist mostly of DTS and bindings/compatibles changes, since all the work they depend on has been already merged, i.e. clock fixes/additions, pinctrl driver, sirq driver.

For the moment, I have only enabled the features I could test on RoseapplePi SBC.

I was hoping to apply this series for v5.11 but we ran out of time. So expect this series to be in v5.12.

Thanks,
Mani

Quoted 46 lines

Thanks,
Cristi

Changes in v2:
- Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
- Added support for the SIRQ controller
- Added new entries in MAINTAINERS
- Updated naming of some patches in v1

Cristian Ciocaltea (18):
arm: dts: owl-s500: Add Clock Management Unit
arm: dts: owl-s500: Set CMU clocks for UARTs
arm: dts: owl-s500: Add Reset controller
dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
dmaengine: owl: Add compatible for the Actions Semi S500 DMA
controller
arm: dts: owl-s500: Add DMA controller
arm: dts: owl-s500: Add pinctrl & GPIO support
dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
arm: dts: owl-s500: Add MMC support
dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
MAINTAINERS: Update entry for Actions Semi Owl I2C binding
i2c: owl: Add compatible for the Actions Semi S500 I2C controller
arm: dts: owl-s500: Add I2C support
arm: dts: owl-s500: Add SIRQ controller
arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
arm: dts: owl-s500-roseapplepi: Add uSD support
arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
MAINTAINERS: Add linux-actions ML for Actions Semi Arch

 .../devicetree/bindings/dma/owl-dma.yaml      |   5 +-
 .../devicetree/bindings/i2c/i2c-owl.txt       |  29 ----
 .../devicetree/bindings/i2c/i2c-owl.yaml      |  62 ++++++++
 .../devicetree/bindings/mmc/owl-mmc.yaml      |   4 +-
 MAINTAINERS                                   |   3 +-
 arch/arm/boot/dts/owl-s500-roseapplepi.dts    |  97 +++++++++++-
 arch/arm/boot/dts/owl-s500.dtsi               | 140 ++++++++++++++++++
 drivers/dma/owl-dma.c                         |   1 +
 drivers/i2c/busses/i2c-owl.c                  |   1 +
 9 files changed, 304 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
Signature · 1 line
2.29.2
#63 lore raw

Hi Mani,

Quoted 13 lines · Manivannan Sadhasivam

Hi Cristi,

Quoted 10 lines · Cristian Ciocaltea

Hi,

This patchset brings a series of improvements for the Actions Semi S500 SoCs family, by adding support for Clock & Reset Management Units, DMA, MMC, I2C & SIRQ controllers.

Please note the patches consist mostly of DTS and bindings/compatibles changes, since all the work they depend on has been already merged, i.e. clock fixes/additions, pinctrl driver, sirq driver.

Quoted 6 lines
Quoted 3 lines

For the moment, I have only enabled the features I could test on RoseapplePi SBC.

I was hoping to apply this series for v5.11 but we ran out of time. So expect this series to be in v5.12.

No problem, thanks a lot for taking care of this!

Kind regards,
Cristi

Quoted 49 lines

Thanks,
Mani

Quoted 46 lines

Thanks,
Cristi

Changes in v2:
- Added new bindings/compatibles for S500 DMA, MMC & I2C controllers
- Added support for the SIRQ controller
- Added new entries in MAINTAINERS
- Updated naming of some patches in v1

Cristian Ciocaltea (18):
arm: dts: owl-s500: Add Clock Management Unit
arm: dts: owl-s500: Set CMU clocks for UARTs
arm: dts: owl-s500: Add Reset controller
dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC
dmaengine: owl: Add compatible for the Actions Semi S500 DMA
controller
arm: dts: owl-s500: Add DMA controller
arm: dts: owl-s500: Add pinctrl & GPIO support
dt-bindings: mmc: owl: Add compatible string for Actions Semi S500 SoC
arm: dts: owl-s500: Add MMC support
dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema
MAINTAINERS: Update entry for Actions Semi Owl I2C binding
i2c: owl: Add compatible for the Actions Semi S500 I2C controller
arm: dts: owl-s500: Add I2C support
arm: dts: owl-s500: Add SIRQ controller
arm: dts: owl-s500-roseapplepi: Use UART clock from CMU
arm: dts: owl-s500-roseapplepi: Add uSD support
arm: dts: owl-s500-roseapplepi: Add I2C pinctrl configuration
MAINTAINERS: Add linux-actions ML for Actions Semi Arch

 .../devicetree/bindings/dma/owl-dma.yaml      |   5 +-
 .../devicetree/bindings/i2c/i2c-owl.txt       |  29 ----
 .../devicetree/bindings/i2c/i2c-owl.yaml      |  62 ++++++++
 .../devicetree/bindings/mmc/owl-mmc.yaml      |   4 +-
 MAINTAINERS                                   |   3 +-
 arch/arm/boot/dts/owl-s500-roseapplepi.dts    |  97 +++++++++++-
 arch/arm/boot/dts/owl-s500.dtsi               | 140 ++++++++++++++++++
 drivers/dma/owl-dma.c                         |   1 +
 drivers/i2c/busses/i2c-owl.c                  |   1 +
 9 files changed, 304 insertions(+), 38 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
Signature · 1 line
2.29.2

_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

maintainer Reviewed-by on v2 4/18
#13 lore raw

Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC

In reply to Cristian Ciocaltea
Quoted 8 lines · Cristian Ciocaltea

Add a new compatible string corresponding to the DMA controller found in the S500 variant of the Actions Semi Owl SoCs family.

---
 Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
maintainer Reviewed-by on v2 10/18
#30 lore raw

Re: [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema

In reply to Cristian Ciocaltea
Quoted 7 lines · Cristian Ciocaltea

Convert the Actions Semi Owl I2C DT binding to a YAML schema for enabling DT validation.

Additionally, add a new compatible string corresponding to the I2C controller found in the S500 variant of the Actions Semi Owl SoCs family.

Quoted 8 lines
---
 .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
 .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
#14 lore raw

Re: [PATCH v2 04/18] dt-bindings: dma: owl: Add compatible string for Actions Semi S500 SoC

In reply to Rob Herring
Quoted 11 lines · Rob Herring
Quoted 8 lines · Cristian Ciocaltea

Add a new compatible string corresponding to the DMA controller found in the S500 variant of the Actions Semi Owl SoCs family.

---
 Documentation/devicetree/bindings/dma/owl-dma.yaml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Thanks for reviewing,
Cristi

#31 lore raw

Re: [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema

In reply to Rob Herring
Quoted 17 lines · Rob Herring
Quoted 7 lines · Cristian Ciocaltea

Convert the Actions Semi Owl I2C DT binding to a YAML schema for enabling DT validation.

Additionally, add a new compatible string corresponding to the I2C controller found in the S500 variant of the Actions Semi Owl SoCs family.

Quoted 8 lines
---
 .../devicetree/bindings/i2c/i2c-owl.txt       | 29 ---------
 .../devicetree/bindings/i2c/i2c-owl.yaml      | 62 +++++++++++++++++++
 2 files changed, 62 insertions(+), 29 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.txt
 create mode 100644 Documentation/devicetree/bindings/i2c/i2c-owl.yaml
Quoted 1 line

Thanks for reviewing,
Cristi

Applied
#32 lore raw

Re: [PATCH v2 10/18] dt-bindings: i2c: owl: Convert Actions Semi Owl binding to a schema

In reply to Cristian Ciocaltea
Quoted 8 lines · Cristian Ciocaltea

Convert the Actions Semi Owl I2C DT binding to a YAML schema for enabling DT validation.

Additionally, add a new compatible string corresponding to the I2C controller found in the S500 variant of the Actions Semi Owl SoCs family.

Applied to for-next, thanks!

#42 lore raw

Re: [PATCH v2 13/18] arm: dts: owl-s500: Add I2C support

Quoted 11 lines · Wolfram Sang
Quoted 6 lines · Manivannan Sadhasivam
Quoted 3 lines · Cristian Ciocaltea

Add I2C controller nodes for Actions Semi S500 SoC.

DTS changes usually go in via arm-soc, so I am not picking this unless there is a reason to do so.

No you should not. This patch will go through actions sub tree which me or Andreas will pick it.

Thanks,
Mani

#60 lore raw

Re: [PATCH v2 18/18] MAINTAINERS: Add linux-actions ML for Actions Semi Arch

In reply to Manivannan Sadhasivam
Quoted 34 lines · Manivannan Sadhasivam
Quoted 33 lines · Andreas Färber
Quoted 31 lines · Cristian Ciocaltea
Quoted 7 lines · Manivannan Sadhasivam
Quoted 3 lines · Cristian Ciocaltea

Add the linux-actions mailing list for the Actions Semi architecture.

There was a patch from me for this change but I don't mind taking yours as long as we keep the list updated :)

Sorry about that, I often forget to manually append this mailing list before submitting related patches and therefore I considered this is a good opportunity to have this issue fixed once and for all.. :)

Quoted 18 lines

I have just one comment below, with that fixed:

MAINTAINERS ARM/ACTIONS SEMI ARCHITECTURE · line 1499

Quoted 12 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index a85c1881cf07..8428aba52581 100644
@@ -1497,6 +1497,7 @@ ARM/ACTIONS SEMI ARCHITECTURE
 M:	Andreas Färber <[email protected]>
 M:	Manivannan Sadhasivam <[email protected]>
 L:	[email protected] (moderated for non-subscribers)

No need to keep the generic list, please remove.

Quoted 5 lines
Quoted 2 lines

Why? They're not mutually exclusive.

Yes but why do we want to spam it? Currently we don't archive actions tree in lore but I can do that.

Hi Mani, Andreas,

I'm going to prepare a new revision of this patch series, but I'm not really sure how should I handle this patch: keep the 'linux-arm-kernel' list or drop it?

Thanks and regards,
Cristi

Quoted 26 lines

Thanks,
Mani

Quoted 23 lines

Regards,
Andreas

Quoted 13 lines

Done, thanks!

Quoted 10 lines

Thanks,
Mani

Quoted 7 lines
MAINTAINERS +1 -0
+L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
Signature · 1 line
2.29.2
Signature · 4 lines
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)
#61 lore raw

Re: [PATCH v2 18/18] MAINTAINERS: Add linux-actions ML for Actions Semi Arch

Quoted 38 lines · Cristian Ciocaltea
Quoted 37 lines · Manivannan Sadhasivam
Quoted 35 lines · Andreas Färber
Quoted 4 lines · Cristian Ciocaltea
Quoted 3 lines · Manivannan Sadhasivam
Quoted 2 lines · Cristian Ciocaltea

Add the linux-actions mailing list for the Actions Semi architecture.

Quoted 27 lines
Quoted 4 lines
Quoted 1 line

There was a patch from me for this change but I don't mind taking yours as long as we keep the list updated :)

Sorry about that, I often forget to manually append this mailing list before submitting related patches and therefore I considered this is a good opportunity to have this issue fixed once and for all.. :)

Quoted 18 lines

I have just one comment below, with that fixed:

MAINTAINERS ARM/ACTIONS SEMI ARCHITECTURE · line 1499

Quoted 12 lines
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)
MAINTAINERS +0 -0
index a85c1881cf07..8428aba52581 100644
@@ -1497,6 +1497,7 @@ ARM/ACTIONS SEMI ARCHITECTURE
 M:	Andreas Färber <[email protected]>
 M:	Manivannan Sadhasivam <[email protected]>
 L:	[email protected] (moderated for non-subscribers)

No need to keep the generic list, please remove.

Why? They're not mutually exclusive.

Quoted 9 lines
Quoted 2 lines

Yes but why do we want to spam it? Currently we don't archive actions tree in lore but I can do that.

Hi Mani, Andreas,

I'm going to prepare a new revision of this patch series, but I'm not really sure how should I handle this patch: keep the 'linux-arm-kernel' list or drop it?

Since Andreas seems to be in favour of keeping it, I don't object.

Thanks,
Mani

Quoted 29 lines

Thanks and regards,
Cristi

Quoted 26 lines

Thanks,
Mani

Quoted 23 lines

Regards,
Andreas

Quoted 13 lines

Done, thanks!

Quoted 10 lines

Thanks,
Mani

Quoted 7 lines
MAINTAINERS +1 -0
+L:	[email protected] (moderated for non-subscribers)
 S:	Maintained
 F:	Documentation/devicetree/bindings/arm/actions.yaml
 F:	Documentation/devicetree/bindings/clock/actions,owl-cmu.txt
Signature · 1 line
2.29.2
Signature · 4 lines
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer
HRB 36809 (AG Nürnberg)