firmware: xilinx: Clean up series
v2 cover firmware: xilinx: Clean up series
Hi,
for being able to review new changes more effectively it is good to get rid of existing kernel-doc and checkpatch violations.
That's why this small clean up series.
Thanks,
Michal
Changes in v2:
- keep variable name and type on the same line - reported by Joe Perches
Michal Simek (3):
firmware: xilinx: Remove additional newline
firmware: xilinx: Add a blank line after function declaration
firmware: xilinx: Properly align function parameter
include/linux/firmware/xlnx-zynqmp.h | 43 ++++++++++++++++++++++++---- 1 file changed, 38 insertions(+), 5 deletions(-)
Signature · 1 line
2.29.2
PATCH v2 1/3 firmware: xilinx: Remove additional newline
This additional newline is useless and also reported by checkpatch --strict.
---
(no changes since v1)
include/linux/firmware/xlnx-zynqmp.h | 1 - 1 file changed, 1 deletion(-)
include/linux/firmware/xlnx-zynqmp.h +0 -1
@@ -316,7 +316,6 @@ struct zynqmp_pm_query_data {u32 arg3; }; -int zynqmp_pm_invoke_fn (u32 pm_api_id,u32 arg0,u32 arg1,u32 arg2,u32 arg3,u32 *ret_payload);
Signature · 1 line
2.29.2
PATCH v2 2/3 firmware: xilinx: Add a blank line after function declaration
In reply to Michal SimekFix all these issues which are also reported by checkpatch --strict.
---
(no changes since v1)
include/linux/firmware/xlnx-zynqmp.h | 34 ++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+)
include/linux/firmware/xlnx-zynqmp.h +34 -0
@@ -363,107 +363,132 @@ static inline struct zynqmp_eemi_ops *zynqmp_pm_get_eemi_ops(void) {return ERR_PTR (-ENODEV ); } +static inline int zynqmp_pm_get_api_version (u32 *version) {return -ENODEV ; } +static inline int zynqmp_pm_get_chipid (u32 *idcode,u32 *version) {return -ENODEV ; } +static inline int zynqmp_pm_query_data (struct zynqmp_pm_query_data qdata,u32 *out) {return -ENODEV ; } +static inline int zynqmp_pm_clock_enable (u32 clock_id) {return -ENODEV ; } +static inline int zynqmp_pm_clock_disable (u32 clock_id) {return -ENODEV ; } +static inline int zynqmp_pm_clock_getstate (u32 clock_id,u32 *state) {return -ENODEV ; } +static inline int zynqmp_pm_clock_setdivider (u32 clock_id,u32 divider) {return -ENODEV ; } +static inline int zynqmp_pm_clock_getdivider (u32 clock_id,u32 *divider) {return -ENODEV ; } +static inline int zynqmp_pm_clock_setrate (u32 clock_id,u64 rate) {return -ENODEV ; } +static inline int zynqmp_pm_clock_getrate (u32 clock_id,u64 *rate) {return -ENODEV ; } +static inline int zynqmp_pm_clock_setparent (u32 clock_id,u32 parent_id) {return -ENODEV ; } +static inline int zynqmp_pm_clock_getparent (u32 clock_id,u32 *parent_id) {return -ENODEV ; } +static inline int zynqmp_pm_set_pll_frac_mode (u32 clk_id,u32 mode) {return -ENODEV ; } +static inline int zynqmp_pm_get_pll_frac_mode (u32 clk_id,u32 *mode) {return -ENODEV ; } +static inline int zynqmp_pm_set_pll_frac_data (u32 clk_id,u32 data) {return -ENODEV ; } +static inline int zynqmp_pm_get_pll_frac_data (u32 clk_id,u32 *data) {return -ENODEV ; } +static inline int zynqmp_pm_set_sd_tapdelay (u32 node_id,u32 type,u32 value) {return -ENODEV ; } +static inline int zynqmp_pm_sd_dll_reset (u32 node_id,u32 type) {return -ENODEV ; } +static inline int zynqmp_pm_reset_assert (const enum zynqmp_pm_reset reset,const enum zynqmp_pm_reset_action assert_flag) {return -ENODEV ; } +static inline int zynqmp_pm_reset_get_status (const enum zynqmp_pm_reset reset,u32 *status) {return -ENODEV ; } +static inline int zynqmp_pm_init_finalize (void ) {return -ENODEV ; } +static inline int zynqmp_pm_set_suspend_mode (u32 mode) {return -ENODEV ; } +static inline int zynqmp_pm_request_node (const u32 node,const u32 capabilities,const u32 qos,const enum zynqmp_pm_request_ack ack) {return -ENODEV ; } +static inline int zynqmp_pm_release_node (const u32 node) {return -ENODEV ; } + static inline int zynqmp_pm_set_requirement(const u32 node, const u32 capabilities, const u32 qos,
@@ -471,39 +496,48 @@ static inline int zynqmp_pm_set_requirement(const u32 node, {return -ENODEV ; } +static inline int zynqmp_pm_aes_engine (const u64 address,u32 *out) {return -ENODEV ; } +static inline int zynqmp_pm_fpga_load (const u64 address,const u32 size,const u32 flags) {return -ENODEV ; } +static inline int zynqmp_pm_fpga_get_status (u32 *value) {return -ENODEV ; } +static inline int zynqmp_pm_write_ggs (u32 index,u32 value) {return -ENODEV ; } +static inline int zynqmp_pm_read_ggs (u32 index,u32 *value) {return -ENODEV ; } +static inline int zynqmp_pm_write_pggs (u32 index,u32 value) {return -ENODEV ; } +static inline int zynqmp_pm_read_pggs (u32 index,u32 *value) {return -ENODEV ; } +static inline int zynqmp_pm_system_shutdown (const u32 type,const u32 subtype) {return -ENODEV ; } +static inline int zynqmp_pm_set_boot_health_status (u32 value) {return -ENODEV ;
Signature · 1 line
2.29.2
PATCH v2 3/3 firmware: xilinx: Properly align function parameter
In reply to Michal SimekFix parameters alignment reported by checkpatch --strict.
---
Changes in v2:
- keep variable name and type on the same line - reported by Joe Perches
include/linux/firmware/xlnx-zynqmp.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
include/linux/firmware/xlnx-zynqmp.h +4 -4
@@ -456,7 +456,7 @@ static inline int zynqmp_pm_sd_dll_reset(u32 node_id, u32 type) }static inline int zynqmp_pm_reset_assert (const enum zynqmp_pm_reset reset, -const enum zynqmp_pm_reset_action assert_flag) +const enum zynqmp_pm_reset_action assert_flag) {return -ENODEV ; }
@@ -490,9 +490,9 @@ static inline int zynqmp_pm_release_node(const u32 node) }static inline int zynqmp_pm_set_requirement (const u32 node, -const u32 capabilities, -const u32 qos, -const enum zynqmp_pm_request_ack ack) +const u32 capabilities, +const u32 qos, +const enum zynqmp_pm_request_ack ack) {return -ENODEV ; }
Signature · 1 line
2.29.2
Hi,
Quoted 15 lines · Michal Simek
Hi,
for being able to review new changes more effectively it is good to get rid of existing kernel-doc and checkpatch violations.
That's why this small clean up series.Thanks,
MichalChanges in v2:
- keep variable name and type on the same line - reported by Joe Perches
Quoted 8 lines
Michal Simek (3):
firmware: xilinx: Remove additional newline
firmware: xilinx: Add a blank line after function declaration
firmware: xilinx: Properly align function parameterinclude/linux/firmware/xlnx-zynqmp.h | 43 ++++++++++++++++++++++++---- 1 file changed, 38 insertions(+), 5 deletions(-)
Applied all.
Michal
Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs