Skip to contentSkip to conversation

Exclude OVERRIDES from vardeps for a couple funcs

PATCH New Christopher Larson 1 participant 3 messages Dec 10, 2020

lore
Share & tools
lore
#0 lore raw

cover Exclude OVERRIDES from vardeps for a couple funcs

These functions are primarily *appending* configuration entries to the overrides, they only get it to ensure it's set at all, so doesn't belong in the vardeps. Having a dependency on OVERRIDES means you cannot use a bbclass like distrooverrides without changing the signatures of recipes using this class.

Christopher Larson (2):
grub-efi-cfg: exclude OVERRIDES from build_efi_cfg vardeps
uboot-extlinux-config: exclude OVERRIDES from
do_create_extlinux_config vardeps

 meta/classes/grub-efi-cfg.bbclass          | 1 +
 meta/classes/uboot-extlinux-config.bbclass | 1 +
 2 files changed, 2 insertions(+)
Signature · 1 line
2.29.2
#1 lore raw

PATCH 1/2 grub-efi-cfg: exclude OVERRIDES from build_efi_cfg vardeps

From: Christopher Larson <[email protected]>

This function is primarily *appending* configuration entries to the overrides, it only gets it to ensure it's set at all, so doesn't belong in the vardeps. Having a dependency on OVERRIDES means you cannot use a bbclass like distrooverrides without changing the signatures of recipes using this class.

---
 meta/classes/grub-efi-cfg.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/grub-efi-cfg.bbclass +1 -0
index 3a2cdd698b..ea21b3de3d 100644
@@ -120,3 +120,4 @@ python build_efi_cfg() {
 
     cfgfile.close()
 }
+build_efi_cfg[vardepsexclude] += "OVERRIDES"
Signature · 1 line
2.29.2
#2 lore raw

PATCH 2/2 uboot-extlinux-config: exclude OVERRIDES from do_create_extlinux_config vardeps

In reply to Christopher Larson

From: Christopher Larson <[email protected]>

This function is primarily *appending* configuration entries to the overrides, it only gets it to ensure it's set at all, so doesn't belong in the vardeps. Having a dependency on OVERRIDES means you cannot use a bbclass like distrooverrides without changing the signatures of recipes using this class.

---
 meta/classes/uboot-extlinux-config.bbclass | 1 +
 1 file changed, 1 insertion(+)
meta/classes/uboot-extlinux-config.bbclass +1 -0
index f4bf94be04..be285daa01 100644
@@ -153,5 +153,6 @@ python do_create_extlinux_config() {
 }
 UBOOT_EXTLINUX_VARS = "CONSOLE MENU_DESCRIPTION ROOT KERNEL_IMAGE FDTDIR FDT KERNEL_ARGS INITRD"
 do_create_extlinux_config[vardeps] += "${@' '.join(['UBOOT_EXTLINUX_%s_%s' % (v, l) for v in d.getVar('UBOOT_EXTLINUX_VARS').split() for l in d.getVar('UBOOT_EXTLINUX_LABELS').split()])}"
+do_create_extlinux_config[vardepsexclude] += "OVERRIDES"
 
 addtask create_extlinux_config before do_install do_deploy after do_compile
Signature · 1 line
2.29.2