Skip to contentSkip to conversation

video: seps525: Add new driver for seps525 OLED display

PATCH New Michal Simek 3 participants 10 messages Dec 15, 2020 – Jan 5, 2021 Framebuffer layer

lore
Share & tools
lore
#0 lore raw

v3 cover video: seps525: Add new driver for seps525 OLED display

Hi,

This driver is connected via spi on one ZynqMP board. Only 8bit SPI connection is supported now. Spi zynq driver was used for testing this driver.
We have tested load image via BMP command and also using it as console as is visible from log in the last patch.

Thanks,
Michal

Changes in v3:
- also fix video_bmp call.
- use 32bit reg/value parameters
- new patch in this series

Changes in v2:
- New patch is series
- New patch is series
- Add support for returning value
- Update kernel-doc format to pass kernel-doc script
- Update patch subject s/call/operation/
- Fix Kconfig entry and use VIDEO_SEPS525 instead of SEPS525 and fix location
- Add kernel-doc structure for seps525_priv structure
- Remove flags variable and use macros directly

Michal Simek (5):
video: Fix video sync kernel-doc format
video: Let video_sync to return error value
video: Introduce video_sync operation
video: seps525: Add seps525 SPI driver
video: Call video_sync in video_clear()

Vikhyat Goyal (1):
video: seps525: Add dt binding description

 MAINTAINERS                                   |   2 +
 .../video/syncoam,seps525.txt                 |  24 ++
 drivers/video/Kconfig                         |   7 +
 drivers/video/Makefile                        |   1 +
 drivers/video/seps525.c                       | 327 ++++++++++++++++++
 drivers/video/vidconsole-uclass.c             |  40 ++-
 drivers/video/video-uclass.c                  |  23 +-
 drivers/video/video_bmp.c                     |   5 +-
 include/video.h                               |  22 +-
 9 files changed, 426 insertions(+), 25 deletions(-)
 create mode 100644 doc/device-tree-bindings/video/syncoam,seps525.txt
 create mode 100644 drivers/video/seps525.c
Signature · 1 line
2.29.2
#1 lore raw

PATCH v3 1/6 video: Fix video sync kernel-doc format

Place description below function parameters to make kernel-doc stript happy. Also rename dev to vid to be aligned with function parameters.

Fixes 1acafc73bfc7 ("dm: video: Add a video uclass")

---

(no changes since v2)

Changes in v2:
- New patch is series

./scripts/kernel-doc -v -man include/video.h > /dev/null

---
 include/video.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
include/video.h +4 -4
index 9d09d2409af6..7313b17f7ce8 100644
@@ -151,13 +151,13 @@ int video_clear(struct udevice *dev);
 /**
  * video_sync() - Sync a device's frame buffer with its hardware
  *
+ * @vid:	Device to sync
+ * @force:	True to force a sync even if there was one recently (this is
+ *		very expensive on sandbox)
+ *
  * Some frame buffers are cached or have a secondary frame buffer. This
  * function syncs these up so that the current contents of the U-Boot frame
  * buffer are displayed to the user.
- *
- * @dev:	Device to sync
- * @force:	True to force a sync even if there was one recently (this is
- *		very expensive on sandbox)
  */
 void video_sync(struct udevice *vid, bool force);
 
Signature · 1 line
2.29.2
#2 lore raw

PATCH v3 2/6 video: Let video_sync to return error value

In reply to Michal Simek

This patch is preparation for follow up one to support cases where synchronization can fail.

---

Changes in v3:
- also fix video_bmp call.

Changes in v2:
- New patch is series

 drivers/video/vidconsole-uclass.c | 40 ++++++++++++++++++++++---------
 drivers/video/video-uclass.c      | 12 +++++++---
 drivers/video/video_bmp.c         |  5 +---
 include/video.h                   |  4 +++-
 4 files changed, 42 insertions(+), 19 deletions(-)
drivers/video/vidconsole-uclass.c +29 -11
index 3a07f36ce278..f29c0e58c76d 100644
@@ -89,9 +89,7 @@ static int vidconsole_back(struct udevice *dev)
 		if (priv->ycur < 0)
 			priv->ycur = 0;
 	}
-	video_sync(dev->parent, false);
-
-	return 0;
+	return video_sync(dev->parent, false);
 }
 
 /* Move to a newline, scrolling the display if necessary */
@@ -101,7 +99,7 @@ static void vidconsole_newline(struct udevice *dev)
 	struct udevice *vid_dev = dev->parent;
 	struct video_priv *vid_priv = dev_get_uclass_priv(vid_dev);
 	const int rows = CONFIG_CONSOLE_SCROLL_LINES;
-	int i;
+	int i, ret;
 
 	priv->xcur_frac = priv->xstart_frac;
 	priv->ycur += priv->y_charsize;
@@ -116,7 +114,12 @@ static void vidconsole_newline(struct udevice *dev)
 	}
 	priv->last_ch = 0;
 
-	video_sync(dev->parent, false);
+	ret = video_sync(dev->parent, false);
+	if (ret) {
+#ifdef DEBUG
+		console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+	}
 }
 
 static const struct vid_rgb colors[VID_COLOR_COUNT] = {
@@ -348,8 +351,15 @@ static void vidconsole_escape_char(struct udevice *dev, char ch)
 		parsenum(priv->escape_buf + 1, &mode);
 
 		if (mode == 2) {
+			int ret;
+
 			video_clear(dev->parent);
-			video_sync(dev->parent, false);
+			ret = video_sync(dev->parent, false);
+			if (ret) {
+#ifdef DEBUG
+				console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+			}
 			priv->ycur = 0;
 			priv->xcur_frac = priv->xstart_frac;
 		} else {
@@ -565,7 +575,12 @@ static void vidconsole_putc(struct stdio_dev *sdev, const char ch)
 		console_puts_select_stderr(true, "[vc err: putc]");
 #endif
 	}
-	video_sync(dev->parent, false);
+	ret = video_sync(dev->parent, false);
+	if (ret) {
+#ifdef DEBUG
+		console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+	}
 }
 
 static void vidconsole_puts(struct stdio_dev *sdev, const char *s)
@@ -582,7 +597,12 @@ static void vidconsole_puts(struct stdio_dev *sdev, const char *s)
 		console_puts_select_stderr(true, str);
 #endif
 	}
-	video_sync(dev->parent, false);
+	ret = video_sync(dev->parent, false);
+	if (ret) {
+#ifdef DEBUG
+		console_puts_select_stderr(true, "[vc err: video_sync]");
+#endif
+	}
 }
 
 /* Set up the number of rows and colours (rotated drivers override this) */
@@ -691,9 +711,7 @@ static int do_video_puts(struct cmd_tbl *cmdtp, int flag, int argc,
 	for (s = argv[1]; *s; s++)
 		vidconsole_put_char(dev, *s);
 
-	video_sync(dev->parent, false);
-
-	return 0;
+	return video_sync(dev->parent, false);
 }
 
 U_BOOT_CMD(
drivers/video/video-uclass.c +9 -3
index 650891e49dd0..6fc412801714 100644
@@ -15,6 +15,7 @@
 #include <video_console.h>
 #include <asm/cache.h>
 #include <dm/lists.h>
+#include <dm/device_compat.h>
 #include <dm/device-internal.h>
 #include <dm/uclass-internal.h>
 #ifdef CONFIG_SANDBOX
@@ -172,7 +173,7 @@ void video_set_default_colors(struct udevice *dev, bool invert)
 }
 
 /* Flush video activity to the caches */
-void video_sync(struct udevice *vid, bool force)
+int video_sync(struct udevice *vid, bool force)
 {
 	/*
 	 * flush_dcache_range() is declared in common.h but it seems that some
@@ -196,17 +197,22 @@ void video_sync(struct udevice *vid, bool force)
 		last_sync = get_timer(0);
 	}
 #endif
+	return 0;
 }
 
 void video_sync_all(void)
 {
 	struct udevice *dev;
+	int ret;
 
 	for (uclass_find_first_device(UCLASS_VIDEO, &dev);
 	     dev;
 	     uclass_find_next_device(&dev)) {
-		if (device_active(dev))
-			video_sync(dev, true);
+		if (device_active(dev)) {
+			ret = video_sync(dev, true);
+			if (ret)
+				dev_dbg(dev, "Video sync failed\n");
+		}
 	}
 }
 
drivers/video/video_bmp.c +1 -4
index 5a4d12c68d4e..66de22318f2b 100644
@@ -379,8 +379,5 @@ int video_bmp_display(struct udevice *dev, ulong bmp_image, int x, int y,
 	if (ret)
 		return log_ret(ret);
 
-	video_sync(dev, false);
-
-	return 0;
+	return video_sync(dev, false);
 }
-
include/video.h +3 -1
index 7313b17f7ce8..1bfe6843a805 100644
@@ -155,11 +155,13 @@ int video_clear(struct udevice *dev);
  * @force:	True to force a sync even if there was one recently (this is
  *		very expensive on sandbox)
  *
+ * @return: 0 always
+ *
  * Some frame buffers are cached or have a secondary frame buffer. This
  * function syncs these up so that the current contents of the U-Boot frame
  * buffer are displayed to the user.
  */
-void video_sync(struct udevice *vid, bool force);
+int video_sync(struct udevice *vid, bool force);
 
 /**
  * video_sync_all() - Sync all devices' frame buffers with there hardware
Signature · 1 line
2.29.2
#3 lore raw

PATCH v3 3/6 video: Introduce video_sync operation

In reply to Michal Simek

Some drivers like LCD connected via SPI requires explicit sync function which copy framebuffer content over SPI to controller to display. This hook doesn't exist yet that's why introduce it via video operations.

---

(no changes since v2)

Changes in v2:
- Add support for returning value
- Update kernel-doc format to pass kernel-doc script
- Update patch subject s/call/operation/

Simon: Please review this. I didn't find existing way how this can be done that's why I am introducing this hook. Also maybe name can be named a little bit differently. That's why waiting for better suggestion.

---
 drivers/video/video-uclass.c |  9 +++++++++
 include/video.h              | 12 ++++++++++--
 2 files changed, 19 insertions(+), 2 deletions(-)
drivers/video/video-uclass.c +9 -0
index 6fc412801714..938e7d371311 100644
@@ -175,6 +175,15 @@ void video_set_default_colors(struct udevice *dev, bool invert)
 /* Flush video activity to the caches */
 int video_sync(struct udevice *vid, bool force)
 {
+	struct video_ops *ops = video_get_ops(vid);
+	int ret;
+
+	if (ops && ops->video_sync) {
+		ret = ops->video_sync(vid);
+		if (ret)
+			return ret;
+	}
+
 	/*
 	 * flush_dcache_range() is declared in common.h but it seems that some
 	 * architectures do not actually implement it. Is there a way to find
include/video.h +10 -2
index 1bfe6843a805..12fc525ab4ef 100644
@@ -114,8 +114,16 @@ struct video_priv {
 	u8 bg_col_idx;
 };
 
-/* Placeholder - there are no video operations at present */
+/**
+ * struct video_ops - structure for keeping video operations
+ * @video_sync: Synchronize FB with device. Some device like SPI based LCD
+ *		displays needs synchronization when data in an FB is available.
+ *		For these devices implement video_sync hook to call a sync
+ *		function. vid is pointer to video device udevice. Function
+ *		should return 0 on success video_sync and error code otherwise
+ */
 struct video_ops {
+	int (*video_sync)(struct udevice *vid);
 };
 
 #define video_get_ops(dev)        ((struct video_ops *)(dev)->driver->ops)
@@ -155,7 +163,7 @@ int video_clear(struct udevice *dev);
  * @force:	True to force a sync even if there was one recently (this is
  *		very expensive on sandbox)
  *
- * @return: 0 always
+ * @return: 0 on success, error code otherwise
  *
  * Some frame buffers are cached or have a secondary frame buffer. This
  * function syncs these up so that the current contents of the U-Boot frame
Signature · 1 line
2.29.2
#4 lore raw

PATCH v3 4/6 video: seps525: Add dt binding description

In reply to Michal Simek

From: Vikhyat Goyal <[email protected]>

Added dt binding for seps525 display driver.

---

(no changes since v1)

 MAINTAINERS                                   |  1 +
 .../video/syncoam,seps525.txt                 | 24 +++++++++++++++++++
 2 files changed, 25 insertions(+)
 create mode 100644 doc/device-tree-bindings/video/syncoam,seps525.txt
MAINTAINERS +1 -0
index 127e30c0a5e0..11857ece9a53 100644
@@ -547,6 +547,7 @@ S:	Maintained
 T:	git https://gitlab.denx.de/u-boot/custodians/u-boot-microblaze.git
 F:	arch/arm/mach-zynq/
 F:	doc/board/xilinx/
+F:	doc/device-tree-bindings/video/syncoam,seps525.txt
 F:	drivers/clk/clk_zynq.c
 F:	drivers/fpga/zynqpl.c
 F:	drivers/gpio/zynq_gpio.c
doc/device-tree-bindings/video/syncoam,seps525.txt new file +24 -0
new file mode 100644
index 000000000000..e1e0db9d71fb
@@ -0,0 +1,24 @@
+spi based seps525 framebuffer display driver
+
+Driver for seps525 display controller (in spi mode), This binding supports selection
+of spi chipselect, spi max frequency, gpio to drive dc and reset pin of seps525
+controller and spi transaction bit length.
+
+Required properties:
+- compatible: "syncoam,seps525"
+- reg: Specifies the chip-select the seps525 is connected to on the spi bus
+- reset-gpios: gpio connected to reset pin of seps525 controller.
+- dc-gpios: gpio connected to dc pin of seps525 controller:
+- buswidth: bitlength of each spi transaction
+
+Example:
+	displayspi at 0 {
+		compatible = "syncoam,seps525";
+		reg = <0>;
+		spi-max-frequency = <10000000>;
+		spi-cpol;
+		spi-cpha;
+		buswidth = <8>;
+		reset-gpios = <&gpio 0x1c GPIO_ACTIVE_LOW>;
+		dc-gpios = <&gpio 0x1b GPIO_ACTIVE_HIGH>;
+	};
Signature · 1 line
2.29.2
#5 lore raw

PATCH v3 5/6 video: seps525: Add seps525 SPI driver

In reply to Michal Simek

Add support for the WiseChip Semiconductor Inc. (UG-6028GDEBF02) display using the SEPS525 (Syncoam) LCD Controller. Syncoam Seps525 PM-Oled is RGB 160x128 display. This driver has been tested through zynq-spi driver.

ZynqMP> load mmc 1 100000 rainbow.bmp
61562 bytes read in 20 ms (2.9 MiB/s)
ZynqMP> bmp info 100000
Image size : 160 x 128
Bits per pixel: 24
Compression : 0
ZynqMP> bmp display 100000
ZynqMP> setenv stdout vidconsole

---

Changes in v3:
- use 32bit reg/value parameters

Changes in v2:
- Fix Kconfig entry and use VIDEO_SEPS525 instead of SEPS525 and fix location
- Add kernel-doc structure for seps525_priv structure
- Remove flags variable and use macros directly

 MAINTAINERS             |   1 +
 drivers/video/Kconfig   |   7 +
 drivers/video/Makefile  |   1 +
 drivers/video/seps525.c | 327 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 336 insertions(+)
 create mode 100644 drivers/video/seps525.c
MAINTAINERS +1 -0
index 11857ece9a53..847b63685a29 100644
@@ -589,6 +589,7 @@ F:	drivers/spi/zynq_qspi.c
 F:	drivers/spi/zynq_spi.c
 F:	drivers/timer/cadence-ttc.c
 F:	drivers/usb/host/ehci-zynq.c
+F:	drivers/video/seps525.c
 F:	drivers/watchdog/cdns_wdt.c
 F:	include/zynqmppl.h
 F:	include/zynqmp_firmware.h
drivers/video/Kconfig +7 -0
index 998271b9b628..71363409f04e 100644
@@ -652,6 +652,13 @@ config VIDEO_NX
 	   HDMI. This option enables this support which can be used on devices
 	   which have an eDP display connected.
 
+config VIDEO_SEPS525
+	bool "Enable video support for Seps525"
+	depends on DM_VIDEO
+	help
+	  Enable support for the Syncoam PM-OLED display driver (RGB 160x128).
+	  Currently driver is supporting only SPI interface.
+
 source "drivers/video/nexell/Kconfig"
 
 config VIDEO
drivers/video/Makefile +1 -0
index 67a492a2d60d..9db96aa891a3 100644
@@ -70,6 +70,7 @@ obj-$(CONFIG_VIDEO_SIMPLE) += simplefb.o
 obj-$(CONFIG_VIDEO_TEGRA20) += tegra.o
 obj-$(CONFIG_VIDEO_VCXK) += bus_vcxk.o
 obj-$(CONFIG_VIDEO_VESA) += vesa.o
+obj-$(CONFIG_VIDEO_SEPS525) += seps525.o
 
 obj-y += bridge/
 obj-y += sunxi/
drivers/video/seps525.c new file +327 -0

327 lines not on this page · raw message

Signature · 1 line
2.29.2
#7 lore raw

PATCH v3 6/6 video: Call video_sync in video_clear()

In reply to Michal Simek

There is a need to call sync when anybody asking for clearing display. For example via cls command.

---

Changes in v3:
- new patch in this series

 drivers/video/video-uclass.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/video-uclass.c +1 -1
index 938e7d371311..21452a1cda97 100644
@@ -143,7 +143,7 @@ int video_clear(struct udevice *dev)
 	if (ret)
 		return ret;
 
-	return 0;
+	return video_sync(dev, false);
 }
 
 void video_set_default_colors(struct udevice *dev, bool invert)
Signature · 1 line
2.29.2
#6 lore raw

PATCH v3 5/6 video: seps525: Add seps525 SPI driver

In reply to Michal Simek

Hi Michal,

Quoted 27 lines · Michal Simek

Add support for the WiseChip Semiconductor Inc. (UG-6028GDEBF02) display using the SEPS525 (Syncoam) LCD Controller. Syncoam Seps525 PM-Oled is RGB 160x128 display. This driver has been tested through zynq-spi driver.

ZynqMP> load mmc 1 100000 rainbow.bmp
61562 bytes read in 20 ms (2.9 MiB/s)
ZynqMP> bmp info 100000
Image size : 160 x 128
Bits per pixel: 24
Compression : 0
ZynqMP> bmp display 100000
ZynqMP> setenv stdout vidconsole

---

Changes in v3:
- use 32bit reg/value parameters

Changes in v2:
- Fix Kconfig entry and use VIDEO_SEPS525 instead of SEPS525 and fix location
- Add kernel-doc structure for seps525_priv structure
- Remove flags variable and use macros directly

Quoted 7 lines
 MAINTAINERS             |   1 +
 drivers/video/Kconfig   |   7 +
 drivers/video/Makefile  |   1 +
 drivers/video/seps525.c | 327 ++++++++++++++++++++++++++++++++++++++++
 4 files changed, 336 insertions(+)
 create mode 100644 drivers/video/seps525.c

Don't worry about changing it again...but I just wanted to mention that my interest was in using natural types (e.g. int / uint) for fuunction parameters - so on arm64 this would actually be a 64-bit value!

I'm pleased to hear that there is no size impact of using u8. Perhaps the compiler it better, and after all these are static functions so there is full visibility for the compiler. I did have a project some years ago full of u8 params and it added a lot to code size.

Regards,
Simon

Applied
#9 lore raw

v3 cover video: seps525: Add new driver for seps525 OLED display

In reply to Michal Simek

?t 15. 12. 2020 v 15:19 odes?latel Michal Simek
<[email protected]> napsal:

Quoted 51 lines

Hi,

This driver is connected via spi on one ZynqMP board. Only 8bit SPI connection is supported now. Spi zynq driver was used for testing this driver.
We have tested load image via BMP command and also using it as console as is visible from log in the last patch.

Thanks,
Michal

Changes in v3:
- also fix video_bmp call.
- use 32bit reg/value parameters
- new patch in this series

Changes in v2:
- New patch is series
- New patch is series
- Add support for returning value
- Update kernel-doc format to pass kernel-doc script
- Update patch subject s/call/operation/
- Fix Kconfig entry and use VIDEO_SEPS525 instead of SEPS525 and fix location
- Add kernel-doc structure for seps525_priv structure
- Remove flags variable and use macros directly

Michal Simek (5):
video: Fix video sync kernel-doc format
video: Let video_sync to return error value
video: Introduce video_sync operation
video: seps525: Add seps525 SPI driver
video: Call video_sync in video_clear()

Vikhyat Goyal (1):
video: seps525: Add dt binding description

 MAINTAINERS                                   |   2 +
 .../video/syncoam,seps525.txt                 |  24 ++
 drivers/video/Kconfig                         |   7 +
 drivers/video/Makefile                        |   1 +
 drivers/video/seps525.c                       | 327 ++++++++++++++++++
 drivers/video/vidconsole-uclass.c             |  40 ++-
 drivers/video/video-uclass.c                  |  23 +-
 drivers/video/video_bmp.c                     |   5 +-
 include/video.h                               |  22 +-
 9 files changed, 426 insertions(+), 25 deletions(-)
 create mode 100644 doc/device-tree-bindings/video/syncoam,seps525.txt
 create mode 100644 drivers/video/seps525.c
Quoted 3 lines

--
2.29.2

Applied.
M

Signature · 5 lines
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs