phy: fsl-imx8-mipi-dphy: Hook into runtime pm

PATCH Superseded Guido Günther 2 participants 3 messages Dec 16, 2020 – Feb 20, 2021

Share & tools

Guido Günther

author

2020-12-16 18:23 UTC #0 lore raw

v3 cover phy: fsl-imx8-mipi-dphy: Hook into runtime pm

This allows us to shut down the mipi power domain on the imx8. The alternative would be to drop the dphy from the mipi power domain in the SOCs device tree and only have the DSI host controller visible there but since the PD is mostly about the PHY that would defeat it's purpose.

This is basically a resend from February 2020 which went without feedback.

This allows to shut off the power domain hen blanking the LCD panel:

pm_genpd_summary before:

domain status slaves
/device runtime status
----------------------------------------------------------------------
mipi on

    /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy  unsupported
    /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi  suspended

after:

mipi off-0

    /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy  suspended
    /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi  suspended

Changes from v1:
- Tweak commit message slightly

Changes from v2:
- As pre review comment by Lucas Stach
https://lore.kernel.org/linux-arm-kernel/[email protected]/
Check for pm_runtime_get_sync failure

Guido Günther (1):
phy: fsl-imx8-mipi-dphy: Hook into runtime pm

 .../phy/freescale/phy-fsl-imx8-mipi-dphy.c    | 25 ++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

Signature · 1 line

2.29.2

Guido Günther

author

2021-02-19 09:40 UTC #1 lore raw

Hi,

Quoted 4 lines · Guido Günther

This allows us to shut down the mipi power domain on the imx8. The alternative would be to drop the dphy from the mipi power domain in the SOCs device tree and only have the DSI host controller visible there but since the PD is mostly about the PHY that would defeat it's purpose.

Is there anything I can do to move that forward. I assume this needs to go via the phy/ subsystem not drm?
Cheers,
-- Guido

Quoted 42 lines

This is basically a resend from February 2020 which went without feedback.
This allows to shut off the power domain hen blanking the LCD panel:
pm_genpd_summary before:
domain status slaves
/device runtime status
----------------------------------------------------------------------
mipi on
    /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy  unsupported
    /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi  suspended
after:
mipi off-0
    /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy  suspended
    /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi  suspended
Changes from v1:
- Tweak commit message slightly
Changes from v2:
- As pre review comment by Lucas Stach
https://lore.kernel.org/linux-arm-kernel/[email protected]/
Check for pm_runtime_get_sync failure
Guido Günther (1):
phy: fsl-imx8-mipi-dphy: Hook into runtime pm
 .../phy/freescale/phy-fsl-imx8-mipi-dphy.c    | 25 ++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Liu Ying

2021-02-20 05:32 UTC #2 lore raw

Hi Guido,

Quoted 9 lines · Guido Günther

Hi,
Quoted 4 lines · Guido Günther
This allows us to shut down the mipi power domain on the imx8. The alternative would be to drop the dphy from the mipi power domain in the SOCs device tree and only have the DSI host controller visible there but since the PD is mostly about the PHY that would defeat it's purpose.
Is there anything I can do to move that forward. I assume this needs to go via the phy/ subsystem not drm?

I cannot find patch 1/1 of v3 in my mailbox, so I'll provide comment on v2.

Regards,
Liu Ying

Quoted 44 lines

Cheers,
-- Guido
Quoted 41 lines
This is basically a resend from February 2020 which went without feedback.
This allows to shut off the power domain hen blanking the LCD panel:
pm_genpd_summary before:
domain status slaves
/device runtime status
----------------------------------------------------------------------
mipi on
    /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy  unsupported
    /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi  suspended
after:
mipi off-0
    /devices/platform/soc@0/soc@0:bus@30800000/30a00300.dphy  suspended
    /devices/platform/soc@0/soc@0:bus@30800000/30a00000.mipi_dsi  suspended
Changes from v1:
- Tweak commit message slightly
Changes from v2:
- As pre review comment by Lucas Stach
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Flinux-arm-kernel%2Fee22b072e0abe07559a3e6a63ccf6ece064a46cb.camel%40pengutronix.de%2F&data=04%7C01%7Cvictor.liu%40nxp.com%7Ccac0b14c892c4a35340508d8d4ba2e16%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637493243396909710%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=PU5kegolJwKK%2BQ7nD7V9qjrKJ2fJ9eKoySoFihnFoD8%3D&reserved=0
Check for pm_runtime_get_sync failure
Guido Günther (1):
phy: fsl-imx8-mipi-dphy: Hook into runtime pm
 .../phy/freescale/phy-fsl-imx8-mipi-dphy.c    | 25 ++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)
Signature · 7 lines
2.29.2


_______________________________________________
linux-arm-kernel mailing list
[email protected]
https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infradead.org%2Fmailman%2Flistinfo%2Flinux-arm-kernel&amp;data=04%7C01%7Cvictor.liu%40nxp.com%7Ccac0b14c892c4a35340508d8d4ba2e16%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637493243396909710%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=kkC3Go0wvHemjxaKVHwU%2F6gWRsgVOFoVz7QEHB7Zqx0%3D&amp;reserved=0