net: make udp tunnel devices support fraglist
Subsystems (3)
Xin Long
maintainercover net: make udp tunnel devices support fraglist
Like GRE device, UDP tunnel devices should also support fraglist, so that some protocol (like SCTP) HW GSO that requires NETIF_F_FRAGLIST in the dev can work. Especially when the lower device support both NETIF_F_GSO_UDP_TUNNEL and NETIF_F_GSO_SCTP.
Xin Long (3):
vxlan: add NETIF_F_FRAGLIST flag for dev features
geneve: add NETIF_F_FRAGLIST flag for dev features
bareudp: add NETIF_F_FRAGLIST flag for dev features
drivers/net/bareudp.c | 5 +++-- drivers/net/geneve.c | 5 +++-- drivers/net/vxlan.c | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-)
Signature · 1 line
2.1.0
Xin Long
maintainerPATCH 1/3 vxlan: add NETIF_F_FRAGLIST flag for dev features
Some protocol HW GSO requires fraglist supported by the device, like SCTP. Without NETIF_F_FRAGLIST set in the dev features of vxlan, it would have to do SW GSO before the packets enter the driver, even when the vxlan dev and lower dev (like veth) both have the feature of NETIF_F_GSO_SCTP.
So this patch is to add it for vxlan.
--- drivers/net/vxlan.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/vxlan.c +3 -2
@@ -3283,12 +3283,13 @@ static void vxlan_setup(struct net_device *dev)SET_NETDEV_DEVTYPE (dev, &vxlan_type); dev->features |=NETIF_F_LLTX ; - dev->features |=NETIF_F_SG |NETIF_F_HW_CSUM ; + dev->features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_FRAGLIST ; dev->features |=NETIF_F_RXCSUM ; dev->features |=NETIF_F_GSO_SOFTWARE ; dev->vlan_features = dev->features; - dev->hw_features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_RXCSUM ; + dev->hw_features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_FRAGLIST ; + dev->hw_features |=NETIF_F_RXCSUM ; dev->hw_features |=NETIF_F_GSO_SOFTWARE ;netif_keep_dst (dev); dev->priv_flags |=IFF_NO_QUEUE ;
Signature · 1 line
2.1.0
Xin Long
maintainerPATCH 2/3 geneve: add NETIF_F_FRAGLIST flag for dev features
Some protocol HW GSO requires fraglist supported by the device, like SCTP. Without NETIF_F_FRAGLIST set in the dev features of geneve, it would have to do SW GSO before the packets enter the driver, even when the geneve dev and lower dev (like veth) both have the feature of NETIF_F_GSO_SCTP.
So this patch is to add it for geneve.
--- drivers/net/geneve.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/geneve.c +3 -2
@@ -1197,11 +1197,12 @@ static void geneve_setup(struct net_device *dev)SET_NETDEV_DEVTYPE (dev, &geneve_type); dev->features |=NETIF_F_LLTX ; - dev->features |=NETIF_F_SG |NETIF_F_HW_CSUM ; + dev->features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_FRAGLIST ; dev->features |=NETIF_F_RXCSUM ; dev->features |=NETIF_F_GSO_SOFTWARE ; - dev->hw_features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_RXCSUM ; + dev->hw_features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_FRAGLIST ; + dev->hw_features |=NETIF_F_RXCSUM ; dev->hw_features |=NETIF_F_GSO_SOFTWARE ;/* MTU range: 68 - (something less than 65535) */
Signature · 1 line
2.1.0
Xin Long
maintainerPATCH 3/3 bareudp: add NETIF_F_FRAGLIST flag for dev features
Like vxlan and geneve, bareudp also needs this dev feature to support some protocol's HW GSO.
--- drivers/net/bareudp.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/net/bareudp.c +3 -2
@@ -526,11 +526,12 @@ static void bareudp_setup(struct net_device *dev) dev->netdev_ops = &bareudp_netdev_ops; dev->needs_free_netdev = true;SET_NETDEV_DEVTYPE (dev, &bareudp_type); - dev->features |=NETIF_F_SG |NETIF_F_HW_CSUM ; + dev->features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_FRAGLIST ; dev->features |=NETIF_F_RXCSUM ; dev->features |=NETIF_F_LLTX ; dev->features |=NETIF_F_GSO_SOFTWARE ; - dev->hw_features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_RXCSUM ; + dev->hw_features |=NETIF_F_SG |NETIF_F_HW_CSUM |NETIF_F_FRAGLIST ; + dev->hw_features |=NETIF_F_RXCSUM ; dev->hw_features |=NETIF_F_GSO_SOFTWARE ; dev->hard_header_len =0 ; dev->addr_len =0 ;
Signature · 1 line
2.1.0
This series was applied to netdev/net-next.git (refs/heads/master):
Hello:
This series was applied to netdev/net-next.git (refs/heads/master):
Quoted 11 lines · On Fri, 15 Jan 2021 17:47:44 +0800 you wrote:
Like GRE device, UDP tunnel devices should also support fraglist, so that some protocol (like SCTP) HW GSO that requires
NETIF_F_FRAGLISTin the dev can work. Especially when the lower device support bothNETIF_F_GSO_UDP_TUNNELandNETIF_F_GSO_SCTP.Xin Long (3):
vxlan: addNETIF_F_FRAGLISTflag for dev features
geneve: addNETIF_F_FRAGLISTflag for dev features
bareudp: addNETIF_F_FRAGLISTflag for dev features[...]
Here is the summary with links:
- [net-next,1/3] vxlan: add NETIF_F_FRAGLIST flag for dev features
https://git.kernel.org/netdev/net-next/c/cb2c57112432 - [net-next,2/3] geneve: add NETIF_F_FRAGLIST flag for dev features https://git.kernel.org/netdev/net-next/c/18423e1a9d7d - [net-next,3/3] bareudp: add NETIF_F_FRAGLIST flag for dev features https://git.kernel.org/netdev/net-next/c/3224dcfd850f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html