Skip to contentSkip to conversation

drm/i915: Disable pread/pwrite ioctl's for IGT testing

PATCH New Ashutosh Dixit 2 participants 7 messages Jan 21, 2021 – Mar 15, 2021

Subsystems (2)
lore
Share & tools
lore
#1 lore raw

PATCH 1/1 drm/i915: Disable pread/pwrite ioctl's for IGT testing

In reply to Ashutosh Dixit

FOR CI ONLY. PLEASE DON'T REVIEW.

The upstream guidance at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and
(b) no existing user mode clients actually use the pread/pwrite interface.

The plan is to phase out these ioctls for _new_ Gen12+ platforms. However, since this patch is actually for CI and the real changes which need to be validated are in IGT, in this patch we are disabling pread/pwrite for existing Gen11 and Gen12 platforms. This will be changed once IGT changes are validated and finalized.

---
 drivers/gpu/drm/i915/i915_gem.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
drivers/gpu/drm/i915/i915_gem.c +18 -0
index 9b04dff5eb32..1c799d0006c8 100644
@@ -366,6 +366,18 @@ i915_gem_gtt_pread(struct drm_i915_gem_object *obj,
 	return ret;
 }
 
+static bool gem_has_pread_pwrite(struct drm_device *dev)
+{
+	/*
+	 * FIXME: Finally we only want to enable this for _new_ Gen12+
+	 * platforms but for now for CI purposes declare pread/pwrite are
+	 * unavailable for all Gen11 and Gen12 platforms so that the IGT
+	 * changes which handle absence of pread/pwrite ioctl's can be
+	 * validated.
+	*/
+	return INTEL_GEN(to_i915(dev)) < 11;
+}
+
 /**
  * Reads data from the object referenced by handle.
  * @dev: drm device pointer
@@ -382,6 +394,9 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data,
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	if (!gem_has_pread_pwrite(dev))
+		return -EOPNOTSUPP;
+
 	if (args->size == 0)
 		return 0;
 
@@ -687,6 +702,9 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	if (!gem_has_pread_pwrite(dev))
+		return -EOPNOTSUPP;
+
 	if (args->size == 0)
 		return 0;
 
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#0 lore raw

cover drm/i915: Disable pread/pwrite ioctl's for IGT testing

FOR CI ONLY. PLEASE DON'T REVIEW.

The upstream guidance at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and
(b) no existing user mode clients actually use the pread/pwrite interface.

The plan is to phase out these ioctls for _new_ Gen12+ platforms. However, since this patch is actually for CI and the real changes which need to be validated are in IGT, in this patch we are disabling pread/pwrite for existing Gen11 and Gen12 platforms. This will be changed once IGT changes are validated and finalized.

Test-with: [email protected]

Ashutosh Dixit (1):
drm/i915: Disable pread/pwrite ioctl's for IGT testing

 drivers/gpu/drm/i915/i915_gem.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Disable pread/pwrite ioctl's for IGT testing

== Series Details ==

== Series Details ==

Series: drm/i915: Disable pread/pwrite ioctl's for IGT testing
URL : https://patchwork.freedesktop.org/series/86155/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
70d666e29d2c drm/i915: Disable pread/pwrite ioctl's for IGT testing
-:38: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#38: FILE: drivers/gpu/drm/i915/i915_gem.c:377:
+	 * validated.
+	*/

total: 0 errors, 1 warnings, 0 checks, 36 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable pread/pwrite ioctl's for IGT testing

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: drm/i915: Disable pread/pwrite ioctl's for IGT testing
URL : https://patchwork.freedesktop.org/series/86155/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9666 -> Patchwork_19449
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_19449 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19449, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_19449:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_parallel@engines@userptr:
- fi-icl-y: [PASS][1] -> [SKIP][2] +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-icl-y/igt@gem_exec_parallel@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-icl-y/igt@gem_exec_parallel@[email protected]

* igt@gem_tiled_pread_basic:
- fi-icl-u2: [PASS][3] -> [SKIP][4] +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-icl-u2/igt@gem_tiled_pread_basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-icl-u2/igt@gem_tiled_pread_basic.html

* igt@prime_vgem@basic-read:
- fi-tgl-y: [PASS][5] -> [SKIP][6] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-tgl-y/igt@[email protected]

* igt@prime_vgem@basic-write:
- fi-tgl-u2: [PASS][7] -> [SKIP][8] +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-u2/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-tgl-u2/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_exec_parallel@engines@userptr:
- {fi-tgl-dsi}: [PASS][9] -> [SKIP][10] +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-dsi/igt@gem_exec_parallel@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-tgl-dsi/igt@gem_exec_parallel@[email protected]

* igt@prime_vgem@basic-write:
- {fi-ehl-1}: [PASS][11] -> [SKIP][12] +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-ehl-1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-ehl-1/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_19449 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_cs_nop@sync-gfx0:
- fi-bsw-n3050: NOTRUN -> [SKIP][13] ([fdo#109271]) +17 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-bsw-n3050/igt@amdgpu/[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [PASS][14] -> [INCOMPLETE][15] ([i915#142] / [i915#2405])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-byt-j1900/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-byt-j1900/igt@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-kbl-7500u: [PASS][16] -> [FAIL][17] ([i915#2128])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-kbl-7500u/igt@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-kbl-7500u/igt@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [PASS][18] -> [FAIL][19] ([i915#1161] / [i915#262])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-kbl-7500u/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-kbl-7500u/igt@[email protected]

* igt@prime_vgem@basic-fence-flip:
- fi-tgl-y: [PASS][20] -> [DMESG-WARN][21] ([i915#402]) +1 similar issue
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-tgl-y/igt@[email protected]

* igt@runner@aborted:
- fi-byt-j1900: NOTRUN -> [FAIL][22] ([i915#1814] / [i915#2505])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-byt-j1900/igt@[email protected]

#### Possible fixes ####

* igt@gem_tiled_blits@basic:
- fi-tgl-y: [DMESG-WARN][23] ([i915#402]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-tgl-y/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-tgl-y/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-n3050: [INCOMPLETE][25] ([i915#2940]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9666/fi-bsw-n3050/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/fi-bsw-n3050/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#1161]: https://gitlab.freedesktop.org/drm/intel/issues/1161
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#1814]: https://gitlab.freedesktop.org/drm/intel/issues/1814
[i915#2128]: https://gitlab.freedesktop.org/drm/intel/issues/2128
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2505]: https://gitlab.freedesktop.org/drm/intel/issues/2505
[i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402

Participating hosts (41 -> 37)
------------------------------

Missing (4): fi-ilk-m540 fi-bsw-cyan fi-bdw-samus fi-hsw-4200u

Build changes
-------------

* IGT: IGT_5962 -> IGTPW_5412
* Linux: CI_DRM_9666 -> Patchwork_19449

CI-20190529: 20190529
CI_DRM_9666: 9ccbc653bf2948d1f7e9ff300dd7679b888ffa25 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5412: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5412/index.html
IGT_5962: 22e3daaed82ab7890018a2f2aabf5082cd536023 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19449: 70d666e29d2c14991e921011bdaee1c3340aced5 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

70d666e29d2c drm/i915: Disable pread/pwrite ioctl's for IGT testing

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19449/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Disable pread/pwrite ioctl's for IGT testing (rev2)

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: drm/i915: Disable pread/pwrite ioctl's for IGT testing (rev2)
URL : https://patchwork.freedesktop.org/series/86155/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5455212ec45e drm/i915: Disable pread/pwrite ioctl's for IGT testing
-:38: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#38: FILE: drivers/gpu/drm/i915/i915_gem.c:373:
+	 * validated.
+	*/

total: 0 errors, 1 warnings, 0 checks, 36 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Disable pread/pwrite ioctl's for IGT testing (rev3)

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: drm/i915: Disable pread/pwrite ioctl's for IGT testing (rev3)
URL : https://patchwork.freedesktop.org/series/86155/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e3884dcf01a3 drm/i915: Disable pread/pwrite ioctl's for IGT testing
-:38: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#38: FILE: drivers/gpu/drm/i915/i915_gem.c:373:
+	 * validated.
+	*/

total: 0 errors, 1 warnings, 0 checks, 36 lines checked

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Disable pread/pwrite ioctl's for IGT testing (rev3)

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: drm/i915: Disable pread/pwrite ioctl's for IGT testing (rev3)
URL : https://patchwork.freedesktop.org/series/86155/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9857 -> Patchwork_19791
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_19791 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19791, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/index.html

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_19791:

### IGT changes ###

#### Possible regressions ####

* igt@gem_tiled_pread_basic:
- fi-icl-u2: [PASS][1] -> [SKIP][2] +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-icl-u2/igt@gem_tiled_pread_basic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-icl-u2/igt@gem_tiled_pread_basic.html

* igt@prime_vgem@basic-write:
- fi-tgl-u2: [PASS][3] -> [SKIP][4] +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-tgl-u2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-tgl-u2/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_exec_parallel@engines@userptr:
- {fi-tgl-dsi}: [PASS][5] -> [SKIP][6] +4 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-tgl-dsi/igt@gem_exec_parallel@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-tgl-dsi/igt@gem_exec_parallel@[email protected]

* igt@gem_tiled_pread_basic:
- {fi-jsl-1}: [PASS][7] -> [SKIP][8] +4 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-jsl-1/igt@gem_tiled_pread_basic.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-jsl-1/igt@gem_tiled_pread_basic.html

* igt@prime_vgem@basic-read:
- {fi-rkl-11500t}: [PASS][9] -> [SKIP][10] +4 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-rkl-11500t/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-rkl-11500t/igt@[email protected]

* igt@prime_vgem@basic-write:
- {fi-ehl-1}: [PASS][11] -> [SKIP][12] +4 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-ehl-1/igt@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-ehl-1/igt@[email protected]
- {fi-ehl-2}: [PASS][13] -> [SKIP][14] +4 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-ehl-2/igt@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-ehl-2/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_19791 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_linear_blits@basic:
- fi-kbl-8809g: [PASS][15] -> [TIMEOUT][16] ([i915#2502] / [i915#3145]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-kbl-8809g/igt@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-kbl-8809g/igt@[email protected]

#### Possible fixes ####

* igt@gem_exec_gttfill@basic:
- fi-kbl-8809g: [TIMEOUT][17] ([i915#3145]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-kbl-8809g/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-kbl-8809g/igt@[email protected]

* igt@i915_selftest@live@client:
- fi-glk-dsi: [DMESG-FAIL][19] ([i915#3047]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-glk-dsi/igt@i915_selftest@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-glk-dsi/igt@i915_selftest@[email protected]

#### Warnings ####

* igt@i915_pm_rpm@module-reload:
- fi-glk-dsi: [DMESG-WARN][21] ([i915#3143]) -> [DMESG-WARN][22] ([i915#1982] / [i915#3143])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9857/fi-glk-dsi/igt@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/fi-glk-dsi/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[i915#1222]: https://gitlab.freedesktop.org/drm/intel/issues/1222
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2502]: https://gitlab.freedesktop.org/drm/intel/issues/2502
[i915#3047]: https://gitlab.freedesktop.org/drm/intel/issues/3047
[i915#3143]: https://gitlab.freedesktop.org/drm/intel/issues/3143
[i915#3145]: https://gitlab.freedesktop.org/drm/intel/issues/3145

Participating hosts (44 -> 40)
------------------------------

Missing (4): fi-ctg-p8600 fi-ilk-m540 fi-bsw-cyan fi-bdw-samus

Build changes
-------------

* IGT: IGT_6032 -> IGTPW_5600
* Linux: CI_DRM_9857 -> Patchwork_19791

CI-20190529: 20190529
CI_DRM_9857: 0f9254e98a162e962fa4b9517645c4be44367e27 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5600: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5600/index.html
IGT_6032: f3fd2cc23455929d0ef276e05e02416b86a6db91 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19791: e3884dcf01a35a367e44e27e83acdd2d1b0ae70e @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

e3884dcf01a3 drm/i915: Disable pread/pwrite ioctl's for IGT testing

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19791/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx