Skip to contentSkip to conversation

drm/i915: Start disabling pread/pwrite ioctl's for future platforms

PATCH In review Ashutosh Dixit 5 participants 12 messages Jan 22, 2021 – Mar 12, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover drm/i915: Start disabling pread/pwrite ioctl's for future platforms

The guidance for i915 at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and (b) no existing user mode clients actually use the pread/pwrite interface.

In this patch we disable these ioctls for dGfx platforms with the expectation that this will be done for all future platforms (both discrete and integrated). IGT changes which handle this kernel change have also been submitted [1].

[1] https://patchwork.freedesktop.org/series/81384/

Test-with: [email protected]

Ashutosh Dixit (1):
drm/i915: Start disabling pread/pwrite ioctl's for future platforms

 drivers/gpu/drm/i915/i915_drv.h          | 1 +
 drivers/gpu/drm/i915/i915_gem.c          | 6 ++++++
 drivers/gpu/drm/i915/i915_pci.c          | 3 ++-
 drivers/gpu/drm/i915/intel_device_info.h | 1 +
 4 files changed, 10 insertions(+), 1 deletion(-)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 1/1 drm/i915: Start disabling pread/pwrite ioctl's for future platforms

The guidance for i915 at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and (b) no existing user mode clients actually use the pread/pwrite interface.

In this patch we disable these ioctls for dGfx platforms with the expectation that this will be done for all future platforms (both discrete and integrated). IGT changes which handle this kernel change have also been submitted [1].

[1] https://patchwork.freedesktop.org/series/81384/

---
 drivers/gpu/drm/i915/i915_drv.h          | 1 +
 drivers/gpu/drm/i915/i915_gem.c          | 6 ++++++
 drivers/gpu/drm/i915/i915_pci.c          | 3 ++-
 drivers/gpu/drm/i915/intel_device_info.h | 1 +
 4 files changed, 10 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
index 7efb501e22d2..66edffadf4a0 100644
@@ -1674,6 +1674,7 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)
 #define HAS_SECURE_BATCHES(dev_priv) (INTEL_GEN(dev_priv) < 6)
 #define HAS_WT(dev_priv)	HAS_EDRAM(dev_priv)
 
+#define HAS_PREAD_PWRITE(dev_priv)	(!INTEL_INFO(dev_priv)->no_pread_pwrite)
 #define HWS_NEEDS_PHYSICAL(dev_priv)	(INTEL_INFO(dev_priv)->hws_needs_physical)
 
 #define HAS_LOGICAL_RING_CONTEXTS(dev_priv) \
drivers/gpu/drm/i915/i915_gem.c +6 -0
index 9b04dff5eb32..9f3ef68fadf3 100644
@@ -382,6 +382,9 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data,
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	if (!HAS_PREAD_PWRITE(to_i915(dev)))
+		return -EOPNOTSUPP;
+
 	if (args->size == 0)
 		return 0;
 
@@ -687,6 +690,9 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	if (!HAS_PREAD_PWRITE(to_i915(dev)))
+		return -EOPNOTSUPP;
+
 	if (args->size == 0)
 		return 0;
 
drivers/gpu/drm/i915/i915_pci.c +2 -1
index 6cff7cf0f17b..3231d989275c 100644
@@ -910,7 +910,8 @@ static const struct intel_device_info rkl_info = {
 	.has_master_unit_irq = 1, \
 	.has_llc = 0, \
 	.has_snoop = 1, \
-	.is_dgfx = 1
+	.is_dgfx = 1, \
+	.no_pread_pwrite = 1
 
 static const struct intel_device_info dg1_info __maybe_unused = {
 	GEN12_DGFX_FEATURES,
drivers/gpu/drm/i915/intel_device_info.h +1 -0
index e6ca1023ffcf..8edd2cfb0bab 100644
@@ -114,6 +114,7 @@ enum intel_ppgtt_type {
 	func(is_lp); \
 	func(require_force_probe); \
 	func(is_dgfx); \
+	func(no_pread_pwrite); \
 	/* Keep has_* in alphabetical order */ \
 	func(has_64bit_reloc); \
 	func(gpu_reset_clobbers_display); \
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 76 lines · Ashutosh Dixit

The guidance for i915 at this time is to start phasing out pread/pwrite ioctl's, the rationale being (a) the functionality can be done entirely in userspace with a combination of mmap + memcpy, and (b) no existing user mode clients actually use the pread/pwrite interface.

In this patch we disable these ioctls for dGfx platforms with the expectation that this will be done for all future platforms (both discrete and integrated). IGT changes which handle this kernel change have also been submitted [1].

[1] https://patchwork.freedesktop.org/series/81384/

---
 drivers/gpu/drm/i915/i915_drv.h          | 1 +
 drivers/gpu/drm/i915/i915_gem.c          | 6 ++++++
 drivers/gpu/drm/i915/i915_pci.c          | 3 ++-
 drivers/gpu/drm/i915/intel_device_info.h | 1 +
 4 files changed, 10 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
index 7efb501e22d2..66edffadf4a0 100644
@@ -1674,6 +1674,7 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)
 #define HAS_SECURE_BATCHES(dev_priv) (INTEL_GEN(dev_priv) < 6)
 #define HAS_WT(dev_priv)       HAS_EDRAM(dev_priv)
 
+#define HAS_PREAD_PWRITE(dev_priv)     (!INTEL_INFO(dev_priv)->no_pread_pwrite)
 #define HWS_NEEDS_PHYSICAL(dev_priv)   (INTEL_INFO(dev_priv)->hws_needs_physical)
 
 #define HAS_LOGICAL_RING_CONTEXTS(dev_priv) \
drivers/gpu/drm/i915/i915_gem.c +6 -0
index 9b04dff5eb32..9f3ef68fadf3 100644
@@ -382,6 +382,9 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data,
        struct drm_i915_gem_object *obj;
        int ret;
 
+       if (!HAS_PREAD_PWRITE(to_i915(dev)))
+               return -EOPNOTSUPP;
+
        if (args->size == 0)
                return 0;
 
@@ -687,6 +690,9 @@ i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
        struct drm_i915_gem_object *obj;
        int ret;
 
+       if (!HAS_PREAD_PWRITE(to_i915(dev)))
+               return -EOPNOTSUPP;
+
        if (args->size == 0)
                return 0;
 
drivers/gpu/drm/i915/i915_pci.c +2 -1
index 6cff7cf0f17b..3231d989275c 100644
@@ -910,7 +910,8 @@ static const struct intel_device_info rkl_info = {
        .has_master_unit_irq = 1, \
        .has_llc = 0, \
        .has_snoop = 1, \
-       .is_dgfx = 1
+       .is_dgfx = 1, \
+       .no_pread_pwrite = 1
 
 static const struct intel_device_info dg1_info __maybe_unused = {
        GEN12_DGFX_FEATURES,
drivers/gpu/drm/i915/intel_device_info.h +0 -0
index e6ca1023ffcf..8edd2cfb0bab 100644

drivers/gpu/drm/i915/intel_device_info.h enum intel_ppgtt_type { · line 117

Quoted 4 lines
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -114,6 +114,7 @@ enum intel_ppgtt_type {
        func(is_lp); \
        func(require_force_probe); \
        func(is_dgfx); \
+       func(no_pread_pwrite); \

Is it really better to add a device_info flag here or would we be better off making it dependent on HW generation? This is what I did for relocs:

       /* Relocations are disallowed for all platforms after TGL-LP */
       if (INTEL_GEN(eb->i915) >= 12 && !IS_TIGERLAKE(eb->i915))
               return -EINVAL;

       /* All discrete memory platforms are Gen12 or above */
       BUG_ON(HAS_LMEM(eb->i915));

At least to me, that makes the code more obvious.

--Jason
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Start disabling pread/pwrite ioctl's for future platforms

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: drm/i915: Start disabling pread/pwrite ioctl's for future platforms
URL : https://patchwork.freedesktop.org/series/86199/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9671 -> Patchwork_19470
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html

Known issues
------------

Here are the changes found in Patchwork_19470 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@userptr:
- fi-byt-j1900: NOTRUN -> [SKIP][1] ([fdo#109271]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/fi-byt-j1900/igt@amdgpu/[email protected]

* igt@debugfs_test@read_all_entries:
- fi-tgl-y: [PASS][2] -> [DMESG-WARN][3] ([i915#402])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/fi-tgl-y/igt@debugfs_test@read_all_entries.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/fi-tgl-y/igt@debugfs_test@read_all_entries.html

#### Possible fixes ####

* igt@fbdev@write:
- fi-tgl-y: [DMESG-WARN][4] ([i915#402]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/fi-tgl-y/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/fi-tgl-y/igt@[email protected]

* igt@i915_module_load@reload:
- fi-kbl-7500u: [DMESG-WARN][6] ([i915#2605]) -> [PASS][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/fi-kbl-7500u/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/fi-kbl-7500u/igt@[email protected]

* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [INCOMPLETE][8] ([i915#142] / [i915#2405]) -> [PASS][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/fi-byt-j1900/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/fi-byt-j1900/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#142]: https://gitlab.freedesktop.org/drm/intel/issues/142
[i915#2405]: https://gitlab.freedesktop.org/drm/intel/issues/2405
[i915#2605]: https://gitlab.freedesktop.org/drm/intel/issues/2605
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402

Participating hosts (40 -> 37)
------------------------------

Missing (3): fi-ilk-m540 fi-bsw-cyan fi-hsw-4200u

Build changes
-------------

* IGT: IGT_5964 -> IGTPW_5412
* Linux: CI_DRM_9671 -> Patchwork_19470

CI-20190529: 20190529
CI_DRM_9671: b91884d8aeac7dbad7ec084e4de0a5b2f596233b @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5412: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5412/index.html
IGT_5964: 0949766cb9846d7d55fac9cdf31d3d8e8ed1d0c6 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_19470: e3103935144f58d24f8d21a2a38bcfc620eebed3 @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

e3103935144f drm/i915: Start disabling pread/pwrite ioctl's for future platforms

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Start disabling pread/pwrite ioctl's for future platforms

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: drm/i915: Start disabling pread/pwrite ioctl's for future platforms
URL : https://patchwork.freedesktop.org/series/86199/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_9671_full -> Patchwork_19470_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_19470_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19470_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_19470_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_sequence@queue-busy:
- shard-skl: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl4/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_19470_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@legacy-engines-hostile:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-snb4/igt@[email protected]
- shard-hsw: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#1099])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw2/igt@[email protected]

* igt@gem_eio@suspend:
- shard-iclb: [PASS][5] -> [INCOMPLETE][6] ([i915#1185] / [i915#2483])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb8/igt@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@[email protected]

* igt@gem_exec_balancer@bonded-pair:
- shard-hsw: NOTRUN -> [SKIP][7] ([fdo#109271]) +43 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw2/igt@[email protected]

* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][8] -> [INCOMPLETE][9] ([i915#2369])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl10/igt@gem_exec_capture@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl3/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][10] -> [FAIL][11] ([i915#2842])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb6/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][12] -> [SKIP][13] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-apl7/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [PASS][14] -> [FAIL][15] ([i915#2842]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-kbl7/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [PASS][16] -> [FAIL][17] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb7/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][18] -> [SKIP][19] ([fdo#109271])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-kbl2/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][20] -> [FAIL][21] ([i915#2842])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk9/igt@gem_exec_fair@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk4/igt@gem_exec_fair@[email protected]
- shard-iclb: NOTRUN -> [FAIL][22] ([i915#2849])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][23] ([fdo#109313])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb7/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: NOTRUN -> [DMESG-WARN][24] ([i915#118] / [i915#95])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk4/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-glk: [PASS][25] -> [DMESG-WARN][26] ([i915#118] / [i915#95])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk2/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk4/igt@[email protected]

* igt@gem_userptr_blits@coherency-unsync:
- shard-tglb: NOTRUN -> [SKIP][27] ([fdo#110542])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109290])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@[email protected]

* igt@gen7_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][29] ([fdo#109289]) +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb7/igt@[email protected]

* igt@gen7_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> [SKIP][30] ([fdo#109289]) +2 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]

* igt@gen9_exec_parse@unaligned-access:
- shard-iclb: NOTRUN -> [SKIP][31] ([fdo#112306])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- shard-tglb: NOTRUN -> [DMESG-FAIL][32] ([i915#2373])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb7/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@gt_pm:
- shard-tglb: NOTRUN -> [DMESG-FAIL][33] ([i915#1759] / [i915#2291])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb7/igt@i915_selftest@live@gt_pm.html
- shard-skl: NOTRUN -> [DMESG-FAIL][34] ([i915#1886] / [i915#2291])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl8/igt@i915_selftest@live@gt_pm.html

* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-kbl: NOTRUN -> [SKIP][35] ([fdo#109271]) +40 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][36] ([fdo#110725] / [fdo#111614]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#111614])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#111615])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_big_joiner@basic:
- shard-tglb: NOTRUN -> [SKIP][39] ([i915#2705])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb8/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#2705])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl8/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#2705])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][42] ([i915#2705])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#2705])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk9/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][44] ([fdo#109271] / [i915#2705])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl2/igt@[email protected]

* igt@kms_ccs@pipe-c-bad-rotation-90:
- shard-skl: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111304])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl6/igt@[email protected]

* igt@kms_chamelium@dp-audio-edid:
- shard-tglb: NOTRUN -> [SKIP][46] ([fdo#109284] / [fdo#111827]) +2 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb3/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-snb4/igt@[email protected]
- shard-hsw: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw1/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl5/igt@[email protected]

* igt@kms_color@pipe-d-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109278] / [i915#1149])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][51] ([fdo#109284] / [fdo#111827]) +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb6/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk8/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +4 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][55] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-skl: [PASS][56] -> [FAIL][57] ([i915#54]) +7 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl3/igt@[email protected]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
- shard-glk: NOTRUN -> [SKIP][58] ([fdo#109271]) +32 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109278] / [fdo#109279])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109279])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb8/igt@[email protected]

* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109274] / [fdo#109278])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [PASS][62] -> [FAIL][63] ([i915#2346]) +1 similar issue
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl9/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][64] -> [INCOMPLETE][65] ([i915#198])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl3/igt@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl5/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-skl: NOTRUN -> [SKIP][66] ([fdo#109271]) +97 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl3/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#109274]) +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@b-hdmi-a1:
- shard-hsw: [PASS][68] -> [INCOMPLETE][69] ([i915#2055] / [i915#2295])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-hsw1/igt@kms_flip@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw2/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-skl: [PASS][70] -> [FAIL][71] ([i915#2628])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl1/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-skl: NOTRUN -> [FAIL][72] ([i915#2628])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-apl: NOTRUN -> [SKIP][73] ([fdo#109271]) +58 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109280]) +18 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][75] ([fdo#109271]) +47 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-snb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#111825]) +17 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_hdr@bpc-switch:
- shard-skl: NOTRUN -> [FAIL][77] ([i915#1188])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][78] -> [FAIL][79] ([i915#1188])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl1/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][80] ([fdo#108145] / [i915#265])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl2/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][81] ([fdo#108145] / [i915#265])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][82] -> [FAIL][83] ([fdo#108145] / [i915#265]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl9/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl5/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#2733])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][85] ([fdo#109271] / [i915#658]) +1 similar issue
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#658]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][87] ([i915#2920])
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-tglb: NOTRUN -> [SKIP][88] ([i915#2920]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][89] ([fdo#109271] / [i915#658]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl6/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][90] ([fdo#109271] / [i915#658]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk9/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#658])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][92] -> [SKIP][93] ([fdo#109441]) +1 similar issue
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: NOTRUN -> [SKIP][94] ([fdo#109441])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@kms_psr@psr2_sprite_render.html

* igt@kms_vblank@pipe-d-ts-continuation-idle-hang:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109278]) +6 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#533])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl7/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#533])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@[email protected]

* igt@nouveau_crc@pipe-a-source-rg:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#2530])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2530])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@prime_nv_api@nv_self_import_to_different_fd:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#109291]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@prime_nv_api@nv_self_import_to_different_fd.html

* igt@prime_nv_test@i915_import_cpu_mmap:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109291]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@prime_nv_test@i915_import_cpu_mmap.html

* igt@sysfs_heartbeat_interval@nopreempt@rcs0:
- shard-skl: [PASS][102] -> [FAIL][103] ([i915#1778])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl10/igt@sysfs_heartbeat_interval@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl9/igt@sysfs_heartbeat_interval@[email protected]

* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-skl: [PASS][104] -> [FAIL][105] ([i915#2825])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl4/igt@sysfs_timeslice_duration@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@sysfs_timeslice_duration@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][106] ([i915#2842]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb6/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][108] ([i915#2842]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk9/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][110] ([i915#2842]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-kbl2/igt@gem_exec_fair@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][112] ([i915#2389]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk4/igt@gem_exec_reloc@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk3/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-apl: [DMESG-WARN][114] ([i915#1610]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-apl4/igt@gem_exec_schedule@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl7/igt@gem_exec_schedule@[email protected]
- shard-iclb: [DMESG-WARN][116] ([i915#2803]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb5/igt@gem_exec_schedule@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_schedule@u-fairslice@vcs0:
- shard-skl: [DMESG-WARN][118] ([i915#1610] / [i915#2803]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl3/igt@gem_exec_schedule@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@gem_exec_schedule@[email protected]

* igt@gem_vm_create@destroy-race:
- shard-tglb: [TIMEOUT][120] ([i915#2795]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb3/igt@[email protected]

* igt@gen9_exec_parse@bb-large:
- shard-apl: [TIMEOUT][122] ([i915#2502]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-apl3/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl8/igt@[email protected]

* igt@i915_pm_rpm@system-suspend:
- shard-skl: [INCOMPLETE][124] ([i915#146] / [i915#151] / [i915#2295]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][126] ([i915#2521]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl5/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-skl: [FAIL][128] ([i915#54]) -> [PASS][129] +10 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl6/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [FAIL][130] ([i915#2122]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl7/igt@kms_flip@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [SKIP][132] ([i915#433]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb5/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][134] ([i915#1188]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl8/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl9/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [SKIP][136] ([fdo#109271]) -> [PASS][137] +13 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl1/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][138] ([fdo#108145] / [i915#265]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl2/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl9/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][140] ([fdo#109441]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

#### Warnings ####

* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-hsw: [FAIL][142] ([i915#2389]) -> [FAIL][143] ([i915#1888] / [i915#2389])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-hsw4/igt@gem_exec_reloc@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw1/igt@gem_exec_reloc@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][144] ([i915#2681] / [i915#2684]) -> [WARN][145] ([i915#1804] / [i9

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#5 lore raw

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Start disabling pread/pwrite ioctl's for future platforms

Quoted 29 lines · Patchwork

[1 <text/plain; utf-8 (7bit)>]
[2 <text/html; utf-8 (7bit)>]
Project List - Patchwork

Patch Details

Series: drm/i915: Start disabling pread/pwrite ioctl's for future platforms
URL: https://patchwork.freedesktop.org/series/86199/
State: failure
Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html

CI Bug Log - changes from CI_DRM_9671_full -> Patchwork_19470_full

Summary

FAILURE

Serious unknown changes coming with Patchwork_19470_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19470_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_19470_full:

Quoted 7 lines

IGT changes

Possible regressions

* igt@kms_sequence@queue-busy:

* shard-skl: PASS -> FAIL

This is a unrelated failure and a false positive, the patch should not have any effect on this platform.

Seeing a few igt@kms_sequence bugs in gitlab but maybe the signature for this one is a little different. Thanks.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#6 lore raw

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Start disabling pread/pwrite ioctl's for future platforms

Re-reported.

-----Original Message-----
From: Dixit, Ashutosh <[email protected]>
Sent: Sunday, January 24, 2021 3:55 PM
To: [email protected]; Vudum, Lakshminarayana <[email protected]>
Subject: Re: ✗ Fi.CI.IGT: failure for drm/i915: Start disabling pread/pwrite ioctl's for future platforms

Quoted 31 lines · Patchwork

[1 <text/plain; utf-8 (7bit)>]
[2 <text/html; utf-8 (7bit)>]
Project List - Patchwork

Patch Details

Series: drm/i915: Start disabling pread/pwrite ioctl's for future
platforms
URL: https://patchwork.freedesktop.org/series/86199/
State: failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html

CI Bug Log - changes from CI_DRM_9671_full -> Patchwork_19470_full

Summary

FAILURE

Serious unknown changes coming with Patchwork_19470_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_19470_full, please notify your bug team to
allow them to document this new failure mode, which will reduce false positives in CI.

Possible new issues

Here are the unknown changes that may have been introduced in Patchwork_19470_full:

Quoted 7 lines

IGT changes

Possible regressions

* igt@kms_sequence@queue-busy:

* shard-skl: PASS -> FAIL

This is a unrelated failure and a false positive, the patch should not have any effect on this platform.

Seeing a few igt@kms_sequence bugs in gitlab but maybe the signature for this one is a little different. Thanks.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#7 lore raw

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Start disabling pread/pwrite ioctl's for future platforms

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: drm/i915: Start disabling pread/pwrite ioctl's for future platforms
URL : https://patchwork.freedesktop.org/series/86199/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_9671_full -> Patchwork_19470_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

Known issues
------------

Here are the changes found in Patchwork_19470_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_ctx_persistence@legacy-engines-hostile:
- shard-snb: NOTRUN -> [SKIP][1] ([fdo#109271] / [i915#1099])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-snb4/igt@[email protected]
- shard-hsw: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#1099])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw2/igt@[email protected]

* igt@gem_eio@suspend:
- shard-iclb: [PASS][3] -> [INCOMPLETE][4] ([i915#1185] / [i915#2483])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb8/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@[email protected]

* igt@gem_exec_balancer@bonded-pair:
- shard-hsw: NOTRUN -> [SKIP][5] ([fdo#109271]) +43 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw2/igt@[email protected]

* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][6] -> [INCOMPLETE][7] ([i915#2369])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl10/igt@gem_exec_capture@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl3/igt@gem_exec_capture@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-iclb: [PASS][8] -> [FAIL][9] ([i915#2842])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb6/igt@gem_exec_fair@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][10] -> [SKIP][11] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-apl7/igt@gem_exec_fair@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: [PASS][12] -> [FAIL][13] ([i915#2842]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-kbl7/igt@gem_exec_fair@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb7/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [PASS][16] -> [SKIP][17] ([fdo#109271])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-kbl2/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][18] -> [FAIL][19] ([i915#2842])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk9/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk4/igt@gem_exec_fair@[email protected]
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2849])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-iclb: NOTRUN -> [SKIP][21] ([fdo#109313])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb7/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-all:
- shard-glk: NOTRUN -> [DMESG-WARN][22] ([i915#118] / [i915#95])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk4/igt@[email protected]

* igt@gem_exec_whisper@basic-queues-forked-all:
- shard-glk: [PASS][23] -> [DMESG-WARN][24] ([i915#118] / [i915#95])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk2/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk4/igt@[email protected]

* igt@gem_userptr_blits@coherency-unsync:
- shard-tglb: NOTRUN -> [SKIP][25] ([fdo#110542])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][26] ([fdo#109290])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@[email protected]

* igt@gen7_exec_parse@batch-without-end:
- shard-tglb: NOTRUN -> [SKIP][27] ([fdo#109289]) +1 similar issue
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb7/igt@[email protected]

* igt@gen7_exec_parse@oacontrol-tracking:
- shard-iclb: NOTRUN -> [SKIP][28] ([fdo#109289]) +2 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]

* igt@gen9_exec_parse@unaligned-access:
- shard-iclb: NOTRUN -> [SKIP][29] ([fdo#112306])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@[email protected]

* igt@i915_selftest@live@gt_lrc:
- shard-tglb: NOTRUN -> [DMESG-FAIL][30] ([i915#2373])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb7/igt@i915_selftest@live@gt_lrc.html

* igt@i915_selftest@live@gt_pm:
- shard-tglb: NOTRUN -> [DMESG-FAIL][31] ([i915#1759] / [i915#2291])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb7/igt@i915_selftest@live@gt_pm.html
- shard-skl: NOTRUN -> [DMESG-FAIL][32] ([i915#1886] / [i915#2291])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl8/igt@i915_selftest@live@gt_pm.html

* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-kbl: NOTRUN -> [SKIP][33] ([fdo#109271]) +40 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][34] ([fdo#110725] / [fdo#111614]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#111614])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_big_fb@yf-tiled-16bpp-rotate-0:
- shard-tglb: NOTRUN -> [SKIP][36] ([fdo#111615])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_big_joiner@basic:
- shard-tglb: NOTRUN -> [SKIP][37] ([i915#2705])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb8/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][38] ([fdo#109271] / [i915#2705])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl8/igt@[email protected]
- shard-kbl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#2705])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][40] ([i915#2705])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#2705])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk9/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#2705])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl2/igt@[email protected]

* igt@kms_ccs@pipe-c-bad-rotation-90:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111304])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl6/igt@[email protected]

* igt@kms_chamelium@dp-audio-edid:
- shard-tglb: NOTRUN -> [SKIP][44] ([fdo#109284] / [fdo#111827]) +2 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb3/igt@[email protected]
- shard-snb: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-snb4/igt@[email protected]
- shard-hsw: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw1/igt@[email protected]

* igt@kms_chamelium@hdmi-hpd-storm-disable:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +8 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl5/igt@[email protected]

* igt@kms_color@pipe-d-ctm-blue-to-red:
- shard-iclb: NOTRUN -> [SKIP][48] ([fdo#109278] / [i915#1149])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-0-75:
- shard-iclb: NOTRUN -> [SKIP][49] ([fdo#109284] / [fdo#111827]) +3 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb6/igt@[email protected]

* igt@kms_color_chamelium@pipe-a-ctm-green-to-red:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +2 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk8/igt@[email protected]
- shard-apl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +4 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl7/igt@[email protected]

* igt@kms_color_chamelium@pipe-d-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][53] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-256x85-onscreen:
- shard-skl: [PASS][54] -> [FAIL][55] ([i915#54]) +7 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl3/igt@[email protected]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl6/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-512x170-offscreen:
- shard-glk: NOTRUN -> [SKIP][56] ([fdo#109271]) +32 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk5/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278] / [fdo#109279])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109279])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb8/igt@[email protected]

* igt@kms_cursor_legacy@2x-cursor-vs-flip-atomic:
- shard-iclb: NOTRUN -> [SKIP][59] ([fdo#109274] / [fdo#109278])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-busy-crc-atomic:
- shard-skl: [PASS][60] -> [FAIL][61] ([i915#2346]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl9/igt@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_fbcon_fbt@psr-suspend:
- shard-skl: [PASS][62] -> [INCOMPLETE][63] ([i915#198])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl3/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl5/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-skl: NOTRUN -> [SKIP][64] ([fdo#109271]) +97 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl3/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check:
- shard-iclb: NOTRUN -> [SKIP][65] ([fdo#109274]) +3 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb5/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@b-hdmi-a1:
- shard-hsw: [PASS][66] -> [INCOMPLETE][67] ([i915#2055] / [i915#2295])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-hsw1/igt@kms_flip@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw2/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-16bpp-ytile:
- shard-skl: [PASS][68] -> [FAIL][69] ([i915#2628])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl1/igt@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile:
- shard-skl: NOTRUN -> [FAIL][70] ([i915#2628])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc:
- shard-apl: NOTRUN -> [SKIP][71] ([fdo#109271]) +58 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-cur-indfb-move:
- shard-iclb: NOTRUN -> [SKIP][72] ([fdo#109280]) +18 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb7/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-snb: NOTRUN -> [SKIP][73] ([fdo#109271]) +47 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-snb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-indfb-pgflip-blt:
- shard-tglb: NOTRUN -> [SKIP][74] ([fdo#111825]) +17 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_hdr@bpc-switch:
- shard-skl: NOTRUN -> [FAIL][75] ([i915#1188])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_hdr@bpc-switch-dpms:
- shard-skl: [PASS][76] -> [FAIL][77] ([i915#1188])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl1/igt@[email protected]
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl7/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-a-alpha-7efc:
- shard-skl: NOTRUN -> [FAIL][78] ([fdo#108145] / [i915#265])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl2/igt@[email protected]
- shard-kbl: NOTRUN -> [FAIL][79] ([fdo#108145] / [i915#265])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][80] -> [FAIL][81] ([fdo#108145] / [i915#265]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl9/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl5/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping:
- shard-skl: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#2733])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl2/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-c-scaler-with-clipping-clamping.html

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-3:
- shard-kbl: NOTRUN -> [SKIP][83] ([fdo#109271] / [i915#658]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-4:
- shard-apl: NOTRUN -> [SKIP][84] ([fdo#109271] / [i915#658]) +1 similar issue
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl4/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#2920])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-1:
- shard-tglb: NOTRUN -> [SKIP][86] ([i915#2920]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb1/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#658]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl6/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][88] ([fdo#109271] / [i915#658]) +1 similar issue
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk9/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][89] ([i915#658])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb1/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][90] -> [SKIP][91] ([fdo#109441]) +1 similar issue
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb4/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109441])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb8/igt@kms_psr@psr2_sprite_render.html

* igt@kms_sequence@queue-busy:
- shard-skl: [PASS][93] -> [FAIL][94] ([i915#2995])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl4/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_vblank@pipe-d-ts-continuation-idle-hang:
- shard-iclb: NOTRUN -> [SKIP][95] ([fdo#109278]) +6 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@[email protected]

* igt@kms_vblank@pipe-d-wait-idle:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#533])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl7/igt@[email protected]
- shard-skl: NOTRUN -> [SKIP][97] ([fdo#109271] / [i915#533])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@[email protected]

* igt@nouveau_crc@pipe-a-source-rg:
- shard-iclb: NOTRUN -> [SKIP][98] ([i915#2530])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb4/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2530])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@prime_nv_api@nv_self_import_to_different_fd:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#109291]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@prime_nv_api@nv_self_import_to_different_fd.html

* igt@prime_nv_test@i915_import_cpu_mmap:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#109291]) +2 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@prime_nv_test@i915_import_cpu_mmap.html

* igt@sysfs_heartbeat_interval@nopreempt@rcs0:
- shard-skl: [PASS][102] -> [FAIL][103] ([i915#1778])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl10/igt@sysfs_heartbeat_interval@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl9/igt@sysfs_heartbeat_interval@[email protected]

* igt@sysfs_timeslice_duration@timeout@vecs0:
- shard-skl: [PASS][104] -> [FAIL][105] ([i915#2825])
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl4/igt@sysfs_timeslice_duration@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@sysfs_timeslice_duration@[email protected]

#### Possible fixes ####

* igt@gem_exec_fair@basic-flow@rcs0:
- shard-tglb: [FAIL][106] ([i915#2842]) -> [PASS][107] +1 similar issue
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb6/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-none-share@rcs0:
- shard-glk: [FAIL][108] ([i915#2842]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk9/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk3/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs1:
- shard-kbl: [FAIL][110] ([i915#2842]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-kbl2/igt@gem_exec_fair@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_reloc@basic-many-active@rcs0:
- shard-glk: [FAIL][112] ([i915#2389]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-glk4/igt@gem_exec_reloc@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-glk3/igt@gem_exec_reloc@[email protected]

* igt@gem_exec_schedule@u-fairslice@rcs0:
- shard-apl: [DMESG-WARN][114] ([i915#1610]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-apl4/igt@gem_exec_schedule@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl7/igt@gem_exec_schedule@[email protected]
- shard-iclb: [DMESG-WARN][116] ([i915#2803]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb5/igt@gem_exec_schedule@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb3/igt@gem_exec_schedule@[email protected]

* igt@gem_exec_schedule@u-fairslice@vcs0:
- shard-skl: [DMESG-WARN][118] ([i915#1610] / [i915#2803]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl3/igt@gem_exec_schedule@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@gem_exec_schedule@[email protected]

* igt@gem_vm_create@destroy-race:
- shard-tglb: [TIMEOUT][120] ([i915#2795]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb2/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb3/igt@[email protected]

* igt@gen9_exec_parse@bb-large:
- shard-apl: [TIMEOUT][122] ([i915#2502]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-apl3/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-apl8/igt@[email protected]

* igt@i915_pm_rpm@system-suspend:
- shard-skl: [INCOMPLETE][124] ([i915#146] / [i915#151] / [i915#2295]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl6/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_async_flips@alternate-sync-async-flip:
- shard-skl: [FAIL][126] ([i915#2521]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl5/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-128x128-random:
- shard-skl: [FAIL][128] ([i915#54]) -> [PASS][129] +10 similar issues
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl6/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl1/igt@[email protected]

* igt@kms_flip@plain-flip-fb-recreate@c-edp1:
- shard-skl: [FAIL][130] ([i915#2122]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl7/igt@kms_flip@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl4/igt@kms_flip@[email protected]

* igt@kms_hdmi_inject@inject-audio:
- shard-tglb: [SKIP][132] ([i915#433]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-tglb5/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-tglb6/igt@[email protected]

* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [FAIL][134] ([i915#1188]) -> [PASS][135]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl8/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl9/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-skl: [SKIP][136] ([fdo#109271]) -> [PASS][137] +13 similar issues
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl1/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl10/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [FAIL][138] ([fdo#108145] / [i915#265]) -> [PASS][139]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-skl2/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-skl9/igt@[email protected]

* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [SKIP][140] ([fdo#109441]) -> [PASS][141] +1 similar issue
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb2/igt@kms_psr@psr2_no_drrs.html

#### Warnings ####

* igt@gem_exec_reloc@basic-wide-active@rcs0:
- shard-hsw: [FAIL][142] ([i915#2389]) -> [FAIL][143] ([i915#1888] / [i915#2389])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-hsw4/igt@gem_exec_reloc@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-hsw1/igt@gem_exec_reloc@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][144] ([i915#2681] / [i915#2684]) -> [WARN][145] ([i915#1804] / [i915#2684])
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb8/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-iclb: [SKIP][146] ([i915#2920]) -> [SKIP][147] ([i915#658]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9671/shard-iclb2/igt@kms

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_19470/index.html

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#8 lore raw

cover drm/i915: Disable pread/pwrite ioctl's for future platforms (v2)

In reply to Ashutosh Dixit

The rationale for this change is roughly as follows:

1. The functionality can be done entirely in userspace with a combination of mmap + memcpy

2. The only reason anyone in userspace is still using it is because someone implemented bo_subdata that way in libdrm ages ago and they're all too lazy to write the 5 lines of code to do a map.

3. This falls cleanly into the category of things which will only get more painful with local memory support.

These ioctls aren't used much anymore by "real" userspace drivers. Vulkan has never used them and neither has the iris GL driver. The old i965 GL driver does use PWRITE for glBufferSubData but it only supports up through Gen11; Gen12 was never enabled in i965. The compute driver has never used PREAD/PWRITE. The only remaining user is the media driver which uses it exactly twice and they're easily removed [1] so expecting them to drop it going forward is reasonable.

IGT changes which handle this kernel change have also been submitted [2].

[1] https://github.com/intel/media-driver/pull/1160
[2] https://patchwork.freedesktop.org/series/81384/

v2 (Jason Ekstrand):
- Improved commit message with the status of all usermode drivers
- A more future-proof platform check

Test-with: [email protected]

Ashutosh Dixit (1):
drm/i915: Disable pread/pwrite ioctl's for future platforms (v2)

 drivers/gpu/drm/i915/i915_drv.h |  1 +
 drivers/gpu/drm/i915/i915_gem.c | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#9 lore raw

PATCH 1/1 drm/i915: Disable pread/pwrite ioctl's for future platforms (v2)

From: Ashutosh Dixit <[email protected]>

The rationale for this change is roughly as follows:

1. The functionality can be done entirely in userspace with a combination of mmap + memcpy

2. The only reason anyone in userspace is still using it is because someone implemented bo_subdata that way in libdrm ages ago and they're all too lazy to write the 5 lines of code to do a map.

3. This falls cleanly into the category of things which will only get more painful with local memory support.

These ioctls aren't used much anymore by "real" userspace drivers. Vulkan has never used them and neither has the iris GL driver. The old i965 GL driver does use PWRITE for glBufferSubData but it only supports up through Gen11; Gen12 was never enabled in i965. The compute driver has never used PREAD/PWRITE. The only remaining user is the media driver which uses it exactly twice and they're easily removed [1] so expecting them to drop it going forward is reasonable.

IGT changes which handle this kernel change have also been submitted [2].

[1] https://github.com/intel/media-driver/pull/1160
[2] https://patchwork.freedesktop.org/series/81384/

v2 (Jason Ekstrand):
- Improved commit message with the status of all usermode drivers
- A more future-proof platform check

---
 drivers/gpu/drm/i915/i915_drv.h |  1 +
 drivers/gpu/drm/i915/i915_gem.c | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +1 -0
index 1d45d7492d10d..3f74188fa8090 100644
@@ -1633,6 +1633,7 @@ tgl_stepping_get(struct drm_i915_private *dev_priv)
 #define HAS_SECURE_BATCHES(dev_priv) (INTEL_GEN(dev_priv) < 6)
 #define HAS_WT(dev_priv)	HAS_EDRAM(dev_priv)
 
+#define HAS_PREAD_PWRITE(dev_priv)	(!INTEL_INFO(dev_priv)->no_pread_pwrite)
 #define HWS_NEEDS_PHYSICAL(dev_priv)	(INTEL_INFO(dev_priv)->hws_needs_physical)
 
 #define HAS_LOGICAL_RING_CONTEXTS(dev_priv) \
drivers/gpu/drm/i915/i915_gem.c +18 -0
index b2e3b5cfccb4a..78ad5a9dd4784 100644
@@ -374,10 +374,19 @@ int
 i915_gem_pread_ioctl(struct drm_device *dev, void *data,
 		     struct drm_file *file)
 {
+	struct drm_i915_private *i915 = to_i915(dev);
 	struct drm_i915_gem_pread *args = data;
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	/* Pread is disallowed for all platforms after TGL-LP */
+	if (INTEL_GEN(i915) >= 12 && !IS_TIGERLAKE(i915))
+		return -EOPNOTSUPP;
+
+	/* All discrete memory platforms are Gen12 or above */
+	if (WARN_ON(HAS_LMEM(i915)))
+		return -EOPNOTSUPP;
+
 	if (args->size == 0)
 		return 0;
 
@@ -675,10 +684,19 @@ int
 i915_gem_pwrite_ioctl(struct drm_device *dev, void *data,
 		      struct drm_file *file)
 {
+	struct drm_i915_private *i915 = to_i915(dev);
 	struct drm_i915_gem_pwrite *args = data;
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	/* Pwrite is disallowed for all platforms after TGL-LP */
+	if (INTEL_GEN(i915) >= 12 && !IS_TIGERLAKE(i915))
+		return -EOPNOTSUPP;
+
+	/* All discrete memory platforms are Gen12 or above */
+	if (WARN_ON(HAS_LMEM(i915)))
+		return -EOPNOTSUPP;
+
 	if (args->size == 0)
 		return 0;
 
Signature · 6 lines
2.29.2

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#10 lore raw

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Disable pread/pwrite ioctl's for future platforms (v2)

Quoted 11 lines · Jason Ekstrand
drivers/gpu/drm/i915/i915_gem.c +1 -0
index b2e3b5cfccb4a..78ad5a9dd4784 100644
@@ -374,10 +374,19 @@ int
 i915_gem_pread_ioctl(struct drm_device *dev, void *data,
 		     struct drm_file *file)
 {
+	struct drm_i915_private *i915 = to_i915(dev);
 	struct drm_i915_gem_pread *args = data;

drivers/gpu/drm/i915/i915_gem.c int · line 388

Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +7 -0
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	/* Pread is disallowed for all platforms after TGL-LP */
+	if (INTEL_GEN(i915) >= 12 && !IS_TIGERLAKE(i915))
+		return -EOPNOTSUPP;
+
+	/* All discrete memory platforms are Gen12 or above */
+	if (WARN_ON(HAS_LMEM(i915)))
+		return -EOPNOTSUPP;

Not sure but you are probably trying to make it explicit that pread/pwrite are truly gone on dGfx? Because real dGfx are Gen12+ the code will return from the first if statement and never get to the second if statement. And there's talk on the relocation thread about tripping fake LMEM here for platforms prior to Gen12.

So I'd suggest get rid of this second if statement and only retain the first (for both pread and pwrite) since that seems to be entirely sufficient.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#11 lore raw

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Disable pread/pwrite ioctl's for future platforms (v2)

Op 2021-03-12 om 04:28 schreef Dixit, Ashutosh:

Quoted 27 lines · Jason Ekstrand
Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +1 -0
index b2e3b5cfccb4a..78ad5a9dd4784 100644
@@ -374,10 +374,19 @@ int
 i915_gem_pread_ioctl(struct drm_device *dev, void *data,
 		     struct drm_file *file)
 {
+	struct drm_i915_private *i915 = to_i915(dev);
 	struct drm_i915_gem_pread *args = data;

drivers/gpu/drm/i915/i915_gem.c int · line 388

Quoted 10 lines
drivers/gpu/drm/i915/i915_gem.c +7 -0
 	struct drm_i915_gem_object *obj;
 	int ret;
 
+	/* Pread is disallowed for all platforms after TGL-LP */
+	if (INTEL_GEN(i915) >= 12 && !IS_TIGERLAKE(i915))
+		return -EOPNOTSUPP;
+
+	/* All discrete memory platforms are Gen12 or above */
+	if (WARN_ON(HAS_LMEM(i915)))
+		return -EOPNOTSUPP;

Not sure but you are probably trying to make it explicit that pread/pwrite are truly gone on dGfx? Because real dGfx are Gen12+ the code will return from the first if statement and never get to the second if statement. And there's talk on the relocation thread about tripping fake LMEM here for platforms prior to Gen12.

Quoted 7 lines

So I'd suggest get rid of this second if statement and only retain the first (for both pread and pwrite) since that seems to be entirely sufficient.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

I think this should probably be a -ENODEV return code, otherwise patch looks good to me.

We probably don't want to break fake lmem until it's removed..

Cc drm maintainers on next version?

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx