staging: rtl8723bs: remove unused code blocks
cover staging: rtl8723bs: remove unused code blocks
Remove unused code blocks as required in TODO file
Fabio Aiuto (15):
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_AUTO_AP_MODE
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_HW_PWRP_DETECTION
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_QOS_OPTIMIZATION
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_AP_WOWLAN
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_PM
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SIGNAL_DISPLAY_DBM
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_BACKGROUND_NOISE_MONITOR
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SKIP_SIGNAL_SCALE_MAPPING
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_GPIO_API
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_EXT_CLK
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_CHECK_BT_HANG
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SDIO_TX_TASKLET
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SW_CHANNEL_PLAN
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_C2H_PACKET_EN
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_ODM_ADAPTIVITY
drivers/staging/rtl8723bs/core/rtw_ap.c | 4 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 - drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 250 ------------- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 35 -- drivers/staging/rtl8723bs/core/rtw_recv.c | 32 -- .../staging/rtl8723bs/core/rtw_wlan_util.c | 126 ------- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 - drivers/staging/rtl8723bs/hal/hal_com.c | 37 -- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 9 - drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 339 ------------------ drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 3 - .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 71 ---- .../staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 - drivers/staging/rtl8723bs/hal/sdio_halinit.c | 126 ------- drivers/staging/rtl8723bs/hal/sdio_ops.c | 37 -- drivers/staging/rtl8723bs/include/drv_types.h | 6 - .../rtl8723bs/include/drv_types_sdio.h | 5 - drivers/staging/rtl8723bs/include/hal_com.h | 10 - .../staging/rtl8723bs/include/hal_com_h2c.h | 30 -- drivers/staging/rtl8723bs/include/hal_data.h | 5 - drivers/staging/rtl8723bs/include/hal_intf.h | 3 - .../staging/rtl8723bs/include/osdep_service.h | 7 - .../staging/rtl8723bs/include/rtl8723b_cmd.h | 6 - .../staging/rtl8723bs/include/rtl8723b_hal.h | 11 - drivers/staging/rtl8723bs/include/rtw_mp.h | 3 - drivers/staging/rtl8723bs/include/rtw_recv.h | 5 - drivers/staging/rtl8723bs/include/rtw_xmit.h | 4 - drivers/staging/rtl8723bs/include/sdio_ops.h | 7 - drivers/staging/rtl8723bs/include/sta_info.h | 5 - .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 - .../staging/rtl8723bs/os_dep/ioctl_linux.c | 130 +------ drivers/staging/rtl8723bs/os_dep/os_intfs.c | 142 -------- drivers/staging/rtl8723bs/os_dep/recv_linux.c | 41 --- 33 files changed, 1 insertion(+), 1512 deletions(-)
Signature · 1 line
2.20.1
PATCH 1/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_AUTO_AP_MODE
remove conditional code blocks checked by unused CONFIG_AUTO_AP_MODE
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/core/rtw_ap.c | 4 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 3 - drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 238 ------------------ drivers/staging/rtl8723bs/core/rtw_recv.c | 32 --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 5 - .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 3 - drivers/staging/rtl8723bs/include/sta_info.h | 5 - drivers/staging/rtl8723bs/os_dep/recv_linux.c | 41 --- 8 files changed, 331 deletions(-)
drivers/staging/rtl8723bs/core/rtw_ap.c +0 -4
@@ -270,10 +270,6 @@ void expire_timeout_chk(struct adapter *padapter)while (phead != plist) { psta = container_of(plist, struct sta_info, asoc_list); plist =get_next (plist); -#ifdef CONFIG_AUTO_AP_MODE -if (psta->isrc) -continue ; -#endif if (chk_sta_is_alive (psta) || !psta->expire_to) { psta->expire_to = pstapriv->expire_to; psta->keep_alive_trycnt =0 ;
drivers/staging/rtl8723bs/core/rtw_mlme.c +0 -3
@@ -1478,8 +1478,6 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf)rtw_sta_media_status_rpt (adapter, psta,1 ); -#ifndef CONFIG_AUTO_AP_MODE -ap_sta_info_defer_update (adapter, psta);/* report to upper layer */
@@ -1503,7 +1501,6 @@ void rtw_stassoc_event_callback(struct adapter *adapter, u8 *pbuf)kfree (passoc_req); } -#endif /* CONFIG_AUTO_AP_MODE */ }return ; }
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -238
262 lines not on this page · raw message
drivers/staging/rtl8723bs/core/rtw_recv.c +0 -32
@@ -1600,38 +1600,6 @@ signed int wlanhdr_to_ethhdr(union recv_frame *precvframe) eth_type =ntohs (be_tmp);/* pattrib->ether_type */ pattrib->eth_type = eth_type; -#ifdef CONFIG_AUTO_AP_MODE -if (0x8899 == pattrib->eth_type) { -struct sta_info *psta = precvframe->u.hdr.psta; - -DBG_871X ("wlan rx: got eth_type = 0x%x\n" , pattrib->eth_type); - -if (psta && psta->isrc && psta->pid >0 ) { -u16 rx_pid; - - rx_pid = *(u16 *)(ptr+rmv_len+2 ); - -DBG_871X ("wlan rx(pid = 0x%x): sta(%pM) pid = 0x%x\n" , - rx_pid,MAC_ARG (psta->hwaddr), psta->pid); - -if (rx_pid == psta->pid) { -int i; -u16 len = *(u16 *)(ptr+rmv_len+4 ); -/* u16 ctrl_type = *(u16*)(ptr+rmv_len+6); */ - -/* DBG_871X("RC: len = 0x%x, ctrl_type = 0x%x\n", len, ctrl_type); */ -DBG_871X ("RC: len = 0x%x\n" , len); - -for (i =0 ; i < len ; i++) -DBG_871X ("0x%x\n" , *(ptr+rmv_len+6 +i)); -/* DBG_871X("0x%x\n", *(ptr+rmv_len+8+i)); */ - -DBG_871X ("RC-end\n" ); - } - } - } -#endif /* CONFIG_AUTO_AP_MODE */ -if ((check_fwstate (pmlmepriv,WIFI_MP_STATE ) == true)) { ptr += rmv_len; *ptr =0x87 ;
drivers/staging/rtl8723bs/core/rtw_xmit.c +0 -5
@@ -467,11 +467,6 @@ static void update_attrib_phy_info(struct adapter *padapter, struct pkt_attrib * pattrib->ampdu_spacing = psta->htpriv.rx_ampdu_min_spacing; pattrib->retry_ctrl = false; - -#ifdef CONFIG_AUTO_AP_MODE -if (psta->isrc && psta->pid >0 ) - pattrib->pctrl = true; -#endif }static s32 update_attrib_sec_info (struct adapter *padapter,struct pkt_attrib *pattrib,struct sta_info *psta)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0 -3
@@ -3079,9 +3079,6 @@ static void rtl8723b_fill_default_txdesc( (pattrib->ether_type != 0x88B4) && (pattrib->dhcp_pkt != 1) && (drv_userate != 1) -#ifdef CONFIG_AUTO_AP_MODE - && (!pattrib->pctrl) -#endif ) {/* Non EAP & ARP & DHCP type data packet */
drivers/staging/rtl8723bs/include/sta_info.h +0 -5
@@ -182,11 +182,6 @@ struct sta_info {u8 keep_alive_trycnt; -#ifdef CONFIG_AUTO_AP_MODE -u8 isrc;/* this device is rc */ -u16 pid;/* pairing id */ -#endif -u8 *passoc_req;u32 assoc_req_len;
drivers/staging/rtl8723bs/os_dep/recv_linux.c +0 -41
53 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH 2/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_HW_PWRP_DETECTION
In reply to Fabio Aiutoremove conditional code blocks checked by unused CONFIG_HW_PWRP_DETECTION
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -4
@@ -113,11 +113,7 @@ static int rtw_enusbss;/* 0:disable, 1:enable */static int rtw_hwpdn_mode =2 ;/* 0:disable, 1:enable, 2: by EFUSE config */ -#ifdef CONFIG_HW_PWRP_DETECTION -static int rtw_hwpwrp_detect =1 ; -#else static int rtw_hwpwrp_detect;/* HW power ping detect 0:disable , 1:enable */ -#endif static int rtw_hw_wps_pbc;
Signature · 1 line
2.20.1
PATCH 3/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_QOS_OPTIMIZATION
In reply to Fabio Aiutoremove conditional code blocks checked by unused CONFIG_QOS_OPTIMIZATION
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -4
@@ -121,11 +121,7 @@ int rtw_mc2u_disable = 0;static int rtw_80211d; -#ifdef CONFIG_QOS_OPTIMIZATION -static int rtw_qos_opt_enable =1 ;/* 0: disable, 1:enable */ -#else static int rtw_qos_opt_enable;/* 0: disable, 1:enable */ -#endif module_param (rtw_qos_opt_enable, int,0644 );static char *ifname ="wlan%d" ;
Signature · 1 line
2.20.1
PATCH 4/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_AP_WOWLAN
In reply to Fabio Aiutoremove conditional code blocks checked by unused CONFIG_AP_WOWLAN
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 35 -- .../staging/rtl8723bs/core/rtw_wlan_util.c | 31 -- drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 339 ------------------ .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 33 -- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 105 ------ drivers/staging/rtl8723bs/hal/sdio_ops.c | 35 -- .../rtl8723bs/include/drv_types_sdio.h | 5 - .../staging/rtl8723bs/include/hal_com_h2c.h | 30 -- drivers/staging/rtl8723bs/include/hal_intf.h | 3 - .../staging/rtl8723bs/include/osdep_service.h | 7 - .../staging/rtl8723bs/include/rtl8723b_cmd.h | 6 - .../staging/rtl8723bs/include/rtl8723b_hal.h | 4 - drivers/staging/rtl8723bs/include/rtw_mp.h | 3 - drivers/staging/rtl8723bs/include/sdio_ops.h | 7 - .../staging/rtl8723bs/os_dep/ioctl_linux.c | 4 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 134 ------- 16 files changed, 781 deletions(-)
drivers/staging/rtl8723bs/core/rtw_pwrctrl.c +0 -35
@@ -350,17 +350,8 @@ static u8 PS_RDY_CHECK(struct adapter *padapter)struct pwrctrl_priv *pwrpriv =adapter_to_pwrctl (padapter);struct mlme_priv *pmlmepriv = &(padapter->mlmepriv); -#ifdef CONFIG_AP_WOWLAN -if (pwrpriv->bInSuspend && pwrpriv->wowlan_mode) -return true; -else if (pwrpriv->bInSuspend && pwrpriv->wowlan_ap_mode) -return true; -else if (pwrpriv->bInSuspend) -return false; -#else if (pwrpriv->bInSuspend)return false; -#endif curr_time = jiffies;
@@ -391,9 +382,6 @@ static u8 PS_RDY_CHECK(struct adapter *padapter)void rtw_set_ps_mode (struct adapter *padapter,u8 ps_mode,u8 smart_ps,u8 bcn_ant_mode,const char *msg) {struct pwrctrl_priv *pwrpriv =adapter_to_pwrctl (padapter); -#ifdef CONFIG_AP_WOWLAN -struct debug_priv *pdbgpriv = &padapter->dvobj->drv_dbg; -#endif RT_TRACE(_module_rtl871x_pwrctrl_c_, _drv_notice_, ("%s: PowerMode =%d Smart_PS =%d\n",
@@ -422,29 +410,6 @@ void rtw_set_ps_mode(struct adapter *padapter, u8 ps_mode, u8 smart_ps, u8 bcn_a pwrpriv->pwr_mode = ps_mode;rtw_set_rpwm (padapter,PS_STATE_S4 ); -#ifdef CONFIG_AP_WOWLAN -if (pwrpriv->wowlan_mode || pwrpriv->wowlan_ap_mode) { -unsigned long start_time; -u32 delay_ms; -u8 val8; - delay_ms =20 ; - start_time = jiffies; -do { -rtw_hal_get_hwreg (padapter,HW_VAR_SYS_CLKR , &val8); -if (!(val8 &BIT (4 ))) {/* 0x08 bit4 = 1 --> in 32k, bit4 = 0 --> leave 32k */ - pwrpriv->cpwm =PS_STATE_S4 ; -break ; - } -if (jiffies_to_msecs (jiffies - start_time) > delay_ms) { -DBG_871X ("%s: Wait for FW 32K leave more than %u ms!!!\n" , - __func__, delay_ms); - pdbgpriv->dbg_wow_leave_ps_fail_cnt++; -break ; - } -msleep (1 ); - }while (1 ); - } -#endif rtw_hal_set_hwreg (padapter,HW_VAR_H2C_FW_PWRMODE , (u8 *)(&ps_mode)); pwrpriv->bFwCurrentInPSMode = false;
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +0 -31
@@ -10,10 +10,6 @@#include <rtw_debug.h> #include <hal_com_h2c.h> -#ifdef CONFIG_AP_WOWLAN -#include <linux/inetdevice.h> -#endif -static unsigned char ARTHEROS_OUI1 [] = {0x00 ,0x03 ,0x7f };static unsigned char ARTHEROS_OUI2 [] = {0x00 ,0x13 ,0x74 };
@@ -2113,30 +2109,3 @@ int rtw_config_gpio(struct net_device *netdev, int gpio_num, bool isOutput)EXPORT_SYMBOL (rtw_config_gpio);#endif -#ifdef CONFIG_AP_WOWLAN -void rtw_get_current_ip_address (struct adapter *padapter,u8 *pcurrentip) -{ -struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv; -struct mlme_ext_info *pmlmeinfo = &(pmlmeext->mlmext_info); -struct in_device *my_ip_ptr = padapter->pnetdev->ip_ptr; -u8 ipaddress[4 ]; - -if ((pmlmeinfo->state &WIFI_FW_LINKING_STATE ) || - pmlmeinfo->state &WIFI_FW_AP_STATE ) { -if (my_ip_ptr) { -struct in_ifaddr *my_ifa_list = my_ip_ptr->ifa_list; - -if (my_ifa_list) { - ipaddress[0 ] = my_ifa_list->ifa_address &0xFF ; - ipaddress[1 ] = (my_ifa_list->ifa_address >>8 ) &0xFF ; - ipaddress[2 ] = (my_ifa_list->ifa_address >>16 ) &0xFF ; - ipaddress[3 ] = my_ifa_list->ifa_address >>24 ; -DBG_871X ("%s: %d.%d.%d.%d ==========\n" , __func__, - ipaddress[0 ], ipaddress[1 ], ipaddress[2 ], ipaddress[3 ]); -memcpy (pcurrentip, ipaddress,4 ); - } - } - } -} -#endif -
drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c +0 -339
374 lines not on this page · raw message
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0 -33
@@ -527,39 +527,6 @@ void rtl8723b_InitializeFirmwareVars(struct adapter *padapter)/* pHalData->H2CStopInsertQueue = false; */ } -#ifdef CONFIG_AP_WOWLAN -/* */ - -/* */ -/* Description: Prepare some information to Fw for WoWLAN. */ -/* (1) Download wowlan Fw. */ -/* (2) Download RSVD page packets. */ -/* (3) Enable AP offload if needed. */ -/* */ -/* 2011.04.12 by tynli. */ -/* */ -void SetFwRelatedForWoWLAN8723b ( -struct adapter *padapter,u8 bHostIsGoingtoSleep -) -{ -int status = _FAIL; -/* */ -/* 1. Before WoWLAN we need to re-download WoWLAN Fw. */ -/* */ - status =rtl8723b_FirmwareDownload (padapter, bHostIsGoingtoSleep); -if (status != _SUCCESS) { -DBG_871X ("SetFwRelatedForWoWLAN8723b(): Re-Download Firmware failed!!\n" ); -return ; - }else { -DBG_871X ("SetFwRelatedForWoWLAN8723b(): Re-Download Firmware Success !!\n" ); - } -/* */ -/* 2. Re-Init the variables about Fw related setting. */ -/* */ -rtl8723b_InitializeFirmwareVars (padapter); -} -#endif /* CONFIG_AP_WOWLAN */ -static void rtl8723b_free_hal_data (struct adapter *padapter) { }
drivers/staging/rtl8723bs/hal/sdio_halinit.c +0 -105
117 lines not on this page · raw message
drivers/staging/rtl8723bs/hal/sdio_ops.c +0 -35
@@ -1114,39 +1114,4 @@ void HalQueryTxOQTBufferStatus8723BSdio(struct adapter *adapter) haldata->SdioTxOQTFreeSpace =SdioLocalCmd52Read1Byte (adapter,SDIO_REG_OQT_FREE_PG ); } -#ifdef CONFIG_AP_WOWLAN -u8 RecvOnePkt (struct adapter *adapter,u32 size) -{ -struct recv_buf *recvbuf; -struct dvobj_priv *sddev; -struct sdio_func *func; - -u8 res = false; - -DBG_871X ("+%s: size: %d+\n" , __func__, size); - -if (!adapter) { -DBG_871X (KERN_ERR "%s: adapter is NULL!\n" , __func__); -return false; - } - sddev =adapter_to_dvobj (adapter); - psdio_data = &sddev->intf_data; - func = psdio_data->func; - -if (size) { -sdio_claim_host (func); - recvbuf =sd_recv_rxfifo (adapter, size); - -if (recvbuf) { -sd_rxhandler (adapter, recvbuf); - res = true; - }else { - res = false; - } -sdio_release_host (func); - } -DBG_871X ("-%s-\n" , __func__); -return res; -} -#endif /* CONFIG_AP_WOWLAN */
drivers/staging/rtl8723bs/include/drv_types_sdio.h +0 -5
@@ -11,11 +11,6 @@#include <linux/mmc/sdio_func.h> #include <linux/mmc/sdio_ids.h> -#ifdef CONFIG_AP_WOWLAN -#include <linux/mmc/host.h> -#include <linux/mmc/card.h> -#endif -struct sdio_data {u8 func_number;
drivers/staging/rtl8723bs/include/hal_com_h2c.h +0 -30
@@ -120,28 +120,6 @@ enum h2c_cmd {#define SET_H2CCMD_DISCONDECISION_PARM_CHECK_PERIOD (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT(__pH2CCmd+1, 0, 8, __Value)#define SET_H2CCMD_DISCONDECISION_PARM_TRY_PKT_NUM (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT(__pH2CCmd+2, 0, 8, __Value) -#ifdef CONFIG_AP_WOWLAN -/* _AP_Offload 0x08 */ -#define SET_H2CCMD_AP_WOWLAN_EN (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT(__pH2CCmd, 0, 8, __Value) -/* _BCN_RsvdPage 0x09 */ -#define SET_H2CCMD_AP_WOWLAN_RSVDPAGE_LOC_BCN (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT(__pH2CCmd, 0, 8, __Value) -/* _Probersp_RsvdPage 0x0a */ -#define SET_H2CCMD_AP_WOWLAN_RSVDPAGE_LOC_ProbeRsp (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT(__pH2CCmd, 0, 8, __Value) -/* _Probersp_RsvdPage 0x13 */ -#define SET_H2CCMD_AP_WOW_GPIO_CTRL_INDEX (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 0, 4, __Value) -#define SET_H2CCMD_AP_WOW_GPIO_CTRL_C2H_EN (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 4, 1, __Value) -#define SET_H2CCMD_AP_WOW_GPIO_CTRL_PLUS (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 5, 1, __Value) -#define SET_H2CCMD_AP_WOW_GPIO_CTRL_HIGH_ACTIVE (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 6, 1, __Value) -#define SET_H2CCMD_AP_WOW_GPIO_CTRL_EN (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 7, 1, __Value) -#define SET_H2CCMD_AP_WOW_GPIO_CTRL_DURATION (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT((__pH2CCmd)+1, 0, 8, __Value) -#define SET_H2CCMD_AP_WOW_GPIO_CTRL_C2H_DURATION (__pH2CCmd, __Value)SET_BITS_TO_LE_1BYTE_8BIT((__pH2CCmd)+2, 0, 8, __Value) -/* _AP_PS 0x26 */ -#define SET_H2CCMD_AP_WOW_PS_EN (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 0, 1, __Value) -#define SET_H2CCMD_AP_WOW_PS_32K_EN (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 1, 1, __Value) -#define SET_H2CCMD_AP_WOW_PS_RF (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 2, 1, __Value) -#define SET_H2CCMD_AP_WOW_PS_DURATION (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE_8BIT((__pH2CCmd)+1, 0, 8, __Value) -#endif -/* _WoWLAN PARAM_CMD_0x80 */ #define SET_H2CCMD_WOWLAN_FUNC_ENABLE (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 0, 1, __Value)#define SET_H2CCMD_WOWLAN_PATTERN_MATCH_ENABLE (__pH2CCmd, __Value) SET_BITS_TO_LE_1BYTE(__pH2CCmd, 1, 1, __Value)
@@ -186,14 +164,6 @@ struct RSVDPAGE_LOC {u8 LocNullData;u8 LocQosNull; u8 LocBTQosNull; -#ifdef CONFIG_AP_WOWLAN -u8 LocApOffloadBCN; -#endif /* CONFIG_AP_WOWLAN */ };#endif -#ifdef CONFIG_AP_WOWLAN -void rtw_get_current_ip_address (struct adapter *padapter,u8 *pcurrentip); -void rtw_get_sec_iv (struct adapter *padapter,u8 *pcur_dot11txpn,u8 *StaAddr); -void rtw_set_sec_pn (struct adapter *padapter); -#endif
drivers/staging/rtl8723bs/include/hal_intf.h +0 -3
@@ -85,9 +85,6 @@ enum HW_VARIABLES {HW_VAR_APFM_ON_MAC ,/* Auto FSM to Turn On, include clock, isolation, power control for MAC only */ /* The valid upper nav range for the HW updating, if the true value is larger than the upper range, the HW won't update it. */ /* Unit in microsecond. 0 means disable this function. */ -#ifdef CONFIG_AP_WOWLAN -HW_VAR_AP_WOWLAN , -#endifHW_VAR_SYS_CLKR ,HW_VAR_NAV_UPPER , HW_VAR_C2H_HANDLE,
drivers/staging/rtl8723bs/include/osdep_service.h +0 -7
@@ -136,15 +136,8 @@ static inline int rtw_bug_check(void *parg1, void *parg2, void *parg3, void *par#define MAC_ARG (x) (x)#endif - -#ifdef CONFIG_AP_WOWLAN -extern void rtw_softap_lock_suspend (void ); -extern void rtw_softap_unlock_suspend (void ); -#endif -extern void rtw_free_netdev (struct net_device * netdev); -/* Macros for handling unaligned memory accesses */ void rtw_buf_free (u8 **buf,u32 *buf_len);
drivers/staging/rtl8723bs/include/rtl8723b_cmd.h +0 -6
@@ -177,12 +177,6 @@ void rtl8723b_download_BTCoex_AP_mode_rsvd_page(struct adapter *padapter);void CheckFwRsvdPageContent (struct adapter *padapter); -#ifdef CONFIG_AP_WOWLAN -void rtl8723b_set_wowlan_cmd (struct adapter *padapter,u8 enable); -void rtl8723b_set_ap_wowlan_cmd (struct adapter *padapter,u8 enable); -void SetFwRelatedForWoWLAN8723b (struct adapter *padapter,u8 bHostIsGoingtoSleep); -#endif -void rtl8723b_set_FwPwrModeInIPS_cmd (struct adapter *padapter,u8 cmd_param);s32 FillH2CCmd8723B (struct adapter *padapter,u8 ElementID,u32 CmdLen,u8 *pCmdBuffer);
drivers/staging/rtl8723bs/include/rtl8723b_hal.h +0 -4
@@ -98,10 +98,6 @@ struct rt_firmware_hdr {/* ARP Rsp:1, RWC:1, GTK Info:1, GTK RSP:2, GTK EXT MEM:2, PNO: 6 */ #define WOWLAN_PAGE_NUM_8723B 0x00 -#ifdef CONFIG_AP_WOWLAN -#define AP_WOWLAN_PAGE_NUM_8723B 0x02 -#endif -#define TX_TOTAL_PAGE_NUMBER_8723B \ (0xFF - BCNQ_PAGE_NUM_8723B - \ BCNQ1_PAGE_NUM_8723B - \
drivers/staging/rtl8723bs/include/rtw_mp.h +0 -3
@@ -189,9 +189,6 @@ enum {CTA_TEST ,MP_DISABLE_BT_COEXIST , MP_PwrCtlDM, -#ifdef CONFIG_AP_WOWLAN -MP_AP_WOW_ENABLE , -#endifMP_NULL , MP_GET_TXPOWER_INX, };
drivers/staging/rtl8723bs/include/sdio_ops.h +0 -7
@@ -25,17 +25,10 @@ s32 _sdio_write32(struct adapter *padapter, u32 addr, u32 val);extern void sd_int_hdl (struct adapter *padapter);extern u8 CheckIPSStatus (struct adapter *padapter); -#ifdef CONFIG_AP_WOWLAN -extern u8 RecvOnePkt (struct adapter *padapter,u32 size); -#endif extern void InitInterrupt8723BSdio (struct adapter *padapter);extern void InitSysInterrupt8723BSdio (struct adapter *padapter);extern void EnableInterrupt8723BSdio (struct adapter *padapter);extern void DisableInterrupt8723BSdio (struct adapter *padapter);extern u8 HalQueryTxBufferStatus8723BSdio (struct adapter *padapter);extern void HalQueryTxOQTBufferStatus8723BSdio (struct adapter *padapter); -#ifdef CONFIG_AP_WOWLAN -extern void ClearInterrupt8723BSdio (struct adapter *padapter); -#endif -#endif /* !__SDIO_OPS_H__ */
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +0 -4
@@ -4668,10 +4668,6 @@ static const struct iw_priv_args rtw_private_args[] = {SIOCIWFIRSTPRIV +0x1D ,IW_PRIV_TYPE_CHAR |40 ,IW_PRIV_TYPE_CHAR |0x7FF ,"test" }, - -#ifdef CONFIG_AP_WOWLAN - { MP_AP_WOW_ENABLE, IW_PRIV_TYPE_CHAR | 1024, 0, "ap_wow_mode" }, /* set */ -#endif }; static iw_handler rtw_private_handler[] = {
drivers/staging/rtl8723bs/os_dep/os_intfs.c +0 -134
160 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH 5/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM
In reply to Fabio Aiutoremove conditional code blocks checked by unused CONFIG_PM
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 -------- 1 file changed, 8 deletions(-)
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0 -8
@@ -3198,14 +3198,6 @@ static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wiphy *w wiphy->flags |=WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL ; wiphy->flags |=WIPHY_FLAG_OFFCHAN_TX |WIPHY_FLAG_HAVE_AP_SME ; -#if defined(CONFIG_PM ) - wiphy->max_sched_scan_reqs =1 ; -#endif - -#if defined(CONFIG_PM ) - wiphy->wowlan = &wowlan_stub; -#endif -if (padapter->registrypriv.power_mgnt !=PS_MODE_ACTIVE ) wiphy->flags |=WIPHY_FLAG_PS_ON_BY_DEFAULT ;else
Signature · 1 line
2.20.1
PATCH 6/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SIGNAL_DISPLAY_DBM
In reply to Fabio Aiutoremove conditional code blocks checked by unused CONFIG_SIGNAL_DISPLAY_DBM
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723bs/hal/hal_com.c | 4 ++-- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 21 +++---------------- 3 files changed, 6 insertions(+), 21 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +1 -1
@@ -4211,7 +4211,7 @@ void site_survey(struct adapter *padapter) channel_scan_time_ms = pmlmeext->chan_scan_time;set_survey_timer (pmlmeext, channel_scan_time_ms); -#if defined(CONFIG_SIGNAL_DISPLAY_DBM ) && defined(CONFIG_BACKGROUND_NOISE_MONITOR ) +#ifdef CONFIG_BACKGROUND_NOISE_MONITOR {struct noise_info info;
drivers/staging/rtl8723bs/hal/hal_com.c +2 -2
@@ -1262,7 +1262,7 @@ void GetHalODMVar( ) {switch (eVariable) { -#if defined(CONFIG_SIGNAL_DISPLAY_DBM ) && defined(CONFIG_BACKGROUND_NOISE_MONITOR ) +#ifdef CONFIG_BACKGROUND_NOISE_MONITOR case HAL_ODM_NOISE_MONITOR : {struct hal_com_data *pHalData =GET_HAL_DATA (Adapter);
@@ -1313,7 +1313,7 @@ void SetHalODMVar(case HAL_ODM_WIFI_DISPLAY_STATE :ODM_CmnInfoUpdate (podmpriv,ODM_CMNINFO_WIFI_DISPLAY , bSet);break ; -#if defined(CONFIG_SIGNAL_DISPLAY_DBM ) && defined(CONFIG_BACKGROUND_NOISE_MONITOR ) +#ifdef CONFIG_BACKGROUND_NOISE_MONITOR case HAL_ODM_NOISE_MONITOR : {struct noise_info *pinfo = pValue1;
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +3 -18
@@ -313,14 +313,11 @@ static char *translate_scan(struct adapter *padapter,/* Add quality statistics */ iwe.cmd =IWEVQUAL ; iwe.u.qual.updated = IW_QUAL_QUAL_UPDATED | IW_QUAL_LEVEL_UPDATED - #if defined(CONFIG_SIGNAL_DISPLAY_DBM) && defined(CONFIG_BACKGROUND_NOISE_MONITOR) + #ifdef CONFIG_BACKGROUND_NOISE_MONITOR |IW_QUAL_NOISE_UPDATED #else |IW_QUAL_NOISE_INVALID #endif -#ifdef CONFIG_SIGNAL_DISPLAY_DBM - | IW_QUAL_DBM -#endif ; if (check_fwstate(pmlmepriv, _FW_LINKED) == true &&
@@ -333,9 +330,6 @@ static char *translate_scan(struct adapter *padapter, } - #ifdef CONFIG_SIGNAL_DISPLAY_DBM - iwe.u.qual.level = (u8)translate_percentage_to_dbm(ss);/* dbm */ - #else#ifdef CONFIG_SKIP_SIGNAL_SCALE_MAPPING {/* Do signal scale mapping when using percentage as the unit of signal strength, since the scale mapping is skipped in odm */
@@ -347,11 +341,10 @@ static char *translate_scan(struct adapter *padapter,#else iwe.u.qual.level = (u8 )ss;/* */ #endif -#endif iwe.u.qual.qual = (u8 )sq;/* signal quality */ -#if defined(CONFIG_SIGNAL_DISPLAY_DBM ) && defined(CONFIG_BACKGROUND_NOISE_MONITOR ) +#ifdef CONFIG_BACKGROUND_NOISE_MONITOR {s16 tmp_noise =0 ;rtw_hal_get_odm_var (padapter,HAL_ODM_NOISE_MONITOR , &(pnetwork->network.Configuration.DSConfig), &(tmp_noise));
@@ -4728,9 +4721,6 @@ static struct iw_statistics *rtw_get_wireless_stats(struct net_device *dev) piwstats->qual.noise =0 ;/* DBG_871X("No link level:%d, qual:%d, noise:%d\n", tmp_level, tmp_qual, tmp_noise); */ }else { - #ifdef CONFIG_SIGNAL_DISPLAY_DBM - tmp_level = translate_percentage_to_dbm(padapter->recvpriv.signal_strength); - #else#ifdef CONFIG_SKIP_SIGNAL_SCALE_MAPPING {/* Do signal scale mapping when using percentage as the unit of signal strength, since the scale mapping is skipped in odm */
@@ -4742,10 +4732,9 @@ static struct iw_statistics *rtw_get_wireless_stats(struct net_device *dev)#else tmp_level = padapter->recvpriv.signal_strength;#endif -#endif tmp_qual = padapter->recvpriv.signal_qual; -#if defined(CONFIG_SIGNAL_DISPLAY_DBM ) && defined(CONFIG_BACKGROUND_NOISE_MONITOR ) +#ifdef CONFIG_BACKGROUND_NOISE_MONITOR if (rtw_linked_check (padapter)) {struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;struct noise_info info;
@@ -4772,10 +4761,6 @@ static struct iw_statistics *rtw_get_wireless_stats(struct net_device *dev) } piwstats->qual.updated =IW_QUAL_ALL_UPDATED ;/* IW_QUAL_DBM; */ -#ifdef CONFIG_SIGNAL_DISPLAY_DBM - piwstats->qual.updated = piwstats->qual.updated |IW_QUAL_DBM ; -#endif -return &padapter->iwstats; }
Signature · 1 line
2.20.1
PATCH 7/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_BACKGROUND_NOISE_MONITOR
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_BACKGROUND_NOISE_MONITOR
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 12 ----- drivers/staging/rtl8723bs/hal/hal_com.c | 35 ------------- drivers/staging/rtl8723bs/include/hal_com.h | 10 ---- drivers/staging/rtl8723bs/include/hal_data.h | 5 -- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 50 +------------------ 5 files changed, 1 insertion(+), 111 deletions(-)
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c +0 -12
@@ -4211,18 +4211,6 @@ void site_survey(struct adapter *padapter) channel_scan_time_ms = pmlmeext->chan_scan_time;set_survey_timer (pmlmeext, channel_scan_time_ms); -#ifdef CONFIG_BACKGROUND_NOISE_MONITOR - { -struct noise_info info; - - info.bPauseDIG = false; - info.IGIValue =0 ; - info.max_time = channel_scan_time_ms/2 ;/* ms */ - info.chan = survey_channel; -rtw_hal_set_odm_var (padapter,HAL_ODM_NOISE_MONITOR , &info, false); - } -#endif - }else {/* channel number is 0 or this channel is not valid. */
drivers/staging/rtl8723bs/hal/hal_com.c +0 -35
@@ -1262,20 +1262,6 @@ void GetHalODMVar( ) {switch (eVariable) { -#ifdef CONFIG_BACKGROUND_NOISE_MONITOR -case HAL_ODM_NOISE_MONITOR : - { -struct hal_com_data *pHalData =GET_HAL_DATA (Adapter); -u8 chan = *(u8 *)pValue1; - *(s16 *)pValue2 = pHalData->noise[chan]; -#ifdef DBG_NOISE_MONITOR -DBG_8192C ("### Noise monitor chan(%d)-noise:%d (dBm) ###\n" , - chan, pHalData->noise[chan]); -#endif - - } -break ; -#endif /* ifdef CONFIG_BACKGROUND_NOISE_MONITOR */ default :break ; }
@@ -1313,27 +1299,6 @@ void SetHalODMVar(case HAL_ODM_WIFI_DISPLAY_STATE :ODM_CmnInfoUpdate (podmpriv,ODM_CMNINFO_WIFI_DISPLAY , bSet);break ; -#ifdef CONFIG_BACKGROUND_NOISE_MONITOR -case HAL_ODM_NOISE_MONITOR : - { -struct noise_info *pinfo = pValue1; - -#ifdef DBG_NOISE_MONITOR -DBG_8192C ("### Noise monitor chan(%d)-bPauseDIG:%d, IGIValue:0x%02x, max_time:%d (ms) ###\n" , - pinfo->chan, pinfo->bPauseDIG, pinfo->IGIValue, pinfo->max_time); -#endif - - pHalData->noise[pinfo->chan] =ODM_InbandNoise_Monitor (podmpriv, pinfo->bPauseDIG, pinfo->IGIValue, pinfo->max_time); -DBG_871X ("chan_%d, noise = %d (dBm)\n" , pinfo->chan, pHalData->noise[pinfo->chan]); -#ifdef DBG_NOISE_MONITOR -DBG_871X ("noise_a = %d, noise_b = %d noise_all:%d\n" , - podmpriv->noise_level.noise[ODM_RF_PATH_A ], - podmpriv->noise_level.noise[ODM_RF_PATH_B ], - podmpriv->noise_level.noise_all); -#endif - } -break ; -#endif /* ifdef CONFIG_BACKGROUND_NOISE_MONITOR */ default :break ;
drivers/staging/rtl8723bs/include/hal_com.h +0 -10
@@ -286,14 +286,4 @@ void SetHalODMVar(enum HAL_ODM_VARIABLE eVariable, void * pValue1, bool bSet); - -#ifdef CONFIG_BACKGROUND_NOISE_MONITOR -struct noise_info { -u8 bPauseDIG; -u8 IGIValue; -u32 max_time;/* ms */ -u8 chan; -}; -#endif -#endif /* __HAL_COMMON_H__ */
drivers/staging/rtl8723bs/include/hal_data.h +0 -5
@@ -439,11 +439,6 @@ struct hal_com_data {/* Interrupt related register information. */ u32 SysIntrStatus;u32 SysIntrMask; - -#ifdef CONFIG_BACKGROUND_NOISE_MONITOR -s16 noise[ODM_MAX_CHANNEL_NUM ]; -#endif - };#define GET_HAL_DATA (__padapter) ((struct hal_com_data *)((__padapter)->HalData))
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +1 -49
75 lines not on this page · raw message
Signature · 1 line
2.20.1
PATCH 8/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SKIP_SIGNAL_SCALE_MAPPING
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_SKIP_SIGNAL_SCALE_MAPPING
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 9 -------- drivers/staging/rtl8723bs/include/rtw_recv.h | 5 ----- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 21 ------------------- 3 files changed, 35 deletions(-)
drivers/staging/rtl8723bs/hal/odm_HWConfig.c +0 -9
@@ -226,19 +226,10 @@ static void odm_RxPhyStatus92CSeries_Parsing(/* UI BSS List signal strength(in percentage), make it good looking, from 0~100. */ /* It is assigned to the BSS List in GetValueFromBeaconOrProbeRsp(). */ if (isCCKrate) { -#ifdef CONFIG_SKIP_SIGNAL_SCALE_MAPPING - pPhyInfo->SignalStrength = (u8 )PWDB_ALL ; -#else pPhyInfo->signal_strength = (u8)(odm_SignalScaleMapping (pDM_Odm,PWDB_ALL ));/* PWDB_ALL; */ -#endif }else {if (rf_rx_num !=0 ) { -#ifdef CONFIG_SKIP_SIGNAL_SCALE_MAPPING - total_rssi /= rf_rx_num; - pPhyInfo->signal_strength = (u8 )total_rssi; -#else pPhyInfo->signal_strength = (u8)(odm_SignalScaleMapping (pDM_Odm, total_rssi /= rf_rx_num)); -#endif } }
drivers/staging/rtl8723bs/include/rtw_recv.h +0 -5
@@ -512,14 +512,9 @@ static inline s32 translate_percentage_to_dbm(u32 SignalStrengthIndex) {s32 SignalPower;/* in dBm. */ -#ifdef CONFIG_SKIP_SIGNAL_SCALE_MAPPING -/* Translate to dBm (x =y-100) */ - SignalPower = SignalStrengthIndex -100 ; -#else /* Translate to dBm (x = 0.5y-95). */ SignalPower = (s32)((SignalStrengthIndex +1 ) >>1 ); SignalPower -=95 ; -#endif return SignalPower; }
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +0 -21
@@ -325,17 +325,7 @@ static char *translate_scan(struct adapter *padapter, } -#ifdef CONFIG_SKIP_SIGNAL_SCALE_MAPPING - { -/* Do signal scale mapping when using percentage as the unit of signal strength, since the scale mapping is skipped in odm */ - -struct hal_com_data *pHal =GET_HAL_DATA (padapter); - - iwe.u.qual.level = (u8 )odm_SignalScaleMapping (&pHal->odmpriv, ss); - } -#else iwe.u.qual.level = (u8 )ss;/* */ -#endif iwe.u.qual.qual = (u8 )sq;/* signal quality */
@@ -4691,18 +4681,7 @@ static struct iw_statistics *rtw_get_wireless_stats(struct net_device *dev) piwstats->qual.noise =0 ;/* DBG_871X("No link level:%d, qual:%d, noise:%d\n", tmp_level, tmp_qual, tmp_noise); */ }else { -#ifdef CONFIG_SKIP_SIGNAL_SCALE_MAPPING - { -/* Do signal scale mapping when using percentage as the unit of signal strength, since the scale mapping is skipped in odm */ - -struct hal_com_data *pHal =GET_HAL_DATA (padapter); - - tmp_level = (u8 )odm_SignalScaleMapping (&pHal->odmpriv, padapter->recvpriv.signal_strength); - } -#else tmp_level = padapter->recvpriv.signal_strength; -#endif - tmp_qual = padapter->recvpriv.signal_qual; tmp_noise = padapter->recvpriv.noise;DBG_871X ("level:%d, qual:%d, noise:%d, rssi (%d)\n" , tmp_level, tmp_qual, tmp_noise, padapter->recvpriv.rssi);
Signature · 1 line
2.20.1
PATCH 9/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_GPIO_API
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_GPIO_API
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- .../staging/rtl8723bs/core/rtw_wlan_util.c | 95 ------------------- drivers/staging/rtl8723bs/include/drv_types.h | 6 -- .../staging/rtl8723bs/os_dep/ioctl_linux.c | 40 -------- 3 files changed, 141 deletions(-)
drivers/staging/rtl8723bs/core/rtw_wlan_util.c +0 -95
@@ -2014,98 +2014,3 @@ struct adapter *dvobj_get_port0_adapter(struct dvobj_priv *dvobj)return dvobj->padapters; } - -#ifdef CONFIG_GPIO_API -int rtw_get_gpio (struct net_device *netdev,int gpio_num) -{ -u8 value; -u8 direction; -struct adapter *adapter =rtw_netdev_priv (netdev); -struct pwrctrl_priv *pwrpriv =adapter_to_pwrctl (adapter); - -rtw_ps_deny (adapter,PS_DENY_IOCTL ); - -DBG_871X ("rf_pwrstate = 0x%02x\n" , pwrpriv->rf_pwrstate); -LeaveAllPowerSaveModeDirect (adapter); - -/* Read GPIO Direction */ - direction = (rtw_read8 (adapter,REG_GPIO_PIN_CTRL +2 ) &BIT (gpio_num)) >> gpio_num; - -/* According the direction to read register value */ -if (direction) - value = (rtw_read8 (adapter,REG_GPIO_PIN_CTRL +1 ) &BIT (gpio_num)) >> gpio_num; -else - value = (rtw_read8 (adapter,REG_GPIO_PIN_CTRL ) &BIT (gpio_num)) >> gpio_num; - -rtw_ps_deny_cancel (adapter,PS_DENY_IOCTL ); -DBG_871X ("%s direction =%d value =%d\n" , __func__, direction, value); - -return value; -} -EXPORT_SYMBOL (rtw_get_gpio); - -int rtw_set_gpio_output_value (struct net_device *netdev,int gpio_num,bool isHigh) -{ -u8 direction =0 ; -u8 res =-1 ; -struct adapter *adapter =rtw_netdev_priv (netdev); - -/* Check GPIO is 4~7 */ -if (gpio_num >7 || gpio_num <4 ) { -DBG_871X ("%s The gpio number does not included 4~7.\n" , __func__); -return -1 ; - } - -rtw_ps_deny (adapter,PS_DENY_IOCTL ); - -LeaveAllPowerSaveModeDirect (adapter); - -/* Read GPIO direction */ - direction = (rtw_read8 (adapter,REG_GPIO_PIN_CTRL +2 ) &BIT (gpio_num)) >> gpio_num; - -/* If GPIO is output direction, setting value. */ -if (direction) { -if (isHigh) -rtw_write8 (adapter,REG_GPIO_PIN_CTRL +1 ,rtw_read8 (adapter,REG_GPIO_PIN_CTRL +1 ) |BIT (gpio_num)); -else -rtw_write8 (adapter,REG_GPIO_PIN_CTRL +1 ,rtw_read8 (adapter,REG_GPIO_PIN_CTRL +1 ) & ~BIT (gpio_num)); - -DBG_871X ("%s Set gpio %x[%d]=%d\n" , __func__,REG_GPIO_PIN_CTRL +1 , gpio_num, isHigh); - res =0 ; - }else { -DBG_871X ("%s The gpio is input, not be set!\n" , __func__); - res =-1 ; - } - -rtw_ps_deny_cancel (adapter,PS_DENY_IOCTL ); -return res; -} -EXPORT_SYMBOL (rtw_set_gpio_output_value); - -int rtw_config_gpio (struct net_device *netdev,int gpio_num,bool isOutput) -{ -struct adapter *adapter =rtw_netdev_priv (netdev); - -if (gpio_num >7 || gpio_num <4 ) { -DBG_871X ("%s The gpio number does not included 4~7.\n" , __func__); -return -1 ; - } - -DBG_871X ("%s gpio_num =%d direction =%d\n" , __func__, gpio_num, isOutput); - -rtw_ps_deny (adapter,PS_DENY_IOCTL ); - -LeaveAllPowerSaveModeDirect (adapter); - -if (isOutput) -rtw_write8 (adapter,REG_GPIO_PIN_CTRL +2 ,rtw_read8 (adapter,REG_GPIO_PIN_CTRL +2 ) |BIT (gpio_num)); -else -rtw_write8 (adapter,REG_GPIO_PIN_CTRL +2 ,rtw_read8 (adapter,REG_GPIO_PIN_CTRL +2 ) & ~BIT (gpio_num)); - -rtw_ps_deny_cancel (adapter,PS_DENY_IOCTL ); - -return 0 ; -} -EXPORT_SYMBOL (rtw_config_gpio); -#endif -
drivers/staging/rtl8723bs/include/drv_types.h +0 -6
@@ -528,12 +528,6 @@ static inline void RTW_ENABLE_FUNC(struct adapter *padapter, int func_bit) (padapter)->bSurpriseRemoved || \ RTW_IS_FUNC_DISABLED((padapter), DF_TX_BIT)) -#ifdef CONFIG_GPIO_API -int rtw_get_gpio (struct net_device *netdev,int gpio_num); -int rtw_set_gpio_output_value (struct net_device *netdev,int gpio_num,bool isHigh); -int rtw_config_gpio (struct net_device *netdev,int gpio_num,bool isOutput); -#endif -static inline u8 *myid (struct eeprom_priv *peepriv) {return peepriv->mac_addr;
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c +0 -40
@@ -3063,46 +3063,6 @@ static int rtw_dbg_port(struct net_device *dev, {break ; } -#ifdef CONFIG_GPIO_API -case 0x25 :/* Get GPIO register */ - { -/* -* dbg 0x7f250000 [gpio_num], Get gpio value, gpio_num:0~7 -*/ - -int value; -DBG_871X ("Read GPIO Value extra_arg = %d\n" , extra_arg); - value =rtw_get_gpio (dev, extra_arg); -DBG_871X ("Read GPIO Value = %d\n" , value); -break ; - } -case 0x26 :/* Set GPIO direction */ - { - -/* dbg 0x7f26000x [y], Set gpio direction, -* x: gpio_num, 4~7 y: indicate direction, 0~1 -*/ - -int value; -DBG_871X ("Set GPIO Direction! arg = %d , extra_arg =%d\n" , arg, extra_arg); - value =rtw_config_gpio (dev, arg, extra_arg); -DBG_871X ("Set GPIO Direction %s\n" , (value ==-1 ) ?"Fail!!!" :"Success" ); -break ; - } -case 0x27 :/* Set GPIO output direction value */ - { -/* -* dbg 0x7f27000x [y], Set gpio output direction value, -* x: gpio_num, 4~7 y: indicate direction, 0~1 -*/ - -int value; -DBG_871X ("Set GPIO Value! arg = %d , extra_arg =%d\n" , arg, extra_arg); - value =rtw_set_gpio_output_value (dev, arg, extra_arg); -DBG_871X ("Set GPIO Value %s\n" , (value ==-1 ) ?"Fail!!!" :"Success" ); -break ; - } -#endif case 0xaa : {if ((extra_arg &0x7F ) >0x3F )
Signature · 1 line
2.20.1
PATCH 10/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_EXT_CLK
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_EXT_CLK
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 14 -------------- 1 file changed, 14 deletions(-)
drivers/staging/rtl8723bs/hal/sdio_halinit.c +0 -14
@@ -53,20 +53,6 @@ u8 _InitPowerOn_8723BS(struct adapter *padapter)/* all of these MUST be configured before power on */ -#ifdef CONFIG_EXT_CLK -/* Use external crystal(XTAL) */ - value8 =rtw_read8 (padapter,REG_PAD_CTRL1_8723B +2 ); - value8 |=BIT (7 ); -rtw_write8 (padapter,REG_PAD_CTRL1_8723B +2 , value8); - -/* CLK_REQ High active or Low Active */ -/* Request GPIO polarity: */ -/* 0: low active */ -/* 1: high active */ - value8 =rtw_read8 (padapter,REG_MULTI_FUNC_CTRL +1 ); - value8 |=BIT (5 ); -rtw_write8 (padapter,REG_MULTI_FUNC_CTRL +1 , value8); -#endif /* CONFIG_EXT_CLK */ /* only cmd52 can be used before power on(card enable) */ ret =CardEnable (padapter);
Signature · 1 line
2.20.1
PATCH 11/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_CHECK_BT_HANG
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_CHECK_BT_HANG
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- .../staging/rtl8723bs/hal/rtl8723b_hal_init.c | 31 ------------------- drivers/staging/rtl8723bs/hal/sdio_halinit.c | 7 ----- .../staging/rtl8723bs/include/rtl8723b_hal.h | 7 ----- 3 files changed, 45 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0 -31
@@ -4421,34 +4421,3 @@ void rtl8723b_stop_thread(struct adapter *padapter) }#endif } - -#if defined(CONFIG_CHECK_BT_HANG ) -extern void check_bt_status_work (void *data); -void rtl8723bs_init_checkbthang_workqueue (struct adapter *adapter) -{ - adapter->priv_checkbt_wq =alloc_workqueue ("sdio_wq" ,0 ,0 ); -INIT_DELAYED_WORK (&adapter->checkbt_work, (void *)check_bt_status_work); -} - -void rtl8723bs_free_checkbthang_workqueue (struct adapter *adapter) -{ -if (adapter->priv_checkbt_wq) { -cancel_delayed_work_sync (&adapter->checkbt_work); -flush_workqueue (adapter->priv_checkbt_wq); -destroy_workqueue (adapter->priv_checkbt_wq); - adapter->priv_checkbt_wq =NULL ; - } -} - -void rtl8723bs_cancle_checkbthang_workqueue (struct adapter *adapter) -{ -if (adapter->priv_checkbt_wq) -cancel_delayed_work_sync (&adapter->checkbt_work); -} - -void rtl8723bs_hal_check_bt_hang (struct adapter *adapter) -{ -if (adapter->priv_checkbt_wq) -queue_delayed_work (adapter->priv_checkbt_wq, &(adapter->checkbt_work),0 ); -} -#endif
drivers/staging/rtl8723bs/hal/sdio_halinit.c +0 -7
@@ -1420,11 +1420,4 @@ void rtl8723bs_set_hal_ops(struct adapter *padapter) pHalFunc->hal_xmit = &rtl8723bs_hal_xmit; pHalFunc->mgnt_xmit = &rtl8723bs_mgnt_xmit; pHalFunc->hal_xmitframe_enqueue = &rtl8723bs_hal_xmitframe_enqueue; - -#if defined(CONFIG_CHECK_BT_HANG ) - pHalFunc->hal_init_checkbthang_workqueue = &rtl8723bs_init_checkbthang_workqueue; - pHalFunc->hal_free_checkbthang_workqueue = &rtl8723bs_free_checkbthang_workqueue; - pHalFunc->hal_cancle_checkbthang_workqueue = &rtl8723bs_cancle_checkbthang_workqueue; - pHalFunc->hal_checke_bt_hang = &rtl8723bs_hal_check_bt_hang; -#endif }
drivers/staging/rtl8723bs/include/rtl8723b_hal.h +0 -7
@@ -240,13 +240,6 @@ void _8051Reset8723(struct adapter *padapter);void rtl8723b_start_thread (struct adapter *padapter);void rtl8723b_stop_thread (struct adapter *padapter); -#if defined(CONFIG_CHECK_BT_HANG ) -void rtl8723bs_init_checkbthang_workqueue (struct adapter *adapter); -void rtl8723bs_free_checkbthang_workqueue (struct adapter *adapter); -void rtl8723bs_cancle_checkbthang_workqueue (struct adapter *adapter); -void rtl8723bs_hal_check_bt_hang (struct adapter *adapter); -#endif -int FirmwareDownloadBT (struct adapter *adapter,struct rt_firmware *firmware);void CCX_FwC2HTxRpt_8723b (struct adapter *padapter,u8 *pdata,u8 len);
Signature · 1 line
2.20.1
PATCH 12/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SDIO_TX_TASKLET
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_SDIO_TX_TASKLET
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 4 ---- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 8 -------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 4 ---- 3 files changed, 16 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +0 -4
@@ -4398,19 +4398,16 @@ u8 GetHalDefVar8723B(struct adapter *padapter, enum HAL_DEF_VARIABLE variable, vvoid rtl8723b_start_thread (struct adapter *padapter) { -#ifndef CONFIG_SDIO_TX_TASKLET struct xmit_priv *xmitpriv = &padapter->xmitpriv; xmitpriv->SdioXmitThread =kthread_run (rtl8723bs_xmit_thread, padapter,"RTWHALXT" );if (IS_ERR (xmitpriv->SdioXmitThread)) {RT_TRACE (_module_hal_xmit_c_, _drv_err_, ("%s: start rtl8723bs_xmit_thread FAIL!!\n" , __func__)); } -#endif }void rtl8723b_stop_thread (struct adapter *padapter) { -#ifndef CONFIG_SDIO_TX_TASKLET struct xmit_priv *xmitpriv = &padapter->xmitpriv;/* stop xmit_buf_thread */
@@ -4419,5 +4416,4 @@ void rtl8723b_stop_thread(struct adapter *padapter)wait_for_completion (&xmitpriv->SdioXmitTerminate); xmitpriv->SdioXmitThread =NULL ; } -#endif }
drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c +0 -8
@@ -124,10 +124,6 @@ static s32 rtl8723_dequeue_writeport(struct adapter *padapter)/* pxmitbuf->priv_data = NULL; */ rtw_free_xmitbuf (pxmitpriv, pxmitbuf); -#ifdef CONFIG_SDIO_TX_TASKLET -tasklet_hi_schedule (&pxmitpriv->xmit_tasklet); -#endif -return _FAIL; }
@@ -601,11 +597,7 @@ s32 rtl8723bs_hal_xmitframe_enqueue( pxmitpriv->tx_drop++; }else { -#ifdef CONFIG_SDIO_TX_TASKLET -tasklet_hi_schedule (&pxmitpriv->xmit_tasklet); -#else complete (&pxmitpriv->SdioXmitStart); -#endif }return err;
drivers/staging/rtl8723bs/include/rtw_xmit.h +0 -4
@@ -412,13 +412,9 @@ struct xmit_priv {u8 wmm_para_seq[4 ];/* sequence for wmm ac parameter strength from large to small. it's value is 0->vo, 1->vi, 2->be, 3->bk. */ -#ifdef CONFIG_SDIO_TX_TASKLET -struct tasklet_struct xmit_tasklet; -#else void *SdioXmitThread;struct completion SdioXmitStart;struct completion SdioXmitTerminate; -#endif /* CONFIG_SDIO_TX_TASKLET */ struct __queue free_xmitbuf_queue;struct __queue pending_xmitbuf_queue;
Signature · 1 line
2.20.1
PATCH 13/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_SW_CHANNEL_PLAN
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_SW_CHANNEL_PLAN
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/hal/hal_com.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/rtl8723bs/hal/hal_com.c +0 -2
@@ -132,10 +132,8 @@ u8 hal_com_config_channel_plan( hw_chnlPlan = hw_channel_plan & (~EEPROM_CHANNEL_PLAN_BY_HW_MASK );if (rtw_is_channel_plan_valid (hw_chnlPlan)) { -#ifndef CONFIG_SW_CHANNEL_PLAN if (hw_channel_plan &EEPROM_CHANNEL_PLAN_BY_HW_MASK ) pHalData->bDisableSWChannelPlan = true; -#endif /* !CONFIG_SW_CHANNEL_PLAN */ chnlPlan = hw_chnlPlan; }
Signature · 1 line
2.20.1
PATCH 14/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_C2H_PACKET_EN
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_C2H_PACKET_EN
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/rtl8723bs/hal/sdio_ops.c +0 -2
@@ -974,7 +974,6 @@ void sd_int_dpc(struct adapter *adapter)if (hal->sdio_hisr &SDIO_HISR_TXBCNERR )DBG_8192C ("%s: SDIO_HISR_TXBCNERR\n" , __func__); -#ifndef CONFIG_C2H_PACKET_EN if (hal->sdio_hisr &SDIO_HISR_C2HCMD ) {struct c2h_evt_hdr_88xx *c2h_evt;
@@ -997,7 +996,6 @@ void sd_int_dpc(struct adapter *adapter)_set_workitem (&adapter->evtpriv.c2h_wk); } } -#endif if (hal->sdio_hisr &SDIO_HISR_RXFOVW )DBG_8192C ("%s: Rx Overflow\n" , __func__);
Signature · 1 line
2.20.1
PATCH 15/15 staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_ODM_ADAPTIVITY
In reply to Fabio Aiutoremove conditional code blocks checked by unusedCONFIG_ODM_ADAPTIVITY
cleaning required in TODO file:
find and remove code blocks guarded by never set CONFIG_FOO defines
--- drivers/staging/rtl8723bs/hal/rtl8723b_dm.c | 3 --- 1 file changed, 3 deletions(-)
drivers/staging/rtl8723bs/hal/rtl8723b_dm.c +0 -3
@@ -91,9 +91,6 @@ static void Update_ODM_ComInfo_8723b(struct adapter *Adapter) | ODM_MAC_EDCA_TURBO |ODM_RF_TX_PWR_TRACK |ODM_RF_CALIBRATION -#ifdef CONFIG_ODM_ADAPTIVITY - |ODM_BB_ADAPTIVITY -#endif ;/* */
Signature · 1 line
2.20.1
Greg KH
maintainerRe: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM
In reply to Fabio AiutoQuoted 16 lines · Fabio Aiuto
remove conditional code blocks checked by unused
CONFIG_PMcleaning required in TODO file:
find and remove code blocks guarded by never set
CONFIG_FOOdefinesSigned-off-by Fabio Aiuto <[email protected]>--- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 -------- 1 file changed, 8 deletions(-)drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0
-0
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wiphy *w · line 3207
Quoted 10 lines
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0
-7@@ -3198,14 +3198,6 @@ static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wiphy *w wiphy->flags |=WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL ; wiphy->flags |=WIPHY_FLAG_OFFCHAN_TX |WIPHY_FLAG_HAVE_AP_SME ; -#if defined(CONFIG_PM ) - wiphy->max_sched_scan_reqs =1 ; -#endif - -#if defined(CONFIG_PM ) - wiphy->wowlan = &wowlan_stub; -#endif
How this is "unused"? This is a real config option, did you just change the logic here?
thanks,
greg k-h
Greg KH
maintainerQuoted 25 lines · Fabio Aiuto
Remove unused code blocks as required in TODO file
Fabio Aiuto (15):
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_AUTO_AP_MODE
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_HW_PWRP_DETECTION
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_QOS_OPTIMIZATION
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_AP_WOWLAN
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_PM
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SIGNAL_DISPLAY_DBM
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_BACKGROUND_NOISE_MONITOR
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SKIP_SIGNAL_SCALE_MAPPING
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_GPIO_API
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_EXT_CLK
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_CHECK_BT_HANG
Quoted 8 lines
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SDIO_TX_TASKLET
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_SW_CHANNEL_PLAN
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_C2H_PACKET_EN
staging: rtl8723bs: remove unused code blocks conditioned by never set
CONFIG_ODM_ADAPTIVITY
Not all of these would apply, please rebase and resend the remaining ones.
thanks,
greg k-h
Re: [PATCH 05/15] staging: rtl8723bs: remove unused code blocks conditioned by never set CONFIG_PM
In reply to Greg KHQuoted 31 lines · Greg KH
Quoted 16 lines · Fabio Aiuto
remove conditional code blocks checked by unused
CONFIG_PMcleaning required in TODO file:
find and remove code blocks guarded by never set
CONFIG_FOOdefinesSigned-off-by Fabio Aiuto <[email protected]>--- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 8 -------- 1 file changed, 8 deletions(-)drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0
-0drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wiphy *w · line 3207
Quoted 10 lines
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +0
-7@@ -3198,14 +3198,6 @@ static void rtw_cfg80211_preinit_wiphy(struct adapter *padapter, struct wiphy *w wiphy->flags |=WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL ; wiphy->flags |=WIPHY_FLAG_OFFCHAN_TX |WIPHY_FLAG_HAVE_AP_SME ; -#if defined(CONFIG_PM ) - wiphy->max_sched_scan_reqs =1 ; -#endif - -#if defined(CONFIG_PM ) - wiphy->wowlan = &wowlan_stub; -#endif How this is "unused"? This is a real config option, did you just change the logic here?
Quoted 3 lines
thanks,
greg k-h
Hi Greg,
ignore this patch. I missed that definition of PM config option. I dropped it off my own local repo.
Thank you,
fabio