Skip to contentSkip to conversation

audit: add documentation for /proc/PID/stable interfaces

PATCH Applied Richard Guy Briggs 3 participants 8 messages Mar 18, 2021 – Apr 1, 2021

lore
Share & tools
lore
#0 lore raw

v3 cover audit: add documentation for /proc/PID/stable interfaces

Add Documentation/ABI entries for audit interfaces in /proc/PID/ that have been stable for more than a decade.

Richard Guy Briggs (2):
audit: document /proc/PID/loginuid
audit: document /proc/PID/sessionid

 .../ABI/stable/procfs-audit_loginuid          | 27 +++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
Signature · 6 lines
2.27.0

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit
#1 lore raw

PATCH v3 1/2 audit: document /proc/PID/loginuid

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")

---
 Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
Documentation/ABI/stable/procfs-audit_loginuid new file +15 -0
new file mode 100644
index 000000000000..e7c100b9ab18
@@ -0,0 +1,15 @@
+What:		Audit Login UID
+Date:		2005-02-01
+KernelVersion:	2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
+Contact:	[email protected]
+Format:		%u
+Users:		audit and login applications
+Description:
+		The /proc/$pid/loginuid pseudofile is written to set and
+		read to get the audit login UID of process $pid.  If it is
+		unset, permissions are not needed to set it.  The accessor must
+		have CAP_AUDIT_CONTROL in the initial user namespace to write
+		it if it has been set.  It cannot be written again if
+		AUDIT_FEATURE_LOGINUID_IMMUTABLE is enabled.  It cannot be
+		unset if AUDIT_FEATURE_ONLY_UNSET_LOGINUID is enabled.
+
Signature · 6 lines
2.27.0

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit
#6 lore raw

PATCH v3 2/2 audit: document /proc/PID/sessionid

In reply to Richard Guy Briggs

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that was added 2008-03-13 in commit 1e0bd7550ea9 ("[PATCH] export sessionid alongside the loginuid in procfs")

---
 Documentation/ABI/stable/procfs-audit_loginuid | 12 ++++++++++++
 1 file changed, 12 insertions(+)
Documentation/ABI/stable/procfs-audit_loginuid +12 -0
index e7c100b9ab18..9d55a3ff4b34 100644
@@ -13,3 +13,15 @@ Description:
 		AUDIT_FEATURE_LOGINUID_IMMUTABLE is enabled.  It cannot be
 		unset if AUDIT_FEATURE_ONLY_UNSET_LOGINUID is enabled.
 
+
+What:		Audit Login Session ID
+Date:		2008-03-13
+KernelVersion:	2.6.25-rc7 1e0bd7550ea9 ("[PATCH] export sessionid alongside the loginuid in procfs")
+Contact:	[email protected]
+Format:		%u
+Users:		audit and login applications
+Description:
+		The /proc/$pid/sessionid pseudofile is read to get the
+		audit login session ID of process $pid.  It is set
+		automatically, serially assigned with each new login.
+
Signature · 6 lines
2.27.0

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit
Applied
#2 lore raw

Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

In reply to Richard Guy Briggs
Quoted 10 lines · Richard Guy Briggs

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")

---
 Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid

Merged into audit/next, thanks.

Signature · 7 lines
paul moore
www.paul-moore.com

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit
Applied
#7 lore raw

Re: [PATCH v3 2/2] audit: document /proc/PID/sessionid

In reply to Richard Guy Briggs
Quoted 9 lines · Richard Guy Briggs

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that was added 2008-03-13 in commit 1e0bd7550ea9 ("[PATCH] export sessionid alongside the loginuid in procfs")

---
 Documentation/ABI/stable/procfs-audit_loginuid | 12 ++++++++++++
 1 file changed, 12 insertions(+)

Merged into audit/next, thanks.

Signature · 7 lines
paul moore
www.paul-moore.com

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit
#4 lore raw

Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

In reply to Mauro Carvalho Chehab
Quoted 41 lines · Mauro Carvalho Chehab

Em Thu, 18 Mar 2021 15:19:10 -0400
Richard Guy Briggs <[email protected]> escreveu:

Quoted 16 lines

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")

---
 Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
Documentation/ABI/stable/procfs-audit_loginuid new file +0 -0
new file mode 100644
index 000000000000..e7c100b9ab18

Documentation/ABI/stable/procfs-audit_loginuid line 5

Quoted 5 lines
Documentation/ABI/stable/procfs-audit_loginuid new file +5 -0
@@ -0,0 +1,15 @@
+What:                Audit Login UID
+Date:                2005-02-01
+KernelVersion:       2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
+Contact:     [email protected]
+Format:              %u

The ABI definition doesn't include a "Format:" symbol. See:

Documentation/ABI/README

For the valid ones.

This change causes a warning at the ABI parser:

        $ ./scripts/get_abi.pl validate
        Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
                tag 'contact' is invalid. Line
                        Format:         %u
        Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
                tag 'contact' is invalid. Line
                        Format:         %u
Quoted 2 lines

You should either drop it or add it to the parser and to the README file, if the ABI maintainers are ok with such new field.

Thanks Mauro, I didn't realize there were tools that parsed these files.

Richard, please post a patch that drops the 'Format:' line from the newly added audit files as soon as possible so I can merge it into audit/next.

Signature · 7 lines
paul moore
www.paul-moore.com

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit
#3 lore raw

Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

In reply to Richard Guy Briggs

Em Thu, 18 Mar 2021 15:19:10 -0400
Richard Guy Briggs <[email protected]> escreveu:

Quoted 16 lines

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")

---
 Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
Documentation/ABI/stable/procfs-audit_loginuid new file +0 -0
new file mode 100644
index 000000000000..e7c100b9ab18

Documentation/ABI/stable/procfs-audit_loginuid line 5

Quoted 5 lines
Documentation/ABI/stable/procfs-audit_loginuid new file +5 -0
@@ -0,0 +1,15 @@
+What:		Audit Login UID
+Date:		2005-02-01
+KernelVersion:	2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
+Contact:	[email protected]
+Format:		%u

The ABI definition doesn't include a "Format:" symbol. See:

Documentation/ABI/README

For the valid ones.

This change causes a warning at the ABI parser:

	$ ./scripts/get_abi.pl validate
	Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
		tag 'contact' is invalid. Line
			Format:		%u
	Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
		tag 'contact' is invalid. Line
			Format:		%u

You should either drop it or add it to the parser and to the README file, if the ABI maintainers are ok with such new field.

Thanks,
Mauro

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit

#5 lore raw

Re: [PATCH v3 1/2] audit: document /proc/PID/loginuid

In reply to Paul Moore
Quoted 43 lines · Paul Moore
Quoted 41 lines · Mauro Carvalho Chehab

Em Thu, 18 Mar 2021 15:19:10 -0400
Richard Guy Briggs <[email protected]> escreveu:

Quoted 16 lines

Describe the /proc/PID/loginuid interface in Documentation/ABI/stable that was added 2005-02-01 by commit 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")

---
 Documentation/ABI/stable/procfs-audit_loginuid | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 Documentation/ABI/stable/procfs-audit_loginuid
Documentation/ABI/stable/procfs-audit_loginuid new file +0 -0
new file mode 100644
index 000000000000..e7c100b9ab18

Documentation/ABI/stable/procfs-audit_loginuid line 5

Quoted 5 lines
Documentation/ABI/stable/procfs-audit_loginuid new file +5 -0
@@ -0,0 +1,15 @@
+What:                Audit Login UID
+Date:                2005-02-01
+KernelVersion:       2.6.11-rc2 1e2d1492e178 ("[PATCH] audit: handle loginuid through proc")
+Contact:     [email protected]
+Format:              %u

The ABI definition doesn't include a "Format:" symbol. See:

Documentation/ABI/README

For the valid ones.

This change causes a warning at the ABI parser:

        $ ./scripts/get_abi.pl validate
        Warning: file Documentation/ABI/stable/procfs-audit_loginuid#5:
                tag 'contact' is invalid. Line
                        Format:         %u
        Warning: file Documentation/ABI/stable/procfs-audit_loginuid#21:
                tag 'contact' is invalid. Line
                        Format:         %u
Quoted 8 lines
Quoted 2 lines

You should either drop it or add it to the parser and to the README file, if the ABI maintainers are ok with such new field.

Thanks Mauro, I didn't realize there were tools that parsed these files.

Richard, please post a patch that drops the 'Format:' line from the newly added audit files as soon as possible so I can merge it into audit/next.

Ok. I'll roll it into the description so we don't lose that information.

Quoted 1 line

paul moore

- RGB

--
Richard Guy Briggs <[email protected]>
Sr. S/W Engineer, Kernel Security, Base Operating Systems Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635

--
Linux-audit mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/linux-audit