Skip to contentSkip to conversation

staging: media: omap4iss: Patchsets cleans up in iss.c

PATCH In review Beatriz Martins de Carvalho 5 participants 11 messages Apr 1, 2021 – Apr 7, 2021

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover staging: media: omap4iss: Patchsets cleans up in iss.c

Clean up checks of "Alignment should match open parenthesis" and "CHECK: Lines should not end with a '('" in iss.c

Beatriz Martins de Carvalho (2):
staging: media: omap4iss: Ending line with argument
staging: media: omap4iss: align arguments with open parenthesis

 drivers/staging/media/omap4iss/iss.c | 48 +++++++++++++---------------
 1 file changed, 23 insertions(+), 25 deletions(-)
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/2 staging: media: omap4iss: Ending line with argument

Remove checkpatch check "CHECK: Lines should not end with a '('" with argument present in next line and reorganize characters so the lines are under 100 columns

---
 drivers/staging/media/omap4iss/iss.c | 46 +++++++++++++---------------
 1 file changed, 22 insertions(+), 24 deletions(-)
drivers/staging/media/omap4iss/iss.c +22 -24
index dae9073e7d3c..e8f724dbf810 100644
@@ -559,9 +559,10 @@ static int iss_reset(struct iss_device *iss)
 	iss_reg_set(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG,
 		    ISS_HL_SYSCONFIG_SOFTRESET);
 
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG) &
-		ISS_HL_SYSCONFIG_SOFTRESET), 1000, 10, 100);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss,
+							    OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG)
+							    & ISS_HL_SYSCONFIG_SOFTRESET),
+							    1000, 10, 100);
 	if (timeout) {
 		dev_err(iss->dev, "ISS reset timeout\n");
 		return -ETIMEDOUT;
@@ -583,9 +584,10 @@ static int iss_isp_reset(struct iss_device *iss)
 
 	iss_reg_set(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL, ISP5_CTRL_MSTANDBY);
 
-	timeout = iss_poll_condition_timeout(
-		iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL) &
-		ISP5_CTRL_MSTANDBY_WAIT, 1000000, 1000, 1500);
+	timeout = iss_poll_condition_timeout(iss_reg_read(iss,
+							  OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL)
+							  & ISP5_CTRL_MSTANDBY_WAIT, 1000000,
+							  1000, 1500);
 	if (timeout) {
 		dev_err(iss->dev, "ISP5 standby timeout\n");
 		return -ETIMEDOUT;
@@ -595,9 +597,10 @@ static int iss_isp_reset(struct iss_device *iss)
 	iss_reg_set(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_SYSCONFIG,
 		    ISP5_SYSCONFIG_SOFTRESET);
 
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_SYSCONFIG) &
-		ISP5_SYSCONFIG_SOFTRESET), 1000000, 1000, 1500);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1,
+							    ISP5_SYSCONFIG) &
+							    ISP5_SYSCONFIG_SOFTRESET), 1000000,
+							    1000, 1500);
 	if (timeout) {
 		dev_err(iss->dev, "ISP5 reset timeout\n");
 		return -ETIMEDOUT;
@@ -1104,33 +1107,28 @@ static int iss_create_links(struct iss_device *iss)
 	}
 
 	/* Connect the submodules. */
-	ret = media_create_pad_link(
-			&iss->csi2a.subdev.entity, CSI2_PAD_SOURCE,
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->csi2a.subdev.entity, CSI2_PAD_SOURCE,
+				    &iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->csi2b.subdev.entity, CSI2_PAD_SOURCE,
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->csi2b.subdev.entity, CSI2_PAD_SOURCE,
+				    &iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
-			&iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
+				    &iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
-			&iss->ipipe.subdev.entity, IPIPE_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
+				    &iss->ipipe.subdev.entity, IPIPE_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipe.subdev.entity, IPIPE_PAD_SOURCE_VP,
-			&iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipe.subdev.entity, IPIPE_PAD_SOURCE_VP,
+				    &iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
Signature · 1 line
2.25.1
#7 lore raw

PATCH 2/2 staging: media: omap4iss: align arguments with open parenthesis

In reply to Beatriz Martins de Carvalho

Cleans up checks of "Alignment should match open parenthesis" in iss.c:96.

---
 drivers/staging/media/omap4iss/iss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/omap4iss/iss.c +1 -1
index e8f724dbf810..472f1837632e 100644
@@ -963,7 +963,7 @@ iss_register_subdev_group(struct iss_device *iss,
 		}
 
 		subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
-				board_info->board_info, NULL);
+						   board_info->board_info, NULL);
 		if (!subdev) {
 			dev_err(iss->dev, "Unable to register subdev %s\n",
 				board_info->board_info->type);
Signature · 1 line
2.25.1
maintainer
#10 lore raw
In reply to Beatriz Martins de Carvalho
Quoted 8 lines · Beatriz Martins de Carvalho

Clean up checks of "Alignment should match open parenthesis" and "CHECK: Lines should not end with a '('" in iss.c

Beatriz Martins de Carvalho (2):
staging: media: omap4iss: Ending line with argument
staging: media: omap4iss: align arguments with open parenthesis

 drivers/staging/media/omap4iss/iss.c | 48 +++++++++++++---------------

Please read the outreachy introduction email again :(

thanks,

greg k-h

#2 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: media: omap4iss: Ending line with argument

In reply to Beatriz Martins de Carvalho
Quoted 5 lines · Beatriz Martins de Carvalho
drivers/staging/media/omap4iss/iss.c +0 -0
index dae9073e7d3c..e8f724dbf810 100644

drivers/staging/media/omap4iss/iss.c static int iss_reset(struct iss_device *iss) · line 565

Quoted 10 lines
drivers/staging/media/omap4iss/iss.c +4 -3
@@ -559,9 +559,10 @@ static int iss_reset(struct iss_device *iss)
 	iss_reg_set(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG,
 		    ISS_HL_SYSCONFIG_SOFTRESET);
 
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG) &
-		ISS_HL_SYSCONFIG_SOFTRESET), 1000, 10, 100);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss,
+							    OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG)
+							    & ISS_HL_SYSCONFIG_SOFTRESET),
+							    1000, 10, 100);

This is not a readability improvment. I would factor it out into its own function.

#8 lore raw

Re: [Outreachy kernel] [PATCH 2/2] staging: media: omap4iss: align arguments with open parenthesis

In reply to Beatriz Martins de Carvalho

drivers/staging/media/omap4iss/iss.c iss_register_subdev_group(struct iss_device *iss, · line 966

Quoted 3 lines · Beatriz Martins de Carvalho
drivers/staging/media/omap4iss/iss.c +1 -1
 		subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
-				board_info->board_info, NULL);
+						   board_info->board_info, NULL);

Also not a readability improvement. This checkpatch warning should be disregarded.

#3 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: media: omap4iss: Ending line with argument

In reply to Matthew Wilcox

Em 01/04/21 16:28, Matthew Wilcox escreveu:

Quoted 9 lines · Beatriz Martins de Carvalho
Quoted 8 lines
drivers/staging/media/omap4iss/iss.c +0 -0
index dae9073e7d3c..e8f724dbf810 100644
@@ -559,9 +559,10 @@ static int iss_reset(struct iss_device *iss)
  	iss_reg_set(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG,
  		    ISS_HL_SYSCONFIG_SOFTRESET);
 
Quoted 9 lines

drivers/staging/media/omap4iss/iss.c static int iss_reset(struct iss_device *iss) · line 565

Quoted 7 lines
drivers/staging/media/omap4iss/iss.c +4 -3
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG) &
-		ISS_HL_SYSCONFIG_SOFTRESET), 1000, 10, 100);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss,
+							    OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG)
+							    & ISS_HL_SYSCONFIG_SOFTRESET),
+							    1000, 10, 100);

This is not a readability improvment. I would factor it out into its own function.

Thanks for the review. How can I do this? I don't know how to do this. Beatriz Martins de Carvalho

#4 lore raw

Re: [Outreachy kernel] [PATCH 1/2] staging: media: omap4iss: Ending line with argument

Quoted 23 lines · Beatriz Martins de Carvalho

Em 01/04/21 16:28, Matthew Wilcox escreveu:

Quoted 12 lines · Beatriz Martins de Carvalho
Quoted 11 lines
drivers/staging/media/omap4iss/iss.c +0 -2
index dae9073e7d3c..e8f724dbf810 100644
@@ -559,9 +559,10 @@ static int iss_reset(struct iss_device *iss)
  	iss_reg_set(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG,
  		    ISS_HL_SYSCONFIG_SOFTRESET);
  -	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG) &
-		ISS_HL_SYSCONFIG_SOFTRESET), 1000, 10, 100);
Quoted 8 lines

drivers/staging/media/omap4iss/iss.c static int iss_reset(struct iss_device *iss) · line 567

Quoted 6 lines
drivers/staging/media/omap4iss/iss.c +4 -0
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss,
+							    OMAP4_ISS_MEM_TOP,
 ISS_HL_SYSCONFIG)
+							    &
 ISS_HL_SYSCONFIG_SOFTRESET),
+							    1000, 10, 100);

This is not a readability improvment. I would factor it out into its own function.

Quoted 1 line

Thanks for the review. How can I do this? I don't know how to do this.

Copy the code into a new function. Then see what parameters this function needs for the various information it requires. The code will produce some results that are needed by the rest of the program. So you have to arrange via the return value that the proper variables are initialized after the function call.

For example,

x = a + b;

could become

int f(int a, int b) {
return a + b;
}

x = f(a,b);

That is a pretty silly change, but it gives the idea.

julia

Quoted 10 lines

Beatriz Martins de Carvalho

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/e175859f-4f68-0408-415f-a3e19f7e4874%40gmail.com.

#5 lore raw

Re: [PATCH 1/2] staging: media: omap4iss: Ending line with argument

In reply to Beatriz Martins de Carvalho

Hi Beatriz,

I'm now reviewing staging/media patches instead of Greg KH. See Vaishali's email from today: "Sending patches for the drivers/staging/media".

Quoted 42 lines · Beatriz Martins de Carvalho

Remove checkpatch check "CHECK: Lines should not end with a '('" with argument present in next line and reorganize characters so the lines are under 100 columns

---
 drivers/staging/media/omap4iss/iss.c | 46 +++++++++++++---------------
 1 file changed, 22 insertions(+), 24 deletions(-)
drivers/staging/media/omap4iss/iss.c +8 -6
index dae9073e7d3c..e8f724dbf810 100644
@@ -559,9 +559,10 @@ static int iss_reset(struct iss_device *iss)
 	iss_reg_set(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG,
 		    ISS_HL_SYSCONFIG_SOFTRESET);
 
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG) &
-		ISS_HL_SYSCONFIG_SOFTRESET), 1000, 10, 100);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss,
+							    OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG)
+							    & ISS_HL_SYSCONFIG_SOFTRESET),
+							    1000, 10, 100);
 	if (timeout) {
 		dev_err(iss->dev, "ISS reset timeout\n");
 		return -ETIMEDOUT;
@@ -583,9 +584,10 @@ static int iss_isp_reset(struct iss_device *iss)
 
 	iss_reg_set(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL, ISP5_CTRL_MSTANDBY);
 
-	timeout = iss_poll_condition_timeout(
-		iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL) &
-		ISP5_CTRL_MSTANDBY_WAIT, 1000000, 1000, 1500);
+	timeout = iss_poll_condition_timeout(iss_reg_read(iss,
+							  OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL)
+							  & ISP5_CTRL_MSTANDBY_WAIT, 1000000,
+							  1000, 1500);
 	if (timeout) {
 		dev_err(iss->dev, "ISP5 standby timeout\n");
 		return -ETIMEDOUT;

drivers/staging/media/omap4iss/iss.c static int iss_isp_reset(struct iss_device *iss) · line 603

Quoted 10 lines
drivers/staging/media/omap4iss/iss.c +4 -3
@@ -595,9 +597,10 @@ static int iss_isp_reset(struct iss_device *iss)
 	iss_reg_set(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_SYSCONFIG,
 		    ISP5_SYSCONFIG_SOFTRESET);
 
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_SYSCONFIG) &
-		ISP5_SYSCONFIG_SOFTRESET), 1000000, 1000, 1500);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1,
+							    ISP5_SYSCONFIG) &
+							    ISP5_SYSCONFIG_SOFTRESET), 1000000,
+							    1000, 1500);

As several other people already commented, these changes do not improve readability. Just leave this code alone, it's good enough. Even splitting up the condition into a separate function would degrade readability since that would make it harder to discover the exact condition that will be polled for.

Not everything that checkpatch.pl flags is necessarily bad code :-)

Quoted 38 lines
drivers/staging/media/omap4iss/iss.c +8 -12
 	if (timeout) {
 		dev_err(iss->dev, "ISP5 reset timeout\n");
 		return -ETIMEDOUT;
@@ -1104,33 +1107,28 @@ static int iss_create_links(struct iss_device *iss)
 	}
 
 	/* Connect the submodules. */
-	ret = media_create_pad_link(
-			&iss->csi2a.subdev.entity, CSI2_PAD_SOURCE,
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->csi2a.subdev.entity, CSI2_PAD_SOURCE,
+				    &iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->csi2b.subdev.entity, CSI2_PAD_SOURCE,
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->csi2b.subdev.entity, CSI2_PAD_SOURCE,
+				    &iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
-			&iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
+				    &iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
-			&iss->ipipe.subdev.entity, IPIPE_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
+				    &iss->ipipe.subdev.entity, IPIPE_PAD_SINK, 0);
 	if (ret < 0)

drivers/staging/media/omap4iss/iss.c static int iss_create_links(struct iss_device *iss) · line 1134

Quoted 10 lines
drivers/staging/media/omap4iss/iss.c +2 -3
 		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipe.subdev.entity, IPIPE_PAD_SOURCE_VP,
-			&iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipe.subdev.entity, IPIPE_PAD_SOURCE_VP,
+				    &iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
 	if (ret < 0)
 		return ret;
 

These, however, are readability improvements, so I'm happy with that.

Regards,

Hans

#6 lore raw

Re: [PATCH 1/2] staging: media: omap4iss: Ending line with argument

Em 07/04/21 14:46, Hans Verkuil escreveu:

Quoted 1 line

Hi Beatriz,

Hi,

Quoted 3 lines

I'm now reviewing staging/media patches instead of Greg KH. See Vaishali's email from today: "Sending patches for the drivers/staging/media".

Yes, I saw the email! Thanks for helping us!

Quoted 59 lines · Beatriz Martins de Carvalho
Quoted 42 lines

Remove checkpatch check "CHECK: Lines should not end with a '('" with argument present in next line and reorganize characters so the lines are under 100 columns

---
  drivers/staging/media/omap4iss/iss.c | 46 +++++++++++++---------------
  1 file changed, 22 insertions(+), 24 deletions(-)
drivers/staging/media/omap4iss/iss.c +8 -6
index dae9073e7d3c..e8f724dbf810 100644
@@ -559,9 +559,10 @@ static int iss_reset(struct iss_device *iss)
  	iss_reg_set(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG,
  		    ISS_HL_SYSCONFIG_SOFTRESET);
 
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG) &
-		ISS_HL_SYSCONFIG_SOFTRESET), 1000, 10, 100);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss,
+							    OMAP4_ISS_MEM_TOP, ISS_HL_SYSCONFIG)
+							    & ISS_HL_SYSCONFIG_SOFTRESET),
+							    1000, 10, 100);
  	if (timeout) {
  		dev_err(iss->dev, "ISS reset timeout\n");
  		return -ETIMEDOUT;
@@ -583,9 +584,10 @@ static int iss_isp_reset(struct iss_device *iss)
 
  	iss_reg_set(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL, ISP5_CTRL_MSTANDBY);
 
-	timeout = iss_poll_condition_timeout(
-		iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL) &
-		ISP5_CTRL_MSTANDBY_WAIT, 1000000, 1000, 1500);
+	timeout = iss_poll_condition_timeout(iss_reg_read(iss,
+							  OMAP4_ISS_MEM_ISP_SYS1, ISP5_CTRL)
+							  & ISP5_CTRL_MSTANDBY_WAIT, 1000000,
+							  1000, 1500);
  	if (timeout) {
  		dev_err(iss->dev, "ISP5 standby timeout\n");
  		return -ETIMEDOUT;

drivers/staging/media/omap4iss/iss.c static int iss_isp_reset(struct iss_device *iss) · line 603

Quoted 10 lines
drivers/staging/media/omap4iss/iss.c +4 -3
@@ -595,9 +597,10 @@ static int iss_isp_reset(struct iss_device *iss)
  	iss_reg_set(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_SYSCONFIG,
  		    ISP5_SYSCONFIG_SOFTRESET);
 
-	timeout = iss_poll_condition_timeout(
-		!(iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1, ISP5_SYSCONFIG) &
-		ISP5_SYSCONFIG_SOFTRESET), 1000000, 1000, 1500);
+	timeout = iss_poll_condition_timeout(!(iss_reg_read(iss, OMAP4_ISS_MEM_ISP_SYS1,
+							    ISP5_SYSCONFIG) &
+							    ISP5_SYSCONFIG_SOFTRESET), 1000000,
+							    1000, 1500);

As several other people already commented, these changes do not improve readability. Just leave this code alone, it's good enough. Even splitting up the condition into a separate function would degrade readability since that would make it harder to discover the exact condition that will be polled for.

Quoted 1 line

Not everything that checkpatch.pl flags is necessarily bad code :-)

Yes, I learning about this. And I will using this for the next patches.

Quoted 40 lines
Quoted 40 lines
drivers/staging/media/omap4iss/iss.c +8 -12
  	if (timeout) {
  		dev_err(iss->dev, "ISP5 reset timeout\n");
  		return -ETIMEDOUT;
@@ -1104,33 +1107,28 @@ static int iss_create_links(struct iss_device *iss)
  	}
 
  	/* Connect the submodules. */
-	ret = media_create_pad_link(
-			&iss->csi2a.subdev.entity, CSI2_PAD_SOURCE,
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->csi2a.subdev.entity, CSI2_PAD_SOURCE,
+				    &iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
  	if (ret < 0)
  		return ret;
 
-	ret = media_create_pad_link(
-			&iss->csi2b.subdev.entity, CSI2_PAD_SOURCE,
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->csi2b.subdev.entity, CSI2_PAD_SOURCE,
+				    &iss->ipipeif.subdev.entity, IPIPEIF_PAD_SINK, 0);
  	if (ret < 0)
  		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
-			&iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
+				    &iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
  	if (ret < 0)
  		return ret;
 
-	ret = media_create_pad_link(
-			&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
-			&iss->ipipe.subdev.entity, IPIPE_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipeif.subdev.entity, IPIPEIF_PAD_SOURCE_VP,
+				    &iss->ipipe.subdev.entity, IPIPE_PAD_SINK, 0);
  	if (ret < 0)
  		return ret;
 
Quoted 10 lines

drivers/staging/media/omap4iss/iss.c static int iss_create_links(struct iss_device *iss) · line 1134

Quoted 9 lines
drivers/staging/media/omap4iss/iss.c +2 -3
-	ret = media_create_pad_link(
-			&iss->ipipe.subdev.entity, IPIPE_PAD_SOURCE_VP,
-			&iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
+	ret = media_create_pad_link(&iss->ipipe.subdev.entity, IPIPE_PAD_SOURCE_VP,
+				    &iss->resizer.subdev.entity, RESIZER_PAD_SINK, 0);
  	if (ret < 0)
  		return ret;
 

These, however, are readability improvements, so I'm happy with that.

Thank!

Quoted 4 lines

Regards,

Hans

Best wishes,
Beatriz Carvalho

#9 lore raw

Re: [PATCH 2/2] staging: media: omap4iss: align arguments with open parenthesis

In reply to Beatriz Martins de Carvalho

Hi Beatriz,

Quoted 2 lines · Beatriz Martins de Carvalho

Cleans up checks of "Alignment should match open parenthesis" in iss.c:96.

Looks good. I'll take this patch.

You can use this reference to record your contribution:

https://patchwork.linuxtv.org/project/linux-media/patch/475dbbe5774cbfed2d924807d8a3cfeb84b3d845.1617287509.git.martinsdecarvalhobeatriz@gmail.com/

The state will change to Accepted once it is merged in our media tree
here: https://git.linuxtv.org/media_tree.git/log/

Regards,

Hans

Quoted 20 lines
---
 drivers/staging/media/omap4iss/iss.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/omap4iss/iss.c +1 -1
index e8f724dbf810..472f1837632e 100644
@@ -963,7 +963,7 @@ iss_register_subdev_group(struct iss_device *iss,
 		}
 
 		subdev = v4l2_i2c_new_subdev_board(&iss->v4l2_dev, adapter,
-				board_info->board_info, NULL);
+						   board_info->board_info, NULL);
 		if (!subdev) {
 			dev_err(iss->dev, "Unable to register subdev %s\n",
 				board_info->board_info->type);