Skip to contentSkip to conversation

staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

PATCH Superseded Aline Santana Cordeiro 4 participants 7 messages Apr 8, 2021 – Apr 9, 2021 1 message not in the archive

Subsystems (2)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH v2 1/2 staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

---
 drivers/staging/media/hantro/hantro_hw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/hantro/hantro_hw.h +1 -1
index 34c9e46..a650b9c 100644
@@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width, unsigned int height)
 void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
 void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
 void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
-	const struct v4l2_ctrl_mpeg2_quantization *ctrl);
+				  const struct v4l2_ctrl_mpeg2_quantization *ctrl);
 int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);
 void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);
 
Signature · 1 line
2.7.4
#2 lore raw

Ola Aline,

Welcome to the kernel community. Hope you enjoy some of this Outreachy adventures.

Normally, when you submit a v2, we want to know what changed between the first submission and v2.

If you are subscribed to linux-media, you can read some of the series with a vN+1 and look how it's done. Examples:

https://www.spinics.net/lists/linux-media/msg190043.html

https://www.spinics.net/lists/linux-media/msg189923.html

I'm sure your Outreachy mentors can tell you more.

Quoted 21 lines · Aline Santana Cordeiro

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

---
 drivers/staging/media/hantro/hantro_hw.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/hantro/hantro_hw.h +1 -1
index 34c9e46..a650b9c 100644
@@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width, unsigned int height)
  void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
  void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
  void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
-       const struct v4l2_ctrl_mpeg2_quantization *ctrl);
+                                 const struct v4l2_ctrl_mpeg2_quantization *ctrl);
  int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);
  void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);

author
#3 lore raw

Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu:

Quoted 1 line

Ola Aline,

Ola Ezequiel,

Quoted 2 lines

Welcome to the kernel community. Hope you enjoy some of this Outreachy adventures.

Thank you!

Quoted 11 lines

Normally, when you submit a v2, we want to know what changed between the first submission and v2.

If you are subscribed to linux-media, you can read some of the series with a vN+1 and look how it's done. Examples:

https://www.spinics.net/lists/linux-media/msg190043.html

https://www.spinics.net/lists/linux-media/msg189923.html

I'm sure your Outreachy mentors can tell you more.

Thank you for the examples, it won't happen again.

The reason for sending a v2 is that I sent my very first patchset yesterday and I sent the cover-letter together, but (I think) I wasn't supposed to, and as the patches weren't marked as [PATCH 1/2] and [PATCH 2/2] in the email - since I commited all the files with the same message - I tought it was wrong and sent again today.

However, I just realized that I've changed just the subject of the e- mail, but I would've to change the commit message, right? And then, it would be a second version, am I right?

Thank you in advance,

Quoted 28 lines · Aline Santana Cordeiro
Quoted 25 lines

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

Signed-off-by: Aline Santana Cordeiro <
[email protected]>
---
 drivers/staging/media/hantro/hantro_hw.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/hantro/hantro_hw.h +1 -1
index 34c9e46..a650b9c 100644
@@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width,
 unsigned int height)
  void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
  void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
  void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
-       const struct v4l2_ctrl_mpeg2_quantization *ctrl);
+                                 const struct
 v4l2_ctrl_mpeg2_quantization *ctrl);
  int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);

 void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);

#4 lore raw
Quoted 28 lines · ascordeiro

Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu:

Quoted 1 line

Ola Aline,

Ola Ezequiel,

Quoted 2 lines

Welcome to the kernel community. Hope you enjoy some of this Outreachy adventures.

Thank you!

Quoted 11 lines

Normally, when you submit a v2, we want to know what changed between the first submission and v2.

If you are subscribed to linux-media, you can read some of the series with a vN+1 and look how it's done. Examples:

https://www.spinics.net/lists/linux-media/msg190043.html

https://www.spinics.net/lists/linux-media/msg189923.html

I'm sure your Outreachy mentors can tell you more.

Thank you for the examples, it won't happen again.

The reason for sending a v2 is that I sent my very first patchset yesterday and I sent the cover-letter together, but (I think) I wasn't supposed to, and as the patches weren't marked as [PATCH 1/2] and [PATCH 2/2] in the email - since I commited all the files with the same message - I tought it was wrong and sent again today.

Quoted 3 lines

However, I just realized that I've changed just the subject of the e- mail, but I would've to change the commit message, right? And then, it would be a second version, am I right?

Your next version should be v3 with information about changes since v1 under --- . If you send it with v2, it'll still be confusing for people because then they have to manually find out the difference between two different patchsets with the same subject line. :)

You can also check 'Revising your patches' section in the tutorial.

Quoted 36 lines

Thank you in advance,

Quoted 10 lines · Aline Santana Cordeiro
Quoted 9 lines

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

Signed-off-by: Aline Santana Cordeiro <
[email protected]>

---
 drivers/staging/media/hantro/hantro_hw.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 18 lines
Quoted 14 lines
drivers/staging/media/hantro/hantro_hw.h +1 -1
index 34c9e46..a650b9c 100644
@@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width,
 unsigned int height)
 void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
 void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
 void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
-       const struct v4l2_ctrl_mpeg2_quantization *ctrl);
+                                 const struct
 v4l2_ctrl_mpeg2_quantization *ctrl);
 int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);
Quoted 2 lines

void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/6bba0e0a5768e902ffec4bda563d4ca810412f84.camel%40gmail.com.

Signature · 1 line
Vaishali
author
#5 lore raw

Em sex, 2021-04-09 às 10:25 +0200, Vaishali Thakkar escreveu:

Quoted 38 lines
Quoted 30 lines · ascordeiro

Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu:

Quoted 1 line

Ola Aline,

Ola Ezequiel,

Quoted 2 lines

Welcome to the kernel community. Hope you enjoy some of this Outreachy adventures.

Thank you!

Quoted 11 lines

Normally, when you submit a v2, we want to know what changed between the first submission and v2.

If you are subscribed to linux-media, you can read some of the series with a vN+1 and look how it's done. Examples:

https://www.spinics.net/lists/linux-media/msg190043.html

https://www.spinics.net/lists/linux-media/msg189923.html

I'm sure your Outreachy mentors can tell you more.

Thank you for the examples, it won't happen again.

The reason for sending a v2 is that I sent my very first patchset yesterday and I sent the cover-letter together, but (I think) I wasn't
supposed to, and as the patches weren't marked as [PATCH 1/2] and [PATCH 2/2] in the email - since I commited all the files with the same
message - I tought it was wrong and sent again today.

Quoted 5 lines

However, I just realized that I've changed just the subject of the e-
mail, but I would've to change the commit message, right? And then, it
would be a second version, am I right?

Quoted 7 lines

Your next version should be v3 with information about changes since v1 under --- . If you send it with v2, it'll still be confusing for people
because then they have to manually find out the difference between two different patchsets with the same subject line. :)

You can also check 'Revising your patches' section in the tutorial.

Thank you, Vaishali!
You made it clear :)
I'm going to correct the patchset and send v3.

Quoted 43 lines
Quoted 40 lines

Thank you in advance,

Quoted 10 lines · Aline Santana Cordeiro
Quoted 9 lines

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

Signed-off-by: Aline Santana Cordeiro <
[email protected]>
---
 drivers/staging/media/hantro/hantro_hw.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 18 lines
Quoted 14 lines
drivers/staging/media/hantro/hantro_hw.h +1 -1
index 34c9e46..a650b9c 100644
@@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width,
 unsigned int height)
  void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
  void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
  void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
-       const struct v4l2_ctrl_mpeg2_quantization *ctrl);
+                                 const struct
 v4l2_ctrl_mpeg2_quantization *ctrl);
  int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);
Quoted 2 lines

 void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit
https://groups.google.com/d/msgid/outreachy-kernel/6bba0e0a5768e902ffec4bda563d4ca810412f84.camel%40gmail.com
.

#6 lore raw
In reply to Ezequiel Garcia
Quoted 8 lines · Ezequiel Garcia

Ola Aline,

Welcome to the kernel community. Hope you enjoy some of this Outreachy adventures.

Normally, when you submit a v2, we want to know what changed between the first submission and v2.

Quoted 8 lines

If you are subscribed to linux-media, you can read some of the series with a vN+1 and look how it's done. Examples:

https://www.spinics.net/lists/linux-media/msg190043.html

https://www.spinics.net/lists/linux-media/msg189923.html

I'm sure your Outreachy mentors can tell you more.

There is information in the kernelnewbies tutorial about how to resubmit patches.

julia

Quoted 30 lines · Aline Santana Cordeiro
Quoted 20 lines

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

---
 drivers/staging/media/hantro/hantro_hw.h | 2 +-

 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/hantro/hantro_hw.h +1 -1
index 34c9e46..a650b9c 100644
@@ -207,7 +207,7 @@ hantro_h264_mv_size(unsigned int width, unsigned int height)
  void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx);
  void rk3399_vpu_mpeg2_dec_run(struct hantro_ctx *ctx);
  void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
-       const struct v4l2_ctrl_mpeg2_quantization *ctrl);
+                                 const struct v4l2_ctrl_mpeg2_quantization *ctrl);
  int hantro_mpeg2_dec_init(struct hantro_ctx *ctx);
  void hantro_mpeg2_dec_exit(struct hantro_ctx *ctx);
Quoted 1 line

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/d4000598fddcf45e578462aa04b556c0ca057091.camel%40collabora.com.

#7 lore raw

PATCH v2 2/2 staging: media: hantro: Align line break to the open parenthesis in file hantro_mpeg2.c

In reply to a message not in the archive

Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch.

---
 drivers/staging/media/hantro/hantro_mpeg2.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/hantro/hantro_mpeg2.c +1 -1
index 1d334e6..53a99a9 100644
@@ -19,7 +19,7 @@ static const u8 zigzag[64] = {
 };
 
 void hantro_mpeg2_dec_copy_qtable(u8 *qtable,
-	const struct v4l2_ctrl_mpeg2_quantization *ctrl)
+				  const struct v4l2_ctrl_mpeg2_quantization *ctrl)
 {
 	int i, n;
 
Signature · 1 line
2.7.4