staging: rtl8192e: cleanup patchset for style issues
v4 cover staging: rtl8192e: cleanup patchset for style issues
Changes from v3:- Changed subject line to match prefix on the patches. [PATCH v3 1/3]:- No changes.
[PATCH v3 2/3]:- No changes.
[PATCH V3 3/3]:- No changes.
Changes from v2:-
[PATCH v2 1/3]:- Modified subject description. Changes has been made in v3.
[PATCH v2 2/3]:- No changes.
[PATCH v2 3/3]:- Rectified spelling mistake in subject description. Changes has been made in v3.
Changes from v1:-
[PATCH 1/3]:- Removed unnecessary parentheses around boolean expression. Changes has been made in v2.
[PATCH 2/3]:- No changes.
[PATCH 3/3]:- No changes.
Mitali Borkar (6):
staging: rtl8192e: remove parentheses around boolean expression
staging: rtl8192e: remove unnecessary ftrace-like logging
staging: rtl8192e: remove unnecessary parentheses
drivers/staging/rtl8192e/rtl819x_HTProc.c | 18 ++- 1 file changed, 7 insertions(+), 11 deletions(-)
Signature · 1 line
2.30.2
PATCH v4 1/3 staging: rtl8192e: remove parentheses around boolean expression
Removed unnecessary parentheses around '!xyz' boolean expression as '!' has higher precedance than '||'
---
Changes from v3:- No changes.
Changes from v2:- Modified subject description. Changes has been made in v3.
Changes from v1:- Removed unnecessary parentheses around boolean expression. Changes has been made in v2.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +1 -1
@@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,struct rt_hi_throughput *pHT = ieee->pHTInfo;struct ht_capab_ele *pCapELE =NULL ; -if ((!posHTCap) || (!pHT)) { +if (!posHTCap || !pHT) {netdev_warn (ieee->dev,"%s(): posHTCap and pHTInfo are null\n" , __func__);return ;
Signature · 1 line
2.30.2
PATCH v4 2/3 staging: rtl8192e: remove unnecessary ftrace-like logging
In reply to Mitali BorkarRemoved unncessary ftrace-like logging by simply deleting that statement as we have other modes of logging like ftrace.
Reported by checkpatch.
---
Changes from v3:- No changes.
Changes from v2:- No changes.
Changes from v1:- No changes.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +0 -4
@@ -630,7 +630,6 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) {struct rt_hi_throughput *pHTInfo = ieee->pHTInfo; -netdev_vdbg (ieee->dev,"%s()\n" , __func__); pHTInfo->bCurrentHTSupport = false; pHTInfo->bCurBW40MHz = false;
@@ -698,7 +697,6 @@ void HTResetSelfAndSavePeerSetting(struct rtllib_device *ieee,struct rt_hi_throughput *pHTInfo = ieee->pHTInfo;u8 bIOTAction =0 ; -netdev_vdbg (ieee->dev,"%s()\n" , __func__);/* unmark bEnableHT flag here is the same reason why unmarked in * function rtllib_softmac_new_net. WB 2008.09.10 */
@@ -832,8 +830,6 @@ static void HTSetConnectBwModeCallback(struct rtllib_device *ieee) {struct rt_hi_throughput *pHTInfo = ieee->pHTInfo; -netdev_vdbg (ieee->dev,"%s()\n" , __func__); -if (pHTInfo->bCurBW40MHz) {if (pHTInfo->CurSTAExtChnlOffset ==HT_EXTCHNL_OFFSET_UPPER ) ieee->set_chan(ieee->dev,
Signature · 1 line
2.30.2
PATCH v4 3/3 staging: rtl8192e: remove unnecessary parentheses
In reply to Mitali BorkarRemoved unnecessary parentheses because they must be used only when it is necessary or they improve readability.
Reported by checkpatch.
---
Changes from v3:- No changes.
Changes from v2:- Rectified spelling mistake in subject description. Changes has been made in v3.
Changes from v1:- No changes.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +6 -6
@@ -287,7 +287,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,u8 EWC11NHTCap[] = {0x00 ,0x90 ,0x4c ,0x33 };memcpy (posHTCap, EWC11NHTCap,sizeof (EWC11NHTCap)); - pCapELE = (struct ht_capab_ele *)&(posHTCap[4 ]); + pCapELE = (struct ht_capab_ele *)&posHTCap[4 ]; *len =30 +2 ; }else { pCapELE = (struct ht_capab_ele *)posHTCap;
@@ -646,13 +646,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; -memset ((void *)(&(pHTInfo->SelfHTCap)),0 , +memset ((void *)(&pHTInfo->SelfHTCap),0 ,sizeof (pHTInfo->SelfHTCap)); -memset ((void *)(&(pHTInfo->SelfHTInfo)),0 , +memset ((void *)(&pHTInfo->SelfHTInfo),0 ,sizeof (pHTInfo->SelfHTInfo)); -memset ((void *)(&(pHTInfo->PeerHTCapBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTCapBuf),0 ,sizeof (pHTInfo->PeerHTCapBuf)); -memset ((void *)(&(pHTInfo->PeerHTInfoBuf)),0 , +memset ((void *)(&pHTInfo->PeerHTInfoBuf),0 ,sizeof (pHTInfo->PeerHTInfoBuf)); pHTInfo->bSwBwInProgress = false;
@@ -668,7 +668,7 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->IOTRaFunc =0 ; { -u8 *RegHTSuppRateSets = &(ieee->RegHTSuppRateSet[0 ]); +u8 *RegHTSuppRateSets = &ieee->RegHTSuppRateSet[0 ]; RegHTSuppRateSets[0 ] =0xFF ; RegHTSuppRateSets[1 ] =0xFF ;
Signature · 1 line
2.30.2
Re: [PATCH v4 3/3] staging: rtl8192e: remove unnecessary parentheses
Quoted 3 lines · Mitali Borkar
Removed unnecessary parentheses because they must be used only when it is necessary or they improve readability.
Reported by checkpatch.
I gave you feedback about the memset changes.
Please use it.
https://lore.kernel.org/lkml/[email protected]/
Quoted 4 lines
Changes from v3:- No changes.
Changes from v2:- Rectified spelling mistake in subject description. Changes has been made in v3.
Changes from v1:- No changes.
[]
drivers/staging/rtl8192e/rtl819x_HTProc.c
Quoted 1 line
drivers/staging/rtl8192e/rtl819x_HTProc.c +0
-0
[]
Quoted 8 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c +0
-0@@ -646,13 +646,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) � pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; � pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;�
drivers/staging/rtl8192e/rtl819x_HTProc.c +1
-1- memset((void *)(&(pHTInfo->SelfHTCap)), 0, + memset((void *)(&pHTInfo->SelfHTCap), 0,�
sizeof(pHTInfo->SelfHTCap));
memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap);
etc...
Re: [PATCH v4 3/3] staging: rtl8192e: remove unnecessary parentheses
Quoted 9 lines · Joe Perches
Quoted 3 lines · Mitali Borkar
Removed unnecessary parentheses because they must be used only when it is necessary or they improve readability.
Reported by checkpatch.I gave you feedback about the memset changes.
Please use it.
https://lore.kernel.org/lkml/[email protected]/
I am sorry Sir, I missed this. I will make required changes now.
Quoted 20 lines
Quoted 4 lines
Changes from v3:- No changes.
Changes from v2:- Rectified spelling mistake in subject description. Changes has been made in v3.
Changes from v1:- No changes.[]
drivers/staging/rtl8192e/rtl819x_HTProc.c
Quoted 1 line
drivers/staging/rtl8192e/rtl819x_HTProc.c +0
-0[]
Quoted 8 lines
drivers/staging/rtl8192e/rtl819x_HTProc.c +0
-0@@ -646,13 +646,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;drivers/staging/rtl8192e/rtl819x_HTProc.c +1
-1- memset((void *)(&(pHTInfo->SelfHTCap)), 0, + memset((void *)(&pHTInfo->SelfHTCap), 0,
sizeof(pHTInfo->SelfHTCap));memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap);etc...