staging: media: intel-ipu3: Cleanup patchset for style issues
Subsystems (3)
v3 cover staging: media: intel-ipu3: Cleanup patchset for style issues
Changes from v2:- Rebased these four patces and made changes against mailine code
Changes from v1:-
Dropped patches 1/6 and 2/6 and compiled this as a patchset of 4 patches.
[PATCH 1/4]:- No changes.
[PATCH 2/4]:- No changes.
[PATCH 3/4]:- Reduced length of a line under 80 characters. This was patch 5/6 previously.
[PATCH 4/4]:- No changes.
Mitali Borkar (4):
staging: media: intel-ipu3: remove unnecessary blank line
staging: media: intel-ipu3: reduce length of line
staging: media: intel-ipu3: line should not end with '['
staging: media: intel-ipu3: remove space before tabs
drivers/staging/media/ipu3/include/intel-ipu3.h | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-)
Signature · 1 line
2.30.2
PATCH v3 1/4 staging: media: intel-ipu3: remove unnecessary blank line
Removed an unnecessary blank line to meet linux kernel coding style. Reported by checkpatch.pl
---
Changes from v2:- No changes.
Changes from v1:- NO changes.
drivers/staging/media/ipu3/include/intel-ipu3.h | 1 - 1 file changed, 1 deletion(-)
drivers/staging/media/ipu3/include/intel-ipu3.h +0 -1
@@ -74,7 +74,6 @@ struct ipu3_uapi_grid_config { (IPU3_UAPI_AWB_MAX_SETS * \ (IPU3_UAPI_AWB_SET_SIZE +IPU3_UAPI_AWB_SPARE_FOR_BUBBLES )) -/** * struct ipu3_uapi_awb_raw_buffer - AWB raw buffer *
Signature · 1 line
2.30.2
PATCH v3 2/4 staging: media: intel-ipu3: reduce length of line
In reply to Mitali BorkarReduced length of line as it was exceeding 100 characters by removing comments from same line and adding it to previous line. This makes code neater, and meets linux kernel coding style.
Reported by checkpatch.
---
Changes from v2:- No changes.
Changes from v1:- No changes.
drivers/staging/media/ipu3/include/intel-ipu3.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/staging/media/ipu3/include/intel-ipu3.h +6 -2
@@ -9,8 +9,12 @@/* from /drivers/staging/media/ipu3/include/videodev2.h */ /* Vendor specific - used for IPU3 camera sub-system */ -#define V4L2_META_FMT_IPU3_PARAMS v4l2_fourcc('i', 'p', '3', 'p')/* IPU3 processing parameters */ -#define V4L2_META_FMT_IPU3_STAT_3A v4l2_fourcc('i', 'p', '3', 's')/* IPU3 3A statistics */ + +/* IPU3 processing parameters */ +#define V4L2_META_FMT_IPU3_PARAMS v4l2_fourcc('i', 'p', '3', 'p') + +/* IPU3 3A statistics */ +#define V4L2_META_FMT_IPU3_STAT_3A v4l2_fourcc('i', 'p', '3', 's')/* from include/uapi/linux/v4l2-controls.h */ #define V4L2_CID_INTEL_IPU3_BASE (V4L2_CID_USER_BASE + 0x10c0)
Signature · 1 line
2.30.2
PATCH v3 3/4 staging: media: intel-ipu3: line should not end with '['
In reply to Mitali BorkarFixed the issue of line should not end with '[' by moving argument from next line to line ending with '[' and made it under 80 characters.
Reported by checkpatch.
---
Changes from v2:- No changes
Changes from v1:- Made line length under 80 characters
drivers/staging/media/ipu3/include/intel-ipu3.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/ipu3/include/intel-ipu3.h +2 -2
@@ -247,8 +247,8 @@ struct ipu3_uapi_ae_ccm {*/ struct ipu3_uapi_ae_config {struct ipu3_uapi_ae_grid_config grid_cfg __attribute__((aligned (32 ))); -struct ipu3_uapi_ae_weight_elem weights[ -IPU3_UAPI_AE_WEIGHTS ] __attribute__((aligned (32 ))); +struct ipu3_uapi_ae_weight_elem weights[IPU3_UAPI_AE_WEIGHTS ] + __attribute__((aligned (32 )));struct ipu3_uapi_ae_ccm ae_ccm __attribute__((aligned (32 ))); } __packed;
Signature · 1 line
2.30.2
PATCH v3 4/4 staging: media: intel-ipu3: remove space before tabs
In reply to Mitali BorkarRemoved unnecessary space before tabs to adhere to linux kernel coding style.
Reported by checkpatch.
---
Changes from v2:- No changes.
Changes from v1:- No changes.
drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/media/ipu3/include/intel-ipu3.h +1 -1
@@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config {* @cg: Gain coefficient for threshold calculation, [0, 31], default 8. * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] * default 6. -* format: u3.2 (3 most significant bits represent whole number, +*format: u3.2 (3 most significant bits represent whole number, * 2 least significant bits represent the fractional part * with each count representing 0.25) * e.g. 6 in binary format is 00110, that translates to 1.5
Signature · 1 line
2.30.2
Quoted 2 lines · Mitali Borkar
Changes from v2:- Rebased these four patces and made changes against mailine code
Thanks for the update, Mitali.
For the set:
Signature · 1 line
Sakari Ailus
Re: [PATCH v3 4/4] staging: media: intel-ipu3: remove space before tabs
In reply to Mitali BorkarQuoted 18 lines · Mitali Borkar
Removed unnecessary space before tabs to adhere to linux kernel coding style.
Reported by checkpatch.Signed-off-by Mitali Borkar <[email protected]>---
Changes from v2:- No changes.
Changes from v1:- No changes.drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/media/ipu3/include/intel-ipu3.h +0
-0
drivers/staging/media/ipu3/include/intel-ipu3.h struct ipu3_uapi_bnr_static_config_wb_gains_thr_config { · line 637
Quoted 6 lines
drivers/staging/media/ipu3/include/intel-ipu3.h +1
-1@@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config {* @cg: Gain coefficient for threshold calculation, [0, 31], default 8. * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] * default 6. -* format: u3.2 (3 most significant bits represent whole number, +*format: u3.2 (3 most significant bits represent whole number, * 2 least significant bits represent the fractional part
Just remove the spaces, don't remove the tab. It's looks silly now.
regards,
dan carpenter
Re: [PATCH v3 4/4] staging: media: intel-ipu3: remove space before tabs
Quoted 14 lines · Dan Carpenter
Quoted 13 lines · Mitali Borkar
Removed unnecessary space before tabs to adhere to linux kernel coding style.
Reported by checkpatch.Signed-off-by Mitali Borkar <[email protected]>---
Changes from v2:- No changes.
Changes from v1:- No changes.drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
drivers/staging/media/ipu3/include/intel-ipu3.h struct ipu3_uapi_bnr_static_config_wb_gains_thr_config { · line 637
Quoted 11 lines
drivers/staging/media/ipu3/include/intel-ipu3.h +1
-1@@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config {* @cg: Gain coefficient for threshold calculation, [0, 31], default 8. * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] * default 6. -* format: u3.2 (3 most significant bits represent whole number, +*format: u3.2 (3 most significant bits represent whole number, * 2 least significant bits represent the fractional part Just remove the spaces, don't remove the tab. It's looks silly now.
Okay Sir, do I have to send a v4 patch on this now?
Quoted 3 lines
regards,
dan carpenter
Re: [Outreachy kernel] Re: [PATCH v3 4/4] staging: media: intel-ipu3: remove space before tabs
Quoted 29 lines · Mitali Borkar
Quoted 14 lines · Dan Carpenter
Quoted 13 lines · Mitali Borkar
Removed unnecessary space before tabs to adhere to linux kernel coding style.
Reported by checkpatch.Signed-off-by Mitali Borkar <[email protected]>---
Changes from v2:- No changes.
Changes from v1:- No changes.drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 14 lines
drivers/staging/media/ipu3/include/intel-ipu3.h struct ipu3_uapi_bnr_static_config_wb_gains_thr_config { · line 637
Quoted 11 lines
drivers/staging/media/ipu3/include/intel-ipu3.h +1
-1@@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config {* @cg: Gain coefficient for threshold calculation, [0, 31], default 8. * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] * default 6. -* format: u3.2 (3 most significant bits represent whole number, +*format: u3.2 (3 most significant bits represent whole number, * 2 least significant bits represent the fractional part Just remove the spaces, don't remove the tab. It's looks silly now.
Quoted 1 line
Okay Sir, do I have to send a v4 patch on this now?
Yes. If you get feedback on a patch, you should send a new version.
julia
Quoted 10 lines
Quoted 4 lines
regards,
dan carpenter--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/YHX3iVCNXJlOsmuQ%40kali.
Sakari Ailus
maintainerRe: [Outreachy kernel] Re: [PATCH v3 4/4] staging: media: intel-ipu3: remove space before tabs
Quoted 33 lines · Julia Lawall
Quoted 29 lines · Mitali Borkar
Quoted 28 lines · Dan Carpenter
Quoted 18 lines · Mitali Borkar
Removed unnecessary space before tabs to adhere to linux kernel coding style.
Reported by checkpatch.Signed-off-by Mitali Borkar <[email protected]>---
Changes from v2:- No changes.
Changes from v1:- No changes.drivers/staging/media/ipu3/include/intel-ipu3.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/media/ipu3/include/intel-ipu3.h +0
-0drivers/staging/media/ipu3/include/intel-ipu3.h struct ipu3_uapi_bnr_static_config_wb_gains_thr_config { · line 637
Quoted 6 lines
drivers/staging/media/ipu3/include/intel-ipu3.h +1
-1@@ -633,7 +633,7 @@ struct ipu3_uapi_bnr_static_config_wb_gains_thr_config {* @cg: Gain coefficient for threshold calculation, [0, 31], default 8. * @ci: Intensity coefficient for threshold calculation. range [0, 0x1f] * default 6. -* format: u3.2 (3 most significant bits represent whole number, +*format: u3.2 (3 most significant bits represent whole number, * 2 least significant bits represent the fractional part Just remove the spaces, don't remove the tab. It's looks silly now.
Quoted 3 lines
Quoted 1 line
Okay Sir, do I have to send a v4 patch on this now?
Yes. If you get feedback on a patch, you should send a new version.
v2 of this patch can be used as well, it's fine. (I missed this change in v3.)
Signature · 1 line
Sakari Ailus