staging: rtl8192e: Clean up patchset for style issues in rtl819x_HTProc.c
v6 cover staging: rtl8192e: Clean up patchset for style issues in rtl819x_HTProc.c
Changes from v5:- Rebased these patches and dropped 2/3 and made this a patchset of 2.
[PATCH v5 1/2]:- No changes.
[PATCH V5 2/2]:- No changes.
Changes from v4:-
[PATCH v4 1/2]:- No changes.
[PATCH V4 2/2]:- Removed casts and parentheses.
Changes from v3:- Changed subject line to match prefix on the patches. [PATCH v3 1/2]:- No changes.
[PATCH V3 2/2]:- No changes.
Changes from v2:-
[PATCH v2 1/2]:- Modified subject description. Changes has been made in v3.
[PATCH v2 2/2]:- Rectified spelling mistake in subject description. Changes has been made in v3.
Changes from v1:-
[PATCH 1/2]:- Removed unnecessary parentheses around boolean expression. Changes has been made in v2.
[PATCH 2/2]:- No changes.
Mitali Borkar (2):
staging: rtl8192e: remove parentheses around boolean expression
staging: rtl8192e: remove casts and parentheses
drivers/staging/rtl8192e/rtl819x_HTProc.c | 14 +-- 1 file changed, 5 insertions(+), 9 deletions(-)
Signature · 1 line
2.30.2
PATCH v6 1/2 staging: rtl8192e: remove parentheses around boolean expression
Removed unnecessary parentheses around '!xyz' boolean expression as '!' has higher precedance than '||'
---
Changes from v5:- No changes.
Changes from v4:- No changes.
Changes from v3:- No changes.
Changes from v2:- Modified subject description. Changes has been made in v3.
Changes from v1:- Removed unnecessary parentheses around boolean expression. Changes has been made in v2.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +1 -1
@@ -276,7 +276,7 @@ void HTConstructCapabilityElement(struct rtllib_device *ieee, u8 *posHTCap,struct rt_hi_throughput *pHT = ieee->pHTInfo;struct ht_capab_ele *pCapELE =NULL ; -if ((!posHTCap) || (!pHT)) { +if (!posHTCap || !pHT) {netdev_warn (ieee->dev,"%s(): posHTCap and pHTInfo are null\n" , __func__);return ;
Signature · 1 line
2.30.2
PATCH v6 2/2 staging: rtl8192e: remove casts and parentheses
In reply to Mitali BorkarRemoved unnecessary (void *) cast and parentheses to meet linux kernel coding style.
---
Changes from v5:- No changes.
Changes from v4:- Removed unnecessary casts and parentheses. Changes from v3:- No changes.
Changes from v2:- Rectified spelling mistake in subject description. Changes has been made in v3.
Changes from v1:- No changes.
drivers/staging/rtl8192e/rtl819x_HTProc.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-)
drivers/staging/rtl8192e/rtl819x_HTProc.c +4 -8
@@ -646,14 +646,10 @@ void HTInitializeHTInfo(struct rtllib_device *ieee) pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density; pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor; -memset ((void *)(&pHTInfo->SelfHTCap),0 , -sizeof (pHTInfo->SelfHTCap)); -memset ((void *)(&pHTInfo->SelfHTInfo),0 , -sizeof (pHTInfo->SelfHTInfo)); -memset ((void *)(&pHTInfo->PeerHTCapBuf),0 , -sizeof (pHTInfo->PeerHTCapBuf)); -memset ((void *)(&pHTInfo->PeerHTInfoBuf),0 , -sizeof (pHTInfo->PeerHTInfoBuf)); +memset (&pHTInfo->SelfHTCap,0 ,sizeof (pHTInfo->SelfHTCap)); +memset (&pHTInfo->SelfHTInfo,0 ,sizeof (pHTInfo->SelfHTInfo)); +memset (&pHTInfo->PeerHTCapBuf,0 ,sizeof (pHTInfo->PeerHTCapBuf)); +memset (&pHTInfo->PeerHTInfoBuf,0 ,sizeof (pHTInfo->PeerHTInfoBuf)); pHTInfo->bSwBwInProgress = false;
Signature · 1 line
2.30.2
Greg KH
maintainerRe: [PATCH v6 1/2] staging: rtl8192e: remove parentheses around boolean expression
In reply to Mitali BorkarQuoted 5 lines · Mitali Borkar
Removed unnecessary parentheses around '!xyz' boolean expression as '!' has higher precedance than '||'
Signed-off-by Mitali Borkar <[email protected]>---
This series does not apply to my tree :(