staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_cmd.c
Subsystems (4)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/4 staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_cmd.c
Balance braces around conditional statements. Issue detected by checkpatch.pl.
It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code.
--- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_cmd.c +10 -9
@@ -1132,9 +1132,10 @@ void atomisp_buf_done(struct atomisp_sub_device *asd, int error, asd->frame_status[vb->i] =ATOMISP_FRAME_STATUS_OK ; } - }else + }else { asd->frame_status[vb->i] =ATOMISP_FRAME_STATUS_OK ; + } }else { asd->frame_status[vb->i] =ATOMISP_FRAME_STATUS_OK ; }
@@ -4898,9 +4899,9 @@ atomisp_try_fmt_file(struct atomisp_device *isp, struct v4l2_format *f) depth =get_pixel_depth (pixelformat); -if (field ==V4L2_FIELD_ANY ) +if (field ==V4L2_FIELD_ANY ) { field =V4L2_FIELD_NONE ; -else if (field !=V4L2_FIELD_NONE ) { + }else if (field !=V4L2_FIELD_NONE ) {dev_err (isp->dev,"Wrong output field\n" );return -EINVAL ; }
@@ -6548,17 +6549,17 @@ static int atomisp_get_pipe_id(struct atomisp_video_pipe *pipe) {struct atomisp_sub_device *asd = pipe->asd; -if (ATOMISP_USE_YUVPP (asd)) +if (ATOMISP_USE_YUVPP (asd)) {return IA_CSS_PIPE_ID_YUVPP ; -else if (asd->vfpp->val ==ATOMISP_VFPP_DISABLE_SCALER ) + }else if (asd->vfpp->val ==ATOMISP_VFPP_DISABLE_SCALER ) {return IA_CSS_PIPE_ID_VIDEO ; -else if (asd->vfpp->val ==ATOMISP_VFPP_DISABLE_LOWLAT ) + }else if (asd->vfpp->val ==ATOMISP_VFPP_DISABLE_LOWLAT ) {return IA_CSS_PIPE_ID_CAPTURE ; -else if (pipe == &asd->video_out_video_capture) + }else if (pipe == &asd->video_out_video_capture) {return IA_CSS_PIPE_ID_VIDEO ; -else if (pipe == &asd->video_out_vf) + }else if (pipe == &asd->video_out_vf) {return IA_CSS_PIPE_ID_CAPTURE ; -else if (pipe == &asd->video_out_preview) { + }else if (pipe == &asd->video_out_preview) {if (asd->run_mode->val ==ATOMISP_RUN_MODE_VIDEO )return IA_CSS_PIPE_ID_VIDEO ;else
Signature · 1 line
2.7.4
PATCH 2/4 staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_compat_css20.c
In reply to a message not in the archiveBalance braces around conditional statements. Issue detected by checkpatch.pl.
It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code.
--- drivers/staging/media/atomisp/pci/atomisp_compat_css20.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_compat_css20.c +2 -2
@@ -2784,9 +2784,9 @@ int atomisp_get_css_frame_info(struct atomisp_sub_device *asd,int stream_index;struct atomisp_device *isp = asd->isp; -if (ATOMISP_SOC_CAMERA (asd)) +if (ATOMISP_SOC_CAMERA (asd)) { stream_index =atomisp_source_pad_to_stream_id (asd, source_pad); -else { + }else { stream_index = (pipe_index ==IA_CSS_PIPE_ID_YUVPP ) ?ATOMISP_INPUT_STREAM_VIDEO :atomisp_source_pad_to_stream_id (asd, source_pad);
Signature · 1 line
2.7.4
PATCH 3/4 staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_subdev.c
In reply to a message not in the archiveBalance braces around conditional statements. Issue detected by checkpatch.pl.
It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code.
--- drivers/staging/media/atomisp/pci/atomisp_subdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_subdev.c +2 -2
@@ -472,9 +472,9 @@ int atomisp_subdev_set_selection(struct v4l2_subdev *sd,* when dvs is disabled. */ dvs_w = dvs_h =12 ; - }else + }else { dvs_w = dvs_h =0 ; - + }atomisp_css_video_set_dis_envelope (isp_sd, dvs_w, dvs_h);atomisp_css_input_set_effective_resolution (isp_sd, stream_id, crop[pad]->width, crop[pad]->height);
Signature · 1 line
2.7.4
PATCH 4/4 staging: media: atomisp: pci: Balance braces around conditional statements in file atomisp_v4l2.c
In reply to a message not in the archiveBalance braces around conditional statements. Issue detected by checkpatch.pl.
It happens in if-else statements where one of the commands uses braces around a block of code and the other command does not since it has just a single line of code.
--- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/media/atomisp/pci/atomisp_v4l2.c +2 -2
@@ -1500,9 +1500,9 @@ static int init_atomisp_wdts(struct atomisp_device *isp)for (i =0 ; i < isp->num_of_streams; i++) {struct atomisp_sub_device *asd = &isp->asd[i]; -if (!IS_ISP2401 ) +if (!IS_ISP2401 ) {timer_setup (&asd->wdt, atomisp_wdt,0 ); -else { + }else {timer_setup (&asd->video_out_capture.wdt, atomisp_wdt,0 ); timer_setup(&asd->video_out_preview.wdt,
Signature · 1 line
2.7.4