staging: media: atomisp: code cleanup fixes
Subsystems (4)
v4 cover staging: media: atomisp: code cleanup fixes
This patch set addresses multiple issues reported by of checkpatch script as WARNING and CHECK complaints. Other feedback received from the maintainers is incorporated as well.
Note:
- The patches should be applied in the ascending order.
- Patch count revised to 9 from 6
- patch 1/9 is not being sent since it was already submitted by another developer.
Changes since v3:
Generic change:
1. Dropped patch 1/9 since it was already submitted to Hans by another developer.
2. Split patch 2 into patch 2 & 3 since they are doing two different things.
3. Added patch 8 & 9 for extended clean up based on patch set feedback received.
Patch Specific change:
1. patch 1/9 : dropped
2. patch 2/9 : split into patch 2 & 3
3. patch 3/9 : introduced
4. patch 4/9 : none
5. patch 5/9 : include header file in the clean up
6. patch 6/9 : none
7. patch 7/9 : include dev_info() for replacements
8. patch 8/9 : introduced
9. patch 9/9 : introduced
Changes since v2:
Generic change:
1. Correct patch versioning in patch subject
Patch Specific change:
1. patch 1/6 : none
2. patch 2/6 : none
3. patch 3/6 : none
4. patch 4/6 :
a. Tag Fabio Auito for the patch suggestion
5. patch 5/6 : none
6. patch 6/6:
a. Tag Fabio Auito for the patch suggestion
Changes since v1:
Generic change:
1. The patch set is being resent from an email account that matches with the patch signed-of-by tag. Issue highlighted by Hans Verkuil.
Patch specific changes:
1. patch 1/6 : none
2. patch 2/6 : none
3. patch 3/6 : none
4. patch 4/6 : implement following changes suggested by Fabio Aiuto a. Corrected commenting style
b. Similar style implemented for other comment blocks in
the same files.
5. patch 5/6 : none
6. patch 6/6: implement following changes suggested by Fabio Aiuto a. use dev_info instead of pr_info
b. update patch log message accordingly
Deepak R Varma (9):
staging: media: atomisp: improve function argument alignment
staging: media: atomisp: balance braces around if...else block
staging: media: atomisp: remove unnecessary braces
staging: media: atomisp: use __func__ over function names
staging: media: atomisp: reformat code comment blocks
staging: media: atomisp: fix CamelCase variable naming
staging: media: atomisp: replace raw pr_*() by dev_dbg()
staging: media: atomisp: remove unnecessary pr_info calls
staging: media: atomisp: remove unwanted dev_*() calls
.../media/atomisp/i2c/atomisp-gc0310.c | 57 +++------ .../media/atomisp/i2c/atomisp-gc2235.c | 29 ++--- .../atomisp/i2c/atomisp-libmsrlisthelper.c | 6 +- .../media/atomisp/i2c/atomisp-lm3554.c | 2 +- .../media/atomisp/i2c/atomisp-mt9m114.c | 108 ++++++++++-------- .../media/atomisp/i2c/atomisp-ov2680.c | 41 ++++--- .../media/atomisp/i2c/atomisp-ov2722.c | 10 +- drivers/staging/media/atomisp/i2c/mt9m114.h | 3 +- drivers/staging/media/atomisp/i2c/ov2680.h | 10 +- 9 files changed, 130 insertions(+), 136 deletions(-)
Signature · 1 line
2.31.1
PATCH v4 2/9 staging: media: atomisp: balance braces around if...else block
Balance braces around the if else blocks as per the code style guidelines. Add braces to branches where it is missing. Resolves checkpatch script CHECK / WARNING feedback messages.
---
Changes since v3:
- Split this patch into patch 2 and 3.
- patch 2 now only adds missing braces.
- Removing unwanted braces is moved into patch 3
Changes since v2:
- None.
Changes since v1:
- None.
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-gc2235.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c | 4 ++-- drivers/staging/media/atomisp/i2c/atomisp-ov2722.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-)
drivers/staging/media/atomisp/i2c/atomisp-gc0310.c +2 -2
@@ -872,9 +872,9 @@ static int gc0310_s_power(struct v4l2_subdev *sd, int on) {int ret; -if (on ==0 ) +if (on ==0 ) {return power_down (sd); -else { + }else { ret =power_up (sd);if (!ret)return gc0310_init (sd);
drivers/staging/media/atomisp/i2c/atomisp-gc2235.c +2 -2
@@ -658,9 +658,9 @@ static int gc2235_s_power(struct v4l2_subdev *sd, int on) {int ret; -if (on ==0 ) +if (on ==0 ) { ret =power_down (sd); -else { + }else { ret =power_up (sd);if (!ret) ret =__gc2235_init (sd);
drivers/staging/media/atomisp/i2c/atomisp-mt9m114.c +2 -2
@@ -568,9 +568,9 @@ static int power_down(struct v4l2_subdev *sd)static int mt9m114_s_power (struct v4l2_subdev *sd,int power) { -if (power ==0 ) +if (power ==0 ) {return power_down (sd); -else { + }else {if (power_up (sd))return -EINVAL ;
drivers/staging/media/atomisp/i2c/atomisp-ov2722.c +2 -2
@@ -772,9 +772,9 @@ static int ov2722_s_power(struct v4l2_subdev *sd, int on) {int ret; -if (on ==0 ) +if (on ==0 ) {return power_down (sd); -else { + }else { ret =power_up (sd);if (!ret)return ov2722_init (sd);
Signature · 1 line
2.31.1
Hi Deepak,
Quoted 9 lines · Deepak R Varma
This patch set addresses multiple issues reported by of checkpatch script as WARNING and CHECK complaints. Other feedback received from the maintainers is incorporated as well.
Note:
- The patches should be applied in the ascending order.
- Patch count revised to 9 from 6
- patch 1/9 is not being sent since it was already submitted by another developer.
Then what is now the 2nd patch should have been the first. No need to resend because of just that though.
For the rest of the patches apart from 5th,
Signature · 1 line
Sakari Ailus