btrfs: commit the transaction unconditionally for ensopc
Subsystems (2)
cover btrfs: commit the transaction unconditionally for ensopc
Hello,
While debugging early ENOSPC issues in the Facebook fleet I hit a case where we weren't committing the transaction because of some patch that I hadn't backported to our kernel.
This made me think really hard about why we have may_commit_transaction, and realized that it doesn't make sense in it's current form anymore. By-in-large it just exists to have bugs in it and cause us pain. It served a purpose in the pre-ticketing days, but now just exists to be a giant pain in the ass.
So rip it out. Just commit the transaction. This also allows us to drop the logic for ->total_bytes_pinned, which Nikolay noticed a problem with earlier this week again. Thanks,
Josef Bacik (3):
btrfs: rip out may_commit_transaction
btrfs: rip the first_ticket_bytes logic from fail_all_tickets
btrfs: rip out ->total_bytes_pinned
fs/btrfs/block-group.c | 3 - fs/btrfs/ctree.h | 1 - fs/btrfs/delayed-ref.c | 26 ----- fs/btrfs/disk-io.c | 3 - fs/btrfs/extent-tree.c | 15 --- fs/btrfs/space-info.c | 178 +++-------------------------------- fs/btrfs/space-info.h | 30 ------ fs/btrfs/sysfs.c | 13 --- include/trace/events/btrfs.h | 3 +- 9 files changed, 14 insertions(+), 258 deletions(-)
Signature · 1 line
2.26.3
PATCH 1/3 btrfs: rip out may_commit_transaction
may_commit_transaction was introduced before the ticketing infrastructure existed. There was a problem where we'd legitimately be out of space, but every reservation would trigger a transaction commit and then fail. Thus if you had 1000 things trying to make a reservation, they'd all do the flushing loop and thus commit the transaction 1000 times before they'd get their ENOSPC.
This helper was introduced to short circuit this, if there wasn't space that could be reclaimed by committing the transaction then simply ENOSPC out. This made true ENOSPC tests much faster as we didn't waste a bunch of time.
However many of our bugs over the years have been from cases where we didn't account for some space that would be reclaimed by committing a transaction. The delayed refs rsv space, delayed rsv, many pinned bytes miscalculations, etc. And in the meantime the original problem has been solved with ticketing. We no longer will commit the transaction 1000 times. Instead we'll get 1000 waiters, we will go through the flushing mechanisms, and if there's no progress after 2 loops we ENOSPC everybody out. The ticketing infrastructure gives us a deterministic way to see if we're making progress or not, thus we avoid a lot of extra work.
So simplify this step by simply unconditionally committing the transaction. This removes what is arguably our most common source of early ENOSPC bugs and will allow us to drastically simplify many of the things we track because we simply won't need them with this stuff gone.
--- fs/btrfs/ctree.h | 1 - fs/btrfs/space-info.c | 155 +++-------------------------------- include/trace/events/btrfs.h | 3 +- 3 files changed, 14 insertions(+), 145 deletions(-)
fs/btrfs/ctree.h +0 -1
@@ -2793,7 +2793,6 @@ enum btrfs_flush_state {ALLOC_CHUNK_FORCE =9 ,RUN_DELAYED_IPUTS =10 , COMMIT_TRANS = 11, - FORCE_COMMIT_TRANS = 12, }; int btrfs_subvolume_reserve_metadata(struct btrfs_root *root,
fs/btrfs/space-info.c +13 -142
187 lines not on this page · raw message
include/trace/events/btrfs.h +1 -2
@@ -100,8 +100,7 @@ struct btrfs_space_info; EM( ALLOC_CHUNK, "ALLOC_CHUNK") \ EM( ALLOC_CHUNK_FORCE, "ALLOC_CHUNK_FORCE") \ EM( RUN_DELAYED_IPUTS, "RUN_DELAYED_IPUTS") \ - EM( COMMIT_TRANS, "COMMIT_TRANS") \ -EMe (FORCE_COMMIT_TRANS ,"FORCE_COMMIT_TRANS" ) +EMe (COMMIT_TRANS ,"COMMIT_TRANS" )/* * First define the enums in the above macros to be exported to userspace via
Signature · 1 line
2.26.3
Re: [PATCH 1/3] btrfs: rip out may_commit_transaction
Quoted 34 lines · Josef Bacik
may_commit_transactionwas introduced before the ticketing infrastructure existed. There was a problem where we'd legitimately be out of space, but every reservation would trigger a transaction commit and then fail. Thus if you had 1000 things trying to make a reservation, they'd all do the flushing loop and thus commit the transaction 1000 times before they'd get their ENOSPC.This helper was introduced to short circuit this, if there wasn't space that could be reclaimed by committing the transaction then simply ENOSPC out. This made true ENOSPC tests much faster as we didn't waste a bunch of time.
However many of our bugs over the years have been from cases where we didn't account for some space that would be reclaimed by committing a transaction. The delayed refs rsv space, delayed rsv, many pinned bytes miscalculations, etc. And in the meantime the original problem has been solved with ticketing. We no longer will commit the transaction 1000 times. Instead we'll get 1000 waiters, we will go through the flushing mechanisms, and if there's no progress after 2 loops we ENOSPC everybody out. The ticketing infrastructure gives us a deterministic way to see if we're making progress or not, thus we avoid a lot of extra work.
So simplify this step by simply unconditionally committing the transaction. This removes what is arguably our most common source of early ENOSPC bugs and will allow us to drastically simplify many of the things we track because we simply won't need them with this stuff gone.
Signed-off-by Josef Bacik <[email protected]>--- fs/btrfs/ctree.h | 1 - fs/btrfs/space-info.c | 155 +++-------------------------------- include/trace/events/btrfs.h | 3 +- 3 files changed, 14 insertions(+), 145 deletions(-)
<snip>
Quoted 13 lines
fs/btrfs/space-info.c +0
-9@@ -1238,31 +1128,12 @@ static void btrfs_preempt_reclaim_metadata_space(struct work_struct *work)* If we are freeing inodes, we want to make sure all delayed iputs have * completed, because they could have been on an inode with i_nlink == 0, and * thus have been truncated and freed up space. But again this space is not -* immediately re-usable, it comes in the form of a delayed ref, which must be -* run and then the transaction must be committed. -* -* FLUSH_DELAYED_REFS -* The above two cases generate delayed refs that will affect -* ->total_bytes_pinned. However this counter can be inconsistent with -* reality if there are outstanding delayed refs. This is because we adjust -* the counter based solely on the current set of delayed refs and disregard -* any on-disk state which might include more refs. So for example, if we
fs/btrfs/space-info.c static void btrfs_preempt_reclaim_metadata_space(struct work_struct *work) · line 1132
Quoted 10 lines
fs/btrfs/space-info.c +2
-8-* have an extent with 2 references, but we only drop 1, we'll see that there -* is a negative delayed ref count for the extent and assume that the space -* will be freed, and thus increase ->total_bytes_pinned. -* -* Running the delayed refs gives us the actual real view of what will be -* freed at the transaction commit time. This stage will not actually free -* space for us, it just makes sure that may_commit_transaction() has all of -* the information it needs to make the right decision. +* immediately re-usable, it will be pinned, which will be reclaimed by +* committing the transaction.
So you remove the explanation about FLUSH_DELAYED_REFS, yet it's retained as a distinct state in data flush. So perhaps it should also be removed from data_flush_state, given that transaction commit, by definition, runs delayed refs so we don't need it as a discrete step during data flush ? If I'm wrong then this state requires an updated rationale.
Quoted 13 lines
fs/btrfs/space-info.c +2
-6* * COMMIT_TRANS -* This is where we reclaim all of the pinned space generated by the previous -* two stages. We will not commit the transaction if we don't think we're -* likely to satisfy our request, which means if our current free space + -* total_bytes_pinned < reservation we will not commit. This is why the -* previous states are actually important, to make sure we know for sure -* whether committing the transaction will allow us to make progress. +* This is where we reclaim all of the pinned space generated by running +* delayed iputs. * * ALLOC_CHUNK_FORCE * For data we start with alloc chunk force, however we could have been full
<snip>
Re: [PATCH 1/3] btrfs: rip out may_commit_transaction
Quoted 61 lines · Nikolay Borisov
Quoted 34 lines · Josef Bacik
may_commit_transactionwas introduced before the ticketing infrastructure existed. There was a problem where we'd legitimately be out of space, but every reservation would trigger a transaction commit and then fail. Thus if you had 1000 things trying to make a reservation, they'd all do the flushing loop and thus commit the transaction 1000 times before they'd get their ENOSPC.This helper was introduced to short circuit this, if there wasn't space that could be reclaimed by committing the transaction then simply ENOSPC out. This made true ENOSPC tests much faster as we didn't waste a bunch of time.
However many of our bugs over the years have been from cases where we didn't account for some space that would be reclaimed by committing a transaction. The delayed refs rsv space, delayed rsv, many pinned bytes miscalculations, etc. And in the meantime the original problem has been solved with ticketing. We no longer will commit the transaction 1000 times. Instead we'll get 1000 waiters, we will go through the flushing mechanisms, and if there's no progress after 2 loops we ENOSPC everybody out. The ticketing infrastructure gives us a deterministic way to see if we're making progress or not, thus we avoid a lot of extra work.
So simplify this step by simply unconditionally committing the transaction. This removes what is arguably our most common source of early ENOSPC bugs and will allow us to drastically simplify many of the things we track because we simply won't need them with this stuff gone.
Signed-off-by Josef Bacik <[email protected]>--- fs/btrfs/ctree.h | 1 - fs/btrfs/space-info.c | 155 +++-------------------------------- include/trace/events/btrfs.h | 3 +- 3 files changed, 14 insertions(+), 145 deletions(-)<snip>
Quoted 22 lines
fs/btrfs/space-info.c +1
-17@@ -1238,31 +1128,12 @@ static void btrfs_preempt_reclaim_metadata_space(struct work_struct *work)* If we are freeing inodes, we want to make sure all delayed iputs have * completed, because they could have been on an inode with i_nlink == 0, and * thus have been truncated and freed up space. But again this space is not -* immediately re-usable, it comes in the form of a delayed ref, which must be -* run and then the transaction must be committed. -* -* FLUSH_DELAYED_REFS -* The above two cases generate delayed refs that will affect -* ->total_bytes_pinned. However this counter can be inconsistent with -* reality if there are outstanding delayed refs. This is because we adjust -* the counter based solely on the current set of delayed refs and disregard -* any on-disk state which might include more refs. So for example, if we -* have an extent with 2 references, but we only drop 1, we'll see that there -* is a negative delayed ref count for the extent and assume that the space -* will be freed, and thus increase ->total_bytes_pinned. -* -* Running the delayed refs gives us the actual real view of what will be -* freed at the transaction commit time. This stage will not actually free -* space for us, it just makes sure that may_commit_transaction() has all of -* the information it needs to make the right decision. +* immediately re-usable, it will be pinned, which will be reclaimed by
Quoted 9 lines
fs/btrfs/space-info.c static void btrfs_preempt_reclaim_metadata_space(struct work_struct *work) · line 1132
Quoted 1 line
fs/btrfs/space-info.c +1
-0+* committing the transaction. So you remove the explanation about
FLUSH_DELAYED_REFS, yet it's retained as a distinct state in data flush. So perhaps it should also be removed fromdata_flush_state, given that transaction commit, by definition, runs delayed refs so we don't need it as a discrete step during data flush ? If I'm wrong then this state requires an updated rationale.
Oops forgot to pull the flush_delayed_refs thing from the list, I'll put that in a separate patch. Thanks,
Josef
PATCH 2/3 btrfs: rip the first_ticket_bytes logic from fail_all_tickets
In reply to Josef BacikThis was a trick implemented to handle the case where we had a giant reservation in front of a bunch of little reservations in the ticket queue. If the giant reservation was too large for the transaction commit to make a difference we'd ENOSPC everybody out instead of committing the transaction. This logic was put in to force us to go back and re-try the transaction commit logic to see if we could make progress.
Instead now we know we've committed the transaction, so any space that would have been recovered is now available, and would be caught by the btrfs_try_granting_tickets() in this loop, so we no longer need this code and can simply delete it.
--- fs/btrfs/space-info.c | 16 ---------------- 1 file changed, 16 deletions(-)
fs/btrfs/space-info.c +0 -16
@@ -873,7 +873,6 @@ static bool maybe_fail_all_tickets(struct btrfs_fs_info *fs_info, {struct reserve_ticket *ticket;u64 tickets_id = space_info->tickets_id; -u64 first_ticket_bytes =0 ;if (btrfs_test_opt (fs_info,ENOSPC_DEBUG )) {btrfs_info (fs_info,"cannot satisfy tickets, dumping space info" );
@@ -889,21 +888,6 @@ static bool maybe_fail_all_tickets(struct btrfs_fs_info *fs_info, steal_from_global_rsv(fs_info, space_info, ticket))return true; -/* -* may_commit_transaction will avoid committing the transaction -* if it doesn't feel like the space reclaimed by the commit -* would result in the ticket succeeding. However if we have a -* smaller ticket in the queue it may be small enough to be -* satisified by committing the transaction, so if any -* subsequent ticket is smaller than the first ticket go ahead -* and send us back for another loop through the enospc flushing -* code. -*/ -if (first_ticket_bytes ==0 ) - first_ticket_bytes = ticket->bytes; -else if (first_ticket_bytes > ticket->bytes) -return true; -if (btrfs_test_opt (fs_info,ENOSPC_DEBUG ))btrfs_info (fs_info,"failing ticket with %llu bytes" , ticket->bytes);
Signature · 1 line
2.26.3
PATCH 3/3 btrfs: rip out ->total_bytes_pinned
In reply to Josef BacikWe used this in may_commit_transaction() in order to determine if we needed to commit the transaction. However we no longer have that logic and thus have no use of this counter anymore, so delete it.
--- fs/btrfs/block-group.c | 3 --- fs/btrfs/delayed-ref.c | 26 -------------------------- fs/btrfs/disk-io.c | 3 --- fs/btrfs/extent-tree.c | 15 --------------- fs/btrfs/space-info.c | 7 ------- fs/btrfs/space-info.h | 30 ------------------------------ fs/btrfs/sysfs.c | 13 ------------- 7 files changed, 97 deletions(-)
fs/btrfs/block-group.c +0 -3
@@ -1399,7 +1399,6 @@ void btrfs_delete_unused_bgs(struct btrfs_fs_info *fs_info)btrfs_space_info_update_bytes_pinned (fs_info, space_info, -block_group->pinned); space_info->bytes_readonly += block_group->pinned; -__btrfs_mod_total_bytes_pinned (space_info, -block_group->pinned); block_group->pinned =0 ;spin_unlock (&block_group->lock);
@@ -3062,8 +3061,6 @@ int btrfs_update_block_group(struct btrfs_trans_handle *trans,spin_unlock (&cache->lock);spin_unlock (&cache->space_info->lock); -__btrfs_mod_total_bytes_pinned (cache->space_info, - num_bytes);set_extent_dirty (&trans->transaction->pinned_extents, bytenr, bytenr + num_bytes -1 ,GFP_NOFS | __GFP_NOFAIL);
fs/btrfs/delayed-ref.c +0 -26
@@ -641,7 +641,6 @@ static noinline void update_existing_head_ref(struct btrfs_trans_handle *trans,struct btrfs_delayed_ref_root *delayed_refs = &trans->transaction->delayed_refs;struct btrfs_fs_info *fs_info = trans->fs_info; -u64 flags =btrfs_ref_head_to_space_flags (existing);int old_ref_mod;BUG_ON (existing->is_data != update->is_data);
@@ -711,26 +710,6 @@ static noinline void update_existing_head_ref(struct btrfs_trans_handle *trans, } } -/* -* This handles the following conditions: -* -* 1. We had a ref mod of 0 or more and went negative, indicating that -* we may be freeing space, so add our space to the -* total_bytes_pinned counter. -* 2. We were negative and went to 0 or positive, so no longer can say -* that the space would be pinned, decrement our counter from the -* total_bytes_pinned counter. -* 3. We are now at 0 and have ->must_insert_reserved set, which means -* this was a new allocation and then we dropped it, and thus must -* add our space to the total_bytes_pinned counter. -*/ -if (existing->total_ref_mod <0 && old_ref_mod >=0 ) -btrfs_mod_total_bytes_pinned (fs_info, flags, existing->num_bytes); -else if (existing->total_ref_mod >=0 && old_ref_mod <0 ) -btrfs_mod_total_bytes_pinned (fs_info, flags, -existing->num_bytes); -else if (existing->total_ref_mod ==0 && existing->must_insert_reserved) -btrfs_mod_total_bytes_pinned (fs_info, flags, existing->num_bytes); -spin_unlock (&existing->lock); }
@@ -835,17 +814,12 @@ add_delayed_ref_head(struct btrfs_trans_handle *trans,kmem_cache_free (btrfs_delayed_ref_head_cachep, head_ref); head_ref = existing; }else { -u64 flags =btrfs_ref_head_to_space_flags (head_ref); -if (head_ref->is_data && head_ref->ref_mod <0 ) { delayed_refs->pending_csums += head_ref->num_bytes; trans->delayed_ref_updates +=btrfs_csum_bytes_to_leaves (trans->fs_info, head_ref->num_bytes); } -if (head_ref->ref_mod <0 ) -btrfs_mod_total_bytes_pinned (trans->fs_info, flags, - head_ref->num_bytes); delayed_refs->num_heads++; delayed_refs->num_heads_ready++;atomic_inc (&delayed_refs->num_entries);
fs/btrfs/disk-io.c +0 -3
@@ -4696,9 +4696,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, cache->space_info->bytes_reserved -= head->num_bytes;spin_unlock (&cache->lock);spin_unlock (&cache->space_info->lock); -percpu_counter_add_batch ( - &cache->space_info->total_bytes_pinned, - head->num_bytes,BTRFS_TOTAL_BYTES_PINNED_BATCH );btrfs_put_block_group (cache);
fs/btrfs/extent-tree.c +0 -15
@@ -1804,19 +1804,6 @@ void btrfs_cleanup_ref_head_accounting(struct btrfs_fs_info *fs_info, nr_items +=btrfs_csum_bytes_to_leaves (fs_info, head->num_bytes); } -/* -* We were dropping refs, or had a new ref and dropped it, and thus must -* adjust down our total_bytes_pinned, the space may or may not have -* been pinned and so is accounted for properly in the pinned space by -* now. -*/ -if (head->total_ref_mod <0 || - (head->total_ref_mod ==0 && head->must_insert_reserved)) { -u64 flags =btrfs_ref_head_to_space_flags (head); - -btrfs_mod_total_bytes_pinned (fs_info, flags, -head->num_bytes); - } -btrfs_delayed_refs_rsv_release (fs_info, nr_items); }
@@ -2551,7 +2538,6 @@ static int pin_down_extent(struct btrfs_trans_handle *trans,spin_unlock (&cache->lock);spin_unlock (&cache->space_info->lock); -__btrfs_mod_total_bytes_pinned (cache->space_info, num_bytes);set_extent_dirty (&trans->transaction->pinned_extents, bytenr, bytenr + num_bytes -1 ,GFP_NOFS | __GFP_NOFAIL);return 0 ;
@@ -2762,7 +2748,6 @@ static int unpin_extent_range(struct btrfs_fs_info *fs_info, cache->pinned -= len;btrfs_space_info_update_bytes_pinned (fs_info, space_info, -len); space_info->max_extent_size =0 ; -__btrfs_mod_total_bytes_pinned (space_info, -len);if (cache->ro) { space_info->bytes_readonly += len; readonly = true;
fs/btrfs/space-info.c +0 -7
@@ -192,13 +192,6 @@ static int create_space_info(struct btrfs_fs_info *info, u64 flags)if (!space_info)return -ENOMEM ; - ret =percpu_counter_init (&space_info->total_bytes_pinned,0 , -GFP_KERNEL ); -if (ret) { -kfree (space_info); -return ret; - } -for (i =0 ; i <BTRFS_NR_RAID_TYPES ; i++)INIT_LIST_HEAD (&space_info->block_groups[i]);init_rwsem (&space_info->groups_sem);
fs/btrfs/space-info.h +0 -30
@@ -43,18 +43,6 @@ struct btrfs_space_info {u64 flags; -/* -* bytes_pinned is kept in line with what is actually pinned, as in -* we've called update_block_group and dropped the bytes_used counter -* and increased the bytes_pinned counter. However this means that -* bytes_pinned does not reflect the bytes that will be pinned once the -* delayed refs are flushed, so this counter is inc'ed every time we -* call btrfs_free_extent so it is a realtime count of what will be -* freed once the transaction is committed. It will be zeroed every -* time the transaction commits. -*/ -struct percpu_counter total_bytes_pinned; -struct list_head list;/* Protected by the spinlock 'lock'. */ struct list_head ro_bgs;
@@ -163,22 +151,4 @@ static inline void btrfs_space_info_free_bytes_may_use( }int btrfs_reserve_data_bytes (struct btrfs_fs_info *fs_info,u64 bytes,enum btrfs_reserve_flush_enum flush); - -static inline void __btrfs_mod_total_bytes_pinned ( -struct btrfs_space_info *space_info, -s64 mod) -{ -percpu_counter_add_batch (&space_info->total_bytes_pinned, mod, -BTRFS_TOTAL_BYTES_PINNED_BATCH ); -} - -static inline void btrfs_mod_total_bytes_pinned (struct btrfs_fs_info *fs_info, -u64 flags,s64 mod) -{ -struct btrfs_space_info *space_info =btrfs_find_space_info (fs_info, flags); - -ASSERT (space_info); -__btrfs_mod_total_bytes_pinned (space_info, mod); -} -#endif /* BTRFS_SPACE_INFO_H */
fs/btrfs/sysfs.c +0 -13
@@ -665,15 +665,6 @@ static ssize_t btrfs_space_info_show_##field(struct kobject *kobj, \ } \ BTRFS_ATTR(space_info, field, btrfs_space_info_show_##field) -static ssize_t btrfs_space_info_show_total_bytes_pinned (struct kobject *kobj, -struct kobj_attribute *a, -char *buf) -{ -struct btrfs_space_info *sinfo =to_space_info (kobj); -s64 val =percpu_counter_sum (&sinfo->total_bytes_pinned); -return scnprintf (buf,PAGE_SIZE ,"%lld\n" , val); -} -static ssize_t btrfs_space_info_show_enospc_events (struct kobject *kobj,struct kobj_attribute *a,char *buf)
@@ -693,8 +684,6 @@ SPACE_INFO_ATTR(bytes_readonly);SPACE_INFO_ATTR (bytes_zone_unusable);SPACE_INFO_ATTR (disk_used);SPACE_INFO_ATTR (disk_total); -BTRFS_ATTR (space_info, total_bytes_pinned, - btrfs_space_info_show_total_bytes_pinned);BTRFS_ATTR (space_info, enospc_events, btrfs_space_info_show_enospc_events);
@@ -709,7 +698,6 @@ static struct attribute *space_info_attrs[] = {BTRFS_ATTR_PTR (space_info, bytes_zone_unusable),BTRFS_ATTR_PTR (space_info, disk_used),BTRFS_ATTR_PTR (space_info, disk_total), -BTRFS_ATTR_PTR (space_info, total_bytes_pinned),BTRFS_ATTR_PTR (space_info, enospc_events), NULL, };
@@ -718,7 +706,6 @@ ATTRIBUTE_GROUPS(space_info);static void space_info_release (struct kobject *kobj) {struct btrfs_space_info *sinfo =to_space_info (kobj); -percpu_counter_destroy (&sinfo->total_bytes_pinned);kfree (sinfo); }
Signature · 1 line
2.26.3
Quoted 20 lines · Josef Bacik
Hello,
While debugging early ENOSPC issues in the Facebook fleet I hit a case where we weren't committing the transaction because of some patch that I hadn't backported to our kernel.
This made me think really hard about why we have
may_commit_transaction, and realized that it doesn't make sense in it's current form anymore. By-in-large it just exists to have bugs in it and cause us pain. It served a purpose in the pre-ticketing days, but now just exists to be a giant pain in the ass.So rip it out. Just commit the transaction. This also allows us to drop the logic for ->total_bytes_pinned, which Nikolay noticed a problem with earlier this week again. Thanks,
Josef Bacik (3):
btrfs: rip outmay_commit_transaction
btrfs: rip thefirst_ticket_byteslogic fromfail_all_tickets
btrfs: rip out ->total_bytes_pinned
Quoted 11 lines
fs/btrfs/block-group.c | 3 - fs/btrfs/ctree.h | 1 - fs/btrfs/delayed-ref.c | 26 ----- fs/btrfs/disk-io.c | 3 - fs/btrfs/extent-tree.c | 15 --- fs/btrfs/space-info.c | 178 +++-------------------------------- fs/btrfs/space-info.h | 30 ------ fs/btrfs/sysfs.c | 13 --- include/trace/events/btrfs.h | 3 +- 9 files changed, 14 insertions(+), 258 deletions(-)
For patches 2-3:
Patch is also fine apart from the minor nit about the undocumented FLUSH_DELAYED_REFS when flushing data space.
Quoted 11 lines · Josef Bacik
Hello,
While debugging early ENOSPC issues in the Facebook fleet I hit a case where we weren't committing the transaction because of some patch that I hadn't backported to our kernel.
This made me think really hard about why we have
may_commit_transaction, and realized that it doesn't make sense in it's current form anymore. By-in-large it just exists to have bugs in it and cause us pain. It served a purpose in the pre-ticketing days, but now just exists to be a giant pain in the ass.
Quoted 8 lines
So rip it out. Just commit the transaction. This also allows us to drop the logic for ->total_bytes_pinned, which Nikolay noticed a problem with earlier this week again. Thanks,
Josef Bacik (3):
btrfs: rip outmay_commit_transaction
btrfs: rip thefirst_ticket_byteslogic fromfail_all_tickets
btrfs: rip out ->total_bytes_pinned
For the record, this has been picked before merge and is now in 5.14-rc.