staging: rtl8723bs: remove unused functions

Changes in v3:
- Fix issue causing some emails to drop their In-Reply-To: header.

(For the curious: NullMailer & my email provider where conspiring)

Changes in v2:
- Remove build warnings I introduced in the previous version.

***

There is a lot of un-used code and un-needed abstractions leftover in this driver from when (I assume) it could be compiled on more than one kernel.

This series removes dead code and is one small step toward refactoring how this driver interacts with the SDIO subsystem.

Bryan Brattlof (5):
staging: rtl8723bs: remove sdio_write_mem()
staging: rtl8723bs: remove sdio_writeN()
staging: rtl8723bs: remove sdio_read_mem() and sdio_readN()
staging: rtl8723bs: remove unused definitions from rtw_io.h
staging: rtl8723bs: remove _read_port from _io_ops structure

 drivers/staging/rtl8723bs/hal/sdio_ops.c   | 116 ---------------------
 drivers/staging/rtl8723bs/include/rtw_io.h |  96 -----------------
 2 files changed, 212 deletions(-)

--
2.30.2

The sdio_write_mem() function is unused in the driver. We can remove it.

---
 drivers/staging/rtl8723bs/hal/sdio_ops.c   | 11 -----------
 drivers/staging/rtl8723bs/include/rtw_io.h |  1 -
 2 files changed, 12 deletions(-)

index a545832a468e..b784a390c8e1 100644
@@ -356,16 +356,6 @@ static void sdio_read_mem(
 	sdio_readN(intfhdl, addr, cnt, rmem);
 }
 
-static void sdio_write_mem(
-	struct intf_hdl *intfhdl,
-	u32 addr,
-	u32 cnt,
-	u8 *wmem
-)
-{
-	sdio_writeN(intfhdl, addr, cnt, wmem);
-}
-
 /*
  * Description:
  *Read from RX FIFO

@@ -474,7 +464,6 @@ void sdio_set_intf_ops(struct adapter *adapter, struct _io_ops *ops)
 	ops->_write16 = &sdio_write16;
 	ops->_write32 = &sdio_write32;
 	ops->_writeN = &sdio_writeN;
-	ops->_write_mem = &sdio_write_mem;
 	ops->_write_port = &sdio_write_port;
 }
 

index e98083a07a66..87f36b7e880f 100644
@@ -91,7 +91,6 @@ struct _io_ops {
 		int (*_write32_async)(struct intf_hdl *pintfhdl, u32 addr, u32 val);
 
 		void (*_read_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
-		void (*_write_mem)(struct intf_hdl *pintfhdl, u32 addr, u32 cnt, u8 *pmem);
 
 		void (*_sync_irp_protocol_rw)(struct io_queue *pio_q);
 

--
2.30.2

Sorry for the noise Greg,

On this day, August 27, 2021 thus sayeth Bryan Brattlof:

This turns out to be untrue :(

I've been testing my git-send-email setup on some friends without issue. Somewhere between me and the mailing list In-Reply-To: headers are being dropped.

I'll be back, but you can safely drop any patches from me today :(

Again sorry for the noise

~Bryan

Did not quite work, see:

	https://lore.kernel.org/r/[email protected]

as proof that only this message, and 1/5 were linked together.

The other 4 were out on their own :(

Also, there was no "v3" in the subject line as the documentation asks for :(

v4 please?

thanks,

greg k-h

THis changed from the previous version in ways you did not document anywhere. Please fix up in your v4 notes.