Skip to contentSkip to conversation

quick man fixes

PATCH Applied Pavel Begunkov 2 participants 4 messages Aug 28, 2021 io_uring

lore
Share & tools
lore
#0 lore raw

cover quick man fixes

Clarify details on registration quiesce.

Pavel Begunkov (2):
man: fix io_uring_sqe alignment
man: update notes on register quiesce

 man/io_uring_enter.2    | 10 +++++-----
 man/io_uring_register.2 | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)
Signature · 1 line
2.33.0
#1 lore raw

PATCH 1/2 man: fix io_uring_sqe alignment

Tabs make man to go crazy, replace them with spaces where it haven't been done yet.

---
 man/io_uring_enter.2 | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
man/io_uring_enter.2 +5 -5
index 00f0778..fc81099 100644
@@ -162,18 +162,18 @@ struct io_uring_sqe {
     };
     __u64    user_data;     /* data to be passed back at completion time */
     union {
-	struct {
-	    /* index into fixed buffers, if used */
+    struct {
+        /* index into fixed buffers, if used */
             union {
                 /* index into fixed buffers, if used */
                 __u16    buf_index;
                 /* for grouped buffer selection */
                 __u16    buf_group;
             }
-	    /* personality to use, if used */
-	    __u16    personality;
+        /* personality to use, if used */
+        __u16    personality;
             __s32    splice_fd_in;
-	};
+    };
         __u64    __pad2[3];
     };
 };
Signature · 1 line
2.33.0
#2 lore raw

PATCH 2/2 man: update notes on register quiesce

In reply to Pavel Begunkov

We don't quiesce rsrc registrations since 5.13, reflect it in the man.

---
 man/io_uring_register.2 | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
man/io_uring_register.2 +6 -6
index 5326a87..a8479fd 100644
@@ -88,9 +88,9 @@ then issuing a new call to
 .BR io_uring_register ()
 with the new buffers.
 
-Note that registering buffers will wait for the ring to idle. If the application
-currently has requests in-flight, the registration will wait for those to
-finish before proceeding.
+Note that before 5.13 registering buffers would wait for the ring to idle.
+If the application currently has requests in-flight, the registration will
+wait for those to finish before proceeding.
 
 An application need not unregister buffers explicitly before shutting
 down the io_uring instance. Available since 5.1.
@@ -128,9 +128,9 @@ See
 .B IORING_REGISTER_FILES_UPDATE
 for how to update files in place.
 
-Note that registering files will wait for the ring to idle. If the application
-currently has requests in-flight, the registration will wait for those to
-finish before proceeding. See
+Note that before 5.13 registering files would wait for the ring to idle.
+If the application currently has requests in-flight, the registration will
+wait for those to finish before proceeding. See
 .B IORING_REGISTER_FILES_UPDATE
 for how to update an existing set without that limitation.
 
Signature · 1 line
2.33.0
maintainer Applied
#3 lore raw
In reply to Pavel Begunkov
Quoted 9 lines · Pavel Begunkov

Clarify details on registration quiesce.

Pavel Begunkov (2):
man: fix io_uring_sqe alignment
man: update notes on register quiesce

 man/io_uring_enter.2    | 10 +++++-----
 man/io_uring_register.2 | 12 ++++++------
 2 files changed, 11 insertions(+), 11 deletions(-)

Applied, thanks.

Signature · 1 line
Jens Axboe