Skip to contentSkip to conversation

Linux v5.4.143-rt64-rc2

PATCH New [email protected] 1 participant 4 messages Sep 7, 2021 Locking primitives

lore
Share & tools
lore
#0 lore raw

cover Linux v5.4.143-rt64-rc2

From: Tom Zanussi <[email protected]>

Dear RT Folks,

This is the RT stable review cycle of patch 5.4.143-rt64-rc2.

Please scream at me if I messed something up. Please test the patches too.

The -rc release will be uploaded to kernel.org and will be deleted when the final release is out. This is just a review release (or release candidate).

The pre-releases will not be pushed to the git repository, only the final release is.

If all goes well, this patch will be converted to the next main release on 2021-09-10.

To build 5.4.143-rt64-rc2 directly, the following patches should be applied:

https://www.kernel.org/pub/linux/kernel/v5.x/linux-5.4.tar.xz

https://www.kernel.org/pub/linux/kernel/v5.x/patch-5.4.143.xz

https://www.kernel.org/pub/linux/kernel/projects/rt/5.4/patch-5.4.143-rt64-rc2.patch.xz

You can also build from 5.4.143-rt63 by applying the incremental patch:

https://www.kernel.org/pub/linux/kernel/projects/rt/5.4/incr/patch-5.4.143-rt63-rt64-rc2.patch.xz

Enjoy,

-- Tom

Andrew Halaney (1):
locking/rwsem-rt: Remove might_sleep() in __up_read()

Gregor Beck (1):
fscache: fix initialisation of cookie hash table raw spinlocks

Tom Zanussi (1):
Linux 5.4.143-rt64-rc2

 fs/fscache/cookie.c       | 2 +-
 kernel/locking/rwsem-rt.c | 1 -
 localversion-rt           | 2 +-
 3 files changed, 2 insertions(+), 3 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 locking/rwsem-rt: Remove might_sleep() in __up_read()

From: Andrew Halaney <[email protected]>

v5.4.143-rt64-rc2 stable review patch.
If anyone has any objections, please let me know.

-----------

[ Upstream commit b2ed0a4302faf2bb09e97529dd274233c082689b ]

There's no chance of sleeping here, the reader is giving up the lock and possibly waking up the writer who is waiting on it.

---
 kernel/locking/rwsem-rt.c | 1 -
 1 file changed, 1 deletion(-)
kernel/locking/rwsem-rt.c +0 -1
index 19ea20be3fd7..966946454ced 100644
@@ -200,7 +200,6 @@ void __up_read(struct rw_semaphore *sem)
 	if (!atomic_dec_and_test(&sem->readers))
 		return;
 
-	might_sleep();
 	raw_spin_lock_irq(&m->wait_lock);
 	/*
 	 * Wake the writer, i.e. the rtmutex owner. It might release the
Signature · 1 line
2.17.1
#2 lore raw

PATCH 2/3 fscache: fix initialisation of cookie hash table raw spinlocks

In reply to [email protected]

From: Gregor Beck <[email protected]>

v5.4.143-rt64-rc2 stable review patch.
If anyone has any objections, please let me know.

-----------

The original patch, 602660600bcd ("fscache: initialize cookie hash table raw spinlocks"), subtracted 1 from the shift and so still left some spinlocks uninitialized. This fixes that.

[zanussi: Added changelog text]

Fixes 602660600bcd ("fscache: initialize cookie hash table raw spinlocks")
---
 fs/fscache/cookie.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/fscache/cookie.c +1 -1
index 5508d92e3f8f..cba2a226897f 100644
@@ -963,6 +963,6 @@ void __init fscache_cookie_init(void)
 {
 	int i;
 
-	for (i = 0; i < (1 << fscache_cookie_hash_shift) - 1; i++)
+	for (i = 0; i < ARRAY_SIZE(fscache_cookie_hash); i++)
 		INIT_HLIST_BL_HEAD(&fscache_cookie_hash[i]);
 }
Signature · 1 line
2.17.1