Skip to contentSkip to conversation

Return actual submission methods from submission method functions

PATCH In review Ashutosh Dixit 3 participants 11 messages Oct 28, 2021 – Nov 2, 2021

lore
Share & tools
lore
#0 lore raw

cover Return actual submission methods from submission method functions

Change submission method functions to return actual submission method in use in the kernel. Also change these function names to reflect this change in functionality. While at this also fix gem_ctx_shared/disjoint_timelines test requirements.

Ashutosh Dixit (3):
lib/i915: Return actual submission method from gem_submission_method lib/i915: Clarify gem_submission function names tests/gem_ctx_shared: Fix disjoint_timelines test requirements

 lib/i915/gem_scheduler.c    |  2 +-
 lib/i915/gem_submission.c   | 16 ++++++++--------
 lib/i915/gem_submission.h   |  6 +++---
 tests/i915/gem_ctx_shared.c |  2 +-
 tests/i915/gem_exec_fair.c  |  2 +-
 tests/i915/gem_watchdog.c   |  2 +-
 6 files changed, 15 insertions(+), 15 deletions(-)
Signature · 1 line
2.33.0
#1 lore raw

PATCH 1/3 lib/i915: Return actual submission method from gem_submission_method

gem_submission_method() purports to return the currently used submission method by the kernel, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
new code equivalent to the previous code.
v3: Clarify that submission method is either guc (0x4), execlists (0x2) or

    legacy without semaphores (0x0) or legacy with semaphores (0x1)
---
 lib/i915/gem_submission.c   | 10 +++++-----
 tests/i915/gem_ctx_shared.c |  2 +-
 tests/i915/gem_watchdog.c   |  2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)
lib/i915/gem_submission.c +5 -5
index 2627b802cfb..6fe7112d958 100644
@@ -77,7 +77,7 @@ static bool has_semaphores(int fd, int dir)
 unsigned gem_submission_method(int fd)
 {
 	const int gen = intel_gen(intel_get_drm_devid(fd));
-	unsigned flags = 0;
+	unsigned method = 0;
 
 	int dir;
 
@@ -86,21 +86,21 @@ unsigned gem_submission_method(int fd)
 		return 0;
 
 	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
-		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
+		method = GEM_SUBMISSION_GUC;
 		goto out;
 	}
 
 	if (gen >= 8) {
-		flags |= GEM_SUBMISSION_EXECLISTS;
+		method = GEM_SUBMISSION_EXECLISTS;
 		goto out;
 	}
 
 	if (has_semaphores(fd, dir))
-		flags |= GEM_SUBMISSION_SEMAPHORES;
+		method = GEM_SUBMISSION_SEMAPHORES;
 
 out:
 	close(dir);
-	return flags;
+	return method;
 }
 
 /**
tests/i915/gem_ctx_shared.c +1 -1
index ea1b5dd1b8c..f50ef13263f 100644
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
 	uint32_t plug;
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
 	/*
 	 * Each context, although they share a vm, are expected to be
tests/i915/gem_watchdog.c +1 -1
index db562335a2a..21c7710a806 100644
@@ -222,7 +222,7 @@ static void virtual(int i915, const intel_ctx_cfg_t *base_cfg)
 	const intel_ctx_t *ctx[num_engines];
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
 	igt_debug("%u virtual engines\n", num_engines);
 	igt_require(num_engines);
Signature · 1 line
2.33.0
#7 lore raw

PATCH 2/3 lib/i915: Clarify gem_submission function names

In reply to Ashutosh Dixit

The function names gem_has_guc_submission, gem_has_execlists and gem_has_semaphores are ambiguous. After "lib/i915: Return actual submission method from gem_submission_method" these functions return which submission method the kernel is actually using, not merely one which is present (e.g. execlist submission is present on all kernels on which GuC submission is present).

Therefore change the function names to clarify that they return the actual submission method being used, not merely one which is present.

---
 lib/i915/gem_scheduler.c    | 2 +-
 lib/i915/gem_submission.c   | 6 +++---
 lib/i915/gem_submission.h   | 6 +++---
 tests/i915/gem_ctx_shared.c | 2 +-
 tests/i915/gem_exec_fair.c  | 2 +-
 tests/i915/gem_watchdog.c   | 2 +-
 6 files changed, 10 insertions(+), 10 deletions(-)
lib/i915/gem_scheduler.c +1 -1
index cdddf42ad2b..bec9f0cda2e 100644
@@ -145,7 +145,7 @@ bool gem_scheduler_has_timeslicing(int fd)
 		 I915_SCHEDULER_CAP_SEMAPHORES)) ==
 		(I915_SCHEDULER_CAP_PREEMPTION |
 		I915_SCHEDULER_CAP_SEMAPHORES))
-		|| gem_has_guc_submission(fd));
+		|| gem_using_guc_submission(fd));
 }
 
 /**
lib/i915/gem_submission.c +3 -3
index 6fe7112d958..afdaf214192 100644
@@ -139,7 +139,7 @@ void gem_submission_print_method(int fd)
  * Feature test macro to query whether the driver is using semaphores for
  * synchronization between engines.
  */
-bool gem_has_semaphores(int fd)
+bool gem_using_semaphores(int fd)
 {
 	return gem_submission_method(fd) & GEM_SUBMISSION_SEMAPHORES;
 }
@@ -151,7 +151,7 @@ bool gem_has_semaphores(int fd)
  * Feature test macro to query whether the driver is using execlists as a
  * hardware submission method.
  */
-bool gem_has_execlists(int fd)
+bool gem_using_execlists(int fd)
 {
 	return gem_submission_method(fd) & GEM_SUBMISSION_EXECLISTS;
 }
@@ -163,7 +163,7 @@ bool gem_has_execlists(int fd)
  * Feature test macro to query whether the driver is using the GuC as a
  * hardware submission method.
  */
-bool gem_has_guc_submission(int fd)
+bool gem_using_guc_submission(int fd)
 {
 	return gem_submission_method(fd) & GEM_SUBMISSION_GUC;
 }
lib/i915/gem_submission.h +3 -3
index 38dd24a99a4..5ecade25f46 100644
@@ -33,9 +33,9 @@
 #define GEM_SUBMISSION_GUC		(1 << 2)
 unsigned gem_submission_method(int fd);
 void gem_submission_print_method(int fd);
-bool gem_has_semaphores(int fd);
-bool gem_has_execlists(int fd);
-bool gem_has_guc_submission(int fd);
+bool gem_using_semaphores(int fd);
+bool gem_using_execlists(int fd);
+bool gem_using_guc_submission(int fd);
 bool gem_engine_has_mutable_submission(int fd, unsigned int engine);
 bool gem_class_has_mutable_submission(int fd, int class);
 
tests/i915/gem_ctx_shared.c +1 -1
index f50ef13263f..849713ff32f 100644
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
 	uint32_t plug;
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
+	igt_require(gem_using_execlists(i915) || gem_using_guc_submission(i915));
 
 	/*
 	 * Each context, although they share a vm, are expected to be
tests/i915/gem_exec_fair.c +1 -1
index 2aa2bdebed5..935f9c4a0bc 100644
@@ -1318,7 +1318,7 @@ igt_main
 		 * These tests are for a specific scheduling model which is
 		 * not currently implemented by GuC. So skip on GuC platforms.
 		 */
-		igt_require(!gem_has_guc_submission(i915));
+		igt_require(!gem_using_guc_submission(i915));
 
 		cfg = intel_ctx_cfg_all_physical(i915);
 
tests/i915/gem_watchdog.c +1 -1
index 21c7710a806..a9d7f9da7fe 100644
@@ -222,7 +222,7 @@ static void virtual(int i915, const intel_ctx_cfg_t *base_cfg)
 	const intel_ctx_t *ctx[num_engines];
 	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
+	igt_require(gem_using_execlists(i915) || gem_using_guc_submission(i915));
 
 	igt_debug("%u virtual engines\n", num_engines);
 	igt_require(num_engines);
Signature · 1 line
2.33.0
#8 lore raw

PATCH 3/3 tests/gem_ctx_shared: Fix disjoint_timelines test requirements

In reply to Ashutosh Dixit

Use gem_uses_ppgtt() for create vm and gem_scheduler_enabled() for context re-ordering.

---
 tests/i915/gem_ctx_shared.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/i915/gem_ctx_shared.c +1 -1
index 849713ff32f..670452f97fd 100644
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
 	uint32_t plug;
 	uint64_t ahnd;
 
-	igt_require(gem_using_execlists(i915) || gem_using_guc_submission(i915));
+	igt_require(gem_uses_ppgtt(i915) && gem_scheduler_enabled(i915));
 
 	/*
 	 * Each context, although they share a vm, are expected to be
Signature · 1 line
2.33.0
#9 lore raw

[igt-dev] ✓ Fi.CI.BAT: success for Return actual submission methods from submission method functions

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: Return actual submission methods from submission method functions
URL : https://patchwork.freedesktop.org/series/96370/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10802 -> IGTPW_6358
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/index.html

Participating hosts (35 -> 33)
------------------------------

Additional (1): fi-tgl-1115g4
Missing (3): fi-bsw-cyan bat-dg1-6 bat-adlp-4

Known issues
------------

Here are the changes found in IGTPW_6358 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@query-info:
- fi-tgl-1115g4: NOTRUN -> [SKIP][1] ([fdo#109315])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@amdgpu/[email protected]

* igt@amdgpu/amd_cs_nop@nop-gfx0:
- fi-tgl-1115g4: NOTRUN -> [SKIP][2] ([fdo#109315] / [i915#2575]) +16 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@amdgpu/[email protected]

* igt@gem_huc_copy@huc-copy:
- fi-tgl-1115g4: NOTRUN -> [SKIP][3] ([i915#2190])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@[email protected]

* igt@i915_pm_backlight@basic-brightness:
- fi-tgl-1115g4: NOTRUN -> [SKIP][4] ([i915#1155])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-kefka: [PASS][5] -> [INCOMPLETE][6] ([i915#2940])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/fi-bsw-kefka/igt@i915_selftest@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-bsw-kefka/igt@i915_selftest@[email protected]

* igt@kms_chamelium@common-hpd-after-suspend:
- fi-tgl-1115g4: NOTRUN -> [SKIP][7] ([fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-tgl-1115g4: NOTRUN -> [SKIP][8] ([i915#4103]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-tgl-1115g4: NOTRUN -> [SKIP][9] ([fdo#109285])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@[email protected]

* igt@kms_psr@primary_mmap_gtt:
- fi-tgl-1115g4: NOTRUN -> [SKIP][10] ([i915#1072]) +3 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html

* igt@prime_vgem@basic-userptr:
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#3301])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-tgl-1115g4/igt@[email protected]

* igt@runner@aborted:
- fi-bsw-kefka: NOTRUN -> [FAIL][12] ([fdo#109271] / [i915#1436] / [i915#2722] / [i915#3428] / [i915#4312])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/fi-bsw-kefka/igt@[email protected]

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2722]: https://gitlab.freedesktop.org/drm/intel/issues/2722
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_6262 -> IGTPW_6358

CI-20190529: 20190529
CI_DRM_10802: 91f9ec61fdacc648fe6bc3abbb3c09701ac7f407 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6358: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/index.html
IGT_6262: d1c793b26e31cc6ae3f9fa3239805a9bbcc749fb @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/index.html

#10 lore raw

[igt-dev] ✓ Fi.CI.IGT: success for Return actual submission methods from submission method functions

In reply to Ashutosh Dixit
== Series Details ==

== Series Details ==

Series: Return actual submission methods from submission method functions
URL : https://patchwork.freedesktop.org/series/96370/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_10802_full -> IGTPW_6358_full
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/index.html

Participating hosts (10 -> 7)
------------------------------

Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005

Known issues
------------

Here are the changes found in IGTPW_6358_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-iclb: NOTRUN -> [DMESG-WARN][1] ([i915#3002])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb7/igt@[email protected]
- shard-snb: NOTRUN -> [DMESG-WARN][2] ([i915#3002])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-snb2/igt@[email protected]
- shard-kbl: NOTRUN -> [DMESG-WARN][3] ([i915#3002])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl4/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][4] ([i915#3002])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb5/igt@[email protected]
- shard-glk: NOTRUN -> [DMESG-WARN][5] ([i915#3002])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk7/igt@[email protected]
- shard-apl: NOTRUN -> [DMESG-WARN][6] ([i915#3002])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl1/igt@[email protected]

* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: [PASS][7] -> [FAIL][8] ([i915#2410])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-tglb5/igt@[email protected]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb2/igt@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-iclb: [PASS][9] -> [TIMEOUT][10] ([i915#2369] / [i915#2481] / [i915#3070])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb8/igt@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb3/igt@[email protected]

* igt@gem_exec_fair@basic-deadline:
- shard-kbl: NOTRUN -> [FAIL][11] ([i915#2846])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl1/igt@[email protected]
- shard-glk: NOTRUN -> [FAIL][12] ([i915#2846])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk7/igt@[email protected]

* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-kbl: NOTRUN -> [FAIL][13] ([i915#2842])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@rcs0:
- shard-kbl: [PASS][14] -> [SKIP][15] ([fdo#109271]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-kbl3/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vcs0:
- shard-glk: [PASS][16] -> [FAIL][17] ([i915#2842]) +1 similar issue
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-glk8/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk9/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-tglb: [PASS][18] -> [FAIL][19] ([i915#2842]) +1 similar issue
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-tglb5/igt@gem_exec_fair@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-iclb: NOTRUN -> [FAIL][20] ([i915#2849])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_params@rsvd2-dirt:
- shard-tglb: NOTRUN -> [SKIP][21] ([fdo#109283])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb7/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][22] ([fdo#109283])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb8/igt@[email protected]

* igt@gem_huc_copy@huc-copy:
- shard-kbl: NOTRUN -> [SKIP][23] ([fdo#109271] / [i915#2190])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl3/igt@[email protected]

* igt@gem_pxp@create-protected-buffer:
- shard-snb: NOTRUN -> [SKIP][24] ([fdo#109271]) +19 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-snb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][25] ([i915#4270]) +1 similar issue
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb5/igt@[email protected]

* igt@gem_pxp@fail-invalid-protected-context:
- shard-tglb: NOTRUN -> [SKIP][26] ([i915#4270]) +2 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb5/igt@[email protected]

* igt@gem_userptr_blits@coherency-sync:
- shard-tglb: NOTRUN -> [SKIP][27] ([fdo#110542])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb6/igt@[email protected]

* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][28] ([i915#2856]) +1 similar issue
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb6/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][29] ([i915#2856])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb7/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][30] -> [FAIL][31] ([i915#454])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb5/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb5/igt@[email protected]

* igt@i915_pm_dc@dc9-dpms:
- shard-apl: [PASS][32] -> [SKIP][33] ([fdo#109271])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-apl2/igt@[email protected]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl4/igt@[email protected]

* igt@i915_pm_rc6_residency@media-rc6-accuracy:
- shard-tglb: NOTRUN -> [SKIP][34] ([fdo#109289] / [fdo#111719])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb7/igt@[email protected]

* igt@i915_pm_rpm@modeset-non-lpsp-stress-no-wait:
- shard-tglb: NOTRUN -> [SKIP][35] ([fdo#111644] / [i915#1397] / [i915#2411])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb2/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- shard-snb: [PASS][36] -> [INCOMPLETE][37] ([i915#3921])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-snb2/igt@i915_selftest@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-snb7/igt@i915_selftest@[email protected]

* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-apl: NOTRUN -> [SKIP][38] ([fdo#109271]) +48 similar issues
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl3/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-90:
- shard-tglb: NOTRUN -> [SKIP][39] ([fdo#111614])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb6/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][40] ([fdo#109271] / [i915#3777]) +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl7/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][41] ([fdo#109271] / [i915#3777]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk3/igt@[email protected]

* igt@kms_big_fb@yf-tiled-8bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][42] ([fdo#111615]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb7/igt@[email protected]

* igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-kbl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3886]) +7 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html
- shard-iclb: NOTRUN -> [SKIP][44] ([fdo#109278] / [i915#3886]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb6/igt@kms_ccs@pipe-a-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs:
- shard-glk: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3886]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk9/igt@kms_ccs@pipe-b-bad-pixel-format-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#3689]) +3 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb2/igt@kms_ccs@pipe-b-crc-primary-rotation-180-y_tiled_ccs.html

* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#3689] / [i915#3886]) +2 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb6/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html

* igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl6/igt@kms_ccs@pipe-c-ccs-on-another-bo-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_chamelium@dp-crc-fast:
- shard-snb: NOTRUN -> [SKIP][49] ([fdo#109271] / [fdo#111827]) +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-snb2/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][50] ([fdo#109284] / [fdo#111827]) +3 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb4/igt@[email protected]

* igt@kms_chamelium@hdmi-audio-edid:
- shard-kbl: NOTRUN -> [SKIP][51] ([fdo#109271] / [fdo#111827]) +13 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl4/igt@[email protected]

* igt@kms_chamelium@vga-edid-read:
- shard-glk: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk8/igt@[email protected]

* igt@kms_chamelium@vga-hpd-for-each-pipe:
- shard-apl: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +4 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][54] ([fdo#109284] / [fdo#111827]) +6 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb3/igt@[email protected]

* igt@kms_content_protection@dp-mst-lic-type-1:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#3116])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb3/igt@[email protected]

* igt@kms_content_protection@legacy:
- shard-kbl: NOTRUN -> [TIMEOUT][56] ([i915#1319])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl1/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-32x10-random:
- shard-tglb: NOTRUN -> [SKIP][57] ([i915#3359]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb2/igt@[email protected]

* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-tglb: [PASS][58] -> [INCOMPLETE][59] ([i915#2411] / [i915#2828] / [i915#456])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-tglb1/igt@[email protected]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb7/igt@[email protected]

* igt@kms_cursor_crc@pipe-c-cursor-512x512-random:
- shard-tglb: NOTRUN -> [SKIP][60] ([fdo#109279] / [i915#3359]) +1 similar issue
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb5/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-512x170-sliding:
- shard-iclb: NOTRUN -> [SKIP][61] ([fdo#109278]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb1/igt@[email protected]

* igt@kms_cursor_crc@pipe-d-cursor-suspend:
- shard-kbl: NOTRUN -> [SKIP][62] ([fdo#109271]) +177 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl1/igt@[email protected]

* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][63] ([fdo#109274] / [fdo#109278])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb4/igt@[email protected]

* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-iclb: NOTRUN -> [SKIP][64] ([i915#426])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb1/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#426])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb2/igt@[email protected]

* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#3528])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb1/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][67] -> [INCOMPLETE][68] ([i915#180] / [i915#1982])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-apl4/igt@[email protected]
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl4/igt@[email protected]

* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-iclb: NOTRUN -> [SKIP][69] ([fdo#109274])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb2/igt@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@a-edp1:
- shard-tglb: [PASS][70] -> [INCOMPLETE][71] ([i915#2411] / [i915#456])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-tglb2/igt@kms_flip@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb7/igt@kms_flip@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-msflip-blt:
- shard-tglb: NOTRUN -> [SKIP][72] ([fdo#111825]) +25 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb5/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][73] ([fdo#109280]) +5 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb2/igt@kms_frontbuffer_tracking@psr-2p-primscrn-pri-indfb-draw-render.html

* igt@kms_hdr@bpc-switch-suspend:
- shard-kbl: [PASS][74] -> [DMESG-WARN][75] ([i915#180]) +3 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-kbl1/igt@[email protected]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl6/igt@[email protected]

* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence:
- shard-kbl: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#533]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl3/igt@[email protected]
- shard-glk: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#533])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk6/igt@[email protected]

* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- shard-apl: [PASS][78] -> [DMESG-WARN][79] ([i915#180]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-apl2/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl4/igt@[email protected]
- shard-kbl: NOTRUN -> [DMESG-WARN][80] ([i915#180])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-b-alpha-7efc:
- shard-apl: NOTRUN -> [FAIL][81] ([fdo#108145] / [i915#265]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl6/igt@[email protected]

* igt@kms_plane_alpha_blend@pipe-c-alpha-7efc:
- shard-kbl: NOTRUN -> [FAIL][82] ([fdo#108145] / [i915#265]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl4/igt@[email protected]

* igt@kms_plane_cursor@pipe-d-viewport-size-256:
- shard-glk: NOTRUN -> [SKIP][83] ([fdo#109271]) +42 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk3/igt@[email protected]

* igt@kms_plane_lowres@pipe-c-tiling-yf:
- shard-iclb: NOTRUN -> [SKIP][84] ([i915#3536])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#112054])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb6/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area-1:
- shard-kbl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#658]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl3/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-2:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#2920]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb1/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-5:
- shard-iclb: NOTRUN -> [SKIP][88] ([i915#658])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb8/igt@[email protected]

* igt@kms_psr@psr2_cursor_mmap_cpu:
- shard-iclb: [PASS][89] -> [SKIP][90] ([fdo#109441]) +2 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_cpu.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb7/igt@kms_psr@psr2_cursor_mmap_cpu.html

* igt@kms_psr@psr2_primary_render:
- shard-tglb: NOTRUN -> [FAIL][91] ([i915#132] / [i915#3467])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb1/igt@kms_psr@psr2_primary_render.html
- shard-iclb: NOTRUN -> [SKIP][92] ([fdo#109441])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb5/igt@kms_psr@psr2_primary_render.html

* igt@kms_setmode@basic:
- shard-apl: [PASS][93] -> [FAIL][94] ([i915#31])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-apl3/igt@[email protected]
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl2/igt@[email protected]

* igt@kms_vrr@flip-suspend:
- shard-tglb: NOTRUN -> [SKIP][95] ([fdo#109502])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb1/igt@[email protected]

* igt@nouveau_crc@pipe-a-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][96] ([i915#2530])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb8/igt@[email protected]

* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-tglb: NOTRUN -> [SKIP][97] ([fdo#109289])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb7/igt@[email protected]

* igt@prime_nv_api@i915_self_import:
- shard-tglb: NOTRUN -> [SKIP][98] ([fdo#109291]) +1 similar issue
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb2/igt@prime_nv_api@i915_self_import.html

* igt@prime_nv_test@i915_import_gtt_mmap:
- shard-iclb: NOTRUN -> [SKIP][99] ([fdo#109291])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb6/igt@prime_nv_test@i915_import_gtt_mmap.html

* igt@prime_vgem@fence-read-hang:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#109295]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb1/igt@[email protected]

* igt@sysfs_clients@fair-3:
- shard-kbl: NOTRUN -> [SKIP][101] ([fdo#109271] / [i915#2994]) +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl7/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][102] ([i915#2994])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb1/igt@[email protected]

* igt@sysfs_clients@split-25:
- shard-glk: NOTRUN -> [SKIP][103] ([fdo#109271] / [i915#2994]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk9/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-tglb: [INCOMPLETE][104] ([i915#456]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-tglb7/igt@gem_ctx_isolation@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb2/igt@gem_ctx_isolation@[email protected]

* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][106] ([i915#2842]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-kbl1/igt@gem_exec_fair@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][108] ([i915#2842]) -> [PASS][109] +1 similar issue
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-glk8/igt@gem_exec_fair@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk2/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@bcs0:
- shard-tglb: [FAIL][110] ([i915#2842]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-tglb5/igt@gem_exec_fair@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [FAIL][112] ([i915#2842]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb7/igt@gem_exec_fair@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb7/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-fds-forked:
- shard-glk: [DMESG-WARN][114] ([i915#118]) -> [PASS][115] +1 similar issue
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-glk3/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk1/igt@[email protected]

* igt@gem_softpin@noreloc-s3:
- shard-tglb: [INCOMPLETE][116] ([i915#1373]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-tglb7/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-tglb1/igt@[email protected]

* igt@kms_atomic_transition@plane-all-transition-fencing@edp-1-pipe-b:
- shard-iclb: [DMESG-WARN][118] -> [PASS][119] +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb7/igt@kms_atomic_transition@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb2/igt@kms_atomic_transition@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-180:
- shard-glk: [FAIL][120] -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-glk8/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk2/igt@[email protected]

* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-apl: [FAIL][122] ([i915#2346] / [i915#533]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html

* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][124] ([i915#180]) -> [PASS][125] +8 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-kbl1/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-kbl4/igt@[email protected]

* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [SKIP][126] ([fdo#109441]) -> [PASS][127] +1 similar issue
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb3/igt@kms_psr@psr2_sprite_plane_move.html
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html

* igt@kms_setmode@basic:
- shard-glk: [FAIL][128] ([i915#31]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-glk4/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk5/igt@[email protected]

#### Warnings ####

* igt@i915_pm_dc@dc9-dpms:
- shard-iclb: [SKIP][130] ([i915#4281]) -> [FAIL][131] ([i915#4275])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb3/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb7/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-fence:
- shard-iclb: [WARN][132] ([i915#1804] / [i915#2684]) -> [WARN][133] ([i915#2684])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb3/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb5/igt@[email protected]

* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [WARN][134] ([i915#2684]) -> [WARN][135] ([i915#1804] / [i915#2684])
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb8/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb7/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-180:
- shard-glk: [DMESG-WARN][136] ([i915#118]) -> [DMESG-WARN][137] ([i915#118] / [i915#1982])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-glk6/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-glk6/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area-3:
- shard-iclb: [SKIP][138] ([i915#2920]) -> [SKIP][139] ([i915#658]) +1 similar issue
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb2/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb6/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-1:
- shard-iclb: [SKIP][140] ([i915#658]) -> [SKIP][141] ([i915#2920])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb3/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb2/igt@[email protected]

* igt@kms_psr2_su@page_flip:
- shard-iclb: [SKIP][142] ([fdo#109642] / [fdo#111068] / [i915#658]) -> [FAIL][143] ([i915#4148])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_10802/shard-iclb7/igt@kms_psr2_su@page_flip.html
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/shard-iclb2/igt@kms_psr2_su@page_flip.html

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6358/index.html

#2 lore raw

Re: [igt-dev] [PATCH i-g-t 1/3] lib/i915: Return actual submission method from gem_submission_method

In reply to Ashutosh Dixit
Quoted 4 lines · Ashutosh Dixit

gem_submission_method() purports to return the currently used submission method by the kernel, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

Quoted 8 lines

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
new code equivalent to the previous code.
v3: Clarify that submission method is either guc (0x4), execlists (0x2) or

     legacy without semaphores (0x0) or legacy with semaphores (0x1)

What about GuC with semaphores vs GuC without semaphores? Likewise execlist.

Quoted 31 lines
---
  lib/i915/gem_submission.c   | 10 +++++-----
  tests/i915/gem_ctx_shared.c |  2 +-
  tests/i915/gem_watchdog.c   |  2 +-
  3 files changed, 7 insertions(+), 7 deletions(-)
lib/i915/gem_submission.c +2 -2
index 2627b802cfb..6fe7112d958 100644
@@ -77,7 +77,7 @@ static bool has_semaphores(int fd, int dir)
  unsigned gem_submission_method(int fd)
  {
  	const int gen = intel_gen(intel_get_drm_devid(fd));
-	unsigned flags = 0;
+	unsigned method = 0;
 
  	int dir;
 
@@ -86,21 +86,21 @@ unsigned gem_submission_method(int fd)
  		return 0;
 
  	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
-		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
+		method = GEM_SUBMISSION_GUC;
  		goto out;
  	}

lib/i915/gem_submission.c unsigned gem_submission_method(int fd) · line 99

Quoted 10 lines
lib/i915/gem_submission.c +2 -2
 
  	if (gen >= 8) {
-		flags |= GEM_SUBMISSION_EXECLISTS;
+		method = GEM_SUBMISSION_EXECLISTS;
  		goto out;
  	}
 
  	if (has_semaphores(fd, dir))
-		flags |= GEM_SUBMISSION_SEMAPHORES;
+		method = GEM_SUBMISSION_SEMAPHORES;

Semaphores is not a submission method. They are a submission feature whose support or lack there of is independent of the submission method.

Quoted 13 lines
lib/i915/gem_submission.c +1 -1
  out:
  	close(dir);
-	return flags;
+	return method;
  }
 
  /**
tests/i915/gem_ctx_shared.c +0 -0
index ea1b5dd1b8c..f50ef13263f 100644

tests/i915/gem_ctx_shared.c static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg) · line 162

Quoted 5 lines
tests/i915/gem_ctx_shared.c +1 -1
@@ -159,7 +159,7 @@ static void disjoint_timelines(int i915, const intel_ctx_cfg_t *cfg)
  	uint32_t plug;
  	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));

Maybe 'require(submission_type() > SUBMISSION_RING)'? There will be likely other submission methods in the future.

But isn't this one really looking for semaphores, anyway? Or am I thinking of something else?

John.

Quoted 16 lines
tests/i915/gem_ctx_shared.c +0 -0
  	/*
  	 * Each context, although they share a vm, are expected to be
tests/i915/gem_watchdog.c +1 -1
index db562335a2a..21c7710a806 100644
@@ -222,7 +222,7 @@ static void virtual(int i915, const intel_ctx_cfg_t *base_cfg)
  	const intel_ctx_t *ctx[num_engines];
  	uint64_t ahnd;
 
-	igt_require(gem_has_execlists(i915));
+	igt_require(gem_has_execlists(i915) || gem_has_guc_submission(i915));
 
  	igt_debug("%u virtual engines\n", num_engines);
  	igt_require(num_engines);
#3 lore raw

Re: [igt-dev] [PATCH i-g-t 1/3] lib/i915: Return actual submission method from gem_submission_method

Quoted 15 lines · John Harrison
Quoted 4 lines · Ashutosh Dixit

gem_submission_method() purports to return the currently used submission method by the kernel, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

Quoted 8 lines

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
new code equivalent to the previous code.
v3: Clarify that submission method is either guc (0x4), execlists (0x2) or

     legacy without semaphores (0x0) or legacy with semaphores (0x1)
Quoted 4 lines

What about GuC with semaphores vs GuC without semaphores? Likewise execlist.

Semaphores is not a submission method. They are a submission feature whose support or lack there of is independent of the submission method.

Sorry I didn't know that. But if you see gem_submission_method() in current upstream IGT (pasted below) it doesn't return "GuC with semaphores' or "execlist with semaphores" either. Anyway, let me do this in the next rev. Thanks.

unsigned gem_submission_method(int fd)

{
	const int gen = intel_gen(intel_get_drm_devid(fd));
	unsigned flags = 0;

	int dir;

	dir = igt_params_open(fd);
	if (dir < 0)
		return 0;

	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
		goto out;
	}

	if (gen >= 8) {
		flags |= GEM_SUBMISSION_EXECLISTS;
		goto out;
	}

	if (has_semaphores(fd, dir))
		flags |= GEM_SUBMISSION_SEMAPHORES;

out:

	close(dir);
	return flags;
}
#4 lore raw

Re: [igt-dev] [PATCH i-g-t 1/3] lib/i915: Return actual submission method from gem_submission_method

Quoted 14 lines · Ashutosh
Quoted 13 lines · John Harrison
Quoted 12 lines · Ashutosh Dixit

gem_submission_method() purports to return the currently used submission method by the kernel, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
new code equivalent to the previous code.
v3: Clarify that submission method is either guc (0x4), execlists (0x2) or

      legacy without semaphores (0x0) or legacy with semaphores (0x1)
Quoted 8 lines
Quoted 4 lines

What about GuC with semaphores vs GuC without semaphores? Likewise execlist.

Semaphores is not a submission method. They are a submission feature whose support or lack there of is independent of the submission method.

Sorry I didn't know that. But if you see gem_submission_method() in current upstream IGT (pasted below) it doesn't return "GuC with semaphores' or "execlist with semaphores" either. Anyway, let me do this in the next rev. Thanks.

I mean that in the old code:
    "GuC with semaphores" == is_guc_submission() && has_semaphores()

But if you conflate semaphores with the submission method then you have to explicitly enumerate all combinations.

Hmm, okay. Just realised that the old code did indeed have GEM_SUBMISSION_SEMAPHORES. Not sure what that was about!? You can definitely have semaphores with GuC/execlists and you can definitely have GuC/execlists without semaphores. I don't see why ring buffer submission would be any different but I admit it's been a while since I've looked at any ring buffer code.

It doesn't look like anything was actually using 'gem_has_semaphores()' at all, though. So nothing would notice if it was removed ;).

John.

Quoted 29 lines

unsigned gem_submission_method(int fd)

{
	const int gen = intel_gen(intel_get_drm_devid(fd));
	unsigned flags = 0;

	int dir;

	dir = igt_params_open(fd);
	if (dir < 0)
		return 0;

	if (igt_sysfs_get_u32(dir, "enable_guc") & 1) {
		flags |= GEM_SUBMISSION_GUC | GEM_SUBMISSION_EXECLISTS;
		goto out;
	}

	if (gen >= 8) {
		flags |= GEM_SUBMISSION_EXECLISTS;
		goto out;
	}

	if (has_semaphores(fd, dir))
		flags |= GEM_SUBMISSION_SEMAPHORES;

out:

	close(dir);
	return flags;
}
#5 lore raw

Re: [igt-dev] [PATCH i-g-t 1/3] lib/i915: Return actual submission method from gem_submission_method

Quoted 37 lines · John Harrison
Quoted 14 lines · Ashutosh
Quoted 13 lines · John Harrison
Quoted 12 lines · Ashutosh Dixit

gem_submission_method() purports to return the currently used submission method by the kernel, as evidenced by its callers. Therefore remove the GEM_SUBMISSION_EXECLISTS flag when GuC submission is detected.

This also fixes gem_has_execlists() to match its description, previously gem_has_execlists() would return true even if GuC submission was actually being used in the driver.

v2: Or gem_has_execlists call-sites with gem_has_guc_submission to make the
new code equivalent to the previous code.
v3: Clarify that submission method is either guc (0x4), execlists (0x2) or

      legacy without semaphores (0x0) or legacy with semaphores (0x1)
Quoted 8 lines
Quoted 4 lines

What about GuC with semaphores vs GuC without semaphores? Likewise execlist.

Semaphores is not a submission method. They are a submission feature whose support or lack there of is independent of the submission method.

Sorry I didn't know that. But if you see gem_submission_method() in current upstream IGT (pasted below) it doesn't return "GuC with semaphores' or "execlist with semaphores" either. Anyway, let me do this in the next rev. Thanks.

I mean that in the old code:

   "GuC with semaphores" == is_guc_submission() && has_semaphores()

But if you conflate semaphores with the submission method then you have to explicitly enumerate all combinations.

Hmm, okay. Just realised that the old code did indeed have GEM_SUBMISSION_SEMAPHORES. Not sure what that was about!? You can definitely have semaphores with GuC/execlists and you can definitely have GuC/execlists without semaphores. I don't see why ring buffer submission would be any different but I admit it's been a while since I've looked at any ring buffer code.

Quoted 2 lines

It doesn't look like anything was actually using 'gem_has_semaphores()' at all, though. So nothing would notice if it was removed ;).

I think I am going to do this. Also, has_semaphores() calls here in i915:

	int i915_getparam_ioctl()
	{
		...
		case I915_PARAM_HAS_SEMAPHORES:
			value = !!(i915->caps.scheduler & I915_SCHEDULER_CAP_SEMAPHORES);
			break;

But appears I915_SCHEDULER_CAP_SEMAPHORES bits are never set in caps.scheduler so has_semaphores() should always be returning zero.

#6 lore raw

Re: [igt-dev] [PATCH i-g-t 1/3] lib/i915: Return actual submission method from gem_submission_method

Quoted 10 lines · Ashutosh

I think I am going to do this. Also, has_semaphores() calls here in i915:

	int i915_getparam_ioctl()
	{
		...
		case I915_PARAM_HAS_SEMAPHORES:
			value = !!(i915->caps.scheduler & I915_SCHEDULER_CAP_SEMAPHORES);
			break;
Quoted 2 lines

But appears I915_SCHEDULER_CAP_SEMAPHORES bits are never set in caps.scheduler so has_semaphores() should always be returning zero.

Sorry I am wrong, I915_SCHEDULER_CAP_SEMAPHORES is set in i915 set_scheduler_caps() and gem_busy@semaphores tests run in CI.