Support bcm6123 Bus Converter
Subsystems (2)
cover Support bcm6123 Bus Converter
Hi,
This patchset adds support for BCM6123 Bus Converter from Vicor Corporation.
Marcello Sylvester Bauer (3):
dt-bindings: vendor-prefixes: add Vicor Corporation
dt-bindings: hwmon/pmbus: Add vicor,bcm6123 Bus Converter
pmbus: remove trailing whitespaces
Patrick Rudolph (1):
pmbus: Add support for bcm6123 Bus Converter
.../bindings/hwmon/pmbus/vicor,bcm6123.yaml | 41 +++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/hwmon/pmbus/Kconfig | 13 ++- drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/bcm6123.c | 90 +++++++++++++++++++ 5 files changed, 145 insertions(+), 2 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml create mode 100644 drivers/hwmon/pmbus/bcm6123.c
Signature · 1 line
2.33.1
PATCH 1/4 dt-bindings: vendor-prefixes: add Vicor Corporation
Add vendor prefix for Vicor Corporation.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -1273,6 +1273,8 @@ patternProperties: "^vdl,.*": description: Van der Laan b.v. "^via,.*": + description: Vicor Corporation + "^vicor,.*": description: VIA Technologies, Inc. "^videostrong,.*": description: Videostrong Technology Co., Ltd.
Signature · 1 line
2.33.1
Rob Herring
maintainerRe: [PATCH v1 1/4] dt-bindings: vendor-prefixes: add Vicor Corporation
Quoted 12 lines · Marcello Sylvester Bauer
Add vendor prefix for Vicor Corporation.
Signed-off-by Marcello Sylvester Bauer <[email protected]>--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)Documentation/devicetree/bindings/vendor-prefixes.yaml +0
-0
Documentation/devicetree/bindings/vendor-prefixes.yaml patternProperties: · line 1276
Quoted 4 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +1
-0@@ -1273,6 +1273,8 @@ patternProperties: "^vdl,.*": description: Van der Laan b.v. "^via,.*": + description: Vicor Corporation
You just changed the description for VIA.
Quoted 8 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +1
-0+ "^vicor,.*": description: VIA Technologies, Inc. "^videostrong,.*": description: Videostrong Technology Co., Ltd.Signature · 1 line
2.33.1
Re: [PATCH v1 1/4] dt-bindings: vendor-prefixes: add Vicor Corporation
Quoted 9 lines · Rob Herring
Quoted 7 lines · Marcello Sylvester Bauer
Add vendor prefix for Vicor Corporation.
Signed-off-by Marcello Sylvester Bauer <[email protected]>---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++1 file changed, 2 insertions(+)
Quoted 12 lines
Quoted 10 lines
Documentation/devicetree/bindings/vendor-prefixes.yaml +0
-0@@ -1273,6 +1273,8 @@ patternProperties:"^vdl,.*":
description: Van der Laan b.v.
"^via,.*":
+ description: Vicor CorporationYou just changed the description for VIA.
Indeed. My bad.
Quoted 9 lines
Quoted 9 lines
+ "^vicor,.*":
description: VIA Technologies, Inc. "^videostrong,.*":
description: Videostrong Technology Co., Ltd.Signature · 1 line
2.33.1
PATCH 2/4 dt-bindings: hwmon/pmbus: Add vicor,bcm6123 Bus Converter
In reply to Marcello Sylvester BauerAdd bindings for BCM6123 Bus Converter from Vicor Corporation.
--- .../bindings/hwmon/pmbus/vicor,bcm6123.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml new file +41 -0
@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,bcm6123.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Vicor Corporation BCM6123 Bus Converter + +description: | + The BCM6123 is an isolated Fixed-Ratio DC-DC Converter, + operating from a 260V to 410V primary bus to deliver an unregulated + ratiometric secondary voltage. + + Datasheet: https://www.vicorpower.com/documents/datasheets/ds_BCM6123xD1E5135yzz.pdf + +properties: + compatible: + enum: + - vicor,bcm6123 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bcm6123@5f { + compatible = "vicor,bcm6123"; + reg = <0x5f>; + }; + };
Signature · 1 line
2.33.1
Guenter Roeck
maintainerRe: [PATCH v1 2/4] dt-bindings: hwmon/pmbus: Add vicor,bcm6123 Bus Converter
Quoted 3 lines · Marcello Sylvester Bauer
Add bindings for BCM6123 Bus Converter from Vicor Corporation.
Signed-off-by Marcello Sylvester Bauer <[email protected]>
Can this be added to trivial devices instead ?
Guenter
Quoted 53 lines
--- .../bindings/hwmon/pmbus/vicor,bcm6123.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+)create mode 100644
Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yamlDocumentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml new file +41
-0@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,bcm6123.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Vicor Corporation BCM6123 Bus Converter + +description: | + The BCM6123 is an isolated Fixed-Ratio DC-DC Converter, + operating from a 260V to 410V primary bus to deliver an unregulated + ratiometric secondary voltage. + + Datasheet: https://www.vicorpower.com/documents/datasheets/ds_BCM6123xD1E5135yzz.pdf + +properties: + compatible: + enum: + - vicor,bcm6123 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bcm6123@5f { + compatible = "vicor,bcm6123"; + reg = <0x5f>; + }; + };
Re: [PATCH v1 2/4] dt-bindings: hwmon/pmbus: Add vicor,bcm6123 Bus Converter
Quoted 8 lines · Guenter Roeck
Quoted 3 lines · Marcello Sylvester Bauer
Add bindings for BCM6123 Bus Converter from Vicor Corporation.
Signed-off-by Marcello Sylvester Bauer <[email protected]>Can this be added to trivial devices instead ?
Guenter
Indeed. Thanks.
Marcello
Quoted 55 lines
Quoted 54 lines
--- .../bindings/hwmon/pmbus/vicor,bcm6123.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+)create mode 100644
Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yamlDocumentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml new file +41
-0@@ -0,0 +1,41 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/pmbus/vicor,bcm6123.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Vicor Corporation BCM6123 Bus Converter + +description: | + The BCM6123 is an isolated Fixed-Ratio DC-DC Converter, + operating from a 260V to 410V primary bus to deliver an unregulated + ratiometric secondary voltage. + + Datasheet: https://www.vicorpower.com/documents/datasheets/ds_BCM6123xD1E5135yzz.pdf + +properties: + compatible: + enum: + - vicor,bcm6123 + + reg: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + bcm6123@5f { + compatible = "vicor,bcm6123"; + reg = <0x5f>; + }; + };
Rob Herring
maintainerRe: [PATCH v1 2/4] dt-bindings: hwmon/pmbus: Add vicor,bcm6123 Bus Converter
In reply to Marcello Sylvester BauerQuoted 8 lines · Marcello Sylvester Bauer
Add bindings for BCM6123 Bus Converter from Vicor Corporation.
Signed-off-by Marcello Sylvester Bauer <[email protected]>--- .../bindings/hwmon/pmbus/vicor,bcm6123.yaml | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml: 'maintainers' is a required property
hint: Metaschema for devicetree binding documentation
from schema $id: http://devicetree.org/meta-schemas/base.yaml#
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yaml: ignoring, error in schema:Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.example.dt.yaml:0:0: /example-0/i2c/bcm6123@5f: failed to match any schema with compatible: ['vicor,bcm6123']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/patch/1580909
This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date:
pip3 install dtschema --upgrade
Please check and re-submit.
PATCH 3/4 pmbus: remove trailing whitespaces
In reply to Marcello Sylvester BauerFix checkpatch issues by removing trailing whitespaces in Kconfig.
--- drivers/hwmon/pmbus/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/hwmon/pmbus/Kconfig +2 -2
@@ -189,8 +189,8 @@ config SENSORS_LTC2978_REGULATOR depends on SENSORS_LTC2978 && REGULATOR help If you say yes here you get regulator support for Linear Technology - LTC3880, LTC3883, LTC3884, LTC3886, LTC3887, LTC3889, LTC7880, - LTM4644, LTM4675, LTM4676, LTM4677, LTM4678, LTM4680, LTM4686, + LTC3880, LTC3883, LTC3884, LTC3886, LTC3887, LTC3889, LTC7880, + LTM4644, LTM4675, LTM4676, LTM4677, LTM4678, LTM4680, LTM4686, and LTM4700. config SENSORS_LTC3815
Signature · 1 line
2.33.1
Re: [PATCH v1 3/4] pmbus: remove trailing whitespaces
Quoted 3 lines · Marcello Sylvester Bauer
Fix checkpatch issues by removing trailing whitespaces in
Kconfig.Signed-off-by Marcello Sylvester Bauer <[email protected]>
Applied, after updating Kconfig file. No need to resend.
Quoted 19 lines
--- drivers/hwmon/pmbus/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/hwmon/pmbus/Kconfig +2
-2@@ -189,8 +189,8 @@ config SENSORS_LTC2978_REGULATOR depends on SENSORS_LTC2978 && REGULATOR help If you say yes here you get regulator support for Linear Technology - LTC3880, LTC3883, LTC3884, LTC3886, LTC3887, LTC3889, LTC7880, - LTM4644, LTM4675, LTM4676, LTM4677, LTM4678, LTM4680, LTM4686, + LTC3880, LTC3883, LTC3884, LTC3886, LTC3887, LTC3889, LTC7880, + LTM4644, LTM4675, LTM4676, LTM4677, LTM4678, LTM4680, LTM4686, and LTM4700. config SENSORS_LTC3815
PATCH 4/4 pmbus: Add support for bcm6123 Bus Converter
In reply to Marcello Sylvester BauerFrom: Patrick Rudolph <[email protected]>
BCM6123 is an Fixed-Ratio DC-DC Converter.
--- drivers/hwmon/pmbus/Kconfig | 9 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/bcm6123.c | 90 +++++++++++++++++++++++++++++++++++ 3 files changed, 100 insertions(+) create mode 100644 drivers/hwmon/pmbus/bcm6123.c
drivers/hwmon/pmbus/Kconfig +9 -0
@@ -48,6 +48,15 @@ config SENSORS_ADM1275 This driver can also be built as a module. If so, the module will be called adm1275. +config SENSORS_BCM6123 + tristate "Vicor BCM6123 Compatible Power Supplies" + help + If you say yes here you get hardware monitoring support for Vicor + BCM6123 Power Supplies. + + This driver can also be built as a module. If so, the module will + be called bcm6123. + config SENSORS_BEL_PFE tristate "Bel PFE Compatible Power Supplies" help
drivers/hwmon/pmbus/Makefile +1 -0
@@ -7,6 +7,7 @@ obj-$(CONFIG_PMBUS) += pmbus_core.o obj-$(CONFIG_SENSORS_PMBUS) += pmbus.o obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o +obj-$(CONFIG_SENSORS_BCM6123) += bcm6123.o obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o obj-$(CONFIG_SENSORS_BPA_RS600) += bpa-rs600.o obj-$(CONFIG_SENSORS_DELTA_AHE50DC_FAN) += delta-ahe50dc-fan.o
drivers/hwmon/pmbus/bcm6123.c new file +90 -0
90 lines not on this page · raw message
Signature · 1 line
2.33.1
Guenter Roeck
maintainerRe: [PATCH v1 4/4] pmbus: Add support for bcm6123 Bus Converter
Quoted 10 lines · Marcello Sylvester Bauer
From: Patrick Rudolph <[email protected]>
BCM6123 is an Fixed-Ratio DC-DC Converter.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Marcello Sylvester Bauer <[email protected]>--- drivers/hwmon/pmbus/Kconfig | 9 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/bcm6123.c | 90 +++++++++++++++++++++++++++++++++++
Documentation/hwmon/bcm6123 is missing.
drivers/hwmon/pmbus/Kconfig config SENSORS_ADM1275 · line 52
Quoted 13 lines
3 files changed, 100 insertions(+)create mode 100644
drivers/hwmon/pmbus/bcm6123.cdrivers/hwmon/pmbus/Kconfig +2
-0@@ -48,6 +48,15 @@ config SENSORS_ADM1275 This driver can also be built as a module. If so, the module will be called adm1275. +config SENSORS_BCM6123 + tristate "Vicor BCM6123 Compatible Power Supplies"
Is this a power supply or a chip ? It can't be both.
Quoted 28 lines
drivers/hwmon/pmbus/Kconfig +7
-0+ help + If you say yes here you get hardware monitoring support for Vicor + BCM6123 Power Supplies. + + This driver can also be built as a module. If so, the module will + be called bcm6123. + config SENSORS_BEL_PFE tristate "Bel PFE Compatible Power Supplies" helpdrivers/hwmon/pmbus/Makefile +1
-0@@ -7,6 +7,7 @@ obj-$(CONFIG_PMBUS) += pmbus_core.o obj-$(CONFIG_SENSORS_PMBUS) += pmbus.o obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o +obj-$(CONFIG_SENSORS_BCM6123) += bcm6123.o obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o obj-$(CONFIG_SENSORS_BPA_RS600) += bpa-rs600.o obj-$(CONFIG_SENSORS_DELTA_AHE50DC_FAN) += delta-ahe50dc-fan.odrivers/hwmon/pmbus/bcm6123.c new file +0
-0
drivers/hwmon/pmbus/bcm6123.c line 4
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +4
-0@@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Hardware monitoring driver for Infineon bcm6123 +*
Infineon ?
drivers/hwmon/pmbus/bcm6123.c line 9
Quoted 5 lines
drivers/hwmon/pmbus/bcm6123.c new file +5
-0+* Copyright (c) 2021 9elements GmbH +* +* VOUT_MODE is not supported by the device. The driver fakes VOUT linear16 +* mode with exponent value -8 as direct mode with m=256/b=0/R=0. +*
Does it not ? The datasheet doesn't say, and the code below doesn't match this description.
drivers/hwmon/pmbus/bcm6123.c line 11
Quoted 2 lines
drivers/hwmon/pmbus/bcm6123.c new file +2
-0+* The device supports VOUT_PEAK, IOUT_PEAK, and TEMPERATURE_PEAK, however +* this driver does not currently support them.
Does it ? There is no reference for this in the datasheet.
Overall it seems like there is a lot of cut-and-paste. Please clean this up.
drivers/hwmon/pmbus/bcm6123.c line 24
Quoted 13 lines
drivers/hwmon/pmbus/bcm6123.c new file +13
-0+*/ + +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/pmbus.h> +#include "pmbus.h" + +static struct pmbus_platform_data bcm6123_plat_data = { + .flags =PMBUS_NO_CAPABILITY , +};
We should only set this flag if it is really needed.
Quoted 12 lines
drivers/hwmon/pmbus/bcm6123.c new file +12
-0+ +static struct pmbus_driver_info bcm6123_info = { + .pages =2 , + .format[PSC_VOLTAGE_IN ] = direct, + .format[PSC_VOLTAGE_OUT ] = direct, + .format[PSC_CURRENT_IN ] = direct, + .format[PSC_CURRENT_OUT ] = direct, + .format[PSC_POWER ] = linear, + .format[PSC_TEMPERATURE ] = linear, + .m[PSC_VOLTAGE_IN ] =1 , + .b[PSC_VOLTAGE_IN ] =0 , + .R[PSC_VOLTAGE_IN ] =1 ,
drivers/hwmon/pmbus/bcm6123.c line 46
Quoted 10 lines
drivers/hwmon/pmbus/bcm6123.c new file +10
-0+ .m[PSC_VOLTAGE_OUT] = 1, + .b[PSC_VOLTAGE_OUT] = 0, + .R[PSC_VOLTAGE_OUT] = 1, + .m[PSC_CURRENT_IN] = 1, + .b[PSC_CURRENT_IN] = 0, + .R[PSC_CURRENT_IN] = 3, + .m[PSC_CURRENT_OUT] = 1, + .b[PSC_CURRENT_OUT] = 0, + .R[PSC_CURRENT_OUT] = 2, + .func[0] = 0, /* Summing page without voltage readings */
This needs further explanation. The public datasheet doesn't say anything about multiple pages, and it doesn't really make much sense to have an "empty" page with no information in it.
Quoted 45 lines
drivers/hwmon/pmbus/bcm6123.c new file +44
-0+ .func[1] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT + |PMBUS_HAVE_TEMP |PMBUS_HAVE_STATUS_TEMP + |PMBUS_HAVE_VOUT |PMBUS_HAVE_STATUS_VOUT + |PMBUS_HAVE_IOUT |PMBUS_HAVE_STATUS_IOUT + | PMBUS_HAVE_IIN | PMBUS_HAVE_POUT, +}; + +static int bcm6123_probe (struct i2c_client *client) +{ + client->dev.platform_data = &bcm6123_plat_data; + +return pmbus_do_probe (client, &bcm6123_info); +} + +static const struct i2c_device_id bcm6123_id[] = { + {"bcm6123" ,0 }, + {} +}; + +MODULE_DEVICE_TABLE (i2c, bcm6123_id); + +#ifdef CONFIG_OF +static const struct of_device_id bcm6123_of_match[] = { + { .compatible ="vicor,bcm6123" }, + { }, +}; +MODULE_DEVICE_TABLE (of, bcm6123_of_match); +#endif + +/* This is the driver that will be inserted */ +static struct i2c_driver bcm6123_driver = { + .driver = { + .name ="bcm6123" , + .of_match_table =of_match_ptr (bcm6123_of_match), + }, + .probe_new = bcm6123_probe, + .id_table = bcm6123_id, +}; + +module_i2c_driver (bcm6123_driver); + +MODULE_AUTHOR ("Patrick Rudolph <[email protected]>" ); +MODULE_DESCRIPTION ("PMBus driver for Vicor bcm6123" ); +MODULE_LICENSE ("GPL" );
Guenter Roeck
maintainerRe: [PATCH v1 4/4] pmbus: Add support for bcm6123 Bus Converter
Quoted 113 lines · Guenter Roeck
Quoted 10 lines · Marcello Sylvester Bauer
From: Patrick Rudolph <[email protected]>
BCM6123 is an Fixed-Ratio DC-DC Converter.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Marcello Sylvester Bauer <[email protected]>---
drivers/hwmon/pmbus/Kconfig | 9 ++++ drivers/hwmon/pmbus/Makefile | 1 +drivers/hwmon/pmbus/bcm6123.c| 90 +++++++++++++++++++++++++++++++++++
Documentation/hwmon/bcm6123is missing.Quoted 8 lines
3 files changed, 100 insertions(+)create mode 100644
drivers/hwmon/pmbus/bcm6123.cdrivers/hwmon/pmbus/Kconfig +0
-0@@ -48,6 +48,15 @@ config SENSORS_ADM1275Quoted 4 lines
This driver can also be built as a module. If so, the module will be called adm1275.
+configSENSORS_BCM6123
+ tristate "Vicor BCM6123 Compatible Power Supplies"Is this a power supply or a chip ? It can't be both.
Quoted 28 lines
+ help
+ If you say yes here you get hardware monitoring support for Vicor + BCM6123 Power Supplies.drivers/hwmon/pmbus/Kconfig +4
-0+ + This driver can also be built as a module. If so, the module will + be called bcm6123. +config
SENSORS_BEL_PFE
tristate "Bel PFE Compatible Power Supplies" helpdrivers/hwmon/pmbus/Makefile +0
-0@@ -7,6 +7,7 @@ obj-$(CONFIG_PMBUS) += pmbus_core.oobj-$(CONFIG_SENSORS_PMBUS) += pmbus.o obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o +obj-$(CONFIG_SENSORS_BCM6123) += bcm6123.o obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o obj-$(CONFIG_SENSORS_BPA_RS600) += bpa-rs600.o obj-$(CONFIG_SENSORS_DELTA_AHE50DC_FAN) += delta-ahe50dc-fan.o
drivers/hwmon/pmbus/bcm6123.c new file +0
-0drivers/hwmon/pmbus/bcm6123.c line 4
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +4
-0@@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Hardware monitoring driver for Infineon bcm6123 +* Infineon ?
drivers/hwmon/pmbus/bcm6123.c line 9
Quoted 5 lines
drivers/hwmon/pmbus/bcm6123.c new file +5
-0+* Copyright (c) 2021 9elements GmbH +* +* VOUT_MODE is not supported by the device. The driver fakes VOUT linear16 +* mode with exponent value -8 as direct mode with m=256/b=0/R=0. +* Does it not ? The datasheet doesn't say, and the code below doesn't match this description.
drivers/hwmon/pmbus/bcm6123.c line 11
Quoted 2 lines
drivers/hwmon/pmbus/bcm6123.c new file +2
-0+* The device supports VOUT_PEAK, IOUT_PEAK, and TEMPERATURE_PEAK, however +* this driver does not currently support them. Does it ? There is no reference for this in the datasheet.
Overall it seems like there is a lot of cut-and-paste. Please clean this up.
drivers/hwmon/pmbus/bcm6123.c line 24
Quoted 13 lines
drivers/hwmon/pmbus/bcm6123.c new file +13
-0+*/ + +#include <linux/err.h> +#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/pmbus.h> +#include "pmbus.h" + +static struct pmbus_platform_data bcm6123_plat_data = { + .flags = PMBUS_NO_CAPABILITY, +};We should only set this flag if it is really needed.
Quoted 18 lines
drivers/hwmon/pmbus/bcm6123.c new file +18
-0+ +static struct pmbus_driver_info bcm6123_info = { + .pages = 2, + .format[PSC_VOLTAGE_IN] = direct, + .format[PSC_VOLTAGE_OUT] = direct, + .format[PSC_CURRENT_IN] = direct, + .format[PSC_CURRENT_OUT] = direct, + .format[PSC_POWER] = linear, + .format[PSC_TEMPERATURE] = linear, + .m[PSC_VOLTAGE_IN] = 1, + .b[PSC_VOLTAGE_IN] = 0, + .R[PSC_VOLTAGE_IN] = 1, + .m[PSC_VOLTAGE_OUT] = 1, + .b[PSC_VOLTAGE_OUT] = 0, + .R[PSC_VOLTAGE_OUT] = 1, + .m[PSC_CURRENT_IN] = 1, + .b[PSC_CURRENT_IN] = 0, + .R[PSC_CURRENT_IN] = 3,
Quoted 9 lines
drivers/hwmon/pmbus/bcm6123.c line 46
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +4
-0+ .m[PSC_CURRENT_OUT] = 1, + .b[PSC_CURRENT_OUT] = 0, + .R[PSC_CURRENT_OUT] = 2, + .func[0] = 0, /* Summing page without voltage readings */This needs further explanation. The public datasheet doesn't say anything about multiple pages, and it doesn't really make much sense to have an "empty" page with no information in it.
Digging further, there is actually a digital supervisor (D44TL1A0) which is used to access BCM6123, and there can be up to 4 BCM6123 connected to D44TL1A0. Page 0 is the supervisor, and pages 1..4 provide data for the connected BCM6123s. Page 0 does report various telemetry values, which should be supported. Pages 2..4 should be supported as well.
Question is if the driver should be named after the supervisor or after the voltage converter; I'll leave that up to you. Either case it needs to support all five pages.
Guenter
Quoted 46 lines
Quoted 45 lines
drivers/hwmon/pmbus/bcm6123.c new file +44
-0+ .func[1] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT + | PMBUS_HAVE_IIN | PMBUS_HAVE_POUT, +}; + +static int bcm6123_probe (struct i2c_client *client) +{ + client->dev.platform_data = &bcm6123_plat_data; + + return pmbus_do_probe(client, &bcm6123_info); +} + +static const struct i2c_device_id bcm6123_id[] = { + {"bcm6123", 0}, + {} +}; + +MODULE_DEVICE_TABLE (i2c, bcm6123_id); + +#ifdef CONFIG_OF +static const struct of_device_id bcm6123_of_match[] = { + { .compatible = "vicor,bcm6123" }, + { }, +}; +MODULE_DEVICE_TABLE (of, bcm6123_of_match); +#endif + +/* This is the driver that will be inserted */ +static struct i2c_driver bcm6123_driver = { + .driver = { + .name = "bcm6123", + .of_match_table = of_match_ptr(bcm6123_of_match), + }, + .probe_new = bcm6123_probe, + .id_table = bcm6123_id, +}; + +module_i2c_driver (bcm6123_driver); + +MODULE_AUTHOR ("Patrick Rudolph <[email protected]>" ); +MODULE_DESCRIPTION ("PMBus driver for Vicor bcm6123" ); +MODULE_LICENSE ("GPL" );
Re: [PATCH v1 4/4] pmbus: Add support for bcm6123 Bus Converter
Quoted 73 lines · Guenter Roeck
Quoted 72 lines · Guenter Roeck
Quoted 10 lines · Marcello Sylvester Bauer
From: Patrick Rudolph <[email protected]>
BCM6123 is an Fixed-Ratio DC-DC Converter.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Marcello Sylvester Bauer <[email protected]>---
drivers/hwmon/pmbus/Kconfig | 9 ++++ drivers/hwmon/pmbus/Makefile | 1 +drivers/hwmon/pmbus/bcm6123.c| 90 +++++++++++++++++++++++++++++++++++
Documentation/hwmon/bcm6123is missing.Quoted 8 lines
3 files changed, 100 insertions(+)create mode 100644
drivers/hwmon/pmbus/bcm6123.cdrivers/hwmon/pmbus/Kconfig +0
-0@@ -48,6 +48,15 @@ config SENSORS_ADM1275Quoted 4 lines
This driver can also be built as a module. If so, the module will be called adm1275.
+configSENSORS_BCM6123
+ tristate "Vicor BCM6123 Compatible Power Supplies"Is this a power supply or a chip ? It can't be both.
Quoted 28 lines
+ help
+ If you say yes here you get hardware monitoring support for Vicor + BCM6123 Power Supplies.drivers/hwmon/pmbus/Kconfig +4
-0+ + This driver can also be built as a module. If so, the module will + be called bcm6123. +config
SENSORS_BEL_PFE
tristate "Bel PFE Compatible Power Supplies" helpdrivers/hwmon/pmbus/Makefile +0
-0@@ -7,6 +7,7 @@ obj-$(CONFIG_PMBUS) += pmbus_core.oobj-$(CONFIG_SENSORS_PMBUS) += pmbus.o obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o +obj-$(CONFIG_SENSORS_BCM6123) += bcm6123.o obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o obj-$(CONFIG_SENSORS_BPA_RS600) += bpa-rs600.o obj-$(CONFIG_SENSORS_DELTA_AHE50DC_FAN) += delta-ahe50dc-fan.o
drivers/hwmon/pmbus/bcm6123.c new file +0
-0drivers/hwmon/pmbus/bcm6123.c line 4
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +4
-0@@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Hardware monitoring driver for Infineon bcm6123 +* Infineon ?
drivers/hwmon/pmbus/bcm6123.c line 9
Quoted 5 lines
drivers/hwmon/pmbus/bcm6123.c new file +5
-0+* Copyright (c) 2021 9elements GmbH +* +* VOUT_MODE is not supported by the device. The driver fakes VOUT linear16 +* mode with exponent value -8 as direct mode with m=256/b=0/R=0. +* Does it not ? The datasheet doesn't say, and the code below doesn't match this description.
Quoted 6 lines
Quoted 6 lines
drivers/hwmon/pmbus/bcm6123.c line 11
Quoted 2 lines
drivers/hwmon/pmbus/bcm6123.c new file +2
-0+* The device supports VOUT_PEAK, IOUT_PEAK, and TEMPERATURE_PEAK, however +* this driver does not currently support them. Does it ? There is no reference for this in the datasheet.
Overall it seems like there is a lot of cut-and-paste. Please clean this up.
Sorry. Looks like it is not related to this driver and should be removed.
Quoted 16 lines
Quoted 16 lines
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +3
-0+*/ + +#include <linux/err.h> drivers/hwmon/pmbus/bcm6123.c line 24
Quoted 10 lines
drivers/hwmon/pmbus/bcm6123.c new file +10
-0+#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/pmbus.h> +#include "pmbus.h" + +static struct pmbus_platform_data bcm6123_plat_data = { + .flags = PMBUS_NO_CAPABILITY, +};We should only set this flag if it is really needed.
The capability command did not return valid information during testing. e.g. it claimed PEC is supported and caused therefore unexpected issues. I'll test it again to see if it's necessary for the driver to work.
Quoted 35 lines
Quoted 19 lines
Quoted 19 lines
drivers/hwmon/pmbus/bcm6123.c new file +18
-0+ +static struct pmbus_driver_info bcm6123_info = { + .pages = 2, + .format[PSC_VOLTAGE_IN] = direct, + .format[PSC_VOLTAGE_OUT] = direct, + .format[PSC_CURRENT_IN] = direct, + .format[PSC_CURRENT_OUT] = direct, + .format[PSC_POWER] = linear, + .format[PSC_TEMPERATURE] = linear, + .m[PSC_VOLTAGE_IN] = 1, + .b[PSC_VOLTAGE_IN] = 0, + .R[PSC_VOLTAGE_IN] = 1, + .m[PSC_VOLTAGE_OUT] = 1, + .b[PSC_VOLTAGE_OUT] = 0, + .R[PSC_VOLTAGE_OUT] = 1, + .m[PSC_CURRENT_IN] = 1, + .b[PSC_CURRENT_IN] = 0, + .R[PSC_CURRENT_IN] = 3,Quoted 9 lines
drivers/hwmon/pmbus/bcm6123.c line 46
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +4
-0+ .m[PSC_CURRENT_OUT] = 1, + .b[PSC_CURRENT_OUT] = 0, + .R[PSC_CURRENT_OUT] = 2, + .func[0] = 0, /* Summing page without voltage readings */This needs further explanation. The public datasheet doesn't say anything about multiple pages, and it doesn't really make much sense to have an "empty" page with no information in it.
Digging further, there is actually a digital supervisor (D44TL1A0) which is used to access BCM6123, and there can be up to 4 BCM6123 connected to D44TL1A0. Page 0 is the supervisor, and pages 1..4 provide data for the connected BCM6123s. Page 0 does report various telemetry values, which should be supported. Pages 2..4 should be supported as well.
Quoted 5 lines
Question is if the driver should be named after the supervisor or after the voltage converter; I'll leave that up to you. Either case it needs to support all five pages.
Guenter
After Digging further ourselves, it looks like our hardware also contains a digital supervisor IC (PLI1209BC), which is connected to one BCM6123 only. Unfortunately, we were not able to find the data sheet before:
https://www.vicorpower.com/documents/datasheets/ds-PLI1209BCxyzz-VICOR.pdf
This explains why there are two pages in our case. Since there are different hardware configurations it would make more sense to name this driver after the supervisor.
I'll rework this patch set and implement the PLI1209BC properly.
Marcello
Quoted 48 lines
Quoted 47 lines
Quoted 46 lines
drivers/hwmon/pmbus/bcm6123.c new file +44
-0+ .func[1] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT + | PMBUS_HAVE_IIN | PMBUS_HAVE_POUT, +}; + +static int bcm6123_probe (struct i2c_client *client) +{ + client->dev.platform_data = &bcm6123_plat_data; + + return pmbus_do_probe(client, &bcm6123_info); +} + +static const struct i2c_device_id bcm6123_id[] = { + {"bcm6123", 0}, + {} +}; + +MODULE_DEVICE_TABLE (i2c, bcm6123_id); + +#ifdef CONFIG_OF +static const struct of_device_id bcm6123_of_match[] = { + { .compatible = "vicor,bcm6123" }, + { }, +}; +MODULE_DEVICE_TABLE (of, bcm6123_of_match); +#endif + +/* This is the driver that will be inserted */ +static struct i2c_driver bcm6123_driver = { + .driver = { + .name = "bcm6123", + .of_match_table = of_match_ptr(bcm6123_of_match), + }, + .probe_new = bcm6123_probe, + .id_table = bcm6123_id, +}; + +module_i2c_driver (bcm6123_driver); + +MODULE_AUTHOR ("Patrick Rudolph <[email protected]>" ); +MODULE_DESCRIPTION ("PMBus driver for Vicor bcm6123" ); +MODULE_LICENSE ("GPL" );
Guenter Roeck
maintainerRe: [PATCH v1 4/4] pmbus: Add support for bcm6123 Bus Converter
Quoted 152 lines · sylv
Quoted 73 lines · Guenter Roeck
Quoted 72 lines · Guenter Roeck
Quoted 10 lines · Marcello Sylvester Bauer
From: Patrick Rudolph <[email protected]>
BCM6123 is an Fixed-Ratio DC-DC Converter.
Signed-off-by Patrick Rudolph <[email protected]>Signed-off-by Marcello Sylvester Bauer <[email protected]>--- drivers/hwmon/pmbus/Kconfig | 9 ++++ drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/bcm6123.c | 90 +++++++++++++++++++++++++++++++++++
Documentation/hwmon/bcm6123is missing.drivers/hwmon/pmbus/Kconfig config SENSORS_ADM1275 · line 51
Quoted 12 lines
3 files changed, 100 insertions(+)create mode 100644
drivers/hwmon/pmbus/bcm6123.cdrivers/hwmon/pmbus/Kconfig +2
-0@@ -48,6 +48,15 @@ config SENSORS_ADM1275 This driver can also be built as a module. If so, the module will be called adm1275. +config SENSORS_BCM6123 + tristate "Vicor BCM6123 Compatible Power Supplies"Is this a power supply or a chip ? It can't be both.
Quoted 28 lines
drivers/hwmon/pmbus/Kconfig +7
-0+ help + If you say yes here you get hardware monitoring support for Vicor + BCM6123 Power Supplies. + + This driver can also be built as a module. If so, the module will + be called bcm6123. + config SENSORS_BEL_PFE tristate "Bel PFE Compatible Power Supplies" helpdrivers/hwmon/pmbus/Makefile +1
-0@@ -7,6 +7,7 @@ obj-$(CONFIG_PMBUS) += pmbus_core.o obj-$(CONFIG_SENSORS_PMBUS) += pmbus.o obj-$(CONFIG_SENSORS_ADM1266) += adm1266.o obj-$(CONFIG_SENSORS_ADM1275) += adm1275.o +obj-$(CONFIG_SENSORS_BCM6123) += bcm6123.o obj-$(CONFIG_SENSORS_BEL_PFE) += bel-pfe.o obj-$(CONFIG_SENSORS_BPA_RS600) += bpa-rs600.o obj-$(CONFIG_SENSORS_DELTA_AHE50DC_FAN) += delta-ahe50dc-fan.odrivers/hwmon/pmbus/bcm6123.c new file +0
-0drivers/hwmon/pmbus/bcm6123.c line 4
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +4
-0@@ -0,0 +1,90 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* +* Hardware monitoring driver for Infineon bcm6123 +* Infineon ?
drivers/hwmon/pmbus/bcm6123.c line 9
Quoted 5 lines
drivers/hwmon/pmbus/bcm6123.c new file +5
-0+* Copyright (c) 2021 9elements GmbH +* +* VOUT_MODE is not supported by the device. The driver fakes VOUT linear16 +* mode with exponent value -8 as direct mode with m=256/b=0/R=0. +* Does it not ? The datasheet doesn't say, and the code below doesn't match this description.
Quoted 6 lines
Quoted 6 lines
drivers/hwmon/pmbus/bcm6123.c line 11
Quoted 2 lines
drivers/hwmon/pmbus/bcm6123.c new file +2
-0+* The device supports VOUT_PEAK, IOUT_PEAK, and TEMPERATURE_PEAK, however +* this driver does not currently support them. Does it ? There is no reference for this in the datasheet.
Overall it seems like there is a lot of cut-and-paste. Please clean this up.
Sorry. Looks like it is not related to this driver and should be removed.
Quoted 16 lines
Quoted 16 lines
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +3
-0+*/ + +#include <linux/err.h> drivers/hwmon/pmbus/bcm6123.c line 24
Quoted 10 lines
drivers/hwmon/pmbus/bcm6123.c new file +10
-0+#include <linux/i2c.h> +#include <linux/init.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/pmbus.h> +#include "pmbus.h" + +static struct pmbus_platform_data bcm6123_plat_data = { + .flags = PMBUS_NO_CAPABILITY, +};We should only set this flag if it is really needed.
The capability command did not return valid information during testing. e.g. it claimed PEC is supported and caused therefore unexpected issues. I'll test it again to see if it's necessary for the driver to work.
Quoted 35 lines
Quoted 19 lines
Quoted 19 lines
drivers/hwmon/pmbus/bcm6123.c new file +18
-0+ +static struct pmbus_driver_info bcm6123_info = { + .pages = 2, + .format[PSC_VOLTAGE_IN] = direct, + .format[PSC_VOLTAGE_OUT] = direct, + .format[PSC_CURRENT_IN] = direct, + .format[PSC_CURRENT_OUT] = direct, + .format[PSC_POWER] = linear, + .format[PSC_TEMPERATURE] = linear, + .m[PSC_VOLTAGE_IN] = 1, + .b[PSC_VOLTAGE_IN] = 0, + .R[PSC_VOLTAGE_IN] = 1, + .m[PSC_VOLTAGE_OUT] = 1, + .b[PSC_VOLTAGE_OUT] = 0, + .R[PSC_VOLTAGE_OUT] = 1, + .m[PSC_CURRENT_IN] = 1, + .b[PSC_CURRENT_IN] = 0, + .R[PSC_CURRENT_IN] = 3,Quoted 9 lines
drivers/hwmon/pmbus/bcm6123.c line 46
Quoted 4 lines
drivers/hwmon/pmbus/bcm6123.c new file +4
-0+ .m[PSC_CURRENT_OUT] = 1, + .b[PSC_CURRENT_OUT] = 0, + .R[PSC_CURRENT_OUT] = 2, + .func[0] = 0, /* Summing page without voltage readings */This needs further explanation. The public datasheet doesn't say anything about multiple pages, and it doesn't really make much sense to have an "empty" page with no information in it.
Digging further, there is actually a digital supervisor (D44TL1A0) which is used to access BCM6123, and there can be up to 4 BCM6123 connected to D44TL1A0. Page 0 is the supervisor, and pages 1..4 provide data for the connected BCM6123s. Page 0 does report various telemetry values, which should be supported. Pages 2..4 should be supported as well.
Quoted 5 lines
Question is if the driver should be named after the supervisor or after the voltage converter; I'll leave that up to you. Either case it needs to support all five pages.
Guenter
After Digging further ourselves, it looks like our hardware also contains a digital supervisor IC (PLI1209BC), which is connected to one BCM6123 only. Unfortunately, we were not able to find the data sheet before:
Quoted 7 lines
https://www.vicorpower.com/documents/datasheets/ds-PLI1209BCxyzz-VICOR.pdf
This explains why there are two pages in our case. Since there are different hardware configurations it would make more sense to name this driver after the supervisor.I'll rework this patch set and implement the PLI1209BC properly.
Apparently there are (at least) two different supervisor chips, PLI1209BC and D44TL1A0. Given that, it is ok if you only implement support for PLI1209BC is that is what you use, but the driver name should indeed reflect the supervisor chip to ensure that support for the other supervisor chip can be added at a later point.
Thanks,
Guenter
Quoted 51 lines
Marcello
Quoted 48 lines
Quoted 47 lines
Quoted 46 lines
drivers/hwmon/pmbus/bcm6123.c new file +44
-0+ .func[1] = PMBUS_HAVE_VIN | PMBUS_HAVE_STATUS_INPUT + | PMBUS_HAVE_TEMP | PMBUS_HAVE_STATUS_TEMP + | PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT + | PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT + | PMBUS_HAVE_IIN | PMBUS_HAVE_POUT, +}; + +static int bcm6123_probe (struct i2c_client *client) +{ + client->dev.platform_data = &bcm6123_plat_data; + + return pmbus_do_probe(client, &bcm6123_info); +} + +static const struct i2c_device_id bcm6123_id[] = { + {"bcm6123", 0}, + {} +}; + +MODULE_DEVICE_TABLE (i2c, bcm6123_id); + +#ifdef CONFIG_OF +static const struct of_device_id bcm6123_of_match[] = { + { .compatible = "vicor,bcm6123" }, + { }, +}; +MODULE_DEVICE_TABLE (of, bcm6123_of_match); +#endif + +/* This is the driver that will be inserted */ +static struct i2c_driver bcm6123_driver = { + .driver = { + .name = "bcm6123", + .of_match_table = of_match_ptr(bcm6123_of_match), + }, + .probe_new = bcm6123_probe, + .id_table = bcm6123_id, +}; + +module_i2c_driver (bcm6123_driver); + +MODULE_AUTHOR ("Patrick Rudolph <[email protected]>" ); +MODULE_DESCRIPTION ("PMBus driver for Vicor bcm6123" ); +MODULE_LICENSE ("GPL" );
Hi,
since this driver actually implements the supervisor pli1209bc, see this patch set as discontinued. A new patch set will be uploaded soon.
Thanks,
Marcello
Quoted 24 lines · Marcello Sylvester Bauer
Hi,
This patchset adds support for BCM6123 Bus Converter from Vicor Corporation.
Marcello Sylvester Bauer (3):
dt-bindings: vendor-prefixes: add Vicor Corporation
dt-bindings: hwmon/pmbus: Add vicor,bcm6123 Bus Converter
pmbus: remove trailing whitespacesPatrick Rudolph (1):
pmbus: Add support for bcm6123 Bus Converter.../bindings/hwmon/pmbus/vicor,bcm6123.yaml | 41 +++++++++ .../devicetree/bindings/vendor-prefixes.yaml | 2 + drivers/hwmon/pmbus/Kconfig | 13 ++- drivers/hwmon/pmbus/Makefile | 1 + drivers/hwmon/pmbus/bcm6123.c | 90
+++++++++++++++++++5 files changed, 145 insertions(+), 2 deletions(-)create mode 100644
Documentation/devicetree/bindings/hwmon/pmbus/vicor,bcm6123.yamlcreate mode 100644drivers/hwmon/pmbus/bcm6123.c