Delete useless module.h|moduleparam.h includes
Subsystems (7)
cover Delete useless module.h|moduleparam.h includes
From: Leon Romanovsky <[email protected]>
Nothing fancy, just delete module.h|moduleparam.h from files that don't need these includes at all.
Thanks
Leon Romanovsky (11):
RDMA/mlx5: Delete useless module.h include
RDMA/core: Delete useless module.h include
RDMA/hfi1: Delete useless module.h include
RDMA/mlx4: Delete useless module.h include
RDMA/mthca: Delete useless module.h include
RDMA/qib: Delete useless module.h include
RDMA/usnic: Delete useless module.h include
RDMA/rxe: Delete useless module.h include
RDMA/ipoib: Delete useless module.h include
RDMA/iser: Delete useless module.h include
RDMA/opa: Delete useless module.h include
drivers/infiniband/core/addr.c | 1 - drivers/infiniband/core/cache.c | 1 - drivers/infiniband/core/cma_configfs.c | 1 - drivers/infiniband/core/cq.c | 1 - drivers/infiniband/core/iwpm_util.h | 1 - drivers/infiniband/core/sa_query.c | 1 - drivers/infiniband/hw/hfi1/affinity.c | 1 - drivers/infiniband/hw/hfi1/debugfs.c | 1 - drivers/infiniband/hw/hfi1/device.c | 1 - drivers/infiniband/hw/hfi1/fault.c | 1 - drivers/infiniband/hw/hfi1/firmware.c | 1 - drivers/infiniband/hw/mlx4/alias_GUID.c | 1 - drivers/infiniband/hw/mlx5/ib_virt.c | 1 - drivers/infiniband/hw/mlx5/mem.c | 1 - drivers/infiniband/hw/mlx5/qp.c | 1 - drivers/infiniband/hw/mlx5/srq.c | 1 - drivers/infiniband/hw/mthca/mthca_profile.c | 2 -- drivers/infiniband/hw/qib/qib_fs.c | 1 - drivers/infiniband/hw/usnic/usnic_debugfs.c | 1 - drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 1 - drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 1 - drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 1 - drivers/infiniband/hw/usnic/usnic_transport.c | 1 - drivers/infiniband/hw/usnic/usnic_vnic.c | 1 - drivers/infiniband/sw/rxe/rxe.h | 1 - drivers/infiniband/sw/rxe/rxe_mmap.c | 1 - drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 1 - drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 1 - drivers/infiniband/ulp/iser/iser_memory.c | 1 - drivers/infiniband/ulp/iser/iser_verbs.c | 1 - drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c | 1 - 31 files changed, 32 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/11 RDMA/mlx5: Delete useless module.h include
From: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/hw/mlx5/ib_virt.c | 1 - drivers/infiniband/hw/mlx5/mem.c | 1 - drivers/infiniband/hw/mlx5/qp.c | 1 - drivers/infiniband/hw/mlx5/srq.c | 1 - 4 files changed, 4 deletions(-)
drivers/infiniband/hw/mlx5/ib_virt.c +0 -1
@@ -30,7 +30,6 @@* SOFTWARE. */ -#include <linux/module.h> #include <linux/mlx5/vport.h> #include "mlx5_ib.h"
drivers/infiniband/hw/mlx5/mem.c +0 -1
@@ -30,7 +30,6 @@* SOFTWARE. */ -#include <linux/module.h> #include <rdma/ib_umem.h> #include <rdma/ib_umem_odp.h> #include "mlx5_ib.h"
drivers/infiniband/hw/mlx5/qp.c +0 -1
@@ -31,7 +31,6 @@*/ #include <linux/etherdevice.h> -#include <linux/module.h> #include <rdma/ib_umem.h> #include <rdma/ib_cache.h> #include <rdma/ib_user_verbs.h>
drivers/infiniband/hw/mlx5/srq.c +0 -1
@@ -3,7 +3,6 @@* Copyright (c) 2013-2018, Mellanox Technologies inc. All rights reserved. */ -#include <linux/module.h> #include <linux/mlx5/qp.h> #include <linux/slab.h> #include <rdma/ib_umem.h>
Signature · 1 line
2.34.1
PATCH 2/11 RDMA/core: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/core/addr.c | 1 - drivers/infiniband/core/cache.c | 1 - drivers/infiniband/core/cma_configfs.c | 1 - drivers/infiniband/core/cq.c | 1 - drivers/infiniband/core/iwpm_util.h | 1 - drivers/infiniband/core/sa_query.c | 1 - 6 files changed, 6 deletions(-)
drivers/infiniband/core/addr.c +0 -1
@@ -37,7 +37,6 @@#include <linux/inetdevice.h> #include <linux/slab.h> #include <linux/workqueue.h> -#include <linux/module.h> #include <net/arp.h> #include <net/neighbour.h> #include <net/route.h>
drivers/infiniband/core/cache.c +0 -1
@@ -34,7 +34,6 @@*/ #include <linux/if_vlan.h> -#include <linux/module.h> #include <linux/errno.h> #include <linux/slab.h> #include <linux/workqueue.h>
drivers/infiniband/core/cma_configfs.c +0 -1
@@ -30,7 +30,6 @@* SOFTWARE. */ -#include <linux/module.h> #include <linux/configfs.h> #include <rdma/ib_verbs.h> #include <rdma/rdma_cm.h>
drivers/infiniband/core/cq.c +0 -1
@@ -2,7 +2,6 @@/* * Copyright (c) 2015 HGST, a Western Digital Company. */ -#include <linux/module.h> #include <linux/err.h> #include <linux/slab.h> #include <rdma/ib_verbs.h>
drivers/infiniband/core/iwpm_util.h +0 -1
@@ -33,7 +33,6 @@#ifndef _IWPM_UTIL_H#define _IWPM_UTIL_H -#include <linux/module.h> #include <linux/io.h> #include <linux/in.h> #include <linux/in6.h>
drivers/infiniband/core/sa_query.c +0 -1
@@ -32,7 +32,6 @@* SOFTWARE. */ -#include <linux/module.h> #include <linux/init.h> #include <linux/err.h> #include <linux/random.h>
Signature · 1 line
2.34.1
PATCH 3/11 RDMA/hfi1: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/hw/hfi1/affinity.c | 1 - drivers/infiniband/hw/hfi1/debugfs.c | 1 - drivers/infiniband/hw/hfi1/device.c | 1 - drivers/infiniband/hw/hfi1/fault.c | 1 - drivers/infiniband/hw/hfi1/firmware.c | 1 - 5 files changed, 5 deletions(-)
drivers/infiniband/hw/hfi1/affinity.c +0 -1
@@ -5,7 +5,6 @@#include <linux/topology.h> #include <linux/cpumask.h> -#include <linux/module.h> #include <linux/interrupt.h> #include <linux/numa.h>
drivers/infiniband/hw/hfi1/debugfs.c +0 -1
@@ -7,7 +7,6 @@#include <linux/seq_file.h> #include <linux/kernel.h> #include <linux/export.h> -#include <linux/module.h> #include <linux/string.h> #include <linux/types.h> #include <linux/ratelimit.h>
drivers/infiniband/hw/hfi1/device.c +0 -1
@@ -4,7 +4,6 @@*/ #include <linux/cdev.h> -#include <linux/module.h> #include <linux/device.h> #include <linux/fs.h>
drivers/infiniband/hw/hfi1/fault.c +0 -1
@@ -6,7 +6,6 @@#include <linux/debugfs.h> #include <linux/seq_file.h> #include <linux/kernel.h> -#include <linux/module.h> #include <linux/types.h> #include <linux/bitmap.h>
drivers/infiniband/hw/hfi1/firmware.c +0 -1
@@ -5,7 +5,6 @@#include <linux/firmware.h> #include <linux/mutex.h> -#include <linux/module.h> #include <linux/delay.h> #include <linux/crc32.h>
Signature · 1 line
2.34.1
PATCH 4/11 RDMA/mlx4: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/hw/mlx4/alias_GUID.c | 1 - 1 file changed, 1 deletion(-)
drivers/infiniband/hw/mlx4/alias_GUID.c +0 -1
@@ -38,7 +38,6 @@#include <rdma/ib_sa.h> #include <rdma/ib_pack.h> #include <linux/mlx4/cmd.h> -#include <linux/module.h> #include <linux/init.h> #include <linux/errno.h> #include <rdma/ib_user_verbs.h>
Signature · 1 line
2.34.1
PATCH 5/11 RDMA/mthca: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following file.
--- drivers/infiniband/hw/mthca/mthca_profile.c | 2 -- 1 file changed, 2 deletions(-)
drivers/infiniband/hw/mthca/mthca_profile.c +0 -2
@@ -31,8 +31,6 @@* SOFTWARE. */ -#include <linux/module.h> -#include <linux/moduleparam.h> #include <linux/string.h> #include <linux/slab.h>
Signature · 1 line
2.34.1
PATCH 6/11 RDMA/qib: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following file.
--- drivers/infiniband/hw/qib/qib_fs.c | 1 - 1 file changed, 1 deletion(-)
drivers/infiniband/hw/qib/qib_fs.c +0 -1
@@ -32,7 +32,6 @@* SOFTWARE. */ -#include <linux/module.h> #include <linux/fs.h> #include <linux/fs_context.h> #include <linux/mount.h>
Signature · 1 line
2.34.1
PATCH 7/11 RDMA/usnic: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/hw/usnic/usnic_debugfs.c | 1 - drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 1 - drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 1 - drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 1 - drivers/infiniband/hw/usnic/usnic_transport.c | 1 - drivers/infiniband/hw/usnic/usnic_vnic.c | 1 - 6 files changed, 6 deletions(-)
drivers/infiniband/hw/usnic/usnic_debugfs.c +0 -1
@@ -32,7 +32,6 @@*/ #include <linux/debugfs.h> -#include <linux/module.h> #include "usnic.h" #include "usnic_log.h"
drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c +0 -1
@@ -32,7 +32,6 @@*/ #include <linux/bug.h> #include <linux/errno.h> -#include <linux/module.h> #include <linux/spinlock.h> #include "usnic_log.h"
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c +0 -1
@@ -31,7 +31,6 @@* */ -#include <linux/module.h> #include <linux/init.h> #include <linux/errno.h>
drivers/infiniband/hw/usnic/usnic_ib_verbs.c +0 -1
@@ -30,7 +30,6 @@* SOFTWARE. * */ -#include <linux/module.h> #include <linux/init.h> #include <linux/slab.h> #include <linux/errno.h>
drivers/infiniband/hw/usnic/usnic_transport.c +0 -1
@@ -32,7 +32,6 @@*/ #include <linux/bitmap.h> #include <linux/file.h> -#include <linux/module.h> #include <linux/slab.h> #include <net/inet_sock.h>
drivers/infiniband/hw/usnic/usnic_vnic.c +0 -1
@@ -31,7 +31,6 @@* */ #include <linux/errno.h> -#include <linux/module.h> #include <linux/pci.h> #include "usnic_ib.h"
Signature · 1 line
2.34.1
PATCH 8/11 RDMA/rxe: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/sw/rxe/rxe.h | 1 - drivers/infiniband/sw/rxe/rxe_mmap.c | 1 - 2 files changed, 2 deletions(-)
drivers/infiniband/sw/rxe/rxe.h +0 -1
@@ -12,7 +12,6 @@#endif #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt -#include <linux/module.h> #include <linux/skbuff.h> #include <rdma/ib_verbs.h>
drivers/infiniband/sw/rxe/rxe_mmap.c +0 -1
@@ -4,7 +4,6 @@* Copyright (c) 2015 System Fabric Works, Inc. All rights reserved. */ -#include <linux/module.h> #include <linux/vmalloc.h> #include <linux/mm.h> #include <linux/errno.h>
Signature · 1 line
2.34.1
Re: [PATCH rdma-next 08/11] RDMA/rxe: Delete useless module.h include
Quoted 6 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
There is no need in include of
module.hin the following files.Signed-off-by Leon Romanovsky <[email protected]>
Thanks a lot.
Zhu Yanjun
Quoted 32 lines
--- drivers/infiniband/sw/rxe/rxe.h | 1 - drivers/infiniband/sw/rxe/rxe_mmap.c | 1 - 2 files changed, 2 deletions(-)drivers/infiniband/sw/rxe/rxe.h +0
-1@@ -12,7 +12,6 @@#endif #define pr_fmt (fmt) KBUILD_MODNAME ": " fmt -#include <linux/module.h> #include <linux/skbuff.h> #include <rdma/ib_verbs.h> drivers/infiniband/sw/rxe/rxe_mmap.c +0
-2@@ -4,7 +4,6 @@* Copyright (c) 2015 System Fabric Works, Inc. All rights reserved. */ -#include <linux/module.h> #include <linux/vmalloc.h> #include <linux/mm.h> #include <linux/errno.h> --2.34.1
PATCH 9/11 RDMA/ipoib: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 1 - drivers/infiniband/ulp/ipoib/ipoib_vlan.c | 1 - 2 files changed, 2 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_netlink.c +0 -1
@@ -32,7 +32,6 @@#include <linux/netdevice.h> #include <linux/if_arp.h> /* For ARPHRD_xxx */ -#include <linux/module.h> #include <net/rtnetlink.h> #include "ipoib.h"
drivers/infiniband/ulp/ipoib/ipoib_vlan.c +0 -1
@@ -30,7 +30,6 @@* SOFTWARE. */ -#include <linux/module.h> #include <linux/sched/signal.h> #include <linux/init.h>
Signature · 1 line
2.34.1
PATCH 10/11 RDMA/iser: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following files.
--- drivers/infiniband/ulp/iser/iser_memory.c | 1 - drivers/infiniband/ulp/iser/iser_verbs.c | 1 - 2 files changed, 2 deletions(-)
drivers/infiniband/ulp/iser/iser_memory.c +0 -1
@@ -30,7 +30,6 @@* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ -#include <linux/module.h> #include <linux/kernel.h> #include <linux/slab.h> #include <linux/mm.h>
drivers/infiniband/ulp/iser/iser_verbs.c +0 -1
@@ -32,7 +32,6 @@* SOFTWARE. */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/slab.h> #include <linux/delay.h>
Signature · 1 line
2.34.1
Re: [PATCH rdma-next 10/11] RDMA/iser: Delete useless module.h include
Quoted 27 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
There is no need in include of
module.hin the following files.Signed-off-by Leon Romanovsky <[email protected]>--- drivers/infiniband/ulp/iser/iser_memory.c | 1 - drivers/infiniband/ulp/iser/iser_verbs.c | 1 - 2 files changed, 2 deletions(-)drivers/infiniband/ulp/iser/iser_memory.c +0
-1@@ -30,7 +30,6 @@* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. */ -#include <linux/module.h> #include <linux/kernel.h> #include <linux/slab.h> #include <linux/mm.h> drivers/infiniband/ulp/iser/iser_verbs.c +0
-0
drivers/infiniband/ulp/iser/iser_verbs.c line 37
Quoted 7 lines
drivers/infiniband/ulp/iser/iser_verbs.c +0
-1@@ -32,7 +32,6 @@* SOFTWARE. */ #include <linux/kernel.h> -#include <linux/module.h> #include <linux/slab.h> #include <linux/delay.h>
Looks good thanks,
PATCH 11/11 RDMA/opa: Delete useless module.h include
In reply to Leon RomanovskyFrom: Leon Romanovsky <[email protected]>
There is no need in include of module.h in the following file.
--- drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c | 1 - 1 file changed, 1 deletion(-)
drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c +0 -1
@@ -50,7 +50,6 @@* netdev functionality. */ -#include <linux/module.h> #include <linux/if_vlan.h> #include <linux/crc32.h>
Signature · 1 line
2.34.1
Quoted 7 lines · Leon Romanovsky
From: Leon Romanovsky <[email protected]>
Nothing fancy, just delete module.h|moduleparam.h from files that don't need these includes at all.
Thanks
Quoted 12 lines
Leon Romanovsky (11):
RDMA/mlx5: Delete uselessmodule.hinclude
RDMA/core: Delete uselessmodule.hinclude
RDMA/hfi1: Delete uselessmodule.hinclude
RDMA/mlx4: Delete uselessmodule.hinclude
RDMA/mthca: Delete uselessmodule.hinclude
RDMA/qib: Delete uselessmodule.hinclude
RDMA/usnic: Delete uselessmodule.hinclude
RDMA/rxe: Delete uselessmodule.hinclude
RDMA/ipoib: Delete uselessmodule.hinclude
RDMA/iser: Delete uselessmodule.hinclude
RDMA/opa: Delete uselessmodule.hinclude
Applied to for-next, thanks
Jason