Skip to contentSkip to conversation

Delete useless module.h|moduleparam.h includes

PATCH Applied Leon Romanovsky 4 participants 15 messages Jan 23, 2022 – Jan 28, 2022

Subsystems (7)
lore
Share & tools
lore
#0 lore raw

cover Delete useless module.h|moduleparam.h includes

From: Leon Romanovsky <[email protected]>

Nothing fancy, just delete module.h|moduleparam.h from files that don't need these includes at all.

Thanks

Leon Romanovsky (11):
RDMA/mlx5: Delete useless module.h include
RDMA/core: Delete useless module.h include
RDMA/hfi1: Delete useless module.h include
RDMA/mlx4: Delete useless module.h include
RDMA/mthca: Delete useless module.h include
RDMA/qib: Delete useless module.h include
RDMA/usnic: Delete useless module.h include
RDMA/rxe: Delete useless module.h include
RDMA/ipoib: Delete useless module.h include
RDMA/iser: Delete useless module.h include
RDMA/opa: Delete useless module.h include

 drivers/infiniband/core/addr.c                    | 1 -
 drivers/infiniband/core/cache.c                   | 1 -
 drivers/infiniband/core/cma_configfs.c            | 1 -
 drivers/infiniband/core/cq.c                      | 1 -
 drivers/infiniband/core/iwpm_util.h               | 1 -
 drivers/infiniband/core/sa_query.c                | 1 -
 drivers/infiniband/hw/hfi1/affinity.c             | 1 -
 drivers/infiniband/hw/hfi1/debugfs.c              | 1 -
 drivers/infiniband/hw/hfi1/device.c               | 1 -
 drivers/infiniband/hw/hfi1/fault.c                | 1 -
 drivers/infiniband/hw/hfi1/firmware.c             | 1 -
 drivers/infiniband/hw/mlx4/alias_GUID.c           | 1 -
 drivers/infiniband/hw/mlx5/ib_virt.c              | 1 -
 drivers/infiniband/hw/mlx5/mem.c                  | 1 -
 drivers/infiniband/hw/mlx5/qp.c                   | 1 -
 drivers/infiniband/hw/mlx5/srq.c                  | 1 -
 drivers/infiniband/hw/mthca/mthca_profile.c       | 2 --
 drivers/infiniband/hw/qib/qib_fs.c                | 1 -
 drivers/infiniband/hw/usnic/usnic_debugfs.c       | 1 -
 drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c     | 1 -
 drivers/infiniband/hw/usnic/usnic_ib_sysfs.c      | 1 -
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c      | 1 -
 drivers/infiniband/hw/usnic/usnic_transport.c     | 1 -
 drivers/infiniband/hw/usnic/usnic_vnic.c          | 1 -
 drivers/infiniband/sw/rxe/rxe.h                   | 1 -
 drivers/infiniband/sw/rxe/rxe_mmap.c              | 1 -
 drivers/infiniband/ulp/ipoib/ipoib_netlink.c      | 1 -
 drivers/infiniband/ulp/ipoib/ipoib_vlan.c         | 1 -
 drivers/infiniband/ulp/iser/iser_memory.c         | 1 -
 drivers/infiniband/ulp/iser/iser_verbs.c          | 1 -
 drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c | 1 -
 31 files changed, 32 deletions(-)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/11 RDMA/mlx5: Delete useless module.h include

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/hw/mlx5/ib_virt.c | 1 -
 drivers/infiniband/hw/mlx5/mem.c     | 1 -
 drivers/infiniband/hw/mlx5/qp.c      | 1 -
 drivers/infiniband/hw/mlx5/srq.c     | 1 -
 4 files changed, 4 deletions(-)
drivers/infiniband/hw/mlx5/ib_virt.c +0 -1
index f2f62875d072..afeb5e53254f 100644
@@ -30,7 +30,6 @@
  * SOFTWARE.
  */
 
-#include <linux/module.h>
 #include <linux/mlx5/vport.h>
 #include "mlx5_ib.h"
 
drivers/infiniband/hw/mlx5/mem.c +0 -1
index 844545064c9e..6191aa833ac2 100644
@@ -30,7 +30,6 @@
  * SOFTWARE.
  */
 
-#include <linux/module.h>
 #include <rdma/ib_umem.h>
 #include <rdma/ib_umem_odp.h>
 #include "mlx5_ib.h"
drivers/infiniband/hw/mlx5/qp.c +0 -1
index 4f325a844c93..8fa6570caa1b 100644
@@ -31,7 +31,6 @@
  */
 
 #include <linux/etherdevice.h>
-#include <linux/module.h>
 #include <rdma/ib_umem.h>
 #include <rdma/ib_cache.h>
 #include <rdma/ib_user_verbs.h>
drivers/infiniband/hw/mlx5/srq.c +0 -1
index 0694e9cba8d3..757756c50cc6 100644
@@ -3,7 +3,6 @@
  * Copyright (c) 2013-2018, Mellanox Technologies inc.  All rights reserved.
  */
 
-#include <linux/module.h>
 #include <linux/mlx5/qp.h>
 #include <linux/slab.h>
 #include <rdma/ib_umem.h>
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/11 RDMA/core: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/core/addr.c         | 1 -
 drivers/infiniband/core/cache.c        | 1 -
 drivers/infiniband/core/cma_configfs.c | 1 -
 drivers/infiniband/core/cq.c           | 1 -
 drivers/infiniband/core/iwpm_util.h    | 1 -
 drivers/infiniband/core/sa_query.c     | 1 -
 6 files changed, 6 deletions(-)
drivers/infiniband/core/addr.c +0 -1
index 65e3e7df8a4b..f253295795f0 100644
@@ -37,7 +37,6 @@
 #include <linux/inetdevice.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
-#include <linux/module.h>
 #include <net/arp.h>
 #include <net/neighbour.h>
 #include <net/route.h>
drivers/infiniband/core/cache.c +0 -1
index f6aa1a964573..4084d05a4510 100644
@@ -34,7 +34,6 @@
  */
 
 #include <linux/if_vlan.h>
-#include <linux/module.h>
 #include <linux/errno.h>
 #include <linux/slab.h>
 #include <linux/workqueue.h>
drivers/infiniband/core/cma_configfs.c +0 -1
index 9ac16e0db761..de8a2d5d741c 100644
@@ -30,7 +30,6 @@
  * SOFTWARE.
  */
 
-#include <linux/module.h>
 #include <linux/configfs.h>
 #include <rdma/ib_verbs.h>
 #include <rdma/rdma_cm.h>
drivers/infiniband/core/cq.c +0 -1
index 433b426729d4..a70876a0a231 100644
@@ -2,7 +2,6 @@
 /*
  * Copyright (c) 2015 HGST, a Western Digital Company.
  */
-#include <linux/module.h>
 #include <linux/err.h>
 #include <linux/slab.h>
 #include <rdma/ib_verbs.h>
drivers/infiniband/core/iwpm_util.h +0 -1
index 3a42ad43056e..d6fc8402158a 100644
@@ -33,7 +33,6 @@
 #ifndef _IWPM_UTIL_H
 #define _IWPM_UTIL_H
 
-#include <linux/module.h>
 #include <linux/io.h>
 #include <linux/in.h>
 #include <linux/in6.h>
drivers/infiniband/core/sa_query.c +0 -1
index 74ecd7456a11..8dc7d1f4b35d 100644
@@ -32,7 +32,6 @@
  * SOFTWARE.
  */
 
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/err.h>
 #include <linux/random.h>
Signature · 1 line
2.34.1
#3 lore raw

PATCH 3/11 RDMA/hfi1: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/hw/hfi1/affinity.c | 1 -
 drivers/infiniband/hw/hfi1/debugfs.c  | 1 -
 drivers/infiniband/hw/hfi1/device.c   | 1 -
 drivers/infiniband/hw/hfi1/fault.c    | 1 -
 drivers/infiniband/hw/hfi1/firmware.c | 1 -
 5 files changed, 5 deletions(-)
drivers/infiniband/hw/hfi1/affinity.c +0 -1
index 98c813ba4304..706b3b659713 100644
@@ -5,7 +5,6 @@
 
 #include <linux/topology.h>
 #include <linux/cpumask.h>
-#include <linux/module.h>
 #include <linux/interrupt.h>
 #include <linux/numa.h>
 
drivers/infiniband/hw/hfi1/debugfs.c +0 -1
index 22a3cdb940be..80ba1e53c068 100644
@@ -7,7 +7,6 @@
 #include <linux/seq_file.h>
 #include <linux/kernel.h>
 #include <linux/export.h>
-#include <linux/module.h>
 #include <linux/string.h>
 #include <linux/types.h>
 #include <linux/ratelimit.h>
drivers/infiniband/hw/hfi1/device.c +0 -1
index 68a184c39941..8ceff7141baf 100644
@@ -4,7 +4,6 @@
  */
 
 #include <linux/cdev.h>
-#include <linux/module.h>
 #include <linux/device.h>
 #include <linux/fs.h>
 
drivers/infiniband/hw/hfi1/fault.c +0 -1
index e2e4f9f6fae2..3af77a0840ab 100644
@@ -6,7 +6,6 @@
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
 #include <linux/kernel.h>
-#include <linux/module.h>
 #include <linux/types.h>
 #include <linux/bitmap.h>
 
drivers/infiniband/hw/hfi1/firmware.c +0 -1
index 31e63e245ea9..aa15a5cc7cf3 100644
@@ -5,7 +5,6 @@
 
 #include <linux/firmware.h>
 #include <linux/mutex.h>
-#include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/crc32.h>
 
Signature · 1 line
2.34.1
#4 lore raw

PATCH 4/11 RDMA/mlx4: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/hw/mlx4/alias_GUID.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/hw/mlx4/alias_GUID.c +0 -1
index e2e1f5daddc4..111fa88a3be4 100644
@@ -38,7 +38,6 @@
 #include <rdma/ib_sa.h>
 #include <rdma/ib_pack.h>
 #include <linux/mlx4/cmd.h>
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/errno.h>
 #include <rdma/ib_user_verbs.h>
Signature · 1 line
2.34.1
#5 lore raw

PATCH 5/11 RDMA/mthca: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following file.

---
 drivers/infiniband/hw/mthca/mthca_profile.c | 2 --
 1 file changed, 2 deletions(-)
drivers/infiniband/hw/mthca/mthca_profile.c +0 -2
index 7ea970774839..69af65f1b332 100644
@@ -31,8 +31,6 @@
  * SOFTWARE.
  */
 
-#include <linux/module.h>
-#include <linux/moduleparam.h>
 #include <linux/string.h>
 #include <linux/slab.h>
 
Signature · 1 line
2.34.1
#6 lore raw

PATCH 6/11 RDMA/qib: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following file.

---
 drivers/infiniband/hw/qib/qib_fs.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/hw/qib/qib_fs.c +0 -1
index a0c5f3bdc324..a973905afd13 100644
@@ -32,7 +32,6 @@
  * SOFTWARE.
  */
 
-#include <linux/module.h>
 #include <linux/fs.h>
 #include <linux/fs_context.h>
 #include <linux/mount.h>
Signature · 1 line
2.34.1
#7 lore raw

PATCH 7/11 RDMA/usnic: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/hw/usnic/usnic_debugfs.c   | 1 -
 drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 1 -
 drivers/infiniband/hw/usnic/usnic_ib_sysfs.c  | 1 -
 drivers/infiniband/hw/usnic/usnic_ib_verbs.c  | 1 -
 drivers/infiniband/hw/usnic/usnic_transport.c | 1 -
 drivers/infiniband/hw/usnic/usnic_vnic.c      | 1 -
 6 files changed, 6 deletions(-)
drivers/infiniband/hw/usnic/usnic_debugfs.c +0 -1
index e5a3f02fb078..10a8cd5ba076 100644
@@ -32,7 +32,6 @@
  */
 
 #include <linux/debugfs.h>
-#include <linux/module.h>
 
 #include "usnic.h"
 #include "usnic_log.h"
drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c +0 -1
index 3b60fa9cb58d..59bfbfaee325 100644
@@ -32,7 +32,6 @@
  */
 #include <linux/bug.h>
 #include <linux/errno.h>
-#include <linux/module.h>
 #include <linux/spinlock.h>
 
 #include "usnic_log.h"
drivers/infiniband/hw/usnic/usnic_ib_sysfs.c +0 -1
index 7d868f033bbf..fdb63a8fb997 100644
@@ -31,7 +31,6 @@
  *
  */
 
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/errno.h>
 
drivers/infiniband/hw/usnic/usnic_ib_verbs.c +0 -1
index 5a0e26cd648e..d3a9670bf971 100644
@@ -30,7 +30,6 @@
  * SOFTWARE.
  *
  */
-#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/slab.h>
 #include <linux/errno.h>
drivers/infiniband/hw/usnic/usnic_transport.c +0 -1
index 82dd810bc000..dc37066900a5 100644
@@ -32,7 +32,6 @@
  */
 #include <linux/bitmap.h>
 #include <linux/file.h>
-#include <linux/module.h>
 #include <linux/slab.h>
 #include <net/inet_sock.h>
 
drivers/infiniband/hw/usnic/usnic_vnic.c +0 -1
index ebe08f348453..0c47f73aaed5 100644
@@ -31,7 +31,6 @@
  *
  */
 #include <linux/errno.h>
-#include <linux/module.h>
 #include <linux/pci.h>
 
 #include "usnic_ib.h"
Signature · 1 line
2.34.1
#8 lore raw

PATCH 8/11 RDMA/rxe: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/sw/rxe/rxe.h      | 1 -
 drivers/infiniband/sw/rxe/rxe_mmap.c | 1 -
 2 files changed, 2 deletions(-)
drivers/infiniband/sw/rxe/rxe.h +0 -1
index fb9066e6f5f0..30fbdf3bc76a 100644
@@ -12,7 +12,6 @@
 #endif
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <linux/module.h>
 #include <linux/skbuff.h>
 
 #include <rdma/ib_verbs.h>
drivers/infiniband/sw/rxe/rxe_mmap.c +0 -1
index 035f226af133..9149b6095429 100644
@@ -4,7 +4,6 @@
  * Copyright (c) 2015 System Fabric Works, Inc. All rights reserved.
  */
 
-#include <linux/module.h>
 #include <linux/vmalloc.h>
 #include <linux/mm.h>
 #include <linux/errno.h>
Signature · 1 line
2.34.1
maintainer Acked-by on v1 8/11
#9 lore raw

Re: [PATCH rdma-next 08/11] RDMA/rxe: Delete useless module.h include

Quoted 6 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

Thanks a lot.

Zhu Yanjun

Quoted 32 lines
---
 drivers/infiniband/sw/rxe/rxe.h      | 1 -
 drivers/infiniband/sw/rxe/rxe_mmap.c | 1 -
 2 files changed, 2 deletions(-)
drivers/infiniband/sw/rxe/rxe.h +0 -1
index fb9066e6f5f0..30fbdf3bc76a 100644
@@ -12,7 +12,6 @@
 #endif
 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 
-#include <linux/module.h>
 #include <linux/skbuff.h>
 
 #include <rdma/ib_verbs.h>
drivers/infiniband/sw/rxe/rxe_mmap.c +0 -2
index 035f226af133..9149b6095429 100644
@@ -4,7 +4,6 @@
  * Copyright (c) 2015 System Fabric Works, Inc. All rights reserved.
  */
 
-#include <linux/module.h>
 #include <linux/vmalloc.h>
 #include <linux/mm.h>
 #include <linux/errno.h>
--

2.34.1

#10 lore raw

PATCH 9/11 RDMA/ipoib: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/ulp/ipoib/ipoib_netlink.c | 1 -
 drivers/infiniband/ulp/ipoib/ipoib_vlan.c    | 1 -
 2 files changed, 2 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_netlink.c +0 -1
index 5b05cf3837da..ea16ba5d8da6 100644
@@ -32,7 +32,6 @@
 
 #include <linux/netdevice.h>
 #include <linux/if_arp.h>      /* For ARPHRD_xxx */
-#include <linux/module.h>
 #include <net/rtnetlink.h>
 #include "ipoib.h"
 
drivers/infiniband/ulp/ipoib/ipoib_vlan.c +0 -1
index 0322dc75396f..4bd161e86f8d 100644
@@ -30,7 +30,6 @@
  * SOFTWARE.
  */
 
-#include <linux/module.h>
 #include <linux/sched/signal.h>
 
 #include <linux/init.h>
Signature · 1 line
2.34.1
#11 lore raw

PATCH 10/11 RDMA/iser: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
 drivers/infiniband/ulp/iser/iser_memory.c | 1 -
 drivers/infiniband/ulp/iser/iser_verbs.c  | 1 -
 2 files changed, 2 deletions(-)
drivers/infiniband/ulp/iser/iser_memory.c +0 -1
index 660982625488..f1fd05d8609d 100644
@@ -30,7 +30,6 @@
  * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-#include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/mm.h>
drivers/infiniband/ulp/iser/iser_verbs.c +0 -1
index 8bf87b073d9b..8893bc27d8f5 100644
@@ -32,7 +32,6 @@
  * SOFTWARE.
  */
 #include <linux/kernel.h>
-#include <linux/module.h>
 #include <linux/slab.h>
 #include <linux/delay.h>
 
Signature · 1 line
2.34.1
maintainer Acked-by on v1 10/11
#12 lore raw

Re: [PATCH rdma-next 10/11] RDMA/iser: Delete useless module.h include

Quoted 27 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following files.

---
  drivers/infiniband/ulp/iser/iser_memory.c | 1 -
  drivers/infiniband/ulp/iser/iser_verbs.c  | 1 -
  2 files changed, 2 deletions(-)
drivers/infiniband/ulp/iser/iser_memory.c +0 -1
index 660982625488..f1fd05d8609d 100644
@@ -30,7 +30,6 @@
   * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
   * SOFTWARE.
   */
-#include <linux/module.h>
  #include <linux/kernel.h>
  #include <linux/slab.h>
  #include <linux/mm.h>
drivers/infiniband/ulp/iser/iser_verbs.c +0 -0
index 8bf87b073d9b..8893bc27d8f5 100644

drivers/infiniband/ulp/iser/iser_verbs.c line 37

Quoted 7 lines
drivers/infiniband/ulp/iser/iser_verbs.c +0 -1
@@ -32,7 +32,6 @@
   * SOFTWARE.
   */
  #include <linux/kernel.h>
-#include <linux/module.h>
  #include <linux/slab.h>
  #include <linux/delay.h>
 

Looks good thanks,

#13 lore raw

PATCH 11/11 RDMA/opa: Delete useless module.h include

In reply to Leon Romanovsky

From: Leon Romanovsky <[email protected]>

There is no need in include of module.h in the following file.

---
 drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c | 1 -
 1 file changed, 1 deletion(-)
drivers/infiniband/ulp/opa_vnic/opa_vnic_netdev.c +0 -1
index aeff68f582d3..071f35711468 100644
@@ -50,7 +50,6 @@
  * netdev functionality.
  */
 
-#include <linux/module.h>
 #include <linux/if_vlan.h>
 #include <linux/crc32.h>
 
Signature · 1 line
2.34.1
maintainer Applied
#14 lore raw
In reply to Leon Romanovsky
Quoted 7 lines · Leon Romanovsky

From: Leon Romanovsky <[email protected]>

Nothing fancy, just delete module.h|moduleparam.h from files that don't need these includes at all.

Thanks

Quoted 12 lines

Leon Romanovsky (11):
RDMA/mlx5: Delete useless module.h include
RDMA/core: Delete useless module.h include
RDMA/hfi1: Delete useless module.h include
RDMA/mlx4: Delete useless module.h include
RDMA/mthca: Delete useless module.h include
RDMA/qib: Delete useless module.h include
RDMA/usnic: Delete useless module.h include
RDMA/rxe: Delete useless module.h include
RDMA/ipoib: Delete useless module.h include
RDMA/iser: Delete useless module.h include
RDMA/opa: Delete useless module.h include

Applied to for-next, thanks

Jason