dt-bindings: timer: sifive, clint: Miscellaneous improvements
v4 cover dt-bindings: timer: sifive, clint: Miscellaneous improvements
Hi all,
This patch series contains two improvements for the SiFive CLINT DT bindings.
Changes compared to v3[1]:
- Use architectural maximum instead of practical maximum of 10,
- Add Reviewed-by (this time for real ;-).
Changes compared to v2[2]:
- Add Acked-by, Reviewed-by.
Changes compared to v1[3]:
- Split in two patches,
- Improve patch description and document limit rationale.
Thanks!
[1] https://lore.kernel.org/r/[email protected]/
[2] https://lore.kernel.org/r/[email protected]
[3] https://lore.kernel.org/r/[email protected]
Geert Uytterhoeven (2):
dt-bindings: timer: sifive,clint: Fix number of interrupts
dt-bindings: timer: sifive,clint: Group interrupt tuples
.../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
Signature · 12 lines
2.25.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus TorvaldsPATCH v4 2/2 dt-bindings: timer: sifive,clint: Group interrupt tuples
To improve human readability and enable automatic validation, the tuples in "interrupts-extended" properties should be grouped using angle brackets.
---
v4:
- Add Reviewed-by (this time for real ;-),
v3:
- Add Reviewed-by,
v2:
- Split in two patches.
--- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/timer/sifive,clint.yaml +4 -4
@@ -57,10 +57,10 @@ examples: - | timer@2000000 { compatible = "sifive,fu540-c000-clint", "sifive,clint0"; - interrupts-extended = <&cpu1intc 3 &cpu1intc 7 - &cpu2intc 3 &cpu2intc 7 - &cpu3intc 3 &cpu3intc 7 - &cpu4intc 3 &cpu4intc 7>; + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>, + <&cpu2intc 3>, <&cpu2intc 7>, + <&cpu3intc 3>, <&cpu3intc 7>, + <&cpu4intc 3>, <&cpu4intc 7>; reg = <0x2000000 0x10000>; }; ...
Signature · 7 lines
2.25.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
PATCH v4 1/2 dt-bindings: timer: sifive,clint: Fix number of interrupts
In reply to Geert UytterhoevenThe number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make dtbs_check".
Fix this by adding the missing "maxItems", using the architectural maximum of 4095 interrupts.
---
v4:
- Use architectural maximum instead of practical maximum of 10,
v3:
- Add Acked-by,
v2:
- Split in two patches,
- Improve patch description and document limit rationale.
--- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/timer/sifive,clint.yaml +1 -0
@@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 4095 additionalProperties: false
Signature · 7 lines
2.25.1 _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v4 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts
Quoted 10 lines · Geert Uytterhoeven
The number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make
dtbs_check".Fix this by adding the missing "maxItems", using the architectural maximum of 4095 interrupts.
Signed-off-by Geert Uytterhoeven <[email protected]>Acked-by Rob Herring <[email protected]>
Looks good to me.
Regards,
Anup
Quoted 34 lines
---
v4:
- Use architectural maximum instead of practical maximum of 10,v3:
- Add Acked-by,v2:
- Split in two patches,
- Improve patch description and document limit rationale.--- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/timer/sifive,clint.yaml +1
-1@@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 4095 additionalProperties: false --2.25.1
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v4 2/2] dt-bindings: timer: sifive, clint: Group interrupt tuples
In reply to Geert UytterhoevenQuoted 7 lines · Geert Uytterhoeven
To improve human readability and enable automatic validation, the tuples in "interrupts-extended" properties should be grouped using angle brackets.
Signed-off-by Geert Uytterhoeven <[email protected]>Reviewed-by Rob Herring <[email protected]>
Looks good to me.
Regards,
Anup
Quoted 40 lines
---
v4:
- Add Reviewed-by (this time for real ;-),v3:
- Add Reviewed-by,v2:
- Split in two patches.--- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)Documentation/devicetree/bindings/timer/sifive,clint.yaml +4
-5@@ -57,10 +57,10 @@ examples: - | timer@2000000 { compatible = "sifive,fu540-c000-clint", "sifive,clint0"; - interrupts-extended = <&cpu1intc 3 &cpu1intc 7 - &cpu2intc 3 &cpu2intc 7 - &cpu3intc 3 &cpu3intc 7 - &cpu4intc 3 &cpu4intc 7>; + interrupts-extended = <&cpu1intc 3>, <&cpu1intc 7>, + <&cpu2intc 3>, <&cpu2intc 7>, + <&cpu3intc 3>, <&cpu3intc 7>, + <&cpu4intc 3>, <&cpu4intc 7>; reg = <0x2000000 0x10000>; }; --2.25.1
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Re: [PATCH v4 1/2] dt-bindings: timer: sifive, clint: Fix number of interrupts
In reply to Geert UytterhoevenQuoted 36 lines
The number of interrupts lacks an upper bound, thus assuming one, causing properly grouped "interrupts-extended" properties to be flagged as an error by "make
dtbs_check".Fix this by adding the missing "maxItems", using the architectural maximum of 4095 interrupts.
Signed-off-by Geert Uytterhoeven <[email protected]>Acked-by Rob Herring <[email protected]>---
v4:
- Use architectural maximum instead of practical maximum of 10,v3:
- Add Acked-by,v2:
- Split in two patches,
- Improve patch description and document limit rationale.--- Documentation/devicetree/bindings/timer/sifive,clint.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/timer/sifive,clint.yaml +1
-1@@ -44,6 +44,7 @@ properties: interrupts-extended: minItems: 1 + maxItems: 4095 additionalProperties: false --
Quoted 1 line
2.25.1
Clears errors on the icicle dt, so fwiw: Acked-by: Conor Dooley <[email protected]>
Quoted 23 lines · Geert Uytterhoeven
Hi all,
This patch series contains two improvements for the SiFive CLINT DT bindings.
Changes compared to v3[1]:
- Use architectural maximum instead of practical maximum of 10,
- Add Reviewed-by (this time for real ;-).Changes compared to v2[2]:
- Add Acked-by, Reviewed-by.Changes compared to v1[3]:
- Split in two patches,
- Improve patch description and document limit rationale.Thanks!
[1] https://lore.kernel.org/r/[email protected]/
[2] https://lore.kernel.org/r/[email protected]
[3] https://lore.kernel.org/r/[email protected]
Quoted 6 lines
Geert Uytterhoeven (2):
dt-bindings: timer: sifive,clint: Fix number of interrupts
dt-bindings: timer: sifive,clint: Group interrupt tuples.../devicetree/bindings/timer/sifive,clint.yaml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-)
As these have not been picked up yet, I've applied them.
Rob