drm/i915/dmc: cleanups
Subsystems (4)
cover drm/i915/dmc: cleanups
Clean up dmc code to hide details better in intel_dmc.c.
Jani Nikula (8):
drm/i915/dmc: simplify intel_dmc_load_program() conditions drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c drm/i915/dmc: move dmc debugfs to intel_dmc.c drm/i915/dmc: fix i915_reg_t usage
drm/i915/dmc: don't register DMC debugfs file if there's no DMC drm/i915/dmc: abstract GPU error state dump drm/i915/dmc: hide DMC version macros
drm/i915/dmc: split out dmc registers to a separate file
.../drm/i915/display/intel_display_debugfs.c | 75 +---------- .../drm/i915/display/intel_display_power.c | 18 +-- drivers/gpu/drm/i915/display/intel_dmc.c | 125 ++++++++++++++++-- drivers/gpu/drm/i915/display/intel_dmc.h | 10 +- drivers/gpu/drm/i915/display/intel_dmc_regs.h | 31 +++++ drivers/gpu/drm/i915/gvt/handlers.c | 1 + drivers/gpu/drm/i915/i915_gpu_error.c | 10 +- drivers/gpu/drm/i915/i915_reg.h | 21 --- 8 files changed, 158 insertions(+), 133 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_regs.h
Signature · 1 line
2.30.2
PATCH 1/8 drm/i915/dmc: simplify intel_dmc_load_program() conditions
intel_dmc_load_program() is only ever called when intel_dmc_has_payload() is true. Move the condition within intel_dmc_load_program() to let it be called directly.
Also note that intel_dmc_has_payload() will always return false when HAS_DMC() is false. Remove the redundant check.
--- drivers/gpu/drm/i915/display/intel_display_power.c | 6 +++--- drivers/gpu/drm/i915/display/intel_dmc.c | 11 +---------- 2 files changed, 4 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +3 -3
@@ -5387,7 +5387,7 @@ static void skl_display_core_init(struct drm_i915_private *dev_priv,gen9_dbuf_enable (dev_priv); -if (resume &&intel_dmc_has_payload (dev_priv)) +if (resume)intel_dmc_load_program (dev_priv); }
@@ -5454,7 +5454,7 @@ static void bxt_display_core_init(struct drm_i915_private *dev_priv, bool resumegen9_dbuf_enable (dev_priv); -if (resume &&intel_dmc_has_payload (dev_priv)) +if (resume)intel_dmc_load_program (dev_priv); }
@@ -5618,7 +5618,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,if (IS_DG2 (dev_priv))intel_snps_phy_wait_for_calibration (dev_priv); -if (resume &&intel_dmc_has_payload (dev_priv)) +if (resume)intel_dmc_load_program (dev_priv);/* Wa_14011508470:tgl,dg1,rkl,adl-s,adl-p */
drivers/gpu/drm/i915/display/intel_dmc.c +1 -10
@@ -276,17 +276,8 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv)struct intel_dmc *dmc = &dev_priv->dmc;u32 id, i; -if (!HAS_DMC (dev_priv)) { -drm_err (&dev_priv->drm, -"No DMC support available for this platform\n" ); -return ; - } - -if (!dev_priv->dmc.dmc_info[DMC_FW_MAIN ].payload) { -drm_err (&dev_priv->drm, -"Tried to program CSR with empty payload\n" ); +if (!intel_dmc_has_payload (dev_priv))return ; - }assert_rpm_wakelock_held (&dev_priv->runtime_pm);
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 1/8] drm/i915/dmc: simplify intel_dmc_load_program() conditions
Quoted 8 lines · Jani Nikula
intel_dmc_load_program()is only ever called whenintel_dmc_has_payload()is true. Move the condition withinintel_dmc_load_program()to let it be called directly.Also note that
intel_dmc_has_payload()will always return false whenHAS_DMC()is false. Remove the redundant check.Signed-off-by Jani Nikula <[email protected]>
Lucas De Marchi
Quoted 62 lines
---
drivers/gpu/drm/i915/display/intel_display_power.c| 6 +++---drivers/gpu/drm/i915/display/intel_dmc.c| 11 +----------2 files changed, 4 insertions(+), 13 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +3
-3@@ -5387,7 +5387,7 @@ static void skl_display_core_init(struct drm_i915_private *dev_priv,gen9_dbuf_enable (dev_priv); -if (resume &&intel_dmc_has_payload (dev_priv)) +if (resume)intel_dmc_load_program (dev_priv); }@@ -5454,7 +5454,7 @@ static void bxt_display_core_init(struct drm_i915_private *dev_priv, bool resumegen9_dbuf_enable (dev_priv); -if (resume &&intel_dmc_has_payload (dev_priv)) +if (resume)intel_dmc_load_program (dev_priv); }@@ -5618,7 +5618,7 @@ static void icl_display_core_init(struct drm_i915_private *dev_priv,if (IS_DG2 (dev_priv))intel_snps_phy_wait_for_calibration (dev_priv); -if (resume &&intel_dmc_has_payload (dev_priv)) +if (resume)intel_dmc_load_program (dev_priv);/* Wa_14011508470:tgl,dg1,rkl,adl-s,adl-p */ drivers/gpu/drm/i915/display/intel_dmc.c +1
-10@@ -276,17 +276,8 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv)struct intel_dmc *dmc = &dev_priv->dmc;u32 id, i; -if (!HAS_DMC (dev_priv)) { -drm_err (&dev_priv->drm, -"No DMC support available for this platform\n" ); -return ; - } - -if (!dev_priv->dmc.dmc_info[DMC_FW_MAIN ].payload) { -drm_err (&dev_priv->drm, -"Tried to program CSR with empty payload\n" ); +if (!intel_dmc_has_payload (dev_priv))return ; - }assert_rpm_wakelock_held (&dev_priv->runtime_pm);Signature · 1 line
2.30.2
PATCH 2/8 drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c
In reply to Jani NikulaStart localizing DMC register and data access to intel_dmc.c.
--- drivers/gpu/drm/i915/display/intel_display_power.c | 12 ------------ drivers/gpu/drm/i915/display/intel_dmc.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 2 ++ 3 files changed, 13 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power.c +0 -12
@@ -905,18 +905,6 @@ static void bxt_disable_dc9(struct drm_i915_private *dev_priv)intel_pps_unlock_regs_wa (dev_priv); } -static void assert_dmc_loaded (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, - !intel_de_read (dev_priv, -DMC_PROGRAM (dev_priv->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), -"DMC program storage start is NULL\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_SSP_BASE ), -"DMC SSP Base Not fine\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_HTP_SKL ), -"DMC HTP Not fine\n" ); -} -/** * intel_display_power_set_target_dc_state - Set target dc state. * @dev_priv: i915 device
drivers/gpu/drm/i915/display/intel_dmc.c +11 -0
@@ -305,6 +305,17 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv)gen9_set_dc_state_debugmask (dev_priv); } +void assert_dmc_loaded (struct drm_i915_private *i915) +{ +drm_WARN_ONCE (&i915->drm, + !intel_de_read (i915,DMC_PROGRAM (i915->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), +"DMC program storage start is NULL\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_SSP_BASE ), +"DMC SSP Base Not fine\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_HTP_SKL ), +"DMC HTP Not fine\n" ); +} +static bool fw_info_matches_stepping (const struct intel_fw_info *fw_info,const struct stepping_info *si) {
drivers/gpu/drm/i915/display/intel_dmc.h +2 -0
@@ -55,4 +55,6 @@ void intel_dmc_ucode_suspend(struct drm_i915_private *i915);void intel_dmc_ucode_resume (struct drm_i915_private *i915);bool intel_dmc_has_payload (struct drm_i915_private *i915); +void assert_dmc_loaded (struct drm_i915_private *i915); +#endif /* __INTEL_DMC_H__ */
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 2/8] drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c
Quoted 59 lines · Jani Nikula
Start localizing DMC register and data access to
intel_dmc.c.Signed-off-by Jani Nikula <[email protected]>---
drivers/gpu/drm/i915/display/intel_display_power.c | 12 ------------ drivers/gpu/drm/i915/display/intel_dmc.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 2 ++ 3 files changed, 13 insertions(+), 12 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-12@@ -905,18 +905,6 @@ static void bxt_disable_dc9(struct drm_i915_private *dev_priv)intel_pps_unlock_regs_wa (dev_priv); } -static void assert_dmc_loaded (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, - !intel_de_read (dev_priv, -DMC_PROGRAM (dev_priv->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), -"DMC program storage start is NULL\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_SSP_BASE ), -"DMC SSP Base Not fine\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_HTP_SKL ), -"DMC HTP Not fine\n" ); -} -/** * intel_display_power_set_target_dc_state - Set target dc state. * @dev_priv: i915 device drivers/gpu/drm/i915/display/intel_dmc.c +11
-0@@ -305,6 +305,17 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv)gen9_set_dc_state_debugmask (dev_priv); } +void assert_dmc_loaded (struct drm_i915_private *i915) +{ +drm_WARN_ONCE (&i915->drm, + !intel_de_read (i915,DMC_PROGRAM (i915->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), +"DMC program storage start is NULL\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_SSP_BASE ), +"DMC SSP Base Not fine\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_HTP_SKL ), +"DMC HTP Not fine\n" ); +} +static bool fw_info_matches_stepping (const struct intel_fw_info *fw_info,const struct stepping_info *si) {drivers/gpu/drm/i915/display/intel_dmc.h +0
-0
drivers/gpu/drm/i915/display/intel_dmc.h void intel_dmc_ucode_suspend(struct drm_i915_private *i915); · line 58
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dmc.h +1
-0@@ -55,4 +55,6 @@ void intel_dmc_ucode_suspend(struct drm_i915_private *i915);void intel_dmc_ucode_resume (struct drm_i915_private *i915);bool intel_dmc_has_payload (struct drm_i915_private *i915); +void assert_dmc_loaded (struct drm_i915_private *i915);
intel_dmc_assert_loaded()?
Lucas De Marchi
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dmc.h +1
-0+#endif /* __INTEL_DMC_H__ */ Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 2/8] drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c
Quoted 63 lines · Lucas De Marchi
Quoted 62 lines · Jani Nikula
Start localizing DMC register and data access to
intel_dmc.c.Signed-off-by Jani Nikula <[email protected]>---
drivers/gpu/drm/i915/display/intel_display_power.c | 12 ------------ drivers/gpu/drm/i915/display/intel_dmc.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 2 ++ 3 files changed, 13 insertions(+), 12 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-12@@ -905,18 +905,6 @@ static void bxt_disable_dc9(struct drm_i915_private *dev_priv)intel_pps_unlock_regs_wa (dev_priv); } -static void assert_dmc_loaded (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, - !intel_de_read (dev_priv, -DMC_PROGRAM (dev_priv->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), -"DMC program storage start is NULL\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_SSP_BASE ), -"DMC SSP Base Not fine\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_HTP_SKL ), -"DMC HTP Not fine\n" ); -} -/** * intel_display_power_set_target_dc_state - Set target dc state. * @dev_priv: i915 device drivers/gpu/drm/i915/display/intel_dmc.c +11
-0@@ -305,6 +305,17 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv)gen9_set_dc_state_debugmask (dev_priv); } +void assert_dmc_loaded (struct drm_i915_private *i915) +{ +drm_WARN_ONCE (&i915->drm, + !intel_de_read (i915,DMC_PROGRAM (i915->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), +"DMC program storage start is NULL\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_SSP_BASE ), +"DMC SSP Base Not fine\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_HTP_SKL ), +"DMC HTP Not fine\n" ); +} +static bool fw_info_matches_stepping (const struct intel_fw_info *fw_info,const struct stepping_info *si) {drivers/gpu/drm/i915/display/intel_dmc.h +0
-0@@ -55,4 +55,6 @@ void intel_dmc_ucode_suspend(struct drm_i915_private *i915);void intel_dmc_ucode_resume (struct drm_i915_private *i915);bool intel_dmc_has_payload (struct drm_i915_private *i915);
Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dmc.h void intel_dmc_ucode_suspend(struct drm_i915_private *i915); · line 58
Quoted 1 line
drivers/gpu/drm/i915/display/intel_dmc.h +1
-0+void assert_dmc_loaded (struct drm_i915_private *i915);
intel_dmc_assert_loaded()?
assert_dmc_loaded() is in line with the display asserts we have:
git grep assert_ -- drivers/gpu/drm/i915/display/*.h
I'd rather stick with that convention for now, and moving away from it should be a separate conversation.
BR,
Jani.
Quoted 8 lines
Lucas De Marchi
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dmc.h +1
-0+#endif /* __INTEL_DMC_H__ */ Signature · 1 line
2.30.2
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Lucas De Marchi
Reviewed-byRe: [Intel-gfx] [PATCH 2/8] drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c
Quoted 69 lines · Jani Nikula
Quoted 63 lines · Lucas De Marchi
Quoted 62 lines · Jani Nikula
Start localizing DMC register and data access to
intel_dmc.c.Signed-off-by Jani Nikula <[email protected]>---
drivers/gpu/drm/i915/display/intel_display_power.c | 12 ------------ drivers/gpu/drm/i915/display/intel_dmc.c | 11 +++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 2 ++ 3 files changed, 13 insertions(+), 12 deletions(-)drivers/gpu/drm/i915/display/intel_display_power.c +0
-12@@ -905,18 +905,6 @@ static void bxt_disable_dc9(struct drm_i915_private *dev_priv)intel_pps_unlock_regs_wa (dev_priv); } -static void assert_dmc_loaded (struct drm_i915_private *dev_priv) -{ -drm_WARN_ONCE (&dev_priv->drm, - !intel_de_read (dev_priv, -DMC_PROGRAM (dev_priv->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), -"DMC program storage start is NULL\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_SSP_BASE ), -"DMC SSP Base Not fine\n" ); -drm_WARN_ONCE (&dev_priv->drm, !intel_de_read (dev_priv,DMC_HTP_SKL ), -"DMC HTP Not fine\n" ); -} -/** * intel_display_power_set_target_dc_state - Set target dc state. * @dev_priv: i915 device drivers/gpu/drm/i915/display/intel_dmc.c +11
-0@@ -305,6 +305,17 @@ void intel_dmc_load_program(struct drm_i915_private *dev_priv)gen9_set_dc_state_debugmask (dev_priv); } +void assert_dmc_loaded (struct drm_i915_private *i915) +{ +drm_WARN_ONCE (&i915->drm, + !intel_de_read (i915,DMC_PROGRAM (i915->dmc.dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 )), +"DMC program storage start is NULL\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_SSP_BASE ), +"DMC SSP Base Not fine\n" ); +drm_WARN_ONCE (&i915->drm, !intel_de_read (i915,DMC_HTP_SKL ), +"DMC HTP Not fine\n" ); +} +static bool fw_info_matches_stepping (const struct intel_fw_info *fw_info,const struct stepping_info *si) {drivers/gpu/drm/i915/display/intel_dmc.h +0
-0@@ -55,4 +55,6 @@ void intel_dmc_ucode_suspend(struct drm_i915_private *i915);void intel_dmc_ucode_resume (struct drm_i915_private *i915);bool intel_dmc_has_payload (struct drm_i915_private *i915);Quoted 4 lines
drivers/gpu/drm/i915/display/intel_dmc.h void intel_dmc_ucode_suspend(struct drm_i915_private *i915); · line 58
Quoted 1 line
drivers/gpu/drm/i915/display/intel_dmc.h +1
-0+void assert_dmc_loaded (struct drm_i915_private *i915);
intel_dmc_assert_loaded()?
Quoted 6 lines
assert_dmc_loaded()is in line with the display asserts we have:git grep
assert_--drivers/gpu/drm/i915/display/*.hI'd rather stick with that convention for now, and moving away from it should be a separate conversation.
ok, fair enough.
thanks
Lucas De Marchi
Quoted 15 lines
BR,
Jani.Quoted 8 lines
Lucas De Marchi
Quoted 5 lines
drivers/gpu/drm/i915/display/intel_dmc.h +1
-1+#endif /* __INTEL_DMC_H__ */ --2.30.2
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
PATCH 3/8 drm/i915/dmc: move dmc debugfs to intel_dmc.c
In reply to Jani NikulaContinue localizing DMC register and data access to intel_dmc.c.
--- .../drm/i915/display/intel_display_debugfs.c | 75 +---------------- drivers/gpu/drm/i915/display/intel_dmc.c | 83 +++++++++++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 1 + 3 files changed, 85 insertions(+), 74 deletions(-)
drivers/gpu/drm/i915/display/intel_display_debugfs.c +1 -74
@@ -436,79 +436,6 @@ static int i915_power_domain_info(struct seq_file *m, void *unused)return 0 ; } -static int i915_dmc_info (struct seq_file *m,void *unused) -{ -struct drm_i915_private *dev_priv =node_to_i915 (m->private); -intel_wakeref_t wakeref; -struct intel_dmc *dmc; -i915_reg_t dc5_reg, dc6_reg = {}; - -if (!HAS_DMC (dev_priv)) -return -ENODEV ; - - dmc = &dev_priv->dmc; - - wakeref =intel_runtime_pm_get (&dev_priv->runtime_pm); - -seq_printf (m,"fw loaded: %s\n" , -str_yes_no (intel_dmc_has_payload (dev_priv))); -seq_printf (m,"path: %s\n" , dmc->fw_path); -seq_printf (m,"Pipe A fw support: %s\n" , -str_yes_no (GRAPHICS_VER (dev_priv) >=12 )); -seq_printf (m,"Pipe A fw loaded: %s\n" , -str_yes_no (dmc->dmc_info[DMC_FW_PIPEA ].payload)); -seq_printf (m,"Pipe B fw support: %s\n" , -str_yes_no (IS_ALDERLAKE_P (dev_priv))); -seq_printf (m,"Pipe B fw loaded: %s\n" , -str_yes_no (dmc->dmc_info[DMC_FW_PIPEB ].payload)); - -if (!intel_dmc_has_payload (dev_priv)) - goto out; - -seq_printf (m,"version: %d.%d\n" ,DMC_VERSION_MAJOR (dmc->version), -DMC_VERSION_MINOR (dmc->version)); - -if (DISPLAY_VER (dev_priv) >=12 ) { -if (IS_DGFX (dev_priv)) { - dc5_reg =DG1_DMC_DEBUG_DC5_COUNT ; - }else { - dc5_reg =TGL_DMC_DEBUG_DC5_COUNT ; - dc6_reg =TGL_DMC_DEBUG_DC6_COUNT ; - } - -/* -* NOTE: DMC_DEBUG3 is a general purpose reg. -* According to B.Specs:49196 DMC f/w reuses DC5/6 counter -* reg for DC3CO debugging and validation, -* but TGL DMC f/w is using DMC_DEBUG3 reg for DC3CO counter. -*/ -seq_printf (m,"DC3CO count: %d\n" ,intel_de_read (dev_priv,IS_DGFX (dev_priv) ? -DG1_DMC_DEBUG3 :TGL_DMC_DEBUG3 )); - }else { - dc5_reg =IS_BROXTON (dev_priv) ?BXT_DMC_DC3_DC5_COUNT : -SKL_DMC_DC3_DC5_COUNT ; -if (!IS_GEMINILAKE (dev_priv) && !IS_BROXTON (dev_priv)) - dc6_reg =SKL_DMC_DC5_DC6_COUNT ; - } - -seq_printf (m,"DC3 -> DC5 count: %d\n" , -intel_de_read (dev_priv, dc5_reg)); -if (dc6_reg.reg) -seq_printf (m,"DC5 -> DC6 count: %d\n" , -intel_de_read (dev_priv, dc6_reg)); - -out: -seq_printf (m,"program base: 0x%08x\n" , -intel_de_read (dev_priv,DMC_PROGRAM (dmc->dmc_info[DMC_FW_MAIN ].start_mmioaddr,0 ))); -seq_printf (m,"ssp base: 0x%08x\n" , -intel_de_read (dev_priv,DMC_SSP_BASE )); -seq_printf (m,"htp: 0x%08x\n" ,intel_de_read (dev_priv,DMC_HTP_SKL )); - -intel_runtime_pm_put (&dev_priv->runtime_pm, wakeref); - -return 0 ; -} -static void intel_seq_print_mode (struct seq_file *m,int tabs,const struct drm_display_mode *mode) {
@@ -1952,7 +1879,6 @@ static const struct drm_info_list intel_display_debugfs_list[] = { {"i915_gem_framebuffer", i915_gem_framebuffer_info, 0}, {"i915_edp_psr_status", i915_edp_psr_status, 0}, {"i915_power_domain_info", i915_power_domain_info, 0}, - {"i915_dmc_info", i915_dmc_info, 0}, {"i915_display_info", i915_display_info, 0}, {"i915_shared_dplls_info", i915_shared_dplls_info, 0}, {"i915_dp_mst_info", i915_dp_mst_info, 0},
@@ -1996,6 +1922,7 @@ void intel_display_debugfs_register(struct drm_i915_private *i915)ARRAY_SIZE (intel_display_debugfs_list), minor->debugfs_root, minor); +intel_dmc_debugfs_register (i915);intel_fbc_debugfs_register (i915); }
drivers/gpu/drm/i915/display/intel_dmc.c +83 -0
86 lines not on this page · raw message
drivers/gpu/drm/i915/display/intel_dmc.h +1 -0
@@ -54,6 +54,7 @@ void intel_dmc_ucode_fini(struct drm_i915_private *i915);void intel_dmc_ucode_suspend (struct drm_i915_private *i915);void intel_dmc_ucode_resume (struct drm_i915_private *i915);bool intel_dmc_has_payload (struct drm_i915_private *i915); +void intel_dmc_debugfs_register (struct drm_i915_private *i915);void assert_dmc_loaded (struct drm_i915_private *i915);
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 3/8] drm/i915/dmc: move dmc debugfs to intel_dmc.c
Quoted 3 lines · Jani Nikula
Continue localizing DMC register and data access to
intel_dmc.c.Signed-off-by Jani Nikula <[email protected]>
Lucas De Marchi
PATCH 4/8 drm/i915/dmc: fix i915_reg_t usage
In reply to Jani Nikulai915_reg_t is supposed to be a somewhat opaque data type, not to be looked inside.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/display/intel_dmc.c +2 -2
@@ -816,7 +816,7 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused)struct drm_i915_private *i915 = m->private;intel_wakeref_t wakeref;struct intel_dmc *dmc; -i915_reg_t dc5_reg, dc6_reg = {}; +i915_reg_t dc5_reg, dc6_reg =INVALID_MMIO_REG ;if (!HAS_DMC (i915))return -ENODEV ;
@@ -868,7 +868,7 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused) }seq_printf (m,"DC3 -> DC5 count: %d\n" ,intel_de_read (i915, dc5_reg)); -if (dc6_reg.reg) +if (i915_mmio_reg_valid (dc6_reg))seq_printf (m,"DC5 -> DC6 count: %d\n" ,intel_de_read (i915, dc6_reg));
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 4/8] drm/i915/dmc: fix i915_reg_t usage
Quoted 4 lines · Jani Nikula
i915_reg_tis supposed to be a somewhat opaque data type, not to be looked inside.Signed-off-by Jani Nikula <[email protected]>
but maybe also already clean up the remaining one?
$ git grep "i915_reg_t.*= *{ *}"
drivers/gpu/drm/i915/display/intel_display_debugfs.c: i915_reg_t dc5_reg, dc6_reg = {};
drivers/gpu/drm/i915/gt/intel_ring_submission.c: i915_reg_t last_reg = {}; /* keep gcc quiet */Lucas De Marchi
Quoted 29 lines
---
drivers/gpu/drm/i915/display/intel_dmc.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_dmc.c +2
-2@@ -816,7 +816,7 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused)struct drm_i915_private *i915 = m->private;intel_wakeref_t wakeref;struct intel_dmc *dmc; -i915_reg_t dc5_reg, dc6_reg = {}; +i915_reg_t dc5_reg, dc6_reg =INVALID_MMIO_REG ;if (!HAS_DMC (i915))return -ENODEV ;@@ -868,7 +868,7 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused) }seq_printf (m,"DC3 -> DC5 count: %d\n" ,intel_de_read (i915, dc5_reg)); -if (dc6_reg.reg) +if (i915_mmio_reg_valid (dc6_reg))seq_printf (m,"DC5 -> DC6 count: %d\n" ,intel_de_read (i915, dc6_reg));Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 4/8] drm/i915/dmc: fix i915_reg_t usage
Quoted 7 lines · Lucas De Marchi
Quoted 4 lines · Jani Nikula
i915_reg_tis supposed to be a somewhat opaque data type, not to be looked inside.Signed-off-by Jani Nikula <[email protected]>
Quoted 6 lines
Reviewed-by Lucas De Marchi <[email protected]>but maybe also already clean up the remaining one?
$ git grep "i915_reg_t.*= *{ *}" drivers/gpu/drm/i915/display/intel_display_debugfs.c: i915_reg_t dc5_reg, dc6_reg = {};
So that's the one being fixed here.
Quoted 1 line
drivers/gpu/drm/i915/gt/intel_ring_submission.c:i915_reg_tlast_reg= {}; /* keep gcc quiet */
I'll send a separate fix for that, not part of this series.
Thanks,
Jani.
Quoted 32 lines
Lucas De Marchi
Quoted 29 lines
---
drivers/gpu/drm/i915/display/intel_dmc.c| 4 ++--1 file changed, 2 insertions(+), 2 deletions(-)drivers/gpu/drm/i915/display/intel_dmc.c +2
-2@@ -816,7 +816,7 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused)struct drm_i915_private *i915 = m->private;intel_wakeref_t wakeref;struct intel_dmc *dmc; -i915_reg_t dc5_reg, dc6_reg = {}; +i915_reg_t dc5_reg, dc6_reg =INVALID_MMIO_REG ;if (!HAS_DMC (i915))return -ENODEV ;@@ -868,7 +868,7 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused) }seq_printf (m,"DC3 -> DC5 count: %d\n" ,intel_de_read (i915, dc5_reg)); -if (dc6_reg.reg) +if (i915_mmio_reg_valid (dc6_reg))seq_printf (m,"DC5 -> DC6 count: %d\n" ,intel_de_read (i915, dc6_reg));Signature · 1 line
2.30.2
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
PATCH 5/8 drm/i915/dmc: don't register DMC debugfs file if there's no DMC
In reply to Jani NikulaRegister the DMC debugfs file only on platforms that support DMC. There's no point in having a no-op debugfs file.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/display/intel_dmc.c +3 -3
@@ -818,9 +818,6 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused)struct intel_dmc *dmc;i915_reg_t dc5_reg, dc6_reg =INVALID_MMIO_REG ; -if (!HAS_DMC (i915)) -return -ENODEV ; - dmc = &i915->dmc; wakeref =intel_runtime_pm_get (&i915->runtime_pm);
@@ -890,6 +887,9 @@ void intel_dmc_debugfs_register(struct drm_i915_private *i915) {struct drm_minor *minor = i915->drm.primary; +if (!HAS_DMC (i915)) +return ; +debugfs_create_file ("i915_dmc_info" ,0444 , minor->debugfs_root, i915, &intel_dmc_debugfs_status_fops); }
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 5/8] drm/i915/dmc: don't register DMC debugfs file if there's no DMC
Quoted 2 lines · Jani Nikula
Register the DMC debugfs file only on platforms that support DMC. There's no point in having a no-op debugfs file.
It seems this would not change much the behavior (fail on open vs fail on read). But the code in igt is suspicious:
bool igt_pm_dmc_loaded(int debugfs)
{
char buf[15];
int len;
len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
if (len < 0)
return true; /* no CSR support, no DMC requirement */From a quick inspection of igt_sysfs_read() it seems it would just return 0 if there's nothing to be read. And it would return < 0 on failure to open the file.
These would be the affected tests:
tests/i915/i915_pm_rpm.c:tests/i915/i915_pm_lpsp.c:tests/i915/i915_pm_dc.c:
igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
Lucas De Marchi
Quoted 33 lines
Signed-off-by Jani Nikula <[email protected]>---
drivers/gpu/drm/i915/display/intel_dmc.c| 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_dmc.c +3
-3@@ -818,9 +818,6 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused)struct intel_dmc *dmc;i915_reg_t dc5_reg, dc6_reg =INVALID_MMIO_REG ; -if (!HAS_DMC (i915)) -return -ENODEV ; - dmc = &i915->dmc; wakeref =intel_runtime_pm_get (&i915->runtime_pm);@@ -890,6 +887,9 @@ void intel_dmc_debugfs_register(struct drm_i915_private *i915) {struct drm_minor *minor = i915->drm.primary; +if (!HAS_DMC (i915)) +return ; +debugfs_create_file ("i915_dmc_info" ,0444 , minor->debugfs_root, i915, &intel_dmc_debugfs_status_fops); }Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 5/8] drm/i915/dmc: don't register DMC debugfs file if there's no DMC
Quoted 21 lines · Lucas De Marchi
Quoted 2 lines · Jani Nikula
Register the DMC debugfs file only on platforms that support DMC. There's no point in having a no-op debugfs file.
It seems this would not change much the behavior (fail on open vs fail on read). But the code in igt is suspicious:
bool igt_pm_dmc_loaded(int debugfs) { char buf[15]; int len; len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1); if (len < 0) return true; /* no CSR support, no DMC requirement */From a quick inspection of
igt_sysfs_read()it seems it would just
return 0 if there's nothing to be read. And it would return < 0 on failure to open the file.
Quoted 6 lines
These would be the affected tests:
tests/i915/i915_pm_rpm.c:tests/i915/i915_pm_lpsp.c:tests/i915/i915_pm_dc.c:igt_require(igt_pm_dmc_loaded(data.debugfs_fd));
Ok, I think I'll just drop this patch for now, don't have the time to go down that rabbit hole...
Thanks,
Jani.
Quoted 37 lines
Lucas De Marchi
Quoted 33 lines
Signed-off-by Jani Nikula <[email protected]>---
drivers/gpu/drm/i915/display/intel_dmc.c| 6 +++---1 file changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/i915/display/intel_dmc.c +3
-3@@ -818,9 +818,6 @@ static int intel_dmc_debugfs_status_show(struct seq_file *m, void *unused)struct intel_dmc *dmc;i915_reg_t dc5_reg, dc6_reg =INVALID_MMIO_REG ; -if (!HAS_DMC (i915)) -return -ENODEV ; - dmc = &i915->dmc; wakeref =intel_runtime_pm_get (&i915->runtime_pm);@@ -890,6 +887,9 @@ void intel_dmc_debugfs_register(struct drm_i915_private *i915) {struct drm_minor *minor = i915->drm.primary; +if (!HAS_DMC (i915)) +return ; +debugfs_create_file ("i915_dmc_info" ,0444 , minor->debugfs_root, i915, &intel_dmc_debugfs_status_fops); }Signature · 1 line
2.30.2
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
PATCH 6/8 drm/i915/dmc: abstract GPU error state dump
In reply to Jani NikulaOnly intel_dmc.c should be accessing dmc details directly.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 15 +++++++++++++++ drivers/gpu/drm/i915/display/intel_dmc.h | 3 +++ drivers/gpu/drm/i915/i915_gpu_error.c | 10 +--------- 3 files changed, 19 insertions(+), 9 deletions(-)
drivers/gpu/drm/i915/display/intel_dmc.c +15 -0
@@ -811,6 +811,21 @@ void intel_dmc_ucode_fini(struct drm_i915_private *dev_priv)kfree (dev_priv->dmc.dmc_info[id].payload); } +void intel_dmc_print_error_state (struct drm_i915_error_state_buf *m, +struct drm_i915_private *i915) +{ +struct intel_dmc *dmc = &i915->dmc; + +if (!HAS_DMC (i915)) +return ; + +i915_error_printf (m,"DMC loaded: %s\n" , +str_yes_no (intel_dmc_has_payload (i915))); +i915_error_printf (m,"DMC fw version: %d.%d\n" , +DMC_VERSION_MAJOR (dmc->version), +DMC_VERSION_MINOR (dmc->version)); +} +static int intel_dmc_debugfs_status_show (struct seq_file *m,void *unused) {struct drm_i915_private *i915 = m->private;
drivers/gpu/drm/i915/display/intel_dmc.h +3 -0
@@ -10,6 +10,7 @@#include "intel_wakeref.h" #include <linux/workqueue.h> +struct drm_i915_error_state_buf ;struct drm_i915_private ;#define DMC_VERSION (major, minor) ((major) << 16 | (minor))
@@ -55,6 +56,8 @@ void intel_dmc_ucode_suspend(struct drm_i915_private *i915);void intel_dmc_ucode_resume (struct drm_i915_private *i915);bool intel_dmc_has_payload (struct drm_i915_private *i915);void intel_dmc_debugfs_register (struct drm_i915_private *i915); +void intel_dmc_print_error_state (struct drm_i915_error_state_buf *m, +struct drm_i915_private *i915);void assert_dmc_loaded (struct drm_i915_private *i915);
drivers/gpu/drm/i915/i915_gpu_error.c +1 -9
@@ -825,15 +825,7 @@ static void __err_print_to_sgl(struct drm_i915_error_state_buf *m,err_printf (m,"IOMMU enabled?: %d\n" , error->iommu); -if (HAS_DMC (m->i915)) { -struct intel_dmc *dmc = &m->i915->dmc; - -err_printf (m,"DMC loaded: %s\n" , -str_yes_no (intel_dmc_has_payload (m->i915) !=0 )); -err_printf (m,"DMC fw version: %d.%d\n" , -DMC_VERSION_MAJOR (dmc->version), -DMC_VERSION_MINOR (dmc->version)); - } +intel_dmc_print_error_state (m, m->i915);err_printf (m,"RPM wakelock: %s\n" ,str_yes_no (error->wakelock));err_printf (m,"PM suspended: %s\n" ,str_yes_no (error->suspended));
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 6/8] drm/i915/dmc: abstract GPU error state dump
Quoted 3 lines · Jani Nikula
Only
intel_dmc.cshould be accessing dmc details directly.Signed-off-by Jani Nikula <[email protected]>
Lucas De Marchi
PATCH 7/8 drm/i915/dmc: hide DMC version macros
In reply to Jani NikulaThe macros are now only needed within intel_dmc.c, so move them there.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++++ drivers/gpu/drm/i915/display/intel_dmc.h | 4 ---- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/display/intel_dmc.c +4 -0
@@ -37,6 +37,10 @@* low-power state and comes back to normal. */ +#define DMC_VERSION (major, minor) ((major) << 16 | (minor)) +#define DMC_VERSION_MAJOR (version) ((version) >> 16) +#define DMC_VERSION_MINOR (version) ((version) & 0xffff) +#define DMC_PATH (platform, major, minor) \ "i915/" \ __stringify(platform) "_dmc_ver" \
drivers/gpu/drm/i915/display/intel_dmc.h +0 -4
@@ -13,10 +13,6 @@struct drm_i915_error_state_buf ;struct drm_i915_private ; -#define DMC_VERSION (major, minor) ((major) << 16 | (minor)) -#define DMC_VERSION_MAJOR (version) ((version) >> 16) -#define DMC_VERSION_MINOR (version) ((version) & 0xffff) -enum {DMC_FW_MAIN =0 ,DMC_FW_PIPEA ,
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 7/8] drm/i915/dmc: hide DMC version macros
Quoted 3 lines · Jani Nikula
The macros are now only needed within
intel_dmc.c, so move them there.Signed-off-by Jani Nikula <[email protected]>
Lucas De Marchi
PATCH 8/8 drm/i915/dmc: split out dmc registers to a separate file
In reply to Jani NikulaClean up the massive i915_reg.h a bit with this isolated set of registers.
--- drivers/gpu/drm/i915/display/intel_dmc.c | 1 + drivers/gpu/drm/i915/display/intel_dmc_regs.h | 31 +++++++++++++++++++ drivers/gpu/drm/i915/gvt/handlers.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 21 ------------- 4 files changed, 33 insertions(+), 21 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_dmc_regs.h
drivers/gpu/drm/i915/display/intel_dmc.c +1 -0
@@ -28,6 +28,7 @@#include "i915_reg.h" #include "intel_de.h" #include "intel_dmc.h" +#include "intel_dmc_regs.h" /** * DOC: DMC Firmware Support
drivers/gpu/drm/i915/display/intel_dmc_regs.h new file +31 -0
@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2022 Intel Corporation +*/ + +#ifndef __INTEL_DMC_REGS_H__ +#define __INTEL_DMC_REGS_H__ + +#include "i915_reg_defs.h" + +#define DMC_PROGRAM (addr, i) _MMIO((addr) + (i) * 4) +#define DMC_SSP_BASE_ADDR_GEN9 0x00002FC0 +#define DMC_HTP_ADDR_SKL 0x00500034 +#define DMC_SSP_BASE _MMIO(0x8F074) +#define DMC_HTP_SKL _MMIO(0x8F004) +#define DMC_LAST_WRITE _MMIO(0x8F034) +#define DMC_LAST_WRITE_VALUE 0xc003b400 +/* MMIO address range for DMC program (0x80000 - 0x82FFF) */ +#define DMC_MMIO_START_RANGE 0x80000 +#define DMC_MMIO_END_RANGE 0x8FFFF +#define SKL_DMC_DC3_DC5_COUNT _MMIO(0x80030) +#define SKL_DMC_DC5_DC6_COUNT _MMIO(0x8002C) +#define BXT_DMC_DC3_DC5_COUNT _MMIO(0x80038) +#define TGL_DMC_DEBUG_DC5_COUNT _MMIO(0x101084) +#define TGL_DMC_DEBUG_DC6_COUNT _MMIO(0x101088) +#define DG1_DMC_DEBUG_DC5_COUNT _MMIO(0x134154) + +#define TGL_DMC_DEBUG3 _MMIO(0x101090) +#define DG1_DMC_DEBUG3 _MMIO(0x13415c) + +#endif /* __INTEL_DMC_REGS_H__ */
drivers/gpu/drm/i915/gvt/handlers.c +1 -0
@@ -42,6 +42,7 @@#include "i915_pvinfo.h" #include "intel_mchbar_regs.h" #include "display/intel_display_types.h" +#include "display/intel_dmc_regs.h" #include "display/intel_fbc.h" #include "display/vlv_dsi_pll_regs.h" #include "gt/intel_gt_regs.h"
drivers/gpu/drm/i915/i915_reg.h +0 -21
@@ -5493,27 +5493,6 @@#define GAMMA_MODE_MODE_SPLIT (3 << 0)/* ivb-bdw */ #define GAMMA_MODE_MODE_12BIT_MULTI_SEGMENTED (3 << 0)/* icl + */ -/* DMC */ -#define DMC_PROGRAM (addr, i) _MMIO((addr) + (i) * 4) -#define DMC_SSP_BASE_ADDR_GEN9 0x00002FC0 -#define DMC_HTP_ADDR_SKL 0x00500034 -#define DMC_SSP_BASE _MMIO(0x8F074) -#define DMC_HTP_SKL _MMIO(0x8F004) -#define DMC_LAST_WRITE _MMIO(0x8F034) -#define DMC_LAST_WRITE_VALUE 0xc003b400 -/* MMIO address range for DMC program (0x80000 - 0x82FFF) */ -#define DMC_MMIO_START_RANGE 0x80000 -#define DMC_MMIO_END_RANGE 0x8FFFF -#define SKL_DMC_DC3_DC5_COUNT _MMIO(0x80030) -#define SKL_DMC_DC5_DC6_COUNT _MMIO(0x8002C) -#define BXT_DMC_DC3_DC5_COUNT _MMIO(0x80038) -#define TGL_DMC_DEBUG_DC5_COUNT _MMIO(0x101084) -#define TGL_DMC_DEBUG_DC6_COUNT _MMIO(0x101088) -#define DG1_DMC_DEBUG_DC5_COUNT _MMIO(0x134154) - -#define TGL_DMC_DEBUG3 _MMIO(0x101090) -#define DG1_DMC_DEBUG3 _MMIO(0x13415c) -/* Display Internal Timeout Register */ #define RM_TIMEOUT _MMIO(0x42060)#define MMIO_TIMEOUT_US (us) ((us) << 0)
Signature · 1 line
2.30.2
Re: [Intel-gfx] [PATCH 8/8] drm/i915/dmc: split out dmc registers to a separate file
Quoted 38 lines · Jani Nikula
Clean up the massive
i915_reg.ha bit with this isolated set of registers.Signed-off-by Jani Nikula <[email protected]>---
drivers/gpu/drm/i915/display/intel_dmc.c | 1 + drivers/gpu/drm/i915/display/intel_dmc_regs.h | 31 +++++++++++++++++++ drivers/gpu/drm/i915/gvt/handlers.c | 1 + drivers/gpu/drm/i915/i915_reg.h | 21 ------------- 4 files changed, 33 insertions(+), 21 deletions(-)create mode 100644
drivers/gpu/drm/i915/display/intel_dmc_regs.hdrivers/gpu/drm/i915/display/intel_dmc.c +1
-0@@ -28,6 +28,7 @@#include "i915_reg.h" #include "intel_de.h" #include "intel_dmc.h" +#include "intel_dmc_regs.h" /** * DOC: DMC Firmware Support drivers/gpu/drm/i915/display/intel_dmc_regs.h new file +8
-0@@ -0,0 +1,31 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2022 Intel Corporation +*/ + +#ifndef __INTEL_DMC_REGS_H__ +#define __INTEL_DMC_REGS_H__ +
drivers/gpu/drm/i915/display/intel_dmc_regs.h line 18
Quoted 10 lines
drivers/gpu/drm/i915/display/intel_dmc_regs.h new file +10
-0+#include "i915_reg_defs.h" + +#define DMC_PROGRAM (addr, i) _MMIO((addr) + (i) * 4) +#define DMC_SSP_BASE_ADDR_GEN9 0x00002FC0 +#define DMC_HTP_ADDR_SKL 0x00500034 +#define DMC_SSP_BASE _MMIO(0x8F074) +#define DMC_HTP_SKL _MMIO(0x8F004) +#define DMC_LAST_WRITE _MMIO(0x8F034) +#define DMC_LAST_WRITE_VALUE 0xc003b400 +/* MMIO address range for DMC program (0x80000 - 0x82FFF) */
this comment seems outdated. Or at least unneeded
Anyway:
Lucas De Marchi
Quoted 13 lines
drivers/gpu/drm/i915/display/intel_dmc_regs.h new file +13
-0+#define DMC_MMIO_START_RANGE 0x80000 +#define DMC_MMIO_END_RANGE 0x8FFFF +#define SKL_DMC_DC3_DC5_COUNT _MMIO(0x80030) +#define SKL_DMC_DC5_DC6_COUNT _MMIO(0x8002C) +#define BXT_DMC_DC3_DC5_COUNT _MMIO(0x80038) +#define TGL_DMC_DEBUG_DC5_COUNT _MMIO(0x101084) +#define TGL_DMC_DEBUG_DC6_COUNT _MMIO(0x101088) +#define DG1_DMC_DEBUG_DC5_COUNT _MMIO(0x134154) + +#define TGL_DMC_DEBUG3 _MMIO(0x101090) +#define DG1_DMC_DEBUG3 _MMIO(0x13415c) + +#endif /* __INTEL_DMC_REGS_H__ */
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dmc: cleanups
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/dmc: cleanups
URL : https://patchwork.freedesktop.org/series/101499/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip 148ae63a423d drm/i915/dmc: simplify intel_dmc_load_program() conditions f5b3417a7183 drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c -:44: WARNING:LONG_LINE: line length of 107 exceeds 100 columns #44: FILE: drivers/gpu/drm/i915/display/intel_dmc.c:311: + !intel_de_read(i915, DMC_PROGRAM(i915->dmc.dmc_info[DMC_FW_MAIN].start_mmioaddr, 0)),
total: 0 errors, 1 warnings, 0 checks, 41 lines checkedf22b25aa0be3 drm/i915/dmc: move dmc debugfs to intel_dmc.c2a37260cdcf5 drm/i915/dmc: fix i915_reg_t usage16d7cf76f90d drm/i915/dmc: don't register DMC debugfs file if there's no DMC 1b7ec1b7a556 drm/i915/dmc: abstract GPU error state dump2c93821f352b drm/i915/dmc: hide DMC version macros15377b5193fb drm/i915/dmc: split out dmc registers to a separate file
-:25: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #25:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 72 lines checked
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/dmc: cleanups
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/dmc: cleanups
URL : https://patchwork.freedesktop.org/series/101499/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dmc: cleanups
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/dmc: cleanups
URL : https://patchwork.freedesktop.org/series/101499/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11378 -> Patchwork_22597
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/index.html
Participating hosts (46 -> 44)
------------------------------
Additional (1): fi-pnv-d510
Missing (3): bat-dg2-8 fi-bsw-cyan fi-bdw-samus
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22597:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@i915_selftest@live@evict:
- {bat-rpls-2}: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/bat-rpls-2/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_22597 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_lrc:
- fi-rkl-guc: [PASS][2] -> [INCOMPLETE][3] ([i915#2373])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-rkl-guc/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [PASS][4] -> [INCOMPLETE][5] ([i915#3303])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/fi-hsw-4770/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-hsw-4770/igt@i915_selftest@[email protected]
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][6] ([i915#3921])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-bdw-5557u/igt@i915_selftest@[email protected]
* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][7] ([fdo#109271] / [fdo#111827]) +8 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-bdw-5557u/igt@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-c:
- fi-pnv-d510: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#5341])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-pnv-d510/igt@[email protected]
* igt@kms_setmode@basic-clone-single-crtc:
- fi-bdw-5557u: NOTRUN -> [SKIP][9] ([fdo#109271]) +14 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-bdw-5557u/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][10] ([fdo#109271]) +57 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-pnv-d510/igt@[email protected]
* igt@runner@aborted:
- fi-hsw-4770: NOTRUN -> [FAIL][11] ([fdo#109271] / [i915#1436] / [i915#4312])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-hsw-4770/igt@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-blb-e6850: [FAIL][12] ([i915#3194]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/fi-blb-e6850/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/fi-blb-e6850/igt@[email protected]
* igt@i915_module_load@reload:
- {bat-rpls-2}: [DMESG-WARN][14] ([i915#4391]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/bat-rpls-2/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/bat-rpls-2/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- {bat-rpls-2}: [INCOMPLETE][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@kms_busy@basic@modeset:
- {bat-adlp-6}: [DMESG-WARN][18] ([i915#3576]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/bat-adlp-6/igt@kms_busy@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/bat-adlp-6/igt@kms_busy@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#3194]: https://gitlab.freedesktop.org/drm/intel/issues/3194
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4897]: https://gitlab.freedesktop.org/drm/intel/issues/4897
[i915#5087]: https://gitlab.freedesktop.org/drm/intel/issues/5087
[i915#5195]: https://gitlab.freedesktop.org/drm/intel/issues/5195
[i915#5341]: https://gitlab.freedesktop.org/drm/intel/issues/5341
Build changes
-------------
* Linux: CI_DRM_11378 -> Patchwork_22597
CI-20190529: 20190529
CI_DRM_11378: 3ec612f871c18232b04e5530e485992c76bf13a6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6385: f3df40281d93d5a63ee98fa30e90852d780673c9 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22597: 15377b5193fbb3c89e40426719b44baba27a6185 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
15377b5193fb drm/i915/dmc: split out dmc registers to a separate file 2c93821f352b drm/i915/dmc: hide DMC version macros1b7ec1b7a556 drm/i915/dmc: abstract GPU error state dump 16d7cf76f90d drm/i915/dmc: don't register DMC debugfs file if there's no DMC 2a37260cdcf5 drm/i915/dmc: fix i915_reg_t usagef22b25aa0be3 drm/i915/dmc: move dmc debugfs to intel_dmc.c f5b3417a7183 drm/i915/dmc: move assert_dmc_loaded() to intel_dmc.c 148ae63a423d drm/i915/dmc: simplify intel_dmc_load_program() conditions
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dmc: cleanups
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/dmc: cleanups
URL : https://patchwork.freedesktop.org/series/101499/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11378_full -> Patchwork_22597_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22597_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_22597_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22597_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb4/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-75@pipe-b-edp-1-downscale-with-pixel-format.html
Known issues
------------
Here are the changes found in Patchwork_22597_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][3] -> [SKIP][4] ([i915#658])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb2/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb1/igt@[email protected]
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][5] ([i915#4991]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl6/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- shard-tglb: [PASS][6] -> [TIMEOUT][7] ([i915#3063] / [i915#3648])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-tglb7/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [PASS][8] -> [SKIP][9] ([i915#4525])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb1/igt@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb8/igt@[email protected]
* igt@gem_exec_balancer@parallel-ordering:
- shard-kbl: NOTRUN -> [DMESG-FAIL][10] ([i915#5076])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl1/igt@[email protected]
* igt@gem_exec_capture@pi@rcs0:
- shard-skl: [PASS][11] -> [INCOMPLETE][12] ([i915#4547])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl10/igt@gem_exec_capture@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl7/igt@gem_exec_capture@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][13] ([fdo#109271]) +119 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl9/igt@gem_exec_fair@[email protected]
- shard-tglb: [PASS][14] -> [FAIL][15] ([i915#2842])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-tglb7/igt@gem_exec_fair@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-glk: NOTRUN -> [FAIL][16] ([i915#2842])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][17] -> [FAIL][18] ([i915#2842])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-kbl6/igt@gem_exec_fair@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl4/igt@gem_exec_fair@[email protected]
- shard-apl: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-apl3/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-throttle@rcs0:
- shard-glk: [PASS][21] -> [FAIL][22] ([i915#2842])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-glk5/igt@gem_exec_fair@[email protected]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk1/igt@gem_exec_fair@[email protected]
- shard-iclb: [PASS][23] -> [FAIL][24] ([i915#2849])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb2/igt@gem_exec_fair@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-fds-forked-all:
- shard-iclb: [PASS][25] -> [INCOMPLETE][26] ([i915#1895])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb6/igt@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb3/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- shard-tglb: [PASS][27] -> [SKIP][28] ([i915#2190])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-tglb2/igt@[email protected]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglb6/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-random:
- shard-skl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl4/igt@[email protected]
* igt@gem_pxp@create-valid-protected-context:
- shard-iclb: NOTRUN -> [SKIP][30] ([i915#4270])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@gem_render_copy@y-tiled-mc-ccs-to-vebox-y-tiled:
- shard-iclb: NOTRUN -> [SKIP][31] ([i915#768])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@gem_userptr_blits@coherency-sync:
- shard-iclb: NOTRUN -> [SKIP][32] ([fdo#109290])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-iclb: NOTRUN -> [SKIP][33] ([i915#3323])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@gen3_render_linear_blits:
- shard-tglb: NOTRUN -> [SKIP][34] ([fdo#109289])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglb7/igt@gen3_render_linear_blits.html
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: NOTRUN -> [SKIP][35] ([i915#658])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][36] -> [FAIL][37] ([i915#454]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb2/igt@[email protected]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@i915_pm_rpm@gem-execbuf-stress-pc8:
- shard-iclb: NOTRUN -> [SKIP][38] ([fdo#109293] / [fdo#109506])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: [PASS][39] -> [DMESG-WARN][40] ([i915#180]) +1 similar issue
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-kbl6/igt@[email protected]
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl4/igt@[email protected]
* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][41] ([i915#5286]) +1 similar issue
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip:
- shard-kbl: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#3777]) +1 similar issue
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl1/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][43] ([fdo#109271] / [i915#3777]) +3 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][44] ([i915#3743])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl8/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-180-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][45] ([fdo#109271] / [i915#3777])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][46] ([fdo#109271] / [i915#1888] / [i915#3886])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl9/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc:
- shard-skl: NOTRUN -> [SKIP][47] ([fdo#109271] / [i915#3886]) +7 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl3/igt@kms_ccs@pipe-a-bad-pixel-format-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][48] ([fdo#109271] / [i915#3886])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl3/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][49] ([fdo#109271] / [i915#3886]) +1 similar issue
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@kms_ccs@pipe-b-random-ccs-data-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][50] ([fdo#109271] / [i915#3886])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk2/igt@kms_ccs@pipe-c-crc-primary-basic-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#3689])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglb1/igt@kms_ccs@pipe-d-random-ccs-data-y_tiled_gen12_mc_ccs.html
* igt@kms_chamelium@dp-crc-multiple:
- shard-skl: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +7 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl3/igt@[email protected]
* igt@kms_chamelium@hdmi-crc-nonplanar-formats:
- shard-kbl: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl1/igt@[email protected]
* igt@kms_chamelium@vga-edid-read:
- shard-apl: NOTRUN -> [SKIP][54] ([fdo#109271] / [fdo#111827]) +3 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@[email protected]
* igt@kms_content_protection@lic:
- shard-kbl: NOTRUN -> [TIMEOUT][55] ([i915#1319])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl3/igt@[email protected]
* igt@kms_content_protection@uevent:
- shard-apl: NOTRUN -> [FAIL][56] ([i915#2105])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-256x256-rapid-movement:
- shard-iclb: NOTRUN -> [SKIP][57] ([fdo#109278]) +3 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-64x21-rapid-movement:
- shard-apl: NOTRUN -> [SKIP][58] ([fdo#109271]) +39 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][59] -> [FAIL][60] ([i915#72])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-glk8/igt@[email protected]
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-skl: [PASS][61] -> [FAIL][62] ([i915#2346])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl10/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl7/igt@[email protected]
* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-tglb: NOTRUN -> [SKIP][63] ([fdo#109274] / [fdo#111825])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglb1/igt@[email protected]
* igt@kms_flip@2x-flip-vs-blocking-wf-vblank@ac-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][64] -> [FAIL][65] ([i915#2122]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-glk7/igt@kms_flip@[email protected]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk6/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [PASS][66] -> [FAIL][67] ([i915#79])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-apl3/igt@kms_flip@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][68] -> [FAIL][69] ([i915#79])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl3/igt@kms_flip@[email protected]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl9/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][70] -> [DMESG-WARN][71] ([i915#180]) +3 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-apl2/igt@kms_flip@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl4/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check@c-edp1:
- shard-skl: NOTRUN -> [FAIL][72] ([i915#2122]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl3/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][73] -> [SKIP][74] ([i915#3701])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb4/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-glk: [PASS][75] -> [FAIL][76] ([i915#4911]) +1 similar issue
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-glk5/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
- shard-glk: NOTRUN -> [SKIP][77] ([fdo#109271]) +1 similar issue
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-shrfb-plflip-blt:
- shard-iclb: NOTRUN -> [SKIP][78] ([fdo#109280]) +2 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@kms_multipipe_modeset@basic-max-pipe-crc-check:
- shard-iclb: NOTRUN -> [SKIP][79] ([i915#1839])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@kms_pipe_crc_basic@disable-crc-after-crtc-pipe-d:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#533])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl1/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-skl: NOTRUN -> [FAIL][81] ([fdo#108145] / [i915#265]) +1 similar issue
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][82] -> [FAIL][83] ([fdo#108145] / [i915#265])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl6/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-basic:
- shard-apl: NOTRUN -> [FAIL][84] ([fdo#108145] / [i915#265])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl8/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-kbl: NOTRUN -> [FAIL][85] ([fdo#108145] / [i915#265])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl3/igt@[email protected]
* igt@kms_psr2_sf@cursor-plane-update-sf:
- shard-skl: NOTRUN -> [SKIP][86] ([fdo#109271] / [i915#658]) +2 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl8/igt@[email protected]
* igt@kms_psr@psr2_suspend:
- shard-iclb: [PASS][87] -> [SKIP][88] ([fdo#109441]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb2/igt@kms_psr@psr2_suspend.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@kms_psr@psr2_suspend.html
* igt@kms_sysfs_edid_timing:
- shard-skl: NOTRUN -> [FAIL][89] ([IGT#2])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl4/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [PASS][90] -> [DMESG-WARN][91] ([i915#180] / [i915#295])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-apl6/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-apl3/igt@[email protected]
* igt@perf@short-reads:
- shard-skl: [PASS][92] -> [FAIL][93] ([i915#51])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl10/igt@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl6/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- shard-iclb: NOTRUN -> [SKIP][94] ([i915#3301])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@syncobj_timeline@transfer-timeline-point:
- shard-iclb: NOTRUN -> [DMESG-FAIL][95] ([i915#5098])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-iclb6/igt@[email protected]
* igt@sysfs_clients@split-25:
- shard-skl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#2994]) +2 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl9/igt@[email protected]
* igt@sysfs_heartbeat_interval@mixed@vcs0:
- shard-skl: [PASS][97] -> [WARN][98] ([i915#4055])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl1/igt@sysfs_heartbeat_interval@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl7/igt@sysfs_heartbeat_interval@[email protected]
* igt@sysfs_heartbeat_interval@mixed@vecs0:
- shard-skl: [PASS][99] -> [FAIL][100] ([i915#1731])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl1/igt@sysfs_heartbeat_interval@[email protected]
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl7/igt@sysfs_heartbeat_interval@[email protected]
* igt@tools_test@sysfs_l3_parity:
- shard-kbl: NOTRUN -> [SKIP][101] ([fdo#109271]) +75 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl1/igt@tools_test@sysfs_l3_parity.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@vcs0:
- shard-kbl: [DMESG-WARN][102] ([i915#180]) -> [PASS][103] +2 similar issues
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-kbl7/igt@gem_ctx_isolation@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl3/igt@gem_ctx_isolation@[email protected]
* igt@gem_eio@kms:
- shard-tglb: [FAIL][104] ([i915#232]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-tglb1/igt@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglb6/igt@[email protected]
* igt@gem_eio@unwedge-stress:
- {shard-tglu}: [TIMEOUT][106] ([i915#3063] / [i915#3648]) -> [PASS][107]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-tglu-4/igt@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglu-5/igt@[email protected]
- {shard-rkl}: [TIMEOUT][108] ([i915#3063]) -> [PASS][109]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-6/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [FAIL][110] ([i915#2846]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-kbl3/igt@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-kbl1/igt@[email protected]
* igt@gen9_exec_parse@allowed-all:
- shard-glk: [DMESG-WARN][112] ([i915#1436] / [i915#716]) -> [PASS][113]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-glk5/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-glk2/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- {shard-tglu}: [SKIP][114] ([i915#4281]) -> [PASS][115]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-tglu-6/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglu-4/igt@[email protected]
* igt@i915_pm_rpm@system-suspend-modeset:
- {shard-rkl}: ([SKIP][116], [SKIP][117]) ([fdo#109308]) -> [PASS][118]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-4/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@linear-16bpp-rotate-0:
- {shard-tglu}: [DMESG-WARN][119] ([i915#402]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-tglu-5/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-tglu-6/igt@[email protected]
* igt@kms_big_fb@linear-64bpp-rotate-0:
- {shard-rkl}: ([SKIP][121], [SKIP][122]) ([i915#1845] / [i915#4098]) -> [PASS][123]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-4/igt@[email protected]
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-0:
- {shard-rkl}: [SKIP][124] ([i915#1845] / [i915#4098]) -> [PASS][125] +6 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_color@pipe-a-gamma:
- {shard-rkl}: [SKIP][126] ([i915#1149] / [i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][127]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-256x85-onscreen:
- {shard-rkl}: [SKIP][128] ([fdo#112022] / [i915#4070]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-64x64-sliding:
- {shard-rkl}: ([SKIP][130], [PASS][131]) ([fdo#112022] / [i915#4070]) -> [PASS][132]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-4/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-6/igt@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_edge_walk@pipe-b-128x128-top-edge:
- {shard-rkl}: [SKIP][133] ([i915#1849] / [i915#4070] / [i915#4098]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- {shard-rkl}: [SKIP][135] ([fdo#111825] / [i915#4070]) -> [PASS][136] +1 similar issue
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-mmap-wc-untiled:
- shard-skl: [DMESG-WARN][137] ([i915#1982]) -> [PASS][138]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-skl1/igt@[email protected]
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-skl7/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb8888-blt-ytiled:
- {shard-rkl}: [SKIP][139] ([fdo#111314] / [i915#4098] / [i915#4369]) -> [PASS][140] +3 similar issues
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-rkl-5/igt@[email protected]
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/shard-rkl-6/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-iclb: [FAIL][141] ([i915#79]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11378/shard-iclb8/igt@kms_flip@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22597/index.html