staging: vme: Cleanup driver tree old structures

The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig') sourced at "drivers/vme/boards/KConfig" misses a depends on line for VME_BUS, which is unnoticeable for menuconfig users who aren't be able to select it through this interface without setting the CONFIG_VME_BUS option because it's nested on VME_BUS menu entry.

VME windows in a manner at least semi-compatible with the interface

Signature · 1 line

2.35.3

Please, disregard the following message as there's a typo in the prefix.

Quoted 5 lines · Bruno Moreira-Guedes

The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig') sourced at "drivers/vme/boards/KConfig" misses a depends on line for VME_BUS, which is unnoticeable for menuconfig users who aren't be able to select it through this interface without setting the CONFIG_VME_BUS option because it's nested on VME_BUS menu entry.

...

Quoted 4 lines

VME windows in a manner at least semi-compatible with the interface

Signature · 1 line

2.35.3

It's already sent a new copy with the proper version number. Nothing's changed except for the message ID and the v2 typo.

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file (2/3), and rearrages the directory tree for the driver allowing a more straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the 'staging/' tree, but its structure, entry in menuconfig and building routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Signed-off-by Bruno Moreira-Guedes <[email protected]>

Quoted 14 lines · Bruno Moreira-Guedes

Please, disregard the following message as there's a typo in the prefix.

Quoted 5 lines · Bruno Moreira-Guedes

The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig') sourced at "drivers/vme/boards/KConfig" misses a depends on line for VME_BUS, which is unnoticeable for menuconfig users who aren't be able to select it through this interface without setting the CONFIG_VME_BUS option because it's nested on VME_BUS menu entry.

...

Quoted 4 lines

VME windows in a manner at least semi-compatible with the interface

Signature · 1 line

2.35.3

Quoted 2 lines

It's already sent a new copy with the proper version number. Nothing's changed except for the message ID and the v2 typo.

I can't handle 2 v2 of this same commit, our tools get very confused (as do people.) Would you be able to unwind this if you were in my position?

Please resubmit a v3 of this series with everything fixed up.

thanks,

greg k-h

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file (2/3), and rearrages the directory tree for the driver allowing a more straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the 'staging/' tree, but its structure, entry in menuconfig and building routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Signed-off-by Bruno Moreira-Guedes <[email protected]>

---
CHANGE SUMMARY

  Version:  v1  v2  v3
[PATCH 1/3] *   -   *
[PATCH 2/3] -   *   *
[PATCH 3/3] -   *   *

CHANGELOG
[PATCH 0/3] staging: vme: Restructuring menuconfig and tree v1:
Created PATCH 1/3 as a single patch
v2:
Added PATCH 2/3 and 3/3, turning it into a patchset
v3:
Fixed and improved commit messages according to previous comments by Greg and Alison (to whom I'm indebted for their kind reviews). The commit titles got changed to be more specific and use the present imperative tense as for Alison's suggestions. The message body got fixed according to Greg formatting comments. The changelogs were moved to the cover letter as per another suggestion by Alison, and I added missing details (like the update in the MAINTAINERS I failed to mention in v2) and made textual improvements for clarity that I also noticed.

[PATCH 1/3] staging: vme: Move vme_user to staging KConfig v1:
- Sourced "drivers/staging/vme/devices/Kconfig" in "drivers/staging/Kconfig" and unsourced in "drivers/vme/Kconfig".
v3:
- Modified the commit subject and text body.

[PATCH 2/3] staging: vme: Add VME_BUS dependency to Kconfig v2:
- Added this patch to the patchset.
v3:
- Modified the commit subject and text body.

[PATCH 3/3] staging: vme: Move 'vme/devices' to 'vme_user/' v2:
- Added this patch to the patchset
v3
- Modified the commit subject and text body.

Bruno Moreira-Guedes (3):
staging: vme: Adjusted VME_USER in Kconfig
staging: vme: Fix missing depends on at KConfig
staging: vme: "drivers/staging/vme" tree cleanup

 MAINTAINERS                                          | 2 +-
 drivers/staging/Kconfig                              | 1 +
 drivers/staging/Makefile                             | 2 +-
 drivers/staging/vme/Makefile                         | 2 --
 drivers/staging/{vme/devices => vme_user}/Kconfig    | 2 +-
 drivers/staging/{vme/devices => vme_user}/Makefile   | 0
 drivers/staging/{vme/devices => vme_user}/vme_user.c | 0
 drivers/staging/{vme/devices => vme_user}/vme_user.h | 0
 drivers/vme/Kconfig                                  | 2 --
 9 files changed, 4 insertions(+), 7 deletions(-)
 delete mode 100644 drivers/staging/vme/Makefile
 rename drivers/staging/{vme/devices => vme_user}/Kconfig (93%)
 rename drivers/staging/{vme/devices => vme_user}/Makefile (100%)
 rename drivers/staging/{vme/devices => vme_user}/vme_user.c (100%)
 rename drivers/staging/{vme/devices => vme_user}/vme_user.h (100%)

Signature · 1 line

2.35.3

Quoted 15 lines · Greg Kroah-Hartman

Quoted 14 lines · Bruno Moreira-Guedes

Please, disregard the following message as there's a typo in the prefix.

Quoted 5 lines · Bruno Moreira-Guedes

The KConfig file for VME_USER ('drivers/staging/vme/devices/Kconfig') sourced at "drivers/vme/boards/KConfig" misses a depends on line for VME_BUS, which is unnoticeable for menuconfig users who aren't be able to select it through this interface without setting the CONFIG_VME_BUS option because it's nested on VME_BUS menu entry.

...

Quoted 4 lines

VME windows in a manner at least semi-compatible with the interface

Signature · 1 line

2.35.3

Quoted 6 lines

Quoted 2 lines

It's already sent a new copy with the proper version number. Nothing's changed except for the message ID and the v2 typo.

I can't handle 2 v2 of this same commit, our tools get very confused (as do people.) Would you be able to unwind this if you were in my position?

I really apologize for this confusion, I really did some mistakes on my local branch and had to edit the patches manually to reapply them. While working on that I accidentally missed to change the 'v2' to 'v3'. My mistake.

Though, there's no 2 v2s, the new one I sent is a v3 as is the rest of this thread. So, would it be necessary to unwind anything anyway?

Quoted 14 lines · Bruno Moreira-Guedes

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the
'staging/' tree, but its structure, entry in menuconfig and building
routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Quoted 1 line

Signed-off-by Bruno Moreira-Guedes <[email protected]>

What about deleting the vme drivers entirely?

Martyn, anyone still using these?

thanks,

greg k-h

Quoted 15 lines · Greg Kroah-Hartman

Quoted 14 lines · Bruno Moreira-Guedes

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the
'staging/' tree, but its structure, entry in menuconfig and building
routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Quoted 3 lines

Quoted 1 line

Signed-off-by Bruno Moreira-Guedes <[email protected]>

What about deleting the vme drivers entirely?

I assume you're suggesting deleting the "vme_user" driver from the staging directory?

Quoted 2 lines

Martyn, anyone still using these?

I'm fairly sure that the actual VME drivers for the hardware bridges (the bits not in staging) are still being used based on the conversations I've had today. I'm just trying to find out whether the vme_user bit is actively being used.

Quoted 18 lines · Martyn Welch

Quoted 17 lines · Greg Kroah-Hartman

Quoted 15 lines · Bruno Moreira-Guedes

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the
'staging/' tree, but its structure, entry in menuconfig and building
routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Signed-off-by Bruno Moreira-Guedes <[email protected]>

Quoted 4 lines

Quoted 1 line

What about deleting the vme drivers entirely?

I assume you're suggesting deleting the "vme_user" driver from the staging directory?

Yes, at the very least given that no one has tried to fix it up and get it out of staging in many years.

Quoted 8 lines

Quoted 3 lines

Martyn, anyone still using these?

I'm fairly sure that the actual VME drivers for the hardware bridges (the bits not in staging) are still being used based on the conversations I've had today. I'm just trying to find out whether the vme_user bit is actively being used.

If the non-staging vme drivers are still being used, that's great. But if not, those too should be dropped.

thanks,

greg k-h

Hello,

Quoted 21 lines · Greg Kroah-Hartman

Quoted 20 lines · Martyn Welch

Quoted 18 lines · Greg Kroah-Hartman

Quoted 7 lines · Bruno Moreira-Guedes

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).

Quoted 8 lines

The 'vme_user/' driver is the only remaining vme-family driver in the
'staging/' tree, but its structure, entry in menuconfig and building
routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Signed-off-by Bruno Moreira-Guedes <[email protected]>

What about deleting the vme drivers entirely?

Quoted 5 lines

Quoted 2 lines

I assume you're suggesting deleting the "vme_user" driver from the staging directory?

Yes, at the very least given that no one has tried to fix it up and get it out of staging in many years.

While I cannot comment anything on that regard, I imagine the v4 I sent a couple of days ago will wait for that decision, right?

Should I prepare a patch removing them and also submit so when it's decided you can just pick one patch or the other?

Quoted 27 lines · Bruno Moreira-Guedes

Hello,

Quoted 24 lines · Greg Kroah-Hartman

Quoted 22 lines · Martyn Welch

Quoted 15 lines · Greg Kroah-Hartman

Quoted 14 lines · Bruno Moreira-Guedes

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the
'staging/' tree, but its structure, entry in menuconfig and building
routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Quoted 3 lines

Quoted 1 line

Signed-off-by Bruno Moreira-Guedes <[email protected]>

What about deleting the vme drivers entirely?

I assume you're suggesting deleting the "vme_user" driver from the staging directory?

Quoted 5 lines

Quoted 2 lines

Yes, at the very least given that no one has tried to fix it up and get it out of staging in many years.

While I cannot comment anything on that regard, I imagine the v4 I sent a couple of days ago will wait for that decision, right?

I do not know what you are referring to, sorry. My staging patch queue is empty right now.

Quoted 3 lines

Should I prepare a patch removing them and also submit so when it's decided you can just pick one patch or the other?

Let's wait on a removal patch for now.

thanks,

greg k-h

Quoted 31 lines · Greg Kroah-Hartman

Quoted 30 lines · Bruno Moreira-Guedes

Hello,

Quoted 26 lines · Greg Kroah-Hartman

Quoted 16 lines · Martyn Welch

Quoted 15 lines · Greg Kroah-Hartman

Quoted 14 lines · Bruno Moreira-Guedes

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the
'staging/' tree, but its structure, entry in menuconfig and building
routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Quoted 6 lines

Quoted 3 lines

Quoted 1 line

Signed-off-by Bruno Moreira-Guedes <[email protected]>

What about deleting the vme drivers entirely?

I assume you're suggesting deleting the "vme_user" driver from the staging directory?

Yes, at the very least given that no one has tried to fix it up and get it out of staging in many years.

Quoted 5 lines

Quoted 2 lines

While I cannot comment anything on that regard, I imagine the v4 I sent a couple of days ago will wait for that decision, right?

I do not know what you are referring to, sorry. My staging patch queue is empty right now.

Ohhh, okay, no problem, I have sent a v4 around 6 days ago and thought you were waiting on this definition.

Quoted 32 lines · Bruno Moreira-Guedes

Quoted 31 lines · Greg Kroah-Hartman

Quoted 30 lines · Bruno Moreira-Guedes

Hello,

Quoted 26 lines · Greg Kroah-Hartman

Quoted 16 lines · Martyn Welch

Quoted 15 lines · Greg Kroah-Hartman

Quoted 14 lines · Bruno Moreira-Guedes

This patch series modify the vme_user driver's place in menuconfig (1/3), fixes a missing depends on line in a Kconfig file
(2/3), and rearrages the directory tree for the driver allowing a more
straightforward comprehension of its contents (3/3).

The 'vme_user/' driver is the only remaining vme-family driver in the
'staging/' tree, but its structure, entry in menuconfig and building
routines are still attached to the 'vme/' subtree now outside 'staging/'. The present patchset fixes it.

Quoted 6 lines

Quoted 3 lines

Quoted 1 line

Signed-off-by Bruno Moreira-Guedes <[email protected]>

What about deleting the vme drivers entirely?

I assume you're suggesting deleting the "vme_user" driver from the staging directory?

Yes, at the very least given that no one has tried to fix it up and get it out of staging in many years.

Quoted 7 lines

Quoted 5 lines

Quoted 2 lines

While I cannot comment anything on that regard, I imagine the v4 I sent a couple of days ago will wait for that decision, right?

I do not know what you are referring to, sorry. My staging patch queue is empty right now.

Ohhh, okay, no problem, I have sent a v4 around 6 days ago and thought you were waiting on this definition.

If I did not take it, please resend.

thanks,

greg k-h