drm/i915: Media freq factor and per-gt enhancements/fixes
Subsystems (2)
PATCH v2 9/9 drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs
In reply to Ashutosh DixitAdd the following sysfs file to gt/gtN/.defaults:
* media_freq_factor
--- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 18 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 1 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 2 ++ 3 files changed, 21 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +18 -0
@@ -759,6 +759,18 @@ default_boost_freq_mhz_show(struct kobject *kobj, struct kobj_attribute *attr, cstatic struct kobj_attribute default_boost_freq_mhz =__ATTR (rps_boost_freq_mhz,0444 , default_boost_freq_mhz_show,NULL ); +static ssize_t +default_media_freq_factor_show (struct kobject *kobj,struct kobj_attribute *attr,char *buf) +{ +struct intel_gt *gt =kobj_to_gt (kobj->parent); + +return sysfs_emit (buf,"%d\n" , +media_ratio_mode_to_factor (gt->rps_defaults.media_ratio_mode)); +} + +static struct kobj_attribute default_media_freq_factor = +__ATTR (media_freq_factor,0444 , default_media_freq_factor_show,NULL ); +static const struct attribute *const rps_defaults_attrs[] = { &default_min_freq_mhz.attr, &default_max_freq_mhz.attr,
@@ -819,6 +831,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)drm_warn (>->i915->drm,"failed to create add gt%u media_perf_power_attrs sysfs (%pe)\n" , gt->info.id,ERR_PTR (ret)); + + ret =sysfs_create_file (gt->sysfs_defaults, &default_media_freq_factor.attr); +if (ret) +drm_warn (>->i915->drm, +"failed to add gt%u default_media_freq_factor sysfs (%pe)\n" , + gt->info.id,ERR_PTR (ret)); } ret =add_rps_defaults (gt);
drivers/gpu/drm/i915/gt/intel_gt_types.h +1 -0
@@ -65,6 +65,7 @@ struct intel_rps_defaults {u32 min_freq;u32 max_freq;u32 boost_freq; +u32 media_ratio_mode; };enum intel_submission_method {
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +2 -0
@@ -260,7 +260,9 @@ int intel_guc_slpc_init(struct intel_guc_slpc *slpc) slpc->boost_freq =0 ;atomic_set (&slpc->num_waiters,0 ); slpc->num_boosts =0 ; + slpc->media_ratio_mode =SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ; +slpc_to_gt (slpc)->rps_defaults.media_ratio_mode = slpc->media_ratio_mode;mutex_init (&slpc->lock);INIT_WORK (&slpc->boost_work, slpc_boost_work);
Signature · 1 line
2.34.1
v2 cover drm/i915: Media freq factor and per-gt enhancements/fixes
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionality:
* Patches 1 and 2 implement basic sysfs controls for media freq
* Patches 3 and 4 extend previous pcode functions for multiple gt's and patch 5 adds a couple of pcode helpers
* Patch 6 uses the new pcode functions to retrieve media RP0/RPn frequencies
* Patch 7 fixes memory leaks in the previous per-gt sysfs implementation and some code refactoring
* Patch 8 creates a gt/gtN/.defaults directory to expose default RPS parameter values in the per-gt sysfs
* Patch 9 adds the default value for media_freq_factor to gt/gtN/.defaults
IGT tests for this new functionality have also been posted at:
https://patchwork.freedesktop.org/series/102664/
Test-with: 85c51c99da76e3fe286ed28e80fa964e148f6020.1650435058.git.ashutosh.dixit@intel.com
v2: Fixed commit author on patches 5 and 6 (Rodrigo)
Added new patch 4
Ashutosh Dixit (7):
drm/i915: Introduce has_media_ratio_mode
drm/i915/gt: Add media freq factor to per-gt sysfs drm/i915/pcode: Extend pcode functions for multiple gt's drm/i915/gt: Convert callers to user per-gt pcode functions drm/i915/gt: Fix memory leaks in per-gt sysfs drm/i915/gt: Expose per-gt RPS defaults in sysfs drm/i915/gt: Expose default value for media_freq_factor in per-gt
sysfs
Dale B Stimson (2):
drm/i915/pcode: Add a couple of pcode helpers
drm/i915/gt: Add media RP0/RPn to per-gt sysfs
drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 6 +- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 41 ++- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 12 +- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 246 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 14 + drivers/gpu/drm/i915/gt/intel_llc.c | 9 +- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 +- drivers/gpu/drm/i915/gt/intel_rps.c | 9 +- drivers/gpu/drm/i915/gt/selftest_llc.c | 4 +- drivers/gpu/drm/i915/gt/selftest_rps.c | 4 +- .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 39 ++- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_pci.c | 2 + drivers/gpu/drm/i915/i915_reg.h | 18 ++ drivers/gpu/drm/i915/i915_sysfs.c | 2 + drivers/gpu/drm/i915/intel_device_info.h | 1 + drivers/gpu/drm/i915/intel_pcode.c | 136 ++++++---- drivers/gpu/drm/i915/intel_pcode.h | 39 ++- 23 files changed, 499 insertions(+), 101 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 6/9 drm/i915/gt: Add media RP0/RPn to per-gt sysfs
From: Dale B Stimson <[email protected]>
Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs:
* media_RP0_freq_mhz
* media_RPn_freq_mhz
v2: Fixed commit author (Rodrigo)
--- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 15 +++++++ 2 files changed, 62 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +47 -0
@@ -12,6 +12,7 @@#include "i915_sysfs.h" #include "intel_gt.h" #include "intel_gt_regs.h" +#include "intel_pcode.h" #include "intel_gt_sysfs.h" #include "intel_gt_sysfs_pm.h" #include "intel_rc6.h"
@@ -669,13 +670,59 @@ static ssize_t media_freq_factor_store(struct device *dev,return err ?: count; } +static ssize_t media_RP0_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =__intel_gt_pcode_read (gt,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_P0 , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* data_out - Fused P0 for domain ID in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} + +static ssize_t media_RPn_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =__intel_gt_pcode_read (gt,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_PN , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* data_out - Fused P0 for domain ID in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} +static DEVICE_ATTR_RW (media_freq_factor);static struct device_attribute dev_attr_media_freq_factor_scale =__ATTR (media_freq_factor.scale,0444 , freq_factor_scale_show,NULL ); +static DEVICE_ATTR_RO (media_RP0_freq_mhz); +static DEVICE_ATTR_RO (media_RPn_freq_mhz);static const struct attribute *media_perf_power_attrs[] = { &dev_attr_media_freq_factor.attr, &dev_attr_media_freq_factor_scale.attr, + &dev_attr_media_RP0_freq_mhz.attr, + &dev_attr_media_RPn_freq_mhz.attr,NULL };
drivers/gpu/drm/i915/i915_reg.h +15 -0
@@ -6753,6 +6753,21 @@#define DG1_UNCORE_GET_INIT_STATUS 0x0#define DG1_UNCORE_INIT_STATUS_COMPLETE 0x1#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23 +#define XEHPSDV_PCODE_FREQUENCY_CONFIG 0x6e/* xehpsdv, pvc */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ +#define PCODE_MBOX_FC_SC_READ_FUSED_P0 0x0 +#define PCODE_MBOX_FC_SC_READ_FUSED_PN 0x1 +/* PCODE_MBOX_DOMAIN_* - mailbox domain IDs */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG param2 */ +#define PCODE_MBOX_DOMAIN_NONE 0x0 +#define PCODE_MBOX_DOMAIN_GT 0x1 +#define PCODE_MBOX_DOMAIN_HBM 0x2 +#define PCODE_MBOX_DOMAIN_MEDIAFF 0x3 +#define PCODE_MBOX_DOMAIN_MEDIA_SAMPLER 0x4 +#define PCODE_MBOX_DOMAIN_SYSTOLIC_ARRAY 0x5 +#define PCODE_MBOX_DOMAIN_CHIPLET 0x6 +#define PCODE_MBOX_DOMAIN_BASE_CHIPLET_LINK 0x7 +#define PCODE_MBOX_DOMAIN_BASE 0x8#define GEN6_PCODE_DATA _MMIO(0x138128)#define GEN6_PCODE_FREQ_IA_RATIO_SHIFT 8#define GEN6_PCODE_FREQ_RING_RATIO_SHIFT 16
Signature · 1 line
2.34.1
PATCH v2 1/9 drm/i915: Introduce has_media_ratio_mode
In reply to Ashutosh DixitMedia ratio mode (the ability for media IP to work at a different frequency from the GT) is available for a subset of dGfx platforms supporting GuC/SLPC. Introduce 'has_media_ratio_mode' flag in intel_device_info to identify these platforms and set it for XEHPSDV and DG2/ATS-M.
--- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_pci.c | 2 ++ drivers/gpu/drm/i915/intel_device_info.h | 1 + 3 files changed, 5 insertions(+)
drivers/gpu/drm/i915/i915_drv.h +2 -0
@@ -1224,6 +1224,8 @@ IS_SUBPLATFORM(const struct drm_i915_private *i915,#define CCS_MASK (gt) \ ENGINE_INSTANCES_MASK(gt, CCS0, I915_MAX_CCS) +#define HAS_MEDIA_RATIO_MODE (dev_priv) (INTEL_INFO(dev_priv)->has_media_ratio_mode) +/* * The Gen7 cmdparser copies the scanned buffer to the ggtt for execution * All later gens can run the final buffer from the ppgtt
drivers/gpu/drm/i915/i915_pci.c +2 -0
@@ -1032,6 +1032,7 @@ static const struct intel_device_info xehpsdv_info = { .display = { }, .has_64k_pages = 1, .needs_compact_pt = 1, + .has_media_ratio_mode = 1, .platform_engine_mask =BIT (RCS0 ) |BIT (BCS0 ) | BIT(VECS0) | BIT(VECS1) | BIT(VECS2) | BIT(VECS3) |
@@ -1051,6 +1052,7 @@ static const struct intel_device_info xehpsdv_info = { .has_64k_pages = 1, \ .has_guc_deprivilege = 1, \ .needs_compact_pt = 1, \ + .has_media_ratio_mode = 1, \ .platform_engine_mask = \BIT (RCS0 ) |BIT (BCS0 ) | \ BIT(VECS0) | BIT(VECS1) | \
drivers/gpu/drm/i915/intel_device_info.h +1 -0
@@ -151,6 +151,7 @@ enum intel_ppgtt_type {func (has_llc); \func (has_logical_ring_contexts); \func (has_logical_ring_elsq); \ +func (has_media_ratio_mode); \func (has_mslices); \func (has_pooled_eu); \func (has_pxp); \
Signature · 1 line
2.34.1
PATCH v2 5/9 drm/i915/pcode: Add a couple of pcode helpers
In reply to Ashutosh DixitFrom: Dale B Stimson <[email protected]>
Add a couple of helpers to help formatting pcode commands and improve code readability.
v2: Fixed commit author (Rodrigo)
--- drivers/gpu/drm/i915/i915_reg.h | 3 +++ drivers/gpu/drm/i915/intel_pcode.c | 32 ++++++++++++++++++++++++++++++ drivers/gpu/drm/i915/intel_pcode.h | 12 +++++++++++ 3 files changed, 47 insertions(+)
drivers/gpu/drm/i915/i915_reg.h +3 -0
@@ -6684,6 +6684,9 @@#define GEN6_PCODE_MAILBOX _MMIO(0x138124)#define GEN6_PCODE_READY (1 << 31) +#define GEN6_PCODE_MB_PARAM2 REG_GENMASK(23, 16) +#define GEN6_PCODE_MB_PARAM1 REG_GENMASK(15, 8) +#define GEN6_PCODE_MB_COMMAND REG_GENMASK(7, 0)#define GEN6_PCODE_ERROR_MASK 0xFF#define GEN6_PCODE_SUCCESS 0x0#define GEN6_PCODE_ILLEGAL_CMD 0x1
drivers/gpu/drm/i915/intel_pcode.c +32 -0
@@ -239,3 +239,35 @@ int intel_pcode_init(struct drm_i915_private *i915)return 0 ; } + +int __intel_gt_pcode_read (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 *val) +{ +intel_wakeref_t wakeref; +u32 mbox; +int err; + + mbox =REG_FIELD_PREP (GEN6_PCODE_MB_COMMAND , mbcmd) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM1 , p1) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM2 , p2); + +with_intel_runtime_pm (gt->uncore->rpm, wakeref) + err = intel_gt_pcode_read(gt, mbox, val, NULL); + +return err; +} + +int __intel_gt_pcode_write (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 val) +{ +intel_wakeref_t wakeref; +u32 mbox; +int err; + + mbox =REG_FIELD_PREP (GEN6_PCODE_MB_COMMAND , mbcmd) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM1 , p1) + |REG_FIELD_PREP (GEN6_PCODE_MB_PARAM2 , p2); + +with_intel_runtime_pm (gt->uncore->rpm, wakeref) + err = intel_gt_pcode_write(gt, mbox, val); + +return err; +}
drivers/gpu/drm/i915/intel_pcode.h +12 -0
@@ -36,4 +36,16 @@ int intel_gt_pcode_request(struct intel_gt *gt, u32 mbox, u32 request,int intel_pcode_init (struct drm_i915_private *i915); +/* +* Helpers for dGfx PCODE mailbox command formatting +*/ +int __intel_gt_pcode_read (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 *val); +int __intel_gt_pcode_write (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 val); + +#define __snb_pcode_read (i915, mbcmd, p1, p2, val) \ + __intel_gt_pcode_read(&(i915)->gt0, mbcmd, p1, p2, val) + +#define __snb_pcode_write (i915, mbcmd, p1, p2, val) \ + __intel_gt_pcode_write(&(i915)->gt0, mbcmd, p1, p2, val) +#endif /* _INTEL_PCODE_H */
Signature · 1 line
2.34.1
PATCH v2 7/9 drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Ashutosh DixitAll kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization.
--- drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 35 ++++++++++-------------- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +--- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 ++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 5 files changed, 22 insertions(+), 25 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt.c +1 -0
@@ -783,6 +783,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) {intel_wakeref_t wakeref; +intel_gt_sysfs_unregister (gt);intel_rps_driver_unregister (>->rps);intel_pxp_fini (>->pxp);
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +15 -20
@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj)static struct intel_gt *kobj_to_gt (struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gtn); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,
@@ -72,21 +72,19 @@ static struct attribute *id_attrs[] = { };ATTRIBUTE_GROUPS (id); -static void kobj_gt_release (struct kobject *kobj) +/* A kobject needs a release() method even if it does nothing */ +static void kobj_gtn_release (struct kobject *kobj) { -kfree (kobj); } -static struct kobj_type kobj_gt_type = { - .release = kobj_gt_release, +static struct kobj_type kobj_gtn_type = { + .release = kobj_gtn_release, .sysfs_ops = &kobj_sysfs_ops, .default_groups = id_groups, };void intel_gt_sysfs_register (struct intel_gt *gt) { -struct kobj_gt *kg; -/* * We need to make things right with the * ABI compatibility. The files were originally
@@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt)if (gt_is_root (gt))intel_gt_sysfs_pm_init (gt,gt_get_parent_obj (gt)); - kg =kzalloc (sizeof (*kg),GFP_KERNEL ); -if (!kg) +/* init and xfer ownership to sysfs tree */ +if (kobject_init_and_add (>->sysfs_gtn, &kobj_gtn_type, + gt->i915->sysfs_gt,"gt%d" , gt->info.id)) goto exit_fail; -kobject_init (&kg->base, &kobj_gt_type); - kg->gt = gt; - -/* xfer ownership to sysfs tree */ -if (kobject_add (&kg->base, gt->i915->sysfs_gt,"gt%d" , gt->info.id)) - goto exit_kobj_put; - -intel_gt_sysfs_pm_init (gt, &kg->base); +intel_gt_sysfs_pm_init (gt, >->sysfs_gtn);return ; -exit_kobj_put: -kobject_put (&kg->base); - exit_fail: +kobject_put (>->sysfs_gtn);drm_warn (>->i915->drm,"failed to initialize gt%d sysfs root\n" , gt->info.id); } + +void intel_gt_sysfs_unregister (struct intel_gt *gt) +{ +kobject_put (>->sysfs_gtn); +}
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +1 -5
@@ -13,11 +13,6 @@struct intel_gt ; -struct kobj_gt { -struct kobject base; -struct intel_gt *gt; -}; -bool is_object_gt (struct kobject *kobj);struct drm_i915_private *kobj_to_i915 (struct kobject *kobj);
@@ -28,6 +23,7 @@ intel_gt_create_kobj(struct intel_gt *gt, const char *name);void intel_gt_sysfs_register (struct intel_gt *gt); +void intel_gt_sysfs_unregister (struct intel_gt *gt);struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name);
drivers/gpu/drm/i915/gt/intel_gt_types.h +3 -0
@@ -222,6 +222,9 @@ struct intel_gt { } mocs;struct intel_pxp pxp; + +/* gt/gtN sysfs */ +struct kobject sysfs_gtn; };enum intel_gt_scratch_field {
drivers/gpu/drm/i915/i915_sysfs.c +2 -0
@@ -259,4 +259,6 @@ void i915_teardown_sysfs(struct drm_i915_private *dev_priv)device_remove_bin_file (kdev, &dpf_attrs_1);device_remove_bin_file (kdev, &dpf_attrs); + +kobject_put (dev_priv->sysfs_gt); }
Signature · 1 line
2.34.1
PATCH v2 2/9 drm/i915/gt: Add media freq factor to per-gt sysfs
In reply to Ashutosh DixitExpose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively).
Media freq factor is converted to media_ratio_mode for GuC. It is programmed into GuC using H2G SLPC interface. It is retrieved from GuC through a register read. A cached media_ratio_mode is maintained to preserve set values across GuC resets.
This patch adds the following sysfs files to gt/gtN sysfs:
* media_freq_factor
* media_freq_factor.scale
--- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 130 ++++++++++++++++++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 20 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + 6 files changed, 161 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_regs.h +1 -0
@@ -732,6 +732,7 @@#define GEN6_AGGRESSIVE_TURBO (0 << 15)#define GEN9_SW_REQ_UNSLICE_RATIO_SHIFT 23#define GEN9_IGNORE_SLICE_RATIO (0 << 0) +#define GEN12_MEDIA_FREQ_RATIO REG_BIT(13)#define GEN6_RC_VIDEO_FREQ _MMIO(0xa00c)#define GEN6_RC_CTL_RC6pp_ENABLE (1 << 16)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +130 -0
140 lines not on this page · raw message
drivers/gpu/drm/i915/gt/uc/abi/guc_actions_slpc_abi.h +6 -0
@@ -122,6 +122,12 @@ enum slpc_param_id { SLPC_MAX_PARAM = 32, }; +enum slpc_media_ratio_mode { +SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL =0 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_ONE =1 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_TWO =2 , +}; +enum slpc_event_id {SLPC_EVENT_RESET =0 ,SLPC_EVENT_SHUTDOWN =1 ,
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +20 -0
@@ -260,6 +260,7 @@ int intel_guc_slpc_init(struct intel_guc_slpc *slpc) slpc->boost_freq =0 ;atomic_set (&slpc->num_waiters,0 ); slpc->num_boosts =0 ; + slpc->media_ratio_mode =SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ;mutex_init (&slpc->lock);INIT_WORK (&slpc->boost_work, slpc_boost_work);
@@ -506,6 +507,22 @@ int intel_guc_slpc_get_min_freq(struct intel_guc_slpc *slpc, u32 *val)return ret; } +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val) +{ +struct drm_i915_private *i915 =slpc_to_i915 (slpc); +intel_wakeref_t wakeref; +int ret =0 ; + +if (!HAS_MEDIA_RATIO_MODE (i915)) +return -ENODEV ; + +with_intel_runtime_pm (&i915->runtime_pm, wakeref) + ret = slpc_set_param(slpc, +SLPC_PARAM_MEDIA_FF_RATIO_MODE , + val); +return ret; +} +void intel_guc_pm_intrmsk_enable (struct intel_gt *gt) {u32 pm_intrmsk_mbz =0 ;
@@ -654,6 +671,9 @@ int intel_guc_slpc_enable(struct intel_guc_slpc *slpc)return ret; } +/* Set cached media freq ratio mode */ +intel_guc_slpc_set_media_ratio_mode (slpc, slpc->media_ratio_mode); +return 0 ; }
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h +1 -0
@@ -38,6 +38,7 @@ int intel_guc_slpc_set_boost_freq(struct intel_guc_slpc *slpc, u32 val);int intel_guc_slpc_get_max_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_get_min_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_print_info (struct intel_guc_slpc *slpc,struct drm_printer *p); +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val);void intel_guc_pm_intrmsk_enable (struct intel_gt *gt);void intel_guc_slpc_boost (struct intel_guc_slpc *slpc);void intel_guc_slpc_dec_waiters (struct intel_guc_slpc *slpc);
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc_types.h +3 -0
@@ -29,6 +29,9 @@ struct intel_guc_slpc {u32 min_freq_softlimit;u32 max_freq_softlimit; +/* cached media ratio mode */ +u32 media_ratio_mode; +/* Protects set/reset of boost freq * and value of num_waiters */
Signature · 1 line
2.34.1
PATCH v2 8/9 drm/i915/gt: Expose per-gt RPS defaults in sysfs
In reply to Ashutosh DixitCreate a gt/gtN/.defaults directory (similar to engine/<engine-name>/.defaults) to expose default parameter values for each gt in sysfs. Populate the .defaults directory with RPS parameter default values in order to allow userspace to revert to default values when needed.
This patch adds the following sysfs files to gt/gtN/.defaults:
* default_min_freq_mhz
* default_max_freq_mhz
* default_boost_freq_mhz
--- drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 10 ++-- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +++ drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 51 +++++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 10 ++++ drivers/gpu/drm/i915/gt/intel_rps.c | 3 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 17 +++++-- 6 files changed, 87 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +5 -5
@@ -22,11 +22,6 @@ bool is_object_gt(struct kobject *kobj)return !strncmp (kobj->name,"gt" ,2 ); } -static struct intel_gt *kobj_to_gt (struct kobject *kobj) -{ - return container_of(kobj, struct intel_gt, sysfs_gtn); -} -struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name) {
@@ -101,6 +96,10 @@ void intel_gt_sysfs_register(struct intel_gt *gt) gt->i915->sysfs_gt, "gt%d", gt->info.id)) goto exit_fail; + gt->sysfs_defaults =kobject_create_and_add (".defaults" , >->sysfs_gtn); +if (!gt->sysfs_defaults) + goto exit_fail; +intel_gt_sysfs_pm_init (gt, >->sysfs_gtn);return ;
@@ -113,5 +112,6 @@ void intel_gt_sysfs_register(struct intel_gt *gt)void intel_gt_sysfs_unregister (struct intel_gt *gt) { +kobject_put (gt->sysfs_defaults);kobject_put (>->sysfs_gtn); }
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +6 -0
@@ -10,6 +10,7 @@#include <linux/kobject.h> #include "i915_gem.h" /* GEM_BUG_ON() */ +#include "intel_gt_types.h" struct intel_gt ;
@@ -22,6 +23,11 @@ intel_gt_create_kobj(struct intel_gt *gt,struct kobject *dir, const char *name); +static inline struct intel_gt *kobj_to_gt (struct kobject *kobj) +{ + return container_of(kobj, struct intel_gt, sysfs_gtn); +} +void intel_gt_sysfs_register (struct intel_gt *gt);void intel_gt_sysfs_unregister (struct intel_gt *gt); struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +51 -0
61 lines not on this page · raw message
drivers/gpu/drm/i915/gt/intel_gt_types.h +10 -0
@@ -61,6 +61,12 @@ enum intel_steering_type {NUM_STEERING_TYPES }; +struct intel_rps_defaults { +u32 min_freq; +u32 max_freq; +u32 boost_freq; +}; +enum intel_submission_method {INTEL_SUBMISSION_RING ,INTEL_SUBMISSION_ELSP ,
@@ -225,6 +231,10 @@ struct intel_gt {/* gt/gtN sysfs */ struct kobject sysfs_gtn; + +/* sysfs defaults per gt */ +struct intel_rps_defaults rps_defaults; +struct kobject *sysfs_defaults; };enum intel_gt_scratch_field {
drivers/gpu/drm/i915/gt/intel_rps.c +3 -0
@@ -1976,7 +1976,9 @@ void intel_rps_init(struct intel_rps *rps)/* Derive initial user preferences/limits from the hardware limits */ rps->max_freq_softlimit = rps->max_freq; +rps_to_gt (rps)->rps_defaults.max_freq = rps->max_freq_softlimit; rps->min_freq_softlimit = rps->min_freq; +rps_to_gt (rps)->rps_defaults.min_freq = rps->min_freq_softlimit;/* After setting max-softlimit, find the overclock max freq */ if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {
@@ -1994,6 +1996,7 @@ void intel_rps_init(struct intel_rps *rps)/* Finally allow us to boost to max by default */ rps->boost_freq = rps->max_freq; +rps_to_gt (rps)->rps_defaults.boost_freq = rps->boost_freq; rps->idle_freq = rps->min_freq;/* Start in the middle, from here we will autotune based on workload */
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +12 -5
@@ -547,20 +547,24 @@ static int slpc_set_softlimits(struct intel_guc_slpc *slpc)* unless they have deviated from defaults, in which case, * we retain the values and set min/max accordingly. */ -if (!slpc->max_freq_softlimit) +if (!slpc->max_freq_softlimit) { slpc->max_freq_softlimit = slpc->rp0_freq; -else if (slpc->max_freq_softlimit != slpc->rp0_freq) +slpc_to_gt (slpc)->rps_defaults.max_freq = slpc->max_freq_softlimit; + }else if (slpc->max_freq_softlimit != slpc->rp0_freq) { ret =intel_guc_slpc_set_max_freq (slpc, slpc->max_freq_softlimit); + }if (unlikely (ret))return ret; -if (!slpc->min_freq_softlimit) +if (!slpc->min_freq_softlimit) { slpc->min_freq_softlimit = slpc->min_freq; -else if (slpc->min_freq_softlimit != slpc->min_freq) +slpc_to_gt (slpc)->rps_defaults.min_freq = slpc->min_freq_softlimit; + }else if (slpc->min_freq_softlimit != slpc->min_freq) {return intel_guc_slpc_set_min_freq (slpc, slpc->min_freq_softlimit); + }return 0 ; }
@@ -606,8 +610,11 @@ static void slpc_get_rp_values(struct intel_guc_slpc *slpc) slpc->rp1_freq =intel_gpu_freq (rps, caps.rp1_freq); slpc->min_freq =intel_gpu_freq (rps, caps.min_freq); -if (!slpc->boost_freq) +/* Boost freq is RP0, unless already set */ +if (!slpc->boost_freq) { slpc->boost_freq = slpc->rp0_freq; +slpc_to_gt (slpc)->rps_defaults.boost_freq = slpc->boost_freq; + } }/*
Signature · 1 line
2.34.1
PATCH v2 3/9 drm/i915/pcode: Extend pcode functions for multiple gt's
In reply to Ashutosh DixitEach gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. Previous (GT0) pcode read/write interfaces are preserved.
--- drivers/gpu/drm/i915/intel_pcode.c | 108 ++++++++++++++++------------- drivers/gpu/drm/i915/intel_pcode.h | 27 ++++++-- 2 files changed, 82 insertions(+), 53 deletions(-)
drivers/gpu/drm/i915/intel_pcode.c +61 -47
@@ -6,6 +6,7 @@#include "i915_drv.h" #include "i915_reg.h" #include "intel_pcode.h" +#include "gt/intel_gt.h" static int gen6_check_mailbox_status (u32 mbox) {
@@ -52,14 +53,14 @@ static int gen7_check_mailbox_status(u32 mbox) } } -static int __snb_pcode_rw (struct drm_i915_private *i915,u32 mbox, -u32 *val,u32 *val1, -int fast_timeout_us,int slow_timeout_ms, -bool is_read) +static int __gt_pcode_rw (struct intel_gt *gt,u32 mbox, +u32 *val,u32 *val1, +int fast_timeout_us,int slow_timeout_ms, +bool is_read) { -struct intel_uncore *uncore = &i915->uncore; +struct intel_uncore *uncore = gt->uncore; -lockdep_assert_held (&i915->sb_lock); +lockdep_assert_held (>->i915->sb_lock);/* * GEN6_PCODE_* are outside of the forcewake domain, we can use
@@ -88,60 +89,60 @@ static int __snb_pcode_rw(struct drm_i915_private *i915, u32 mbox,if (is_read && val1) *val1 =intel_uncore_read_fw (uncore,GEN6_PCODE_DATA1 ); -if (GRAPHICS_VER (i915) >6 ) +if (GRAPHICS_VER (gt->i915) >6 )return gen7_check_mailbox_status (mbox);else return gen6_check_mailbox_status (mbox); } -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1) +int intel_gt_pcode_read (struct intel_gt *gt,u32 mbox,u32 *val,u32 *val1) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, val, val1,500 ,20 , true); -mutex_unlock (&i915->sb_lock); +mutex_lock (>->i915->sb_lock); + err =__gt_pcode_rw (gt, mbox, val, val1,500 ,20 , true); +mutex_unlock (>->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, -"warning: pcode (read from mbox %x) mailbox access failed for %ps: %d\n" , - mbox,__builtin_return_address (0 ), err); +drm_dbg (>->i915->drm, +"gt %d: warning: pcode (read from mbox %x) mailbox access failed for %ps: %d\n" , + gt->info.id, mbox,__builtin_return_address (0 ), err); }return err; } -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, -int fast_timeout_us,int slow_timeout_ms) +int intel_gt_pcode_write_timeout (struct intel_gt *gt,u32 mbox,u32 val, +int fast_timeout_us,int slow_timeout_ms) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, &val,NULL , - fast_timeout_us, slow_timeout_ms, false); -mutex_unlock (&i915->sb_lock); +mutex_lock (>->i915->sb_lock); + err =__gt_pcode_rw (gt, mbox, &val,NULL , + fast_timeout_us, slow_timeout_ms, false); +mutex_unlock (>->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, -"warning: pcode (write of 0x%08x to mbox %x) mailbox access failed for %ps: %d\n" , - val, mbox,__builtin_return_address (0 ), err); +drm_dbg (>->i915->drm, +"gt %d: warning: pcode (write of 0x%08x to mbox %x) mailbox access failed for %ps: %d\n" , + gt->info.id, val, mbox,__builtin_return_address (0 ), err); }return err; } -static bool skl_pcode_try_request (struct drm_i915_private *i915,u32 mbox, -u32 request,u32 reply_mask,u32 reply, -u32 *status) +static bool __gt_pcode_try_request (struct intel_gt *gt,u32 mbox, +u32 request,u32 reply_mask,u32 reply, +u32 *status) { - *status =__snb_pcode_rw (i915, mbox, &request,NULL ,500 ,0 , true); + *status =__gt_pcode_rw (gt, mbox, &request,NULL ,500 ,0 , true);return (*status ==0 ) && ((request & reply_mask) == reply); }/** -* skl_pcode_request - send PCODE request until acknowledgment -* @i915: device private +* intel_gt_pcode_request - send PCODE request until acknowledgment +* @gt: gt * @mbox: PCODE mailbox ID the request is targeted for * @request: request ID * @reply_mask: mask used to check for request acknowledgment
@@ -158,16 +159,16 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox,* Returns 0 on success, %-ETIMEDOUT in case of a timeout, <0 in case of some * other error as reported by PCODE. */ -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, -u32 reply_mask,u32 reply,int timeout_base_ms) +int intel_gt_pcode_request (struct intel_gt *gt,u32 mbox,u32 request, +u32 reply_mask,u32 reply,int timeout_base_ms) {u32 status;int ret; -mutex_lock (&i915->sb_lock); +mutex_lock (>->i915->sb_lock);#define COND \ - skl_pcode_try_request(i915, mbox, request, reply_mask, reply, &status) + __gt_pcode_try_request(gt, mbox, request, reply_mask, reply, &status)/* * Prime the PCODE by doing a request first. Normally it guarantees
@@ -193,35 +194,48 @@ int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request,* requests, and for any quirks of the PCODE firmware that delays * the request completion. */ -drm_dbg_kms (&i915->drm, +drm_dbg_kms (>->i915->drm,"PCODE timeout, retrying with preemption disabled\n" ); -drm_WARN_ON_ONCE (&i915->drm, timeout_base_ms >3 ); +drm_WARN_ON_ONCE (>->i915->drm, timeout_base_ms >3 );preempt_disable (); ret =wait_for_atomic (COND ,50 );preempt_enable (); out: -mutex_unlock (&i915->sb_lock); +mutex_unlock (>->i915->sb_lock);return status ? status : ret;#undef COND } +static int __gt_pcode_init (struct intel_gt *gt) +{ +int ret =intel_gt_pcode_request (gt,DG1_PCODE_STATUS , +DG1_UNCORE_GET_INIT_STATUS , +DG1_UNCORE_INIT_STATUS_COMPLETE , +DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); + +drm_dbg (>->i915->drm,"gt %d: PCODE init status %d\n" , gt->info.id, ret); + +if (ret) +drm_err (>->i915->drm,"gt %d: Pcode did not report uncore initialization completion!\n" , + gt->info.id); + +return ret; +} +int intel_pcode_init (struct drm_i915_private *i915) { -int ret =0 ; +struct intel_gt *gt; +int i, ret =0 ;if (!IS_DGFX (i915))return ret; - ret =skl_pcode_request (i915,DG1_PCODE_STATUS , -DG1_UNCORE_GET_INIT_STATUS , -DG1_UNCORE_INIT_STATUS_COMPLETE , -DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); - -drm_dbg (&i915->drm,"PCODE init status %d\n" , ret); - -if (ret) -drm_err (&i915->drm,"Pcode did not report uncore initialization completion!\n" ); +for_each_gt (gt, i915, i) { + ret =__gt_pcode_init (gt); +if (ret) +return ret; + } -return ret; +return 0 ; }
drivers/gpu/drm/i915/intel_pcode.h +21 -6
@@ -8,16 +8,31 @@#include <linux/types.h> +struct intel_gt ;struct drm_i915_private ; -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1); -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, -int fast_timeout_us,int slow_timeout_ms); -#define snb_pcode_write (i915, mbox, val) \ +int intel_gt_pcode_read (struct intel_gt *gt,u32 mbox,u32 *val,u32 *val1); + +int intel_gt_pcode_write_timeout (struct intel_gt *gt,u32 mbox,u32 val, +int fast_timeout_us,int slow_timeout_ms); + +#define intel_gt_pcode_write (gt, mbox, val) \ + intel_gt_pcode_write_timeout(gt, mbox, val, 500, 0) + +int intel_gt_pcode_request (struct intel_gt *gt,u32 mbox,u32 request, +u32 reply_mask,u32 reply,int timeout_base_ms); + +#define snb_pcode_read (i915, mbox, val, val1) \ + intel_gt_pcode_read(&(i915)->gt0, mbox, val, val1) + +#define snb_pcode_write_timeout (i915, mbox, val, fast_timeout_us, slow_timeout_ms) \ + intel_gt_pcode_write_timeout(&(i915)->gt0, mbox, val, fast_timeout_us, slow_timeout_ms) + +#define snb_pcode_write (i915, mbox, val) \ snb_pcode_write_timeout(i915, mbox, val, 500, 0) -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, -u32 reply_mask,u32 reply,int timeout_base_ms); +#define skl_pcode_request (i915, mbox, request, reply_mask, reply, timeout_base_ms) \ + intel_gt_pcode_request(&(i915)->gt0, mbox, request, reply_mask, reply, timeout_base_ms)int intel_pcode_init (struct drm_i915_private *i915);
Signature · 1 line
2.34.1
PATCH v2 4/9 drm/i915/gt: Convert callers to user per-gt pcode functions
In reply to Ashutosh DixitConvert appropriate callers to use per-gt pcode functions. Callers using pcode functions at "global scope", including *all* display functions are not converted, they continue to use the legacy pcode interface.
--- drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 6 +++--- drivers/gpu/drm/i915/gt/intel_llc.c | 9 ++++----- drivers/gpu/drm/i915/gt/intel_rc6.c | 4 ++-- drivers/gpu/drm/i915/gt/intel_rps.c | 6 +++--- drivers/gpu/drm/i915/gt/selftest_llc.c | 4 ++-- drivers/gpu/drm/i915/gt/selftest_rps.c | 4 ++-- 6 files changed, 16 insertions(+), 17 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c +3 -3
@@ -138,7 +138,7 @@ static int gen6_drpc(struct seq_file *m) }if (GRAPHICS_VER (i915) <=7 ) -snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); +intel_gt_pcode_read (gt,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );seq_printf (m,"RC1e Enabled: %s\n" ,str_yes_no (rcctl1 & GEN6_RC_CTL_RC1e_ENABLE));
@@ -545,8 +545,8 @@ static int llc_show(struct seq_file *m, void *data) wakeref =intel_runtime_pm_get (gt->uncore->rpm);for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) { ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , - &ia_freq,NULL ); +intel_gt_pcode_read (gt,GEN6_PCODE_READ_MIN_FREQ_TABLE , + &ia_freq,NULL ); seq_printf(m, "%d\t\t%d\t\t\t\t%d\n", intel_gpu_freq(rps, (gpu_freq *
drivers/gpu/drm/i915/gt/intel_llc.c +4 -5
@@ -124,7 +124,6 @@ static void calc_ia_freq(struct intel_llc *llc,static void gen6_update_ring_freq (struct intel_llc *llc) { -struct drm_i915_private *i915 =llc_to_gt (llc)->i915;struct ia_constants consts;unsigned int gpu_freq;
@@ -142,10 +141,10 @@ static void gen6_update_ring_freq(struct intel_llc *llc)unsigned int ia_freq, ring_freq;calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); -snb_pcode_write (i915,GEN6_PCODE_WRITE_MIN_FREQ_TABLE , - ia_freq <<GEN6_PCODE_FREQ_IA_RATIO_SHIFT | - ring_freq <<GEN6_PCODE_FREQ_RING_RATIO_SHIFT | - gpu_freq); +intel_gt_pcode_write (llc_to_gt (llc),GEN6_PCODE_WRITE_MIN_FREQ_TABLE , + ia_freq <<GEN6_PCODE_FREQ_IA_RATIO_SHIFT | + ring_freq <<GEN6_PCODE_FREQ_RING_RATIO_SHIFT | + gpu_freq); } }
drivers/gpu/drm/i915/gt/intel_rc6.c +2 -2
@@ -272,7 +272,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)GEN6_RC_CTL_HW_ENABLE ; rc6vids =0 ; - ret =snb_pcode_read (i915,GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL ); + ret =intel_gt_pcode_read (rc6_to_gt (rc6),GEN6_PCODE_READ_RC6VIDS , &rc6vids,NULL );if (GRAPHICS_VER (i915) ==6 && ret) {drm_dbg (&i915->drm,"Couldn't check for BIOS workaround\n" ); } else if (GRAPHICS_VER(i915) == 6 &&
@@ -282,7 +282,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6) GEN6_DECODE_RC6_VID(rc6vids & 0xff), 450); rc6vids &=0xffff00 ; rc6vids |=GEN6_ENCODE_RC6_VID (450 ); - ret =snb_pcode_write (i915,GEN6_PCODE_WRITE_RC6VIDS , rc6vids); + ret =intel_gt_pcode_write (rc6_to_gt (rc6),GEN6_PCODE_WRITE_RC6VIDS , rc6vids);if (ret)drm_err (&i915->drm,"Couldn't fix incorrect rc6 voltage\n" );
drivers/gpu/drm/i915/gt/intel_rps.c +3 -3
@@ -1142,8 +1142,8 @@ static void gen6_rps_init(struct intel_rps *rps)if (IS_GEN9_BC (i915) ||GRAPHICS_VER (i915) >=11 ) mult =GEN9_FREQ_SCALER ; -if (snb_pcode_read (i915,HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , - &ddcc_status,NULL ) ==0 ) +if (intel_gt_pcode_read (rps_to_gt (rps),HSW_PCODE_DYNAMIC_DUTY_CYCLE_CONTROL , + &ddcc_status,NULL ) ==0 ) rps->efficient_freq = clamp_t(u32, ((ddcc_status >> 8) & 0xff) * mult,
@@ -1982,7 +1982,7 @@ void intel_rps_init(struct intel_rps *rps)if (GRAPHICS_VER (i915) ==6 ||IS_IVYBRIDGE (i915) ||IS_HASWELL (i915)) {u32 params =0 ; -snb_pcode_read (i915,GEN6_READ_OC_PARAMS , ¶ms,NULL ); +intel_gt_pcode_read (rps_to_gt (rps),GEN6_READ_OC_PARAMS , ¶ms,NULL );if (params &BIT (31 )) {/* OC supported */ drm_dbg(&i915->drm, "Overclocking supported, max: %dMHz, overclock: %dMHz\n",
drivers/gpu/drm/i915/gt/selftest_llc.c +2 -2
@@ -31,8 +31,8 @@ static int gen6_verify_ring_freq(struct intel_llc *llc)calc_ia_freq (llc, gpu_freq, &consts, &ia_freq, &ring_freq); val = gpu_freq; -if (snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , - &val,NULL )) { +if (intel_gt_pcode_read (llc_to_gt (llc),GEN6_PCODE_READ_MIN_FREQ_TABLE , + &val,NULL )) {pr_err ("Failed to read freq table[%d], range [%d, %d]\n" , gpu_freq, consts.min_gpu_freq, consts.max_gpu_freq); err = -ENXIO ;
drivers/gpu/drm/i915/gt/selftest_rps.c +2 -2
@@ -521,8 +521,8 @@ static void show_pcu_config(struct intel_rps *rps)for (gpu_freq = min_gpu_freq; gpu_freq <= max_gpu_freq; gpu_freq++) {int ia_freq = gpu_freq; -snb_pcode_read (i915,GEN6_PCODE_READ_MIN_FREQ_TABLE , - &ia_freq,NULL ); +intel_gt_pcode_read (rps_to_gt (rps),GEN6_PCODE_READ_MIN_FREQ_TABLE , + &ia_freq,NULL ); pr_info("%5d %5d %5d\n", gpu_freq * 50,
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim checkpatch failed2993d1f47961 drm/i915: Introduce has_media_ratio_mode bce07f6f7b01 drm/i915/gt: Add media freq factor to per-gt sysfs 98c49b8e21f0 drm/i915/pcode: Extend pcode functions for multiple gt's f8fab08799a7 drm/i915/gt: Convert callers to user per-gt pcode functions 6bd0711a3b41 drm/i915/pcode: Add a couple of pcode helpers c05fb6b721be drm/i915/gt: Add media RP0/RPn to per-gt sysfs -:80: CHECK:CAMELCASE: Avoid CamelCase: <media_RPn_freq_mhz> #80: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:719:
+static DEVICE_ATTR_RO(media_RPn_freq_mhz);
-:86: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_media_RPn_freq_mhz> #86: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:725:
+ &dev_attr_media_RPn_freq_mhz.attr,
total: 0 errors, 0 warnings, 2 checks, 87 lines checked5baf8f9db7ad drm/i915/gt: Fix memory leaks in per-gt sysfs 02c0e57e2478 drm/i915/gt: Expose per-gt RPS defaults in sysfs acef7774effa drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev2)
URL : https://patchwork.freedesktop.org/series/102665/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11523 -> Patchwork_102665v2
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_102665v2 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_102665v2, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/index.html
Participating hosts (47 -> 45)
------------------------------
Additional (3): bat-adlm-1 fi-rkl-11600 fi-hsw-4770
Missing (5): fi-bdw-5557u fi-hsw-4200u fi-bsw-cyan fi-snb-2520m fi-ctg-p8600
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102665v2:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@slpc:
- bat-dg1-5: NOTRUN -> [INCOMPLETE][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/bat-dg1-5/igt@i915_selftest@[email protected]
Known issues
------------
Here are the changes found in Patchwork_102665v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3@smem:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][2] ([i915#5127])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-hsw-4770: NOTRUN -> [SKIP][3] ([fdo#109271]) +9 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-hsw-4770/igt@[email protected]
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#3012])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-hsw-4770/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-hsw-4770: NOTRUN -> [SKIP][5] ([fdo#109271] / [fdo#111827]) +8 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-hsw-4770/igt@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- fi-tgl-u2: [PASS][6] -> [DMESG-WARN][7] ([i915#402])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11523/fi-tgl-u2/igt@kms_flip@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-tgl-u2/igt@kms_flip@[email protected]
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-4770: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#533])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-hsw-4770/igt@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- fi-hsw-4770: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1072]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-adl-ddr5: [DMESG-WARN][10] -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11523/fi-adl-ddr5/igt@i915_selftest@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-adl-ddr5/igt@i915_selftest@[email protected]
- bat-dg1-6: [DMESG-FAIL][12] ([i915#4494] / [i915#4957]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11523/bat-dg1-6/igt@i915_selftest@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/bat-dg1-6/igt@i915_selftest@[email protected]
* igt@kms_frontbuffer_tracking@basic:
- fi-cml-u2: [DMESG-WARN][14] ([i915#4269]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11523/fi-cml-u2/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/fi-cml-u2/igt@[email protected]
#### Warnings ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-5: [INCOMPLETE][16] -> [DMESG-FAIL][17] ([i915#4494] / [i915#4957])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11523/bat-dg1-5/igt@i915_selftest@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/bat-dg1-5/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4269]: https://gitlab.freedesktop.org/drm/intel/issues/4269
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5552]: https://gitlab.freedesktop.org/drm/intel/issues/5552
Build changes
-------------
* IGT: IGT_6440 -> IGTPW_6952
* Linux: CI_DRM_11523 -> Patchwork_102665v2
CI-20190529: 20190529
CI_DRM_11523: 6b6803c3f43f5d0f960246b4b52f956f1a579833 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_6952: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_6952/index.html
IGT_6440: 04262fc75ff3ec42f4db0c929d46b7cd5083911f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102665v2: 6b6803c3f43f5d0f960246b4b52f956f1a579833 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
fba615af4388 drm/i915/gt: Expose default value for media_freq_factor in per-gt sysfs 4dbbf797fce1 drm/i915/gt: Expose per-gt RPS defaults in sysfs 571de9eed294 drm/i915/gt: Fix memory leaks in per-gt sysfs 53acdc5a10f5 drm/i915/gt: Add media RP0/RPn to per-gt sysfs 2beb6a66e339 drm/i915/pcode: Add a couple of pcode helpers 40c0bf34b990 drm/i915/gt: Convert callers to user per-gt pcode functions 53f9af589b81 drm/i915/pcode: Extend pcode functions for multiple gt's 40b9e9888c60 drm/i915/gt: Add media freq factor to per-gt sysfs d0aa37b05656 drm/i915: Introduce has_media_ratio_mode
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v2/index.html
Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Ashutosh DixitQuoted 2 lines · Andrzej Hajda
Hi Ashutosh,
Hi Andrzej,
Quoted 9 lines · Ashutosh Dixit
Quoted 8 lines
All kmalloc'd kobjects need a
kobject_put()to free memory. For example in previous code,kobj_gt_release()never gets called. The requirement ofkobject_put()now results in a slightly different code organization.Cc Andi Shyti <[email protected]>Cc Andrzej Hajda <[email protected]>Cc Rodrigo Vivi <[email protected]>Fixes b770bcfae9ad ("drm/i915/gt: create per-tile sysfs interface")
/snip/
Quoted 30 lines
Quoted 30 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +4
-0+void intel_gt_sysfs_unregister (struct intel_gt *gt) +{ +kobject_put (>->sysfs_gtn); +}drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +1
-4@@ -13,11 +13,6 @@struct intel_gt ; -struct kobj_gt { -struct kobject base; -struct intel_gt *gt; -}; -bool is_object_gt (struct kobject *kobj);struct drm_i915_private *kobj_to_i915 (struct kobject *kobj);@@ -28,6 +23,7 @@ intel_gt_create_kobj(struct intel_gt *gt, const char *name);void intel_gt_sysfs_register (struct intel_gt *gt); +void intel_gt_sysfs_unregister (struct intel_gt *gt);struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name); diff --git a/drivers/gpu/drm/i915/gt/intel_gt_types.h
b/drivers/gpu/drm/i915/gt/intel_gt_types.h
index937b2e1a305e..4c72b4f983a6100644drivers/gpu/drm/i915/gt/intel_gt_types.h +0
-0@@ -222,6 +222,9 @@ struct intel_gt { } mocs;
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h struct intel_gt { · line 227
Quoted 4 lines
drivers/gpu/drm/i915/gt/intel_gt_types.h +3
-0struct intel_pxp pxp; + +/* gt/gtN sysfs */ +struct kobject sysfs_gtn;If you put kobject as a part of
intel_gtwhat assures you that lifetime of kobject is shorter thanintel_gt? Ie its refcounter is 0 on removal ofintel_gt?
Because we are explicitly doing a kobject_put() in intel_gt_sysfs_unregister(). Which is exactly what we are *not* doing in the previous code.
Let me explain a bit about the previous code (but feel free to skip since the patch should speak for itself):
* Previously we kzalloc a 'struct kobj_gt'
* But we don't save a pointer to the 'struct kobj_gt' so we don't have the pointer to the kobject to be able to do a kobject_put() on it later
* Therefore we need to store the pointer in 'struct intel_gt'
* But if we have to put the pointer in 'struct intel_gt' we might as well put the kobject as part of 'struct intel_gt' and that also removes the need to have a 'struct kobj_gt' (kobj_to_gt() can just use container_of() to get gt from kobj).
* So I think this patch simpler/cleaner than the original code if you take the requirement for kobject_put() into account.
Thanks.
--
Ashutosh
Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs
In reply to Ashutosh DixitHi Ashutosh,
[...]
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj) · line 724
Quoted 9 lines
static int intel_sysfs_rps_init(struct
intel_gt*gt, struct kobject *kobj,drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +2
-0const struct attribute * const *attrs) {@@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)drm_warn (>->i915->drm,"failed to create gt%u throttle sysfs files (%pe)" , gt->info.id,ERR_PTR (ret)); + +if (HAS_MEDIA_RATIO_MODE (gt->i915) &&intel_uc_uses_guc_slpc (>->uc)) {
you could use in this case the ".is_visible()" function as you are not inheriting it from the upper drm class.
Anyway,
Thanks,
Andi
Re: [Intel-gfx] [PATCH 1/9] drm/i915: Introduce has_media_ratio_mode
In reply to Ashutosh DixitHi Ashutosh,
Quoted 8 lines
Media ratio mode (the ability for media IP to work at a different frequency from the GT) is available for a subset of dGfx platforms supporting GuC/SLPC. Introduce '
has_media_ratio_mode' flag inintel_device_infoto identify these platforms and set it for XEHPSDV and DG2/ATS-M.Cc Rodrigo Vivi <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>
Thanks,
Andi
Re: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's
In reply to Ashutosh DixitHi Ashutosh,
[...]
drivers/gpu/drm/i915/intel_pcode.c static int __snb_pcode_rw(struct drm_i915_private *i915, u32 mbox, · line 134
Quoted 4 lines
drivers/gpu/drm/i915/intel_pcode.c +1
-3-static bool skl_pcode_try_request (struct drm_i915_private *i915,u32 mbox, -u32 request,u32 reply_mask,u32 reply, -u32 *status) +static bool __gt_pcode_try_request(struct intel_gt *gt, u32 mbox,
why is this becoming a '__' function?
Quoted 72 lines
drivers/gpu/drm/i915/intel_pcode.c +26
-10+ u32 request, u32 reply_mask, u32 reply, + u32 *status) { - *status =__snb_pcode_rw (i915, mbox, &request,NULL ,500 ,0 , true); + *status =__gt_pcode_rw (gt, mbox, &request,NULL ,500 ,0 , true);return (*status ==0 ) && ((request & reply_mask) == reply); }/** -* skl_pcode_request - send PCODE request until acknowledgment -* @i915: device private +* intel_gt_pcode_request - send PCODE request until acknowledgment +* @gt: gt * @mbox: PCODE mailbox ID the request is targeted for * @request: request ID * @reply_mask: mask used to check for request acknowledgment @@ -158,16 +159,16 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox,* Returns 0 on success, %-ETIMEDOUT in case of a timeout, <0 in case of some * other error as reported by PCODE. */ -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, -u32 reply_mask,u32 reply,int timeout_base_ms) +int intel_gt_pcode_request (struct intel_gt *gt,u32 mbox,u32 request, +u32 reply_mask,u32 reply,int timeout_base_ms) {u32 status;int ret; -mutex_lock (&i915->sb_lock); +mutex_lock (>->i915->sb_lock);#define COND \ - skl_pcode_try_request(i915, mbox, request, reply_mask, reply, &status) + __gt_pcode_try_request(gt, mbox, request, reply_mask, reply, &status)/* * Prime the PCODE by doing a request first. Normally it guarantees @@ -193,35 +194,48 @@ int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request,* requests, and for any quirks of the PCODE firmware that delays * the request completion. */ -drm_dbg_kms (&i915->drm, +drm_dbg_kms (>->i915->drm,"PCODE timeout, retrying with preemption disabled\n" ); -drm_WARN_ON_ONCE (&i915->drm, timeout_base_ms >3 ); +drm_WARN_ON_ONCE (>->i915->drm, timeout_base_ms >3 );preempt_disable (); ret =wait_for_atomic (COND ,50 );preempt_enable (); out: -mutex_unlock (&i915->sb_lock); +mutex_unlock (>->i915->sb_lock);return status ? status : ret;#undef COND } +static int __gt_pcode_init (struct intel_gt *gt) +{ +int ret =intel_gt_pcode_request (gt,DG1_PCODE_STATUS , +DG1_UNCORE_GET_INIT_STATUS , +DG1_UNCORE_INIT_STATUS_COMPLETE , +DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); + +drm_dbg (>->i915->drm,"gt %d: PCODE init status %d\n" , gt->info.id, ret); + +if (ret) +drm_err (>->i915->drm,"gt %d: Pcode did not report uncore initialization completion!\n" , + gt->info.id); + +return ret;
drivers/gpu/drm/i915/intel_pcode.c int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request, · line 232
Quoted 10 lines
drivers/gpu/drm/i915/intel_pcode.c +4
-1+} +int intel_pcode_init (struct drm_i915_private *i915) { -int ret =0 ; +struct intel_gt *gt; +int i, ret =0 ;if (!IS_DGFX (i915))return ret;
we can take some freedom, if you don't mind, and declare ret inside the for_each, and return 0 here. Just a small cosmetic.
Quoted 48 lines
drivers/gpu/drm/i915/intel_pcode.c +6
-10- ret =skl_pcode_request (i915,DG1_PCODE_STATUS , -DG1_UNCORE_GET_INIT_STATUS , -DG1_UNCORE_INIT_STATUS_COMPLETE , -DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); - -drm_dbg (&i915->drm,"PCODE init status %d\n" , ret); - -if (ret) -drm_err (&i915->drm,"Pcode did not report uncore initialization completion!\n" ); +for_each_gt (gt, i915, i) { + ret =__gt_pcode_init (gt); +if (ret) +return ret; + } -return ret; +return 0 ; }drivers/gpu/drm/i915/intel_pcode.h +15
-4@@ -8,16 +8,31 @@#include <linux/types.h> +struct intel_gt ;struct drm_i915_private ; -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1); -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, -int fast_timeout_us,int slow_timeout_ms); -#define snb_pcode_write (i915, mbox, val) \ +int intel_gt_pcode_read (struct intel_gt *gt,u32 mbox,u32 *val,u32 *val1); + +int intel_gt_pcode_write_timeout (struct intel_gt *gt,u32 mbox,u32 val, +int fast_timeout_us,int slow_timeout_ms); + +#define intel_gt_pcode_write (gt, mbox, val) \ + intel_gt_pcode_write_timeout(gt, mbox, val, 500, 0) + +int intel_gt_pcode_request (struct intel_gt *gt,u32 mbox,u32 request, +u32 reply_mask,u32 reply,int timeout_base_ms); + +#define snb_pcode_read (i915, mbox, val, val1) \ + intel_gt_pcode_read(&(i915)->gt0, mbox, val, val1) +
drivers/gpu/drm/i915/intel_pcode.h line 35
Quoted 10 lines
drivers/gpu/drm/i915/intel_pcode.h +6
-2+#define snb_pcode_write_timeout (i915, mbox, val, fast_timeout_us, slow_timeout_ms) \ + intel_gt_pcode_write_timeout(&(i915)->gt0, mbox, val, fast_timeout_us, slow_timeout_ms) + +#define snb_pcode_write (i915, mbox, val) \ snb_pcode_write_timeout(i915, mbox, val, 500, 0) -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, -u32 reply_mask,u32 reply,int timeout_base_ms); +#define skl_pcode_request (i915, mbox, request, reply_mask, reply, timeout_base_ms) \ + intel_gt_pcode_request(&(i915)->gt0, mbox, request, reply_mask, reply, timeout_base_ms)
to_gt(i915)
I guess this is just a replacement i915 to gt, I think it's all correct and with the latter changed:
Thanks,
Andi
Re: [Intel-gfx] [PATCH 4/9] drm/i915/gt: Convert callers to user per-gt pcode functions
In reply to Ashutosh DixitHi Ashutosh,
Quoted 8 lines · Ashutosh Dixit
Convert appropriate callers to use per-gt pcode functions. Callers using pcode functions at "global scope", including *all* display functions are not converted, they continue to use the legacy pcode interface.
Cc Andi Shyti <[email protected]>Cc Jani Nikula <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>
Thanks,
Andi
Re: [Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers
In reply to Ashutosh DixitHi Ashutosh,
Quoted 4 lines · Ashutosh Dixit
From: Dale B Stimson <[email protected]>
Add a couple of helpers to help formatting pcode commands and improve code readability.
Can you please add some more details on the helpers?
Quoted 7 lines
v2: Fixed commit author (Rodrigo)
Cc Mike Ruhl <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Dale B Stimson <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]>
[...]
drivers/gpu/drm/i915/intel_pcode.h int intel_gt_pcode_request(struct intel_gt *gt, u32 mbox, u32 request, · line 49
Quoted 11 lines
drivers/gpu/drm/i915/intel_pcode.h +11
-0+/* +* Helpers for dGfx PCODE mailbox command formatting +*/ +int __intel_gt_pcode_read (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 *val); +int __intel_gt_pcode_write (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 val); + +#define __snb_pcode_read (i915, mbcmd, p1, p2, val) \ + __intel_gt_pcode_read(&(i915)->gt0, mbcmd, p1, p2, val) + +#define __snb_pcode_write (i915, mbcmd, p1, p2, val) \ + __intel_gt_pcode_write(&(i915)->gt0, mbcmd, p1, p2, val)
to_gt(i915)
Why do we need these defines? Looks hacky and lazy. Can't we just replace all __snb_pcode_read/write()?
Andi
Re: [Intel-gfx] [PATCH 6/9] drm/i915/gt: Add media RP0/RPn to per-gt sysfs
In reply to Ashutosh DixitHi Ashutosh,
[...]
Quoted 6 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +6
-0+static ssize_t media_RP0_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val;
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c static ssize_t media_freq_factor_store(struct device *dev, · line 688
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +10
-0+int err; + + err =__intel_gt_pcode_read (gt,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_P0 , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* data_out - Fused P0 for domain ID in units of 50 MHz */
this comment doesn't say much, can we make it a bit clearer? The same for the one below.
The rest looks good:
Quoted 15 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +15
-0+ val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} + +static ssize_t media_RPn_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err = __intel_gt_pcode_read(gt, XEHPSDV_PCODE_FREQUENCY_CONFIG, + PCODE_MBOX_FC_SC_READ_FUSED_PN,
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c static ssize_t media_freq_factor_store(struct device *dev, · line 713
Quoted 10 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +10
-0+ PCODE_MBOX_DOMAIN_MEDIAFF, &val); + +if (err) +return err; + +/* data_out - Fused P0 for domain ID in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +}
[...]
Thanks,
Andi
Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Ashutosh DixitHi Ashutosh,
[...]
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c static struct attribute *id_attrs[] = { · line 80
Quoted 3 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-2-static struct kobj_type kobj_gt_type = { - .release = kobj_gt_release, +static struct kobj_type kobj_gtn_type = {
what does it mean GTN? Or is it GTn? Please use just GT, gtn is confusing.
Same for all the rest of the gtn's you have used below.
Thanks,
Andi
Re: [Intel-gfx] [PATCH 2/9] drm/i915/gt: Add media freq factor to per-gt sysfs
In reply to Andi ShytiQuoted 2 lines · Andi Shyti
Hi Ashutosh,
Hi Andi
Quoted 14 lines
[...]
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj) · line 724
Quoted 9 lines
static int intel_sysfs_rps_init(struct
intel_gt*gt, struct kobject *kobj,
const struct attribute * const *attrs)
{drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +2
-0@@ -598,4 +720,12 @@ void intel_gt_sysfs_pm_init(struct intel_gt *gt, struct kobject *kobj)drm_warn (>->i915->drm,"failed to create gt%u throttle sysfs files (%pe)" , gt->info.id,ERR_PTR (ret)); + +if (HAS_MEDIA_RATIO_MODE (gt->i915) &&intel_uc_uses_guc_slpc (>->uc)) {you could use in this case the ".is_visible()" function as you are not inheriting it from the upper drm class.
".is_visible()" is only available in an "attribute_group" but here we are not creating an "attribute_group", just creating files in a previously existing sysfs directory (i.e. using using sysfs_create_files() (as done for RPS attributes) rather than sysfs_create_group() (as done for RC6)). There seems to be no reason to create an "attribute_group" (such as what was needed for RC6) so unless you suggest otherwise I'm leaving this as is.
Quoted 4 lines
Anyway,
Reviewed-by Andi Shyti <[email protected]>
Thanks.
--
Ashutosh
Jani Nikula
maintainerRe: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's
In reply to Ashutosh DixitQuoted 3 lines · Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. Previous (GT0) pcode read/write interfaces are preserved.
Replying here as well. I'd prefer it if a dependency on gt wasn't introduced here. You could just pass the uncore.
BR,
Jani.
Quoted 251 lines
Cc Rodrigo Vivi <[email protected]>Cc Mike Ruhl <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>--- drivers/gpu/drm/i915/intel_pcode.c | 108 ++++++++++++++++------------- drivers/gpu/drm/i915/intel_pcode.h | 27 ++++++-- 2 files changed, 82 insertions(+), 53 deletions(-)drivers/gpu/drm/i915/intel_pcode.c +61
-47@@ -6,6 +6,7 @@#include "i915_drv.h" #include "i915_reg.h" #include "intel_pcode.h" +#include "gt/intel_gt.h" static int gen6_check_mailbox_status (u32 mbox) {@@ -52,14 +53,14 @@ static int gen7_check_mailbox_status(u32 mbox) } } -static int __snb_pcode_rw (struct drm_i915_private *i915,u32 mbox, -u32 *val,u32 *val1, -int fast_timeout_us,int slow_timeout_ms, -bool is_read) +static int __gt_pcode_rw (struct intel_gt *gt,u32 mbox, +u32 *val,u32 *val1, +int fast_timeout_us,int slow_timeout_ms, +bool is_read) { -struct intel_uncore *uncore = &i915->uncore; +struct intel_uncore *uncore = gt->uncore; -lockdep_assert_held (&i915->sb_lock); +lockdep_assert_held (>->i915->sb_lock);/* * GEN6_PCODE_* are outside of the forcewake domain, we can use @@ -88,60 +89,60 @@ static int __snb_pcode_rw(struct drm_i915_private *i915, u32 mbox,if (is_read && val1) *val1 =intel_uncore_read_fw (uncore,GEN6_PCODE_DATA1 ); -if (GRAPHICS_VER (i915) >6 ) +if (GRAPHICS_VER (gt->i915) >6 )return gen7_check_mailbox_status (mbox);else return gen6_check_mailbox_status (mbox); } -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1) +int intel_gt_pcode_read (struct intel_gt *gt,u32 mbox,u32 *val,u32 *val1) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, val, val1,500 ,20 , true); -mutex_unlock (&i915->sb_lock); +mutex_lock (>->i915->sb_lock); + err =__gt_pcode_rw (gt, mbox, val, val1,500 ,20 , true); +mutex_unlock (>->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, -"warning: pcode (read from mbox %x) mailbox access failed for %ps: %d\n" , - mbox,__builtin_return_address (0 ), err); +drm_dbg (>->i915->drm, +"gt %d: warning: pcode (read from mbox %x) mailbox access failed for %ps: %d\n" , + gt->info.id, mbox,__builtin_return_address (0 ), err); }return err; } -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, -int fast_timeout_us,int slow_timeout_ms) +int intel_gt_pcode_write_timeout (struct intel_gt *gt,u32 mbox,u32 val, +int fast_timeout_us,int slow_timeout_ms) {int err; -mutex_lock (&i915->sb_lock); - err =__snb_pcode_rw (i915, mbox, &val,NULL , - fast_timeout_us, slow_timeout_ms, false); -mutex_unlock (&i915->sb_lock); +mutex_lock (>->i915->sb_lock); + err =__gt_pcode_rw (gt, mbox, &val,NULL , + fast_timeout_us, slow_timeout_ms, false); +mutex_unlock (>->i915->sb_lock);if (err) { -drm_dbg (&i915->drm, -"warning: pcode (write of 0x%08x to mbox %x) mailbox access failed for %ps: %d\n" , - val, mbox,__builtin_return_address (0 ), err); +drm_dbg (>->i915->drm, +"gt %d: warning: pcode (write of 0x%08x to mbox %x) mailbox access failed for %ps: %d\n" , + gt->info.id, val, mbox,__builtin_return_address (0 ), err); }return err; } -static bool skl_pcode_try_request (struct drm_i915_private *i915,u32 mbox, -u32 request,u32 reply_mask,u32 reply, -u32 *status) +static bool __gt_pcode_try_request (struct intel_gt *gt,u32 mbox, +u32 request,u32 reply_mask,u32 reply, +u32 *status) { - *status =__snb_pcode_rw (i915, mbox, &request,NULL ,500 ,0 , true); + *status =__gt_pcode_rw (gt, mbox, &request,NULL ,500 ,0 , true);return (*status ==0 ) && ((request & reply_mask) == reply); }/** -* skl_pcode_request - send PCODE request until acknowledgment -* @i915: device private +* intel_gt_pcode_request - send PCODE request until acknowledgment +* @gt: gt * @mbox: PCODE mailbox ID the request is targeted for * @request: request ID * @reply_mask: mask used to check for request acknowledgment @@ -158,16 +159,16 @@ static bool skl_pcode_try_request(struct drm_i915_private *i915, u32 mbox,* Returns 0 on success, %-ETIMEDOUT in case of a timeout, <0 in case of some * other error as reported by PCODE. */ -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, -u32 reply_mask,u32 reply,int timeout_base_ms) +int intel_gt_pcode_request (struct intel_gt *gt,u32 mbox,u32 request, +u32 reply_mask,u32 reply,int timeout_base_ms) {u32 status;int ret; -mutex_lock (&i915->sb_lock); +mutex_lock (>->i915->sb_lock);#define COND \ - skl_pcode_try_request(i915, mbox, request, reply_mask, reply, &status) + __gt_pcode_try_request(gt, mbox, request, reply_mask, reply, &status)/* * Prime the PCODE by doing a request first. Normally it guarantees @@ -193,35 +194,48 @@ int skl_pcode_request(struct drm_i915_private *i915, u32 mbox, u32 request,* requests, and for any quirks of the PCODE firmware that delays * the request completion. */ -drm_dbg_kms (&i915->drm, +drm_dbg_kms (>->i915->drm,"PCODE timeout, retrying with preemption disabled\n" ); -drm_WARN_ON_ONCE (&i915->drm, timeout_base_ms >3 ); +drm_WARN_ON_ONCE (>->i915->drm, timeout_base_ms >3 );preempt_disable (); ret =wait_for_atomic (COND ,50 );preempt_enable (); out: -mutex_unlock (&i915->sb_lock); +mutex_unlock (>->i915->sb_lock);return status ? status : ret;#undef COND } +static int __gt_pcode_init (struct intel_gt *gt) +{ +int ret =intel_gt_pcode_request (gt,DG1_PCODE_STATUS , +DG1_UNCORE_GET_INIT_STATUS , +DG1_UNCORE_INIT_STATUS_COMPLETE , +DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); + +drm_dbg (>->i915->drm,"gt %d: PCODE init status %d\n" , gt->info.id, ret); + +if (ret) +drm_err (>->i915->drm,"gt %d: Pcode did not report uncore initialization completion!\n" , + gt->info.id); + +return ret; +} +int intel_pcode_init (struct drm_i915_private *i915) { -int ret =0 ; +struct intel_gt *gt; +int i, ret =0 ;if (!IS_DGFX (i915))return ret; - ret =skl_pcode_request (i915,DG1_PCODE_STATUS , -DG1_UNCORE_GET_INIT_STATUS , -DG1_UNCORE_INIT_STATUS_COMPLETE , -DG1_UNCORE_INIT_STATUS_COMPLETE ,180000 ); - -drm_dbg (&i915->drm,"PCODE init status %d\n" , ret); - -if (ret) -drm_err (&i915->drm,"Pcode did not report uncore initialization completion!\n" ); +for_each_gt (gt, i915, i) { + ret =__gt_pcode_init (gt); +if (ret) +return ret; + } -return ret; +return 0 ; }drivers/gpu/drm/i915/intel_pcode.h +21
-6@@ -8,16 +8,31 @@#include <linux/types.h> +struct intel_gt ;struct drm_i915_private ; -int snb_pcode_read (struct drm_i915_private *i915,u32 mbox,u32 *val,u32 *val1); -int snb_pcode_write_timeout (struct drm_i915_private *i915,u32 mbox,u32 val, -int fast_timeout_us,int slow_timeout_ms); -#define snb_pcode_write (i915, mbox, val) \ +int intel_gt_pcode_read (struct intel_gt *gt,u32 mbox,u32 *val,u32 *val1); + +int intel_gt_pcode_write_timeout (struct intel_gt *gt,u32 mbox,u32 val, +int fast_timeout_us,int slow_timeout_ms); + +#define intel_gt_pcode_write (gt, mbox, val) \ + intel_gt_pcode_write_timeout(gt, mbox, val, 500, 0) + +int intel_gt_pcode_request (struct intel_gt *gt,u32 mbox,u32 request, +u32 reply_mask,u32 reply,int timeout_base_ms); + +#define snb_pcode_read (i915, mbox, val, val1) \ + intel_gt_pcode_read(&(i915)->gt0, mbox, val, val1) + +#define snb_pcode_write_timeout (i915, mbox, val, fast_timeout_us, slow_timeout_ms) \ + intel_gt_pcode_write_timeout(&(i915)->gt0, mbox, val, fast_timeout_us, slow_timeout_ms) + +#define snb_pcode_write (i915, mbox, val) \ snb_pcode_write_timeout(i915, mbox, val, 500, 0) -int skl_pcode_request (struct drm_i915_private *i915,u32 mbox,u32 request, -u32 reply_mask,u32 reply,int timeout_base_ms); +#define skl_pcode_request (i915, mbox, request, reply_mask, reply, timeout_base_ms) \ + intel_gt_pcode_request(&(i915)->gt0, mbox, request, reply_mask, reply, timeout_base_ms)int intel_pcode_init (struct drm_i915_private *i915);
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Re: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's
Quoted 8 lines · Jani Nikula
Quoted 3 lines · Ashutosh Dixit
Each gt contains an independent instance of pcode. Extend pcode functions to interface with pcode on different gt's. Previous (GT0) pcode read/write interfaces are preserved.
Replying here as well. I'd prefer it if a dependency on gt wasn't introduced here. You could just pass the uncore.
This seems like a good solution, I will rework the patches. Thanks.
Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Andi ShytiQuoted 3 lines · Andi Shyti
Hi Ashutosh,
Hi Andi,
Quoted 10 lines
[...]
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c static struct attribute *id_attrs[] = { · line 80
Quoted 3 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-2-static struct kobj_type kobj_gt_type = { - .release = kobj_gt_release, +static struct kobj_type kobj_gtn_type = {what does it mean GTN? Or is it GTn? Please use just GT, gtn is confusing.
Same for all the rest of the gtn's you have used below.
I didn't like gtn either. But a sysfs_gt kobject is already part of 'struct drm_i915_private' so I thought I'll put sysfs_gtn (for gt/gtN) in 'struct intel_gt'. Otherwise browsing the code etc. gets confusing.
So that was the reason, but I think I'll change the name to 'kobj_gt' (from the current 'sysfs_gtn') in the next rev. That seems better. Thoughts?
Will respond to your other comments after posting the next rev patches (now need some rework because Jani doesn't want a dependence between gt and display code in pcode functions).
Thanks.
--
Ashutosh
Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs
Hi Ashutosh,
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c static struct attribute *id_attrs[] = { · line 80
Quoted 3 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-2-static struct kobj_type kobj_gt_type = { - .release = kobj_gt_release, +static struct kobj_type kobj_gtn_type = {what does it mean GTN? Or is it GTn? Please use just GT, gtn is confusing.
Quoted 5 lines
Quoted 1 line
Same for all the rest of the gtn's you have used below.
I didn't like gtn either. But a
sysfs_gtkobject is already part of 'structdrm_i915_private' so I thought I'll putsysfs_gtn(for gt/gtN) in 'structintel_gt'. Otherwise browsing the code etc. gets confusing.
we can even use 'gt_n' if the 'n' is really necessary.
Andi
Re: [Intel-gfx] [PATCH 7/9] drm/i915/gt: Fix memory leaks in per-gt sysfs
Quoted 2 lines · Andi Shyti
Hi Ashutosh,
Hi Andi,
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c static struct attribute *id_attrs[] = { · line 80
Quoted 3 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +1
-2-static struct kobj_type kobj_gt_type = { - .release = kobj_gt_release, +static struct kobj_type kobj_gtn_type = {what does it mean GTN? Or is it GTn? Please use just GT, gtn is confusing.
Quoted 7 lines
Quoted 5 lines
Quoted 1 line
Same for all the rest of the gtn's you have used below.
I didn't like gtn either. But a
sysfs_gtkobject is already part of 'structdrm_i915_private' so I thought I'll putsysfs_gtn(for gt/gtN) in 'structintel_gt'. Otherwise browsing the code etc. gets confusing.we can even use '
gt_n' if the 'n' is really necessary.
I decided to just go with sysfs_gt in v2 as you had suggested. The total number of instances of sysfs_gt are very few so it didn't seem too bad to have the same member name in the two struct's.
Thanks.
--
Ashutosh
Re: [Intel-gfx] [PATCH 6/9] drm/i915/gt: Add media RP0/RPn to per-gt sysfs
In reply to Andi ShytiQuoted 16 lines · Andi Shyti
Hi Ashutosh,
[...]
Quoted 11 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +11
-0+static ssize_t media_RP0_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =__intel_gt_pcode_read (gt,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_P0 , +PCODE_MBOX_DOMAIN_MEDIAFF , &val);
Quoted 8 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c static ssize_t media_freq_factor_store(struct device *dev, · line 688
Quoted 5 lines
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +5
-0+ +if (err) +return err; + +/* data_out - Fused P0 for domain ID in units of 50 MHz */ this comment doesn't say much, can we make it a bit clearer? The same for the one below.
Hopefully I've made it a bit clearer in v3.
Quoted 4 lines
The rest looks good:
Reviewed-by Andi Shyti <[email protected]>
Retaining the R-b, since change in v3 is just s/gt/gt->uncore/.
Re: [Intel-gfx] [PATCH 4/9] drm/i915/gt: Convert callers to user per-gt pcode functions
In reply to Andi ShytiQuoted 8 lines · Andi Shyti
Hi Ashutosh,
Quoted 4 lines · Ashutosh Dixit
Convert appropriate callers to use per-gt pcode functions. Callers using pcode functions at "global scope", including *all* display functions are not converted, they continue to use the legacy pcode interface.
Quoted 6 lines
Quoted 4 lines
Cc Andi Shyti <[email protected]>Cc Jani Nikula <[email protected]>Cc Rodrigo Vivi <[email protected]>Signed-off-by Ashutosh Dixit <[email protected]>Reviewed-by Andi Shyti <[email protected]>
Retaining the R-b since change in v3 is just s/gt/gt->uncore/.
Re: [Intel-gfx] [PATCH 3/9] drm/i915/pcode: Extend pcode functions for multiple gt's
In reply to Andi ShytiQuoted 2 lines · Andi Shyti
Hi Ashutosh,
Hi Andi,
Quoted 8 lines
[...]
drivers/gpu/drm/i915/intel_pcode.c static int __snb_pcode_rw(struct drm_i915_private *i915, u32 mbox, · line 134
Quoted 4 lines
drivers/gpu/drm/i915/intel_pcode.c +1
-3-static bool skl_pcode_try_request (struct drm_i915_private *i915,u32 mbox, -u32 request,u32 reply_mask,u32 reply, -u32 *status) +static bool __gt_pcode_try_request(struct intel_gt *gt, u32 mbox,why is this becoming a '__' function?
Fixed in v3.
Quoted 11 lines
Quoted 8 lines
int
intel_pcode_init(struct drm_i915_private *i915){drivers/gpu/drm/i915/intel_pcode.c +2
-1-int ret =0 ; +struct intel_gt *gt; +int i, ret =0 ;if (!IS_DGFX(i915)) return ret;we can take some freedom, if you don't mind, and declare ret inside the
for_each, and return 0 here. Just a small cosmetic.
Good idea, changed in v3.
Quoted 4 lines
drivers/gpu/drm/i915/intel_pcode.h line 35
Quoted 2 lines
drivers/gpu/drm/i915/intel_pcode.h +2
-0+#define skl_pcode_request (i915, mbox, request, reply_mask, reply, timeout_base_ms) \ + intel_gt_pcode_request(&(i915)->gt0, mbox, request, reply_mask, reply, timeout_base_ms)
to_gt(i915)
Not needed in v3 due to interface change to uncore.
Quoted 4 lines
I guess this is just a replacement i915 to gt, I think it's all correct and with the latter changed:
Reviewed-by Andi Shyti <[email protected]>
I've removed the R-b from this patch due to interface change to uncore since it's a significant change. I have retained R-b on the following patches since those changes are just s/gt/gt->uncore/ .
Thanks.
--
Ashutosh
Re: [Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers
In reply to Andi ShytiQuoted 10 lines · Andi Shyti
Hi Ashutosh,
Quoted 4 lines · Ashutosh Dixit
From: Dale B Stimson <[email protected]>
Add a couple of helpers to help formatting pcode commands and improve code readability.
Can you please add some more details on the helpers?
Done in v3, please take a look.
Quoted 14 lines
drivers/gpu/drm/i915/intel_pcode.h int intel_gt_pcode_request(struct intel_gt *gt, u32 mbox, u32 request, · line 49
Quoted 11 lines
drivers/gpu/drm/i915/intel_pcode.h +11
-0+/* +* Helpers for dGfx PCODE mailbox command formatting +*/ +int __intel_gt_pcode_read (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 *val); +int __intel_gt_pcode_write (struct intel_gt *gt,u32 mbcmd,u32 p1,u32 p2,u32 val); + +#define __snb_pcode_read (i915, mbcmd, p1, p2, val) \ + __intel_gt_pcode_read(&(i915)->gt0, mbcmd, p1, p2, val) + +#define __snb_pcode_write (i915, mbcmd, p1, p2, val) \ + __intel_gt_pcode_write(&(i915)->gt0, mbcmd, p1, p2, val)
to_gt(i915)
Quoted 2 lines
Why do we need these defines? Looks hacky and lazy. Can't we just replace all __snb_pcode_read/write()?
You are right, I've removed the #define's in v3.
Thanks.
--
Ashutosh