media: v4l2-core: Enable reserved field of v4l2_event
PATCH 1/1 media: v4l2-core: Enable reserved field of v4l2_event
'reserved' member of struct v4l2_event is currently not enabled. This field can be used to transfer data, if >64 bytes of data has to be sent. Hence, added this change to copy the reserved field in __v4l2_event_queue_fh.
Naina Vaskenly (1):
media: v4l2-core: Enable reserved field of v4l2_event
drivers/media/v4l2-core/v4l2-event.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.7.4
Quoted 11 lines · Naina Vaskenly
'reserved' member of struct
v4l2_eventis currently not enabled. This field can be used to transfer data, if >64 bytes of data has to be sent. Hence, added this change to copy the reserved field in__v4l2_event_queue_fh.Naina Vaskenly (1):
media: v4l2-core: Enable reserved field ofv4l2_eventdrivers/media/v4l2-core/v4l2-event.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
No patch?
Regards,
Hans
PATCH 1/1 media: v4l2-core: Enable reserved field of v4l2_event
In reply to Naina Vaskenly'reserved' member of struct v4l2_event is currently not enabled. This field can be used to transfer data, if >64 bytes of data has to be sent. Hence, added this change to copy the reserved field in __v4l2_event_queue_fh.
--- drivers/media/v4l2-core/v4l2-event.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/media/v4l2-core/v4l2-event.c +3 -1
@@ -137,8 +137,10 @@ static void __v4l2_event_queue_fh(struct v4l2_fh *fh,/* Take one and fill it. */ kev = sev->events +sev_pos (sev, sev->in_use); kev->event.type = ev->type; -if (copy_payload) +if (copy_payload) { kev->event.u = ev->u; +memcpy (kev->event.reserved, ev->reserved,sizeof (ev->reserved)); + } kev->event.id = ev->id; kev->ts = ts; kev->event.sequence = fh->sequence;
Signature · 1 line
2.7.4
Quoted 16 lines · Naina Vaskenly
'reserved' member of struct
v4l2_eventis currently not enabled. This field can be used to transfer data, if >64 bytes of data has to be sent. Hence, added this change to copy the reserved field in__v4l2_event_queue_fh.Signed-off-by Naina Vaskenly <[email protected]>--- drivers/media/v4l2-core/v4l2-event.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/media/v4l2-core/v4l2-event.c +0
-0@@ -137,8 +137,10 @@ static void __v4l2_event_queue_fh(struct v4l2_fh *fh,/* Take one and fill it. */
drivers/media/v4l2-core/v4l2-event.c static void __v4l2_event_queue_fh(struct v4l2_fh *fh, · line 146
Quoted 10 lines
drivers/media/v4l2-core/v4l2-event.c +3
-1kev = sev->events +sev_pos (sev, sev->in_use); kev->event.type = ev->type; -if (copy_payload) +if (copy_payload) { kev->event.u = ev->u; +memcpy (kev->event.reserved, ev->reserved,sizeof (ev->reserved)); + } kev->event.id = ev->id; kev->ts = ts; kev->event.sequence = fh->sequence;
What's the point of this? It's a reserved field, it must be 0. If you want to use it for something else, then make a proposal to repurpose some of the reserved fields.
This looks like you are trying to copy reserved data for some driver-specific hack.
That's not going to be accepted.
For the record:
Regards,
Hans