Skip to contentSkip to conversation

dt-bindings: vendor-prefixes: Add prefix for EBBG

PATCH Superseded Joel Selvaraj 4 participants 9 messages May 11, 2022 – May 13, 2022 1 message not in the archive

Subsystems (5)
Device tree bindings DRM drivers DRM misc DRM panel drivers +1 more subsystems

v2 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Joel Selvaraj

author maintainer
#1 lore raw

PATCH v2 1/3 dt-bindings: vendor-prefixes: Add prefix for EBBG

Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company.

Signed-off-by Joel Selvaraj <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
index 80e80fa53f8a..effd1cb995cf 100644
@@ -337,6 +337,8 @@ patternProperties:
     description: Embedded Artists AB
   "^ebang,.*":
     description: Zhejiang Ebang Communication Co., Ltd
+  "^ebbg,.*":
+    description: EBBG
   "^ebs-systart,.*":
     description: EBS-SYSTART GmbH
   "^ebv,.*":
Signature · 1 line
2.36.1
#2 lore raw
Quoted 7 lines · Joel Selvaraj

Add a prefix for EBBG. They manufacture displays which are used in some Xiaomi phones, but I could not find much details about the company.

Signed-off-by Joel Selvaraj <[email protected]>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L543

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof

author maintainer
#3 lore raw
Quoted 7 lines · Krzysztof Kozlowski

Please add Acked-by/Reviewed-by tags when posting new versions. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L543

If a tag was not added on purpose, please state why and what changed.

My bad. Completely forgot to pick the Acked-by. I will make sure to pick them up in future patches.

Best Regards,
Joel Selvaraj

author maintainer
#4 lore raw

PATCH v2 2/3 dt-bindings: display: Add bindings for EBBG FT8719

In reply to a message not in the archive

Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver.

Signed-off-by Joel Selvaraj <[email protected]>

---
Changes in v2: (Krzysztof Kozlowski's Suggestions)
- Specify maxItems for reg
- Cleanup and simplify the panel properties
- In example change "|+" to "|' and "dsi0" to "dsi"

 .../bindings/display/panel/ebbg,ft8719.yaml   | 74 +++++++++++++++++++
 1 file changed, 74 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml new file +74 -0
new file mode 100644
index 000000000000..80deedc01c7c
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/ebbg,ft8719.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: EBBG FT8719 MIPI-DSI LCD panel
+
+maintainers:
+  - Joel Selvaraj <[email protected]>
+
+description: |
+  The FT8719 panel from EBBG is a FHD+ LCD display panel with a resolution
+  of 1080x2246. It is a video mode DSI panel. The backlight is managed
+  through the QCOM WLED driver.
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    const: ebbg,ft8719
+
+  reg:
+    maxItems: 1
+    description: DSI virtual channel of the peripheral
+
+  vddio-supply:
+    description: power IC supply regulator
+
+  vddpos-supply:
+    description: positive boost supply regulator
+
+  vddneg-supply:
+    description: negative boost supply regulator
+
+required:
+  - compatible
+  - reg
+  - vddio-supply
+  - vddpos-supply
+  - vddneg-supply
+  - reset-gpios
+  - port
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    dsi {
+      #address-cells = <1>;
+      #size-cells = <0>;
+
+      panel@0 {
+        compatible = "ebbg,ft8719";
+        reg = <0>;
+
+        vddio-supply = <&vreg_l14a_1p88>;
+        vddpos-supply = <&lab>;
+        vddneg-supply = <&ibb>;
+
+        reset-gpios = <&tlmm 6 GPIO_ACTIVE_LOW>;
+
+        backlight = <&pmi8998_wled>;
+
+        port {
+          ebbg_ft8719_in_0: endpoint {
+            remote-endpoint = <&dsi0_out>;
+          };
+        };
+      };
+    };
Signature · 1 line
2.36.1
Reviewed-by on v2 2/3
#6 lore raw

Re: [PATCH v2 2/3] dt-bindings: display: Add bindings for EBBG FT8719

In reply to Joel Selvaraj
Quoted 10 lines · Joel Selvaraj

Add bindings for the EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The backlight is managed through the QCOM WLED driver.

Signed-off-by Joel Selvaraj <[email protected]>

---
Changes in v2: (Krzysztof Kozlowski's Suggestions)
- Specify maxItems for reg
- Cleanup and simplify the panel properties
- In example change "|+" to "|' and "dsi0" to "dsi"

Reviewed-by Linus Walleij <[email protected]>

Yours,
Linus Walleij

author maintainer
#7 lore raw

PATCH v2 3/3 drm/panel: introduce ebbg,ft8719 panel

In reply to a message not in the archive

Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver.

Signed-off-by Joel Selvaraj <[email protected]>
---
 MAINTAINERS                               |   7 +
 drivers/gpu/drm/panel/Kconfig             |  11 +
 drivers/gpu/drm/panel/Makefile            |   1 +
 drivers/gpu/drm/panel/panel-ebbg-ft8719.c | 362 ++++++++++++++++++++++
 4 files changed, 381 insertions(+)
 create mode 100644 drivers/gpu/drm/panel/panel-ebbg-ft8719.c
MAINTAINERS +7 -0
index cd0f68d4a34a..dfd2c53aea00 100644
@@ -6018,6 +6018,13 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/display/bridge/chipone,icn6211.yaml
 F:	drivers/gpu/drm/bridge/chipone-icn6211.c
 
+DRM DRIVER FOR EBBG FT8719 PANEL
+M:	Joel Selvaraj <[email protected]>
+S:	Maintained
+T:	git git://anongit.freedesktop.org/drm/drm-misc
+F:	Documentation/devicetree/bindings/display/panel/ebbg,ft8719.yaml
+F:	drivers/gpu/drm/panel/panel-ebbg-ft8719.c
+
 DRM DRIVER FOR FARADAY TVE200 TV ENCODER
 M:	Linus Walleij <[email protected]>
 S:	Maintained
drivers/gpu/drm/panel/Kconfig +11 -0
index 9989a316fe88..77176df2e2ec 100644
@@ -114,6 +114,17 @@ config DRM_PANEL_EDP
 	  that it can be automatically turned off when the panel goes into a
 	  low power state.
 
+config DRM_PANEL_EBBG_FT8719
+	tristate "EBBG FT8719 panel driver"
+	depends on OF
+	depends on DRM_MIPI_DSI
+	depends on BACKLIGHT_CLASS_DEVICE
+	help
+	  Say Y here if you want to enable support for the EBBG FT8719
+	  video mode panel. Mainly found on Xiaomi Poco F1 mobile phone.
+	  The panel has a resolution of 1080x2246. It provides a MIPI DSI
+	  interface to the host.
+
 config DRM_PANEL_ELIDA_KD35T133
 	tristate "Elida KD35T133 panel driver"
 	depends on OF
drivers/gpu/drm/panel/Makefile +1 -0
index d99fbbce49d1..47cc20c1a770 100644
@@ -9,6 +9,7 @@ obj-$(CONFIG_DRM_PANEL_DSI_CM) += panel-dsi-cm.o
 obj-$(CONFIG_DRM_PANEL_LVDS) += panel-lvds.o
 obj-$(CONFIG_DRM_PANEL_SIMPLE) += panel-simple.o
 obj-$(CONFIG_DRM_PANEL_EDP) += panel-edp.o
+obj-$(CONFIG_DRM_PANEL_EBBG_FT8719) += panel-ebbg-ft8719.o
 obj-$(CONFIG_DRM_PANEL_ELIDA_KD35T133) += panel-elida-kd35t133.o
 obj-$(CONFIG_DRM_PANEL_FEIXIN_K101_IM2BA02) += panel-feixin-k101-im2ba02.o
 obj-$(CONFIG_DRM_PANEL_FEIYANG_FY07024DI26A30D) += panel-feiyang-fy07024di26a30d.o
drivers/gpu/drm/panel/panel-ebbg-ft8719.c new file +362 -0

362 lines not on this page · raw message

Signature · 1 line
2.36.1
Reviewed-by on v2 3/3
#8 lore raw

Re: [PATCH v2 3/3] drm/panel: introduce ebbg,ft8719 panel

Hi Joel,

Quoted 5 lines · Joel Selvaraj

Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver.

Signed-off-by Joel Selvaraj <[email protected]>

Driver looks good:

Reviewed-by Sam Ravnborg <[email protected]>

I expect someone else to pick it up and apply.

Sam

#9 lore raw

Re: [PATCH v2 3/3] drm/panel: introduce ebbg,ft8719 panel

In reply to Joel Selvaraj
Quoted 5 lines · Joel Selvaraj

Add DRM panel driver for EBBG FT8719 6.18" 2246x1080 DSI video mode panel, which can be found on some Xiaomi Poco F1 phones. The panel's backlight is managed through QCOM WLED driver.

Signed-off-by Joel Selvaraj <[email protected]>

I see my review comments on v1 arrived after v2.

Nevertheless, please address my review comments on v1.

drivers/gpu/drm/panel/panel-ebbg-ft8719.c line 39

Quoted 8 lines
drivers/gpu/drm/panel/panel-ebbg-ft8719.c new file +8 -0
+struct ebbg_ft8719 {
+       struct drm_panel panel;
+       struct mipi_dsi_device *dsi;
+
+       struct regulator_bulk_data supplies[ARRAY_SIZE(regulator_names)];
+
+       struct gpio_desc *reset_gpio;
+       bool prepared;

For example that means to drop this prepared member.

Yours,
Linus Walleij