drm/i915: Media freq factor and per-gt enhancements/fixes
Subsystems (2)
cover drm/i915: Media freq factor and per-gt enhancements/fixes
Some recent Intel dGfx platforms allow media IP to work at a different frequency from the base GT. This patch series exposes sysfs controls for this functionality in the new per-gt sysfs. Some enhancements and fixes to previous per-gt functionality are also included to complete the new functionality:
* Patches 1 and 2 implement basic sysfs controls for media freq
* Patch 3 extends previous pcode functions for multiple gt's
* Patch 4 inits pcode on different gt's
* Patch 5 adds a couple of pcode helpers
* Patch 6 uses the new pcode functions to retrieve media RP0/RPn freq
* Patch 7 fixes memory leaks in the previous per-gt sysfs implementation and some code refactoring
IGT tests for this new functionality have also been posted at:
https://patchwork.freedesktop.org/series/103175/
Test-with: [email protected]
v2: Fixed commit author on patches 5 and 6 (Rodrigo)
Added new patch 4
v3: Expose pcode functions in terms of uncore rather than gt (Jani/Rodrigo)
v4: Retain previous pcode function names to eliminate
needless #defines (Rodrigo)
v5: Add new patch 4 and remove last two patches in the v4 series which will
be submitted later. Other mostly minor fixes from code review
v6: Identical to v5, only update "Test-with:" since CI did not pick up
previous "Test-with:" probably because it was old
v7: Rebase remaining patches after patches 1, 3 and 5 have been merged
Ashutosh Dixit (3):
drm/i915/gt: Add media freq factor to per-gt sysfs drm/i915/pcode: Init pcode on different gt's drm/i915/gt: Fix memory leaks in per-gt sysfs
Dale B Stimson (1):
drm/i915/gt: Add media RP0/RPn to per-gt sysfs
drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 29 ++- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 177 ++++++++++++++++++ drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 + .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 20 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + drivers/gpu/drm/i915/i915_driver.c | 20 +- drivers/gpu/drm/i915/i915_reg.h | 8 + drivers/gpu/drm/i915/i915_sysfs.c | 2 + 13 files changed, 253 insertions(+), 24 deletions(-)
Signature · 1 line
2.34.1
PATCH 1/4 drm/i915/gt: Add media freq factor to per-gt sysfs
Expose new sysfs to program and retrieve media freq factor. Factor values of 0 (dynamic), 0.5 and 1.0 are supported via a u8.8 fixed point representation (corresponding to integer values of 0, 128 and 256 respectively).
Media freq factor is converted to media_ratio_mode for GuC. It is programmed into GuC using H2G SLPC interface. It is retrieved from GuC through a register read. A cached media_ratio_mode is maintained to preserve set values across GuC resets.
This patch adds the following sysfs files to gt/gtN sysfs:
* media_freq_factor
* media_freq_factor.scale
v2: Minor wording change in drm_warn (Tvrtko)
--- drivers/gpu/drm/i915/gt/intel_gt_regs.h | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 130 ++++++++++++++++++ .../drm/i915/gt/uc/abi/guc_actions_slpc_abi.h | 6 + drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 20 +++ drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h | 1 + .../gpu/drm/i915/gt/uc/intel_guc_slpc_types.h | 3 + 6 files changed, 161 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_regs.h +1 -0
@@ -740,6 +740,7 @@#define GEN6_AGGRESSIVE_TURBO (0 << 15)#define GEN9_SW_REQ_UNSLICE_RATIO_SHIFT 23#define GEN9_IGNORE_SLICE_RATIO (0 << 0) +#define GEN12_MEDIA_FREQ_RATIO REG_BIT(13)#define GEN6_RC_VIDEO_FREQ _MMIO(0xa00c)#define GEN6_RC_CTL_RC6pp_ENABLE (1 << 16)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +130 -0
140 lines not on this page · raw message
drivers/gpu/drm/i915/gt/uc/abi/guc_actions_slpc_abi.h +6 -0
@@ -122,6 +122,12 @@ enum slpc_param_id { SLPC_MAX_PARAM = 32, }; +enum slpc_media_ratio_mode { +SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL =0 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_ONE =1 , +SLPC_MEDIA_RATIO_MODE_FIXED_ONE_TO_TWO =2 , +}; +enum slpc_event_id {SLPC_EVENT_RESET =0 ,SLPC_EVENT_SHUTDOWN =1 ,
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c +20 -0
@@ -260,6 +260,7 @@ int intel_guc_slpc_init(struct intel_guc_slpc *slpc) slpc->boost_freq =0 ;atomic_set (&slpc->num_waiters,0 ); slpc->num_boosts =0 ; + slpc->media_ratio_mode =SLPC_MEDIA_RATIO_MODE_DYNAMIC_CONTROL ;mutex_init (&slpc->lock);INIT_WORK (&slpc->boost_work, slpc_boost_work);
@@ -506,6 +507,22 @@ int intel_guc_slpc_get_min_freq(struct intel_guc_slpc *slpc, u32 *val)return ret; } +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val) +{ +struct drm_i915_private *i915 =slpc_to_i915 (slpc); +intel_wakeref_t wakeref; +int ret =0 ; + +if (!HAS_MEDIA_RATIO_MODE (i915)) +return -ENODEV ; + +with_intel_runtime_pm (&i915->runtime_pm, wakeref) + ret = slpc_set_param(slpc, +SLPC_PARAM_MEDIA_FF_RATIO_MODE , + val); +return ret; +} +void intel_guc_pm_intrmsk_enable (struct intel_gt *gt) {u32 pm_intrmsk_mbz =0 ;
@@ -654,6 +671,9 @@ int intel_guc_slpc_enable(struct intel_guc_slpc *slpc)return ret; } +/* Set cached media freq ratio mode */ +intel_guc_slpc_set_media_ratio_mode (slpc, slpc->media_ratio_mode); +return 0 ; }
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.h +1 -0
@@ -38,6 +38,7 @@ int intel_guc_slpc_set_boost_freq(struct intel_guc_slpc *slpc, u32 val);int intel_guc_slpc_get_max_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_get_min_freq (struct intel_guc_slpc *slpc,u32 *val);int intel_guc_slpc_print_info (struct intel_guc_slpc *slpc,struct drm_printer *p); +int intel_guc_slpc_set_media_ratio_mode (struct intel_guc_slpc *slpc,u32 val);void intel_guc_pm_intrmsk_enable (struct intel_gt *gt);void intel_guc_slpc_boost (struct intel_guc_slpc *slpc);void intel_guc_slpc_dec_waiters (struct intel_guc_slpc *slpc);
drivers/gpu/drm/i915/gt/uc/intel_guc_slpc_types.h +3 -0
@@ -29,6 +29,9 @@ struct intel_guc_slpc {u32 min_freq_softlimit;u32 max_freq_softlimit; +/* cached media ratio mode */ +u32 media_ratio_mode; +/* Protects set/reset of boost freq * and value of num_waiters */
Signature · 1 line
2.34.1
PATCH 2/4 drm/i915/pcode: Init pcode on different gt's
In reply to Ashutosh DixitExtend pcode initialization to pcode on different gt's.
--- drivers/gpu/drm/i915/i915_driver.c | 20 ++++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-)
drivers/gpu/drm/i915/i915_driver.c +18 -2
@@ -520,6 +520,22 @@ static int i915_set_dma_info(struct drm_i915_private *i915)return ret; } +static int i915_pcode_init (struct drm_i915_private *i915) +{ +struct intel_gt *gt; +int id, ret; + +for_each_gt (gt, i915, id) { + ret =intel_pcode_init (gt->uncore); +if (ret) { +drm_err (>->i915->drm,"gt%d: intel_pcode_init failed %d\n" , id, ret); +return ret; + } + } + +return 0 ; +} +/** * i915_driver_hw_probe - setup state requiring device access * @dev_priv: device private
@@ -629,7 +645,7 @@ static int i915_driver_hw_probe(struct drm_i915_private *dev_priv)intel_opregion_setup (dev_priv); - ret =intel_pcode_init (&dev_priv->uncore); + ret =i915_pcode_init (dev_priv);if (ret) goto err_msi;
@@ -1251,7 +1267,7 @@ static int i915_drm_resume(struct drm_device *dev)disable_rpm_wakeref_asserts (&dev_priv->runtime_pm); - ret =intel_pcode_init (&dev_priv->uncore); + ret =i915_pcode_init (dev_priv);if (ret)return ret;
Signature · 1 line
2.34.1
PATCH 3/4 drm/i915/gt: Add media RP0/RPn to per-gt sysfs
In reply to Ashutosh DixitFrom: Dale B Stimson <[email protected]>
Retrieve RP0 and RPn freq for media IP from PCODE and display in per-gt sysfs. This patch adds the following files to gt/gtN sysfs:
* media_RP0_freq_mhz
* media_RPn_freq_mhz
v2: Fixed commit author (Rodrigo)
v3: Convert to new uncore interface for pcode functions
v4: Adapt to intel_pcode.* function rename
v5: #include "intel_pcode.h" in alphabetical order (Tvrtko)
--- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 47 +++++++++++++++++++++ drivers/gpu/drm/i915/i915_reg.h | 8 ++++ 2 files changed, 55 insertions(+)
drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c +47 -0
@@ -14,6 +14,7 @@#include "intel_gt_regs.h" #include "intel_gt_sysfs.h" #include "intel_gt_sysfs_pm.h" +#include "intel_pcode.h" #include "intel_rc6.h" #include "intel_rps.h"
@@ -670,13 +671,59 @@ static ssize_t media_freq_factor_store(struct device *dev,return err ?: count; } +static ssize_t media_RP0_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =snb_pcode_read_p (gt->uncore,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_P0 , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* Fused media RP0 read from pcode is in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} + +static ssize_t media_RPn_freq_mhz_show (struct device *dev, +struct device_attribute *attr, +char *buff) +{ +struct intel_gt *gt =intel_gt_sysfs_get_drvdata (dev, attr->attr.name); +u32 val; +int err; + + err =snb_pcode_read_p (gt->uncore,XEHPSDV_PCODE_FREQUENCY_CONFIG , +PCODE_MBOX_FC_SC_READ_FUSED_PN , +PCODE_MBOX_DOMAIN_MEDIAFF , &val); + +if (err) +return err; + +/* Fused media RPn read from pcode is in units of 50 MHz */ + val *=GT_FREQUENCY_MULTIPLIER ; + +return sysfs_emit (buff,"%u\n" , val); +} +static DEVICE_ATTR_RW (media_freq_factor);static struct device_attribute dev_attr_media_freq_factor_scale =__ATTR (media_freq_factor.scale,0444 , freq_factor_scale_show,NULL ); +static DEVICE_ATTR_RO (media_RP0_freq_mhz); +static DEVICE_ATTR_RO (media_RPn_freq_mhz);static const struct attribute *media_perf_power_attrs[] = { &dev_attr_media_freq_factor.attr, &dev_attr_media_freq_factor_scale.attr, + &dev_attr_media_RP0_freq_mhz.attr, + &dev_attr_media_RPn_freq_mhz.attr,NULL };
drivers/gpu/drm/i915/i915_reg.h +8 -0
@@ -6804,6 +6804,14 @@#define DG1_UNCORE_GET_INIT_STATUS 0x0#define DG1_UNCORE_INIT_STATUS_COMPLETE 0x1#define GEN12_PCODE_READ_SAGV_BLOCK_TIME_US 0x23 +#define XEHPSDV_PCODE_FREQUENCY_CONFIG 0x6e/* xehpsdv, pvc */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG sub-commands (param1) */ +#define PCODE_MBOX_FC_SC_READ_FUSED_P0 0x0 +#define PCODE_MBOX_FC_SC_READ_FUSED_PN 0x1 +/* PCODE_MBOX_DOMAIN_* - mailbox domain IDs */ +/* XEHPSDV_PCODE_FREQUENCY_CONFIG param2 */ +#define PCODE_MBOX_DOMAIN_NONE 0x0 +#define PCODE_MBOX_DOMAIN_MEDIAFF 0x3#define GEN6_PCODE_DATA _MMIO(0x138128)#define GEN6_PCODE_FREQ_IA_RATIO_SHIFT 8#define GEN6_PCODE_FREQ_RING_RATIO_SHIFT 16
Signature · 1 line
2.34.1
PATCH 4/4 drm/i915/gt: Fix memory leaks in per-gt sysfs
In reply to Ashutosh DixitAll kmalloc'd kobjects need a kobject_put() to free memory. For example in previous code, kobj_gt_release() never gets called. The requirement of kobject_put() now results in a slightly different code organization.
v2: s/gtn/gt/ (Andi)
--- drivers/gpu/drm/i915/gt/intel_gt.c | 1 + drivers/gpu/drm/i915/gt/intel_gt_sysfs.c | 29 ++++++++++-------------- drivers/gpu/drm/i915/gt/intel_gt_sysfs.h | 6 +---- drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 +++ drivers/gpu/drm/i915/i915_sysfs.c | 2 ++ 5 files changed, 19 insertions(+), 22 deletions(-)
drivers/gpu/drm/i915/gt/intel_gt.c +1 -0
@@ -790,6 +790,7 @@ void intel_gt_driver_unregister(struct intel_gt *gt) {intel_wakeref_t wakeref; +intel_gt_sysfs_unregister (gt);intel_rps_driver_unregister (>->rps);intel_gsc_fini (>->gsc);
drivers/gpu/drm/i915/gt/intel_gt_sysfs.c +12 -17
@@ -24,7 +24,7 @@ bool is_object_gt(struct kobject *kobj)static struct intel_gt *kobj_to_gt (struct kobject *kobj) { - return container_of(kobj, struct kobj_gt, base)->gt; + return container_of(kobj, struct intel_gt, sysfs_gt); } struct intel_gt *intel_gt_sysfs_get_drvdata(struct device *dev,
@@ -72,9 +72,9 @@ static struct attribute *id_attrs[] = { };ATTRIBUTE_GROUPS (id); +/* A kobject needs a release() method even if it does nothing */ static void kobj_gt_release (struct kobject *kobj) { -kfree (kobj); }static struct kobj_type kobj_gt_type = {
@@ -85,8 +85,6 @@ static struct kobj_type kobj_gt_type = {void intel_gt_sysfs_register (struct intel_gt *gt) { -struct kobj_gt *kg; -/* * We need to make things right with the * ABI compatibility. The files were originally
@@ -98,25 +96,22 @@ void intel_gt_sysfs_register(struct intel_gt *gt)if (gt_is_root (gt))intel_gt_sysfs_pm_init (gt,gt_get_parent_obj (gt)); - kg =kzalloc (sizeof (*kg),GFP_KERNEL ); -if (!kg) +/* init and xfer ownership to sysfs tree */ +if (kobject_init_and_add (>->sysfs_gt, &kobj_gt_type, + gt->i915->sysfs_gt,"gt%d" , gt->info.id)) goto exit_fail; -kobject_init (&kg->base, &kobj_gt_type); - kg->gt = gt; - -/* xfer ownership to sysfs tree */ -if (kobject_add (&kg->base, gt->i915->sysfs_gt,"gt%d" , gt->info.id)) - goto exit_kobj_put; - -intel_gt_sysfs_pm_init (gt, &kg->base); +intel_gt_sysfs_pm_init (gt, >->sysfs_gt);return ; -exit_kobj_put: -kobject_put (&kg->base); - exit_fail: +kobject_put (>->sysfs_gt);drm_warn (>->i915->drm,"failed to initialize gt%d sysfs root\n" , gt->info.id); } + +void intel_gt_sysfs_unregister (struct intel_gt *gt) +{ +kobject_put (>->sysfs_gt); +}
drivers/gpu/drm/i915/gt/intel_gt_sysfs.h +1 -5
@@ -13,11 +13,6 @@struct intel_gt ; -struct kobj_gt { -struct kobject base; -struct intel_gt *gt; -}; -bool is_object_gt (struct kobject *kobj);struct drm_i915_private *kobj_to_i915 (struct kobject *kobj);
@@ -28,6 +23,7 @@ intel_gt_create_kobj(struct intel_gt *gt, const char *name);void intel_gt_sysfs_register (struct intel_gt *gt); +void intel_gt_sysfs_unregister (struct intel_gt *gt);struct intel_gt *intel_gt_sysfs_get_drvdata (struct device *dev,const char *name);
drivers/gpu/drm/i915/gt/intel_gt_types.h +3 -0
@@ -225,6 +225,9 @@ struct intel_gt { } mocs;struct intel_pxp pxp; + +/* gt/gtN sysfs */ +struct kobject sysfs_gt; };enum intel_gt_scratch_field {
drivers/gpu/drm/i915/i915_sysfs.c +2 -0
@@ -259,4 +259,6 @@ void i915_teardown_sysfs(struct drm_i915_private *dev_priv)device_remove_bin_file (kdev, &dpf_attrs_1);device_remove_bin_file (kdev, &dpf_attrs); + +kobject_put (dev_priv->sysfs_gt); }
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev7)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev7)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim checkpatch failed9e468bd7db66 drm/i915/gt: Add media freq factor to per-gt sysfs 10b8fc18842f drm/i915/pcode: Init pcode on different gt's e0f712fb7eab drm/i915/gt: Add media RP0/RPn to per-gt sysfs -:83: CHECK:CAMELCASE: Avoid CamelCase: <media_RPn_freq_mhz> #83: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:720:
+static DEVICE_ATTR_RO(media_RPn_freq_mhz);
-:89: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_media_RPn_freq_mhz> #89: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:726:
+ &dev_attr_media_RPn_freq_mhz.attr,
total: 0 errors, 0 warnings, 2 checks, 80 lines checked fc74c8104e52 drm/i915/gt: Fix memory leaks in per-gt sysfs
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev8)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev8)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Media freq factor and per-gt enhancements/fixes (rev8)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev8)
URL : https://patchwork.freedesktop.org/series/102665/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11694 -> Patchwork_102665v8
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_102665v8 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_102665v8, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/index.html
Participating hosts (46 -> 9)
------------------------------
ERROR: It appears as if the changes made in Patchwork_102665v8 prevented too many machines from booting.
Additional (2): bat-jsl-2 bat-atsm-1
Missing (39): fi-kbl-soraka fi-rkl-11600 fi-rkl-guc fi-bdw-gvtdvm fi-icl-u2 fi-snb-2520m fi-apl-guc fi-pnv-d510 fi-blb-e6850 fi-skl-6600u fi-snb-2600 fi-bxt-dsi fi-bdw-5557u fi-bsw-n3050 fi-adl-ddr5 bat-dg2-8 fi-tgl-u2 bat-adlm-1 fi-bwr-2160 fi-glk-dsi fi-hsw-g3258 fi-ilk-650 fi-ivb-3770 fi-elk-e7500 fi-bsw-nick fi-skl-6700k2 fi-kbl-7567u fi-tgl-dsi fi-skl-guc fi-cfl-8700k fi-glk-j4005 fi-ehl-2 fi-jsl-1 fi-tgl-1115g4 fi-cfl-guc fi-kbl-guc fi-cfl-8109u fi-kbl-8809g fi-bsw-kefka
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_102665v8:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_lmem_swapping@verify-random@lmem0:
- {bat-atsm-1}: NOTRUN -> [INCOMPLETE][1] +4 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-atsm-1/igt@gem_lmem_swapping@[email protected]
* igt@kms_addfb_basic@bad-pitch-256:
- {bat-atsm-1}: NOTRUN -> [SKIP][2] +95 similar issues
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-atsm-1/igt@[email protected]
* igt@kms_flip@basic-flip-vs-modeset:
- {bat-atsm-1}: NOTRUN -> [FAIL][3] +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-atsm-1/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_102665v8 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@basic-rte:
- bat-dg1-5: [PASS][4] -> [SKIP][5] ([i915#4078]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11694/bat-dg1-5/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-dg1-5/igt@[email protected]
* igt@i915_pm_rpm@module-reload:
- bat-adlp-4: [PASS][6] -> [DMESG-WARN][7] ([i915#3576])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11694/bat-adlp-4/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-adlp-4/igt@[email protected]
* igt@kms_chamelium@common-hpd-after-suspend:
- bat-dg1-6: NOTRUN -> [SKIP][8] ([fdo#111827])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-dg1-6/igt@[email protected]
- bat-dg1-5: NOTRUN -> [SKIP][9] ([fdo#111827])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-dg1-5/igt@[email protected]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- bat-dg1-5: NOTRUN -> [SKIP][10] ([i915#4078])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-dg1-5/igt@[email protected]
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [DMESG-FAIL][11] ([i915#4494] / [i915#4957]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11694/bat-dg1-6/igt@i915_selftest@[email protected]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-dg1-6/igt@i915_selftest@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@a-edp1:
- bat-adlp-4: [DMESG-WARN][13] ([i915#3576]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11694/bat-adlp-4/igt@kms_flip@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-adlp-4/igt@kms_flip@[email protected]
* igt@kms_flip@basic-flip-vs-modeset@b-edp1:
- {bat-adlp-6}: [DMESG-WARN][15] ([i915#3576]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11694/bat-adlp-6/igt@kms_flip@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/bat-adlp-6/igt@kms_flip@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5869]: https://gitlab.freedesktop.org/drm/intel/issues/5869
Build changes
-------------
* IGT: IGT_6486 -> IGTPW_7094
* Linux: CI_DRM_11694 -> Patchwork_102665v8
CI-20190529: 20190529
CI_DRM_11694: ba77f2196526253b70968472d78ced6dd09bdd4d @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_7094: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_7094/index.html
IGT_6486: f91af0ee70ed290890d122ece6b3857222f985b0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_102665v8: ba77f2196526253b70968472d78ced6dd09bdd4d @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
05b447f95bfd drm/i915/gt: Fix memory leaks in per-gt sysfs dd824f1ef4f5 drm/i915/gt: Add media RP0/RPn to per-gt sysfs fee2f04ccc51 drm/i915/pcode: Init pcode on different gt's 6906cdd4a92a drm/i915/gt: Add media freq factor to per-gt sysfs
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_102665v8/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev9)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev9)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim checkpatch failed63e0ab0ed664 drm/i915/gt: Add media freq factor to per-gt sysfs 2e706c2fdf7e drm/i915/pcode: Init pcode on different gt's 7fd38d4f289e drm/i915/gt: Add media RP0/RPn to per-gt sysfs -:83: CHECK:CAMELCASE: Avoid CamelCase: <media_RPn_freq_mhz> #83: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:720:
+static DEVICE_ATTR_RO(media_RPn_freq_mhz);
-:89: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_media_RPn_freq_mhz> #89: FILE: drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c:726:
+ &dev_attr_media_RPn_freq_mhz.attr,
total: 0 errors, 0 warnings, 2 checks, 80 lines checked e18539ed7c20 drm/i915/gt: Fix memory leaks in per-gt sysfs
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Media freq factor and per-gt enhancements/fixes (rev9)
In reply to Ashutosh Dixit== Series Details ==
== Series Details ==
Series: drm/i915: Media freq factor and per-gt enhancements/fixes (rev9)
URL : https://patchwork.freedesktop.org/series/102665/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.