drm/i915/gmbus: stop using implicit dev_priv
Subsystems (4)
cover drm/i915/gmbus: stop using implicit dev_priv
The register macros are the last holdout for implicit dev_priv local variable. Try out what it would mean to stop using it, and require passing i915 as parameter to the register macros. Use gmbus as a nicely isolated playing ground.
Jani Nikula (6):
drm/i915/gmbus: split out gmbus regs in a separate file drm/i915/gmbus: whitespace cleanup in reg definitions drm/i915/gmbus: add wrapper for gmbus mmio base drm/i915/gmbus: stop using implicit dev_priv in register definitions drm/i915/reg: stop using implicit dev_priv in DSPCLK_GATE_D drm/i915/gmbus: mass dev_priv -> i915 rename
.../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 275 +++++++++--------- .../gpu/drm/i915/display/intel_gmbus_regs.h | 81 ++++++ drivers/gpu/drm/i915/display/intel_overlay.c | 4 +- drivers/gpu/drm/i915/display/vlv_dsi.c | 8 +- drivers/gpu/drm/i915/gvt/edid.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 65 +---- drivers/gpu/drm/i915/intel_pm.c | 4 +- 8 files changed, 232 insertions(+), 212 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_gmbus_regs.h
Signature · 1 line
2.34.1
PATCH 1/6 drm/i915/gmbus: split out gmbus regs in a separate file
Declutter i915_reg.h, and also observe very few places need the gmbus register defitions.
--- drivers/gpu/drm/i915/display/intel_gmbus.c | 1 + .../gpu/drm/i915/display/intel_gmbus_regs.h | 71 +++++++++++++++++++ drivers/gpu/drm/i915/gvt/edid.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 63 ---------------- 4 files changed, 74 insertions(+), 64 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_gmbus_regs.h
drivers/gpu/drm/i915/display/intel_gmbus.c +1 -0
@@ -37,6 +37,7 @@#include "intel_de.h" #include "intel_display_types.h" #include "intel_gmbus.h" +#include "intel_gmbus_regs.h" struct intel_gmbus {struct i2c_adapter adapter;
drivers/gpu/drm/i915/display/intel_gmbus_regs.h new file +71 -0
71 lines not on this page · raw message
drivers/gpu/drm/i915/gvt/edid.c +2 -1
@@ -32,9 +32,10 @@* */ +#include "display/intel_gmbus_regs.h" +#include "gvt.h" #include "i915_drv.h" #include "i915_reg.h" -#include "gvt.h" #define GMBUS1_TOTAL_BYTES_SHIFT 16#define GMBUS1_TOTAL_BYTES_MASK 0x1ff
drivers/gpu/drm/i915/i915_reg.h +0 -63
69 lines not on this page · raw message
Signature · 1 line
2.34.1
PATCH 4/6 drm/i915/gmbus: stop using implicit dev_priv in register definitions
In reply to Jani NikulaSince the beginning of time, we've implicitly assumed dev_priv is present as a local variable in many places. We've gone a long way in removing many of them, but the register macro definitions are the last holdout. Remove them from the gmbus macros.
--- drivers/gpu/drm/i915/display/intel_gmbus.c | 54 +++++++++---------- .../gpu/drm/i915/display/intel_gmbus_regs.h | 14 ++--- 2 files changed, 34 insertions(+), 34 deletions(-)
drivers/gpu/drm/i915/display/intel_gmbus.c +27 -27
@@ -171,10 +171,10 @@ to_intel_gmbus(struct i2c_adapter *i2c) }void -intel_gmbus_reset (struct drm_i915_private *dev_priv) +intel_gmbus_reset (struct drm_i915_private *i915) { -intel_de_write (dev_priv,GMBUS0 ,0 ); -intel_de_write (dev_priv,GMBUS4 ,0 ); +intel_de_write (i915,GMBUS0 (i915),0 ); +intel_de_write (i915,GMBUS4 (i915),0 ); } static void pnv_gmbus_clock_gating(struct drm_i915_private *dev_priv,
@@ -371,16 +371,16 @@ static int gmbus_wait(struct drm_i915_private *dev_priv, u32 status, u32 irq_en) irq_en =0 ;add_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait); -intel_de_write_fw (dev_priv,GMBUS4 , irq_en); +intel_de_write_fw (dev_priv,GMBUS4 (dev_priv), irq_en); status |=GMBUS_SATOER ; - ret =wait_for_us ((gmbus2 =intel_de_read_fw (dev_priv,GMBUS2 )) & status, + ret =wait_for_us ((gmbus2 =intel_de_read_fw (dev_priv,GMBUS2 (dev_priv))) & status,2 );if (ret) - ret =wait_for ((gmbus2 =intel_de_read_fw (dev_priv,GMBUS2 )) & status, + ret =wait_for ((gmbus2 =intel_de_read_fw (dev_priv,GMBUS2 (dev_priv))) & status,50 ); -intel_de_write_fw (dev_priv,GMBUS4 ,0 ); +intel_de_write_fw (dev_priv,GMBUS4 (dev_priv),0 );remove_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait);if (gmbus2 &GMBUS_SATOER )
@@ -402,13 +402,13 @@ gmbus_wait_idle(struct drm_i915_private *dev_priv) irq_enable =GMBUS_IDLE_EN ;add_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait); -intel_de_write_fw (dev_priv,GMBUS4 , irq_enable); +intel_de_write_fw (dev_priv,GMBUS4 (dev_priv), irq_enable); ret =intel_wait_for_register_fw (&dev_priv->uncore, -GMBUS2 ,GMBUS_ACTIVE ,0 , +GMBUS2 (dev_priv),GMBUS_ACTIVE ,0 ,10 ); -intel_de_write_fw (dev_priv,GMBUS4 ,0 ); +intel_de_write_fw (dev_priv,GMBUS4 (dev_priv),0 );remove_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait);return ret;
@@ -439,11 +439,11 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv, len++; } size = len %256 +256 ; -intel_de_write_fw (dev_priv,GMBUS0 , +intel_de_write_fw (dev_priv,GMBUS0 (dev_priv), gmbus0_reg |GMBUS_BYTE_CNT_OVERRIDE ); } -intel_de_write_fw (dev_priv,GMBUS1 , +intel_de_write_fw (dev_priv,GMBUS1 (dev_priv), gmbus1_index |GMBUS_CYCLE_WAIT | (size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_READ |GMBUS_SW_RDY );while (len) {int ret;
@@ -453,7 +453,7 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv,if (ret)return ret; - val =intel_de_read_fw (dev_priv,GMBUS3 ); + val =intel_de_read_fw (dev_priv,GMBUS3 (dev_priv)); do { if (extra_byte_added && len == 1) break;
@@ -464,7 +464,7 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv,if (burst_read && len == size -4 )/* Reset the override bit */ -intel_de_write_fw (dev_priv,GMBUS0 , gmbus0_reg); +intel_de_write_fw (dev_priv,GMBUS0 (dev_priv), gmbus0_reg); }return 0 ;
@@ -521,8 +521,8 @@ gmbus_xfer_write_chunk(struct drm_i915_private *dev_priv, len -=1 ; } -intel_de_write_fw (dev_priv,GMBUS3 , val); -intel_de_write_fw (dev_priv,GMBUS1 , +intel_de_write_fw (dev_priv,GMBUS3 (dev_priv), val); +intel_de_write_fw (dev_priv,GMBUS1 (dev_priv), gmbus1_index |GMBUS_CYCLE_WAIT | (chunk_size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_WRITE |GMBUS_SW_RDY );while (len) {int ret;
@@ -532,7 +532,7 @@ gmbus_xfer_write_chunk(struct drm_i915_private *dev_priv, val |= *buf++ << (8 * loop); }while (--len && ++loop <4 ); -intel_de_write_fw (dev_priv,GMBUS3 , val); +intel_de_write_fw (dev_priv,GMBUS3 (dev_priv), val); ret =gmbus_wait (dev_priv,GMBUS_HW_RDY ,GMBUS_HW_RDY_EN );if (ret)
@@ -597,7 +597,7 @@ gmbus_index_xfer(struct drm_i915_private *dev_priv, struct i2c_msg *msgs,/* GMBUS5 holds 16-bit index */ if (gmbus5) -intel_de_write_fw (dev_priv,GMBUS5 , gmbus5); +intel_de_write_fw (dev_priv,GMBUS5 (dev_priv), gmbus5);if (msgs[1 ].flags &I2C_M_RD ) ret = gmbus_xfer_read(dev_priv, &msgs[1], gmbus0_reg,
@@ -607,7 +607,7 @@ gmbus_index_xfer(struct drm_i915_private *dev_priv, struct i2c_msg *msgs,/* Clear GMBUS5 after each index transfer */ if (gmbus5) -intel_de_write_fw (dev_priv,GMBUS5 ,0 ); +intel_de_write_fw (dev_priv,GMBUS5 (dev_priv),0 );return ret; }
@@ -628,7 +628,7 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,pch_gmbus_clock_gating (dev_priv, false); retry: -intel_de_write_fw (dev_priv,GMBUS0 , gmbus0_source | bus->reg0); +intel_de_write_fw (dev_priv,GMBUS0 (dev_priv), gmbus0_source | bus->reg0);for (; i < num; i += inc) { inc =1 ;
@@ -656,7 +656,7 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,* a STOP on the very first cycle. To simplify the code we * unconditionally generate the STOP condition with an additional gmbus * cycle. */ -intel_de_write_fw (dev_priv,GMBUS1 ,GMBUS_CYCLE_STOP |GMBUS_SW_RDY ); +intel_de_write_fw (dev_priv,GMBUS1 (dev_priv),GMBUS_CYCLE_STOP |GMBUS_SW_RDY );/* Mark the GMBUS interface as disabled after waiting for idle. * We will re-enable it at the start of the next xfer,
@@ -668,7 +668,7 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num, adapter->name); ret = -ETIMEDOUT ; } -intel_de_write_fw (dev_priv,GMBUS0 ,0 ); +intel_de_write_fw (dev_priv,GMBUS0 (dev_priv),0 ); ret = ret ?: i; goto out;
@@ -698,9 +698,9 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,* of resetting the GMBUS controller and so clearing the * BUS_ERROR raised by the slave's NAK. */ -intel_de_write_fw (dev_priv,GMBUS1 ,GMBUS_SW_CLR_INT ); -intel_de_write_fw (dev_priv,GMBUS1 ,0 ); -intel_de_write_fw (dev_priv,GMBUS0 ,0 ); +intel_de_write_fw (dev_priv,GMBUS1 (dev_priv),GMBUS_SW_CLR_INT ); +intel_de_write_fw (dev_priv,GMBUS1 (dev_priv),0 ); +intel_de_write_fw (dev_priv,GMBUS0 (dev_priv),0 ); drm_dbg_kms(&dev_priv->drm, "GMBUS [%s] NAK for addr: %04x %c(%d)\n", adapter->name, msgs[i].addr,
@@ -725,7 +725,7 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,drm_dbg_kms (&dev_priv->drm,"GMBUS [%s] timed out, falling back to bit banging on pin %d\n" , bus->adapter.name, bus->reg0 &0xff ); -intel_de_write_fw (dev_priv,GMBUS0 ,0 ); +intel_de_write_fw (dev_priv,GMBUS0 (dev_priv),0 );/* * Hardware may not support GMBUS over these pins? Try GPIO bitbanging
@@ -915,7 +915,7 @@ int intel_gmbus_setup(struct drm_i915_private *dev_priv)if (IS_I830 (dev_priv)) bus->force_bit =1 ; -intel_gpio_setup (bus,GPIO (gmbus_pin->gpio)); +intel_gpio_setup (bus,GPIO (dev_priv, gmbus_pin->gpio)); ret =i2c_add_adapter (&bus->adapter);if (ret) {
drivers/gpu/drm/i915/display/intel_gmbus_regs.h +7 -7
@@ -10,7 +10,7 @@#define GMBUS_MMIO_BASE (__i915) ((__i915)->display.gmbus.mmio_base) -#define GPIO (gpio) _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5010 + 4 * (gpio)) +#define GPIO (__i915, gpio) _MMIO(GMBUS_MMIO_BASE(__i915) + 0x5010 + 4 * (gpio))#define GPIO_CLOCK_DIR_MASK (1 << 0)#define GPIO_CLOCK_DIR_IN (0 << 1)#define GPIO_CLOCK_DIR_OUT (1 << 1)
@@ -27,7 +27,7 @@#define GPIO_DATA_PULLUP_DISABLE (1 << 13)/* clock/port select */ -#define GMBUS0 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5100) +#define GMBUS0 (__i915) _MMIO(GMBUS_MMIO_BASE(__i915) + 0x5100)#define GMBUS_AKSV_SELECT (1 << 11)#define GMBUS_RATE_100KHZ (0 << 8)#define GMBUS_RATE_50KHZ (1 << 8)
@@ -37,7 +37,7 @@#define GMBUS_BYTE_CNT_OVERRIDE (1 << 6)/* command/status */ -#define GMBUS1 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5104) +#define GMBUS1 (__i915) _MMIO(GMBUS_MMIO_BASE(__i915) + 0x5104)#define GMBUS_SW_CLR_INT (1 << 31)#define GMBUS_SW_RDY (1 << 30)#define GMBUS_ENT (1 << 29)/* enable timeout */
@@ -54,7 +54,7 @@#define GMBUS_SLAVE_WRITE (0 << 0)/* status */ -#define GMBUS2 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5108) +#define GMBUS2 (__i915) _MMIO(GMBUS_MMIO_BASE(__i915) + 0x5108)#define GMBUS_INUSE (1 << 15)#define GMBUS_HW_WAIT_PHASE (1 << 14)#define GMBUS_STALL_TIMEOUT (1 << 13)
@@ -64,10 +64,10 @@#define GMBUS_ACTIVE (1 << 9)/* data buffer bytes 3-0 */ -#define GMBUS3 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x510c) +#define GMBUS3 (__i915) _MMIO(GMBUS_MMIO_BASE(__i915) + 0x510c)/* interrupt mask (Pineview+) */ -#define GMBUS4 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5110) +#define GMBUS4 (__i915) _MMIO(GMBUS_MMIO_BASE(__i915) + 0x5110)#define GMBUS_SLAVE_TIMEOUT_EN (1 << 4)#define GMBUS_NAK_EN (1 << 3)#define GMBUS_IDLE_EN (1 << 2)
@@ -75,7 +75,7 @@#define GMBUS_HW_RDY_EN (1 << 0)/* byte index */ -#define GMBUS5 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5120) +#define GMBUS5 (__i915) _MMIO(GMBUS_MMIO_BASE(__i915) + 0x5120)#define GMBUS_2BYTE_INDEX_EN (1 << 31)#endif /* __INTEL_GMBUS_REGS_H__ */
Signature · 1 line
2.34.1
PATCH 3/6 drm/i915/gmbus: add wrapper for gmbus mmio base
In reply to Jani NikulaDon't repeat the same thing so much.
--- drivers/gpu/drm/i915/display/intel_gmbus_regs.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/gpu/drm/i915/display/intel_gmbus_regs.h +9 -8
@@ -8,8 +8,9 @@#include "i915_reg_defs.h" -#define GPIO (gpio) _MMIO(dev_priv->display.gmbus.mmio_base + 0x5010 + \ - 4 * (gpio)) +#define GMBUS_MMIO_BASE (__i915) ((__i915)->display.gmbus.mmio_base) + +#define GPIO (gpio) _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5010 + 4 * (gpio))#define GPIO_CLOCK_DIR_MASK (1 << 0)#define GPIO_CLOCK_DIR_IN (0 << 1)#define GPIO_CLOCK_DIR_OUT (1 << 1)
@@ -26,7 +27,7 @@#define GPIO_DATA_PULLUP_DISABLE (1 << 13)/* clock/port select */ -#define GMBUS0 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5100) +#define GMBUS0 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5100)#define GMBUS_AKSV_SELECT (1 << 11)#define GMBUS_RATE_100KHZ (0 << 8)#define GMBUS_RATE_50KHZ (1 << 8)
@@ -36,7 +37,7 @@#define GMBUS_BYTE_CNT_OVERRIDE (1 << 6)/* command/status */ -#define GMBUS1 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5104) +#define GMBUS1 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5104)#define GMBUS_SW_CLR_INT (1 << 31)#define GMBUS_SW_RDY (1 << 30)#define GMBUS_ENT (1 << 29)/* enable timeout */
@@ -53,7 +54,7 @@#define GMBUS_SLAVE_WRITE (0 << 0)/* status */ -#define GMBUS2 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5108) +#define GMBUS2 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5108)#define GMBUS_INUSE (1 << 15)#define GMBUS_HW_WAIT_PHASE (1 << 14)#define GMBUS_STALL_TIMEOUT (1 << 13)
@@ -63,10 +64,10 @@#define GMBUS_ACTIVE (1 << 9)/* data buffer bytes 3-0 */ -#define GMBUS3 _MMIO(dev_priv->display.gmbus.mmio_base + 0x510c) +#define GMBUS3 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x510c)/* interrupt mask (Pineview+) */ -#define GMBUS4 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5110) +#define GMBUS4 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5110)#define GMBUS_SLAVE_TIMEOUT_EN (1 << 4)#define GMBUS_NAK_EN (1 << 3)#define GMBUS_IDLE_EN (1 << 2)
@@ -74,7 +75,7 @@#define GMBUS_HW_RDY_EN (1 << 0)/* byte index */ -#define GMBUS5 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5120) +#define GMBUS5 _MMIO(GMBUS_MMIO_BASE(dev_priv) + 0x5120)#define GMBUS_2BYTE_INDEX_EN (1 << 31)#endif /* __INTEL_GMBUS_REGS_H__ */
Signature · 1 line
2.34.1
PATCH 5/6 drm/i915/reg: stop using implicit dev_priv in DSPCLK_GATE_D
In reply to Jani NikulaRemove the implicit dev_priv usage in DSPCLK_GATE_D register, and pass it as parameter.
--- drivers/gpu/drm/i915/display/intel_display_power_well.c | 4 ++-- drivers/gpu/drm/i915/display/intel_gmbus.c | 4 ++-- drivers/gpu/drm/i915/display/intel_overlay.c | 4 ++-- drivers/gpu/drm/i915/display/vlv_dsi.c | 8 ++++---- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 6 files changed, 13 insertions(+), 13 deletions(-)
drivers/gpu/drm/i915/display/intel_display_power_well.c +2 -2
@@ -1157,10 +1157,10 @@ static void vlv_init_display_clock_gating(struct drm_i915_private *dev_priv)* (and never recovering) in this case. intel_dsi_post_disable() will * clear it when we turn off the display. */ - val =intel_de_read (dev_priv,DSPCLK_GATE_D ); + val =intel_de_read (dev_priv,DSPCLK_GATE_D (dev_priv)); val &=DPOUNIT_CLOCK_GATE_DISABLE ; val |=VRHUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,DSPCLK_GATE_D , val); +intel_de_write (dev_priv,DSPCLK_GATE_D (dev_priv), val);/* * Disable trickle feed and enable pnd deadline calculation
drivers/gpu/drm/i915/display/intel_gmbus.c +2 -2
@@ -183,12 +183,12 @@ static void pnv_gmbus_clock_gating(struct drm_i915_private *dev_priv,u32 val;/* When using bit bashing for I2C, this bit needs to be set to 1 */ - val =intel_de_read (dev_priv,DSPCLK_GATE_D ); + val =intel_de_read (dev_priv,DSPCLK_GATE_D (dev_priv));if (!enable) val |=PNV_GMBUSUNIT_CLOCK_GATE_DISABLE ;else val &= ~PNV_GMBUSUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,DSPCLK_GATE_D , val); +intel_de_write (dev_priv,DSPCLK_GATE_D (dev_priv), val); } static void pch_gmbus_clock_gating(struct drm_i915_private *dev_priv,
drivers/gpu/drm/i915/display/intel_overlay.c +2 -2
@@ -211,9 +211,9 @@ static void i830_overlay_clock_gating(struct drm_i915_private *dev_priv,/* WA_OVERLAY_CLKGATE:alm */ if (enable) -intel_de_write (dev_priv,DSPCLK_GATE_D ,0 ); +intel_de_write (dev_priv,DSPCLK_GATE_D (dev_priv),0 );else -intel_de_write (dev_priv,DSPCLK_GATE_D , +intel_de_write (dev_priv,DSPCLK_GATE_D (dev_priv),OVRUNIT_CLOCK_GATE_DISABLE );/* WA_DISABLE_L2CACHE_CLOCK_GATING:alm */
drivers/gpu/drm/i915/display/vlv_dsi.c +4 -4
@@ -822,9 +822,9 @@ static void intel_dsi_pre_enable(struct intel_atomic_state *state,u32 val;/* Disable DPOunit clock gating, can stall pipe */ - val =intel_de_read (dev_priv,DSPCLK_GATE_D ); + val =intel_de_read (dev_priv,DSPCLK_GATE_D (dev_priv)); val |=DPOUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,DSPCLK_GATE_D , val); +intel_de_write (dev_priv,DSPCLK_GATE_D (dev_priv), val); }if (!IS_GEMINILAKE (dev_priv))
@@ -998,9 +998,9 @@ static void intel_dsi_post_disable(struct intel_atomic_state *state,vlv_dsi_pll_disable (encoder); - val =intel_de_read (dev_priv,DSPCLK_GATE_D ); + val =intel_de_read (dev_priv,DSPCLK_GATE_D (dev_priv)); val &= ~DPOUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,DSPCLK_GATE_D , val); +intel_de_write (dev_priv,DSPCLK_GATE_D (dev_priv), val); }/* Assert reset */
drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -1637,7 +1637,7 @@#define DSTATE_PLL_D3_OFF (1 << 3)#define DSTATE_GFX_CLOCK_GATING (1 << 1)#define DSTATE_DOT_CLOCK_GATING (1 << 0) -#define DSPCLK_GATE_D _MMIO(DISPLAY_MMIO_BASE(dev_priv) + 0x6200) +#define DSPCLK_GATE_D (__i915) _MMIO(DISPLAY_MMIO_BASE(__i915) + 0x6200)# define DPUNIT_B_CLOCK_GATE_DISABLE (1 << 30)/* 965 */ # define VSUNIT_CLOCK_GATE_DISABLE (1 << 29)/* 965 */ # define VRHUNIT_CLOCK_GATE_DISABLE (1 << 28)/* 965 */
drivers/gpu/drm/i915/intel_pm.c +2 -2
@@ -7993,7 +7993,7 @@ static void g4x_init_clock_gating(struct drm_i915_private *dev_priv)OVCUNIT_CLOCK_GATE_DISABLE ;if (IS_GM45 (dev_priv)) dspclk_gate |=DSSUNIT_CLOCK_GATE_DISABLE ; -intel_uncore_write (&dev_priv->uncore,DSPCLK_GATE_D , dspclk_gate); +intel_uncore_write (&dev_priv->uncore,DSPCLK_GATE_D (dev_priv), dspclk_gate);g4x_disable_trickle_feed (dev_priv); }
@@ -8004,7 +8004,7 @@ static void i965gm_init_clock_gating(struct drm_i915_private *dev_priv)intel_uncore_write (uncore,RENCLK_GATE_D1 ,I965_RCC_CLOCK_GATE_DISABLE );intel_uncore_write (uncore,RENCLK_GATE_D2 ,0 ); -intel_uncore_write (uncore,DSPCLK_GATE_D ,0 ); +intel_uncore_write (uncore,DSPCLK_GATE_D (dev_priv),0 );intel_uncore_write (uncore,RAMCLK_GATE_D ,0 );intel_uncore_write16 (uncore,DEUC ,0 ); intel_uncore_write(uncore,
Signature · 1 line
2.34.1
PATCH 6/6 drm/i915/gmbus: mass dev_priv -> i915 rename
In reply to Jani NikulaNow that gmbus no longer uses macros that assume dev_priv is implicitly available, mass rename dev_priv to i915 in gmbus code.
--- drivers/gpu/drm/i915/display/intel_gmbus.c | 268 ++++++++++----------- 1 file changed, 134 insertions(+), 134 deletions(-)
drivers/gpu/drm/i915/display/intel_gmbus.c +134 -134
@@ -46,7 +46,7 @@ struct intel_gmbus {u32 reg0;i915_reg_t gpio_reg;struct i2c_algo_bit_data bit_algo; -struct drm_i915_private *dev_priv; +struct drm_i915_private *i915; };struct gmbus_pin {
@@ -177,49 +177,49 @@ intel_gmbus_reset(struct drm_i915_private *i915)intel_de_write (i915,GMBUS4 (i915),0 ); } -static void pnv_gmbus_clock_gating (struct drm_i915_private *dev_priv, +static void pnv_gmbus_clock_gating (struct drm_i915_private *i915,bool enable) {u32 val;/* When using bit bashing for I2C, this bit needs to be set to 1 */ - val =intel_de_read (dev_priv,DSPCLK_GATE_D (dev_priv)); + val =intel_de_read (i915,DSPCLK_GATE_D (i915));if (!enable) val |=PNV_GMBUSUNIT_CLOCK_GATE_DISABLE ;else val &= ~PNV_GMBUSUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,DSPCLK_GATE_D (dev_priv), val); +intel_de_write (i915,DSPCLK_GATE_D (i915), val); } -static void pch_gmbus_clock_gating (struct drm_i915_private *dev_priv, +static void pch_gmbus_clock_gating (struct drm_i915_private *i915,bool enable) {u32 val; - val =intel_de_read (dev_priv,SOUTH_DSPCLK_GATE_D ); + val =intel_de_read (i915,SOUTH_DSPCLK_GATE_D );if (!enable) val |=PCH_GMBUSUNIT_CLOCK_GATE_DISABLE ;else val &= ~PCH_GMBUSUNIT_CLOCK_GATE_DISABLE ; -intel_de_write (dev_priv,SOUTH_DSPCLK_GATE_D , val); +intel_de_write (i915,SOUTH_DSPCLK_GATE_D , val); } -static void bxt_gmbus_clock_gating (struct drm_i915_private *dev_priv, +static void bxt_gmbus_clock_gating (struct drm_i915_private *i915,bool enable) {u32 val; - val =intel_de_read (dev_priv,GEN9_CLKGATE_DIS_4 ); + val =intel_de_read (i915,GEN9_CLKGATE_DIS_4 );if (!enable) val |=BXT_GMBUS_GATING_DIS ;else val &= ~BXT_GMBUS_GATING_DIS ; -intel_de_write (dev_priv,GEN9_CLKGATE_DIS_4 , val); +intel_de_write (i915,GEN9_CLKGATE_DIS_4 , val); }static u32 get_reserved (struct intel_gmbus *bus) { -struct drm_i915_private *i915 = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915;struct intel_uncore *uncore = &i915->uncore;u32 reserved =0 ;
@@ -235,7 +235,7 @@ static u32 get_reserved(struct intel_gmbus *bus)static int get_clock (void *data) {struct intel_gmbus *bus = data; -struct intel_uncore *uncore = &bus->dev_priv->uncore; +struct intel_uncore *uncore = &bus->i915->uncore;u32 reserved =get_reserved (bus); intel_uncore_write_notrace(uncore,
@@ -250,7 +250,7 @@ static int get_clock(void *data)static int get_data (void *data) {struct intel_gmbus *bus = data; -struct intel_uncore *uncore = &bus->dev_priv->uncore; +struct intel_uncore *uncore = &bus->i915->uncore;u32 reserved =get_reserved (bus); intel_uncore_write_notrace(uncore,
@@ -265,7 +265,7 @@ static int get_data(void *data)static void set_clock (void *data,int state_high) {struct intel_gmbus *bus = data; -struct intel_uncore *uncore = &bus->dev_priv->uncore; +struct intel_uncore *uncore = &bus->i915->uncore;u32 reserved =get_reserved (bus);u32 clock_bits;
@@ -284,7 +284,7 @@ static void set_clock(void *data, int state_high)static void set_data (void *data,int state_high) {struct intel_gmbus *bus = data; -struct intel_uncore *uncore = &bus->dev_priv->uncore; +struct intel_uncore *uncore = &bus->i915->uncore;u32 reserved =get_reserved (bus);u32 data_bits;
@@ -302,12 +302,12 @@ static int intel_gpio_pre_xfer(struct i2c_adapter *adapter) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915; -intel_gmbus_reset (dev_priv); +intel_gmbus_reset (i915); -if (IS_PINEVIEW (dev_priv)) -pnv_gmbus_clock_gating (dev_priv, false); +if (IS_PINEVIEW (i915)) +pnv_gmbus_clock_gating (i915, false);set_data (bus,1 );set_clock (bus,1 );
@@ -319,13 +319,13 @@ static void intel_gpio_post_xfer(struct i2c_adapter *adapter) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915;set_data (bus,1 );set_clock (bus,1 ); -if (IS_PINEVIEW (dev_priv)) -pnv_gmbus_clock_gating (dev_priv, true); +if (IS_PINEVIEW (i915)) +pnv_gmbus_clock_gating (i915, true); } static void
@@ -357,7 +357,7 @@ static bool has_gmbus_irq(struct drm_i915_private *i915)return HAS_GMBUS_IRQ (i915) &&intel_irqs_enabled (i915); } -static int gmbus_wait (struct drm_i915_private *dev_priv,u32 status,u32 irq_en) +static int gmbus_wait (struct drm_i915_private *i915,u32 status,u32 irq_en) {DEFINE_WAIT (wait);u32 gmbus2;
@@ -367,21 +367,21 @@ static int gmbus_wait(struct drm_i915_private *dev_priv, u32 status, u32 irq_en)* we also need to check for NAKs besides the hw ready/idle signal, we * need to wake up periodically and check that ourselves. */ -if (!has_gmbus_irq (dev_priv)) +if (!has_gmbus_irq (i915)) irq_en =0 ; -add_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait); -intel_de_write_fw (dev_priv,GMBUS4 (dev_priv), irq_en); +add_wait_queue (&i915->display.gmbus.wait_queue, &wait); +intel_de_write_fw (i915,GMBUS4 (i915), irq_en); status |=GMBUS_SATOER ; - ret =wait_for_us ((gmbus2 =intel_de_read_fw (dev_priv,GMBUS2 (dev_priv))) & status, + ret =wait_for_us ((gmbus2 =intel_de_read_fw (i915,GMBUS2 (i915))) & status,2 );if (ret) - ret =wait_for ((gmbus2 =intel_de_read_fw (dev_priv,GMBUS2 (dev_priv))) & status, + ret =wait_for ((gmbus2 =intel_de_read_fw (i915,GMBUS2 (i915))) & status,50 ); -intel_de_write_fw (dev_priv,GMBUS4 (dev_priv),0 ); -remove_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait); +intel_de_write_fw (i915,GMBUS4 (i915),0 ); +remove_wait_queue (&i915->display.gmbus.wait_queue, &wait);if (gmbus2 &GMBUS_SATOER )return -ENXIO ;
@@ -390,7 +390,7 @@ static int gmbus_wait(struct drm_i915_private *dev_priv, u32 status, u32 irq_en) }static int -gmbus_wait_idle (struct drm_i915_private *dev_priv) +gmbus_wait_idle (struct drm_i915_private *i915) {DEFINE_WAIT (wait);u32 irq_enable;
@@ -398,35 +398,35 @@ gmbus_wait_idle(struct drm_i915_private *dev_priv)/* Important: The hw handles only the first bit, so set only one! */ irq_enable =0 ; -if (has_gmbus_irq (dev_priv)) +if (has_gmbus_irq (i915)) irq_enable =GMBUS_IDLE_EN ; -add_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait); -intel_de_write_fw (dev_priv,GMBUS4 (dev_priv), irq_enable); +add_wait_queue (&i915->display.gmbus.wait_queue, &wait); +intel_de_write_fw (i915,GMBUS4 (i915), irq_enable); - ret =intel_wait_for_register_fw (&dev_priv->uncore, -GMBUS2 (dev_priv),GMBUS_ACTIVE ,0 , + ret =intel_wait_for_register_fw (&i915->uncore, +GMBUS2 (i915),GMBUS_ACTIVE ,0 ,10 ); -intel_de_write_fw (dev_priv,GMBUS4 (dev_priv),0 ); -remove_wait_queue (&dev_priv->display.gmbus.wait_queue, &wait); +intel_de_write_fw (i915,GMBUS4 (i915),0 ); +remove_wait_queue (&i915->display.gmbus.wait_queue, &wait);return ret; } -static unsigned int gmbus_max_xfer_size (struct drm_i915_private *dev_priv) +static unsigned int gmbus_max_xfer_size (struct drm_i915_private *i915) { -return DISPLAY_VER (dev_priv) >=9 ?GEN9_GMBUS_BYTE_COUNT_MAX : +return DISPLAY_VER (i915) >=9 ?GEN9_GMBUS_BYTE_COUNT_MAX :GMBUS_BYTE_COUNT_MAX ; }static int -gmbus_xfer_read_chunk (struct drm_i915_private *dev_priv, +gmbus_xfer_read_chunk (struct drm_i915_private *i915,unsigned short addr,u8 *buf,unsigned int len,u32 gmbus0_reg,u32 gmbus1_index) {unsigned int size = len; -bool burst_read = len >gmbus_max_xfer_size (dev_priv); +bool burst_read = len >gmbus_max_xfer_size (i915);bool extra_byte_added = false;if (burst_read) {
@@ -439,21 +439,21 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv, len++; } size = len %256 +256 ; -intel_de_write_fw (dev_priv,GMBUS0 (dev_priv), +intel_de_write_fw (i915,GMBUS0 (i915), gmbus0_reg |GMBUS_BYTE_CNT_OVERRIDE ); } -intel_de_write_fw (dev_priv,GMBUS1 (dev_priv), +intel_de_write_fw (i915,GMBUS1 (i915), gmbus1_index |GMBUS_CYCLE_WAIT | (size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_READ |GMBUS_SW_RDY );while (len) {int ret;u32 val, loop =0 ; - ret =gmbus_wait (dev_priv,GMBUS_HW_RDY ,GMBUS_HW_RDY_EN ); + ret =gmbus_wait (i915,GMBUS_HW_RDY ,GMBUS_HW_RDY_EN );if (ret)return ret; - val =intel_de_read_fw (dev_priv,GMBUS3 (dev_priv)); + val =intel_de_read_fw (i915,GMBUS3 (i915)); do { if (extra_byte_added && len == 1) break;
@@ -464,7 +464,7 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv,if (burst_read && len == size -4 )/* Reset the override bit */ -intel_de_write_fw (dev_priv,GMBUS0 (dev_priv), gmbus0_reg); +intel_de_write_fw (i915,GMBUS0 (i915), gmbus0_reg); }return 0 ;
@@ -481,7 +481,7 @@ gmbus_xfer_read_chunk(struct drm_i915_private *dev_priv,#define INTEL_GMBUS_BURST_READ_MAX_LEN 767Ustatic int -gmbus_xfer_read (struct drm_i915_private *dev_priv,struct i2c_msg *msg, +gmbus_xfer_read (struct drm_i915_private *i915,struct i2c_msg *msg,u32 gmbus0_reg,u32 gmbus1_index) {u8 *buf = msg->buf;
@@ -490,12 +490,12 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg,int ret; do { - if (HAS_GMBUS_BURST_READ(dev_priv)) + if (HAS_GMBUS_BURST_READ(i915)) len = min(rx_size, INTEL_GMBUS_BURST_READ_MAX_LEN); else - len = min(rx_size, gmbus_max_xfer_size(dev_priv)); + len = min(rx_size, gmbus_max_xfer_size(i915)); - ret = gmbus_xfer_read_chunk(dev_priv, msg->addr, buf, len, + ret = gmbus_xfer_read_chunk(i915, msg->addr, buf, len, gmbus0_reg, gmbus1_index); if (ret) return ret;
@@ -508,7 +508,7 @@ gmbus_xfer_read(struct drm_i915_private *dev_priv, struct i2c_msg *msg, }static int -gmbus_xfer_write_chunk (struct drm_i915_private *dev_priv, +gmbus_xfer_write_chunk (struct drm_i915_private *i915,unsigned short addr,u8 *buf,unsigned int len,u32 gmbus1_index) {
@@ -521,8 +521,8 @@ gmbus_xfer_write_chunk(struct drm_i915_private *dev_priv, len -=1 ; } -intel_de_write_fw (dev_priv,GMBUS3 (dev_priv), val); -intel_de_write_fw (dev_priv,GMBUS1 (dev_priv), +intel_de_write_fw (i915,GMBUS3 (i915), val); +intel_de_write_fw (i915,GMBUS1 (i915), gmbus1_index |GMBUS_CYCLE_WAIT | (chunk_size <<GMBUS_BYTE_COUNT_SHIFT ) | (addr <<GMBUS_SLAVE_ADDR_SHIFT ) |GMBUS_SLAVE_WRITE |GMBUS_SW_RDY );while (len) {int ret;
@@ -532,9 +532,9 @@ gmbus_xfer_write_chunk(struct drm_i915_private *dev_priv, val |= *buf++ << (8 * loop); }while (--len && ++loop <4 ); -intel_de_write_fw (dev_priv,GMBUS3 (dev_priv), val); +intel_de_write_fw (i915,GMBUS3 (i915), val); - ret =gmbus_wait (dev_priv,GMBUS_HW_RDY ,GMBUS_HW_RDY_EN ); + ret =gmbus_wait (i915,GMBUS_HW_RDY ,GMBUS_HW_RDY_EN );if (ret)return ret; }
@@ -543,7 +543,7 @@ gmbus_xfer_write_chunk(struct drm_i915_private *dev_priv, }static int -gmbus_xfer_write (struct drm_i915_private *dev_priv,struct i2c_msg *msg, +gmbus_xfer_write (struct drm_i915_private *i915,struct i2c_msg *msg,u32 gmbus1_index) {u8 *buf = msg->buf;
@@ -552,9 +552,9 @@ gmbus_xfer_write(struct drm_i915_private *dev_priv, struct i2c_msg *msg,int ret; do { - len = min(tx_size, gmbus_max_xfer_size(dev_priv)); + len = min(tx_size, gmbus_max_xfer_size(i915)); - ret = gmbus_xfer_write_chunk(dev_priv, msg->addr, buf, len, + ret = gmbus_xfer_write_chunk(i915, msg->addr, buf, len, gmbus1_index); if (ret) return ret;
@@ -581,7 +581,7 @@ gmbus_is_index_xfer(struct i2c_msg *msgs, int i, int num) }static int -gmbus_index_xfer (struct drm_i915_private *dev_priv,struct i2c_msg *msgs, +gmbus_index_xfer (struct drm_i915_private *i915,struct i2c_msg *msgs,u32 gmbus0_reg) {u32 gmbus1_index =0 ;
@@ -597,17 +597,17 @@ gmbus_index_xfer(struct drm_i915_private *dev_priv, struct i2c_msg *msgs,/* GMBUS5 holds 16-bit index */ if (gmbus5) -intel_de_write_fw (dev_priv,GMBUS5 (dev_priv), gmbus5); +intel_de_write_fw (i915,GMBUS5 (i915), gmbus5);if (msgs[1 ].flags &I2C_M_RD ) - ret =gmbus_xfer_read (dev_priv, &msgs[1 ], gmbus0_reg, + ret =gmbus_xfer_read (i915, &msgs[1 ], gmbus0_reg, gmbus1_index);else - ret =gmbus_xfer_write (dev_priv, &msgs[1 ], gmbus1_index); + ret =gmbus_xfer_write (i915, &msgs[1 ], gmbus1_index);/* Clear GMBUS5 after each index transfer */ if (gmbus5) -intel_de_write_fw (dev_priv,GMBUS5 (dev_priv),0 ); +intel_de_write_fw (i915,GMBUS5 (i915),0 );return ret; }
@@ -617,34 +617,34 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num, u32 gmbus0_source) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915;int i =0 , inc, try =0 ;int ret =0 ;/* Display WA #0868: skl,bxt,kbl,cfl,glk */ -if (IS_GEMINILAKE (dev_priv) ||IS_BROXTON (dev_priv)) -bxt_gmbus_clock_gating (dev_priv, false); -else if (HAS_PCH_SPT (dev_priv) ||HAS_PCH_CNP (dev_priv)) -pch_gmbus_clock_gating (dev_priv, false); +if (IS_GEMINILAKE (i915) ||IS_BROXTON (i915)) +bxt_gmbus_clock_gating (i915, false); +else if (HAS_PCH_SPT (i915) ||HAS_PCH_CNP (i915)) +pch_gmbus_clock_gating (i915, false); retry: -intel_de_write_fw (dev_priv,GMBUS0 (dev_priv), gmbus0_source | bus->reg0); +intel_de_write_fw (i915,GMBUS0 (i915), gmbus0_source | bus->reg0);for (; i < num; i += inc) { inc =1 ;if (gmbus_is_index_xfer (msgs, i, num)) { - ret =gmbus_index_xfer (dev_priv, &msgs[i], + ret =gmbus_index_xfer (i915, &msgs[i], gmbus0_source | bus->reg0); inc =2 ;/* an index transmission is two msgs */ }else if (msgs[i].flags &I2C_M_RD ) { - ret =gmbus_xfer_read (dev_priv, &msgs[i], + ret =gmbus_xfer_read (i915, &msgs[i], gmbus0_source | bus->reg0,0 ); }else { - ret =gmbus_xfer_write (dev_priv, &msgs[i],0 ); + ret =gmbus_xfer_write (i915, &msgs[i],0 ); }if (!ret) - ret =gmbus_wait (dev_priv, + ret =gmbus_wait (i915,GMBUS_HW_WAIT_PHASE ,GMBUS_HW_WAIT_EN );if (ret == -ETIMEDOUT ) goto timeout;
@@ -656,19 +656,19 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,* a STOP on the very first cycle. To simplify the code we * unconditionally generate the STOP condition with an additional gmbus * cycle. */ -intel_de_write_fw (dev_priv,GMBUS1 (dev_priv),GMBUS_CYCLE_STOP |GMBUS_SW_RDY ); +intel_de_write_fw (i915,GMBUS1 (i915),GMBUS_CYCLE_STOP |GMBUS_SW_RDY );/* Mark the GMBUS interface as disabled after waiting for idle. * We will re-enable it at the start of the next xfer, * till then let it sleep. */ -if (gmbus_wait_idle (dev_priv)) { -drm_dbg_kms (&dev_priv->drm, +if (gmbus_wait_idle (i915)) { +drm_dbg_kms (&i915->drm,"GMBUS [%s] timed out waiting for idle\n" , adapter->name); ret = -ETIMEDOUT ; } -intel_de_write_fw (dev_priv,GMBUS0 (dev_priv),0 ); +intel_de_write_fw (i915,GMBUS0 (i915),0 ); ret = ret ?: i; goto out;
@@ -687,8 +687,8 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,* it's slow responding and only answers on the 2nd retry. */ ret = -ENXIO ; -if (gmbus_wait_idle (dev_priv)) { -drm_dbg_kms (&dev_priv->drm, +if (gmbus_wait_idle (i915)) { +drm_dbg_kms (&i915->drm,"GMBUS [%s] timed out after NAK\n" , adapter->name); ret = -ETIMEDOUT ;
@@ -698,11 +698,11 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,* of resetting the GMBUS controller and so clearing the * BUS_ERROR raised by the slave's NAK. */ -intel_de_write_fw (dev_priv,GMBUS1 (dev_priv),GMBUS_SW_CLR_INT ); -intel_de_write_fw (dev_priv,GMBUS1 (dev_priv),0 ); -intel_de_write_fw (dev_priv,GMBUS0 (dev_priv),0 ); +intel_de_write_fw (i915,GMBUS1 (i915),GMBUS_SW_CLR_INT ); +intel_de_write_fw (i915,GMBUS1 (i915),0 ); +intel_de_write_fw (i915,GMBUS0 (i915),0 ); -drm_dbg_kms (&dev_priv->drm,"GMBUS [%s] NAK for addr: %04x %c(%d)\n" , +drm_dbg_kms (&i915->drm,"GMBUS [%s] NAK for addr: %04x %c(%d)\n" , adapter->name, msgs[i].addr, (msgs[i].flags &I2C_M_RD ) ?'r' :'w' , msgs[i].len);
@@ -713,7 +713,7 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num,* drm_do_probe_ddc_edid, which bails out on the first -ENXIO. */ if (ret == -ENXIO && i ==0 && try++ ==0 ) { -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"GMBUS [%s] NAK on first message, retry\n" , adapter->name); goto retry;
@@ -722,10 +722,10 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num, goto out; timeout: -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"GMBUS [%s] timed out, falling back to bit banging on pin %d\n" , bus->adapter.name, bus->reg0 &0xff ); -intel_de_write_fw (dev_priv,GMBUS0 (dev_priv),0 ); +intel_de_write_fw (i915,GMBUS0 (i915),0 );/* * Hardware may not support GMBUS over these pins? Try GPIO bitbanging
@@ -735,10 +735,10 @@ do_gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num, out:/* Display WA #0868: skl,bxt,kbl,cfl,glk */ -if (IS_GEMINILAKE (dev_priv) ||IS_BROXTON (dev_priv)) -bxt_gmbus_clock_gating (dev_priv, true); -else if (HAS_PCH_SPT (dev_priv) ||HAS_PCH_CNP (dev_priv)) -pch_gmbus_clock_gating (dev_priv, true); +if (IS_GEMINILAKE (i915) ||IS_BROXTON (i915)) +bxt_gmbus_clock_gating (i915, true); +else if (HAS_PCH_SPT (i915) ||HAS_PCH_CNP (i915)) +pch_gmbus_clock_gating (i915, true);return ret; }
@@ -747,11 +747,11 @@ static int gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num) { struct intel_gmbus *bus = to_intel_gmbus(adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915;intel_wakeref_t wakeref;int ret; - wakeref =intel_display_power_get (dev_priv,POWER_DOMAIN_GMBUS ); + wakeref =intel_display_power_get (i915,POWER_DOMAIN_GMBUS );if (bus->force_bit) { ret = i2c_bit_algo.master_xfer (adapter, msgs, num);
@@ -763,7 +763,7 @@ gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num) bus->force_bit |=GMBUS_FORCE_BIT_RETRY ; } -intel_display_power_put (dev_priv,POWER_DOMAIN_GMBUS , wakeref); +intel_display_power_put (i915,POWER_DOMAIN_GMBUS , wakeref);return ret; }
@@ -771,7 +771,7 @@ gmbus_xfer(struct i2c_adapter *adapter, struct i2c_msg *msgs, int num)int intel_gmbus_output_aksv (struct i2c_adapter *adapter) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915;u8 cmd =DRM_HDCP_DDC_AKSV ;u8 buf[DRM_HDCP_KSV_LEN ] = {0 };struct i2c_msg msgs[] = {
@@ -791,8 +791,8 @@ int intel_gmbus_output_aksv(struct i2c_adapter *adapter)intel_wakeref_t wakeref;int ret; - wakeref =intel_display_power_get (dev_priv,POWER_DOMAIN_GMBUS ); -mutex_lock (&dev_priv->display.gmbus.mutex); + wakeref =intel_display_power_get (i915,POWER_DOMAIN_GMBUS ); +mutex_lock (&i915->display.gmbus.mutex);/* * In order to output Aksv to the receiver, use an indexed write to
@@ -801,8 +801,8 @@ int intel_gmbus_output_aksv(struct i2c_adapter *adapter)*/ ret =do_gmbus_xfer (adapter, msgs,ARRAY_SIZE (msgs),GMBUS_AKSV_SELECT ); -mutex_unlock (&dev_priv->display.gmbus.mutex); -intel_display_power_put (dev_priv,POWER_DOMAIN_GMBUS , wakeref); +mutex_unlock (&i915->display.gmbus.mutex); +intel_display_power_put (i915,POWER_DOMAIN_GMBUS , wakeref);return ret; }
@@ -825,27 +825,27 @@ static void gmbus_lock_bus(struct i2c_adapter *adapter, unsigned int flags) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915; -mutex_lock (&dev_priv->display.gmbus.mutex); +mutex_lock (&i915->display.gmbus.mutex); }static int gmbus_trylock_bus (struct i2c_adapter *adapter,unsigned int flags) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915; -return mutex_trylock (&dev_priv->display.gmbus.mutex); +return mutex_trylock (&i915->display.gmbus.mutex); }static void gmbus_unlock_bus (struct i2c_adapter *adapter,unsigned int flags) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915; -mutex_unlock (&dev_priv->display.gmbus.mutex); +mutex_unlock (&i915->display.gmbus.mutex); }static const struct i2c_lock_operations gmbus_lock_ops = {
@@ -856,31 +856,31 @@ static const struct i2c_lock_operations gmbus_lock_ops = {/** * intel_gmbus_setup - instantiate all Intel i2c GMBuses -* @dev_priv: i915 device private +* @i915: i915 device private */ -int intel_gmbus_setup (struct drm_i915_private *dev_priv) +int intel_gmbus_setup (struct drm_i915_private *i915) { -struct pci_dev *pdev =to_pci_dev (dev_priv->drm.dev); +struct pci_dev *pdev =to_pci_dev (i915->drm.dev);unsigned int pin;int ret; -if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) - dev_priv->display.gmbus.mmio_base =VLV_DISPLAY_BASE ; -else if (!HAS_GMCH (dev_priv)) +if (IS_VALLEYVIEW (i915) ||IS_CHERRYVIEW (i915)) + i915->display.gmbus.mmio_base =VLV_DISPLAY_BASE ; +else if (!HAS_GMCH (i915))/* * Broxton uses the same PCH offsets for South Display Engine, * even though it doesn't have a PCH. */ - dev_priv->display.gmbus.mmio_base =PCH_DISPLAY_BASE ; + i915->display.gmbus.mmio_base =PCH_DISPLAY_BASE ; -mutex_init (&dev_priv->display.gmbus.mutex); -init_waitqueue_head (&dev_priv->display.gmbus.wait_queue); +mutex_init (&i915->display.gmbus.mutex); +init_waitqueue_head (&i915->display.gmbus.wait_queue); -for (pin =0 ; pin <ARRAY_SIZE (dev_priv->display.gmbus.bus); pin++) { +for (pin =0 ; pin <ARRAY_SIZE (i915->display.gmbus.bus); pin++) {const struct gmbus_pin *gmbus_pin;struct intel_gmbus *bus; - gmbus_pin =get_gmbus_pin (dev_priv, pin); + gmbus_pin =get_gmbus_pin (i915, pin);if (!gmbus_pin)continue ;
@@ -897,7 +897,7 @@ int intel_gmbus_setup(struct drm_i915_private *dev_priv) "i915 gmbus %s", gmbus_pin->name); bus->adapter.dev.parent = &pdev->dev; - bus->dev_priv = dev_priv; + bus->i915 = i915; bus->adapter.algo = &gmbus_algorithm; bus->adapter.lock_ops = &gmbus_lock_ops;
@@ -912,10 +912,10 @@ int intel_gmbus_setup(struct drm_i915_private *dev_priv) bus->reg0 = pin |GMBUS_RATE_100KHZ ;/* gmbus seems to be broken on i830 */ -if (IS_I830 (dev_priv)) +if (IS_I830 (i915)) bus->force_bit =1 ; -intel_gpio_setup (bus,GPIO (dev_priv, gmbus_pin->gpio)); +intel_gpio_setup (bus,GPIO (i915, gmbus_pin->gpio)); ret =i2c_add_adapter (&bus->adapter);if (ret) {
@@ -923,43 +923,43 @@ int intel_gmbus_setup(struct drm_i915_private *dev_priv) goto err; } - dev_priv->display.gmbus.bus[pin] = bus; + i915->display.gmbus.bus[pin] = bus; } -intel_gmbus_reset (dev_priv); +intel_gmbus_reset (i915);return 0 ; err: -intel_gmbus_teardown (dev_priv); +intel_gmbus_teardown (i915);return ret; } -struct i2c_adapter *intel_gmbus_get_adapter (struct drm_i915_private *dev_priv, +struct i2c_adapter *intel_gmbus_get_adapter (struct drm_i915_private *i915,unsigned int pin) { -if (drm_WARN_ON (&dev_priv->drm, pin >=ARRAY_SIZE (dev_priv->display.gmbus.bus) || - !dev_priv->display.gmbus.bus[pin])) +if (drm_WARN_ON (&i915->drm, pin >=ARRAY_SIZE (i915->display.gmbus.bus) || + !i915->display.gmbus.bus[pin]))return NULL ; -return &dev_priv->display.gmbus.bus[pin]->adapter; +return &i915->display.gmbus.bus[pin]->adapter; }void intel_gmbus_force_bit (struct i2c_adapter *adapter,bool force_bit) {struct intel_gmbus *bus =to_intel_gmbus (adapter); -struct drm_i915_private *dev_priv = bus->dev_priv; +struct drm_i915_private *i915 = bus->i915; -mutex_lock (&dev_priv->display.gmbus.mutex); +mutex_lock (&i915->display.gmbus.mutex); bus->force_bit += force_bit ?1 :-1 ; -drm_dbg_kms (&dev_priv->drm, +drm_dbg_kms (&i915->drm,"%sabling bit-banging on %s. force bit now %d\n" , force_bit ?"en" :"dis" , adapter->name, bus->force_bit); -mutex_unlock (&dev_priv->display.gmbus.mutex); +mutex_unlock (&i915->display.gmbus.mutex); }bool intel_gmbus_is_forced_bit (struct i2c_adapter *adapter)
@@ -969,20 +969,20 @@ bool intel_gmbus_is_forced_bit(struct i2c_adapter *adapter)return bus->force_bit; } -void intel_gmbus_teardown (struct drm_i915_private *dev_priv) +void intel_gmbus_teardown (struct drm_i915_private *i915) {unsigned int pin; -for (pin =0 ; pin <ARRAY_SIZE (dev_priv->display.gmbus.bus); pin++) { +for (pin =0 ; pin <ARRAY_SIZE (i915->display.gmbus.bus); pin++) {struct intel_gmbus *bus; - bus = dev_priv->display.gmbus.bus[pin]; + bus = i915->display.gmbus.bus[pin];if (!bus)continue ;i2c_del_adapter (&bus->adapter);kfree (bus); - dev_priv->display.gmbus.bus[pin] =NULL ; + i915->display.gmbus.bus[pin] =NULL ; } }
Signature · 1 line
2.34.1
PATCH 2/6 drm/i915/gmbus: whitespace cleanup in reg definitions
In reply to Jani NikulaSimple whitespace cleanup and comment movement.
--- .../gpu/drm/i915/display/intel_gmbus_regs.h | 117 ++++++++++-------- 1 file changed, 63 insertions(+), 54 deletions(-)
drivers/gpu/drm/i915/display/intel_gmbus_regs.h +63 -54
@@ -10,62 +10,71 @@#define GPIO (gpio) _MMIO(dev_priv->display.gmbus.mmio_base + 0x5010 + \ 4 * (gpio)) +#define GPIO_CLOCK_DIR_MASK (1 << 0) +#define GPIO_CLOCK_DIR_IN (0 << 1) +#define GPIO_CLOCK_DIR_OUT (1 << 1) +#define GPIO_CLOCK_VAL_MASK (1 << 2) +#define GPIO_CLOCK_VAL_OUT (1 << 3) +#define GPIO_CLOCK_VAL_IN (1 << 4) +#define GPIO_CLOCK_PULLUP_DISABLE (1 << 5) +#define GPIO_DATA_DIR_MASK (1 << 8) +#define GPIO_DATA_DIR_IN (0 << 9) +#define GPIO_DATA_DIR_OUT (1 << 9) +#define GPIO_DATA_VAL_MASK (1 << 10) +#define GPIO_DATA_VAL_OUT (1 << 11) +#define GPIO_DATA_VAL_IN (1 << 12) +#define GPIO_DATA_PULLUP_DISABLE (1 << 13) -# define GPIO_CLOCK_DIR_MASK (1 << 0) -# define GPIO_CLOCK_DIR_IN (0 << 1) -# define GPIO_CLOCK_DIR_OUT (1 << 1) -# define GPIO_CLOCK_VAL_MASK (1 << 2) -# define GPIO_CLOCK_VAL_OUT (1 << 3) -# define GPIO_CLOCK_VAL_IN (1 << 4) -# define GPIO_CLOCK_PULLUP_DISABLE (1 << 5) -# define GPIO_DATA_DIR_MASK (1 << 8) -# define GPIO_DATA_DIR_IN (0 << 9) -# define GPIO_DATA_DIR_OUT (1 << 9) -# define GPIO_DATA_VAL_MASK (1 << 10) -# define GPIO_DATA_VAL_OUT (1 << 11) -# define GPIO_DATA_VAL_IN (1 << 12) -# define GPIO_DATA_PULLUP_DISABLE (1 << 13) +/* clock/port select */ +#define GMBUS0 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5100) +#define GMBUS_AKSV_SELECT (1 << 11) +#define GMBUS_RATE_100KHZ (0 << 8) +#define GMBUS_RATE_50KHZ (1 << 8) +#define GMBUS_RATE_400KHZ (2 << 8)/* reserved on Pineview */ +#define GMBUS_RATE_1MHZ (3 << 8)/* reserved on Pineview */ +#define GMBUS_HOLD_EXT (1 << 7)/* 300ns hold time, rsvd on Pineview */ +#define GMBUS_BYTE_CNT_OVERRIDE (1 << 6) -#define GMBUS0 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5100)/* clock/port select */ -#define GMBUS_AKSV_SELECT (1 << 11) -#define GMBUS_RATE_100KHZ (0 << 8) -#define GMBUS_RATE_50KHZ (1 << 8) -#define GMBUS_RATE_400KHZ (2 << 8)/* reserved on Pineview */ -#define GMBUS_RATE_1MHZ (3 << 8)/* reserved on Pineview */ -#define GMBUS_HOLD_EXT (1 << 7)/* 300ns hold time, rsvd on Pineview */ -#define GMBUS_BYTE_CNT_OVERRIDE (1 << 6) +/* command/status */ +#define GMBUS1 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5104) +#define GMBUS_SW_CLR_INT (1 << 31) +#define GMBUS_SW_RDY (1 << 30) +#define GMBUS_ENT (1 << 29)/* enable timeout */ +#define GMBUS_CYCLE_NONE (0 << 25) +#define GMBUS_CYCLE_WAIT (1 << 25) +#define GMBUS_CYCLE_INDEX (2 << 25) +#define GMBUS_CYCLE_STOP (4 << 25) +#define GMBUS_BYTE_COUNT_SHIFT 16 +#define GMBUS_BYTE_COUNT_MAX 256U +#define GEN9_GMBUS_BYTE_COUNT_MAX 511U +#define GMBUS_SLAVE_INDEX_SHIFT 8 +#define GMBUS_SLAVE_ADDR_SHIFT 1 +#define GMBUS_SLAVE_READ (1 << 0) +#define GMBUS_SLAVE_WRITE (0 << 0) -#define GMBUS1 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5104)/* command/status */ -#define GMBUS_SW_CLR_INT (1 << 31) -#define GMBUS_SW_RDY (1 << 30) -#define GMBUS_ENT (1 << 29)/* enable timeout */ -#define GMBUS_CYCLE_NONE (0 << 25) -#define GMBUS_CYCLE_WAIT (1 << 25) -#define GMBUS_CYCLE_INDEX (2 << 25) -#define GMBUS_CYCLE_STOP (4 << 25) -#define GMBUS_BYTE_COUNT_SHIFT 16 -#define GMBUS_BYTE_COUNT_MAX 256U -#define GEN9_GMBUS_BYTE_COUNT_MAX 511U -#define GMBUS_SLAVE_INDEX_SHIFT 8 -#define GMBUS_SLAVE_ADDR_SHIFT 1 -#define GMBUS_SLAVE_READ (1 << 0) -#define GMBUS_SLAVE_WRITE (0 << 0) -#define GMBUS2 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5108)/* status */ -#define GMBUS_INUSE (1 << 15) -#define GMBUS_HW_WAIT_PHASE (1 << 14) -#define GMBUS_STALL_TIMEOUT (1 << 13) -#define GMBUS_INT (1 << 12) -#define GMBUS_HW_RDY (1 << 11) -#define GMBUS_SATOER (1 << 10) -#define GMBUS_ACTIVE (1 << 9) -#define GMBUS3 _MMIO(dev_priv->display.gmbus.mmio_base + 0x510c)/* data buffer bytes 3-0 */ -#define GMBUS4 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5110)/* interrupt mask (Pineview+) */ -#define GMBUS_SLAVE_TIMEOUT_EN (1 << 4) -#define GMBUS_NAK_EN (1 << 3) -#define GMBUS_IDLE_EN (1 << 2) -#define GMBUS_HW_WAIT_EN (1 << 1) -#define GMBUS_HW_RDY_EN (1 << 0) -#define GMBUS5 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5120)/* byte index */ -#define GMBUS_2BYTE_INDEX_EN (1 << 31) +/* status */ +#define GMBUS2 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5108) +#define GMBUS_INUSE (1 << 15) +#define GMBUS_HW_WAIT_PHASE (1 << 14) +#define GMBUS_STALL_TIMEOUT (1 << 13) +#define GMBUS_INT (1 << 12) +#define GMBUS_HW_RDY (1 << 11) +#define GMBUS_SATOER (1 << 10) +#define GMBUS_ACTIVE (1 << 9) + +/* data buffer bytes 3-0 */ +#define GMBUS3 _MMIO(dev_priv->display.gmbus.mmio_base + 0x510c) + +/* interrupt mask (Pineview+) */ +#define GMBUS4 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5110) +#define GMBUS_SLAVE_TIMEOUT_EN (1 << 4) +#define GMBUS_NAK_EN (1 << 3) +#define GMBUS_IDLE_EN (1 << 2) +#define GMBUS_HW_WAIT_EN (1 << 1) +#define GMBUS_HW_RDY_EN (1 << 0) + +/* byte index */ +#define GMBUS5 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5120) +#define GMBUS_2BYTE_INDEX_EN (1 << 31)#endif /* __INTEL_GMBUS_REGS_H__ */
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gmbus: stop using implicit dev_priv
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/gmbus: stop using implicit dev_priv
URL : https://patchwork.freedesktop.org/series/107930/
State : warning
== Summary ==
Error: dim checkpatch failed3c07702148f6 drm/i915/gmbus: split out gmbus regs in a separate file
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 11, in <module>
import git
ModuleNotFoundError: No module named 'git'
-:24: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #24:
new file mode 100644
-:57: WARNING:LONG_LINE_COMMENT: line length of 105 exceeds 100 columns #57: FILE: drivers/gpu/drm/i915/display/intel_gmbus_regs.h:29:
+#define GMBUS0 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5100) /* clock/port select */
-:66: WARNING:LONG_LINE_COMMENT: line length of 102 exceeds 100 columns #66: FILE: drivers/gpu/drm/i915/display/intel_gmbus_regs.h:38:
+#define GMBUS1 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5104) /* command/status */
-:89: WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns #89: FILE: drivers/gpu/drm/i915/display/intel_gmbus_regs.h:61:
+#define GMBUS3 _MMIO(dev_priv->display.gmbus.mmio_base + 0x510c) /* data buffer bytes 3-0 */
-:90: WARNING:LONG_LINE_COMMENT: line length of 114 exceeds 100 columns #90: FILE: drivers/gpu/drm/i915/display/intel_gmbus_regs.h:62:
+#define GMBUS4 _MMIO(dev_priv->display.gmbus.mmio_base + 0x5110) /* interrupt mask (Pineview+) */
total: 0 errors, 5 warnings, 0 checks, 158 lines checked 010019a09cff drm/i915/gmbus: whitespace cleanup in reg definitions f770b6f60e27 drm/i915/gmbus: add wrapper for gmbus mmio base 8d2905eb3406 drm/i915/gmbus: stop using implicit dev_priv in register definitions 7446134adefe drm/i915/reg: stop using implicit dev_priv in DSPCLK_GATE_D dcb5561c1c40 drm/i915/gmbus: mass dev_priv -> i915 rename
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gmbus: stop using implicit dev_priv
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/gmbus: stop using implicit dev_priv
URL : https://patchwork.freedesktop.org/series/107930/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gmbus: stop using implicit dev_priv
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/gmbus: stop using implicit dev_priv
URL : https://patchwork.freedesktop.org/series/107930/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12048 -> Patchwork_107930v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/index.html
Participating hosts (39 -> 35)
------------------------------
Missing (4): fi-ctg-p8600 bat-dg2-8 bat-adln-1 fi-bdw-samus
Known issues
------------
Here are the changes found in Patchwork_107930v1 that come from known issues:
### IGT changes ###
#### Possible fixes ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size:
- fi-bsw-kefka: [FAIL][1] ([i915#6298]) -> [PASS][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/fi-bsw-kefka/igt@kms_cursor_legacy@basic-busy-flip-before-cursor@atomic-transitions-varying-size.html
* igt@kms_pipe_crc_basic@suspend-read-crc@pipe-c-hdmi-a-2:
- fi-bdw-5557u: [INCOMPLETE][3] ([i915#146]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/fi-bdw-5557u/igt@kms_pipe_crc_basic@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/fi-bdw-5557u/igt@kms_pipe_crc_basic@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#146]: https://gitlab.freedesktop.org/drm/intel/issues/146
[i915#6298]: https://gitlab.freedesktop.org/drm/intel/issues/6298
[i915#6579]: https://gitlab.freedesktop.org/drm/intel/issues/6579
Build changes
-------------
* Linux: CI_DRM_12048 -> Patchwork_107930v1
CI-20190529: 20190529
CI_DRM_12048: 7662d7a73e30619a337c4486f85f7fce046524d6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6638: 9338ab3ec085292817ab1e74d1f2fb90b6a98332 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107930v1: 7662d7a73e30619a337c4486f85f7fce046524d6 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
24ac71aef6c6 drm/i915/gmbus: mass dev_priv -> i915 rename bfed02a1f0de drm/i915/reg: stop using implicit dev_priv in DSPCLK_GATE_D 39aef0a32249 drm/i915/gmbus: stop using implicit dev_priv in register definitions 2170ddc0a90d drm/i915/gmbus: add wrapper for gmbus mmio base 9e41fecd59e1 drm/i915/gmbus: whitespace cleanup in reg definitions 3febf782d0a9 drm/i915/gmbus: split out gmbus regs in a separate file
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/index.html
Quoted 5 lines · Jani Nikula
The register macros are the last holdout for implicit
dev_privlocal variable. Try out what it would mean to stop using it, and require passing i915 as parameter to the register macros. Use gmbus as a nicely isolated playing ground.
Quoted 7 lines
Jani Nikula (6):
drm/i915/gmbus: split out gmbus regs in a separate file drm/i915/gmbus: whitespace cleanup in reg definitions drm/i915/gmbus: add wrapper for gmbus mmio base drm/i915/gmbus: stop using implicitdev_privin register definitions drm/i915/reg: stop using implicitdev_privinDSPCLK_GATE_Ddrm/i915/gmbus: massdev_priv-> i915 rename
Looks reasonable enough to me. Just wondering when I'll start getting annoyed at not finding something in i915_reg.h :)
Series is
Quoted 14 lines
.../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 275 +++++++++--------- .../gpu/drm/i915/display/intel_gmbus_regs.h | 81 ++++++ drivers/gpu/drm/i915/display/intel_overlay.c | 4 +- drivers/gpu/drm/i915/display/vlv_dsi.c | 8 +- drivers/gpu/drm/i915/gvt/edid.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 65 +---- drivers/gpu/drm/i915/intel_pm.c | 4 +- 8 files changed, 232 insertions(+), 212 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_gmbus_regs.hSignature · 1 line
2.34.1
Signature · 2 lines
Ville Syrjälä Intel
Quoted 14 lines · Ville Syrjälä
Quoted 5 lines · Jani Nikula
The register macros are the last holdout for implicit
dev_privlocal variable. Try out what it would mean to stop using it, and require passing i915 as parameter to the register macros. Use gmbus as a nicely isolated playing ground.Quoted 7 lines
Jani Nikula (6):
drm/i915/gmbus: split out gmbus regs in a separate file drm/i915/gmbus: whitespace cleanup in reg definitions drm/i915/gmbus: add wrapper for gmbus mmio base drm/i915/gmbus: stop using implicitdev_privin register definitions drm/i915/reg: stop using implicitdev_privinDSPCLK_GATE_Ddrm/i915/gmbus: massdev_priv-> i915 rename
Quoted 2 lines
Looks reasonable enough to me. Just wondering when I'll start getting annoyed at not finding something in
i915_reg.h:)
That's a risk. :)
The flip side is, I've actually liked to see how few places really need each of the new *_regs.h files. It's almost an indication the design is wrong if more than a couple .c files include the same regs file.
Quoted 2 lines
Series is
Reviewed-by Ville Syrjälä <[email protected]>
Thanks!
Jani.
Quoted 15 lines
Quoted 15 lines
.../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 275 +++++++++--------- .../gpu/drm/i915/display/intel_gmbus_regs.h | 81 ++++++ drivers/gpu/drm/i915/display/intel_overlay.c | 4 +- drivers/gpu/drm/i915/display/vlv_dsi.c | 8 +- drivers/gpu/drm/i915/gvt/edid.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 65 +---- drivers/gpu/drm/i915/intel_pm.c | 4 +- 8 files changed, 232 insertions(+), 212 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_gmbus_regs.hSignature · 1 line
2.34.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gmbus: stop using implicit dev_priv
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915/gmbus: stop using implicit dev_priv
URL : https://patchwork.freedesktop.org/series/107930/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12048_full -> Patchwork_107930v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 12)
------------------------------
Missing (1): shard-dg1
Known issues
------------
Here are the changes found in Patchwork_107930v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@api_intel_bb@crc32:
- shard-tglb: NOTRUN -> [SKIP][1] ([i915#6230])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@feature_discovery@chamelium:
- shard-tglb: NOTRUN -> [SKIP][2] ([fdo#111827])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@feature_discovery@display-2x:
- shard-tglb: NOTRUN -> [SKIP][3] ([i915#1839]) +2 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@gem_ccs@ctrl-surf-copy:
- shard-tglb: NOTRUN -> [SKIP][4] ([i915#3555] / [i915#5325]) +2 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@gem_ccs@suspend-resume:
- shard-tglb: NOTRUN -> [SKIP][5] ([i915#5325]) +1 similar issue
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@gem_create@create-ext-cpu-access-sanity-check:
- shard-tglb: NOTRUN -> [SKIP][6] ([i915#6335]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][7] ([i915#4991])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][8] ([i915#4991]) +1 similar issue
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- shard-tglb: NOTRUN -> [FAIL][9] ([i915#6268])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
* igt@gem_ctx_param@set-priority-not-supported:
- shard-tglb: NOTRUN -> [SKIP][10] ([fdo#109314])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@gem_ctx_persistence@many-contexts:
- shard-tglb: NOTRUN -> [FAIL][11] ([i915#2410])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@gem_ctx_sseu@engines:
- shard-tglb: NOTRUN -> [SKIP][12] ([i915#280]) +3 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@gem_eio@kms:
- shard-tglb: NOTRUN -> [FAIL][13] ([i915#5784]) +1 similar issue
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@gem_exec_balancer@parallel-bb-first:
- shard-iclb: [PASS][14] -> [SKIP][15] ([i915#4525]) +2 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb1/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb7/igt@[email protected]
* igt@gem_exec_balancer@parallel-ordering:
- shard-tglb: NOTRUN -> [FAIL][16] ([i915#6117])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@gem_exec_capture@capture-invisible@smem0:
- shard-tglb: NOTRUN -> [SKIP][17] ([i915#6334])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@gem_exec_capture@[email protected]
* igt@gem_exec_capture@capture-recoverable:
- shard-tglb: NOTRUN -> [SKIP][18] ([i915#6344])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][19] -> [FAIL][20] ([i915#2842])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@gem_exec_fair@[email protected]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vcs1:
- shard-tglb: NOTRUN -> [FAIL][21] ([i915#2842]) +15 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-iclb: [PASS][22] -> [FAIL][23] ([i915#2842]) +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb7/igt@gem_exec_fair@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb8/igt@gem_exec_fair@[email protected]
* igt@gem_exec_flush@basic-batch-kernel-default-cmd:
- shard-tglb: NOTRUN -> [SKIP][24] ([fdo#109313])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@gem_exec_params@no-blt:
- shard-tglb: NOTRUN -> [SKIP][25] ([fdo#109283]) +2 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@gem_exec_params@no-vebox:
- shard-tglb: NOTRUN -> [SKIP][26] ([fdo#109283] / [i915#4877])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@gem_exec_params@secure-non-root:
- shard-tglb: NOTRUN -> [SKIP][27] ([fdo#112283]) +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@gem_lmem_swapping@heavy-verify-multi-ccs:
- shard-tglb: NOTRUN -> [SKIP][28] ([i915#4613]) +19 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify:
- shard-apl: NOTRUN -> [SKIP][29] ([fdo#109271] / [i915#4613])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
* igt@gem_lmem_swapping@parallel-random-verify-ccs:
- shard-kbl: NOTRUN -> [SKIP][30] ([fdo#109271] / [i915#4613])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@[email protected]
* igt@gem_media_vme:
- shard-tglb: NOTRUN -> [SKIP][31] ([i915#284])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@gem_media_vme.html
* igt@gem_mmap_gtt@coherency:
- shard-tglb: NOTRUN -> [SKIP][32] ([fdo#111656])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@gem_pread@exhaustion:
- shard-apl: NOTRUN -> [WARN][33] ([i915#2658])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
- shard-tglb: NOTRUN -> [WARN][34] ([i915#2658]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@gem_pxp@reject-modify-context-protection-off-1:
- shard-tglb: NOTRUN -> [SKIP][35] ([i915#4270]) +17 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@gem_render_copy@x-tiled-to-vebox-yf-tiled:
- shard-apl: NOTRUN -> [SKIP][36] ([fdo#109271]) +41 similar issues
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
* igt@gem_softpin@evict-snoop:
- shard-tglb: NOTRUN -> [SKIP][37] ([fdo#109312]) +1 similar issue
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@gem_userptr_blits@coherency-sync:
- shard-tglb: NOTRUN -> [SKIP][38] ([fdo#110542])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@gem_userptr_blits@dmabuf-sync:
- shard-apl: NOTRUN -> [SKIP][39] ([fdo#109271] / [i915#3323])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][40] ([i915#3323])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@gem_userptr_blits@readonly-pwrite-unsync:
- shard-tglb: NOTRUN -> [SKIP][41] ([i915#3297]) +10 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-tglb: NOTRUN -> [FAIL][42] ([i915#3318])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@gen7_exec_parse@load-register-reg:
- shard-tglb: NOTRUN -> [SKIP][43] ([fdo#109289]) +22 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@gen9_exec_parse@cmd-crossing-page:
- shard-tglb: NOTRUN -> [SKIP][44] ([i915#2527] / [i915#2856]) +20 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@i915_module_load@load:
- shard-tglb: NOTRUN -> [SKIP][45] ([i915#6227])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@i915_module_load@resize-bar:
- shard-tglb: NOTRUN -> [SKIP][46] ([i915#6412])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-tglb: NOTRUN -> [SKIP][47] ([i915#1904])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-tglb: NOTRUN -> [FAIL][48] ([i915#3989] / [i915#454]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
* igt@i915_pm_dc@dc9-dpms:
- shard-tglb: NOTRUN -> [SKIP][49] ([i915#4281])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@i915_pm_freq_mult@media-freq@gt0:
- shard-tglb: NOTRUN -> [SKIP][50] ([i915#6590])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@i915_pm_freq_mult@[email protected]
* igt@i915_pm_lpsp@screens-disabled:
- shard-tglb: NOTRUN -> [SKIP][51] ([i915#1902])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglb: NOTRUN -> [WARN][52] ([i915#2681]) +4 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@modeset-non-lpsp:
- shard-tglb: NOTRUN -> [SKIP][53] ([fdo#111644] / [i915#1397] / [i915#2411]) +4 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-tglb: NOTRUN -> [SKIP][54] ([fdo#109506] / [i915#2411]) +2 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- shard-tglb: NOTRUN -> [SKIP][55] ([i915#4387])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@i915_query@hwconfig_table:
- shard-tglb: NOTRUN -> [SKIP][56] ([i915#6245])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@i915_query@hwconfig_table.html
* igt@i915_query@query-topology-known-pci-ids:
- shard-tglb: NOTRUN -> [SKIP][57] ([fdo#109303])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@i915_query@query-topology-unsupported:
- shard-tglb: NOTRUN -> [SKIP][58] ([fdo#109302])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@i915_query@test-query-geometry-subslices:
- shard-tglb: NOTRUN -> [SKIP][59] ([i915#5723])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@i915_selftest@live@gt_lrc:
- shard-tglb: NOTRUN -> [DMESG-FAIL][60] ([i915#2373])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@i915_selftest@live@gt_lrc.html
* igt@i915_selftest@live@gt_pm:
- shard-tglb: NOTRUN -> [DMESG-FAIL][61] ([i915#1759])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@i915_selftest@live@gt_pm.html
* igt@i915_suspend@debugfs-reader:
- shard-kbl: [PASS][62] -> [DMESG-WARN][63] ([i915#180]) +7 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
* igt@kms_addfb_basic@invalid-smem-bo-on-discrete:
- shard-tglb: NOTRUN -> [SKIP][64] ([i915#3826])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@kms_atomic@plane-primary-overlay-mutable-zpos:
- shard-tglb: NOTRUN -> [SKIP][65] ([i915#404])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@kms_atomic_transition@plane-all-modeset-transition-fencing:
- shard-tglb: NOTRUN -> [SKIP][66] ([i915#1769]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180:
- shard-tglb: NOTRUN -> [SKIP][67] ([i915#5286]) +33 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@kms_big_fb@x-tiled-16bpp-rotate-270:
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#111614]) +17 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-kbl: NOTRUN -> [SKIP][69] ([fdo#109271]) +15 similar issues
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglb: NOTRUN -> [SKIP][70] ([fdo#111615]) +38 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@kms_big_fb@yf-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_joiner@invalid-modeset:
- shard-tglb: NOTRUN -> [SKIP][71] ([i915#2705]) +2 similar issues
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#3886]) +1 similar issue
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@kms_ccs@pipe-a-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-kbl: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#3886]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@kms_ccs@pipe-b-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][74] ([i915#6095]) +28 similar issues
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@kms_ccs@pipe-c-bad-pixel-format-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglb: NOTRUN -> [SKIP][75] ([i915#3689] / [i915#3886]) +26 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_dg2_rc_ccs:
- shard-tglb: NOTRUN -> [SKIP][76] ([i915#3689] / [i915#6095]) +28 similar issues
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@kms_ccs@pipe-c-crc-primary-rotation-180-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][77] ([i915#3689]) +51 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@kms_ccs@pipe-c-random-ccs-data-y_tiled_ccs.html
* igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][78] ([fdo#111615] / [i915#3689]) +33 similar issues
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@kms_ccs@pipe-d-bad-aux-stride-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglb: NOTRUN -> [SKIP][79] ([i915#3742]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@kms_chamelium@dp-edid-change-during-suspend:
- shard-kbl: NOTRUN -> [SKIP][80] ([fdo#109271] / [fdo#111827]) +1 similar issue
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@[email protected]
* igt@kms_chamelium@dp-hpd-fast:
- shard-tglb: NOTRUN -> [SKIP][81] ([fdo#109284] / [fdo#111827]) +54 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@kms_chamelium@vga-frame-dump:
- shard-apl: NOTRUN -> [SKIP][82] ([fdo#109271] / [fdo#111827]) +2 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
* igt@kms_content_protection@atomic-dpms:
- shard-tglb: NOTRUN -> [SKIP][83] ([i915#1063]) +7 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@kms_content_protection@dp-mst-lic-type-0:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3116] / [i915#3299]) +3 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
* igt@kms_content_protection@mei_interface:
- shard-tglb: NOTRUN -> [SKIP][85] ([fdo#109300])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@kms_content_protection@mei_interface.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-tglb: NOTRUN -> [SKIP][86] ([fdo#109274] / [fdo#111825]) +27 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@kms_cursor_legacy@short-busy-flip-before-cursor:
- shard-tglb: NOTRUN -> [SKIP][87] ([i915#4103]) +1 similar issue
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@kms_display_modes@extended-mode-basic:
- shard-tglb: NOTRUN -> [SKIP][88] ([fdo#109274])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-8bpc:
- shard-tglb: NOTRUN -> [SKIP][89] ([i915#1769] / [i915#3555])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
* igt@kms_dp_tiled_display@basic-test-pattern:
- shard-tglb: NOTRUN -> [SKIP][90] ([i915#426])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@kms_dp_tiled_display@basic-test-pattern-with-chamelium:
- shard-tglb: NOTRUN -> [SKIP][91] ([i915#3528])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb2101010-pwrite-4tiled:
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#5287]) +16 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@kms_dsc@dsc-with-bpp:
- shard-tglb: NOTRUN -> [SKIP][93] ([i915#3828])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][94] -> [INCOMPLETE][95] ([i915#180] / [i915#1982] / [i915#4939] / [i915#6598])
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-apl3/igt@[email protected]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl1/igt@[email protected]
* igt@kms_flip@2x-absolute-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][96] ([fdo#109274] / [fdo#111825] / [i915#3637] / [i915#3966])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@kms_flip@2x-absolute-wf_vblank.html
* igt@kms_flip@2x-flip-vs-modeset:
- shard-tglb: NOTRUN -> [SKIP][97] ([fdo#109274] / [fdo#111825] / [i915#3637]) +38 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode:
- shard-iclb: [PASS][98] -> [SKIP][99] ([i915#3555])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-xtile-to-64bpp-xtile-downscaling@pipe-a-default-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-4tile-to-32bpp-4tile-upscaling@pipe-a-valid-mode:
- shard-tglb: NOTRUN -> [SKIP][100] ([i915#2672]) +21 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@kms_flip_scaled_crc@[email protected]
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-iclb: NOTRUN -> [SKIP][101] ([i915#2672]) +7 similar issues
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb6/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_force_connector_basic@force-load-detect:
- shard-tglb: NOTRUN -> [SKIP][102] ([fdo#109285])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-apl: [PASS][103] -> [DMESG-WARN][104] ([i915#180]) +1 similar issue
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-apl2/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl6/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-tiling-4:
- shard-tglb: NOTRUN -> [SKIP][105] ([i915#5439]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][106] ([i915#6497]) +70 similar issues
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite:
- shard-tglb: NOTRUN -> [SKIP][107] ([fdo#109280] / [fdo#111825]) +210 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-cur-indfb-draw-pwrite.html
* igt@kms_hdr@bpc-switch-dpms@pipe-a-dp-1:
- shard-kbl: [PASS][108] -> [FAIL][109] ([i915#1188])
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl1/igt@kms_hdr@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@kms_hdr@[email protected]
* igt@kms_hdr@bpc-switch-suspend:
- shard-tglb: NOTRUN -> [SKIP][110] ([i915#3555]) +16 similar issues
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@kms_invalid_mode@clock-too-high@edp-1-pipe-d:
- shard-tglb: NOTRUN -> [SKIP][111] ([i915#6403]) +3 similar issues
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@kms_invalid_mode@[email protected]
* igt@kms_plane_lowres@tiling-4:
- shard-tglb: NOTRUN -> [SKIP][112] ([fdo#112054] / [i915#5288])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@kms_plane_lowres@tiling-y@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][113] ([i915#3536]) +11 similar issues
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@kms_plane_lowres@[email protected]
* igt@kms_plane_lowres@tiling-yf:
- shard-tglb: NOTRUN -> [SKIP][114] ([fdo#112054])
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@kms_plane_multiple@atomic-pipe-d-tiling-4:
- shard-tglb: NOTRUN -> [SKIP][115] ([i915#5288]) +3 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
* igt@kms_plane_scaling@plane-downscale-with-rotation-factor-0-75@pipe-d-edp-1:
- shard-tglb: NOTRUN -> [SKIP][116] ([i915#5176]) +39 similar issues
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@kms_plane_scaling@[email protected]
* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-25@pipe-c-edp-1:
- shard-tglb: NOTRUN -> [SKIP][117] ([i915#5235]) +15 similar issues
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@kms_plane_scaling@[email protected]
* igt@kms_prime@basic-modeset-hybrid:
- shard-tglb: NOTRUN -> [SKIP][118] ([i915#6524]) +2 similar issues
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-update-continuous-sf:
- shard-tglb: NOTRUN -> [SKIP][119] ([i915#2920]) +12 similar issues
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-apl: NOTRUN -> [SKIP][120] ([fdo#109271] / [i915#658])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-iclb: [PASS][121] -> [SKIP][122] ([fdo#109642] / [fdo#111068] / [i915#658])
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb2/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb8/igt@[email protected]
* igt@kms_psr2_su@page_flip-nv12:
- shard-tglb: NOTRUN -> [SKIP][123] ([i915#1911]) +3 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@kms_psr2_su@page_flip-nv12.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-tglb: NOTRUN -> [FAIL][124] ([i915#132] / [i915#3467]) +20 similar issues
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@kms_psr@psr2_cursor_mmap_gtt.html
* igt@kms_psr@psr2_no_drrs:
- shard-iclb: [PASS][125] -> [SKIP][126] ([fdo#109441]) +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb2/igt@kms_psr@psr2_no_drrs.html
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb6/igt@kms_psr@psr2_no_drrs.html
* igt@kms_rotation_crc@primary-4-tiled-reflect-x-0:
- shard-tglb: NOTRUN -> [SKIP][127] ([i915#5289]) +1 similar issue
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-180:
- shard-tglb: NOTRUN -> [SKIP][128] ([fdo#111615] / [i915#5289]) +1 similar issue
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@kms_scaling_modes@scaling-mode-none@edp-1-pipe-d:
- shard-tglb: NOTRUN -> [SKIP][129] ([i915#5030]) +3 similar issues
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@kms_scaling_modes@[email protected]
* igt@kms_selftest@all:
- shard-tglb: NOTRUN -> [SKIP][130] ([i915#6433]) +2 similar issues
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb7/igt@[email protected]
* igt@kms_tv_load_detect@load-detect:
- shard-tglb: NOTRUN -> [SKIP][131] ([fdo#109309])
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@kms_writeback@writeback-fb-id:
- shard-tglb: NOTRUN -> [SKIP][132] ([i915#2437]) +2 similar issues
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb1/igt@[email protected]
* igt@nouveau_crc@pipe-b-source-outp-inactive:
- shard-tglb: NOTRUN -> [SKIP][133] ([i915#2530]) +20 similar issues
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name:
- shard-tglb: NOTRUN -> [SKIP][134] ([fdo#109291]) +27 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@prime_nv_api@nv_i915_reimport_twice_check_flink_name.html
* igt@prime_vgem@basic-userptr:
- shard-tglb: NOTRUN -> [SKIP][135] ([fdo#109295] / [i915#3301])
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb3/igt@[email protected]
* igt@prime_vgem@coherency-gtt:
- shard-tglb: NOTRUN -> [SKIP][136] ([fdo#109295] / [fdo#111656])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@prime_vgem@fence-flip-hang:
- shard-tglb: NOTRUN -> [SKIP][137] ([fdo#109295]) +2 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb2/igt@[email protected]
* igt@runner@aborted:
- shard-tglb: NOTRUN -> ([FAIL][138], [FAIL][139]) ([i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb5/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@sysfs_clients@busy:
- shard-tglb: NOTRUN -> [SKIP][140] ([i915#2994]) +13 similar issues
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@[email protected]
* igt@sysfs_clients@split-50:
- shard-apl: NOTRUN -> [SKIP][141] ([fdo#109271] / [i915#2994])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
* igt@tools_test@sysfs_l3_parity:
- shard-tglb: NOTRUN -> [SKIP][142] ([fdo#109307])
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-tglb6/igt@tools_test@sysfs_l3_parity.html
#### Possible fixes ####
* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-kbl: [DMESG-WARN][143] ([i915#180]) -> [PASS][144] +2 similar issues
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl4/igt@gem_ctx_isolation@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@gem_ctx_isolation@[email protected]
* igt@gem_exec_balancer@fairslice:
- {shard-rkl}: [SKIP][145] ([i915#6259]) -> [PASS][146]
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-rkl-5/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-rkl-1/igt@[email protected]
* igt@gem_exec_balancer@parallel-balancer:
- shard-iclb: [SKIP][147] ([i915#4525]) -> [PASS][148]
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb3/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@[email protected]
* igt@gem_exec_fair@basic-none@vcs1:
- shard-kbl: [FAIL][149] ([i915#2842]) -> [PASS][150]
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@gem_exec_fair@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [DMESG-WARN][151] ([i915#180]) -> [PASS][152]
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-apl6/igt@kms_flip@[email protected]
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@kms_flip@[email protected]
* igt@kms_hdr@bpc-switch@pipe-a-dp-1:
- shard-kbl: [FAIL][153] ([i915#1188]) -> [PASS][154]
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@kms_hdr@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@kms_hdr@[email protected]
* igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1:
- shard-iclb: [SKIP][155] ([i915#5176]) -> [PASS][156] +1 similar issue
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb3/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@kms_plane_scaling@plane-scaler-with-clipping-clamping-pixel-formats@pipe-b-edp-1.html
* igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1:
- shard-iclb: [SKIP][157] ([i915#5235]) -> [PASS][158] +2 similar issues
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb2/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb6/igt@kms_plane_scaling@planes-upscale-factor-0-25-downscale-factor-0-5@pipe-a-edp-1.html
* igt@kms_psr@psr2_cursor_mmap_gtt:
- shard-iclb: [SKIP][159] ([fdo#109441]) -> [PASS][160] +2 similar issues
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb3/igt@kms_psr@psr2_cursor_mmap_gtt.html
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@kms_psr@psr2_cursor_mmap_gtt.html
#### Warnings ####
* igt@gem_exec_balancer@parallel-ordering:
- shard-iclb: [SKIP][161] ([i915#4525]) -> [FAIL][162] ([i915#6117])
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb8/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@[email protected]
* igt@i915_pm_dc@dc3co-vpb-simulation:
- shard-iclb: [SKIP][163] ([i915#658]) -> [SKIP][164] ([i915#588])
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb3/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@vcs0:
- shard-iclb: [WARN][165] ([i915#2684]) -> [FAIL][166] ([i915#2684])
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb8/igt@i915_pm_rc6_residency@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@i915_pm_rc6_residency@[email protected]
* igt@kms_fbcon_fbt@fbc-suspend:
- shard-kbl: [INCOMPLETE][167] ([i915#180] / [i915#4939] / [i915#6598]) -> [FAIL][168] ([i915#4767])
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-kbl: [FAIL][169] ([i915#1188]) -> [DMESG-FAIL][170] ([i915#180])
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl1/igt@kms_hdr@[email protected]
[170]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@kms_hdr@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-fully-sf:
- shard-iclb: [SKIP][171] ([i915#658]) -> [SKIP][172] ([i915#2920])
[171]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb8/igt@[email protected]
[172]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@[email protected]
* igt@kms_psr2_sf@overlay-plane-move-continuous-sf:
- shard-iclb: [SKIP][173] ([i915#2920]) -> [SKIP][174] ([i915#658]) +2 similar issues
[173]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb2/igt@[email protected]
[174]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb6/igt@[email protected]
* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-iclb: [SKIP][175] ([fdo#111068] / [i915#658]) -> [SKIP][176] ([i915#2920])
[175]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-iclb3/igt@[email protected]
[176]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-iclb2/igt@[email protected]
* igt@runner@aborted:
- shard-apl: ([FAIL][177], [FAIL][178], [FAIL][179], [FAIL][180]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599]) -> ([FAIL][181], [FAIL][182], [FAIL][183], [FAIL][184], [FAIL][185], [FAIL][186]) ([fdo#109271] / [i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6599])
[177]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-apl3/igt@[email protected]
[178]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-apl6/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-apl8/igt@[email protected]
[180]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-apl7/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
[182]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
[183]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl8/igt@[email protected]
[184]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl3/igt@[email protected]
[185]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl6/igt@[email protected]
[186]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-apl1/igt@[email protected]
- shard-kbl: ([FAIL][187], [FAIL][188], [FAIL][189], [FAIL][190], [FAIL][191], [FAIL][192], [FAIL][193], [FAIL][194], [FAIL][195]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#92]) -> ([FAIL][196], [FAIL][197], [FAIL][198], [FAIL][199], [FAIL][200], [FAIL][201], [FAIL][202], [FAIL][203], [FAIL][204], [FAIL][205], [FAIL][206], [FAIL][207], [FAIL][208], [FAIL][209]) ([i915#180] / [i915#3002] / [i915#4312] / [i915#5257] / [i915#6219])
[187]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@[email protected]
[188]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl4/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@[email protected]
[190]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl4/igt@[email protected]
[191]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@[email protected]
[192]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@[email protected]
[193]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl7/igt@[email protected]
[194]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl4/igt@[email protected]
[195]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12048/shard-kbl1/igt@[email protected]
[196]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@[email protected]
[197]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
[198]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@[email protected]
[199]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
[200]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@[email protected]
[201]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
[202]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@[email protected]
[203]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@[email protected]
[204]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
[205]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
[206]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl4/igt@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
[208]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl1/igt@[email protected]
[209]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/shard-kbl7/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109313]: https://bugs.freedesktop.org/show_bug.cgi?id=109313
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1063]: https://gitlab.freedesktop.org/drm/intel/issues/1063
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1257]: https://gitlab.freedesktop.org/drm/intel/issues/1257
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1904]: https://gitlab.freedesktop.org/drm/intel/issues/1904
[i915#1911]: https://gitlab.freedesktop.org/drm/intel/issues/1911
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2410]: https://gitlab.freedesktop.org/drm/intel/issues/2410
[i915#2411]: https://gitlab.freedesktop.org/drm/intel/issues/2411
[i915#2433]: https://gitlab.freedesktop.org/drm/intel/issues/2433
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2530]: https://gitlab.freedesktop.org/drm/intel/issues/2530
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2684]: https://gitlab.freedesktop.org/drm/intel/issues/2684
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3002]: https://gitlab.freedesktop.org/drm/intel/issues/3002
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3376]: https://gitlab.freedesktop.org/drm/intel/issues/3376
[i915#3467]: https://gitlab.freedesktop.org/drm/intel/issues/3467
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3804]: https://gitlab.freedesktop.org/drm/intel/issues/3804
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3828]: https://gitlab.freedesktop.org/drm/intel/issues/3828
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4016]: https://gitlab.freedesktop.org/drm/intel/issues/4016
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4171]: https://gitlab.freedesktop.org/drm/intel/issues/4171
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4281]: https://gitlab.freedesktop.org/drm/intel/issues/4281
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4369]: https://gitlab.freedesktop.org/drm/intel/issues/4369
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#4877]: https://gitlab.freedesktop.org/drm/intel/issues/4877
[i915#4939]: https://gitlab.freedesktop.org/drm/intel/issues/4939
[i915#4991]: https://gitlab.freedesktop.org/drm/intel/issues/4991
[i915#5030]: https://gitlab.freedesktop.org/drm/intel/issues/5030
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5287]: https://gitlab.freedesktop.org/drm/intel/issues/5287
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#588]: https://gitlab.freedesktop.org/drm/intel/issues/588
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6117]: https://gitlab.freedesktop.org/drm/intel/issues/6117
[i915#6219]: https://gitlab.freedesktop.org/drm/intel/issues/6219
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6230]: https://gitlab.freedesktop.org/drm/intel/issues/6230
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6403]: https://gitlab.freedesktop.org/drm/intel/issues/6403
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6598]: https://gitlab.freedesktop.org/drm/intel/issues/6598
[i915#6599]: https://gitlab.freedesktop.org/drm/intel/issues/6599
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
Build changes
-------------
* Linux: CI_DRM_12048 -> Patchwork_107930v1
CI-20190529: 20190529
CI_DRM_12048: 7662d7a73e30619a337c4486f85f7fce046524d6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6638: 9338ab3ec085292817ab1e74d1f2fb90b6a98332 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_107930v1: 7662d7a73e30619a337c4486f85f7fce046524d6 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_107930v1/index.html
Quoted 20 lines · Jani Nikula
Quoted 14 lines · Ville Syrjälä
Quoted 5 lines · Jani Nikula
The register macros are the last holdout for implicit
dev_privlocal variable. Try out what it would mean to stop using it, and require passing i915 as parameter to the register macros. Use gmbus as a nicely isolated playing ground.Quoted 7 lines
Jani Nikula (6):
drm/i915/gmbus: split out gmbus regs in a separate file drm/i915/gmbus: whitespace cleanup in reg definitions drm/i915/gmbus: add wrapper for gmbus mmio base drm/i915/gmbus: stop using implicitdev_privin register definitions drm/i915/reg: stop using implicitdev_privinDSPCLK_GATE_Ddrm/i915/gmbus: massdev_priv-> i915 renameQuoted 2 lines
Looks reasonable enough to me. Just wondering when I'll start getting annoyed at not finding something in
i915_reg.h:)That's a risk. :)
Quoted 8 lines
The flip side is, I've actually liked to see how few places really need each of the new *_regs.h files. It's almost an indication the design is wrong if more than a couple .c files include the same regs file.
Quoted 2 lines
Series is
Reviewed-by Ville Syrjälä <[email protected]>Thanks!
And pushed to drm-intel-next.
BR,
Jani.
Quoted 18 lines
Jani.
Quoted 15 lines
Quoted 15 lines
.../i915/display/intel_display_power_well.c | 4 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 275 +++++++++--------- .../gpu/drm/i915/display/intel_gmbus_regs.h | 81 ++++++ drivers/gpu/drm/i915/display/intel_overlay.c | 4 +- drivers/gpu/drm/i915/display/vlv_dsi.c | 8 +- drivers/gpu/drm/i915/gvt/edid.c | 3 +- drivers/gpu/drm/i915/i915_reg.h | 65 +---- drivers/gpu/drm/i915/intel_pm.c | 4 +- 8 files changed, 232 insertions(+), 212 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_gmbus_regs.hSignature · 1 line
2.34.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center