use memset to make code clearer
v3 cover use memset to make code clearer
Re-write some code using memset to make it more obvious. Also remove an unnecessary volatile qualifier, because compiler complains about passing volatile pointer to memset.
V3: get rid of "volatile" entirely, instead of just casting it away.
V2: re-write commit message because previous message describes a non-existent problem.
Nam Cao (2):
staging: vt6655: remove unnecessary volatile qualifier
staging: vt6655: use memset to make code clearer
drivers/staging/vt6655/desc.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.25.1
PATCH v3 1/2 staging: vt6655: remove unnecessary volatile qualifier
Remove volatile qualifier for the member rd0 of struct vnt_rx_desc, because there is no reason it must be volatile.
--- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/desc.h +1 -1
@@ -182,7 +182,7 @@ struct vnt_rdes1 {/* Rx descriptor*/ struct vnt_rx_desc { -volatile struct vnt_rdes0 rd0; +struct vnt_rdes0 rd0;volatile struct vnt_rdes1 rd1;volatile __le32 buff_addr;volatile __le32 next_desc;
Signature · 1 line
2.25.1
PATCH v3 2/2 staging: vt6655: use memset to make code clearer
In reply to Nam CaoA line of code sets the entire struct vnt_rdes0 to zero by treating it as unsigned int. This works because sizeof(unsigned int) is equal to sizeof(struct vnt_rdes0) (4 bytes). However it is not obvious what this code is doing. Re-write this using memset to make the code clearer.
--- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/vt6655/device_main.c +1 -1
@@ -867,7 +867,7 @@ static bool device_alloc_rx_buf(struct vnt_private *priv,return false; } - *((unsigned int *)&rd->rd0) =0 ;/* FIX cast */ +memset (&rd->rd0,0 ,sizeof (rd->rd0)); rd->rd0.res_count =cpu_to_le16 (priv->rx_buf_sz); rd->rd0.owner =OWNED_BY_NIC ;
Signature · 1 line
2.25.1
Quoted 8 lines · Nam Cao
Re-write some code using memset to make it more obvious. Also remove an unnecessary volatile qualifier, because compiler complains about passing volatile pointer to memset.
V3: get rid of "volatile" entirely, instead of just casting it away.
V2: re-write commit message because previous message describes a non-existent problem.
Quoted 8 lines
Nam Cao (2):
staging: vt6655: remove unnecessary volatile qualifier
staging: vt6655: use memset to make code clearerdrivers/staging/vt6655/desc.h | 2 +- drivers/staging/vt6655/device_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Greg KH
maintainerRe: [PATCH v3 1/2] staging: vt6655: remove unnecessary volatile qualifier
In reply to Nam CaoQuoted 13 lines · Nam Cao
Remove volatile qualifier for the member rd0 of struct
vnt_rx_desc, because there is no reason it must be volatile.Signed-off-by Nam Cao <[email protected]>--- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/desc.h +0
-0
drivers/staging/vt6655/desc.h struct vnt_rdes1 { · line 185
Quoted 5 lines
drivers/staging/vt6655/desc.h +1
-1@@ -182,7 +182,7 @@ struct vnt_rdes1 {/* Rx descriptor*/ struct vnt_rx_desc { -volatile struct vnt_rdes0 rd0; +struct vnt_rdes0 rd0;
You can not just remove this without describing _WHY_ it is ok to do so.
Have you properly determined why it is, or is not, ok to use volatile here? And if so, why are you leaving:
drivers/staging/vt6655/desc.h struct vnt_rdes1 { · line 188
Quoted 3 lines
drivers/staging/vt6655/desc.h +0
-0volatile struct vnt_rdes1 rd1;volatile __le32 buff_addr;volatile __le32 next_desc;
Those?
Please read up on why volatile almost never makes any sense in the kernel (note, sometimes it does), and please write a better changelog text for when you submit the next version of this patch series.
thanks,
greg k-h
Re: [PATCH v3 1/2] staging: vt6655: remove unnecessary volatile qualifier
Quoted 23 lines · Greg KH
Quoted 13 lines · Nam Cao
Remove volatile qualifier for the member rd0 of struct
vnt_rx_desc, because there is no reason it must be volatile.Signed-off-by Nam Cao <[email protected]>--- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/desc.h +0
-0drivers/staging/vt6655/desc.h struct vnt_rdes1 { · line 185
Quoted 5 lines
drivers/staging/vt6655/desc.h +1
-1@@ -182,7 +182,7 @@ struct vnt_rdes1 {/* Rx descriptor*/ struct vnt_rx_desc { -volatile struct vnt_rdes0 rd0; +struct vnt_rdes0 rd0;You can not just remove this without describing _WHY_ it is ok to do so.
Quoted 2 lines
Have you properly determined why it is, or is not, ok to use volatile here?
I did not carefully look at the volatile usage here. After looking at it again, using volatile is actually valid: the structure resides on coherent memory.
Sorry for being careless.
Best regards,
Nam
Greg KH
maintainerRe: [PATCH v3 1/2] staging: vt6655: remove unnecessary volatile qualifier
Quoted 24 lines · Nam Cao
Quoted 23 lines · Greg KH
Quoted 13 lines · Nam Cao
Remove volatile qualifier for the member rd0 of struct
vnt_rx_desc, because there is no reason it must be volatile.Signed-off-by Nam Cao <[email protected]>--- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/desc.h +0
-0drivers/staging/vt6655/desc.h struct vnt_rdes1 { · line 185
Quoted 5 lines
drivers/staging/vt6655/desc.h +1
-1@@ -182,7 +182,7 @@ struct vnt_rdes1 {/* Rx descriptor*/ struct vnt_rx_desc { -volatile struct vnt_rdes0 rd0; +struct vnt_rdes0 rd0;You can not just remove this without describing _WHY_ it is ok to do so.
Quoted 6 lines
Quoted 2 lines
Have you properly determined why it is, or is not, ok to use volatile here?
I did not carefully look at the volatile usage here. After looking at it again, using volatile is actually valid: the structure resides on coherent memory.
Are you sure? That's a very odd thing for a driver to need. Looks like they are allocating some dma memory and then pointing structures on top of that memory. Why would you need to have "volatile" markings on a structure definition for that?
Dig into this some more please, I don't think this is correct.
thanks,
greg k-h
Re: [PATCH v3 1/2] staging: vt6655: remove unnecessary volatile qualifier
Quoted 29 lines · Greg KH
Quoted 27 lines · Nam Cao
Quoted 25 lines · Greg KH
Quoted 13 lines · Nam Cao
Remove volatile qualifier for the member rd0 of struct
vnt_rx_desc, because there is no reason it must be volatile.Signed-off-by Nam Cao <[email protected]>--- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/desc.h +0
-0drivers/staging/vt6655/desc.h struct vnt_rdes1 { · line 185
Quoted 5 lines
drivers/staging/vt6655/desc.h +1
-1@@ -182,7 +182,7 @@ struct vnt_rdes1 {/* Rx descriptor*/ struct vnt_rx_desc { -volatile struct vnt_rdes0 rd0; +struct vnt_rdes0 rd0;You can not just remove this without describing _WHY_ it is ok to do so.
Have you properly determined why it is, or is not, ok to use volatile here?
Quoted 8 lines
Quoted 3 lines
I did not carefully look at the volatile usage here. After looking at it again, using volatile is actually valid: the structure resides on coherent memory.
Are you sure? That's a very odd thing for a driver to need. Looks like they are allocating some dma memory and then pointing structures on top of that memory. Why would you need to have "volatile" markings on a structure definition for that?
These structures are the ring buffer descriptors, which are dma-mapped and their values may be changed by the hardware. For example, the field "owner" of struct vnt_rdes0 is set to OWNED_BY_NIC by CPU, and then set to OWNED_BY_HOST by hardware when new data arrives (at least that's why I can guess based on the codes). So I think volatile is needed.
Please let me know if you think I'm wrong, because I have just recently educated myself on DMA mapping.
Best regards,
Nam
Greg KH
maintainerRe: [PATCH v3 1/2] staging: vt6655: remove unnecessary volatile qualifier
Quoted 39 lines · Nam Cao
Quoted 29 lines · Greg KH
Quoted 27 lines · Nam Cao
Quoted 25 lines · Greg KH
Quoted 13 lines · Nam Cao
Remove volatile qualifier for the member rd0 of struct
vnt_rx_desc, because there is no reason it must be volatile.Signed-off-by Nam Cao <[email protected]>--- drivers/staging/vt6655/desc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/vt6655/desc.h +0
-0drivers/staging/vt6655/desc.h struct vnt_rdes1 { · line 185
Quoted 5 lines
drivers/staging/vt6655/desc.h +1
-1@@ -182,7 +182,7 @@ struct vnt_rdes1 {/* Rx descriptor*/ struct vnt_rx_desc { -volatile struct vnt_rdes0 rd0; +struct vnt_rdes0 rd0;You can not just remove this without describing _WHY_ it is ok to do so.
Have you properly determined why it is, or is not, ok to use volatile here?
Quoted 8 lines
Quoted 3 lines
I did not carefully look at the volatile usage here. After looking at it again, using volatile is actually valid: the structure resides on coherent memory.
Are you sure? That's a very odd thing for a driver to need. Looks like they are allocating some dma memory and then pointing structures on top of that memory. Why would you need to have "volatile" markings on a structure definition for that?
Quoted 8 lines
These structures are the ring buffer descriptors, which are dma-mapped and their values may be changed by the hardware. For example, the field "owner" of struct
vnt_rdes0is set toOWNED_BY_NICby CPU, and then set toOWNED_BY_HOSTby hardware when new data arrives (at least that's why I can guess based on the codes). So I think volatile is needed.Please let me know if you think I'm wrong, because I have just recently educated myself on DMA mapping.
With DMA mapping you shouldn't need "volatile" as it really doesn't do what people thought it did. Other drivers don't use volatile for accessing memory this way, the device should have notified the driver that it is now safe to read from that memory through the DMA api.
So try looking a bit closer and also look at the compiler output before and after your change to see if it actually did anything or not.
thanks,
greg k-h