Skip to contentSkip to conversation

Patch review

PATCH New Steve Sakoman 1 participant 4 messages Sep 29, 2022

lore
Share & tools
lore
#0 lore raw

cover Patch review

Please review this set of patches for dunfell and have comments back by end of day Thursday.

Passed a-full on autobuilder:

https://autobuilder.yoctoproject.org/typhoon/#/builders/83/builds/4278

The following changes since commit 6227efbf03d2e7ca773ab29177705203f2550722:

linux-firmware: package new Qualcomm firmware (2022-09-26 12:29:44 -1000)

are available in the Git repository at:

https://git.openembedded.org/openembedded-core-contrib stable/dunfell-nut
http://cgit.openembedded.org/openembedded-core-contrib/log/?h=stable/dunfell-nut

Hitendra Prajapati (1):
bluez: CVE-2022-39176 BlueZ allows physically proximate attackers

Martin Jansa (1):
create-pull-request: don't switch the git remote protocol to git://

Richard Purdie (1):
vim: Upgrade 9.0.0541 -> 9.0.0598

 meta/recipes-connectivity/bluez5/bluez5.inc   |   1 +
 .../bluez5/bluez5/CVE-2022-39176.patch        | 126 ++++++++++++++++++
 meta/recipes-support/vim/vim.inc              |   4 +-
 scripts/create-pull-request                   |   2 +-
 4 files changed, 130 insertions(+), 3 deletions(-)
 create mode 100644 meta/recipes-connectivity/bluez5/bluez5/CVE-2022-39176.patch
Signature · 1 line
2.25.1
#1 lore raw

PATCH 1/3 bluez: CVE-2022-39176 BlueZ allows physically proximate attackers

From: Hitendra Prajapati <[email protected]>

Source: https://bugs.launchpad.net/ubuntu/+source/bluez/+bug/1977968
MR: 122140
Type: Security Fix
Disposition: Backport from https://launchpad.net/ubuntu/+source/bluez/5.53-0ubuntu3.6
ChangeID: b989c7670a9b2bd1d11221e981eab0d162f3271c
Description:
CVE-2022-39176 bluez: BlueZ allows physically proximate attackers to obtain sensitive information because profiles/audio/avrcp.c does not validate params_len.
Affects "bluez < 5.59"

---
 meta/recipes-connectivity/bluez5/bluez5.inc   |   1 +
 .../bluez5/bluez5/CVE-2022-39176.patch        | 126 ++++++++++++++++++
 2 files changed, 127 insertions(+)
 create mode 100644 meta/recipes-connectivity/bluez5/bluez5/CVE-2022-39176.patch
meta/recipes-connectivity/bluez5/bluez5.inc +1 -0
index 4d4348898a..eaac9ee849 100644
@@ -56,6 +56,7 @@ SRC_URI = "${KERNELORG_MIRROR}/linux/bluetooth/bluez-${PV}.tar.xz \
            file://CVE-2021-3588.patch \
           file://CVE-2021-3658.patch \
            file://CVE-2022-0204.patch \
+           file://CVE-2022-39176.patch \
            "
 S = "${WORKDIR}/bluez-${PV}"
 
meta/recipes-connectivity/bluez5/bluez5/CVE-2022-39176.patch new file +126 -0

126 lines not on this page · raw message

Signature · 1 line
2.25.1
#2 lore raw

PATCH 2/3 vim: Upgrade 9.0.0541 -> 9.0.0598

In reply to Steve Sakoman

From: Richard Purdie <[email protected]>

Includes a fix for CVE-2022-3278.

(cherry picked from commit 98c40271692147873a622e168e8b2e90a9fcc54c)
---
 meta/recipes-support/vim/vim.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
meta/recipes-support/vim/vim.inc +2 -2
index 8a914ae524..f2cd235329 100644
@@ -20,8 +20,8 @@ SRC_URI = "git://github.com/vim/vim.git;branch=master;protocol=https \
            file://no-path-adjust.patch \
            "
 
-PV .= ".0541"
-SRCREV = "ee7c8d999beb847457f768757b1bdcd76391c1f4"
+PV .= ".0598"
+SRCREV = "8279af514ca7e5fd3c31cf13b0864163d1a0bfeb"
 
 # Remove when 8.3 is out
 UPSTREAM_VERSION_UNKNOWN = "1"
Signature · 1 line
2.25.1
#3 lore raw

PATCH 3/3 create-pull-request: don't switch the git remote protocol to git://

In reply to Steve Sakoman

From: Martin Jansa <[email protected]>

Many git repos prefer https:// nowadays and many removed support for git://.

This breaks the script when using github.com even when selected remote is ssh ([email protected]:openembedded/...), it will re-write it to git://
before calling git pull-request causing:

openembedded-core $ scripts/create-pull-request -u github -b jansa/artifacts -o pull-kernel
NOTE: Assuming local branch HEAD, use -l to override.
fatal: unable to connect to github.com:
github.com[0: 140.82.121.3]: errno=Connection timed out

warn: No match for commit ea003bd026aa24bb4c8b7562f44ed6512e921259 found at git://github.com/shr-distribution/oe-core
warn: Are you sure you pushed 'jansa/artifacts' there?
ERROR: git request-pull reported an error

(cherry picked from commit 64c466920b808c35d1ac87b47cf438bc79becea7)
---
 scripts/create-pull-request | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/create-pull-request +1 -1
index 8eefcf63a5..2f91a355b0 100755
@@ -128,7 +128,7 @@ PROTO_RE="[a-z][a-z+]*://"
 GIT_RE="\(^\($PROTO_RE\)\?\)\($USER_RE@\)\?\([^:/]*\)[:/]\(.*\)"
 REMOTE_URL=${REMOTE_URL%.git}
 REMOTE_REPO=$(echo $REMOTE_URL | sed "s#$GIT_RE#\5#")
-REMOTE_URL=$(echo $REMOTE_URL | sed "s#$GIT_RE#git://\4/\5#")
+REMOTE_URL=$(echo $REMOTE_URL | sed "s#$GIT_RE#https://\4/\5#")
 
 if [ -z "$BRANCH" ]; then
 	BRANCH=$(git branch | grep -e "^\* " | cut -d' ' -f2)
Signature · 1 line
2.25.1