Skip to contentSkip to conversation

fix fwnode_irq_get_byname() returnvalue

PATCH Superseded Matti Vaittinen 3 participants 7 messages Oct 25, 2022 – Nov 15, 2022

Subsystems (5)

v2 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

v2 cover fix fwnode_irq_get_byname() returnvalue

The fix fwnode_irq_get_byname() may have returned zero if mapping the IRQ fails. This contradicts the documentation. Furthermore, returning zero or errno on error is unepected and can easily lead to problems like:

int probe(foo)
{
...

	ret = fwnode_irq_get_byname(...);
	if (ret < 0)
		return ret;

...
}

or

int probe(foo)
{
...

	ret = fwnode_irq_get_byname(...);
	if (ret <= 0)
		return ret;

...
}

which are both likely to be wrong. First treats zero as successful call and misses the IRQ mapping failure. Second returns zero from probe even though it detects the IRQ mapping failure correvtly.

Here we change the fwnode_irq_get_byname() to always return a negative errno upon failure. I have also audited following callers:

drivers/i2c/i2c-smbus.c
drivers/iio/accel/adxl355_core.c
drivers/iio/gyro/fxas21002c_core.c
drivers/iio/imu/adis16480.c
drivers/iio/imu/bmi160/bmi160_core.c
drivers/iio/imu/bmi160/bmi160_core.c

and it seems to me these calls will be Ok after the change. The i2c-smbus.c will gain a functional change (bugfix?) as after this patch the probe will return -EINVAL should the IRQ mapping fail. The series will also adjust the return value check for zero to be omitted.

Changelog v1 => v2:
- minor styling

---

Matti Vaittinen (2):
drivers: fwnode: fix fwnode_irq_get_byname()
i2c: i2c-smbus: fwnode_irq_get_byname() return value fix

 drivers/base/property.c | 9 +++++++--
 drivers/i2c/i2c-smbus.c | 2 +-
 2 files changed, 8 insertions(+), 3 deletions(-)

base-commit: 247f34f7b80357943234f93f247a1ae6b6c3a740

Signature · 14 lines
2.37.3


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
#1 lore raw

PATCH v2 1/2 drivers: fwnode: fix fwnode_irq_get_byname()

The fwnode_irq_get_byname() does return 0 upon device-tree IRQ mapping failure. This is contradicting the function documentation and can potentially be a source of errors like:

int probe(...) {
	...

	irq = fwnode_irq_get_byname();
	if (irq <= 0)
		return irq;

	...
}

Here we do correctly check the return value from fwnode_irq_get_byname() but the driver probe will now return success. (There was already one such user in-tree).

Change the fwnode_irq_get_byname() to work as documented and according to the common convention and abd always return a negative errno upon failure.

Fixes ca0acb511c21 ("device property: Add fwnode_irq_get_byname")

---
v1 => v2:
- change check if (!ret) => if (ret == 0), add comment.
- fix drop redundant empty line.

I did a quick audit for the callers at v6.1-rc2:
drivers/i2c/i2c-smbus.c
drivers/iio/accel/adxl355_core.c
drivers/iio/gyro/fxas21002c_core.c
drivers/iio/imu/adis16480.c
drivers/iio/imu/bmi160/bmi160_core.c
drivers/iio/imu/bmi160/bmi160_core.c

I did not spot any errors to be caused by this change. There will be a functional change in i2c-smbus.c as the probe will now return -EINVAL should the IRQ dt-mapping fail. It'd be nice if this was checked to be Ok by the peeps knowing the i2c-smbus :)

---
 drivers/base/property.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
drivers/base/property.c +7 -2
index 4d6278a84868..b4ccc64f7bd2 100644
@@ -964,7 +964,7 @@ EXPORT_SYMBOL(fwnode_irq_get);
  */
 int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name)
 {
-	int index;
+	int index, ret;
 
 	if (!name)
 		return -EINVAL;
@@ -973,7 +973,12 @@ int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name)
 	if (index < 0)
 		return index;
 
-	return fwnode_irq_get(fwnode, index);
+	ret = fwnode_irq_get(fwnode, index);
+	/* We treat mapping errors as invalid case */
+	if (ret == 0)
+		return -EINVAL;
+
+	return ret;
 }
 EXPORT_SYMBOL(fwnode_irq_get_byname);
 
Signature · 14 lines
2.37.3


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
#3 lore raw

PATCH v2 2/2 i2c: i2c-smbus: fwnode_irq_get_byname() return value fix

In reply to Matti Vaittinen

The fwnode_irq_get_byname() was changed to not return 0 upon failure so return value check can be adjusted to reflect the change.

---

Depends on the mentioned return value change which is in patch 1/2. The return value change does also cause a functional change here. Eg. when IRQ mapping fails, the fwnode_irq_get_byname() no longer returns zero. This will cause also the probe here to return nonzero failure. I guess this is desired behaviour.

---
 drivers/i2c/i2c-smbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/i2c-smbus.c +1 -1
index 07c92c8495a3..d0cc4b7903ed 100644
@@ -130,7 +130,7 @@ static int smbalert_probe(struct i2c_client *ara,
 	} else {
 		irq = fwnode_irq_get_byname(dev_fwnode(adapter->dev.parent),
 					    "smbus_alert");
-		if (irq <= 0)
+		if (irq < 0)
 			return irq;
 	}
 
Signature · 14 lines
2.37.3


-- 
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND

~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =] 
#2 lore raw

Re: [PATCH v2 1/2] drivers: fwnode: fix fwnode_irq_get_byname()

In reply to Matti Vaittinen
Quoted 14 lines · Matti Vaittinen

The fwnode_irq_get_byname() does return 0 upon device-tree IRQ mapping failure. This is contradicting the function documentation and can potentially be a source of errors like:

int probe(...) {
	...

	irq = fwnode_irq_get_byname();
	if (irq <= 0)
		return irq;

	...
}
Quoted 6 lines

Here we do correctly check the return value from fwnode_irq_get_byname() but the driver probe will now return success. (There was already one such user in-tree).

Change the fwnode_irq_get_byname() to work as documented and according to the common convention and abd always return a negative errno upon failure.

and abd ?

...

drivers/base/property.c int fwnode_irq_get_byname(const struct fwnode_handle *fwnode, const char *name) · line 981

Quoted 6 lines
drivers/base/property.c +6 -0
+	ret = fwnode_irq_get(fwnode, index);
+	/* We treat mapping errors as invalid case */
+	if (ret == 0)
+		return -EINVAL;
+
+	return ret;

This looks good.

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#4 lore raw

Re: [PATCH v2 2/2] i2c: i2c-smbus: fwnode_irq_get_byname() return value fix

In reply to Matti Vaittinen
Quoted 2 lines · Matti Vaittinen

The fwnode_irq_get_byname() was changed to not return 0 upon failure so return value check can be adjusted to reflect the change.

...

Quoted 5 lines

Depends on the mentioned return value change which is in patch 1/2. The return value change does also cause a functional change here. Eg. when IRQ mapping fails, the fwnode_irq_get_byname() no longer returns zero. This will cause also the probe here to return nonzero failure. I guess this is desired behaviour.

The entire error handling there looks suspicious.

The 'struct i2c_smbus_alert_setup' description says:

"If irq is not specified, the smbus_alert driver doesn't take care of
interrupt handling. In that case it is up to the I2C bus driver to either handle the interrupts or to poll for alerts."

So, the question is, shouldn't we just drop the check completely?

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#5 lore raw

Re: [PATCH v2 2/2] i2c: i2c-smbus: fwnode_irq_get_byname() return value fix

Quoted 14 lines · Andy Shevchenko
Quoted 2 lines · Matti Vaittinen

The fwnode_irq_get_byname() was changed to not return 0 upon failure so return value check can be adjusted to reflect the change.

...

Quoted 5 lines

Depends on the mentioned return value change which is in patch 1/2. The return value change does also cause a functional change here. Eg. when IRQ mapping fails, the fwnode_irq_get_byname() no longer returns zero. This will cause also the probe here to return nonzero failure. I guess this is desired behaviour.

The entire error handling there looks suspicious.

Quoted 7 lines

The 'struct i2c_smbus_alert_setup' description says:

"If irq is not specified, the smbus_alert driver doesn't take care of
interrupt handling. In that case it is up to the I2C bus driver to either handle the interrupts or to poll for alerts."

So, the question is, shouldn't we just drop the check completely?

I don't really know what this means. Does it mean that if IRQ is not provided, the driver needs to take care of alerts (in which case the check here is very valid because IRQ is required for smbus_alert driver). Or does it mean that only the IRQ handling is omitted while the smbus_alert driver should do all the other stuff (what ever that is) as usual. In this case this check indeed feels wrong.

I would appreciate someone with more insight to this driver to take a look at it.

Yours
-- Matti

Signature · 5 lines
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~
#6 lore raw

Re: [PATCH v2 2/2] i2c: i2c-smbus: fwnode_irq_get_byname() return value fix

Quoted 30 lines · Matti Vaittinen
Quoted 14 lines · Andy Shevchenko
Quoted 2 lines · Matti Vaittinen

The fwnode_irq_get_byname() was changed to not return 0 upon failure so return value check can be adjusted to reflect the change.

...

Quoted 5 lines

Depends on the mentioned return value change which is in patch 1/2. The return value change does also cause a functional change here. Eg. when IRQ mapping fails, the fwnode_irq_get_byname() no longer returns zero. This will cause also the probe here to return nonzero failure. I guess this is desired behaviour.

The entire error handling there looks suspicious.

Quoted 7 lines

The 'struct i2c_smbus_alert_setup' description says:

  "If irq is not specified, the smbus_alert driver doesn't take care of interrupt handling. In that case it is up to the I2C bus driver to either handle the interrupts or to poll for alerts."

So, the question is, shouldn't we just drop the check completely?

I don't really know what this means. Does it mean that if IRQ is not provided, the driver needs to take care of alerts (in which case the check here is very valid because IRQ is required for smbus_alert driver). Or does it mean that only the IRQ handling is omitted while the smbus_alert driver should do all the other stuff (what ever that is) as usual. In this case this check indeed feels wrong.

Quoted 2 lines

I would appreciate someone with more insight to this driver to take a look at it.

Wolfram, do you have the required insight?

What would be the best way to proceed? I see 3 options:

1. fix the return value as is done by this series.
https://lore.kernel.org/all/[email protected]/
=> Will cause the i2c-smbus probe to return failure also if IRQ
mapping fails.

2. apply the 1/1 from the series "as is" - but drop the return value check for fwnode_irq_get_byname() altogether as was suggested by Andy

3. drop this series and apply the documentation fix suggested in:
https://lore.kernel.org/all/[email protected]/

Thoughts anyone?

Yours
-- Matti

Signature · 5 lines
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~