Skip to contentSkip to conversation

add python3-brotli_1.0.9 in meta/recipes-devtools/python

PATCH Superseded cp0613 4 participants 7 messages Nov 4, 2022 – Nov 7, 2022 1 message not in the archive

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

cp0613

author
#0 lore raw

cover add python3-brotli_1.0.9 in meta/recipes-devtools/python

The following changes since commit 6050d1f74c02495490d982ead2993b6b3c9cc04a:
are available in the Git repository at:

https://github.com/cp0613/openembedded-core brotli
https://github.com/cp0613/openembedded-core/tree/brotli

cp0613 (1):
add python3-brotli_1.0.9 in meta/recipes-devtools/python

 .../python/python3-brotli_1.0.9.bb            | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-brotli_1.0.9.bb
Signature · 1 line
2.25.1
#2 lore raw
In reply to cp0613

Hello,

Quoted 8 lines · On 04/11/2022 10:02:08+0800, cp0613 wrote:

The following changes since commit 6050d1f74c02495490d982ead2993b6b3c9cc04a:
are available in the Git repository at:

https://github.com/cp0613/openembedded-core brotli
https://github.com/cp0613/openembedded-core/tree/brotli

cp0613 (1):
add python3-brotli_1.0.9 in meta/recipes-devtools/python

This fails on the autobuilders:

The following recipes do not have a HOMEPAGE. Please add an entry for HOMEPAGE in the recipe. python3-brotli (/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/recipes-devtools/python/python3-brotli_1.0.9.bb)

The following recipes do not have a maintainer assigned to them. Please add an entry to meta/conf/distro/include/maintainers.inc file. python3-brotli (/home/pokybuild/yocto-worker/oe-selftest-ubuntu/build/meta/recipes-devtools/python/python3-brotli_1.0.9.bb)

Quoted 18 lines
 .../python/python3-brotli_1.0.9.bb            | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 meta/recipes-devtools/python/python3-brotli_1.0.9.bb
Signature · 11 lines
2.25.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#172658): https://lists.openembedded.org/g/openembedded-core/message/172658
Mute This Topic: https://lists.openembedded.org/mt/94798159/3617179
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
#3 lore raw
In reply to cp0613
Quoted 6 lines · On 4 Nov 2022, at 02:02, cp0613 via lists.openembedded.org…

The following changes since commit 6050d1f74c02495490d982ead2993b6b3c9cc04a:
are available in the Git repository at:

https://github.com/cp0613/openembedded-core brotli
https://github.com/cp0613/openembedded-core/tree/brotli

We take patches sent via git-send-email, so please resend using that.

However, there’s a high bar to getting a python module into oe-core instead of meta-python. Why do you think this module should be in oe-core, and not in meta-python?

Ross

#4 lore raw

+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=941ee9cd1609382f946352712a319b4b”

Relative paths are relative to S, so this can be just file://LICENSE.

+# there is no valid file in pypi, so download from github
+SRC_URI = "http://codeload.github.com/google/brotli/tar.gz/v${PV};downloadfilename=brotli-${PV}.tar.gz” +SRC_URI[sha256sum] = "f9e8d81d0405ba66d181529af42a3354f838c939095ff99930da6aa9cdf6fe46"

That looks like a dynamically generated git archive, which means the checksum will change over time.

If there is no static tarball, use the git: fetcher.

Ross

#5 lore raw
Quoted 11 lines · Ross Burton

+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=941ee9cd1609382f946352712a319b4b”

Relative paths are relative to S, so this can be just file://LICENSE.

(quoted diff) +3 -0
+# there is no valid file in pypi, so download from github
+SRC_URI = "http://codeload.github.com/google/brotli/tar.gz/v${PV};downloadfilename=brotli-${PV}.tar.gz”
+SRC_URI[sha256sum] = "f9e8d81d0405ba66d181529af42a3354f838c939095ff99930da6aa9cdf6fe46"

That looks like a dynamically generated git archive, which means the checksum will change over time.

If there is no static tarball, use the git: fetcher.

There is:
https://pypi.org/project/Brotli/#files

You just need to set the filename suffix correctly (pypi class has a facility for it) so it doesn't try to fetch with the default suffix.

Alex

#7 lore raw

Re: Private: Re: [OE-core] [PATCH 0/1] add python3-brotli_1.0.9 in meta/recipes-devtools/python

In reply to a message not in the archive

Re-adding oe-core to the CC as this discussion should be on the list.

I suggest you add the recipe to meta-python then.

Ross

Quoted 5 lines · On 5 Nov 2022, at 07:58, cp0613 <[email protected]> wrote:

Thanks. This is my first submission and there may be some operation is wrong. I will continue to try git-send-email.

The reason for using python3-brotli is that this library is dependent on many other projects. However, it cannot be installed directly through pip3 on the RISCV platform. Therefore, we use yocto to compile it. We find that many python bb are here, so we add them here.