drm/i915: GMCH refactoring
Subsystems (3)
PATCH 2/4 drm/i915/gmch: split out soc/intel_gmch
In reply to Jani NikulaThe GMCH related code is a bit too low level and out of place for the high level i915_driver.c file. Split out to a separate file under soc/. Rename the functions accordingly.
--- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_driver.c | 145 +------------------------- drivers/gpu/drm/i915/soc/intel_gmch.c | 145 ++++++++++++++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 15 +++ 4 files changed, 166 insertions(+), 140 deletions(-) create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.h
drivers/gpu/drm/i915/Makefile +1 -0
@@ -63,6 +63,7 @@ i915-y += i915_driver.o \ # core peripheral code i915-y += \ soc/intel_dram.o \ + soc/intel_gmch.o \ soc/intel_pch.o # core library code
drivers/gpu/drm/i915/i915_driver.c +5 -140
187 lines not on this page · raw message
drivers/gpu/drm/i915/soc/intel_gmch.c new file +145 -0
145 lines not on this page · raw message
drivers/gpu/drm/i915/soc/intel_gmch.h new file +15 -0
@@ -0,0 +1,15 @@ +/* SPDX-License-Identifier: MIT */ +/* +* Copyright © 2023 Intel Corporation +*/ + +#ifndef __INTEL_GMCH_H__ +#define __INTEL_GMCH_H__ + +struct drm_i915_private ; + +int intel_gmch_bridge_setup (struct drm_i915_private *i915); +void intel_gmch_bar_setup (struct drm_i915_private *i915); +void intel_gmch_bar_teardown (struct drm_i915_private *i915); + +#endif /* __INTEL_GMCH_H__ */
Signature · 1 line
2.34.1
PATCH 3/4 drm/i915/gmch: mass rename dev_priv to i915
In reply to Jani NikulaPrefer the contemporary naming.
--- drivers/gpu/drm/i915/soc/intel_gmch.c | 95 +++++++++++++-------------- 1 file changed, 47 insertions(+), 48 deletions(-)
drivers/gpu/drm/i915/soc/intel_gmch.c +47 -48
@@ -17,33 +17,32 @@ static void intel_gmch_bridge_release(struct drm_device *dev, void *bridge)pci_dev_put (bridge); } -int intel_gmch_bridge_setup (struct drm_i915_private *dev_priv) +int intel_gmch_bridge_setup (struct drm_i915_private *i915) { -int domain =pci_domain_nr (to_pci_dev (dev_priv->drm.dev)->bus); +int domain =pci_domain_nr (to_pci_dev (i915->drm.dev)->bus); - dev_priv->gmch.pdev = -pci_get_domain_bus_and_slot (domain,0 ,PCI_DEVFN (0 ,0 )); -if (!dev_priv->gmch.pdev) { -drm_err (&dev_priv->drm,"bridge device not found\n" ); + i915->gmch.pdev =pci_get_domain_bus_and_slot (domain,0 ,PCI_DEVFN (0 ,0 )); +if (!i915->gmch.pdev) { +drm_err (&i915->drm,"bridge device not found\n" );return -EIO ; } -return drmm_add_action_or_reset (&dev_priv->drm, intel_gmch_bridge_release, - dev_priv->gmch.pdev); +return drmm_add_action_or_reset (&i915->drm, intel_gmch_bridge_release, + i915->gmch.pdev); }/* Allocate space for the MCH regs if needed, return nonzero on error */ static int -intel_alloc_mchbar_resource (struct drm_i915_private *dev_priv) +intel_alloc_mchbar_resource (struct drm_i915_private *i915) { -int reg =GRAPHICS_VER (dev_priv) >=4 ?MCHBAR_I965 :MCHBAR_I915 ; +int reg =GRAPHICS_VER (i915) >=4 ?MCHBAR_I965 :MCHBAR_I915 ;u32 temp_lo, temp_hi =0 ;u64 mchbar_addr;int ret; -if (GRAPHICS_VER (dev_priv) >=4 ) -pci_read_config_dword (dev_priv->gmch.pdev, reg +4 , &temp_hi); -pci_read_config_dword (dev_priv->gmch.pdev, reg, &temp_lo); +if (GRAPHICS_VER (i915) >=4 ) +pci_read_config_dword (i915->gmch.pdev, reg +4 , &temp_hi); +pci_read_config_dword (i915->gmch.pdev, reg, &temp_lo); mchbar_addr = ((u64 )temp_hi <<32 ) | temp_lo;/* If ACPI doesn't have it, assume we need to allocate it ourselves */
@@ -54,46 +53,46 @@ intel_alloc_mchbar_resource(struct drm_i915_private *dev_priv)#endif /* Get some space for it */ - dev_priv->gmch.mch_res.name ="i915 MCHBAR" ; - dev_priv->gmch.mch_res.flags =IORESOURCE_MEM ; - ret =pci_bus_alloc_resource (dev_priv->gmch.pdev->bus, - &dev_priv->gmch.mch_res, + i915->gmch.mch_res.name ="i915 MCHBAR" ; + i915->gmch.mch_res.flags =IORESOURCE_MEM ; + ret =pci_bus_alloc_resource (i915->gmch.pdev->bus, + &i915->gmch.mch_res,MCHBAR_SIZE ,MCHBAR_SIZE ,PCIBIOS_MIN_MEM ,0 , pcibios_align_resource, - dev_priv->gmch.pdev); + i915->gmch.pdev);if (ret) { -drm_dbg (&dev_priv->drm,"failed bus alloc: %d\n" , ret); - dev_priv->gmch.mch_res.start =0 ; +drm_dbg (&i915->drm,"failed bus alloc: %d\n" , ret); + i915->gmch.mch_res.start =0 ;return ret; } -if (GRAPHICS_VER (dev_priv) >=4 ) -pci_write_config_dword (dev_priv->gmch.pdev, reg +4 , -upper_32_bits (dev_priv->gmch.mch_res.start)); +if (GRAPHICS_VER (i915) >=4 ) +pci_write_config_dword (i915->gmch.pdev, reg +4 , +upper_32_bits (i915->gmch.mch_res.start)); -pci_write_config_dword (dev_priv->gmch.pdev, reg, -lower_32_bits (dev_priv->gmch.mch_res.start)); +pci_write_config_dword (i915->gmch.pdev, reg, +lower_32_bits (i915->gmch.mch_res.start));return 0 ; }/* Setup MCHBAR if possible, return true if we should disable it again */ -void intel_gmch_bar_setup (struct drm_i915_private *dev_priv) +void intel_gmch_bar_setup (struct drm_i915_private *i915) { -int mchbar_reg =GRAPHICS_VER (dev_priv) >=4 ?MCHBAR_I965 :MCHBAR_I915 ; +int mchbar_reg =GRAPHICS_VER (i915) >=4 ?MCHBAR_I965 :MCHBAR_I915 ;u32 temp;bool enabled; -if (IS_VALLEYVIEW (dev_priv) ||IS_CHERRYVIEW (dev_priv)) +if (IS_VALLEYVIEW (i915) ||IS_CHERRYVIEW (i915))return ; - dev_priv->gmch.mchbar_need_disable = false; + i915->gmch.mchbar_need_disable = false; -if (IS_I915G (dev_priv) ||IS_I915GM (dev_priv)) { -pci_read_config_dword (dev_priv->gmch.pdev,DEVEN , &temp); +if (IS_I915G (i915) ||IS_I915GM (i915)) { +pci_read_config_dword (i915->gmch.pdev,DEVEN , &temp); enabled = !!(temp &DEVEN_MCHBAR_EN ); }else { -pci_read_config_dword (dev_priv->gmch.pdev, mchbar_reg, &temp); +pci_read_config_dword (i915->gmch.pdev, mchbar_reg, &temp); enabled = temp &1 ; }
@@ -101,45 +100,45 @@ void intel_gmch_bar_setup(struct drm_i915_private *dev_priv)if (enabled)return ; -if (intel_alloc_mchbar_resource (dev_priv)) +if (intel_alloc_mchbar_resource (i915))return ; - dev_priv->gmch.mchbar_need_disable = true; + i915->gmch.mchbar_need_disable = true;/* Space is allocated or reserved, so enable it. */ -if (IS_I915G (dev_priv) ||IS_I915GM (dev_priv)) { -pci_write_config_dword (dev_priv->gmch.pdev,DEVEN , +if (IS_I915G (i915) ||IS_I915GM (i915)) { +pci_write_config_dword (i915->gmch.pdev,DEVEN , temp |DEVEN_MCHBAR_EN ); }else { -pci_read_config_dword (dev_priv->gmch.pdev, mchbar_reg, &temp); -pci_write_config_dword (dev_priv->gmch.pdev, mchbar_reg, temp |1 ); +pci_read_config_dword (i915->gmch.pdev, mchbar_reg, &temp); +pci_write_config_dword (i915->gmch.pdev, mchbar_reg, temp |1 ); } } -void intel_gmch_bar_teardown (struct drm_i915_private *dev_priv) +void intel_gmch_bar_teardown (struct drm_i915_private *i915) { -int mchbar_reg =GRAPHICS_VER (dev_priv) >=4 ?MCHBAR_I965 :MCHBAR_I915 ; +int mchbar_reg =GRAPHICS_VER (i915) >=4 ?MCHBAR_I965 :MCHBAR_I915 ; -if (dev_priv->gmch.mchbar_need_disable) { -if (IS_I915G (dev_priv) ||IS_I915GM (dev_priv)) { +if (i915->gmch.mchbar_need_disable) { +if (IS_I915G (i915) ||IS_I915GM (i915)) {u32 deven_val; -pci_read_config_dword (dev_priv->gmch.pdev,DEVEN , +pci_read_config_dword (i915->gmch.pdev,DEVEN , &deven_val); deven_val &= ~DEVEN_MCHBAR_EN ; -pci_write_config_dword (dev_priv->gmch.pdev,DEVEN , +pci_write_config_dword (i915->gmch.pdev,DEVEN , deven_val); }else {u32 mchbar_val; -pci_read_config_dword (dev_priv->gmch.pdev, mchbar_reg, +pci_read_config_dword (i915->gmch.pdev, mchbar_reg, &mchbar_val); mchbar_val &= ~1 ; -pci_write_config_dword (dev_priv->gmch.pdev, mchbar_reg, +pci_write_config_dword (i915->gmch.pdev, mchbar_reg, mchbar_val); } } -if (dev_priv->gmch.mch_res.start) -release_resource (&dev_priv->gmch.mch_res); +if (i915->gmch.mch_res.start) +release_resource (&i915->gmch.mch_res); }
Signature · 1 line
2.34.1
PATCH 4/4 drm/i915/gmch: move VGA set state to GMCH code
In reply to Jani NikulaThis is the only user for the GMCH bridge device in display. Move it to GMCH code.
--- drivers/gpu/drm/i915/display/intel_vga.c | 32 +++--------------------- drivers/gpu/drm/i915/soc/intel_gmch.c | 27 ++++++++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 3 +++ 3 files changed, 33 insertions(+), 29 deletions(-)
drivers/gpu/drm/i915/display/intel_vga.c +3 -29
@@ -6,9 +6,10 @@#include <linux/pci.h> #include <linux/vgaarb.h> -#include <drm/i915_drm.h> #include <video/vga.h> +#include "soc/intel_gmch.h" +#include "i915_drv.h" #include "i915_reg.h" #include "intel_de.h"
@@ -98,39 +99,12 @@ void intel_vga_reset_io_mem(struct drm_i915_private *i915)vga_put (pdev,VGA_RSRC_LEGACY_IO ); } -static int -intel_vga_set_state (struct drm_i915_private *i915,bool enable_decode) -{ -unsigned int reg =DISPLAY_VER (i915) >=6 ?SNB_GMCH_CTRL :INTEL_GMCH_CTRL ; -u16 gmch_ctrl; - -if (pci_read_config_word (i915->gmch.pdev, reg, &gmch_ctrl)) { -drm_err (&i915->drm,"failed to read control word\n" ); -return -EIO ; - } - -if (!!(gmch_ctrl &INTEL_GMCH_VGA_DISABLE ) == !enable_decode) -return 0 ; - -if (enable_decode) - gmch_ctrl &= ~INTEL_GMCH_VGA_DISABLE ; -else - gmch_ctrl |=INTEL_GMCH_VGA_DISABLE ; - -if (pci_write_config_word (i915->gmch.pdev, reg, gmch_ctrl)) { -drm_err (&i915->drm,"failed to write control word\n" ); -return -EIO ; - } - -return 0 ; -} -static unsigned int intel_vga_set_decode (struct pci_dev *pdev,bool enable_decode) {struct drm_i915_private *i915 =pdev_to_i915 (pdev); -intel_vga_set_state (i915, enable_decode); +intel_gmch_vga_set_state (i915, enable_decode);if (enable_decode) return VGA_RSRC_LEGACY_IO | VGA_RSRC_LEGACY_MEM |
drivers/gpu/drm/i915/soc/intel_gmch.c +27 -0
@@ -7,6 +7,7 @@#include <linux/pnp.h> #include <drm/drm_managed.h> +#include <drm/i915_drm.h> #include "i915_drv.h" #include "intel_gmch.h"
@@ -142,3 +143,29 @@ void intel_gmch_bar_teardown(struct drm_i915_private *i915)if (i915->gmch.mch_res.start)release_resource (&i915->gmch.mch_res); } + +int intel_gmch_vga_set_state (struct drm_i915_private *i915,bool enable_decode) +{ +unsigned int reg =DISPLAY_VER (i915) >=6 ?SNB_GMCH_CTRL :INTEL_GMCH_CTRL ; +u16 gmch_ctrl; + +if (pci_read_config_word (i915->gmch.pdev, reg, &gmch_ctrl)) { +drm_err (&i915->drm,"failed to read control word\n" ); +return -EIO ; + } + +if (!!(gmch_ctrl &INTEL_GMCH_VGA_DISABLE ) == !enable_decode) +return 0 ; + +if (enable_decode) + gmch_ctrl &= ~INTEL_GMCH_VGA_DISABLE ; +else + gmch_ctrl |=INTEL_GMCH_VGA_DISABLE ; + +if (pci_write_config_word (i915->gmch.pdev, reg, gmch_ctrl)) { +drm_err (&i915->drm,"failed to write control word\n" ); +return -EIO ; + } + +return 0 ; +}
drivers/gpu/drm/i915/soc/intel_gmch.h +3 -0
@@ -6,10 +6,13 @@#ifndef __INTEL_GMCH_H__#define __INTEL_GMCH_H__ +#include <linux/types.h> +struct drm_i915_private ;int intel_gmch_bridge_setup (struct drm_i915_private *i915);void intel_gmch_bar_setup (struct drm_i915_private *i915);void intel_gmch_bar_teardown (struct drm_i915_private *i915); +int intel_gmch_vga_set_state (struct drm_i915_private *i915,bool enable_decode);#endif /* __INTEL_GMCH_H__ */
Signature · 1 line
2.34.1
cover drm/i915: GMCH refactoring
Let's see if this sticks.
Jani Nikula (4):
drm/i915: add gmch substruct to struct drm_i915_private drm/i915/gmch: split out soc/intel_gmch drm/i915/gmch: mass rename dev_priv to i915 drm/i915/gmch: move VGA set state to GMCH code
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_vga.c | 32 +--- drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 145 +----------------- drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/soc/intel_gmch.c | 171 ++++++++++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 18 +++ 7 files changed, 204 insertions(+), 175 deletions(-) create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.h
Signature · 1 line
2.34.1
PATCH 1/4 drm/i915: add gmch substruct to struct drm_i915_private
Group the GMCH related members together.
--- drivers/gpu/drm/i915/display/intel_vga.c | 4 +- drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 58 +++++++++++------------ drivers/gpu/drm/i915/i915_drv.h | 10 ++-- 4 files changed, 37 insertions(+), 37 deletions(-)
drivers/gpu/drm/i915/display/intel_vga.c +2 -2
@@ -104,7 +104,7 @@ intel_vga_set_state(struct drm_i915_private *i915, bool enable_decode)unsigned int reg =DISPLAY_VER (i915) >=6 ?SNB_GMCH_CTRL :INTEL_GMCH_CTRL ;u16 gmch_ctrl; -if (pci_read_config_word (i915->bridge_dev, reg, &gmch_ctrl)) { +if (pci_read_config_word (i915->gmch.pdev, reg, &gmch_ctrl)) {drm_err (&i915->drm,"failed to read control word\n" );return -EIO ; }
@@ -117,7 +117,7 @@ intel_vga_set_state(struct drm_i915_private *i915, bool enable_decode)else gmch_ctrl |=INTEL_GMCH_VGA_DISABLE ; -if (pci_write_config_word (i915->bridge_dev, reg, gmch_ctrl)) { +if (pci_write_config_word (i915->gmch.pdev, reg, gmch_ctrl)) {drm_err (&i915->drm,"failed to write control word\n" );return -EIO ; }
drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c +1 -1
@@ -81,7 +81,7 @@ int intel_ggtt_gmch_probe(struct i915_ggtt *ggtt)phys_addr_t gmadr_base;int ret; - ret =intel_gmch_probe (i915->bridge_dev,to_pci_dev (i915->drm.dev),NULL ); + ret =intel_gmch_probe (i915->gmch.pdev,to_pci_dev (i915->drm.dev),NULL );if (!ret) {drm_err (&i915->drm,"failed to set up gmch\n" );return -EIO ;
drivers/gpu/drm/i915/i915_driver.c +29 -29
134 lines not on this page · raw message
drivers/gpu/drm/i915/i915_drv.h +5 -5
@@ -236,13 +236,15 @@ struct drm_i915_private {struct intel_gvt *gvt; -struct pci_dev *bridge_dev; +struct { +struct pci_dev *pdev; +struct resource mch_res; +bool mchbar_need_disable; + } gmch;struct rb_root uabi_engines;unsigned int engine_uabi_class_count[I915_LAST_UABI_ENGINE_CLASS +1 ]; -struct resource mch_res; -/* protects the irq masks */ spinlock_t irq_lock;
@@ -288,8 +290,6 @@ struct drm_i915_private {struct i915_gem_mm mm; -bool mchbar_need_disable; -struct intel_l3_parity l3_parity;/*
Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: GMCH refactoring
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: GMCH refactoring
URL : https://patchwork.freedesktop.org/series/112929/
State : warning
== Summary ==
Error: dim checkpatch failedf3652809952f drm/i915: add gmch substruct to struct drm_i915_privatea0209e099f2c drm/i915/gmch: split out soc/intel_gmch
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
-:223: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #223:
new file mode 100644
total: 0 errors, 1 warnings, 0 checks, 354 lines checked 5970e23a00b1 drm/i915/gmch: mass rename dev_priv to i915 ea0fced4d047 drm/i915/gmch: move VGA set state to GMCH code
Patchwork
CI[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: GMCH refactoring
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: GMCH refactoring
URL : https://patchwork.freedesktop.org/series/112929/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12590 -> Patchwork_112929v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_112929v1 absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_112929v1, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/index.html
Participating hosts (42 -> 44)
------------------------------
Additional (3): fi-kbl-soraka fi-rkl-11600 fi-bsw-kefka
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_112929v1:
### IGT changes ###
#### Possible regressions ####
* igt@i915_module_load@load:
- fi-ctg-p8600: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12590/fi-ctg-p8600/igt@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-ctg-p8600/igt@[email protected]
New tests
---------
New tests have been introduced between CI_DRM_12590 and Patchwork_112929v1:
### New IGT tests (1) ###
* igt@gem_softpin@safe-alignment:
- Statuses : 43 pass(s)
- Exec time: [0.0] s
Known issues
------------
Here are the changes found in Patchwork_112929v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@gem_exec_gttfill@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271]) +15 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-kbl-soraka/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-kbl-soraka: NOTRUN -> [SKIP][5] ([fdo#109271] / [i915#2190])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-kbl-soraka/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#2190])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-kbl-soraka: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#4613]) +3 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-kbl-soraka/igt@[email protected]
- fi-rkl-11600: NOTRUN -> [SKIP][8] ([i915#4613]) +3 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][9] ([i915#3282])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][10] ([i915#7561])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][11] ([i915#1886])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@ring_submission:
- fi-kbl-soraka: NOTRUN -> [INCOMPLETE][12] ([i915#7640])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-kbl-soraka/igt@i915_selftest@live@ring_submission.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][13] ([i915#4817])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@kms_chamelium_hpd@common-hpd-after-suspend:
- bat-dg1-6: NOTRUN -> [SKIP][14] ([i915#7828])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/bat-dg1-6/igt@[email protected]
* igt@kms_chamelium_hpd@dp-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#7828]) +7 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([i915#4103])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][17] ([fdo#109285] / [i915#4098])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][18] ([i915#1072]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][19] ([i915#3555] / [i915#4098])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-fence-flip:
- fi-bsw-kefka: NOTRUN -> [SKIP][20] ([fdo#109271]) +26 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-bsw-kefka/igt@[email protected]
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][21] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][22] ([fdo#109295] / [i915#3301] / [i915#3708])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-rkl-11600/igt@[email protected]
#### Possible fixes ####
* igt@gem_exec_gttfill@basic:
- fi-pnv-d510: [FAIL][23] ([i915#7229]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12590/fi-pnv-d510/igt@[email protected]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/fi-pnv-d510/igt@[email protected]
* igt@i915_selftest@live@hangcheck:
- bat-dg1-6: [INCOMPLETE][25] ([i915#4983]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12590/bat-dg1-6/igt@i915_selftest@[email protected]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/bat-dg1-6/igt@i915_selftest@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#6257]: https://gitlab.freedesktop.org/drm/intel/issues/6257
[i915#7229]: https://gitlab.freedesktop.org/drm/intel/issues/7229
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7640]: https://gitlab.freedesktop.org/drm/intel/issues/7640
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12590 -> Patchwork_112929v1
CI-20190529: 20190529
CI_DRM_12590: aa9844e5dcac30f3b7c09fa0218516692698f0e2 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7121: aa16e81259f59734230d441905b9d0f605e4a4b5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112929v1: aa9844e5dcac30f3b7c09fa0218516692698f0e2 @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
2701ca13ad07 drm/i915/gmch: move VGA set state to GMCH code fea812d0fc2b drm/i915/gmch: mass rename dev_priv to i915 059561d02c61 drm/i915/gmch: split out soc/intel_gmch 3c7264678713 drm/i915: add gmch substruct to struct drm_i915_private
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v1/index.html
Quoted 1 line · Jani Nikula
Let's see if this sticks.
Suddenly all of these 'bridge_dev' makes some sense to me.
I believe we could enjoy the refactor here and add some documentation about this... at least the name Graphics Memory Controller Hub name...
I also wonder if we should make this a child device now that it is really organized...
But anyway, everything can be a follow up, the current refactor is already a very good clean up step, so for the series:
Quoted 21 lines
Jani Nikula (4):
drm/i915: add gmch substruct to structdrm_i915_privatedrm/i915/gmch: split out soc/intel_gmch drm/i915/gmch: mass renamedev_privto i915 drm/i915/gmch: move VGA set state to GMCH codedrivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_vga.c | 32 +--- drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 145 +----------------- drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/soc/intel_gmch.c | 171 ++++++++++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 18 +++ 7 files changed, 204 insertions(+), 175 deletions(-) create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.hSignature · 1 line
2.34.1
Quoted 7 lines · Jani Nikula
Let's see if this sticks.
Jani Nikula (4):
drm/i915: add gmch substruct to structdrm_i915_privatedrm/i915/gmch: split out soc/intel_gmch drm/i915/gmch: mass renamedev_privto i915 drm/i915/gmch: move VGA set state to GMCH code
My main worry with this name would be confusion with HAS_GMCH().
Quoted 14 lines
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_vga.c | 32 +--- drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 145 +----------------- drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/soc/intel_gmch.c | 171 ++++++++++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 18 +++ 7 files changed, 204 insertions(+), 175 deletions(-) create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.hSignature · 1 line
2.34.1
Signature · 2 lines
Ville Syrjälä Intel
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: GMCH refactoring (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: GMCH refactoring (rev2)
URL : https://patchwork.freedesktop.org/series/112929/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: GMCH refactoring (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: GMCH refactoring (rev2)
URL : https://patchwork.freedesktop.org/series/112929/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12592 -> Patchwork_112929v2
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/index.html
Participating hosts (44 -> 44)
------------------------------
Additional (1): fi-rkl-11600
Missing (1): fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_112929v2:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@gem_exec_suspend@basic-s0@smem:
- {bat-rpls-1}: [DMESG-WARN][1] ([i915#7625]) -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/bat-rpls-1/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/bat-rpls-1/igt@gem_exec_suspend@[email protected]
Known issues
------------
Here are the changes found in Patchwork_112929v2 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- fi-rkl-11600: NOTRUN -> [SKIP][3] ([i915#7456])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@gem_huc_copy@huc-copy:
- fi-rkl-11600: NOTRUN -> [SKIP][4] ([i915#2190])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@gem_lmem_swapping@basic:
- fi-rkl-11600: NOTRUN -> [SKIP][5] ([i915#4613]) +3 similar issues
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@gem_tiled_pread_basic:
- fi-rkl-11600: NOTRUN -> [SKIP][6] ([i915#3282])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-rkl-11600: NOTRUN -> [SKIP][7] ([i915#7561])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][8] -> [DMESG-FAIL][9] ([i915#5334])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_suspend@basic-s3-without-i915:
- fi-rkl-11600: NOTRUN -> [INCOMPLETE][10] ([i915#4817])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@kms_chamelium_hpd@dp-hpd-fast:
- fi-rkl-11600: NOTRUN -> [SKIP][11] ([i915#7828]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor:
- fi-rkl-11600: NOTRUN -> [SKIP][12] ([i915#4103])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@kms_force_connector_basic@force-load-detect:
- fi-rkl-11600: NOTRUN -> [SKIP][13] ([fdo#109285] / [i915#4098])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@kms_psr@primary_page_flip:
- fi-rkl-11600: NOTRUN -> [SKIP][14] ([i915#1072]) +3 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@kms_psr@primary_page_flip.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-rkl-11600: NOTRUN -> [SKIP][15] ([i915#3555] / [i915#4098])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-read:
- fi-rkl-11600: NOTRUN -> [SKIP][16] ([fdo#109295] / [i915#3291] / [i915#3708]) +2 similar issues
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
* igt@prime_vgem@basic-userptr:
- fi-rkl-11600: NOTRUN -> [SKIP][17] ([fdo#109295] / [i915#3301] / [i915#3708])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/fi-rkl-11600/igt@[email protected]
#### Possible fixes ####
* igt@i915_module_load@load:
- {bat-dg2-8}: [FAIL][18] -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/bat-dg2-8/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/bat-dg2-8/igt@[email protected]
* igt@i915_selftest@live@slpc:
- {bat-rpls-1}: [DMESG-FAIL][20] ([i915#6367]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/bat-rpls-1/igt@i915_selftest@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/bat-rpls-1/igt@i915_selftest@[email protected]
* igt@i915_suspend@basic-s3-without-i915:
- {bat-adlm-1}: [DMESG-WARN][22] -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/bat-adlm-1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/bat-adlm-1/igt@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4817]: https://gitlab.freedesktop.org/drm/intel/issues/4817
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7625]: https://gitlab.freedesktop.org/drm/intel/issues/7625
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
Build changes
-------------
* Linux: CI_DRM_12592 -> Patchwork_112929v2
CI-20190529: 20190529
CI_DRM_12592: aa316f18737ff65f416f94aa98ed38d6a073582c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7121: aa16e81259f59734230d441905b9d0f605e4a4b5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112929v2: aa316f18737ff65f416f94aa98ed38d6a073582c @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5f652488403d drm/i915/gmch: move VGA set state to GMCH code 4f7c67b69def drm/i915/gmch: mass rename dev_priv to i915 089e79b579f8 drm/i915/gmch: split out soc/intel_gmch 2feda9a33755 drm/i915: add gmch substruct to struct drm_i915_private
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/index.html
Patchwork
CI[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: GMCH refactoring (rev2)
In reply to Jani Nikula== Series Details ==
== Series Details ==
Series: drm/i915: GMCH refactoring (rev2)
URL : https://patchwork.freedesktop.org/series/112929/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12592_full -> Patchwork_112929v2_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/index.html
Participating hosts (13 -> 11)
------------------------------
Additional (1): shard-rkl0
Missing (3): pig-skl-6260u pig-kbl-iris pig-glk-j5005
Known issues
------------
Here are the changes found in Patchwork_112929v2_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [PASS][1] -> [FAIL][2] ([i915#2842]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-glk2/igt@gem_exec_fair@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-glk4/igt@gem_exec_fair@[email protected]
* igt@gem_exec_whisper@basic-queues-priority-all:
- shard-glk: [PASS][3] -> [DMESG-WARN][4] ([i915#118])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-glk4/igt@[email protected]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-glk3/igt@[email protected]
* igt@kms_cursor_legacy@flip-vs-cursor@atomic-transitions:
- shard-glk: [PASS][5] -> [FAIL][6] ([i915#2346])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-glk6/igt@kms_cursor_legacy@[email protected]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-glk5/igt@kms_cursor_legacy@[email protected]
* igt@kms_dither@fb-8bpc-vs-panel-6bpc@pipe-a-hdmi-a-1:
- shard-glk: NOTRUN -> [SKIP][7] ([fdo#109271])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-glk2/igt@kms_dither@[email protected]
* igt@kms_flip@2x-flip-vs-expired-vblank@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][8] -> [FAIL][9] ([i915#79])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-glk1/igt@kms_flip@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-glk9/igt@kms_flip@[email protected]
#### Possible fixes ####
* igt@fbdev@unaligned-write:
- {shard-rkl}: [SKIP][10] ([i915#2582]) -> [PASS][11]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-5/igt@[email protected]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-6/igt@[email protected]
* igt@gem_ctx_exec@basic-nohangcheck:
- {shard-rkl}: [FAIL][12] ([i915#6268]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-6/igt@[email protected]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-5/igt@[email protected]
* igt@gem_eio@suspend:
- {shard-rkl}: [FAIL][14] ([i915#7052]) -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-4/igt@[email protected]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-1/igt@[email protected]
* igt@gem_exec_fair@basic-none-share@rcs0:
- {shard-rkl}: [FAIL][16] ([i915#2842]) -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-6/igt@gem_exec_fair@[email protected]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-5/igt@gem_exec_fair@[email protected]
* igt@gem_exec_reloc@basic-wc-read-noreloc:
- {shard-rkl}: [SKIP][18] ([i915#3281]) -> [PASS][19] +9 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-1/igt@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-5/igt@[email protected]
* igt@gem_partial_pwrite_pread@writes-after-reads:
- {shard-rkl}: [SKIP][20] ([i915#3282]) -> [PASS][21] +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-3/igt@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-5/igt@[email protected]
* igt@gen9_exec_parse@valid-registers:
- {shard-rkl}: [SKIP][22] ([i915#2527]) -> [PASS][23] +1 similar issue
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-1/igt@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-5/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- {shard-rkl}: [SKIP][24] ([i915#3361]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-5/igt@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-4/igt@[email protected]
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- {shard-dg1}: [FAIL][26] ([i915#3591]) -> [PASS][27]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-dg1-15/igt@i915_pm_rc6_residency@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-dg1-19/igt@i915_pm_rc6_residency@[email protected]
* igt@i915_pm_rpm@system-suspend-execbuf:
- {shard-rkl}: [FAIL][28] ([fdo#103375]) -> [PASS][29]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-4/igt@[email protected]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-1/igt@[email protected]
* igt@i915_pm_sseu@full-enable:
- {shard-rkl}: [SKIP][30] ([i915#4387]) -> [PASS][31]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-6/igt@[email protected]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-5/igt@[email protected]
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- {shard-rkl}: [SKIP][32] ([i915#1849] / [i915#4098]) -> [PASS][33] +12 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-3/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_plane@plane-position-hole@pipe-b-planes:
- {shard-rkl}: [SKIP][34] ([i915#1849]) -> [PASS][35] +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-3/igt@kms_plane@[email protected]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-6/igt@kms_plane@[email protected]
* igt@kms_psr@primary_mmap_gtt:
- {shard-rkl}: [SKIP][36] ([i915#1072]) -> [PASS][37]
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-3/igt@kms_psr@primary_mmap_gtt.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-6/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr_stress_test@invalidate-primary-flip-overlay:
- {shard-rkl}: [SKIP][38] ([i915#5461]) -> [PASS][39]
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-3/igt@[email protected]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-6/igt@[email protected]
* igt@kms_rotation_crc@exhaust-fences:
- {shard-rkl}: [SKIP][40] ([i915#1845] / [i915#4098]) -> [PASS][41] +23 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-5/igt@[email protected]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-6/igt@[email protected]
* igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b:
- {shard-rkl}: [SKIP][42] ([i915#4098]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-rkl-5/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-rkl-6/igt@kms_universal_plane@universal-plane-pageflip-windowed-pipe-b.html
* igt@sysfs_heartbeat_interval@mixed@vecs0:
- shard-glk: [FAIL][44] ([i915#1731]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-glk8/igt@sysfs_heartbeat_interval@[email protected]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-glk2/igt@sysfs_heartbeat_interval@[email protected]
* igt@sysfs_heartbeat_interval@precise@vcs1:
- {shard-dg1}: [FAIL][46] ([i915#1755]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12592/shard-dg1-17/igt@sysfs_heartbeat_interval@[email protected]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/shard-dg1-14/igt@sysfs_heartbeat_interval@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1731]: https://gitlab.freedesktop.org/drm/intel/issues/1731
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2532]: https://gitlab.freedesktop.org/drm/intel/issues/2532
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#2920]: https://gitlab.freedesktop.org/drm/intel/issues/2920
[i915#2994]: https://gitlab.freedesktop.org/drm/intel/issues/2994
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3547]: https://gitlab.freedesktop.org/drm/intel/issues/3547
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4767]: https://gitlab.freedesktop.org/drm/intel/issues/4767
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#5327]: https://gitlab.freedesktop.org/drm/intel/issues/5327
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5784]: https://gitlab.freedesktop.org/drm/intel/issues/5784
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6268]: https://gitlab.freedesktop.org/drm/intel/issues/6268
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7052]: https://gitlab.freedesktop.org/drm/intel/issues/7052
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7582]: https://gitlab.freedesktop.org/drm/intel/issues/7582
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
Build changes
-------------
* Linux: CI_DRM_12592 -> Patchwork_112929v2
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_12592: aa316f18737ff65f416f94aa98ed38d6a073582c @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7121: aa16e81259f59734230d441905b9d0f605e4a4b5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_112929v2: aa316f18737ff65f416f94aa98ed38d6a073582c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_112929v2/index.html
Quoted 10 lines · Ville Syrjälä
Quoted 7 lines · Jani Nikula
Let's see if this sticks.
Jani Nikula (4):
drm/i915: add gmch substruct to structdrm_i915_privatedrm/i915/gmch: split out soc/intel_gmch drm/i915/gmch: mass renamedev_privto i915 drm/i915/gmch: move VGA set state to GMCH codeMy main worry with this name would be confusion with
HAS_GMCH().
I know.
Give me a better name, and I'll go with it. I just couldn't think of anything more appropriate.
I guess this somewhat goes back to the HAS_GMCH_DISPLAY -> HAS_GMCH rename.
BR,
Jani.
Quoted 15 lines
Quoted 15 lines
drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_vga.c | 32 +--- drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 145 +----------------- drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/soc/intel_gmch.c | 171 ++++++++++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 18 +++ 7 files changed, 204 insertions(+), 175 deletions(-) create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.hSignature · 1 line
2.34.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
Quoted 8 lines · Rodrigo Vivi
Quoted 1 line · Jani Nikula
Let's see if this sticks.
Suddenly all of these '
bridge_dev' makes some sense to me.I believe we could enjoy the refactor here and add some documentation about this... at least the name Graphics Memory Controller Hub name...
Quoted 8 lines
I also wonder if we should make this a child device now that it is really organized...
But anyway, everything can be a follow up, the current refactor is already a very good clean up step, so for the series:
Reviewed-by Rodrigo Vivi <[email protected]>
Thanks for the reviews, pushed to drm-intel-next with Ville's IRC ack.
BR,
Jani.
Quoted 23 lines
Quoted 23 lines
Jani Nikula (4):
drm/i915: add gmch substruct to structdrm_i915_privatedrm/i915/gmch: split out soc/intel_gmch drm/i915/gmch: mass renamedev_privto i915 drm/i915/gmch: move VGA set state to GMCH codedrivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_vga.c | 32 +--- drivers/gpu/drm/i915/gt/intel_ggtt_gmch.c | 2 +- drivers/gpu/drm/i915/i915_driver.c | 145 +----------------- drivers/gpu/drm/i915/i915_drv.h | 10 +- drivers/gpu/drm/i915/soc/intel_gmch.c | 171 ++++++++++++++++++++++ drivers/gpu/drm/i915/soc/intel_gmch.h | 18 +++ 7 files changed, 204 insertions(+), 175 deletions(-) create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.c create mode 100644 drivers/gpu/drm/i915/soc/intel_gmch.hSignature · 1 line
2.34.1
Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center