Skip to contentSkip to conversation

Remove KZM9D board staging support

PATCH Superseded Geert Uytterhoeven 4 participants 9 messages Jun 9, 2023

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Geert Uytterhoeven

author maintainer
#0 lore raw

cover Remove KZM9D board staging support

Hi all,

Board staging was introduced to host temporarily legacy board support for platforms that are under active conversion to DT. Currently it hosts:
1. USB Gadget support for the Kyoto Microcomputer Co. KZM-A9-Dual (KZM9D) development board,
2. Display support for the Atmark Techno Armadillo-800-EVA development board.

During the last few years, the KZM9D development board didn't receive much love. Also, no one really cared about the EMMA Mobile USB Gadget driver, which is also hosted under staging.

Hence this RFC patch series removes the KZM9D board staging support, together with the EMMA Mobile USB Gadget driver, and the legacy EMMA Mobile EV2 clkdev registration.

Once the SH-Mobile LCDC DRM driver has been converted to atomic modesetting and DT, the remaining parts of board staging can be removed, together with legacy clkdev registration in the MSTP driver.

Thanks for your comments!

Geert Uytterhoeven (3):
staging: emxx_udc: Remove EMMA Mobile USB Gadget driver
staging: board: Remove KZM9D board staging code
clk: renesas: emev2: Remove obsolete clkdev registration

 drivers/clk/renesas/clk-emev2.c     |    3 -
 drivers/staging/Kconfig             |    2 -
 drivers/staging/Makefile            |    1 -
 drivers/staging/board/Makefile      |    1 -
 drivers/staging/board/kzm9d.c       |   26 -
 drivers/staging/emxx_udc/Kconfig    |   11 -
 drivers/staging/emxx_udc/Makefile   |    2 -
 drivers/staging/emxx_udc/TODO       |    6 -
 drivers/staging/emxx_udc/emxx_udc.c | 3223 ---------------------------
 drivers/staging/emxx_udc/emxx_udc.h |  554 -----
 10 files changed, 3829 deletions(-)
 delete mode 100644 drivers/staging/board/kzm9d.c
 delete mode 100644 drivers/staging/emxx_udc/Kconfig
 delete mode 100644 drivers/staging/emxx_udc/Makefile
 delete mode 100644 drivers/staging/emxx_udc/TODO
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.c
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.h
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
author maintainer
#1 lore raw

PATCH 1/3 staging: emxx_udc: Remove EMMA Mobile USB Gadget driver

No one stepped up to complete the EMMA Mobile USB Gadget driver, bring it up to non-staging standards, and convert it to device tree.

---
 drivers/staging/Kconfig             |    2 -
 drivers/staging/Makefile            |    1 -
 drivers/staging/emxx_udc/Kconfig    |   11 -
 drivers/staging/emxx_udc/Makefile   |    2 -
 drivers/staging/emxx_udc/TODO       |    6 -
 drivers/staging/emxx_udc/emxx_udc.c | 3223 ---------------------------
 drivers/staging/emxx_udc/emxx_udc.h |  554 -----
 7 files changed, 3799 deletions(-)
 delete mode 100644 drivers/staging/emxx_udc/Kconfig
 delete mode 100644 drivers/staging/emxx_udc/Makefile
 delete mode 100644 drivers/staging/emxx_udc/TODO
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.c
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.h
drivers/staging/Kconfig +0 -2
index f9aef39cac2e93db..5063b74edc1a7ee6 100644
@@ -48,8 +48,6 @@ source "drivers/staging/iio/Kconfig"
 
 source "drivers/staging/sm750fb/Kconfig"
 
-source "drivers/staging/emxx_udc/Kconfig"
-
 source "drivers/staging/nvec/Kconfig"
 
 source "drivers/staging/media/Kconfig"
drivers/staging/Makefile +0 -1
index ffa70dda481d36c5..a1cddab44b03bcde 100644
@@ -15,7 +15,6 @@ obj-$(CONFIG_VT6656)		+= vt6656/
 obj-$(CONFIG_VME_BUS)		+= vme_user/
 obj-$(CONFIG_IIO)		+= iio/
 obj-$(CONFIG_FB_SM750)		+= sm750fb/
-obj-$(CONFIG_USB_EMXX)		+= emxx_udc/
 obj-$(CONFIG_MFD_NVEC)		+= nvec/
 obj-$(CONFIG_STAGING_BOARD)	+= board/
 obj-$(CONFIG_LTE_GDM724X)	+= gdm724x/
drivers/staging/emxx_udc/Kconfig deleted +0 -11
deleted file mode 100644
index e7a95b3b6a2f742a..0000000000000000
@@ -1,11 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-config USB_EMXX
-	tristate "EMXX USB Function Device Controller"
-	depends on USB_GADGET && (ARCH_RENESAS || COMPILE_TEST)
-	help
-	   The Emma Mobile series of SoCs from Renesas Electronics and
-	   former NEC Electronics include USB Function hardware.
-
-	   Say "y" to link the driver statically, or "m" to build a
-	   dynamically linked module called "emxx_udc" and force all
-	   gadget drivers to also be dynamically linked.
drivers/staging/emxx_udc/Makefile deleted +0 -2
deleted file mode 100644
index 569c5e9a9baeff06..0000000000000000
@@ -1,2 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-obj-$(CONFIG_USB_EMXX)	:= emxx_udc.o
drivers/staging/emxx_udc/TODO deleted +0 -6
deleted file mode 100644
index 471529a470c706bf..0000000000000000
@@ -1,6 +0,0 @@
-* add clock framework support (platform device with CCF needs special care)
-* break out board-specific VBUS GPIO to work with multiplatform
-* convert VBUS GPIO to use GPIO descriptors from <linux/gpio/consumer.h>
-  and stop using the old GPIO API
-* DT bindings
-* move driver into drivers/usb/gadget/
drivers/staging/emxx_udc/emxx_udc.c deleted +0 -3223

2,966 lines not on this page · raw message

drivers/staging/emxx_udc/emxx_udc.h deleted +0 -554

554 lines not on this page · raw message

The rest of this diff is not shown. View the raw message.

Signature · 1 line
2.34.1

Part of the diff is not shown here. View the raw message.

Acked-by on v1 1/3
#2 lore raw

Re: [PATCH/RFC 1/3] staging: emxx_udc: Remove EMMA Mobile USB Gadget driver

Quoted 4 lines · Geert Uytterhoeven

No one stepped up to complete the EMMA Mobile USB Gadget driver, bring it up to non-staging standards, and convert it to device tree.

Yes, if someone really wants to, the driver can be found in the history. Chances are close to 0, though:

author maintainer
#3 lore raw

PATCH 2/3 staging: board: Remove KZM9D board staging code

In reply to Geert Uytterhoeven

With the EMMA Mobile USB Gadget staging driver removed, there is no longer any use for the EMEV2 KZM9D board staging code.

---
 drivers/staging/board/Makefile |  1 -
 drivers/staging/board/kzm9d.c  | 26 --------------------------
 2 files changed, 27 deletions(-)
 delete mode 100644 drivers/staging/board/kzm9d.c
drivers/staging/board/Makefile +0 -1
index ed7839752e129abb..5db091b5ca01596a 100644
@@ -1,4 +1,3 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-y	:= board.o
-obj-$(CONFIG_ARCH_EMEV2)	+= kzm9d.o
 obj-$(CONFIG_ARCH_R8A7740)	+= armadillo800eva.o
drivers/staging/board/kzm9d.c deleted +0 -26
deleted file mode 100644
index d449a837414e6934..0000000000000000
@@ -1,26 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/* Staging board support for KZM9D. Enable not-yet-DT-capable devices here. */
-
-#include <linux/kernel.h>
-#include <linux/platform_device.h>
-#include "board.h"
-
-static struct resource usbs1_res[] __initdata = {
-	DEFINE_RES_MEM(0xe2800000, 0x2000),
-	DEFINE_RES_IRQ(159),
-};
-
-static void __init kzm9d_init(void)
-{
-	board_staging_gic_setup_xlate("arm,pl390", 32);
-
-	if (!board_staging_dt_node_available(usbs1_res,
-					     ARRAY_SIZE(usbs1_res))) {
-		board_staging_gic_fixup_resources(usbs1_res,
-						  ARRAY_SIZE(usbs1_res));
-		platform_device_register_simple("emxx_udc", -1, usbs1_res,
-						ARRAY_SIZE(usbs1_res));
-	}
-}
-
-board_staging("renesas,kzm9d", kzm9d_init);
Signature · 1 line
2.34.1
author maintainer
#5 lore raw

PATCH 3/3 clk: renesas: emev2: Remove obsolete clkdev registration

In reply to Geert Uytterhoeven

EMMA Mobile EV2 is a multi-platform/CCF-only platform, registering all devices from DT, so we can remove the registration of clkdevs.

---
 drivers/clk/renesas/clk-emev2.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/clk/renesas/clk-emev2.c +0 -3
index 7807b30a5bbb5901..37c6f9be5e5b46e8 100644
@@ -6,7 +6,6 @@
  * Copyright (C) 2012 Magnus Damm
  */
 #include <linux/clk-provider.h>
-#include <linux/clkdev.h>
 #include <linux/io.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
@@ -74,7 +73,6 @@ static void __init emev2_smu_clkdiv_init(struct device_node *np)
 	clk = clk_register_divider(NULL, np->name, parent_name, 0,
 				   smu_base + reg[0], reg[1], 8, 0, &lock);
 	of_clk_add_provider(np, of_clk_src_simple_get, clk);
-	clk_register_clkdev(clk, np->full_name, NULL);
 	pr_debug("## %s %pOFn %p\n", __func__, np, clk);
 }
 CLK_OF_DECLARE(emev2_smu_clkdiv, "renesas,emev2-smu-clkdiv",
@@ -92,7 +90,6 @@ static void __init emev2_smu_gclk_init(struct device_node *np)
 	clk = clk_register_gate(NULL, np->name, parent_name, 0,
 				smu_base + reg[0], reg[1], 0, &lock);
 	of_clk_add_provider(np, of_clk_src_simple_get, clk);
-	clk_register_clkdev(clk, np->full_name, NULL);
 	pr_debug("## %s %pOFn %p\n", __func__, np, clk);
 }
 CLK_OF_DECLARE(emev2_smu_gclk, "renesas,emev2-smu-gclk", emev2_smu_gclk_init);
Signature · 1 line
2.34.1
#6 lore raw

Re: [PATCH/RFC 3/3] clk: renesas: emev2: Remove obsolete clkdev registration

Quoted 4 lines · Geert Uytterhoeven

EMMA Mobile EV2 is a multi-platform/CCF-only platform, registering all devices from DT, so we can remove the registration of clkdevs.

Note that this patch does not have a dependency on the two other patches in this series, as (unlike the SH-Mobile LCDC driver) the EMMA Mobile USB Gadget driver does not use any clocks.
The calls to clk_register_clkdev() were not removed before[*], as (in theory) new EMEV2 board staging drivers using clocks could be added...

[*] I did write this patch in 2015, oh well ;-)

Gr{oetje,eeting}s,

Geert

Signature · 5 lines
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
#7 lore raw
In reply to Geert Uytterhoeven
Quoted 4 lines

Hence this RFC patch series removes the KZM9D board staging support, together with the EMMA Mobile USB Gadget driver, and the legacy EMMA Mobile EV2 clkdev registration.

To make it super-clear: we only lose USB gadget support by removing this. And both, board code and driver, have been in staging for years, hardly altered. The rest of the board will still be supported because the other drivers gained DT support.

I am all for this!

Acked-by on the v1 series
#8 lore raw
In reply to Geert Uytterhoeven

Hi Geert,

Happy to see this work!

Quoted 38 lines · Geert Uytterhoeven

Hi all,

Board staging was introduced to host temporarily legacy board support for platforms that are under active conversion to DT. Currently it hosts:
1. USB Gadget support for the Kyoto Microcomputer Co. KZM-A9-Dual (KZM9D) development board,
2. Display support for the Atmark Techno Armadillo-800-EVA development board.

During the last few years, the KZM9D development board didn't receive much love. Also, no one really cared about the EMMA Mobile USB Gadget driver, which is also hosted under staging.

Hence this RFC patch series removes the KZM9D board staging support, together with the EMMA Mobile USB Gadget driver, and the legacy EMMA Mobile EV2 clkdev registration.

Once the SH-Mobile LCDC DRM driver has been converted to atomic modesetting and DT, the remaining parts of board staging can be removed, together with legacy clkdev registration in the MSTP driver.

Thanks for your comments!

Geert Uytterhoeven (3):
staging: emxx_udc: Remove EMMA Mobile USB Gadget driver
staging: board: Remove KZM9D board staging code
clk: renesas: emev2: Remove obsolete clkdev registration

 drivers/clk/renesas/clk-emev2.c     |    3 -
 drivers/staging/Kconfig             |    2 -
 drivers/staging/Makefile            |    1 -
 drivers/staging/board/Makefile      |    1 -
 drivers/staging/board/kzm9d.c       |   26 -
 drivers/staging/emxx_udc/Kconfig    |   11 -
 drivers/staging/emxx_udc/Makefile   |    2 -
 drivers/staging/emxx_udc/TODO       |    6 -
 drivers/staging/emxx_udc/emxx_udc.c | 3223 ---------------------------
Quoted 8 lines
 drivers/staging/emxx_udc/emxx_udc.h |  554 -----
 10 files changed, 3829 deletions(-)
 delete mode 100644 drivers/staging/board/kzm9d.c
 delete mode 100644 drivers/staging/emxx_udc/Kconfig
 delete mode 100644 drivers/staging/emxx_udc/Makefile
 delete mode 100644 drivers/staging/emxx_udc/TODO
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.c
 delete mode 100644 drivers/staging/emxx_udc/emxx_udc.h
Quoted 14 lines
Signature · 13 lines
-- 
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
Signature · 2 lines
Kind Regards,
Niklas Söderlund