Skip to contentSkip to conversation

btrfs-progs: some zoned mkfs fixups

PATCH In review Josef Bacik 5 participants 11 messages Jul 6, 2023 – Jul 21, 2023 Btrfs file system

lore
Share & tools
lore
#0 lore raw

v2 cover btrfs-progs: some zoned mkfs fixups

v1->v2:
- extracted the minimum calculation into a helper as per Christoph's suggestion.

Hello,

I'm trying to get the zoned block device tests running and I ran into an issue of a long running test because scratch_mkfs_sized failed and we tried to fill up a giant fs. Fix up the error message and the math so this is correct. Thanks,

Josef

Josef Bacik (2):
btrfs-progs: print out the correct minimum size for zoned file systems
btrfs-progs: set the proper minimum size for a zoned file system

 mkfs/main.c | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)
Signature · 1 line
2.41.0
#1 lore raw

PATCH v2 1/2 btrfs-progs: print out the correct minimum size for zoned file systems

While trying to get the ZNS testing running I ran into a problem with making a small file system for one of the tests, but the error output didn't make sense because it said the minimum size was 114294784 bytes, and I was trying to make a file system of size 419430400 bytes. The problem here is that we were spitting out min_dev_size, which isn't the minimum size for the ZNS configuration. Add a helper for calculating the minimum zoned fs size, and use that for the error output.

---
 mkfs/main.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)
mkfs/main.c +13 -8
index 972ed111..8d94dac8 100644
@@ -79,6 +79,17 @@ struct prepare_device_progress {
 	int ret;
 };
 
+/*
+ * 2 zones for the primary superblock
+ * 1 zone for the system block group
+ * 1 zone for a metadata block group
+ * 1 zone for a data block group
+ */
+static u64 min_zoned_fs_size(const char *filename)
+{
+	return 5 * zone_size(file);
+}
+
 static int create_metadata_block_groups(struct btrfs_root *root, bool mixed,
 				struct mkfs_allocation *allocation)
 {
@@ -1436,17 +1447,11 @@ int BOX_MAIN(mkfs)(int argc, char **argv)
 			min_dev_size);
 		goto error;
 	}
-	/*
-	 * 2 zones for the primary superblock
-	 * 1 zone for the system block group
-	 * 1 zone for a metadata block group
-	 * 1 zone for a data block group
-	 */
-	if (opt_zoned && block_count && block_count < 5 * zone_size(file)) {
+	if (opt_zoned && block_count && block_count < min_zoned_fs_size(file)) {
 		error("size %llu is too small to make a usable filesystem",
 			block_count);
 		error("minimum size for a zoned btrfs filesystem is %llu",
-			min_dev_size);
+			min_zoned_fs_size(file));
 		goto error;
 	}
 
Signature · 1 line
2.41.0
#3 lore raw

PATCH v2 2/2 btrfs-progs: set the proper minimum size for a zoned file system

In reply to Josef Bacik

We currently limit the size of the file system to 5 * the zone size, however we actually want to limit it to 7 * the zone size. Fix up the comment and the math to match our actual minimum zoned file system size.

---
 mkfs/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
mkfs/main.c +3 -1
index 8d94dac8..c7d7399f 100644
@@ -84,10 +84,12 @@ struct prepare_device_progress {
  * 1 zone for the system block group
  * 1 zone for a metadata block group
  * 1 zone for a data block group
+ * 1 zone for a relocation block group
+ * 1 zone for the tree log
  */
 static u64 min_zoned_fs_size(const char *filename)
 {
-	return 5 * zone_size(file);
+	return 7 * zone_size(file);
 }
 
 static int create_metadata_block_groups(struct btrfs_root *root, bool mixed,
Signature · 1 line
2.41.0
#4 lore raw

Re: [PATCH v2 2/2] btrfs-progs: set the proper minimum size for a zoned file system

In reply to Josef Bacik
Quoted 3 lines · Josef Bacik

We currently limit the size of the file system to 5 * the zone size, however we actually want to limit it to 7 * the zone size. Fix up the comment and the math to match our actual minimum zoned file system size.

Hmm. IS this actually correct? Don't we also need at least a second metadata and system block group in case the first one fills up and metadata needs to go somewhere else to be able to reset the previous ones?

Sorry, should have noticed that last time around.

#5 lore raw

Re: [PATCH v2 2/2] btrfs-progs: set the proper minimum size for a zoned file system

Quoted 11 lines · Christoph Hellwig
Quoted 3 lines · Josef Bacik

We currently limit the size of the file system to 5 * the zone size, however we actually want to limit it to 7 * the zone size. Fix up the comment and the math to match our actual minimum zoned file system size.

Hmm. IS this actually correct? Don't we also need at least a second metadata and system block group in case the first one fills up and metadata needs to go somewhere else to be able to reset the previous ones?

Sorry, should have noticed that last time around.

It depends on what we consider the "minimal" is. Even with the 5 zones (2 SBs + 1 per BG type), we can start writing to the file-system.

If you need to run a relocation, one more block group for it is needed.

The fsync block group might be optional because if the fsync node allocation failed, it should fall back to the full sync. It will kill the performance but still works...

If we say it is the "minimal" that we can infinitely write and delete a file without ENOSPC, we need one (or two, depending on the metadata profile) more BGs per META/SYSTEM.

#9 lore raw

Re: [PATCH v2 2/2] btrfs-progs: set the proper minimum size for a zoned file system

In reply to Josef Bacik
Quoted 14 lines · Josef Bacik

We currently limit the size of the file system to 5 * the zone size, however we actually want to limit it to 7 * the zone size. Fix up the comment and the math to match our actual minimum zoned file system size.

---
 mkfs/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
mkfs/main.c +0 -0
index 8d94dac8..c7d7399f 100644

mkfs/main.c struct prepare_device_progress { · line 92

Quoted 10 lines
mkfs/main.c +3 -1
@@ -84,10 +84,12 @@ struct prepare_device_progress {
  * 1 zone for the system block group
  * 1 zone for a metadata block group
  * 1 zone for a data block group
+ * 1 zone for a relocation block group
+ * 1 zone for the tree log
  */
 static u64 min_zoned_fs_size(const char *filename)
 {
-	return 5 * zone_size(file);
+	return 7 * zone_size(file);

When we use DUP profile for METADATA or SYSTEM, we need two zones for METADATA, SYSTEM, and the tree log BG.

Quoted 6 lines
mkfs/main.c +0 -0
 }
 
 static int create_metadata_block_groups(struct btrfs_root *root, bool mixed,
Signature · 1 line
2.41.0
#6 lore raw

Re: [PATCH v2 2/2] btrfs-progs: set the proper minimum size for a zoned file system

In reply to Naohiro Aota
Quoted 1 line · Naohiro Aota

It depends on what we consider the "minimal" is.

I think minimal means a file system that can actually be be continuously used.

Quoted 5 lines

Even with the 5 zones (2
SBs + 1 per BG type), we can start writing to the file-system.

If you need to run a relocation, one more block group for it is needed.

Quoted 7 lines

The fsync block group might be optional because if the fsync node allocation failed, it should fall back to the full sync. It will kill the performance but still works...

If we say it is the "minimal" that we can infinitely write and delete a file without ENOSPC, we need one (or two, depending on the metadata profile) more BGs per META/SYSTEM.

Based on my above sentence we then need:

2 zones for the primary superblock

metadata replication factor * (
2 zones for the system block group
2 zone for a metadata block group
2 zone for the tree log)

data replication factor * (
1 zone for a data block group
1 zone for a relocation block group
)

where the two for the non-sb, non-data blocks accounts for beeing able to continue writing after filling up one bg and allowing gc. In fact even just two might lead to deadlocks in that case depending on the exact algorithm in other zoned storage systems, but I don't know enough about btrfs metadata placement to understand how that works on zoned btrfs right now.

#7 lore raw

Re: [PATCH v2 2/2] btrfs-progs: set the proper minimum size for a zoned file system

Quoted 29 lines · On Sun, Jul 09, 2023 at 10:28:12PM -0700, [email protected] wrote:
Quoted 1 line · Naohiro Aota

It depends on what we consider the "minimal" is.

I think minimal means a file system that can actually be be continuously used.

Quoted 5 lines

Even with the 5 zones (2
SBs + 1 per BG type), we can start writing to the file-system.

If you need to run a relocation, one more block group for it is needed.

Quoted 7 lines

The fsync block group might be optional because if the fsync node allocation failed, it should fall back to the full sync. It will kill the performance but still works...

If we say it is the "minimal" that we can infinitely write and delete a file without ENOSPC, we need one (or two, depending on the metadata profile) more BGs per META/SYSTEM.

Based on my above sentence we then need:

2 zones for the primary superblock

metadata replication factor * (
2 zones for the system block group
2 zone for a metadata block group
2 zone for the tree log)

Quoted 4 lines

data replication factor * (
1 zone for a data block group
1 zone for a relocation block group
)

I think the relocation should be taken separately, there can be only one relocation process running per block group type, ie. data/metadata and the replication depends on the respective factor. Otherwise yeah the formula for minimal number of zones needs to take into account the replication and all the normal usage case. In total this is still a low number, say always below 20 with currently supported profiles. Devices typically have more and for emulated ones we should scale the size or zone size properly.

Setting up devices with small number of spare zones is also interesting, or with small zones that will trigger the reclaim more often.

#8 lore raw

Re: [PATCH v2 2/2] btrfs-progs: set the proper minimum size for a zoned file system

Quoted 30 lines · David Sterba
Quoted 29 lines · On Sun, Jul 09, 2023 at 10:28:12PM -0700, [email protected] wrote:
Quoted 1 line · Naohiro Aota

It depends on what we consider the "minimal" is.

I think minimal means a file system that can actually be be continuously used.

Quoted 5 lines

Even with the 5 zones (2
SBs + 1 per BG type), we can start writing to the file-system.

If you need to run a relocation, one more block group for it is needed.

Quoted 7 lines

The fsync block group might be optional because if the fsync node allocation failed, it should fall back to the full sync. It will kill the performance but still works...

If we say it is the "minimal" that we can infinitely write and delete a file without ENOSPC, we need one (or two, depending on the metadata profile) more BGs per META/SYSTEM.

Based on my above sentence we then need:

2 zones for the primary superblock

metadata replication factor * (
2 zones for the system block group
2 zone for a metadata block group
2 zone for the tree log)

Quoted 7 lines
Quoted 4 lines

data replication factor * (
1 zone for a data block group
1 zone for a relocation block group
)

I think the relocation should be taken separately, there can be only one relocation process running per block group type, ie. data/metadata and

That relocation block group only write relocated data and that data must be written into a dedicated block group. The relocated metadata can go with the same BG as normal metadata. So, the above calculation looks good to me.

Quoted 9 lines

the replication depends on the respective factor. Otherwise yeah the formula for minimal number of zones needs to take into account the replication and all the normal usage case. In total this is still a low number, say always below 20 with currently supported profiles. Devices typically have more and for emulated ones we should scale the size or zone size properly.

Setting up devices with small number of spare zones is also interesting, or with small zones that will trigger the reclaim more often.