Skip to contentSkip to conversation

seq_buf: Export seq_buf_putc() &nd seq_buf_puts()

PATCH In review Christophe JAILLET 2 participants 5 messages Nov 1, 2023

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover seq_buf: Export seq_buf_putc() &nd seq_buf_puts()

seq_buf_putc() has a potential real use-case (link in the patch), but seq_buf_puts() has currently no forseen use-case, so I have split it in 2 patches if only the 1st one is accepted.

Christophe JAILLET (2):
seq_buf: Export seq_buf_putc()
seq_buf: Export seq_buf_puts()

 lib/seq_buf.c | 2 ++
 1 file changed, 2 insertions(+)
Signature · 1 line
2.34.1
#1 lore raw

PATCH 1/2 seq_buf: Export seq_buf_putc()

Mark seq_buf_putc() which is part of the seq_buf API to be exported to kernel loadable GPL modules.

---
This patch is needed for [1].
(It will need an update because of some recent changes in the seq_buf API)

[1]: https://lore.kernel.org/all/bbbab32e3e104bdc2238724a6a4a85e539f49ddd.1698512661.git.christophe.jaillet@wanadoo.fr/

---
 lib/seq_buf.c | 1 +
 1 file changed, 1 insertion(+)
lib/seq_buf.c +1 -0
index 23518f77ea9c..fb99168c3309 100644
@@ -208,6 +208,7 @@ int seq_buf_putc(struct seq_buf *s, unsigned char c)
 	seq_buf_set_overflow(s);
 	return -1;
 }
+EXPORT_SYMBOL_GPL(seq_buf_putc);
 
 /**
  * seq_buf_putmem - write raw data into the sequenc buffer
Signature · 1 line
2.34.1
#2 lore raw

PATCH 2/2 seq_buf: Export seq_buf_puts()

In reply to Christophe JAILLET

Mark seq_buf_puts() which is part of the seq_buf API to be exported to kernel loadable GPL modules.

---
There is currently no need for me for this export, but should the seq_buf API be more widely used, it could become convenient to have it available.

---
 lib/seq_buf.c | 1 +
 1 file changed, 1 insertion(+)
lib/seq_buf.c +1 -0
index fb99168c3309..010c730ca7fc 100644
@@ -187,6 +187,7 @@ int seq_buf_puts(struct seq_buf *s, const char *str)
 	seq_buf_set_overflow(s);
 	return -1;
 }
+EXPORT_SYMBOL_GPL(seq_buf_puts);
 
 /**
  * seq_buf_putc - sequence printing of simple character
Signature · 1 line
2.34.1
#3 lore raw
In reply to Christophe JAILLET
Quoted 11 lines · On Wed, 1 Nov 2023 18:59:04 +0100 Christophe JAILLET…

seq_buf_putc() has a potential real use-case (link in the patch), but seq_buf_puts() has currently no forseen use-case, so I have split it in 2 patches if only the 1st one is accepted.

Christophe JAILLET (2):
seq_buf: Export seq_buf_putc()
seq_buf: Export seq_buf_puts()

 lib/seq_buf.c | 2 ++
 1 file changed, 2 insertions(+)

I can pull these in as I'm getting ready for my pull request to Linus soon (and just kicked off my testing).

Or do you need them as part of the patch you mentioned? When does that need to go in? Can it wait till it hits Linus's tree?

-- Steve

#4 lore raw

Le 01/11/2023 à 19:17, Steven Rostedt a écrit :

Quoted 15 lines
Quoted 11 lines · On Wed, 1 Nov 2023 18:59:04 +0100 Christophe JAILLET…

seq_buf_putc() has a potential real use-case (link in the patch), but seq_buf_puts() has currently no forseen use-case, so I have split it in 2 patches if only the 1st one is accepted.

Christophe JAILLET (2):
seq_buf: Export seq_buf_putc()
seq_buf: Export seq_buf_puts()

  lib/seq_buf.c | 2 ++
  1 file changed, 2 insertions(+)
Quoted 8 lines

I can pull these in as I'm getting ready for my pull request to Linus soon (and just kicked off my testing).

Or do you need them as part of the patch you mentioned? When does that need to go in? Can it wait till it hits Linus's tree?

-- Steve

You timing will be mine, no need to hurry.
I'll see when it reaches -next.

Thanks for taking care of it.

CJ