Skip to contentSkip to conversation

Revert "scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock"

PATCH Hannes Reinecke 1 participant 2 messages Feb 9, 2024 3 messages not in the archive SCSI

lore
Share & tools
lore
#2 lore raw
In reply to a message not in the archive
Quoted 11 lines · Lee Duncan

From: Lee Duncan <[email protected]>

This reverts commit 1a1975551943f681772720f639ff42fbaa746212

This commit causes interrupts to be lost for FCoE devices, since it changed sping locks from "bh" to "irqsave".

Instead, a work queue should be used, and will be addressed in a separate patch.

Fixes 1a1975551943f681772720f639ff42fbaa746212

Please use the correct fixes tag:

Fixes 1a1975551943 ("scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock")

Otherwise looks good.

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke                Kernel Storage Architect
[email protected]                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich
#4 lore raw

Re: [PATCH v3 2/2] fnic: move fnic_fnic_flush_tx() to a work queue

In reply to a message not in the archive
Quoted 6 lines · Lee Duncan

From: Lee Duncan <[email protected]>

Rather than call 'fnic_flush_tx()' from interrupt context we should be moving it onto a work queue to avoid any locking issues.

Fixes 1a1975551943f681772720f639ff42fbaa746212

Same here, please use the correct fixes tag.

Quoted 9 lines
---
  drivers/scsi/fnic/fnic.h      | 3 ++-
  drivers/scsi/fnic/fnic_fcs.c  | 5 +++--
  drivers/scsi/fnic/fnic_main.c | 1 +
  drivers/scsi/fnic/fnic_scsi.c | 4 ++--
  4 files changed, 8 insertions(+), 5 deletions(-)

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke                Kernel Storage Architect
[email protected]                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Ivo Totev, Andrew McDonald,
Werner Knoblich