Skip to contentSkip to conversation

thermal/drivers/rcar_gen3: Add support for R-Car V4M

PATCH In review Geert Uytterhoeven 3 participants 6 messages Mar 6, 2024

Subsystems (4)
lore
Share & tools
lore

Geert Uytterhoeven

author maintainer
#0 lore raw

cover thermal/drivers/rcar_gen3: Add support for R-Car V4M

Hi all,

This patch series adds support for the Thermal Sensor/Chip Internal Voltage Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.

It has been tested on the Renesas Gray Hawk Single development board, with an R-Car V4M SoC that has unfortunately no calibration values fused.

Thanks for your comments!

Duy Nguyen (1):
dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support

Geert Uytterhoeven (1):
thermal/drivers/rcar_gen3: Add support for R-Car V4M

 .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml        | 2 ++
 drivers/thermal/rcar_gen3_thermal.c                           | 4 ++++
 2 files changed, 6 insertions(+)
Signature · 12 lines
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
author maintainer
#1 lore raw

PATCH 1/2 dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support

From: Duy Nguyen <[email protected]>

Document support for the Thermal Sensor/Chip Internal Voltage Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.

Just like on other R-Car Gen4 SoCs, interrupts are not routed to the INTC-AP (GIC) but to the Error Control Module (ECM).

---
Changes compared to the BSP:
- No interrupts property, as interrupts are routed to the ECM.

---
 .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml          | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml +2 -0
index ecf276fd155cfb27..6a81cb6e11bc1e14 100644
@@ -29,6 +29,7 @@ properties:
       - renesas,r8a779a0-thermal # R-Car V3U
       - renesas,r8a779f0-thermal # R-Car S4-8
       - renesas,r8a779g0-thermal # R-Car V4H
+      - renesas,r8a779h0-thermal # R-Car V4M
 
   reg: true
 
@@ -90,6 +91,7 @@ else:
             enum:
               - renesas,r8a779f0-thermal
               - renesas,r8a779g0-thermal
+              - renesas,r8a779h0-thermal
   then:
     required:
       - interrupts
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/2
#2 lore raw

Re: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support

Hi Geert,

Thanks for your work.

Quoted 11 lines · Geert Uytterhoeven

From: Duy Nguyen <[email protected]>

Document support for the Thermal Sensor/Chip Internal Voltage Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.

Just like on other R-Car Gen4 SoCs, interrupts are not routed to the INTC-AP (GIC) but to the Error Control Module (ECM).

Quoted 30 lines

---
Changes compared to the BSP:
- No interrupts property, as interrupts are routed to the ECM.

---
 .../devicetree/bindings/thermal/rcar-gen3-thermal.yaml          | 2 ++
 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/thermal/rcar-gen3-thermal.yaml +2 -0
index ecf276fd155cfb27..6a81cb6e11bc1e14 100644
@@ -29,6 +29,7 @@ properties:
       - renesas,r8a779a0-thermal # R-Car V3U
       - renesas,r8a779f0-thermal # R-Car S4-8
       - renesas,r8a779g0-thermal # R-Car V4H
+      - renesas,r8a779h0-thermal # R-Car V4M
 
   reg: true
 
@@ -90,6 +91,7 @@ else:
             enum:
               - renesas,r8a779f0-thermal
               - renesas,r8a779g0-thermal
+              - renesas,r8a779h0-thermal
   then:
     required:
       - interrupts
Signature · 1 line
2.34.1
Signature · 2 lines
Kind Regards,
Niklas Söderlund
Acked-by on v1 1/2
#3 lore raw

Re: [PATCH 1/2] dt-bindings: thermal: rcar-gen3-thermal: Add r8a779h0 support

In reply to Geert Uytterhoeven
Quoted 11 lines · Geert Uytterhoeven

From: Duy Nguyen <[email protected]>

Document support for the Thermal Sensor/Chip Internal Voltage Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.

Just like on other R-Car Gen4 SoCs, interrupts are not routed to the INTC-AP (GIC) but to the Error Control Module (ECM).

author maintainer
#4 lore raw

PATCH 2/2 thermal/drivers/rcar_gen3: Add support for R-Car V4M

In reply to Geert Uytterhoeven

Add support for the Thermal Sensor/Chip Internal Voltage Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.

The conversion formulas for R-Car V4M are the same as for other R-Car Gen4 SoCs.

Based on a patch in the BSP by Duy Nguyen.

---
Changes compared to the BSP:
- Use existing rcar_gen4_thermal_info instead of new data_v4m.

---
 drivers/thermal/rcar_gen3_thermal.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/thermal/rcar_gen3_thermal.c +4 -0
index cafcb6d6e235be44..a764cb1115a57562 100644
@@ -428,6 +428,10 @@ static const struct of_device_id rcar_gen3_thermal_dt_ids[] = {
 		.compatible = "renesas,r8a779g0-thermal",
 		.data = &rcar_gen4_thermal_info,
 	},
+	{
+		.compatible = "renesas,r8a779h0-thermal",
+		.data = &rcar_gen4_thermal_info,
+	},
 	{},
 };
 MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 2/2
#5 lore raw

Hello Geert,

Thanks for your patch.

Quoted 9 lines · Geert Uytterhoeven

Add support for the Thermal Sensor/Chip Internal Voltage Monitor/Core Voltage Monitor (THS/CIVM/CVM) on the Renesas R-Car V4M (R8A779H0) SoC.

The conversion formulas for R-Car V4M are the same as for other R-Car Gen4 SoCs.

Based on a patch in the BSP by Duy Nguyen.

Quoted 25 lines

---
Changes compared to the BSP:
- Use existing rcar_gen4_thermal_info instead of new data_v4m.

---
 drivers/thermal/rcar_gen3_thermal.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/thermal/rcar_gen3_thermal.c +4 -0
index cafcb6d6e235be44..a764cb1115a57562 100644
@@ -428,6 +428,10 @@ static const struct of_device_id rcar_gen3_thermal_dt_ids[] = {
 		.compatible = "renesas,r8a779g0-thermal",
 		.data = &rcar_gen4_thermal_info,
 	},
+	{
+		.compatible = "renesas,r8a779h0-thermal",
+		.data = &rcar_gen4_thermal_info,
+	},
 	{},
 };
 MODULE_DEVICE_TABLE(of, rcar_gen3_thermal_dt_ids);
Signature · 1 line
2.34.1
Signature · 2 lines
Kind Regards,
Niklas Söderlund