Add specified fixed LDO VOUT propery

PATCH In review Alina Yu 3 participants 12 messages May 16, 2024 – May 29, 2024

Subsystems (2)

Device tree bindings Voltage and current regulator framework

lore

Share & tools

lore

Alina Yu

author

2024-05-16 09:20 UTC #1 lore raw

PATCH 1/2 regulator: rtq2208: Add fixed LDO VOUT property and check that matches the constraints

In reply to Alina Yu

A fixed LDO VOUT property has been added to specify the fixed_uV of the regulator_desc. Additionally, a check has been included in this version
to ensure that the fixed_uV matches the constraints.

Signed-off-by Alina Yu <[email protected]>

---
 drivers/regulator/rtq2208-regulator.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

drivers/regulator/rtq2208-regulator.c +9 -2

index 39147d6..c2c1689 100644
@@ -377,6 +377,7 @@ static int rtq2208_of_get_ldo_dvs_ability(struct device *dev)
 	struct of_regulator_match *match;
 	struct regulator_desc *desc;
 	struct regulator_init_data *init_data;
+	u32 fixed_uV;
 	int ret, i;
 
 	if (!dev->of_node)

@@ -401,9 +402,15 @@ static int rtq2208_of_get_ldo_dvs_ability(struct device *dev)
 		if (!init_data || !desc)
 			continue;
 
-		if (init_data->constraints.min_uV == init_data->constraints.max_uV) {
+		/* specify working fixed voltage if the propery exists */
+		ret = of_property_read_u32(match->of_node, "richtek,fixed-microvolt", &fixed_uV);
+
+		if (!ret) {
+			if (fixed_uV != init_data->constraints.min_uV ||
+				fixed_uV != init_data->constraints.max_uV)
+				return -EINVAL;
 			desc->n_voltages = 1;
-			desc->fixed_uV = init_data->constraints.min_uV;
+			desc->fixed_uV = fixed_uV;
 			desc->ops = &rtq2208_regulator_ldo_fix_ops;
 		} else {
 			desc->n_voltages = ARRAY_SIZE(rtq2208_ldo_volt_table);

Signature · 1 line

2.7.4

Alina Yu

author

2024-05-16 09:20 UTC #0 lore raw

cover Add specified fixed LDO VOUT propery

Hi,

There are two types of LDO VOUT: fixed voltage mode and adjustable voltage mode.

As the fixed voltage for the LDO is outside the range of the adjustable voltage mode, the constraints for this scenario are not suitable to represent both modes. Therefore, A property is added to specify the fixed LDO VOUT.

Alina Yu (2):
regulator: rtq2208: Add fixed LDO VOUT property and check that matches
the constraints
regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

 .../devicetree/bindings/regulator/richtek,rtq2208.yaml        | 11 ++++++++++-
 drivers/regulator/rtq2208-regulator.c                         | 11 +++++++++--
 2 files changed, 19 insertions(+), 3 deletions(-)

Signature · 1 line

2.7.4

Alina Yu

author

2024-05-16 09:21 UTC #5 lore raw

PATCH 2/2 regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

Examples of fixed LDO VOUT and adjustable LDO VOUT is also added to this version.

Signed-off-by Alina Yu <[email protected]>

---
 .../devicetree/bindings/regulator/richtek,rtq2208.yaml        | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Documentation/devicetree/bindings/regulator/richtek,rtq2208.yaml +10 -1

index 609c066..87accc6 100644
@@ -75,6 +75,12 @@ properties:
         description:
           regulator description for ldo[1-2].
 
+        properties:
+          richtek,fixed-microvolt:
+            description: |
+              This property can be used to set a fixed operating voltage that lies outside
+              the range of the regulator's adjustable mode.
+
 required:
   - compatible
   - reg

@@ -177,6 +183,8 @@ examples:
             };
           };
           ldo1 {
+            /* Fixed LDO VOUT */
+            richtek,fixed-microvolt = <1200000>;
             regulator-min-microvolt = <1200000>;
             regulator-max-microvolt = <1200000>;
             regulator-always-on;

@@ -185,7 +193,8 @@ examples:
             };
           };
           ldo2 {
-            regulator-min-microvolt = <3300000>;
+            /* Adjustable LDO VOUT */
+            regulator-min-microvolt = <1800000>;
             regulator-max-microvolt = <3300000>;
             regulator-always-on;
             regulator-state-mem {

Signature · 1 line

2.7.4

Krzysztof Kozlowski

2024-05-16 12:34 UTC #6 lore raw

Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

Quoted 8 lines · Alina Yu

As the fixed voltage for the LDO is outside the range of the adjustable voltage mode, the constraints for this scenario are not suitable to represent both modes. Therefore, A property is added to specify the fixed LDO VOUT.
Examples of fixed LDO VOUT and adjustable LDO VOUT is also added to this version.
Signed-off-by Alina Yu <[email protected]>
---

This is a v1 but I am pretty sure I saw it somewhere and there was already some sort of discussion. Confused... :(

Best regards,
Krzysztof

Alina Yu

author

2024-05-22 09:03 UTC #7 lore raw

Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

Quoted 7 lines · Krzysztof Kozlowski

Quoted 6 lines · Alina Yu
As the fixed voltage for the LDO is outside the range of the adjustable voltage mode, the constraints for this scenario are not suitable to represent both modes. Therefore, A property is added to specify the fixed LDO VOUT.
Examples of fixed LDO VOUT and adjustable LDO VOUT is also added to this version.

Quoted 9 lines

Quoted 2 lines
Signed-off-by Alina Yu <[email protected]>
---
This is a v1 but I am pretty sure I saw it somewhere and there was already some sort of discussion. Confused... :(
Best regards,
Krzysztof

The discussion regarding this matter took place during v2 and v3. Due to the fixed LDO VOUT being outside the range of the adjustable one, a special-use property has been added to avoid overusing the constraints.

Thanks,
Alina

Krzysztof Kozlowski

2024-05-22 09:27 UTC #8 lore raw

Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

Quoted 11 lines · Alina Yu

Quoted 10 lines · Krzysztof Kozlowski
Quoted 8 lines · Alina Yu
As the fixed voltage for the LDO is outside the range of the adjustable voltage mode, the constraints for this scenario are not suitable to represent both modes. Therefore, A property is added to specify the fixed LDO VOUT.
Examples of fixed LDO VOUT and adjustable LDO VOUT is also added to this version.
Signed-off-by Alina Yu <[email protected]>
---

Quoted 8 lines

Quoted 6 lines
This is a v1 but I am pretty sure I saw it somewhere and there was already some sort of discussion. Confused... :(
Best regards,
Krzysztof
The discussion regarding this matter took place during v2 and v3.

So in the future?

Quoted 2 lines

Due to the fixed LDO VOUT being outside the range of the adjustable one, a special-use property has been added to avoid overusing the constraints.

Hm, why exactly this is not a bool property? What are the benefits?

Best regards,
Krzysztof

Alina Yu

author

2024-05-22 09:45 UTC #9 lore raw

Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

Quoted 15 lines · Krzysztof Kozlowski

Quoted 14 lines · Alina Yu
Quoted 13 lines · Krzysztof Kozlowski
Quoted 8 lines · Alina Yu
As the fixed voltage for the LDO is outside the range of the adjustable voltage mode, the constraints for this scenario are not suitable to represent both modes. Therefore, A property is added to specify the fixed LDO VOUT.
Examples of fixed LDO VOUT and adjustable LDO VOUT is also added to this version.
Signed-off-by Alina Yu <[email protected]>
---
This is a v1 but I am pretty sure I saw it somewhere and there was already some sort of discussion. Confused... :(

Quoted 7 lines

Quoted 5 lines
Quoted 3 lines
Best regards,
Krzysztof
The discussion regarding this matter took place during v2 and v3.
So in the future?

Based on the previous discussion, it is scheduled to be included in the linux-next tree. Will we start a further discussions on this topic?

Quoted 9 lines

Quoted 3 lines
Due to the fixed LDO VOUT being outside the range of the adjustable one, a special-use property has been added to avoid overusing the constraints.
Hm, why exactly this is not a bool property? What are the benefits?
Best regards,
Krzysztof

As only the user will know the exact fixed voltage,
the property is defined as a u32 to allow user customization and decision-making.

Thanks,
Alina

Mark Brown

maintainer

2024-05-22 11:35 UTC #10 lore raw

Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

In reply to Krzysztof Kozlowski

Quoted 6 lines · Krzysztof Kozlowski

Quoted 2 lines · Alina Yu
Due to the fixed LDO VOUT being outside the range of the adjustable one, a special-use property has been added to avoid overusing the constraints.
Hm, why exactly this is not a bool property? What are the benefits?

It avoids confusion between invalid constraints specified on the variable voltage regulator and allows us to validate any constraints that happen to be specified (though it'd be pointless to specify constraints). The fact that the regulator could also be variable voltage is asking for confusion if we use boolean.

Krzysztof Kozlowski

Acked-by

2024-05-22 13:29 UTC #11 lore raw

Re: [PATCH 2/2] regulator: dt-bindings: rtq2208: Add specified fixed LDO VOUT property

Quoted 6 lines · Mark Brown

Quoted 4 lines · Krzysztof Kozlowski
Quoted 2 lines · Alina Yu
Due to the fixed LDO VOUT being outside the range of the adjustable one, a special-use property has been added to avoid overusing the constraints.

Quoted 7 lines

Quoted 1 line
Hm, why exactly this is not a bool property? What are the benefits?
It avoids confusion between invalid constraints specified on the variable voltage regulator and allows us to validate any constraints that happen to be specified (though it'd be pointless to specify constraints). The fact that the regulator could also be variable voltage is asking for confusion if we use boolean.

Acked-by Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

Mark Brown

maintainer

2024-05-27 13:00 UTC #2 lore raw

Re: [PATCH 1/2] regulator: rtq2208: Add fixed LDO VOUT property and check that matches the constraints

In reply to Alina Yu

Quoted 3 lines · Alina Yu

A fixed LDO VOUT property has been added to specify the fixed_uV of the regulator_desc. Additionally, a check has been included in this version
to ensure that the fixed_uV matches the constraints.

This doesn't apply against current code, please check and resend.

Alina Yu

author

2024-05-28 06:07 UTC #3 lore raw

Re: [PATCH 1/2] regulator: rtq2208: Add fixed LDO VOUT property and check that matches the constraints

Quoted 6 lines · Mark Brown

Quoted 3 lines · Alina Yu
A fixed LDO VOUT property has been added to specify the fixed_uV of the regulator_desc. Additionally, a check has been included in this version
to ensure that the fixed_uV matches the constraints.
This doesn't apply against current code, please check and resend.

Sorry, I didn't notice these links missed in linux-next tree:

https://lore.kernel.org/all/a1e19b4026d7fea27526ba94c398500a3826b282.1714467553.git.alina_yu@richtek.com/

https://lore.kernel.org/all/ffeecd61c194df1f7f049bd50cb2bbbad3cf1025.1714467553.git.alina_yu@richtek.com/

I have now integrated these missing parts into the resent patches.

Thanks,
Alina

Alina Yu

author

2024-05-29 06:51 UTC #4 lore raw

Re: [PATCH 1/2] regulator: rtq2208: Add fixed LDO VOUT property and check that matches the constraints

In reply to Mark Brown

Quoted 6 lines · Mark Brown

Quoted 3 lines · Alina Yu
A fixed LDO VOUT property has been added to specify the fixed_uV of the regulator_desc. Additionally, a check has been included in this version
to ensure that the fixed_uV matches the constraints.
This doesn't apply against current code, please check and resend.

Regarding the previous discussion in

https://lore.kernel.org/all/[email protected]/

I found some patches missing in the linux-next tree.

So I merged the missing part in my latest resent sereies.

The issue has been addressed in

In '[RESEND 2/4] regulator: rtq2208: Fix LDO to be compatible with both fixed and adjustable vout'
https://lore.kernel.org/all/5ad4c7728c7fa7f6286db36b99d31c9d0f5d16c7.1716870419.git.alina_yu@richtek.com/

@@ -219,7 +219,7 @@ static const struct regulator_ops rtq2208_regulator_buck_ops = {
.set_suspend_mode = rtq2208_set_suspend_mode,
};

-static const struct regulator_ops rtq2208_regulator_ldo_ops = { +static const struct regulator_ops rtq2208_regulator_ldo_fix_ops = {
.enable = regulator_enable_regmap,
.disable = regulator_disable_regmap,
.is_enabled = regulator_is_enabled_regmap,

...

Thanks,
Alina