Skip to contentSkip to conversation

Spreadtrum SC2731 MFD cleanups

PATCH Applied Stanislav Jakubek 3 participants 8 messages Jul 14, 2024 – Aug 16, 2024

Subsystems (2)
Device tree bindings Arm/spreadtrum SoC support
lore
Share & tools
lore

Stanislav Jakubek

author
#0 lore raw

cover Spreadtrum SC2731 MFD cleanups

This series is a preparation for converting the SC27xx PMIC MFD bindings to DT schema.

Stanislav Jakubek (2):
arm64: dts: sprd: sc2731: correct interrupt-cells value to 2
arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

 arch/arm64/boot/dts/sprd/sc2731.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Signature · 1 line
2.34.1
author
#1 lore raw

PATCH 1/2 arm64: dts: sprd: sc2731: correct interrupt-cells value to 2

According to the DT bindings, SC2731's #interrupt-cells should have a value of 2. Correct it as such.

Signed-off-by Stanislav Jakubek <[email protected]>
---
 arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/sprd/sc2731.dtsi +1 -1
index e15409f55f43..7e55b2b31c84 100644
@@ -13,7 +13,7 @@ sc2731_pmic: pmic@0 {
 		spi-max-frequency = <26000000>;
 		interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>;
 		interrupt-controller;
-		#interrupt-cells = <1>;
+		#interrupt-cells = <2>;
 		#address-cells = <1>;
 		#size-cells = <0>;
Signature · 1 line
2.34.1
author
#2 lore raw

Re: [PATCH 1/2] arm64: dts: sprd: sc2731: correct interrupt-cells value to 2

Hi all,

you can most likely disregard this patch, according to [1], the correct value is actually 1. I'll fix up the bindings during conversion, which I'll be sending soon.

The second patch should be good.

Sorry for the noise,
Stanislav

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm64/boot/dts/sprd/sc2731.dtsi?h=v6.9&id=5863dbe071caabe752ce6f9f6782fa03914527ab

author
#3 lore raw

PATCH 2/2 arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

In reply to Stanislav Jakubek

According to DT spec, node names should be generic. Rename the sprd,sc2731-fgu node to a more generic "fuel-gauge".

Signed-off-by Stanislav Jakubek <[email protected]>
---
 arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/sprd/sc2731.dtsi +1 -1
index 7e55b2b31c84..48b681768f6e 100644
@@ -95,7 +95,7 @@ pmic_adc: adc@480 {
 			nvmem-cells = <&adc_big_scale>, <&adc_small_scale>;
 		};
 
-		fgu@a00 {
+		fuel-gauge@a00 {
 			compatible = "sprd,sc2731-fgu";
 			reg = <0xa00>;
 			bat-detect-gpio = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
Signature · 1 line
2.34.1
Reviewed-by on v1 2/2
#4 lore raw

Re: [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

Quoted 4 lines · Stanislav Jakubek

According to DT spec, node names should be generic. Rename the sprd,sc2731-fgu node to a more generic "fuel-gauge".

Signed-off-by Stanislav Jakubek <[email protected]>

LGTM. Thanks.

Reviewed-by Baolin Wang <[email protected]>
Quoted 17 lines
---
  arch/arm64/boot/dts/sprd/sc2731.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/sprd/sc2731.dtsi +1 -1
index 7e55b2b31c84..48b681768f6e 100644
@@ -95,7 +95,7 @@ pmic_adc: adc@480 {
  			nvmem-cells = <&adc_big_scale>, <&adc_small_scale>;
  		};
 
-		fgu@a00 {
+		fuel-gauge@a00 {
  			compatible = "sprd,sc2731-fgu";
  			reg = <0xa00>;
  			bat-detect-gpio = <&pmic_eic 9 GPIO_ACTIVE_HIGH>;
Applied
#5 lore raw

Re: (subset) [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

In reply to Stanislav Jakubek
Quoted 4 lines · Stanislav Jakubek

According to DT spec, node names should be generic. Rename the sprd,sc2731-fgu node to a more generic "fuel-gauge".

This also waits for something... so I grabbed it.

Applied, thanks!

[2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

      https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
author
#6 lore raw

Re: (subset) [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · Stanislav Jakubek

According to DT spec, node names should be generic. Rename the sprd,sc2731-fgu node to a more generic "fuel-gauge".

Quoted 10 lines

This also waits for something... so I grabbed it.

Applied, thanks!

[2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

      https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>

Hi Krzysztof,

you already applied this change as part of [1].

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit?id=0dcc203956537696e6f936eef886fde70e049f54

Cheers,
Stanislav

#7 lore raw

Re: (subset) [PATCH 2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

Quoted 19 lines · Stanislav Jakubek
Quoted 7 lines · Krzysztof Kozlowski
Quoted 4 lines · Stanislav Jakubek

According to DT spec, node names should be generic. Rename the sprd,sc2731-fgu node to a more generic "fuel-gauge".

Quoted 10 lines

This also waits for something... so I grabbed it.

Applied, thanks!

[2/2] arm64: dts: sprd: sc2731: rename fuel gauge node to be generic

      https://git.kernel.org/krzk/linux-dt/c/e06e908dba9fed62c9493ea5cea2e4cbd306d23c

Best regards,

Signature · 1 line
Krzysztof Kozlowski <[email protected]>
Quoted 5 lines

Hi Krzysztof,

you already applied this change as part of [1].

https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit?id=0dcc203956537696e6f936eef886fde70e049f54

Indeed, thanks. I managed to double-apply because somehow how got impression that was arm32, not arm64.

Best regards,
Krzysztof